[INFO] fetching crate mysql-common-derive 0.31.1... [INFO] checking mysql-common-derive-0.31.1 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate mysql-common-derive 0.31.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate mysql-common-derive 0.31.1 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mysql-common-derive 0.31.1 [INFO] finished tweaking crates.io crate mysql-common-derive 0.31.1 [INFO] tweaked toml for crates.io crate mysql-common-derive 0.31.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 46 packages to latest compatible versions [INFO] [stderr] Adding heck v0.4.1 (available: v0.5.0) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f2fab4948e33d5a1e91578883b49058b4fa9c44f8514aed46c01ca80238ac9ac [INFO] running `Command { std: "docker" "start" "-a" "f2fab4948e33d5a1e91578883b49058b4fa9c44f8514aed46c01ca80238ac9ac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f2fab4948e33d5a1e91578883b49058b4fa9c44f8514aed46c01ca80238ac9ac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f2fab4948e33d5a1e91578883b49058b4fa9c44f8514aed46c01ca80238ac9ac", kill_on_drop: false }` [INFO] [stdout] f2fab4948e33d5a1e91578883b49058b4fa9c44f8514aed46c01ca80238ac9ac [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 973fabed6d9f913247278f536ac9fad1dc25073f39b19e7e045d55ec335eeaba [INFO] running `Command { std: "docker" "start" "-a" "973fabed6d9f913247278f536ac9fad1dc25073f39b19e7e045d55ec335eeaba", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling strsim v0.11.1 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking winnow v0.6.20 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling thiserror v1.0.64 [INFO] [stderr] Checking syn v1.0.109 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling serde_json v1.0.128 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking heck v0.4.1 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking toml_edit v0.22.22 [INFO] [stderr] Checking darling_core v0.20.10 [INFO] [stderr] Checking proc-macro-crate v3.2.0 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Checking darling v0.20.10 [INFO] [stderr] Checking mysql-common-derive v0.31.1 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `mysql_common_derive` [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/lib.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 22 | Ok(gen) => gen.into(), [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/from_row/structs/attrs/container.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error: mismatched closing delimiter: `)` [INFO] [stderr] --> src/from_row/structs/attrs/container.rs:17:15 [INFO] [stderr] | [INFO] [stderr] 17 | #[darling({ default => match _ => )] [INFO] [stderr] | -^ ^ mismatched closing delimiter [INFO] [stderr] | || [INFO] [stderr] | |unclosed delimiter [INFO] [stderr] | closing delimiter possibly meant for this [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/lib.rs:22:20 [INFO] [stdout] | [INFO] [stdout] 22 | Ok(gen) => gen.into(), [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/lib.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 33 | Ok(gen) => gen.into(), [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/lib.rs:33:20 [INFO] [stdout] | [INFO] [stdout] 33 | Ok(gen) => gen.into(), [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/from_row/structs/mod.rs:178:35 [INFO] [stdout] | [INFO] [stdout] 178 | let try_from = if let Some(ref path) = attrs.with { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^---------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/from_row/structs/mod.rs:181:17 [INFO] [stdout] | [INFO] [stdout] 181 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 178 ~ let try_from = match attrs.with { Some(ref path) => { [INFO] [stdout] 179 | let path = &path.0; [INFO] [stdout] 180 | quote::quote!( #path(x) ) [INFO] [stdout] 181 ~ } _ => { [INFO] [stdout] 182 | quote::quote!( <#intermediate_ty as std::convert::TryFrom>::try_from(x) ) [INFO] [stdout] 183 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/from_row/structs/attrs/container.rs:17:15 [INFO] [stdout] | [INFO] [stdout] 17 | #[darling(default)] [INFO] [stdout] | _______________^ [INFO] [stdout] 18 | | pub bound: Option, [INFO] [stdout] | |_____________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/from_row/structs/attrs/container.rs:17:21 [INFO] [stdout] | [INFO] [stdout] 17 | #[darling(default)] [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 17 | #[darling(match { default => _ => })] [INFO] [stdout] | +++++ ++++++++++++ ~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/from_row/structs/attrs/field.rs:12:15 [INFO] [stdout] | [INFO] [stdout] 12 | #[darling(default)] [INFO] [stdout] | _______________^ [INFO] [stdout] 13 | | pub with: Option>, [INFO] [stdout] | |____________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/from_row/structs/attrs/field.rs:12:21 [INFO] [stdout] | [INFO] [stdout] 12 | #[darling(default)] [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 12 | #[darling(match { default => _ => })] [INFO] [stdout] | +++++ ++++++++++++ ~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/from_value/structs/mod.rs:121:29 [INFO] [stdout] | [INFO] [stdout] 121 | let new_tokens = if let Some(x) = &self.item_attrs.deserialize_with { [INFO] [stdout] | ^^^^^^^^^^^^^^^-------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/from_value/structs/mod.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 151 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 121 ~ let new_tokens = match &self.item_attrs.deserialize_with { Some(x) => { [INFO] [stdout] 122 | let path = &x.0; [INFO] [stdout] ... [INFO] [stdout] 150 | ) [INFO] [stdout] 151 ~ } _ => { [INFO] [stdout] 152 | quote::quote!( [INFO] [stdout] ... [INFO] [stdout] 191 | ) [INFO] [stdout] 192 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/from_value/structs/mod.rs:271:29 [INFO] [stdout] | [INFO] [stdout] 271 | let new_tokens = if let Some(x) = &self.item_attrs.deserialize_with { [INFO] [stdout] | ^^^^^^^^^^^^^^^-------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/from_value/structs/mod.rs:297:9 [INFO] [stdout] | [INFO] [stdout] 297 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 271 ~ let new_tokens = match &self.item_attrs.deserialize_with { Some(x) => { [INFO] [stdout] 272 | let path = &x.0; [INFO] [stdout] ... [INFO] [stdout] 296 | ) [INFO] [stdout] 297 ~ } _ => { [INFO] [stdout] 298 | quote::quote!( [INFO] [stdout] ... [INFO] [stdout] 341 | ) [INFO] [stdout] 342 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/from_value/structs/attrs/container.rs:13:15 [INFO] [stdout] | [INFO] [stdout] 13 | #[darling(default)] [INFO] [stdout] | _______________^ [INFO] [stdout] 14 | | pub bound: Option, [INFO] [stdout] | |_____________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/from_value/structs/attrs/container.rs:13:21 [INFO] [stdout] | [INFO] [stdout] 13 | #[darling(default)] [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 13 | #[darling(match { default => _ => })] [INFO] [stdout] | +++++ ++++++++++++ ~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/from_value/structs/attrs/container.rs:15:15 [INFO] [stdout] | [INFO] [stdout] 15 | #[darling(default)] [INFO] [stdout] | _______________^ [INFO] [stdout] 16 | | pub deserialize_with: Option>, [INFO] [stdout] | |________________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/from_value/structs/attrs/container.rs:15:21 [INFO] [stdout] | [INFO] [stdout] 15 | #[darling(default)] [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 15 | #[darling(match { default => _ => })] [INFO] [stdout] | +++++ ++++++++++++ ~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/from_value/structs/attrs/container.rs:17:15 [INFO] [stdout] | [INFO] [stdout] 17 | #[darling(default)] [INFO] [stdout] | _______________^ [INFO] [stdout] 18 | | pub serialize_with: Option>, [INFO] [stdout] | |______________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/from_value/structs/attrs/container.rs:17:21 [INFO] [stdout] | [INFO] [stdout] 17 | #[darling(default)] [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 17 | #[darling(match { default => _ => })] [INFO] [stdout] | +++++ ++++++++++++ ~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `mysql_common_derive` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/from_row/structs/attrs/container.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error: mismatched closing delimiter: `)` [INFO] [stderr] --> src/from_row/structs/attrs/container.rs:17:15 [INFO] [stderr] | [INFO] [stderr] 17 | #[darling({ default => match _ => )] [INFO] [stderr] | -^ ^ mismatched closing delimiter [INFO] [stderr] | || [INFO] [stderr] | |unclosed delimiter [INFO] [stderr] | closing delimiter possibly meant for this [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/lib.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 22 | Ok(gen) => gen.into(), [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/lib.rs:22:20 [INFO] [stdout] | [INFO] [stdout] 22 | Ok(gen) => gen.into(), [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/lib.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 33 | Ok(gen) => gen.into(), [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/lib.rs:33:20 [INFO] [stdout] | [INFO] [stdout] 33 | Ok(gen) => gen.into(), [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/from_row/structs/mod.rs:178:35 [INFO] [stdout] | [INFO] [stdout] 178 | let try_from = if let Some(ref path) = attrs.with { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^---------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/from_row/structs/mod.rs:181:17 [INFO] [stdout] | [INFO] [stdout] 181 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 178 ~ let try_from = match attrs.with { Some(ref path) => { [INFO] [stdout] 179 | let path = &path.0; [INFO] [stdout] 180 | quote::quote!( #path(x) ) [INFO] [stdout] 181 ~ } _ => { [INFO] [stdout] 182 | quote::quote!( <#intermediate_ty as std::convert::TryFrom>::try_from(x) ) [INFO] [stdout] 183 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/from_row/structs/attrs/container.rs:17:15 [INFO] [stdout] | [INFO] [stdout] 17 | #[darling(default)] [INFO] [stdout] | _______________^ [INFO] [stdout] 18 | | pub bound: Option, [INFO] [stdout] | |_____________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/from_row/structs/attrs/container.rs:17:21 [INFO] [stdout] | [INFO] [stdout] 17 | #[darling(default)] [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 17 | #[darling(match { default => _ => })] [INFO] [stdout] | +++++ ++++++++++++ ~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/from_row/structs/attrs/field.rs:12:15 [INFO] [stdout] | [INFO] [stdout] 12 | #[darling(default)] [INFO] [stdout] | _______________^ [INFO] [stdout] 13 | | pub with: Option>, [INFO] [stdout] | |____________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/from_row/structs/attrs/field.rs:12:21 [INFO] [stdout] | [INFO] [stdout] 12 | #[darling(default)] [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 12 | #[darling(match { default => _ => })] [INFO] [stdout] | +++++ ++++++++++++ ~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/from_value/structs/mod.rs:121:29 [INFO] [stdout] | [INFO] [stdout] 121 | let new_tokens = if let Some(x) = &self.item_attrs.deserialize_with { [INFO] [stdout] | ^^^^^^^^^^^^^^^-------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/from_value/structs/mod.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 151 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 121 ~ let new_tokens = match &self.item_attrs.deserialize_with { Some(x) => { [INFO] [stdout] 122 | let path = &x.0; [INFO] [stdout] ... [INFO] [stdout] 150 | ) [INFO] [stdout] 151 ~ } _ => { [INFO] [stdout] 152 | quote::quote!( [INFO] [stdout] ... [INFO] [stdout] 191 | ) [INFO] [stdout] 192 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/from_value/structs/mod.rs:271:29 [INFO] [stdout] | [INFO] [stdout] 271 | let new_tokens = if let Some(x) = &self.item_attrs.deserialize_with { [INFO] [stdout] | ^^^^^^^^^^^^^^^-------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/from_value/structs/mod.rs:297:9 [INFO] [stdout] | [INFO] [stdout] 297 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 271 ~ let new_tokens = match &self.item_attrs.deserialize_with { Some(x) => { [INFO] [stdout] 272 | let path = &x.0; [INFO] [stdout] ... [INFO] [stdout] 296 | ) [INFO] [stdout] 297 ~ } _ => { [INFO] [stdout] 298 | quote::quote!( [INFO] [stdout] ... [INFO] [stdout] 341 | ) [INFO] [stdout] 342 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/from_value/structs/attrs/container.rs:13:15 [INFO] [stdout] | [INFO] [stdout] 13 | #[darling(default)] [INFO] [stdout] | _______________^ [INFO] [stdout] 14 | | pub bound: Option, [INFO] [stdout] | |_____________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/from_value/structs/attrs/container.rs:13:21 [INFO] [stdout] | [INFO] [stdout] 13 | #[darling(default)] [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 13 | #[darling(match { default => _ => })] [INFO] [stdout] | +++++ ++++++++++++ ~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/from_value/structs/attrs/container.rs:15:15 [INFO] [stdout] | [INFO] [stdout] 15 | #[darling(default)] [INFO] [stdout] | _______________^ [INFO] [stdout] 16 | | pub deserialize_with: Option>, [INFO] [stdout] | |________________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/from_value/structs/attrs/container.rs:15:21 [INFO] [stdout] | [INFO] [stdout] 15 | #[darling(default)] [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 15 | #[darling(match { default => _ => })] [INFO] [stdout] | +++++ ++++++++++++ ~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/from_value/structs/attrs/container.rs:17:15 [INFO] [stdout] | [INFO] [stdout] 17 | #[darling(default)] [INFO] [stdout] | _______________^ [INFO] [stdout] 18 | | pub serialize_with: Option>, [INFO] [stdout] | |______________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/from_value/structs/attrs/container.rs:17:21 [INFO] [stdout] | [INFO] [stdout] 17 | #[darling(default)] [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 17 | #[darling(match { default => _ => })] [INFO] [stdout] | +++++ ++++++++++++ ~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.24s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking mysql-common-derive v0.31.1 (/tmp/fixit) [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/lib.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 22 | Ok(gen) => gen.into(), [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 22 | Ok(r#gen) => gen.into(), [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/lib.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 22 | Ok(gen) => gen.into(), [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 22 | Ok(r#gen) => gen.into(), [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected expression, found reserved keyword `gen` [INFO] [stdout] --> src/lib.rs:22:20 [INFO] [stdout] | [INFO] [stdout] 22 | Ok(gen) => gen.into(), [INFO] [stdout] | -- ^^^ expected expression [INFO] [stdout] | | [INFO] [stdout] | while parsing the `match` arm starting here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected expression, found reserved keyword `gen` [INFO] [stdout] --> src/lib.rs:22:20 [INFO] [stdout] | [INFO] [stdout] 22 | Ok(gen) => gen.into(), [INFO] [stdout] | -- ^^^ expected expression [INFO] [stdout] | | [INFO] [stdout] | while parsing the `match` arm starting here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/lib.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 33 | Ok(gen) => gen.into(), [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 33 | Ok(r#gen) => gen.into(), [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected expression, found reserved keyword `gen` [INFO] [stdout] --> src/lib.rs:33:20 [INFO] [stdout] | [INFO] [stdout] 33 | Ok(gen) => gen.into(), [INFO] [stdout] | -- ^^^ expected expression [INFO] [stdout] | | [INFO] [stdout] | while parsing the `match` arm starting here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/lib.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 33 | Ok(gen) => gen.into(), [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 33 | Ok(r#gen) => gen.into(), [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected expression, found reserved keyword `gen` [INFO] [stdout] --> src/lib.rs:33:20 [INFO] [stdout] | [INFO] [stdout] 33 | Ok(gen) => gen.into(), [INFO] [stdout] | -- ^^^ expected expression [INFO] [stdout] | | [INFO] [stdout] | while parsing the `match` arm starting here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `proc_macro_error::abort` [INFO] [stdout] --> src/lib.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use proc_macro_error::abort; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `proc_macro_error::abort` [INFO] [stdout] --> src/lib.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use proc_macro_error::abort; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mysql-common-derive` (lib test) due to 5 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mysql-common-derive` (lib) due to 5 previous errors; 1 warning emitted [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "973fabed6d9f913247278f536ac9fad1dc25073f39b19e7e045d55ec335eeaba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "973fabed6d9f913247278f536ac9fad1dc25073f39b19e7e045d55ec335eeaba", kill_on_drop: false }` [INFO] [stdout] 973fabed6d9f913247278f536ac9fad1dc25073f39b19e7e045d55ec335eeaba