[INFO] fetching crate mozrunner 0.15.3... [INFO] checking mozrunner-0.15.3 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate mozrunner 0.15.3 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate mozrunner 0.15.3 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mozrunner 0.15.3 [INFO] finished tweaking crates.io crate mozrunner 0.15.3 [INFO] tweaked toml for crates.io crate mozrunner 0.15.3 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate mozrunner 0.15.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5970626a1f0d2ae63f4acdaa90166517f4691f7d283d4ce7208bf557ed25f1fd [INFO] running `Command { std: "docker" "start" "-a" "5970626a1f0d2ae63f4acdaa90166517f4691f7d283d4ce7208bf557ed25f1fd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5970626a1f0d2ae63f4acdaa90166517f4691f7d283d4ce7208bf557ed25f1fd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5970626a1f0d2ae63f4acdaa90166517f4691f7d283d4ce7208bf557ed25f1fd", kill_on_drop: false }` [INFO] [stdout] 5970626a1f0d2ae63f4acdaa90166517f4691f7d283d4ce7208bf557ed25f1fd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 84cc20925371da79191c8c913bb3dd222d1b7cc147b105a278169ed3d50bb074 [INFO] running `Command { std: "docker" "start" "-a" "84cc20925371da79191c8c913bb3dd222d1b7cc147b105a278169ed3d50bb074", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling unicode-ident v1.0.6 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking itoa v1.0.5 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking quick-xml v0.32.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.68 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking plist v1.7.0 [INFO] [stderr] Checking mozprofile v0.9.3 [INFO] [stderr] Checking mozrunner v0.15.3 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `mozrunner` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/runner.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error: usage of an `unsafe` block [INFO] [stderr] --> src/runner.rs:346:40 [INFO] [stderr] | [INFO] [stderr] 346 | Some(value) => unsafe { env::set_var(key, value) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: the lint level is defined here [INFO] [stderr] --> src/lib.rs:1:11 [INFO] [stderr] | [INFO] [stderr] 1 | #![forbid(unsafe_code)] [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: usage of an `unsafe` block [INFO] [stderr] --> src/runner.rs:348:33 [INFO] [stderr] | [INFO] [stderr] 348 | None => unsafe { env::remove_var(key) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/runner.rs:345:40 [INFO] [stdout] | [INFO] [stdout] 345 | Some(value) => env::set_var(key, value), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] = note: `--force-warn deprecated-safe-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 345 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 346 ~ Some(value) => unsafe { env::set_var(key, value) }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to deprecated safe function `std::env::remove_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/runner.rs:346:33 [INFO] [stdout] | [INFO] [stdout] 346 | None => env::remove_var(key), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 346 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 347 ~ None => unsafe { env::remove_var(key) }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/firefox_args.rs:221:12 [INFO] [stdout] | [INFO] [stdout] 221 | if let Some((None, value)) = parsed_args.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^-----------^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/firefox_args.rs:223:9 [INFO] [stdout] | [INFO] [stdout] 223 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 221 ~ match parsed_args.next() { Some((None, value)) => { [INFO] [stdout] 222 | found_value = value.clone(); [INFO] [stdout] 223 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Fixed src/firefox_args.rs (1 fix) [INFO] [stderr] Migrating src/bin/firefox-default-path.rs from 2021 edition to 2024 [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.03s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking mozrunner v0.15.3 (/tmp/fixit) [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/runner.rs:345:40 [INFO] [stdout] | [INFO] [stdout] 345 | Some(value) => env::set_var(key, value), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `remove_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/runner.rs:346:33 [INFO] [stdout] | [INFO] [stdout] 346 | None => env::remove_var(key), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stderr] error: could not compile `mozrunner` (lib test) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "84cc20925371da79191c8c913bb3dd222d1b7cc147b105a278169ed3d50bb074", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "84cc20925371da79191c8c913bb3dd222d1b7cc147b105a278169ed3d50bb074", kill_on_drop: false }` [INFO] [stdout] 84cc20925371da79191c8c913bb3dd222d1b7cc147b105a278169ed3d50bb074