[INFO] fetching crate minotp 1.1.0... [INFO] checking minotp-1.1.0 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate minotp 1.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate minotp 1.1.0 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate minotp 1.1.0 [INFO] finished tweaking crates.io crate minotp 1.1.0 [INFO] tweaked toml for crates.io crate minotp 1.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 49 packages to latest compatible versions [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding windows-core v0.52.0 (available: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3b622e59b569b453164f1e2bf8bd3e85bb988c90f4db0dde425457731337a3b7 [INFO] running `Command { std: "docker" "start" "-a" "3b622e59b569b453164f1e2bf8bd3e85bb988c90f4db0dde425457731337a3b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3b622e59b569b453164f1e2bf8bd3e85bb988c90f4db0dde425457731337a3b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3b622e59b569b453164f1e2bf8bd3e85bb988c90f4db0dde425457731337a3b7", kill_on_drop: false }` [INFO] [stdout] 3b622e59b569b453164f1e2bf8bd3e85bb988c90f4db0dde425457731337a3b7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a54e7ae6c4c42f02b005d2a80d1c29e12ed142c5139212a14a03d0c2bd28a0d1 [INFO] running `Command { std: "docker" "start" "-a" "a54e7ae6c4c42f02b005d2a80d1c29e12ed142c5139212a14a03d0c2bd28a0d1", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking keccak v0.1.5 [INFO] [stderr] Checking data-encoding v2.6.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking minotp v1.1.0 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Fixed src/hotp.rs (1 fix) [INFO] [stderr] Fixed src/lib.rs (6 fixes) [INFO] [stderr] Fixed src/totp.rs (2 fixes) [INFO] [stderr] Migrating tests/tests.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `tests` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> tests/tests.rs:31:80 [INFO] [stdout] | [INFO] [stdout] 31 | test_hotp!(hotp_sha1_digit8_generic, Sha1, b"98u9U9u(bu(*u(*y89b(b8g", 0x45EE, gen, 97147126, params: [8]); [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] * tests/tests.rs [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> tests/tests.rs:32:81 [INFO] [stdout] | [INFO] [stdout] 32 | test_hotp!(hotp_sha1_digit10_generic, Sha1, b"98u9U9u(bu(*u(*y89b(b8g", 0x45EE, gen, 997147126, params: [10]); [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> tests/tests.rs:10:39 [INFO] [stdout] | [INFO] [stdout] 10 | ($fn_name:ident, $alg:ty, $secret:expr, $counter:expr, $call:ident, $exp:expr $(, params: [$($param:expr),*])?) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 10 | ($fn_name:ident, $alg:ty, $secret:expr_2021, $counter:expr, $call:ident, $exp:expr $(, params: [$($param:expr),*])?) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> tests/tests.rs:10:54 [INFO] [stdout] | [INFO] [stdout] 10 | ($fn_name:ident, $alg:ty, $secret:expr, $counter:expr, $call:ident, $exp:expr $(, params: [$($param:expr),*])?) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 10 | ($fn_name:ident, $alg:ty, $secret:expr, $counter:expr_2021, $call:ident, $exp:expr $(, params: [$($param:expr),*])?) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> tests/tests.rs:10:78 [INFO] [stdout] | [INFO] [stdout] 10 | ($fn_name:ident, $alg:ty, $secret:expr, $counter:expr, $call:ident, $exp:expr $(, params: [$($param:expr),*])?) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 10 | ($fn_name:ident, $alg:ty, $secret:expr, $counter:expr, $call:ident, $exp:expr_2021 $(, params: [$($param:expr),*])?) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> tests/tests.rs:10:105 [INFO] [stdout] | [INFO] [stdout] 10 | ($fn_name:ident, $alg:ty, $secret:expr, $counter:expr, $call:ident, $exp:expr $(, params: [$($param:expr),*])?) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 10 | ($fn_name:ident, $alg:ty, $secret:expr, $counter:expr, $call:ident, $exp:expr $(, params: [$($param:expr_2021),*])?) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stdout] warning: 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> tests/tests.rs:10:31 [INFO] [stderr] | [INFO] [stderr] 10 | ($fn_name:ident, $alg:ty, $secret:expr_2021, $counter:expr_2021, $call:ident, $exp:expr_2021 $(, params: [$($param:expr_2021),*])?) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> tests/tests.rs:10:50 [INFO] [stderr] | [INFO] [stderr] 10 | ($fn_name:ident, $alg:ty, $secret:expr_2021, $counter:expr_2021, $call:ident, $exp:expr_2021 $(, params: [$($param:expr_2021),*])?) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> tests/tests.rs:10:83 [INFO] [stderr] | [INFO] [stderr] 10 | ($fn_name:ident, $alg:ty, $secret:expr_2021, $counter:expr_2021, $call:ident, $exp:expr_2021 $(, params: [$($param:expr_2021),*])?) => { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> tests/tests.rs:10:113 [INFO] [stderr] | [INFO] [stderr] 10 | ($fn_name:ident, $alg:ty, $secret:expr_2021, $counter:expr_2021, $call:ident, $exp:expr_2021 $(, params: [$($param:expr_2021),*])?) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.49s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking minotp v1.1.0 (/tmp/fixit) [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> tests/tests.rs:15:29 [INFO] [stdout] | [INFO] [stdout] 15 | assert_eq!(hotp.$call($($($param,)*)?), $exp); [INFO] [stdout] | ^^^^^ expected identifier, found reserved keyword [INFO] [stdout] ... [INFO] [stdout] 31 | test_hotp!(hotp_sha1_digit8_generic, Sha1, b"98u9U9u(bu(*u(*y89b(b8g", 0x45EE, gen, 97147126, params: [8]); [INFO] [stdout] | ---------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this error originates in the macro `test_hotp` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 31 | test_hotp!(hotp_sha1_digit8_generic, Sha1, b"98u9U9u(bu(*u(*y89b(b8g", 0x45EE, r#gen, 97147126, params: [8]); [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> tests/tests.rs:15:29 [INFO] [stdout] | [INFO] [stdout] 15 | assert_eq!(hotp.$call($($($param,)*)?), $exp); [INFO] [stdout] | ^^^^^ expected identifier, found reserved keyword [INFO] [stdout] ... [INFO] [stdout] 32 | test_hotp!(hotp_sha1_digit10_generic, Sha1, b"98u9U9u(bu(*u(*y89b(b8g", 0x45EE, gen, 997147126, params: [10]); [INFO] [stdout] | ------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this error originates in the macro `test_hotp` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 32 | test_hotp!(hotp_sha1_digit10_generic, Sha1, b"98u9U9u(bu(*u(*y89b(b8g", 0x45EE, r#gen, 997147126, params: [10]); [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `minotp` (test "tests") due to 3 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "a54e7ae6c4c42f02b005d2a80d1c29e12ed142c5139212a14a03d0c2bd28a0d1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a54e7ae6c4c42f02b005d2a80d1c29e12ed142c5139212a14a03d0c2bd28a0d1", kill_on_drop: false }` [INFO] [stdout] a54e7ae6c4c42f02b005d2a80d1c29e12ed142c5139212a14a03d0c2bd28a0d1