[INFO] fetching crate memory-cache-rust 0.1.0-alpha... [INFO] checking memory-cache-rust-0.1.0-alpha against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate memory-cache-rust 0.1.0-alpha into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate memory-cache-rust 0.1.0-alpha on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate memory-cache-rust 0.1.0-alpha [INFO] finished tweaking crates.io crate memory-cache-rust 0.1.0-alpha [INFO] tweaked toml for crates.io crate memory-cache-rust 0.1.0-alpha written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 128 packages to latest compatible versions [INFO] [stderr] Adding ahash v0.7.8 (available: v0.8.11) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding clap v2.34.0 (available: v4.5.18) [INFO] [stderr] Adding criterion v0.3.6 (available: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.4.5 (available: v0.5.0) [INFO] [stderr] Adding crossbeam v0.3.2 (available: v0.8.4) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding half v1.8.3 (available: v2.4.1) [INFO] [stderr] Adding hashbrown v0.13.2 (available: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (available: v0.4.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding rand v0.3.23 (available: v0.8.5) [INFO] [stderr] Adding rand v0.4.6 (available: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (available: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (available: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (available: v0.8.3) [INFO] [stderr] Adding seize v0.2.5 (available: v0.4.5) [INFO] [stderr] Adding textwrap v0.11.0 (available: v0.16.1) [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (available: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f0bea783237fc992a927c9f0dee5ec8da43f00b89f8e1a8fa85cbc6c3c4fd9c2 [INFO] running `Command { std: "docker" "start" "-a" "f0bea783237fc992a927c9f0dee5ec8da43f00b89f8e1a8fa85cbc6c3c4fd9c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f0bea783237fc992a927c9f0dee5ec8da43f00b89f8e1a8fa85cbc6c3c4fd9c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f0bea783237fc992a927c9f0dee5ec8da43f00b89f8e1a8fa85cbc6c3c4fd9c2", kill_on_drop: false }` [INFO] [stdout] f0bea783237fc992a927c9f0dee5ec8da43f00b89f8e1a8fa85cbc6c3c4fd9c2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5e029f00273fa39e4c045fd8cd202dd2fe798d6faf38159cdd2abeb18e2fa9b6 [INFO] running `Command { std: "docker" "start" "-a" "5e029f00273fa39e4c045fd8cd202dd2fe798d6faf38159cdd2abeb18e2fa9b6", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Fixed Cargo.toml (1 fix) [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling serde_json v1.0.128 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling ahash v0.7.8 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Checking iana-time-zone v0.1.61 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking cpufeatures v0.2.14 [INFO] [stderr] Checking plotters-backend v0.3.7 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking plotters-svg v0.3.7 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking crossbeam v0.3.2 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking concache v0.2.1 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking seize v0.2.5 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking libmath v0.2.1 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking timer v0.2.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking xxhash-rust v0.8.12 [INFO] [stderr] Checking syncpool v0.1.6 [INFO] [stderr] Checking seahash v4.1.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling uuid-macro-internal v1.10.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking hashbrown v0.13.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking aes-prng v0.2.1 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking memory-cache-rust v0.1.0-alpha (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Checking criterion v0.3.6 [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/cmsketch.rs:32:29 [INFO] [stdout] | [INFO] [stdout] 32 | let source = raange.gen::(); [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `memory_cache_rust` [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/cache.rs:28:10 [INFO] [stdout] | [INFO] [stdout] 28 | ($n: expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 28 | ($n: expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/bloom/bbloom.rs [INFO] [stderr] * src/bloom/haskey.rs [INFO] [stderr] * src/cache.rs [INFO] [stderr] * src/policy.rs [INFO] [stderr] * src/ring.rs [INFO] [stderr] * src/store.rs [INFO] [stderr] * src/ttl.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/cache.rs:28:6 [INFO] [stderr] | [INFO] [stderr] 28 | ($n: expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ops::Deref` [INFO] [stderr] --> src/bloom/haskey.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::ops::Deref; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/ttl.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 94 | break; [INFO] [stderr] | ----- any code following this expression is unreachable [INFO] [stderr] 95 | [INFO] [stderr] 96 | break; [INFO] [stderr] | ^^^^^^ unreachable statement [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unreachable_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `syncpool::prelude` [INFO] [stderr] --> src/ring.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use syncpool::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Add` [INFO] [stderr] --> src/cache.rs:6:16 [INFO] [stderr] | [INFO] [stderr] 6 | use std::ops::{Add, Deref}; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `entries` is never read [INFO] [stderr] --> src/bloom/bbloom.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | let mut entries = 0; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: maybe it is overwritten before being read? [INFO] [stderr] = note: `#[warn(unused_assignments)]` on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `locs` is never read [INFO] [stderr] --> src/bloom/bbloom.rs:36:17 [INFO] [stderr] | [INFO] [stderr] 36 | let mut locs = 0; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: maybe it is overwritten before being read? [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/bloom/bbloom.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | unsafe { [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_unsafe)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/bloom/bbloom.rs:153:32 [INFO] [stderr] | [INFO] [stderr] 153 | bj.filter_set[i] = unsafe { ptr.wrapping_offset(i as isize) as u8 } [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] [INFO] [stderr] warning: function cannot return without recursing [INFO] [stderr] --> src/store.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | fn deref_mut(&mut self) -> &mut Self::Target { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing [INFO] [stderr] 72 | self [INFO] [stderr] | ---- recursive call site [INFO] [stderr] | [INFO] [stderr] = help: a `loop` may express intention better if this is on purpose [INFO] [stderr] = note: `#[warn(unconditional_recursion)]` on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `expiration` is never read [INFO] [stderr] --> src/cache.rs:592:17 [INFO] [stderr] | [INFO] [stderr] 592 | let mut expiration: Option = None; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: maybe it is overwritten before being read? [INFO] [stderr] [INFO] [stderr] warning: function cannot return without recursing [INFO] [stderr] --> src/cache.rs:742:5 [INFO] [stderr] | [INFO] [stderr] 742 | pub fn clear<'g>(&'g self, guard: &'g Guard) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing [INFO] [stderr] ... [INFO] [stderr] 761 | self.clear(guard); [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/cmsketch.rs:94:51 [INFO] [stdout] | [INFO] [stdout] 94 | s.push_str(format!("{:#02} ", (self.0[(i / 2)] >> ((i & 1) * 4)) & 0x0f).as_str()); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 94 - s.push_str(format!("{:#02} ", (self.0[(i / 2)] >> ((i & 1) * 4)) & 0x0f).as_str()); [INFO] [stdout] 94 + s.push_str(format!("{:#02} ", (self.0[i / 2] >> ((i & 1) * 4)) & 0x0f).as_str()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] | ----------------- recursive call site [INFO] [stderr] | [INFO] [stderr] = help: a `loop` may express intention better if this is on purpose [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/policy.rs:191:17 [INFO] [stderr] | [INFO] [stderr] 191 | unsafe { [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/ring.rs:46:25 [INFO] [stderr] | [INFO] [stderr] 44 | unsafe { [INFO] [stderr] | ------ because it's nested under this `unsafe` block [INFO] [stderr] 45 | let p = self.cons.load(Ordering::SeqCst, guard); [INFO] [stderr] 46 | let p = unsafe {p.as_ptr()}; [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/ring.rs:47:25 [INFO] [stderr] | [INFO] [stderr] 44 | unsafe { [INFO] [stderr] | ------ because it's nested under this `unsafe` block [INFO] [stderr] ... [INFO] [stderr] 47 | let p = unsafe {p.as_mut().unwrap()}; [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/ring.rs:49:39 [INFO] [stderr] | [INFO] [stderr] 44 | unsafe { [INFO] [stderr] | ------ because it's nested under this `unsafe` block [INFO] [stderr] ... [INFO] [stderr] 49 | if data.is_null() || !unsafe { data.deref() }.is_empty() { [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error; 15 warnings emitted [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: unreachable statement [INFO] [stdout] --> src/ttl.rs:96:13 [INFO] [stdout] | [INFO] [stdout] 94 | break; [INFO] [stdout] | ----- any code following this expression is unreachable [INFO] [stdout] 95 | [INFO] [stdout] 96 | break; [INFO] [stdout] | ^^^^^^ unreachable statement [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `syncpool::prelude` [INFO] [stdout] --> src/ring.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use syncpool::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Add` [INFO] [stdout] --> src/cache.rs:6:16 [INFO] [stdout] | [INFO] [stdout] 6 | use std::ops::{Add, Deref}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `entries` is never read [INFO] [stdout] --> src/bloom/bbloom.rs:35:17 [INFO] [stdout] | [INFO] [stdout] 35 | let mut entries = 0; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `locs` is never read [INFO] [stdout] --> src/bloom/bbloom.rs:36:17 [INFO] [stdout] | [INFO] [stdout] 36 | let mut locs = 0; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/bloom/bbloom.rs:133:9 [INFO] [stdout] | [INFO] [stdout] 133 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_unsafe)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/bloom/bbloom.rs:153:32 [INFO] [stdout] | [INFO] [stdout] 153 | bj.filter_set[i] = unsafe { ptr.wrapping_offset(i as isize) as u8 } [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::slice::from_raw_parts` is unsafe and requires unsafe block [INFO] [stdout] --> src/bloom/rutil.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | / ::std::slice::from_raw_parts( [INFO] [stdout] 9 | | (p as *const T) as *const u8, [INFO] [stdout] 10 | | ::std::mem::size_of::(), [INFO] [stdout] 11 | | ) [INFO] [stdout] | |_____^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/bloom/rutil.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | unsafe fn any_as_u8_slice(p: &T) -> &[u8] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `--force-warn unsafe-op-in-unsafe-fn` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function cannot return without recursing [INFO] [stdout] --> src/store.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 71 | fn deref_mut(&mut self) -> &mut Self::Target { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing [INFO] [stdout] 72 | self [INFO] [stdout] | ---- recursive call site [INFO] [stdout] | [INFO] [stdout] = help: a `loop` may express intention better if this is on purpose [INFO] [stdout] = note: `#[warn(unconditional_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::boxed::Box::::from_raw` is unsafe and requires unsafe block [INFO] [stdout] --> src/reclaim.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | Box::from_raw(self.0.into_inner()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/reclaim.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | pub(crate) unsafe fn into_box(self) -> Box> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::boxed::Box::::from_raw` is unsafe and requires unsafe block [INFO] [stdout] --> src/reclaim.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | Box::from_raw(self.ptr) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/reclaim.rs:100:5 [INFO] [stdout] | [INFO] [stdout] 100 | pub(crate) unsafe fn into_box(self) -> Box> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::ptr::mut_ptr::::as_ref` is unsafe and requires unsafe block [INFO] [stdout] --> src/reclaim.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 109 | self.ptr.as_ref() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/reclaim.rs:108:5 [INFO] [stdout] | [INFO] [stdout] 108 | pub(crate) unsafe fn as_ref(&self) -> Option<&'g Linked> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block [INFO] [stdout] --> src/reclaim.rs:113:10 [INFO] [stdout] | [INFO] [stdout] 113 | &*self.ptr [INFO] [stdout] | ^^^^^^^^^ dereference of raw pointer [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/reclaim.rs:112:5 [INFO] [stdout] | [INFO] [stdout] 112 | pub(crate) unsafe fn deref(&self) -> &'g Linked { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `seize::Guard::<'_>::retire` is unsafe and requires unsafe block [INFO] [stdout] --> src/reclaim.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 152 | self.retire(shared.ptr, seize::reclaim::boxed::); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/reclaim.rs:151:5 [INFO] [stdout] | [INFO] [stdout] 151 | unsafe fn retire_shared(&self, shared: Shared<'_, T>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `expiration` is never read [INFO] [stdout] --> src/cache.rs:592:17 [INFO] [stdout] | [INFO] [stdout] 592 | let mut expiration: Option = None; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function cannot return without recursing [INFO] [stdout] --> src/cache.rs:742:5 [INFO] [stdout] | [INFO] [stdout] 742 | pub fn clear<'g>(&'g self, guard: &'g Guard) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing [INFO] [stdout] ... [INFO] [stdout] 761 | self.clear(guard); [INFO] [stdout] | ----------------- recursive call site [INFO] [stdout] | [INFO] [stdout] = help: a `loop` may express intention better if this is on purpose [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/policy.rs:191:17 [INFO] [stdout] | [INFO] [stdout] 191 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/ring.rs:46:25 [INFO] [stdout] | [INFO] [stdout] 44 | unsafe { [INFO] [stdout] | ------ because it's nested under this `unsafe` block [INFO] [stdout] 45 | let p = self.cons.load(Ordering::SeqCst, guard); [INFO] [stdout] 46 | let p = unsafe {p.as_ptr()}; [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/ring.rs:47:25 [INFO] [stdout] | [INFO] [stdout] 44 | unsafe { [INFO] [stdout] | ------ because it's nested under this `unsafe` block [INFO] [stdout] ... [INFO] [stdout] 47 | let p = unsafe {p.as_mut().unwrap()}; [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/ring.rs:49:39 [INFO] [stdout] | [INFO] [stdout] 44 | unsafe { [INFO] [stdout] | ------ because it's nested under this `unsafe` block [INFO] [stdout] ... [INFO] [stdout] 49 | if data.is_null() || !unsafe { data.deref() }.is_empty() { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `size_exp` is never read [INFO] [stdout] --> src/bloom/bbloom.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct Bloom { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 19 | size_exp: u64, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `json_encoder` is never used [INFO] [stdout] --> src/bloom/bbloom.rs:145:8 [INFO] [stdout] | [INFO] [stdout] 32 | impl Bloom { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 145 | fn json_encoder(&mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `any_as_u8_slice` is never used [INFO] [stdout] --> src/bloom/rutil.rs:7:11 [INFO] [stdout] | [INFO] [stdout] 7 | unsafe fn any_as_u8_slice(p: &T) -> &[u8] { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `is_string` is never used [INFO] [stdout] --> src/bloom/hasher.rs:58:4 [INFO] [stdout] | [INFO] [stdout] 58 | fn is_string(_s: &T) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/store.rs:23:19 [INFO] [stdout] | [INFO] [stdout] 22 | impl Node { [INFO] [stdout] | --------------- associated function in this implementation [INFO] [stdout] 23 | pub(crate) fn new(key: u64, conflict: u64, value: AV, expiration: Option) -> Self [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `into_box` and `compare_exchange` are never used [INFO] [stdout] --> src/reclaim.rs:23:26 [INFO] [stdout] | [INFO] [stdout] 10 | impl Atomic { [INFO] [stdout] | ----------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 23 | pub(crate) unsafe fn into_box(self) -> Box> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 36 | pub(crate) fn compare_exchange<'g>( [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `CompareExchangeError` is never constructed [INFO] [stdout] --> src/reclaim.rs:81:19 [INFO] [stdout] | [INFO] [stdout] 81 | pub(crate) struct CompareExchangeError<'g, T> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `RetireShared` is never used [INFO] [stdout] --> src/reclaim.rs:146:18 [INFO] [stdout] | [INFO] [stdout] 146 | pub(crate) trait RetireShared { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `GuardRef` is never used [INFO] [stdout] --> src/reclaim.rs:156:17 [INFO] [stdout] | [INFO] [stdout] 156 | pub(crate) enum GuardRef<'g> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get` and `SetsDropped` are never used [INFO] [stdout] --> src/cache.rs:917:19 [INFO] [stdout] | [INFO] [stdout] 910 | impl Metrics { [INFO] [stdout] | ------------ methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 917 | pub(crate) fn get<'g>(&'g self, t: MetricType, guard: &'g Guard) -> u64 { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 931 | pub(crate) fn SetsDropped<'g>(&'g self, guard: &'g Guard) -> u64 { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `Policy` is never used [INFO] [stdout] --> src/policy.rs:16:11 [INFO] [stdout] | [INFO] [stdout] 16 | pub trait Policy { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `number_counters` and `max_cost` are never read [INFO] [stdout] --> src/policy.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 40 | pub struct DefaultPolicy { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 46 | number_counters: i64, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 47 | lock: Mutex<()>, [INFO] [stdout] 48 | max_cost: i64, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `has`, `close`, and `cap` are never used [INFO] [stdout] --> src/policy.rs:218:12 [INFO] [stdout] | [INFO] [stdout] 53 | impl DefaultPolicy { [INFO] [stdout] | ------------------------ methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 218 | pub fn has(&self, key: u64, _guard: &Guard) -> bool { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 236 | pub fn close(&mut self) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 246 | pub fn cap(&self) -> i64 { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `reset` is never used [INFO] [stdout] --> src/cmsketch.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 16 | impl CmSketch { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 58 | pub fn reset(&mut self) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `reset` and `string` are never used [INFO] [stdout] --> src/cmsketch.rs:85:8 [INFO] [stdout] | [INFO] [stdout] 71 | impl CmRows { [INFO] [stdout] | ----------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 85 | fn reset(&mut self) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 91 | fn string(&self) -> String { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `RingConsumer` is never used [INFO] [stdout] --> src/ring.rs:10:10 [INFO] [stdout] | [INFO] [stdout] 10 | pub type RingConsumer = Box) -> bool>; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `getSize` should have a snake case name [INFO] [stdout] --> src/bloom/bbloom.rs:170:4 [INFO] [stdout] | [INFO] [stdout] 170 | fn getSize(mut u_i64: u64) -> (u64, u64) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `get_size` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/bloom/haskey.rs:17:19 [INFO] [stdout] | [INFO] [stdout] 17 | let key = *key.deref(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `T` does not implement `Deref`, so calling `deref` on `&T` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/cache.rs:249:12 [INFO] [stdout] | [INFO] [stdout] 249 | if let Some(m) = &ca.metrics { [INFO] [stdout] | ^^^^^^^^^^^^^^^---------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/cache.rs:257:9 [INFO] [stdout] | [INFO] [stdout] 257 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 249 ~ match &ca.metrics { Some(m) => { [INFO] [stdout] 250 | let v: *const Metrics = &**m; [INFO] [stdout] ... [INFO] [stdout] 256 | ca.get_buf.store(table, Ordering::SeqCst); [INFO] [stdout] 257 ~ } _ => { [INFO] [stdout] 258 | let table = Shared::boxed(DefaultPolicy::new(ca.numb_counters, ca.max_cost, ptr::null()), &ca.collector); [INFO] [stdout] ... [INFO] [stdout] 262 | ca.get_buf.store(table, Ordering::SeqCst); [INFO] [stdout] 263 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/cache.rs:424:16 [INFO] [stdout] | [INFO] [stdout] 424 | if let Some(m) = &self.metrics { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/cache.rs:434:13 [INFO] [stdout] | [INFO] [stdout] 434 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 424 ~ match &self.metrics { Some(m) => { [INFO] [stdout] 425 | let v: *const Metrics = &**m; [INFO] [stdout] ... [INFO] [stdout] 433 | self.init_ringbuf(guard); [INFO] [stdout] 434 ~ } _ => { [INFO] [stdout] 435 | continue; [INFO] [stdout] 436 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/cache.rs:593:12 [INFO] [stdout] | [INFO] [stdout] 593 | if ttl.as_millis() < 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/cache.rs:659:28 [INFO] [stdout] | [INFO] [stdout] 659 | if let Some(metrics) = &self.metrics { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/cache.rs:661:25 [INFO] [stdout] | [INFO] [stdout] 661 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 659 ~ match &self.metrics { Some(metrics) => { [INFO] [stdout] 660 | metrics.add(KEY_ADD, item.key, 1, guard) [INFO] [stdout] 661 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `delVal` should have a snake case name [INFO] [stdout] --> src/cache.rs:666:29 [INFO] [stdout] | [INFO] [stdout] 666 | let delVal = dstore.del(&victims[i].key, &0, guard); [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `del_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/cache.rs:675:125 [INFO] [stdout] | [INFO] [stdout] 675 | ... (self.on_evict.unwrap())(victims[i].key, victims[i].conflict, unsafe { v.deref().deref().deref() }, victims[i].cost) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `V` does not implement `Deref`, so calling `deref` on `&V` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `delVal` should have a snake case name [INFO] [stdout] --> src/cache.rs:811:29 [INFO] [stdout] | [INFO] [stdout] 811 | let delVal = store.del(&victims[i].key, &0, guard); [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `del_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/cache.rs:820:125 [INFO] [stdout] | [INFO] [stdout] 820 | ... (self.on_evict.unwrap())(victims[i].key, victims[i].conflict, unsafe { v.deref().deref().deref() }, victims[i].cost) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `V` does not implement `Deref`, so calling `deref` on `&V` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `SetsDropped` should have a snake case name [INFO] [stdout] --> src/cache.rs:931:19 [INFO] [stdout] | [INFO] [stdout] 931 | pub(crate) fn SetsDropped<'g>(&'g self, guard: &'g Guard) -> u64 { [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `sets_dropped` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `cmDepth` should have an upper case name [INFO] [stdout] --> src/cmsketch.rs:6:7 [INFO] [stdout] | [INFO] [stdout] 6 | const cmDepth: usize = 4; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case: `CM_DEPTH` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 51 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stderr] Migrating benches/flurry_hashbrown.rs from 2021 edition to 2024 [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> benches/flurry_hashbrown.rs:38:60 [INFO] [stdout] | [INFO] [stdout] 38 | ($bench_macro:ident, $bench_fn_name:ident, $group_name:expr $(,)?) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 38 | ($bench_macro:ident, $bench_fn_name:ident, $group_name:expr_2021 $(,)?) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `flurry_hashbrown` [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> benches/flurry_hashbrown.rs:53:29 [INFO] [stdout] | [INFO] [stdout] 53 | ($group:ident, $keydist:expr, $bench_id: expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 53 | ($group:ident, $keydist:expr_2021, $bench_id: expr) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * benches/flurry_hashbrown.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> benches/flurry_hashbrown.rs:38:48 [INFO] [stderr] | [INFO] [stderr] 38 | ($bench_macro:ident, $bench_fn_name:ident, $group_name:expr_2021 $(,)?) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> benches/flurry_hashbrown.rs:53:20 [INFO] [stderr] | [INFO] [stderr] 53 | ($group:ident, $keydist:expr_2021, $bench_id: expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> benches/flurry_hashbrown.rs:53:40 [INFO] [stderr] | [INFO] [stderr] 53 | ($group:ident, $keydist:expr_2021, $bench_id: expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> benches/flurry_hashbrown.rs:75:20 [INFO] [stderr] | [INFO] [stderr] 75 | ($group:ident, $keydist:expr_2021, $bench_id: expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> benches/flurry_hashbrown.rs:75:40 [INFO] [stderr] | [INFO] [stderr] 75 | ($group:ident, $keydist:expr_2021, $bench_id: expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> benches/flurry_hashbrown.rs:118:20 [INFO] [stderr] | [INFO] [stderr] 118 | ($group:ident, $keydist:expr_2021, $bench_id: expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> benches/flurry_hashbrown.rs:118:40 [INFO] [stderr] | [INFO] [stderr] 118 | ($group:ident, $keydist:expr_2021, $bench_id: expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> benches/flurry_hashbrown.rs:142:20 [INFO] [stderr] | [INFO] [stderr] 142 | ($group:ident, $keydist:expr_2021, $bench_id: expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> benches/flurry_hashbrown.rs:142:40 [INFO] [stderr] | [INFO] [stderr] 142 | ($group:ident, $keydist:expr_2021, $bench_id: expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> benches/flurry_hashbrown.rs:171:20 [INFO] [stderr] | [INFO] [stderr] 171 | ($group:ident, $keydist:expr_2021, $bench_id: expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> benches/flurry_hashbrown.rs:171:40 [INFO] [stderr] | [INFO] [stderr] 171 | ($group:ident, $keydist:expr_2021, $bench_id: expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 11 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> benches/flurry_hashbrown.rs:53:46 [INFO] [stdout] | [INFO] [stdout] 53 | ($group:ident, $keydist:expr, $bench_id: expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 53 | ($group:ident, $keydist:expr, $bench_id: expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> benches/flurry_hashbrown.rs:75:29 [INFO] [stdout] | [INFO] [stdout] 75 | ($group:ident, $keydist:expr, $bench_id: expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 75 | ($group:ident, $keydist:expr_2021, $bench_id: expr) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> benches/flurry_hashbrown.rs:75:46 [INFO] [stdout] | [INFO] [stdout] 75 | ($group:ident, $keydist:expr, $bench_id: expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 75 | ($group:ident, $keydist:expr, $bench_id: expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> benches/flurry_hashbrown.rs:118:29 [INFO] [stdout] | [INFO] [stdout] 118 | ($group:ident, $keydist:expr, $bench_id: expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 118 | ($group:ident, $keydist:expr_2021, $bench_id: expr) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> benches/flurry_hashbrown.rs:118:46 [INFO] [stdout] | [INFO] [stdout] 118 | ($group:ident, $keydist:expr, $bench_id: expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 118 | ($group:ident, $keydist:expr, $bench_id: expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> benches/flurry_hashbrown.rs:142:29 [INFO] [stdout] | [INFO] [stdout] 142 | ($group:ident, $keydist:expr, $bench_id: expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 142 | ($group:ident, $keydist:expr_2021, $bench_id: expr) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> benches/flurry_hashbrown.rs:142:46 [INFO] [stdout] | [INFO] [stdout] 142 | ($group:ident, $keydist:expr, $bench_id: expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 142 | ($group:ident, $keydist:expr, $bench_id: expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> benches/flurry_hashbrown.rs:171:29 [INFO] [stdout] | [INFO] [stdout] 171 | ($group:ident, $keydist:expr, $bench_id: expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 171 | ($group:ident, $keydist:expr_2021, $bench_id: expr) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> benches/flurry_hashbrown.rs:171:46 [INFO] [stdout] | [INFO] [stdout] 171 | ($group:ident, $keydist:expr, $bench_id: expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 171 | ($group:ident, $keydist:expr, $bench_id: expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `insert_erase_flurry_hashbrown` is never used [INFO] [stdout] --> benches/flurry_hashbrown.rs:113:5 [INFO] [stdout] | [INFO] [stdout] 113 | insert_erase_flurry_hashbrown, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] = note: this warning originates in the macro `bench_suite` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_flurry_hashbrown` is never used [INFO] [stdout] --> benches/flurry_hashbrown.rs:139:28 [INFO] [stdout] | [INFO] [stdout] 139 | bench_suite!(bench_lookup, get_flurry_hashbrown, "get_flurry_hashbrown",); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `bench_suite` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_absent_flurry_hashbrown` is never used [INFO] [stdout] --> benches/flurry_hashbrown.rs:166:5 [INFO] [stdout] | [INFO] [stdout] 166 | get_absent_flurry_hashbrown, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `bench_suite` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `iter_flurry_hashbrown` is never used [INFO] [stdout] --> benches/flurry_hashbrown.rs:192:26 [INFO] [stdout] | [INFO] [stdout] 192 | bench_suite!(bench_iter, iter_flurry_hashbrown, "iter_flurry_hashbrown",); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `bench_suite` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/cmsketch.rs:32:29 [INFO] [stdout] | [INFO] [stdout] 32 | let source = raange.gen::(); [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `memory_cache_rust` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/bloom/bbloom.rs [INFO] [stderr] * src/bloom/haskey.rs [INFO] [stderr] * src/cache.rs [INFO] [stderr] * src/policy.rs [INFO] [stderr] * src/ring.rs [INFO] [stderr] * src/store.rs [INFO] [stderr] * src/ttl.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/cache.rs:28:6 [INFO] [stderr] | [INFO] [stderr] 28 | ($n: expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ops::Deref` [INFO] [stderr] --> src/bloom/haskey.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::ops::Deref; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary trailing semicolon [INFO] [stderr] --> src/bloom/haskey.rs:173:9 [INFO] [stderr] | [INFO] [stderr] 173 | ; [INFO] [stderr] | ^ help: remove this semicolon [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/ttl.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 94 | break; [INFO] [stderr] | ----- any code following this expression is unreachable [INFO] [stderr] 95 | [INFO] [stderr] 96 | break; [INFO] [stderr] | ^^^^^^ unreachable statement [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unreachable_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `syncpool::prelude` [INFO] [stderr] --> src/ring.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use syncpool::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Add` [INFO] [stderr] --> src/cache.rs:6:16 [INFO] [stderr] | [INFO] [stderr] 6 | use std::ops::{Add, Deref}; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `entries` is never read [INFO] [stderr] --> src/bloom/bbloom.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | let mut entries = 0; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: maybe it is overwritten before being read? [INFO] [stderr] = note: `#[warn(unused_assignments)]` on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `locs` is never read [INFO] [stderr] --> src/bloom/bbloom.rs:36:17 [INFO] [stderr] | [INFO] [stderr] 36 | let mut locs = 0; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: maybe it is overwritten before being read? [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/bloom/bbloom.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | unsafe { [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_unsafe)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/bloom/bbloom.rs:153:32 [INFO] [stderr] | [INFO] [stderr] 153 | bj.filter_set[i] = unsafe { ptr.wrapping_offset(i as isize) as u8 } [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] [INFO] [stderr] warning: function cannot return without recursing [INFO] [stderr] --> src/store.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | fn deref_mut(&mut self) -> &mut Self::Target { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing [INFO] [stderr] 72 | self [INFO] [stderr] | ---- recursive call site [INFO] [stderr] | [INFO] [stderr] = help: a `loop` may express intention better if this is on purpose [INFO] [stderr] = note: `#[warn(unconditional_recursion)]` on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `expiration` is never read [INFO] [stderr] --> src/cache.rs:592:17 [INFO] [stderr] | [INFO] [stderr] 592 | let mut expiration: Option = None; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: maybe it is overwritten before being read? [INFO] [stderr] [INFO] [stderr] warning: function cannot return without recursing [INFO] [stderr] --> src/cache.rs:742:5 [INFO] [stderr] | [INFO] [stderr] 742 | pub fn clear<'g>(&'g self, guard: &'g Guard) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing [INFO] [stderr] ... [INFO] [stderr] 761 | self.clear(guard); [INFO] [stderr] | ----------------- recursive call site [INFO] [stderr] | [INFO] [stderr] = help: a `loop` may express intention better if this is on purpose [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/policy.rs:191:17 [INFO] [stderr] | [INFO] [stderr] 191 | unsafe { [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/ring.rs:46:25 [INFO] [stderr] | [INFO] [stderr] 44 | unsafe { [INFO] [stderr] | ------ because it's nested under this `unsafe` block [INFO] [stderr] 45 | let p = self.cons.load(Ordering::SeqCst, guard); [INFO] [stderr] 46 | let p = unsafe {p.as_ptr()}; [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/ring.rs:47:25 [INFO] [stderr] | [INFO] [stderr] 44 | unsafe { [INFO] [stderr] | ------ because it's nested under this `unsafe` block [INFO] [stderr] ... [INFO] [stderr] 47 | let p = unsafe {p.as_mut().unwrap()}; [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/ring.rs:49:39 [INFO] [stderr] | [INFO] [stderr] 44 | unsafe { [INFO] [stderr] | ------ because it's nested under this `unsafe` block [INFO] [stderr] ... [INFO] [stderr] 49 | if data.is_null() || !unsafe { data.deref() }.is_empty() { [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error; 16 warnings emitted [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stderr] Migrating tests/cache.rs from 2021 edition to 2024 [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/bloom/haskey.rs:173:9 [INFO] [stdout] | [INFO] [stdout] 173 | ; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/cache.rs:28:10 [INFO] [stdout] | [INFO] [stdout] 28 | ($n: expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 28 | ($n: expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/cmsketch.rs:94:51 [INFO] [stdout] | [INFO] [stdout] 94 | s.push_str(format!("{:#02} ", (self.0[(i / 2)] >> ((i & 1) * 4)) & 0x0f).as_str()); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 94 - s.push_str(format!("{:#02} ", (self.0[(i / 2)] >> ((i & 1) * 4)) & 0x0f).as_str()); [INFO] [stdout] 94 + s.push_str(format!("{:#02} ", (self.0[i / 2] >> ((i & 1) * 4)) & 0x0f).as_str()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable statement [INFO] [stdout] --> src/ttl.rs:96:13 [INFO] [stdout] | [INFO] [stdout] 94 | break; [INFO] [stdout] | ----- any code following this expression is unreachable [INFO] [stdout] 95 | [INFO] [stdout] 96 | break; [INFO] [stdout] | ^^^^^^ unreachable statement [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `syncpool::prelude` [INFO] [stdout] --> src/ring.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use syncpool::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Add` [INFO] [stdout] --> src/cache.rs:6:16 [INFO] [stdout] | [INFO] [stdout] 6 | use std::ops::{Add, Deref}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `entries` is never read [INFO] [stdout] --> src/bloom/bbloom.rs:35:17 [INFO] [stdout] | [INFO] [stdout] 35 | let mut entries = 0; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `locs` is never read [INFO] [stdout] --> src/bloom/bbloom.rs:36:17 [INFO] [stdout] | [INFO] [stdout] 36 | let mut locs = 0; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/bloom/bbloom.rs:133:9 [INFO] [stdout] | [INFO] [stdout] 133 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_unsafe)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/bloom/bbloom.rs:153:32 [INFO] [stdout] | [INFO] [stdout] 153 | bj.filter_set[i] = unsafe { ptr.wrapping_offset(i as isize) as u8 } [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::slice::from_raw_parts` is unsafe and requires unsafe block [INFO] [stdout] --> src/bloom/rutil.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | / ::std::slice::from_raw_parts( [INFO] [stdout] 9 | | (p as *const T) as *const u8, [INFO] [stdout] 10 | | ::std::mem::size_of::(), [INFO] [stdout] 11 | | ) [INFO] [stdout] | |_____^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/bloom/rutil.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | unsafe fn any_as_u8_slice(p: &T) -> &[u8] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `--force-warn unsafe-op-in-unsafe-fn` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function cannot return without recursing [INFO] [stdout] --> src/store.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 71 | fn deref_mut(&mut self) -> &mut Self::Target { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing [INFO] [stdout] 72 | self [INFO] [stdout] | ---- recursive call site [INFO] [stdout] | [INFO] [stdout] = help: a `loop` may express intention better if this is on purpose [INFO] [stdout] = note: `#[warn(unconditional_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::boxed::Box::::from_raw` is unsafe and requires unsafe block [INFO] [stdout] --> src/reclaim.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | Box::from_raw(self.0.into_inner()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/reclaim.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | pub(crate) unsafe fn into_box(self) -> Box> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::boxed::Box::::from_raw` is unsafe and requires unsafe block [INFO] [stdout] --> src/reclaim.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | Box::from_raw(self.ptr) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/reclaim.rs:100:5 [INFO] [stdout] | [INFO] [stdout] 100 | pub(crate) unsafe fn into_box(self) -> Box> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::ptr::mut_ptr::::as_ref` is unsafe and requires unsafe block [INFO] [stdout] --> src/reclaim.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 109 | self.ptr.as_ref() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/reclaim.rs:108:5 [INFO] [stdout] | [INFO] [stdout] 108 | pub(crate) unsafe fn as_ref(&self) -> Option<&'g Linked> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block [INFO] [stdout] --> src/reclaim.rs:113:10 [INFO] [stdout] | [INFO] [stdout] 113 | &*self.ptr [INFO] [stdout] | ^^^^^^^^^ dereference of raw pointer [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/reclaim.rs:112:5 [INFO] [stdout] | [INFO] [stdout] 112 | pub(crate) unsafe fn deref(&self) -> &'g Linked { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `seize::Guard::<'_>::retire` is unsafe and requires unsafe block [INFO] [stdout] --> src/reclaim.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 152 | self.retire(shared.ptr, seize::reclaim::boxed::); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/reclaim.rs:151:5 [INFO] [stdout] | [INFO] [stdout] 151 | unsafe fn retire_shared(&self, shared: Shared<'_, T>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `expiration` is never read [INFO] [stdout] --> src/cache.rs:592:17 [INFO] [stdout] | [INFO] [stdout] 592 | let mut expiration: Option = None; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function cannot return without recursing [INFO] [stdout] --> src/cache.rs:742:5 [INFO] [stdout] | [INFO] [stdout] 742 | pub fn clear<'g>(&'g self, guard: &'g Guard) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing [INFO] [stdout] ... [INFO] [stdout] 761 | self.clear(guard); [INFO] [stdout] | ----------------- recursive call site [INFO] [stdout] | [INFO] [stdout] = help: a `loop` may express intention better if this is on purpose [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/policy.rs:191:17 [INFO] [stdout] | [INFO] [stdout] 191 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/ring.rs:46:25 [INFO] [stdout] | [INFO] [stdout] 44 | unsafe { [INFO] [stdout] | ------ because it's nested under this `unsafe` block [INFO] [stdout] 45 | let p = self.cons.load(Ordering::SeqCst, guard); [INFO] [stdout] 46 | let p = unsafe {p.as_ptr()}; [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/ring.rs:47:25 [INFO] [stdout] | [INFO] [stdout] 44 | unsafe { [INFO] [stdout] | ------ because it's nested under this `unsafe` block [INFO] [stdout] ... [INFO] [stdout] 47 | let p = unsafe {p.as_mut().unwrap()}; [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/ring.rs:49:39 [INFO] [stdout] | [INFO] [stdout] 44 | unsafe { [INFO] [stdout] | ------ because it's nested under this `unsafe` block [INFO] [stdout] ... [INFO] [stdout] 49 | if data.is_null() || !unsafe { data.deref() }.is_empty() { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `size_exp` is never read [INFO] [stdout] --> src/bloom/bbloom.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct Bloom { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 19 | size_exp: u64, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `json_encoder` is never used [INFO] [stdout] --> src/bloom/bbloom.rs:145:8 [INFO] [stdout] | [INFO] [stdout] 32 | impl Bloom { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 145 | fn json_encoder(&mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `any_as_u8_slice` is never used [INFO] [stdout] --> src/bloom/rutil.rs:7:11 [INFO] [stdout] | [INFO] [stdout] 7 | unsafe fn any_as_u8_slice(p: &T) -> &[u8] { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `is_string` is never used [INFO] [stdout] --> src/bloom/hasher.rs:58:4 [INFO] [stdout] | [INFO] [stdout] 58 | fn is_string(_s: &T) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `ITER` is never used [INFO] [stdout] --> src/store.rs:283:11 [INFO] [stdout] | [INFO] [stdout] 283 | const ITER: u64 = 32 * 1024; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `into_box` and `compare_exchange` are never used [INFO] [stdout] --> src/reclaim.rs:23:26 [INFO] [stdout] | [INFO] [stdout] 10 | impl Atomic { [INFO] [stdout] | ----------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 23 | pub(crate) unsafe fn into_box(self) -> Box> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 36 | pub(crate) fn compare_exchange<'g>( [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `CompareExchangeError` is never constructed [INFO] [stdout] --> src/reclaim.rs:81:19 [INFO] [stdout] | [INFO] [stdout] 81 | pub(crate) struct CompareExchangeError<'g, T> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `RetireShared` is never used [INFO] [stdout] --> src/reclaim.rs:146:18 [INFO] [stdout] | [INFO] [stdout] 146 | pub(crate) trait RetireShared { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `GuardRef` is never used [INFO] [stdout] --> src/reclaim.rs:156:17 [INFO] [stdout] | [INFO] [stdout] 156 | pub(crate) enum GuardRef<'g> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get` and `SetsDropped` are never used [INFO] [stdout] --> src/cache.rs:917:19 [INFO] [stdout] | [INFO] [stdout] 910 | impl Metrics { [INFO] [stdout] | ------------ methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 917 | pub(crate) fn get<'g>(&'g self, t: MetricType, guard: &'g Guard) -> u64 { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 931 | pub(crate) fn SetsDropped<'g>(&'g self, guard: &'g Guard) -> u64 { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `0` and `1` are never read [INFO] [stdout] --> src/cache.rs:1199:17 [INFO] [stdout] | [INFO] [stdout] 1199 | struct Pair(Box, Box); [INFO] [stdout] | ---- ^^^^^^^^ ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | fields in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing these fields [INFO] [stdout] = note: `Pair` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `Policy` is never used [INFO] [stdout] --> src/policy.rs:16:11 [INFO] [stdout] | [INFO] [stdout] 16 | pub trait Policy { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `number_counters` and `max_cost` are never read [INFO] [stdout] --> src/policy.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 40 | pub struct DefaultPolicy { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 46 | number_counters: i64, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 47 | lock: Mutex<()>, [INFO] [stdout] 48 | max_cost: i64, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `close` is never used [INFO] [stdout] --> src/policy.rs:236:12 [INFO] [stdout] | [INFO] [stdout] 53 | impl DefaultPolicy { [INFO] [stdout] | ------------------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 236 | pub fn close(&mut self) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `RingConsumer` is never used [INFO] [stdout] --> src/ring.rs:10:10 [INFO] [stdout] | [INFO] [stdout] 10 | pub type RingConsumer = Box) -> bool>; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `getSize` should have a snake case name [INFO] [stdout] --> src/bloom/bbloom.rs:170:4 [INFO] [stdout] | [INFO] [stdout] 170 | fn getSize(mut u_i64: u64) -> (u64, u64) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `get_size` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/bloom/haskey.rs:17:19 [INFO] [stdout] | [INFO] [stdout] 17 | let key = *key.deref(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `T` does not implement `Deref`, so calling `deref` on `&T` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/cache.rs:249:12 [INFO] [stdout] | [INFO] [stdout] 249 | if let Some(m) = &ca.metrics { [INFO] [stdout] | ^^^^^^^^^^^^^^^---------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/cache.rs:257:9 [INFO] [stdout] | [INFO] [stdout] 257 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 249 ~ match &ca.metrics { Some(m) => { [INFO] [stdout] 250 | let v: *const Metrics = &**m; [INFO] [stdout] ... [INFO] [stdout] 256 | ca.get_buf.store(table, Ordering::SeqCst); [INFO] [stdout] 257 ~ } _ => { [INFO] [stdout] 258 | let table = Shared::boxed(DefaultPolicy::new(ca.numb_counters, ca.max_cost, ptr::null()), &ca.collector); [INFO] [stdout] ... [INFO] [stdout] 262 | ca.get_buf.store(table, Ordering::SeqCst); [INFO] [stdout] 263 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/cache.rs:424:16 [INFO] [stdout] | [INFO] [stdout] 424 | if let Some(m) = &self.metrics { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/cache.rs:434:13 [INFO] [stdout] | [INFO] [stdout] 434 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 424 ~ match &self.metrics { Some(m) => { [INFO] [stdout] 425 | let v: *const Metrics = &**m; [INFO] [stdout] ... [INFO] [stdout] 433 | self.init_ringbuf(guard); [INFO] [stdout] 434 ~ } _ => { [INFO] [stdout] 435 | continue; [INFO] [stdout] 436 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/cache.rs:593:12 [INFO] [stdout] | [INFO] [stdout] 593 | if ttl.as_millis() < 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/cache.rs:659:28 [INFO] [stdout] | [INFO] [stdout] 659 | if let Some(metrics) = &self.metrics { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/cache.rs:661:25 [INFO] [stdout] | [INFO] [stdout] 661 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 659 ~ match &self.metrics { Some(metrics) => { [INFO] [stdout] 660 | metrics.add(KEY_ADD, item.key, 1, guard) [INFO] [stdout] 661 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `delVal` should have a snake case name [INFO] [stdout] --> src/cache.rs:666:29 [INFO] [stdout] | [INFO] [stdout] 666 | let delVal = dstore.del(&victims[i].key, &0, guard); [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `del_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/cache.rs:675:125 [INFO] [stdout] | [INFO] [stdout] 675 | ... (self.on_evict.unwrap())(victims[i].key, victims[i].conflict, unsafe { v.deref().deref().deref() }, victims[i].cost) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `V` does not implement `Deref`, so calling `deref` on `&V` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `delVal` should have a snake case name [INFO] [stdout] --> src/cache.rs:811:29 [INFO] [stdout] | [INFO] [stdout] 811 | let delVal = store.del(&victims[i].key, &0, guard); [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `del_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/cache.rs:820:125 [INFO] [stdout] | [INFO] [stdout] 820 | ... (self.on_evict.unwrap())(victims[i].key, victims[i].conflict, unsafe { v.deref().deref().deref() }, victims[i].cost) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `V` does not implement `Deref`, so calling `deref` on `&V` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `SetsDropped` should have a snake case name [INFO] [stdout] --> src/cache.rs:931:19 [INFO] [stdout] | [INFO] [stdout] 931 | pub(crate) fn SetsDropped<'g>(&'g self, guard: &'g Guard) -> u64 { [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `sets_dropped` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/cache.rs:1029:16 [INFO] [stdout] | [INFO] [stdout] 1029 | if let Some(v) = map.get(&i, &guard) { [INFO] [stdout] | ^^^^^^^^^^^^^^---^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/cache.rs:1034:13 [INFO] [stdout] | [INFO] [stdout] 1034 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 1029 ~ match map.get(&i, &guard) { Some(v) => { [INFO] [stdout] 1030 | if &i != v { [INFO] [stdout] ... [INFO] [stdout] 1033 | println!("key:{i}, value: {:?}", map.get(&i, &guard)); [INFO] [stdout] 1034 ~ } _ => { [INFO] [stdout] 1035 | println!("key:{i}, value: None"); [INFO] [stdout] 1036 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/cache.rs:1080:9 [INFO] [stdout] | [INFO] [stdout] 1080 | t1.join(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1080 | let _ = t1.join(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/cache.rs:1081:9 [INFO] [stdout] | [INFO] [stdout] 1081 | t2.join(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1081 | let _ = t2.join(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/cache.rs:1082:9 [INFO] [stdout] | [INFO] [stdout] 1082 | t3.join(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1082 | let _ = t3.join(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/cache.rs:1083:9 [INFO] [stdout] | [INFO] [stdout] 1083 | t4.join(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1083 | let _ = t4.join(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/policy.rs:467:9 [INFO] [stdout] | [INFO] [stdout] 467 | drop(Box::into_raw(shard_metric)) [INFO] [stdout] | ^^^^^---------------------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `*mut Metrics` [INFO] [stdout] | [INFO] [stdout] = note: use `let _ = ...` to ignore the expression or result [INFO] [stdout] = note: `#[warn(dropping_copy_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/policy.rs:519:9 [INFO] [stdout] | [INFO] [stdout] 519 | drop(Box::into_raw(shard_metric)) [INFO] [stdout] | ^^^^^---------------------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `*mut Metrics` [INFO] [stdout] | [INFO] [stdout] = note: use `let _ = ...` to ignore the expression or result [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/policy.rs:534:9 [INFO] [stdout] | [INFO] [stdout] 534 | drop(Box::into_raw(shard_metric)) [INFO] [stdout] | ^^^^^---------------------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `*mut Metrics` [INFO] [stdout] | [INFO] [stdout] = note: use `let _ = ...` to ignore the expression or result [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/policy.rs:552:9 [INFO] [stdout] | [INFO] [stdout] 552 | drop(Box::into_raw(shard_metric)) [INFO] [stdout] | ^^^^^---------------------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `*mut Metrics` [INFO] [stdout] | [INFO] [stdout] = note: use `let _ = ...` to ignore the expression or result [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/policy.rs:570:9 [INFO] [stdout] | [INFO] [stdout] 570 | drop(Box::into_raw(shard_metric)) [INFO] [stdout] | ^^^^^---------------------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `*mut Metrics` [INFO] [stdout] | [INFO] [stdout] = note: use `let _ = ...` to ignore the expression or result [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/policy.rs:594:9 [INFO] [stdout] | [INFO] [stdout] 594 | drop(Box::into_raw(shard_metric)) [INFO] [stdout] | ^^^^^---------------------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `*mut Metrics` [INFO] [stdout] | [INFO] [stdout] = note: use `let _ = ...` to ignore the expression or result [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/policy.rs:612:9 [INFO] [stdout] | [INFO] [stdout] 612 | drop(Box::into_raw(shard_metric)) [INFO] [stdout] | ^^^^^---------------------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `*mut Metrics` [INFO] [stdout] | [INFO] [stdout] = note: use `let _ = ...` to ignore the expression or result [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/policy.rs:631:9 [INFO] [stdout] | [INFO] [stdout] 631 | drop(Box::into_raw(shard_metric)) [INFO] [stdout] | ^^^^^---------------------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `*mut Metrics` [INFO] [stdout] | [INFO] [stdout] = note: use `let _ = ...` to ignore the expression or result [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/policy.rs:650:9 [INFO] [stdout] | [INFO] [stdout] 650 | drop(Box::into_raw(shard_metric)) [INFO] [stdout] | ^^^^^---------------------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `*mut Metrics` [INFO] [stdout] | [INFO] [stdout] = note: use `let _ = ...` to ignore the expression or result [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/policy.rs:670:9 [INFO] [stdout] | [INFO] [stdout] 670 | drop(Box::into_raw(shard_metric)) [INFO] [stdout] | ^^^^^---------------------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `*mut Metrics` [INFO] [stdout] | [INFO] [stdout] = note: use `let _ = ...` to ignore the expression or result [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `cmDepth` should have an upper case name [INFO] [stdout] --> src/cmsketch.rs:6:7 [INFO] [stdout] | [INFO] [stdout] 6 | const cmDepth: usize = 4; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case: `CM_DEPTH` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `TestSketchClear` should have a snake case name [INFO] [stdout] --> src/cmsketch.rs:132:8 [INFO] [stdout] | [INFO] [stdout] 132 | fn TestSketchClear() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `test_sketch_clear` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 67 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stderr] Fixed tests/cache.rs (1 fix) [INFO] [stderr] Migrating benches/flurry_dashmap.rs from 2021 edition to 2024 [INFO] [stderr] Fixed benches/flurry_dashmap.rs (1 fix) [INFO] [stdout] warning: function `task_insert_flurry_u64_u64_guard_every_it` is never used [INFO] [stdout] --> benches/flurry_dashmap.rs:28:4 [INFO] [stdout] | [INFO] [stdout] 28 | fn task_insert_flurry_u64_u64_guard_every_it() -> Cache { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `insert_flurry_u64_u64_guard_every_it` is never used [INFO] [stdout] --> benches/flurry_dashmap.rs:37:4 [INFO] [stdout] | [INFO] [stdout] 37 | fn insert_flurry_u64_u64_guard_every_it(c: &mut Criterion) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `task_get_flurry_u64_u64_guard_every_it` is never used [INFO] [stdout] --> benches/flurry_dashmap.rs:101:4 [INFO] [stdout] | [INFO] [stdout] 101 | fn task_get_flurry_u64_u64_guard_every_it(map: &Cache) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_flurry_u64_u64_guard_every_it` is never used [INFO] [stdout] --> benches/flurry_dashmap.rs:108:4 [INFO] [stdout] | [INFO] [stdout] 108 | fn get_flurry_u64_u64_guard_every_it(c: &mut Criterion) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `task_get_flurry_u64_u64_guard_once` is never used [INFO] [stdout] --> benches/flurry_dashmap.rs:132:4 [INFO] [stdout] | [INFO] [stdout] 132 | fn task_get_flurry_u64_u64_guard_once(threads: usize, map: Arc>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_flurry_u64_u64_guard_once` is never used [INFO] [stdout] --> benches/flurry_dashmap.rs:151:4 [INFO] [stdout] | [INFO] [stdout] 151 | fn get_flurry_u64_u64_guard_once(c: &mut Criterion) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 16.72s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking memory-cache-rust v0.1.0-alpha (/tmp/fixit) [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/cmsketch.rs:32:29 [INFO] [stdout] | [INFO] [stdout] 32 | let source = raange.gen::(); [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 32 | let source = raange.r#gen::(); [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/cmsketch.rs:32:29 [INFO] [stdout] | [INFO] [stdout] 32 | let source = raange.gen::(); [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 32 | let source = raange.r#gen::(); [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/cmsketch.rs:94:51 [INFO] [stdout] | [INFO] [stdout] 94 | s.push_str(format!("{:#02} ", (self.0[(i / 2)] >> ((i & 1) * 4)) & 0x0f).as_str()); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 94 - s.push_str(format!("{:#02} ", (self.0[(i / 2)] >> ((i & 1) * 4)) & 0x0f).as_str()); [INFO] [stdout] 94 + s.push_str(format!("{:#02} ", (self.0[i / 2] >> ((i & 1) * 4)) & 0x0f).as_str()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/bloom/haskey.rs:173:9 [INFO] [stdout] | [INFO] [stdout] 173 | ; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/cmsketch.rs:94:51 [INFO] [stdout] | [INFO] [stdout] 94 | s.push_str(format!("{:#02} ", (self.0[(i / 2)] >> ((i & 1) * 4)) & 0x0f).as_str()); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 94 - s.push_str(format!("{:#02} ", (self.0[(i / 2)] >> ((i & 1) * 4)) & 0x0f).as_str()); [INFO] [stdout] 94 + s.push_str(format!("{:#02} ", (self.0[i / 2] >> ((i & 1) * 4)) & 0x0f).as_str()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable statement [INFO] [stdout] --> src/ttl.rs:96:13 [INFO] [stdout] | [INFO] [stdout] 94 | break; [INFO] [stdout] | ----- any code following this expression is unreachable [INFO] [stdout] 95 | [INFO] [stdout] 96 | break; [INFO] [stdout] | ^^^^^^ unreachable statement [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `syncpool::prelude` [INFO] [stdout] --> src/ring.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use syncpool::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Add` [INFO] [stdout] --> src/cache.rs:6:16 [INFO] [stdout] | [INFO] [stdout] 6 | use std::ops::{Add, Deref}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `entries` is never read [INFO] [stdout] --> src/bloom/bbloom.rs:35:17 [INFO] [stdout] | [INFO] [stdout] 35 | let mut entries = 0; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `locs` is never read [INFO] [stdout] --> src/bloom/bbloom.rs:36:17 [INFO] [stdout] | [INFO] [stdout] 36 | let mut locs = 0; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/bloom/bbloom.rs:133:9 [INFO] [stdout] | [INFO] [stdout] 133 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_unsafe)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/bloom/bbloom.rs:153:32 [INFO] [stdout] | [INFO] [stdout] 153 | bj.filter_set[i] = unsafe { ptr.wrapping_offset(i as isize) as u8 } [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable statement [INFO] [stdout] --> src/ttl.rs:96:13 [INFO] [stdout] | [INFO] [stdout] 94 | break; [INFO] [stdout] | ----- any code following this expression is unreachable [INFO] [stdout] 95 | [INFO] [stdout] 96 | break; [INFO] [stdout] | ^^^^^^ unreachable statement [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::slice::from_raw_parts` is unsafe and requires unsafe block [INFO] [stdout] --> src/bloom/rutil.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | / ::std::slice::from_raw_parts( [INFO] [stdout] 9 | | (p as *const T) as *const u8, [INFO] [stdout] 10 | | ::std::mem::size_of::(), [INFO] [stdout] 11 | | ) [INFO] [stdout] | |_____^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/bloom/rutil.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | unsafe fn any_as_u8_slice(p: &T) -> &[u8] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(unsafe_op_in_unsafe_fn)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function cannot return without recursing [INFO] [stdout] --> src/store.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 71 | fn deref_mut(&mut self) -> &mut Self::Target { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing [INFO] [stdout] 72 | self [INFO] [stdout] | ---- recursive call site [INFO] [stdout] | [INFO] [stdout] = help: a `loop` may express intention better if this is on purpose [INFO] [stdout] = note: `#[warn(unconditional_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::boxed::Box::::from_raw` is unsafe and requires unsafe block [INFO] [stdout] --> src/reclaim.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | Box::from_raw(self.0.into_inner()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/reclaim.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | pub(crate) unsafe fn into_box(self) -> Box> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::boxed::Box::::from_raw` is unsafe and requires unsafe block [INFO] [stdout] --> src/reclaim.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | Box::from_raw(self.ptr) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/reclaim.rs:100:5 [INFO] [stdout] | [INFO] [stdout] 100 | pub(crate) unsafe fn into_box(self) -> Box> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::ptr::mut_ptr::::as_ref` is unsafe and requires unsafe block [INFO] [stdout] --> src/reclaim.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 109 | self.ptr.as_ref() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/reclaim.rs:108:5 [INFO] [stdout] | [INFO] [stdout] 108 | pub(crate) unsafe fn as_ref(&self) -> Option<&'g Linked> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block [INFO] [stdout] --> src/reclaim.rs:113:10 [INFO] [stdout] | [INFO] [stdout] 113 | &*self.ptr [INFO] [stdout] | ^^^^^^^^^ dereference of raw pointer [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/reclaim.rs:112:5 [INFO] [stdout] | [INFO] [stdout] 112 | pub(crate) unsafe fn deref(&self) -> &'g Linked { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `seize::Guard::<'_>::retire` is unsafe and requires unsafe block [INFO] [stdout] --> src/reclaim.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 152 | self.retire(shared.ptr, seize::reclaim::boxed::); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/reclaim.rs:151:5 [INFO] [stdout] | [INFO] [stdout] 151 | unsafe fn retire_shared(&self, shared: Shared<'_, T>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `expiration` is never read [INFO] [stdout] --> src/cache.rs:592:17 [INFO] [stdout] | [INFO] [stdout] 592 | let mut expiration: Option = None; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function cannot return without recursing [INFO] [stdout] --> src/cache.rs:742:5 [INFO] [stdout] | [INFO] [stdout] 742 | pub fn clear<'g>(&'g self, guard: &'g Guard) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing [INFO] [stdout] ... [INFO] [stdout] 761 | self.clear(guard); [INFO] [stdout] | ----------------- recursive call site [INFO] [stdout] | [INFO] [stdout] = help: a `loop` may express intention better if this is on purpose [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/policy.rs:191:17 [INFO] [stdout] | [INFO] [stdout] 191 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `syncpool::prelude` [INFO] [stdout] --> src/ring.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use syncpool::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Add` [INFO] [stdout] --> src/cache.rs:6:16 [INFO] [stdout] | [INFO] [stdout] 6 | use std::ops::{Add, Deref}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `entries` is never read [INFO] [stdout] --> src/bloom/bbloom.rs:35:17 [INFO] [stdout] | [INFO] [stdout] 35 | let mut entries = 0; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `locs` is never read [INFO] [stdout] --> src/bloom/bbloom.rs:36:17 [INFO] [stdout] | [INFO] [stdout] 36 | let mut locs = 0; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/bloom/bbloom.rs:133:9 [INFO] [stdout] | [INFO] [stdout] 133 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_unsafe)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/bloom/bbloom.rs:153:32 [INFO] [stdout] | [INFO] [stdout] 153 | bj.filter_set[i] = unsafe { ptr.wrapping_offset(i as isize) as u8 } [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/ring.rs:46:25 [INFO] [stdout] | [INFO] [stdout] 44 | unsafe { [INFO] [stdout] | ------ because it's nested under this `unsafe` block [INFO] [stdout] 45 | let p = self.cons.load(Ordering::SeqCst, guard); [INFO] [stdout] 46 | let p = unsafe {p.as_ptr()}; [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/ring.rs:47:25 [INFO] [stdout] | [INFO] [stdout] 44 | unsafe { [INFO] [stdout] | ------ because it's nested under this `unsafe` block [INFO] [stdout] ... [INFO] [stdout] 47 | let p = unsafe {p.as_mut().unwrap()}; [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/ring.rs:49:39 [INFO] [stdout] | [INFO] [stdout] 44 | unsafe { [INFO] [stdout] | ------ because it's nested under this `unsafe` block [INFO] [stdout] ... [INFO] [stdout] 49 | if data.is_null() || !unsafe { data.deref() }.is_empty() { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 21 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stderr] error: could not compile `memory-cache-rust` (lib) due to 2 previous errors; 21 warnings emitted [INFO] [stdout] warning[E0133]: call to unsafe function `std::slice::from_raw_parts` is unsafe and requires unsafe block [INFO] [stdout] --> src/bloom/rutil.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | / ::std::slice::from_raw_parts( [INFO] [stdout] 9 | | (p as *const T) as *const u8, [INFO] [stdout] 10 | | ::std::mem::size_of::(), [INFO] [stdout] 11 | | ) [INFO] [stdout] | |_____^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/bloom/rutil.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | unsafe fn any_as_u8_slice(p: &T) -> &[u8] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(unsafe_op_in_unsafe_fn)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: function cannot return without recursing [INFO] [stdout] --> src/store.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 71 | fn deref_mut(&mut self) -> &mut Self::Target { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing [INFO] [stdout] 72 | self [INFO] [stdout] | ---- recursive call site [INFO] [stdout] | [INFO] [stdout] = help: a `loop` may express intention better if this is on purpose [INFO] [stdout] = note: `#[warn(unconditional_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::boxed::Box::::from_raw` is unsafe and requires unsafe block [INFO] [stdout] --> src/reclaim.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | Box::from_raw(self.0.into_inner()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/reclaim.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | pub(crate) unsafe fn into_box(self) -> Box> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::boxed::Box::::from_raw` is unsafe and requires unsafe block [INFO] [stdout] --> src/reclaim.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | Box::from_raw(self.ptr) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/reclaim.rs:100:5 [INFO] [stdout] | [INFO] [stdout] 100 | pub(crate) unsafe fn into_box(self) -> Box> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::ptr::mut_ptr::::as_ref` is unsafe and requires unsafe block [INFO] [stdout] --> src/reclaim.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 109 | self.ptr.as_ref() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/reclaim.rs:108:5 [INFO] [stdout] | [INFO] [stdout] 108 | pub(crate) unsafe fn as_ref(&self) -> Option<&'g Linked> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block [INFO] [stdout] --> src/reclaim.rs:113:10 [INFO] [stdout] | [INFO] [stdout] 113 | &*self.ptr [INFO] [stdout] | ^^^^^^^^^ dereference of raw pointer [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/reclaim.rs:112:5 [INFO] [stdout] | [INFO] [stdout] 112 | pub(crate) unsafe fn deref(&self) -> &'g Linked { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `seize::Guard::<'_>::retire` is unsafe and requires unsafe block [INFO] [stdout] --> src/reclaim.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 152 | self.retire(shared.ptr, seize::reclaim::boxed::); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/reclaim.rs:151:5 [INFO] [stdout] | [INFO] [stdout] 151 | unsafe fn retire_shared(&self, shared: Shared<'_, T>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `expiration` is never read [INFO] [stdout] --> src/cache.rs:592:17 [INFO] [stdout] | [INFO] [stdout] 592 | let mut expiration: Option = None; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function cannot return without recursing [INFO] [stdout] --> src/cache.rs:742:5 [INFO] [stdout] | [INFO] [stdout] 742 | pub fn clear<'g>(&'g self, guard: &'g Guard) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing [INFO] [stdout] ... [INFO] [stdout] 761 | self.clear(guard); [INFO] [stdout] | ----------------- recursive call site [INFO] [stdout] | [INFO] [stdout] = help: a `loop` may express intention better if this is on purpose [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/policy.rs:191:17 [INFO] [stdout] | [INFO] [stdout] 191 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/ring.rs:46:25 [INFO] [stdout] | [INFO] [stdout] 44 | unsafe { [INFO] [stdout] | ------ because it's nested under this `unsafe` block [INFO] [stdout] 45 | let p = self.cons.load(Ordering::SeqCst, guard); [INFO] [stdout] 46 | let p = unsafe {p.as_ptr()}; [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/ring.rs:47:25 [INFO] [stdout] | [INFO] [stdout] 44 | unsafe { [INFO] [stdout] | ------ because it's nested under this `unsafe` block [INFO] [stdout] ... [INFO] [stdout] 47 | let p = unsafe {p.as_mut().unwrap()}; [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/ring.rs:49:39 [INFO] [stdout] | [INFO] [stdout] 44 | unsafe { [INFO] [stdout] | ------ because it's nested under this `unsafe` block [INFO] [stdout] ... [INFO] [stdout] 49 | if data.is_null() || !unsafe { data.deref() }.is_empty() { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 22 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stderr] error: could not compile `memory-cache-rust` (lib test) due to 2 previous errors; 22 warnings emitted [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "5e029f00273fa39e4c045fd8cd202dd2fe798d6faf38159cdd2abeb18e2fa9b6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5e029f00273fa39e4c045fd8cd202dd2fe798d6faf38159cdd2abeb18e2fa9b6", kill_on_drop: false }` [INFO] [stdout] 5e029f00273fa39e4c045fd8cd202dd2fe798d6faf38159cdd2abeb18e2fa9b6