[INFO] fetching crate makiko 0.2.3... [INFO] checking makiko-0.2.3 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate makiko 0.2.3 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate makiko 0.2.3 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate makiko 0.2.3 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate makiko 0.2.3 [INFO] tweaked toml for crates.io crate makiko 0.2.3 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate makiko 0.2.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b187b89f0f721e67f3fe8ad313ba28ee0d74c4ecaffbc4a489fef96ac3ad94ff [INFO] running `Command { std: "docker" "start" "-a" "b187b89f0f721e67f3fe8ad313ba28ee0d74c4ecaffbc4a489fef96ac3ad94ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b187b89f0f721e67f3fe8ad313ba28ee0d74c4ecaffbc4a489fef96ac3ad94ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b187b89f0f721e67f3fe8ad313ba28ee0d74c4ecaffbc4a489fef96ac3ad94ff", kill_on_drop: false }` [INFO] [stdout] b187b89f0f721e67f3fe8ad313ba28ee0d74c4ecaffbc4a489fef96ac3ad94ff [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 41c461e9ef054a1afdf8fe1850018c72f9d6af27cebd9ca3e2513de1b898777e [INFO] running `Command { std: "docker" "start" "-a" "41c461e9ef054a1afdf8fe1850018c72f9d6af27cebd9ca3e2513de1b898777e", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking bytes v1.6.1 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking base16ct v0.2.0 [INFO] [stderr] Checking pem-rfc7468 v0.7.0 [INFO] [stderr] Compiling httparse v1.9.4 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Compiling num-bigint-dig v0.8.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking pem v3.0.4 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking clap_builder v4.5.9 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking ff v0.13.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking hex-literal v0.4.1 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking enclose v1.2.0 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking clap v4.5.9 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling serde_repr v0.1.19 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking tokio v1.38.1 [INFO] [stderr] Checking der v0.7.9 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking block-padding v0.3.3 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking sha-1 v0.10.1 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking salsa20 v0.10.2 [INFO] [stderr] Checking cbc v0.1.2 [INFO] [stderr] Checking blowfish v0.9.1 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking scrypt v0.11.0 [INFO] [stderr] Checking bcrypt-pbkdf v0.10.0 [INFO] [stderr] Checking pkcs5 v0.7.1 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Checking pkcs1 v0.7.5 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking elliptic-curve v0.13.8 [INFO] [stderr] Checking ed25519-dalek v2.1.1 [INFO] [stderr] Checking x25519-dalek v2.0.1 [INFO] [stderr] Checking primeorder v0.13.6 [INFO] [stderr] Checking ecdsa v0.16.9 [INFO] [stderr] Checking p256 v0.13.2 [INFO] [stderr] Checking p384 v0.13.0 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking hyper-util v0.1.6 [INFO] [stderr] Checking serde_with v3.9.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking hyperlocal-next v0.9.0 [INFO] [stderr] Checking rsa v0.9.6 [INFO] [stderr] Checking makiko v0.2.3 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Checking bollard-stubs v1.44.0-rc.2 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `makiko` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/client/pump.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/client/pump.rs:4:6 [INFO] [stderr] | [INFO] [stderr] 4 | ($e:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/client/negotiate.rs:240:35 [INFO] [stdout] | [INFO] [stdout] 240 | let cookie: [u8; 16] = st.rng.gen(); [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/client/pump.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | ($e:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 4 | ($e:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/auth.rs:66:16 [INFO] [stdout] | [INFO] [stdout] 66 | if let Some(payload) = st.auth_st.method.as_mut().unwrap().send_packet(session_id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^----------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/auth.rs:69:13 [INFO] [stdout] | [INFO] [stdout] 69 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 66 ~ match st.auth_st.method.as_mut().unwrap().send_packet(session_id) { Some(payload) => { [INFO] [stdout] 67 | st.codec.send_pipe.feed_packet(&payload); [INFO] [stdout] 68 | return Ok(Pump::Progress) [INFO] [stdout] 69 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/auth.rs:112:8 [INFO] [stdout] | [INFO] [stdout] 112 | if let Some(method) = st.auth_st.method.as_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^-----------------^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/auth.rs:115:5 [INFO] [stdout] | [INFO] [stdout] 115 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 112 ~ match st.auth_st.method.as_mut() { Some(method) => { [INFO] [stdout] 113 | method.recv_packet(msg_id, payload)?; [INFO] [stdout] 114 | Ok(None) [INFO] [stdout] 115 ~ } _ => { [INFO] [stdout] 116 | Err(Error::PacketNotImplemented(msg_id)) [INFO] [stdout] 117 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/auth.rs:127:8 [INFO] [stdout] | [INFO] [stdout] 127 | if let Some(method) = st.auth_st.method.as_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^-----------------^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/auth.rs:130:5 [INFO] [stdout] | [INFO] [stdout] 130 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 127 ~ match st.auth_st.method.as_mut() { Some(method) => { [INFO] [stdout] 128 | method.recv_failure(failure)?; [INFO] [stdout] 129 | Ok(None) [INFO] [stdout] 130 ~ } _ => { [INFO] [stdout] 131 | Err(Error::Protocol("received unexpected SSH_MSG_USERAUTH_FAILURE")) [INFO] [stdout] 132 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/auth_method/pubkey.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 50 | if let Some(result_tx) = self.result_tx.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^--------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/auth_method/pubkey.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 50 ~ match self.result_tx.take() { Some(result_tx) => { [INFO] [stdout] 51 | let _: Result<_, _> = result_tx.send(result); [INFO] [stdout] 52 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/auth_method/pubkey.rs:148:12 [INFO] [stdout] | [INFO] [stdout] 148 | if let Some(result_tx) = self.result_tx.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^--------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/auth_method/pubkey.rs:150:9 [INFO] [stdout] | [INFO] [stdout] 150 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 148 ~ match self.result_tx.take() { Some(result_tx) => { [INFO] [stdout] 149 | let _: Result<_, _> = result_tx.send(result); [INFO] [stdout] 150 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl Future>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/client/channel.rs:109:66 [INFO] [stdout] | [INFO] [stdout] 109 | fn send_channel_data(&self, data: ChannelSendData) -> Result>> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/client/channel.rs:109:26 [INFO] [stdout] | [INFO] [stdout] 109 | fn send_channel_data(&self, data: ChannelSendData) -> Result>> { [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] = note: `--force-warn impl-trait-overcaptures` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 109 | fn send_channel_data(&self, data: ChannelSendData) -> Result> + use<>> { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/channel_state.rs:125:16 [INFO] [stdout] | [INFO] [stdout] 125 | if let Poll::Ready(reply) = Pin::new(&mut send_reply.reply_rx).poll(cx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------------------^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/channel_state.rs:133:13 [INFO] [stdout] | [INFO] [stdout] 133 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 125 ~ match Pin::new(&mut send_reply.reply_rx).poll(cx) { Poll::Ready(reply) => { [INFO] [stdout] 126 | let reply = match reply { [INFO] [stdout] ... [INFO] [stdout] 132 | return Ok(Pump::Progress) [INFO] [stdout] 133 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl Future>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/client/channel_state.rs:251:13 [INFO] [stdout] | [INFO] [stdout] 251 | ) -> Result>> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, these lifetimes are in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/client/channel_state.rs:248:9 [INFO] [stdout] | [INFO] [stdout] 248 | st: &mut ClientState, [INFO] [stdout] | ^ [INFO] [stdout] 249 | channel_st: &mut ChannelState, [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 251 | ) -> Result> + use<>> { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/client_state.rs:112:8 [INFO] [stdout] | [INFO] [stdout] 112 | if let Some(waker) = st.waker.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^--------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/client_state.rs:114:5 [INFO] [stdout] | [INFO] [stdout] 114 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 112 ~ match st.waker.take() { Some(waker) => { [INFO] [stdout] 113 | waker.wake(); [INFO] [stdout] 114 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/conn.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 101 | if let Some(req) = st.conn_st.send_reqs.pop_front() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^-------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/conn.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 101 ~ match st.conn_st.send_reqs.pop_front() { Some(req) => { [INFO] [stdout] 102 | let packet_seq = send_global_request(st, &req); [INFO] [stdout] ... [INFO] [stdout] 106 | return Ok(Pump::Progress) [INFO] [stdout] 107 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/conn.rs:118:11 [INFO] [stdout] | [INFO] [stdout] 118 | while let Some(open) = st.conn_st.open_channels.pop_front() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/conn.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 123 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/negotiate.rs:231:8 [INFO] [stdout] | [INFO] [stdout] 231 | if let Some(kex) = st.negotiate_st.kex.as_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^-------------------^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/negotiate.rs:234:5 [INFO] [stdout] | [INFO] [stdout] 234 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 231 ~ match st.negotiate_st.kex.as_mut() { Some(kex) => { [INFO] [stdout] 232 | kex.recv_packet(msg_id, payload)?; [INFO] [stdout] 233 | Ok(None) [INFO] [stdout] 234 ~ } _ => { [INFO] [stdout] 235 | Err(Error::Protocol("received unexpected kex message")) [INFO] [stdout] 236 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/negotiate.rs:533:8 [INFO] [stdout] | [INFO] [stdout] 533 | if let Some(done_tx) = done_tx { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/negotiate.rs:535:5 [INFO] [stdout] | [INFO] [stdout] 535 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 533 ~ match done_tx { Some(done_tx) => { [INFO] [stdout] 534 | st.negotiate_st.done_txs.push(done_tx); [INFO] [stdout] 535 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/keys/openssh.rs:103:12 [INFO] [stdout] | [INFO] [stdout] 103 | if let Ok(plaintext) = decrypt(&raw, &[]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/keys/openssh.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 103 ~ match decrypt(&raw, &[]) { Ok(plaintext) => { [INFO] [stdout] 104 | let (privkey, comment) = decode_plaintext(plaintext)?; [INFO] [stdout] 105 | (Some(privkey), Some(comment)) [INFO] [stdout] 106 ~ } _ => { [INFO] [stdout] 107 | (None, None) [INFO] [stdout] 108 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 16 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking bollard v0.16.1 [INFO] [stderr] Migrating tests/compat/main.rs from 2021 edition to 2024 [INFO] [stderr] Fixed tests/compat/tunnel_test.rs (1 fix) [INFO] [stderr] Migrating examples/tutorial_5.rs from 2021 edition to 2024 [INFO] [stderr] Fixed tests/compat/smoke_test.rs (2 fixes) [INFO] [stderr] Fixed tests/compat/session_test.rs (4 fixes) [INFO] [stderr] Fixed tests/compat/auth_test.rs (1 fix) [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> tests/compat/auth_test.rs:329:15 [INFO] [stdout] | [INFO] [stdout] 329 | while let Some(event) = client_rx.recv().await? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> tests/compat/auth_test.rs:333:9 [INFO] [stdout] | [INFO] [stdout] 333 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> tests/compat/nursery.rs:117:15 [INFO] [stdout] | [INFO] [stdout] 117 | while let Some(res) = self.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^----------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> tests/compat/nursery.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 119 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> tests/compat/session_test.rs:53:19 [INFO] [stdout] | [INFO] [stdout] 53 | while let Some(event) = session_rx.recv().await? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> tests/compat/session_test.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 73 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> tests/compat/session_test.rs:151:19 [INFO] [stdout] | [INFO] [stdout] 151 | while let Some(event) = session_rx.recv().await? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> tests/compat/session_test.rs:159:13 [INFO] [stdout] | [INFO] [stdout] 159 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> tests/compat/session_test.rs:184:19 [INFO] [stdout] | [INFO] [stdout] 184 | while let Some(event) = session_rx.recv().await? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> tests/compat/session_test.rs:198:13 [INFO] [stdout] | [INFO] [stdout] 198 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> tests/compat/session_test.rs:227:19 [INFO] [stdout] | [INFO] [stdout] 227 | while let Some(event) = session_rx.recv().await? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> tests/compat/session_test.rs:233:13 [INFO] [stdout] | [INFO] [stdout] 233 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> tests/compat/session_test.rs:268:19 [INFO] [stdout] | [INFO] [stdout] 268 | while let Some(event) = session_rx.recv().await? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> tests/compat/session_test.rs:274:13 [INFO] [stdout] | [INFO] [stdout] 274 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> tests/compat/session_test.rs:320:15 [INFO] [stdout] | [INFO] [stdout] 320 | while let Some(event) = client_rx.recv().await? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> tests/compat/session_test.rs:324:9 [INFO] [stdout] | [INFO] [stdout] 324 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> tests/compat/smoke_test.rs:103:15 [INFO] [stdout] | [INFO] [stdout] 103 | while let Some(event) = client_rx.recv().await? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> tests/compat/smoke_test.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> tests/compat/smoke_test.rs:122:19 [INFO] [stdout] | [INFO] [stdout] 122 | while let Some(event) = session_rx.recv().await? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> tests/compat/smoke_test.rs:128:13 [INFO] [stdout] | [INFO] [stdout] 128 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> tests/compat/tunnel_test.rs:159:15 [INFO] [stdout] | [INFO] [stdout] 159 | while let Some(event) = client_rx.recv().await? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> tests/compat/tunnel_test.rs:166:9 [INFO] [stdout] | [INFO] [stdout] 166 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating examples/tutorial_6.rs from 2021 edition to 2024 [INFO] [stderr] Migrating tests/keys/main.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/client.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `keys` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * tests/keys/main.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> tests/keys/main.rs:13:6 [INFO] [stderr] | [INFO] [stderr] 13 | ($a:expr_2021, $b:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> tests/keys/main.rs:13:20 [INFO] [stderr] | [INFO] [stderr] 13 | ($a:expr_2021, $b:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> tests/keys/main.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | ($a:expr, $b:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 13 | ($a:expr_2021, $b:expr) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> tests/keys/main.rs:13:18 [INFO] [stdout] | [INFO] [stdout] 13 | ($a:expr, $b:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 13 | ($a:expr, $b:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `client` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * examples/client.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> examples/client.rs:830:10 [INFO] [stderr] | [INFO] [stderr] 830 | ($mode:expr_2021, $field:ident, $op:ident) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stderr] Migrating examples/tutorial_1.rs from 2021 edition to 2024 [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> examples/client.rs:830:16 [INFO] [stdout] | [INFO] [stdout] 830 | ($mode:expr, $field:ident, $op:ident) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 830 | ($mode:expr_2021, $field:ident, $op:ident) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> examples/client.rs:554:15 [INFO] [stdout] | [INFO] [stdout] 554 | while let Some(event) = session_rx.recv().await? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> examples/client.rs:577:9 [INFO] [stdout] | [INFO] [stdout] 577 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> examples/client.rs:669:15 [INFO] [stdout] | [INFO] [stdout] 669 | while let Some(event) = tunnel_rx.recv().await? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> examples/client.rs:677:9 [INFO] [stdout] | [INFO] [stdout] 677 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating examples/tutorial_7.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/tutorial_2.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/tutorial_4.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/tutorial_3.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `makiko` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/client/pump.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/client/pump.rs:4:6 [INFO] [stderr] | [INFO] [stderr] 4 | ($e:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/client/negotiate.rs:240:35 [INFO] [stdout] | [INFO] [stdout] 240 | let cookie: [u8; 16] = st.rng.gen(); [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/client/pump.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | ($e:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 4 | ($e:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/auth.rs:66:16 [INFO] [stdout] | [INFO] [stdout] 66 | if let Some(payload) = st.auth_st.method.as_mut().unwrap().send_packet(session_id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^----------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/auth.rs:69:13 [INFO] [stdout] | [INFO] [stdout] 69 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 66 ~ match st.auth_st.method.as_mut().unwrap().send_packet(session_id) { Some(payload) => { [INFO] [stdout] 67 | st.codec.send_pipe.feed_packet(&payload); [INFO] [stdout] 68 | return Ok(Pump::Progress) [INFO] [stdout] 69 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/auth.rs:112:8 [INFO] [stdout] | [INFO] [stdout] 112 | if let Some(method) = st.auth_st.method.as_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^-----------------^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/auth.rs:115:5 [INFO] [stdout] | [INFO] [stdout] 115 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 112 ~ match st.auth_st.method.as_mut() { Some(method) => { [INFO] [stdout] 113 | method.recv_packet(msg_id, payload)?; [INFO] [stdout] 114 | Ok(None) [INFO] [stdout] 115 ~ } _ => { [INFO] [stdout] 116 | Err(Error::PacketNotImplemented(msg_id)) [INFO] [stdout] 117 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/auth.rs:127:8 [INFO] [stdout] | [INFO] [stdout] 127 | if let Some(method) = st.auth_st.method.as_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^-----------------^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/auth.rs:130:5 [INFO] [stdout] | [INFO] [stdout] 130 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 127 ~ match st.auth_st.method.as_mut() { Some(method) => { [INFO] [stdout] 128 | method.recv_failure(failure)?; [INFO] [stdout] 129 | Ok(None) [INFO] [stdout] 130 ~ } _ => { [INFO] [stdout] 131 | Err(Error::Protocol("received unexpected SSH_MSG_USERAUTH_FAILURE")) [INFO] [stdout] 132 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/auth_method/pubkey.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 50 | if let Some(result_tx) = self.result_tx.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^--------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/auth_method/pubkey.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 50 ~ match self.result_tx.take() { Some(result_tx) => { [INFO] [stdout] 51 | let _: Result<_, _> = result_tx.send(result); [INFO] [stdout] 52 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/auth_method/pubkey.rs:148:12 [INFO] [stdout] | [INFO] [stdout] 148 | if let Some(result_tx) = self.result_tx.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^--------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/auth_method/pubkey.rs:150:9 [INFO] [stdout] | [INFO] [stdout] 150 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 148 ~ match self.result_tx.take() { Some(result_tx) => { [INFO] [stdout] 149 | let _: Result<_, _> = result_tx.send(result); [INFO] [stdout] 150 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl Future>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/client/channel.rs:109:66 [INFO] [stdout] | [INFO] [stdout] 109 | fn send_channel_data(&self, data: ChannelSendData) -> Result>> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/client/channel.rs:109:26 [INFO] [stdout] | [INFO] [stdout] 109 | fn send_channel_data(&self, data: ChannelSendData) -> Result>> { [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] = note: `--force-warn impl-trait-overcaptures` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 109 | fn send_channel_data(&self, data: ChannelSendData) -> Result> + use<>> { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/channel_state.rs:125:16 [INFO] [stdout] | [INFO] [stdout] 125 | if let Poll::Ready(reply) = Pin::new(&mut send_reply.reply_rx).poll(cx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------------------^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/channel_state.rs:133:13 [INFO] [stdout] | [INFO] [stdout] 133 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 125 ~ match Pin::new(&mut send_reply.reply_rx).poll(cx) { Poll::Ready(reply) => { [INFO] [stdout] 126 | let reply = match reply { [INFO] [stdout] ... [INFO] [stdout] 132 | return Ok(Pump::Progress) [INFO] [stdout] 133 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl Future>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/client/channel_state.rs:251:13 [INFO] [stdout] | [INFO] [stdout] 251 | ) -> Result>> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, these lifetimes are in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/client/channel_state.rs:248:9 [INFO] [stdout] | [INFO] [stdout] 248 | st: &mut ClientState, [INFO] [stdout] | ^ [INFO] [stdout] 249 | channel_st: &mut ChannelState, [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 251 | ) -> Result> + use<>> { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/client_state.rs:112:8 [INFO] [stdout] | [INFO] [stdout] 112 | if let Some(waker) = st.waker.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^--------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/client_state.rs:114:5 [INFO] [stdout] | [INFO] [stdout] 114 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 112 ~ match st.waker.take() { Some(waker) => { [INFO] [stdout] 113 | waker.wake(); [INFO] [stdout] 114 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/conn.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 101 | if let Some(req) = st.conn_st.send_reqs.pop_front() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^-------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/conn.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 101 ~ match st.conn_st.send_reqs.pop_front() { Some(req) => { [INFO] [stdout] 102 | let packet_seq = send_global_request(st, &req); [INFO] [stdout] ... [INFO] [stdout] 106 | return Ok(Pump::Progress) [INFO] [stdout] 107 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/conn.rs:118:11 [INFO] [stdout] | [INFO] [stdout] 118 | while let Some(open) = st.conn_st.open_channels.pop_front() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/conn.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 123 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/negotiate.rs:231:8 [INFO] [stdout] | [INFO] [stdout] 231 | if let Some(kex) = st.negotiate_st.kex.as_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^-------------------^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/negotiate.rs:234:5 [INFO] [stdout] | [INFO] [stdout] 234 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 231 ~ match st.negotiate_st.kex.as_mut() { Some(kex) => { [INFO] [stdout] 232 | kex.recv_packet(msg_id, payload)?; [INFO] [stdout] 233 | Ok(None) [INFO] [stdout] 234 ~ } _ => { [INFO] [stdout] 235 | Err(Error::Protocol("received unexpected kex message")) [INFO] [stdout] 236 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/negotiate.rs:533:8 [INFO] [stdout] | [INFO] [stdout] 533 | if let Some(done_tx) = done_tx { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/negotiate.rs:535:5 [INFO] [stdout] | [INFO] [stdout] 535 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 533 ~ match done_tx { Some(done_tx) => { [INFO] [stdout] 534 | st.negotiate_st.done_txs.push(done_tx); [INFO] [stdout] 535 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/keys/openssh.rs:103:12 [INFO] [stdout] | [INFO] [stdout] 103 | if let Ok(plaintext) = decrypt(&raw, &[]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/keys/openssh.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 103 ~ match decrypt(&raw, &[]) { Ok(plaintext) => { [INFO] [stdout] 104 | let (privkey, comment) = decode_plaintext(plaintext)?; [INFO] [stdout] 105 | (Some(privkey), Some(comment)) [INFO] [stdout] 106 ~ } _ => { [INFO] [stdout] 107 | (None, None) [INFO] [stdout] 108 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 16 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 32.70s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking makiko v0.2.3 (/tmp/fixit) [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/client/negotiate.rs:240:35 [INFO] [stdout] | [INFO] [stdout] 240 | let cookie: [u8; 16] = st.rng.gen(); [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 240 | let cookie: [u8; 16] = st.rng.r#gen(); [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/client/negotiate.rs:240:35 [INFO] [stdout] | [INFO] [stdout] 240 | let cookie: [u8; 16] = st.rng.gen(); [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 240 | let cookie: [u8; 16] = st.rng.r#gen(); [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0597]: `st` does not live long enough [INFO] [stdout] --> src/client/channel.rs:112:49 [INFO] [stdout] | [INFO] [stdout] 109 | fn send_channel_data(&self, data: ChannelSendData) -> Result>> { [INFO] [stdout] | - let's call the lifetime of this reference `'1` [INFO] [stdout] 110 | let st = self.upgrade_client()?; [INFO] [stdout] | -- binding `st` declared here [INFO] [stdout] 111 | let channel_st = self.upgrade_channel()?; [INFO] [stdout] 112 | let fut = channel_state::send_data(&mut st.lock(), &mut channel_st.lock(), data)?; [INFO] [stdout] | ------------------------------^^-------------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | borrowed value does not live long enough [INFO] [stdout] | argument requires that `st` is borrowed for `'1` [INFO] [stdout] 113 | Ok(fut) [INFO] [stdout] 114 | } [INFO] [stdout] | - `st` dropped here while still borrowed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0716]: temporary value dropped while borrowed [INFO] [stdout] --> src/client/channel.rs:112:49 [INFO] [stdout] | [INFO] [stdout] 109 | fn send_channel_data(&self, data: ChannelSendData) -> Result>> { [INFO] [stdout] | - let's call the lifetime of this reference `'1` [INFO] [stdout] ... [INFO] [stdout] 112 | let fut = channel_state::send_data(&mut st.lock(), &mut channel_st.lock(), data)?; [INFO] [stdout] | ------------------------------^^^^^^^^^------------------------------- - temporary value is freed at the end of this statement [INFO] [stdout] | | | [INFO] [stdout] | | creates a temporary value which is freed while still in use [INFO] [stdout] | argument requires that borrow lasts for `'1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0597]: `channel_st` does not live long enough [INFO] [stdout] --> src/client/channel.rs:112:65 [INFO] [stdout] | [INFO] [stdout] 109 | fn send_channel_data(&self, data: ChannelSendData) -> Result>> { [INFO] [stdout] | - let's call the lifetime of this reference `'1` [INFO] [stdout] 110 | let st = self.upgrade_client()?; [INFO] [stdout] 111 | let channel_st = self.upgrade_channel()?; [INFO] [stdout] | ---------- binding `channel_st` declared here [INFO] [stdout] 112 | let fut = channel_state::send_data(&mut st.lock(), &mut channel_st.lock(), data)?; [INFO] [stdout] | ----------------------------------------------^^^^^^^^^^-------------- [INFO] [stdout] | | | [INFO] [stdout] | | borrowed value does not live long enough [INFO] [stdout] | argument requires that `channel_st` is borrowed for `'1` [INFO] [stdout] 113 | Ok(fut) [INFO] [stdout] 114 | } [INFO] [stdout] | - `channel_st` dropped here while still borrowed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0716]: temporary value dropped while borrowed [INFO] [stdout] --> src/client/channel.rs:112:65 [INFO] [stdout] | [INFO] [stdout] 109 | fn send_channel_data(&self, data: ChannelSendData) -> Result>> { [INFO] [stdout] | - let's call the lifetime of this reference `'1` [INFO] [stdout] ... [INFO] [stdout] 112 | let fut = channel_state::send_data(&mut st.lock(), &mut channel_st.lock(), data)?; [INFO] [stdout] | ----------------------------------------------^^^^^^^^^^^^^^^^^------- - temporary value is freed at the end of this statement [INFO] [stdout] | | | [INFO] [stdout] | | creates a temporary value which is freed while still in use [INFO] [stdout] | argument requires that borrow lasts for `'1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0597]: `st` does not live long enough [INFO] [stdout] --> src/client/channel.rs:112:49 [INFO] [stdout] | [INFO] [stdout] 109 | fn send_channel_data(&self, data: ChannelSendData) -> Result>> { [INFO] [stdout] | - let's call the lifetime of this reference `'1` [INFO] [stdout] 110 | let st = self.upgrade_client()?; [INFO] [stdout] | -- binding `st` declared here [INFO] [stdout] 111 | let channel_st = self.upgrade_channel()?; [INFO] [stdout] 112 | let fut = channel_state::send_data(&mut st.lock(), &mut channel_st.lock(), data)?; [INFO] [stdout] | ------------------------------^^-------------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | borrowed value does not live long enough [INFO] [stdout] | argument requires that `st` is borrowed for `'1` [INFO] [stdout] 113 | Ok(fut) [INFO] [stdout] 114 | } [INFO] [stdout] | - `st` dropped here while still borrowed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0716]: temporary value dropped while borrowed [INFO] [stdout] --> src/client/channel.rs:112:49 [INFO] [stdout] | [INFO] [stdout] 109 | fn send_channel_data(&self, data: ChannelSendData) -> Result>> { [INFO] [stdout] | - let's call the lifetime of this reference `'1` [INFO] [stdout] ... [INFO] [stdout] 112 | let fut = channel_state::send_data(&mut st.lock(), &mut channel_st.lock(), data)?; [INFO] [stdout] | ------------------------------^^^^^^^^^------------------------------- - temporary value is freed at the end of this statement [INFO] [stdout] | | | [INFO] [stdout] | | creates a temporary value which is freed while still in use [INFO] [stdout] | argument requires that borrow lasts for `'1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0597]: `channel_st` does not live long enough [INFO] [stdout] --> src/client/channel.rs:112:65 [INFO] [stdout] | [INFO] [stdout] 109 | fn send_channel_data(&self, data: ChannelSendData) -> Result>> { [INFO] [stdout] | - let's call the lifetime of this reference `'1` [INFO] [stdout] 110 | let st = self.upgrade_client()?; [INFO] [stdout] 111 | let channel_st = self.upgrade_channel()?; [INFO] [stdout] | ---------- binding `channel_st` declared here [INFO] [stdout] 112 | let fut = channel_state::send_data(&mut st.lock(), &mut channel_st.lock(), data)?; [INFO] [stdout] | ----------------------------------------------^^^^^^^^^^-------------- [INFO] [stdout] | | | [INFO] [stdout] | | borrowed value does not live long enough [INFO] [stdout] | argument requires that `channel_st` is borrowed for `'1` [INFO] [stdout] 113 | Ok(fut) [INFO] [stdout] 114 | } [INFO] [stdout] | - `channel_st` dropped here while still borrowed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0716]: temporary value dropped while borrowed [INFO] [stdout] --> src/client/channel.rs:112:65 [INFO] [stdout] | [INFO] [stdout] 109 | fn send_channel_data(&self, data: ChannelSendData) -> Result>> { [INFO] [stdout] | - let's call the lifetime of this reference `'1` [INFO] [stdout] ... [INFO] [stdout] 112 | let fut = channel_state::send_data(&mut st.lock(), &mut channel_st.lock(), data)?; [INFO] [stdout] | ----------------------------------------------^^^^^^^^^^^^^^^^^------- - temporary value is freed at the end of this statement [INFO] [stdout] | | | [INFO] [stdout] | | creates a temporary value which is freed while still in use [INFO] [stdout] | argument requires that borrow lasts for `'1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] Some errors have detailed explanations: E0597, E0716. [INFO] [stdout] [INFO] [stdout] For more information about an error, try `rustc --explain E0597`. [INFO] [stdout] [INFO] [stderr] error: could not compile `makiko` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] Some errors have detailed explanations: E0597, E0716. [INFO] [stdout] [INFO] [stdout] For more information about an error, try `rustc --explain E0597`. [INFO] [stdout] [INFO] [stderr] error: could not compile `makiko` (lib test) due to 6 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "41c461e9ef054a1afdf8fe1850018c72f9d6af27cebd9ca3e2513de1b898777e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "41c461e9ef054a1afdf8fe1850018c72f9d6af27cebd9ca3e2513de1b898777e", kill_on_drop: false }` [INFO] [stdout] 41c461e9ef054a1afdf8fe1850018c72f9d6af27cebd9ca3e2513de1b898777e