[INFO] fetching crate imessage-database 2.0.1... [INFO] checking imessage-database-2.0.1 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate imessage-database 2.0.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate imessage-database 2.0.1 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate imessage-database 2.0.1 [INFO] finished tweaking crates.io crate imessage-database 2.0.1 [INFO] tweaked toml for crates.io crate imessage-database 2.0.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 71 packages to latest compatible versions [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding quick-xml v0.32.0 (available: v0.36.2) [INFO] [stderr] Adding windows-core v0.52.0 (available: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b497caf4a51979323d7b81e00d4350ec3898942488d9e04af47658ce48d8f6e4 [INFO] running `Command { std: "docker" "start" "-a" "b497caf4a51979323d7b81e00d4350ec3898942488d9e04af47658ce48d8f6e4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b497caf4a51979323d7b81e00d4350ec3898942488d9e04af47658ce48d8f6e4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b497caf4a51979323d7b81e00d4350ec3898942488d9e04af47658ce48d8f6e4", kill_on_drop: false }` [INFO] [stdout] b497caf4a51979323d7b81e00d4350ec3898942488d9e04af47658ce48d8f6e4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5af651a8ef0c2f91985690882ad7068d9159dd69a8b1c93cf222c0f4169f71fa [INFO] running `Command { std: "docker" "start" "-a" "5af651a8ef0c2f91985690882ad7068d9159dd69a8b1c93cf222c0f4169f71fa", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling libsqlite3-sys v0.30.1 [INFO] [stderr] Checking quick-xml v0.32.0 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Checking hashlink v0.9.1 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking plist v1.7.0 [INFO] [stderr] Checking rusqlite v0.32.1 [INFO] [stderr] Checking imessage-database v2.0.1 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `imessage_database` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/message_types/url.rs [INFO] [stderr] * src/util/query_context.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] warning: elided lifetime has a name [INFO] [stderr] --> src/message_types/url.rs:65:67 [INFO] [stderr] | [INFO] [stderr] 63 | impl<'a> URLMessage<'a> { [INFO] [stderr] | -- lifetime `'a` declared here [INFO] [stderr] 64 | /// Gets the subtype of the URL message based on the payload [INFO] [stderr] 65 | pub fn get_url_message_override(payload: &'a Value) -> Result { [INFO] [stderr] | ^^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stderr] [INFO] [stderr] error: usage of an `unsafe` block [INFO] [stderr] --> src/util/query_context.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | unsafe { set_var("TZ", "PST") }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: the lint level is defined here [INFO] [stderr] --> src/lib.rs:1:11 [INFO] [stderr] | [INFO] [stderr] 1 | #![forbid(unsafe_code)] [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: usage of an `unsafe` block [INFO] [stderr] --> src/util/query_context.rs:183:9 [INFO] [stderr] | [INFO] [stderr] 183 | unsafe { set_var("TZ", "PST") }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: usage of an `unsafe` block [INFO] [stderr] --> src/util/query_context.rs:208:9 [INFO] [stderr] | [INFO] [stderr] 208 | unsafe { set_var("TZ", "PST") }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stderr] [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/message_types/url.rs:65:67 [INFO] [stdout] | [INFO] [stdout] 63 | impl<'a> URLMessage<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] 64 | /// Gets the subtype of the URL message based on the payload [INFO] [stdout] 65 | pub fn get_url_message_override(payload: &'a Value) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/util/query_context.rs:155:9 [INFO] [stdout] | [INFO] [stdout] 155 | set_var("TZ", "PST"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] = note: `--force-warn deprecated-safe-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 155 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 156 ~ unsafe { set_var("TZ", "PST") }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/util/query_context.rs:181:9 [INFO] [stdout] | [INFO] [stdout] 181 | set_var("TZ", "PST"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 181 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 182 ~ unsafe { set_var("TZ", "PST") }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/util/query_context.rs:205:9 [INFO] [stdout] | [INFO] [stdout] 205 | set_var("TZ", "PST"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 205 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 206 ~ unsafe { set_var("TZ", "PST") }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/tables/chat_handle.rs:137:16 [INFO] [stdout] | [INFO] [stdout] 137 | if let Ok(row) = row { [INFO] [stdout] | ^^^^^^^^^^^^^^--- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/tables/chat_handle.rs:139:13 [INFO] [stdout] | [INFO] [stdout] 139 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 137 ~ match row { Ok(row) => { [INFO] [stdout] 138 | unique_chats_from_messages.insert(row); [INFO] [stdout] 139 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/tables/chat_handle.rs:151:16 [INFO] [stdout] | [INFO] [stdout] 151 | if let Ok(row) = row { [INFO] [stdout] | ^^^^^^^^^^^^^^--- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/tables/chat_handle.rs:153:13 [INFO] [stdout] | [INFO] [stdout] 153 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 151 ~ match row { Ok(row) => { [INFO] [stdout] 152 | unique_chats_from_handles.insert(row); [INFO] [stdout] 153 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/tables/handle.rs:215:20 [INFO] [stdout] | [INFO] [stdout] 215 | if let Some(set) = person_to_id.get_mut(person_centric_id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^------------^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/tables/handle.rs:217:17 [INFO] [stdout] | [INFO] [stdout] 217 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 215 ~ match person_to_id.get_mut(person_centric_id) { Some(set) => { [INFO] [stdout] 216 | set.insert(id.to_owned()); [INFO] [stdout] 217 ~ } _ => { [INFO] [stdout] 218 | let mut set = HashSet::new(); [INFO] [stdout] 219 | set.insert(id.to_owned()); [INFO] [stdout] 220 | person_to_id.insert(person_centric_id.to_owned(), set); [INFO] [stdout] 221 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Fixed src/tables/chat_handle.rs (2 fixes) [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/message_types/url.rs:65:67 [INFO] [stdout] | [INFO] [stdout] 63 | impl<'a> URLMessage<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] 64 | /// Gets the subtype of the URL message based on the payload [INFO] [stdout] 65 | pub fn get_url_message_override(payload: &'a Value) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Fixed src/tables/handle.rs (1 fix) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 10.70s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking imessage-database v2.0.1 (/tmp/fixit) [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/message_types/url.rs:65:67 [INFO] [stdout] | [INFO] [stdout] 63 | impl<'a> URLMessage<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] 64 | /// Gets the subtype of the URL message based on the payload [INFO] [stdout] 65 | pub fn get_url_message_override(payload: &'a Value) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/message_types/url.rs:65:67 [INFO] [stdout] | [INFO] [stdout] 63 | impl<'a> URLMessage<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] 64 | /// Gets the subtype of the URL message based on the payload [INFO] [stdout] 65 | pub fn get_url_message_override(payload: &'a Value) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/util/query_context.rs:155:9 [INFO] [stdout] | [INFO] [stdout] 155 | set_var("TZ", "PST"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/util/query_context.rs:181:9 [INFO] [stdout] | [INFO] [stdout] 181 | set_var("TZ", "PST"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/util/query_context.rs:205:9 [INFO] [stdout] | [INFO] [stdout] 205 | set_var("TZ", "PST"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stderr] error: could not compile `imessage-database` (lib test) due to 4 previous errors; 1 warning emitted [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "5af651a8ef0c2f91985690882ad7068d9159dd69a8b1c93cf222c0f4169f71fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5af651a8ef0c2f91985690882ad7068d9159dd69a8b1c93cf222c0f4169f71fa", kill_on_drop: false }` [INFO] [stdout] 5af651a8ef0c2f91985690882ad7068d9159dd69a8b1c93cf222c0f4169f71fa