[INFO] fetching crate ic-agent 0.37.1... [INFO] checking ic-agent-0.37.1 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate ic-agent 0.37.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate ic-agent 0.37.1 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ic-agent 0.37.1 [INFO] finished tweaking crates.io crate ic-agent 0.37.1 [INFO] tweaked toml for crates.io crate ic-agent 0.37.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 247 packages to latest compatible versions [INFO] [stderr] Adding arrayvec v0.5.2 (available: v0.7.6) [INFO] [stderr] Adding block-buffer v0.9.0 (available: v0.10.4) [INFO] [stderr] Adding cached v0.52.0 (available: v0.53.1) [INFO] [stderr] Adding digest v0.9.0 (available: v0.10.7) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding half v1.8.3 (available: v2.4.1) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding ic-transport-types v0.37.1 (available: v0.38.1) [INFO] [stderr] Adding ic-verify-bls-signature v0.5.0 (available: v0.6.0) [INFO] [stderr] Adding idna v0.5.0 (available: v1.0.2) [INFO] [stderr] Adding sha2 v0.9.9 (available: v0.10.8) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] [stderr] Adding tower v0.4.13 (available: v0.5.1) [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-registry v0.2.0 (available: v0.3.0) [INFO] [stderr] Adding windows-strings v0.1.0 (available: v0.2.0) [INFO] [stderr] Adding windows-sys v0.48.0 (available: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (available: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fee38c60da16266e52053911a4cb5f0522e85187acccfb9effb3c425aa4cad34 [INFO] running `Command { std: "docker" "start" "-a" "fee38c60da16266e52053911a4cb5f0522e85187acccfb9effb3c425aa4cad34", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fee38c60da16266e52053911a4cb5f0522e85187acccfb9effb3c425aa4cad34", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fee38c60da16266e52053911a4cb5f0522e85187acccfb9effb3c425aa4cad34", kill_on_drop: false }` [INFO] [stdout] fee38c60da16266e52053911a4cb5f0522e85187acccfb9effb3c425aa4cad34 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 414d14aa003fdc2a0ebc1367a26983281959c15765607a296533d7f76985b7c6 [INFO] running `Command { std: "docker" "start" "-a" "414d14aa003fdc2a0ebc1367a26983281959c15765607a296533d7f76985b7c6", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Fixed Cargo.toml (1 fix) [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking bytes v1.7.2 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking cpufeatures v0.2.14 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Compiling cc v1.1.21 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling httparse v1.9.4 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking rustls-pki-types v1.8.0 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking pem-rfc7468 v0.7.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Checking base16ct v0.2.0 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking der v0.7.9 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Compiling rustls v0.23.13 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking typed-arena v2.0.2 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking data-encoding v2.6.0 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking parking v2.2.1 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking pretty v0.12.3 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking ff v0.13.0 [INFO] [stderr] Checking webpki-roots v0.26.6 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking unicode-normalization v0.1.24 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Checking leb128 v0.2.5 [INFO] [stderr] Checking subtle-ng v2.5.0 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Checking pairing v0.23.0 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Checking rustls-pemfile v2.1.3 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking ipnet v2.10.0 [INFO] [stderr] Checking pem v3.0.4 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking rangemap v1.5.1 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling psm v0.1.23 [INFO] [stderr] Compiling stacker v0.1.17 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking curve25519-dalek-ng v4.1.1 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking ic_bls12_381 v0.10.0 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling candid_derive v0.6.6 [INFO] [stderr] Compiling serde_repr v0.1.19 [INFO] [stderr] Checking elliptic-curve v0.13.8 [INFO] [stderr] Checking ecdsa v0.16.9 [INFO] [stderr] Checking primeorder v0.13.6 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking k256 v0.13.4 [INFO] [stderr] Checking p256 v0.13.2 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Compiling binread_derive v2.1.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking cached v0.52.0 [INFO] [stderr] Checking ic-verify-bls-signature v0.5.0 [INFO] [stderr] Checking backoff v0.4.0 [INFO] [stderr] Checking binread v2.2.0 [INFO] [stderr] Checking rustls-webpki v0.102.8 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking ic_principal v0.1.1 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking ed25519-consensus v2.1.0 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking ic-certification v2.6.0 [INFO] [stderr] Checking h2 v0.4.6 [INFO] [stderr] Checking assert-json-diff v2.0.2 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stderr] Checking candid v0.10.10 [INFO] [stderr] Checking simple_asn1 v0.6.2 [INFO] [stderr] Checking ic-transport-types v0.37.1 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking hyper-util v0.1.9 [INFO] [stderr] Checking hyper-rustls v0.27.3 [INFO] [stderr] Checking mockito v1.5.0 [INFO] [stderr] Checking reqwest v0.12.7 [INFO] [stderr] Checking ic-agent v0.37.1 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `ic_agent` [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/agent/nonce.rs:83:20 [INFO] [stdout] | [INFO] [stdout] 83 | Some(OsRng.gen::<[u8; 16]>().to_vec()) [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/identity/mod.rs:89:49 [INFO] [stdout] | [INFO] [stdout] 89 | ($implementor:ty, $name:ident => $self_expr:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 89 | ($implementor:ty, $name:ident => $self_expr:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/identity/mod.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/identity/mod.rs:89:38 [INFO] [stderr] | [INFO] [stderr] 89 | ($implementor:ty, $name:ident => $self_expr:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/agent/mod.rs:491:35 [INFO] [stdout] | [INFO] [stdout] 491 | let node_key = if let Some(node_key) = subnet.node_keys.get(&signature.identity) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/agent/mod.rs:493:17 [INFO] [stdout] | [INFO] [stdout] 493 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 491 ~ let node_key = match subnet.node_keys.get(&signature.identity) { Some(node_key) => { [INFO] [stdout] 492 | node_key [INFO] [stdout] 493 ~ } _ => { [INFO] [stdout] 494 | subnet = self [INFO] [stdout] ... [INFO] [stdout] 500 | .ok_or(AgentError::CertificateNotAuthorized())? [INFO] [stdout] 501 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/agent/mod.rs:1109:12 [INFO] [stdout] | [INFO] [stdout] 1109 | if let Some(subnet) = subnet { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/agent/mod.rs:1111:9 [INFO] [stdout] | [INFO] [stdout] 1111 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 1109 ~ match subnet { Some(subnet) => { [INFO] [stdout] 1110 | Ok(subnet) [INFO] [stdout] 1111 ~ } _ => { [INFO] [stdout] 1112 | self.fetch_subnet_by_canister(canister).await [INFO] [stdout] 1113 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/agent/http_transport/reqwest_transport.rs:178:15 [INFO] [stdout] | [INFO] [stdout] 178 | while let Some(chunk) = stream.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/agent/http_transport/reqwest_transport.rs:189:9 [INFO] [stdout] | [INFO] [stdout] 189 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/agent/response_authentication.rs:165:24 [INFO] [stdout] | [INFO] [stdout] 165 | let subnet_id = if let Some(delegation) = &certificate.delegation { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/agent/response_authentication.rs:167:5 [INFO] [stdout] | [INFO] [stdout] 167 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 165 ~ let subnet_id = match &certificate.delegation { Some(delegation) => { [INFO] [stdout] 166 | Principal::from_slice(delegation.subnet_id.as_ref()) [INFO] [stdout] 167 ~ } _ => { [INFO] [stdout] 168 | Principal::self_authenticating(root_key) [INFO] [stdout] 169 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/agent/response_authentication.rs:173:12 [INFO] [stdout] | [INFO] [stdout] 173 | if let Some(delegation) = &certificate.delegation { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/agent/response_authentication.rs:180:9 [INFO] [stdout] | [INFO] [stdout] 180 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 173 ~ match &certificate.delegation { Some(delegation) => { [INFO] [stdout] 174 | let delegation: Certificate> = [INFO] [stdout] ... [INFO] [stdout] 179 | )?)? [INFO] [stdout] 180 ~ } _ => { [INFO] [stdout] 181 | serde_cbor::from_slice(lookup_value(&subnet_tree, [b"canister_ranges".as_ref()])?)? [INFO] [stdout] 182 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `ic_agent` [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/agent/nonce.rs:83:20 [INFO] [stdout] | [INFO] [stdout] 83 | Some(OsRng.gen::<[u8; 16]>().to_vec()) [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/identity/mod.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/identity/mod.rs:89:49 [INFO] [stdout] | [INFO] [stdout] 89 | ($implementor:ty, $name:ident => $self_expr:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 89 | ($implementor:ty, $name:ident => $self_expr:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/identity/mod.rs:89:38 [INFO] [stderr] | [INFO] [stderr] 89 | ($implementor:ty, $name:ident => $self_expr:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/agent/mod.rs:491:35 [INFO] [stdout] | [INFO] [stdout] 491 | let node_key = if let Some(node_key) = subnet.node_keys.get(&signature.identity) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/agent/mod.rs:493:17 [INFO] [stdout] | [INFO] [stdout] 493 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 491 ~ let node_key = match subnet.node_keys.get(&signature.identity) { Some(node_key) => { [INFO] [stdout] 492 | node_key [INFO] [stdout] 493 ~ } _ => { [INFO] [stdout] 494 | subnet = self [INFO] [stdout] ... [INFO] [stdout] 500 | .ok_or(AgentError::CertificateNotAuthorized())? [INFO] [stdout] 501 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/agent/mod.rs:1109:12 [INFO] [stdout] | [INFO] [stdout] 1109 | if let Some(subnet) = subnet { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/agent/mod.rs:1111:9 [INFO] [stdout] | [INFO] [stdout] 1111 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 1109 ~ match subnet { Some(subnet) => { [INFO] [stdout] 1110 | Ok(subnet) [INFO] [stdout] 1111 ~ } _ => { [INFO] [stdout] 1112 | self.fetch_subnet_by_canister(canister).await [INFO] [stdout] 1113 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/agent/http_transport/reqwest_transport.rs:178:15 [INFO] [stdout] | [INFO] [stdout] 178 | while let Some(chunk) = stream.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/agent/http_transport/reqwest_transport.rs:189:9 [INFO] [stdout] | [INFO] [stdout] 189 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/agent/response_authentication.rs:165:24 [INFO] [stdout] | [INFO] [stdout] 165 | let subnet_id = if let Some(delegation) = &certificate.delegation { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/agent/response_authentication.rs:167:5 [INFO] [stdout] | [INFO] [stdout] 167 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 165 ~ let subnet_id = match &certificate.delegation { Some(delegation) => { [INFO] [stdout] 166 | Principal::from_slice(delegation.subnet_id.as_ref()) [INFO] [stdout] 167 ~ } _ => { [INFO] [stdout] 168 | Principal::self_authenticating(root_key) [INFO] [stdout] 169 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/agent/response_authentication.rs:173:12 [INFO] [stdout] | [INFO] [stdout] 173 | if let Some(delegation) = &certificate.delegation { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/agent/response_authentication.rs:180:9 [INFO] [stdout] | [INFO] [stdout] 180 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 173 ~ match &certificate.delegation { Some(delegation) => { [INFO] [stdout] 174 | let delegation: Certificate> = [INFO] [stdout] ... [INFO] [stdout] 179 | )?)? [INFO] [stdout] 180 ~ } _ => { [INFO] [stdout] 181 | serde_cbor::from_slice(lookup_value(&subnet_tree, [b"canister_ranges".as_ref()])?)? [INFO] [stdout] 182 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 17.64s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking ic-agent v0.37.1 (/tmp/fixit) [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/agent/nonce.rs:83:20 [INFO] [stdout] | [INFO] [stdout] 83 | Some(OsRng.gen::<[u8; 16]>().to_vec()) [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 83 | Some(OsRng.r#gen::<[u8; 16]>().to_vec()) [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/agent/nonce.rs:83:20 [INFO] [stdout] | [INFO] [stdout] 83 | Some(OsRng.gen::<[u8; 16]>().to_vec()) [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 83 | Some(OsRng.r#gen::<[u8; 16]>().to_vec()) [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ic-agent` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ic-agent` (lib test) due to 2 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "414d14aa003fdc2a0ebc1367a26983281959c15765607a296533d7f76985b7c6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "414d14aa003fdc2a0ebc1367a26983281959c15765607a296533d7f76985b7c6", kill_on_drop: false }` [INFO] [stdout] 414d14aa003fdc2a0ebc1367a26983281959c15765607a296533d7f76985b7c6