[INFO] fetching crate hexchat-api 0.3.2... [INFO] checking hexchat-api-0.3.2 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate hexchat-api 0.3.2 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate hexchat-api 0.3.2 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hexchat-api 0.3.2 [INFO] finished tweaking crates.io crate hexchat-api 0.3.2 [INFO] tweaked toml for crates.io crate hexchat-api 0.3.2 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 20 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f3d4bf293fdf7bb38ae6ace193a77fa7c8e0d78dd42bba8a042c0d36e8e5ed7b [INFO] running `Command { std: "docker" "start" "-a" "f3d4bf293fdf7bb38ae6ace193a77fa7c8e0d78dd42bba8a042c0d36e8e5ed7b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f3d4bf293fdf7bb38ae6ace193a77fa7c8e0d78dd42bba8a042c0d36e8e5ed7b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f3d4bf293fdf7bb38ae6ace193a77fa7c8e0d78dd42bba8a042c0d36e8e5ed7b", kill_on_drop: false }` [INFO] [stdout] f3d4bf293fdf7bb38ae6ace193a77fa7c8e0d78dd42bba8a042c0d36e8e5ed7b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 95bec9a13e1f960b65827d8625573a3d4c29ad8fb4b3492b0b61656ee101edec [INFO] running `Command { std: "docker" "start" "-a" "95bec9a13e1f960b65827d8625573a3d4c29ad8fb4b3492b0b61656ee101edec", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Checking send_wrapper v0.6.0 [INFO] [stderr] Checking hexchat-api v0.3.2 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Fixed src/threadsafe_list_iterator.rs (2 fixes) [INFO] [stderr] Fixed src/list_iterator.rs (1 fix) [INFO] [stderr] Fixed src/threadsafe_context.rs (6 fixes) [INFO] [stderr] Fixed src/hexchat_entry_points.rs (2 fixes) [INFO] [stderr] Fixed src/thread_facilities.rs (2 fixes) [INFO] [stderr] Fixed src/callback_data.rs (5 fixes) [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/hook.rs:69:50 [INFO] [stdout] | [INFO] [stdout] 69 | if let Some(hook_list_rwlock) = unsafe { &HOOK_LIST } { [INFO] [stdout] | ^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #114447 [INFO] [stdout] = note: this will be a hard error in the 2024 edition [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] = note: `--force-warn static-mut-refs` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 69 | if let Some(hook_list_rwlock) = unsafe { addr_of!(HOOK_LIST) } { [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/hook.rs:90:43 [INFO] [stdout] | [INFO] [stdout] 90 | if let Some(hl_rwlock) = unsafe { &HOOK_LIST } { [INFO] [stdout] | ^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #114447 [INFO] [stdout] = note: this will be a hard error in the 2024 edition [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 90 | if let Some(hl_rwlock) = unsafe { addr_of!(HOOK_LIST) } { [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/hook.rs:104:43 [INFO] [stdout] | [INFO] [stdout] 104 | if let Some(hl_rwlock) = unsafe { &HOOK_LIST } { [INFO] [stdout] | ^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #114447 [INFO] [stdout] = note: this will be a hard error in the 2024 edition [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 104 | if let Some(hl_rwlock) = unsafe { addr_of!(HOOK_LIST) } { [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/hook.rs:121:38 [INFO] [stdout] | [INFO] [stdout] 121 | if let Some(hl_rwlock) = &HOOK_LIST { [INFO] [stdout] | ^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #114447 [INFO] [stdout] = note: this will be a hard error in the 2024 edition [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 121 | if let Some(hl_rwlock) = addr_of!(HOOK_LIST) { [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/hook.rs:173:43 [INFO] [stdout] | [INFO] [stdout] 173 | if let Some(hl_rwlock) = unsafe { &HOOK_LIST } { [INFO] [stdout] | ^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #114447 [INFO] [stdout] = note: this will be a hard error in the 2024 edition [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 173 | if let Some(hl_rwlock) = unsafe { addr_of!(HOOK_LIST) } { [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/hexchat_entry_points.rs:282:15 [INFO] [stdout] | [INFO] [stdout] 282 | match &PLUGIN_INFO { Some(info) => { [INFO] [stdout] | ^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #114447 [INFO] [stdout] = note: this will be a hard error in the 2024 edition [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 282 | match addr_of!(PLUGIN_INFO) { Some(info) => { [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/hexchat_entry_points.rs:299:19 [INFO] [stdout] | [INFO] [stdout] 299 | match &PLUGIN_INFO { Some(plugin_info) => { [INFO] [stdout] | ^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #114447 [INFO] [stdout] = note: this will be a hard error in the 2024 edition [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 299 | match addr_of!(PLUGIN_INFO) { Some(plugin_info) => { [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/thread_facilities.rs:249:35 [INFO] [stdout] | [INFO] [stdout] 249 | if let Some(queue) = unsafe { &TASK_QUEUE } { [INFO] [stdout] | ^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #114447 [INFO] [stdout] = note: this will be a hard error in the 2024 edition [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 249 | if let Some(queue) = unsafe { addr_of!(TASK_QUEUE) } { [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/thread_facilities.rs:220:31 [INFO] [stdout] | [INFO] [stdout] 220 | while let Some(mut task) [INFO] [stdout] | ________________________________^ [INFO] [stdout] 221 | | = arc.lock().unwrap().as_mut() [INFO] [stdout] | | _______________________________- [INFO] [stdout] 222 | || .and_then(|q| q.pop_front()) { [INFO] [stdout] | ||____________________________________________________________^ [INFO] [stdout] | |____________________________________________________________| [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/thread_facilities.rs:228:25 [INFO] [stdout] | [INFO] [stdout] 228 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/thread_facilities.rs:251:19 [INFO] [stdout] | [INFO] [stdout] 251 | while let Some(mut task) = queue.pop_front() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^----------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/thread_facilities.rs:253:13 [INFO] [stdout] | [INFO] [stdout] 253 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/hook.rs:69:50 [INFO] [stdout] | [INFO] [stdout] 69 | if let Some(hook_list_rwlock) = unsafe { &HOOK_LIST } { [INFO] [stdout] | ^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #114447 [INFO] [stdout] = note: this will be a hard error in the 2024 edition [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] = note: `--force-warn static-mut-refs` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 69 | if let Some(hook_list_rwlock) = unsafe { addr_of!(HOOK_LIST) } { [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/hook.rs:90:43 [INFO] [stdout] | [INFO] [stdout] 90 | if let Some(hl_rwlock) = unsafe { &HOOK_LIST } { [INFO] [stdout] | ^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #114447 [INFO] [stdout] = note: this will be a hard error in the 2024 edition [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 90 | if let Some(hl_rwlock) = unsafe { addr_of!(HOOK_LIST) } { [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/hook.rs:104:43 [INFO] [stdout] | [INFO] [stdout] 104 | if let Some(hl_rwlock) = unsafe { &HOOK_LIST } { [INFO] [stdout] | ^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #114447 [INFO] [stdout] = note: this will be a hard error in the 2024 edition [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 104 | if let Some(hl_rwlock) = unsafe { addr_of!(HOOK_LIST) } { [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/hook.rs:121:38 [INFO] [stdout] | [INFO] [stdout] 121 | if let Some(hl_rwlock) = &HOOK_LIST { [INFO] [stdout] | ^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #114447 [INFO] [stdout] = note: this will be a hard error in the 2024 edition [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 121 | if let Some(hl_rwlock) = addr_of!(HOOK_LIST) { [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/hook.rs:173:43 [INFO] [stdout] | [INFO] [stdout] 173 | if let Some(hl_rwlock) = unsafe { &HOOK_LIST } { [INFO] [stdout] | ^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #114447 [INFO] [stdout] = note: this will be a hard error in the 2024 edition [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 173 | if let Some(hl_rwlock) = unsafe { addr_of!(HOOK_LIST) } { [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/hexchat_entry_points.rs:282:15 [INFO] [stdout] | [INFO] [stdout] 282 | match &PLUGIN_INFO { Some(info) => { [INFO] [stdout] | ^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #114447 [INFO] [stdout] = note: this will be a hard error in the 2024 edition [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 282 | match addr_of!(PLUGIN_INFO) { Some(info) => { [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/hexchat_entry_points.rs:299:19 [INFO] [stdout] | [INFO] [stdout] 299 | match &PLUGIN_INFO { Some(plugin_info) => { [INFO] [stdout] | ^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #114447 [INFO] [stdout] = note: this will be a hard error in the 2024 edition [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 299 | match addr_of!(PLUGIN_INFO) { Some(plugin_info) => { [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/thread_facilities.rs:249:35 [INFO] [stdout] | [INFO] [stdout] 249 | if let Some(queue) = unsafe { &TASK_QUEUE } { [INFO] [stdout] | ^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #114447 [INFO] [stdout] = note: this will be a hard error in the 2024 edition [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 249 | if let Some(queue) = unsafe { addr_of!(TASK_QUEUE) } { [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/thread_facilities.rs:220:31 [INFO] [stdout] | [INFO] [stdout] 220 | while let Some(mut task) [INFO] [stdout] | ________________________________^ [INFO] [stdout] 221 | | = arc.lock().unwrap().as_mut() [INFO] [stdout] | | _______________________________- [INFO] [stdout] 222 | || .and_then(|q| q.pop_front()) { [INFO] [stdout] | ||____________________________________________________________^ [INFO] [stdout] | |____________________________________________________________| [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/thread_facilities.rs:228:25 [INFO] [stdout] | [INFO] [stdout] 228 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/thread_facilities.rs:251:19 [INFO] [stdout] | [INFO] [stdout] 251 | while let Some(mut task) = queue.pop_front() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^----------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/thread_facilities.rs:253:13 [INFO] [stdout] | [INFO] [stdout] 253 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.64s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking hexchat-api v0.3.2 (/tmp/fixit) [INFO] [stdout] error[E0796]: creating a shared reference to a mutable static [INFO] [stdout] --> src/hook.rs:69:50 [INFO] [stdout] | [INFO] [stdout] 69 | if let Some(hook_list_rwlock) = unsafe { &HOOK_LIST } { [INFO] [stdout] | ^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 69 | if let Some(hook_list_rwlock) = unsafe { addr_of!(HOOK_LIST) } { [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0796]: creating a shared reference to a mutable static [INFO] [stdout] --> src/hook.rs:69:50 [INFO] [stdout] | [INFO] [stdout] 69 | if let Some(hook_list_rwlock) = unsafe { &HOOK_LIST } { [INFO] [stdout] | ^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 69 | if let Some(hook_list_rwlock) = unsafe { addr_of!(HOOK_LIST) } { [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0796]: creating a shared reference to a mutable static [INFO] [stdout] --> src/hook.rs:90:43 [INFO] [stdout] | [INFO] [stdout] 90 | if let Some(hl_rwlock) = unsafe { &HOOK_LIST } { [INFO] [stdout] | ^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 90 | if let Some(hl_rwlock) = unsafe { addr_of!(HOOK_LIST) } { [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0796]: creating a shared reference to a mutable static [INFO] [stdout] --> src/hook.rs:90:43 [INFO] [stdout] | [INFO] [stdout] 90 | if let Some(hl_rwlock) = unsafe { &HOOK_LIST } { [INFO] [stdout] | ^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 90 | if let Some(hl_rwlock) = unsafe { addr_of!(HOOK_LIST) } { [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0796]: creating a shared reference to a mutable static [INFO] [stdout] --> src/hook.rs:104:43 [INFO] [stdout] | [INFO] [stdout] 104 | if let Some(hl_rwlock) = unsafe { &HOOK_LIST } { [INFO] [stdout] | ^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 104 | if let Some(hl_rwlock) = unsafe { addr_of!(HOOK_LIST) } { [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0796]: creating a shared reference to a mutable static [INFO] [stdout] --> src/hook.rs:104:43 [INFO] [stdout] | [INFO] [stdout] 104 | if let Some(hl_rwlock) = unsafe { &HOOK_LIST } { [INFO] [stdout] | ^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 104 | if let Some(hl_rwlock) = unsafe { addr_of!(HOOK_LIST) } { [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0796]: creating a shared reference to a mutable static [INFO] [stdout] --> src/hook.rs:121:38 [INFO] [stdout] | [INFO] [stdout] 121 | if let Some(hl_rwlock) = &HOOK_LIST { [INFO] [stdout] | ^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 121 | if let Some(hl_rwlock) = addr_of!(HOOK_LIST) { [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0796]: creating a shared reference to a mutable static [INFO] [stdout] --> src/hook.rs:121:38 [INFO] [stdout] | [INFO] [stdout] 121 | if let Some(hl_rwlock) = &HOOK_LIST { [INFO] [stdout] | ^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 121 | if let Some(hl_rwlock) = addr_of!(HOOK_LIST) { [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0796]: creating a shared reference to a mutable static [INFO] [stdout] --> src/hook.rs:173:43 [INFO] [stdout] | [INFO] [stdout] 173 | if let Some(hl_rwlock) = unsafe { &HOOK_LIST } { [INFO] [stdout] | ^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 173 | if let Some(hl_rwlock) = unsafe { addr_of!(HOOK_LIST) } { [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0796]: creating a shared reference to a mutable static [INFO] [stdout] --> src/hook.rs:173:43 [INFO] [stdout] | [INFO] [stdout] 173 | if let Some(hl_rwlock) = unsafe { &HOOK_LIST } { [INFO] [stdout] | ^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 173 | if let Some(hl_rwlock) = unsafe { addr_of!(HOOK_LIST) } { [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0796]: creating a shared reference to a mutable static [INFO] [stdout] --> src/hexchat_entry_points.rs:282:15 [INFO] [stdout] | [INFO] [stdout] 282 | match &PLUGIN_INFO { Some(info) => { [INFO] [stdout] | ^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 282 | match addr_of!(PLUGIN_INFO) { Some(info) => { [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0796]: creating a shared reference to a mutable static [INFO] [stdout] --> src/hexchat_entry_points.rs:282:15 [INFO] [stdout] | [INFO] [stdout] 282 | match &PLUGIN_INFO { Some(info) => { [INFO] [stdout] | ^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 282 | match addr_of!(PLUGIN_INFO) { Some(info) => { [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0796]: creating a shared reference to a mutable static [INFO] [stdout] --> src/hexchat_entry_points.rs:299:19 [INFO] [stdout] | [INFO] [stdout] 299 | match &PLUGIN_INFO { Some(plugin_info) => { [INFO] [stdout] | ^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 299 | match addr_of!(PLUGIN_INFO) { Some(plugin_info) => { [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0796]: creating a shared reference to a mutable static [INFO] [stdout] --> src/hexchat_entry_points.rs:299:19 [INFO] [stdout] | [INFO] [stdout] 299 | match &PLUGIN_INFO { Some(plugin_info) => { [INFO] [stdout] | ^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 299 | match addr_of!(PLUGIN_INFO) { Some(plugin_info) => { [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0796]: creating a shared reference to a mutable static [INFO] [stdout] --> src/thread_facilities.rs:249:35 [INFO] [stdout] | [INFO] [stdout] 249 | if let Some(queue) = unsafe { &TASK_QUEUE } { [INFO] [stdout] | ^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 249 | if let Some(queue) = unsafe { addr_of!(TASK_QUEUE) } { [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0796]: creating a shared reference to a mutable static [INFO] [stdout] --> src/thread_facilities.rs:249:35 [INFO] [stdout] | [INFO] [stdout] 249 | if let Some(queue) = unsafe { &TASK_QUEUE } { [INFO] [stdout] | ^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 249 | if let Some(queue) = unsafe { addr_of!(TASK_QUEUE) } { [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0796`. [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0796`. [INFO] [stdout] [INFO] [stderr] error: could not compile `hexchat-api` (lib test) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `hexchat-api` (lib) due to 9 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "95bec9a13e1f960b65827d8625573a3d4c29ad8fb4b3492b0b61656ee101edec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "95bec9a13e1f960b65827d8625573a3d4c29ad8fb4b3492b0b61656ee101edec", kill_on_drop: false }` [INFO] [stdout] 95bec9a13e1f960b65827d8625573a3d4c29ad8fb4b3492b0b61656ee101edec