[INFO] fetching crate git-repo-manager 0.7.18... [INFO] checking git-repo-manager-0.7.18 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate git-repo-manager 0.7.18 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate git-repo-manager 0.7.18 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-2-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate git-repo-manager 0.7.18 [INFO] finished tweaking crates.io crate git-repo-manager 0.7.18 [INFO] tweaked toml for crates.io crate git-repo-manager 0.7.18 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate git-repo-manager 0.7.18 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8e773267402e550d184704b24f35d70fbe132920703092c9e87ed75b09c914bb [INFO] running `Command { std: "docker" "start" "-a" "8e773267402e550d184704b24f35d70fbe132920703092c9e87ed75b09c914bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8e773267402e550d184704b24f35d70fbe132920703092c9e87ed75b09c914bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8e773267402e550d184704b24f35d70fbe132920703092c9e87ed75b09c914bb", kill_on_drop: false }` [INFO] [stdout] 8e773267402e550d184704b24f35d70fbe132920703092c9e87ed75b09c914bb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5593ff7908978ced3b0c978e074eb6725168a6612c9ef2cf6c5bb0fee448d6f1 [INFO] running `Command { std: "docker" "start" "-a" "5593ff7908978ced3b0c978e074eb6725168a6612c9ef2cf6c5bb0fee448d6f1", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking indexmap v2.4.0 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling rustls v0.23.12 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking webpki-roots v0.26.3 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Compiling git-repo-manager v0.7.18 (/tmp/fixit) [INFO] [stderr] Checking url-escape v0.1.1 [INFO] [stderr] Compiling outdir-tempdir v0.2.0 [INFO] [stderr] Migrating build.rs from 2021 edition to 2024 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Compiling syn v2.0.76 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling cc v1.1.14 [INFO] [stderr] Checking shellexpand v3.1.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking parse_link_header v0.4.0 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Compiling libz-sys v1.1.20 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling libssh2-sys v0.3.0 [INFO] [stderr] Compiling libgit2-sys v0.17.0+1.8.1 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking rustls-webpki v0.102.6 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking comfy-table v7.1.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking git2 v0.19.0 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking ureq v2.10.1 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Fixed src/table.rs (4 fixes) [INFO] [stderr] Fixed src/repo.rs (10 fixes) [INFO] [stderr] Fixed src/tree.rs (2 fixes) [INFO] [stderr] Fixed src/worktree.rs (13 fixes) [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/repo.rs:232:23 [INFO] [stdout] | [INFO] [stdout] 232 | while let Some(operation) = rebase.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/repo.rs:258:17 [INFO] [stdout] | [INFO] [stdout] 258 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/repo.rs:356:15 [INFO] [stdout] | [INFO] [stdout] 356 | while let Some(operation) = rebase.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/repo.rs:382:9 [INFO] [stdout] | [INFO] [stdout] 382 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating src/grm/main.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `grm` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/path.rs [INFO] [stderr] * src/repo.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error: usage of an `unsafe` block [INFO] [stderr] --> src/path.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | unsafe { std::env::set_var("HOME", "/home/test") }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: the lint level is defined here [INFO] [stderr] --> src/lib.rs:1:11 [INFO] [stderr] | [INFO] [stderr] 1 | #![forbid(unsafe_code)] [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stderr] --> src/repo.rs:232:23 [INFO] [stderr] | [INFO] [stderr] 232 | while let Some(operation) = rebase.next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^------------- [INFO] [stderr] | | [INFO] [stderr] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stderr] | [INFO] [stderr] = warning: this changes meaning in Rust 2024 [INFO] [stderr] = note: for more information, see issue #124085 [INFO] [stderr] help: the value is now dropped here in Edition 2024 [INFO] [stderr] --> src/repo.rs:258:17 [INFO] [stderr] | [INFO] [stderr] 258 | } [INFO] [stderr] | ^ [INFO] [stderr] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stderr] [INFO] [stderr] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stderr] --> src/repo.rs:356:15 [INFO] [stderr] | [INFO] [stderr] 356 | while let Some(operation) = rebase.next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^------------- [INFO] [stderr] | | [INFO] [stderr] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stderr] | [INFO] [stderr] = warning: this changes meaning in Rust 2024 [INFO] [stderr] = note: for more information, see issue #124085 [INFO] [stderr] help: the value is now dropped here in Edition 2024 [INFO] [stderr] --> src/repo.rs:382:9 [INFO] [stderr] | [INFO] [stderr] 382 | } [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stderr] [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/path.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | std::env::set_var("HOME", "/home/test"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] = note: `--force-warn deprecated-safe-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 11 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 12 ~ unsafe { std::env::set_var("HOME", "/home/test") }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/repo.rs:232:23 [INFO] [stdout] | [INFO] [stdout] 232 | while let Some(operation) = rebase.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/repo.rs:258:17 [INFO] [stdout] | [INFO] [stdout] 258 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/repo.rs:356:15 [INFO] [stdout] | [INFO] [stdout] 356 | while let Some(operation) = rebase.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/repo.rs:382:9 [INFO] [stdout] | [INFO] [stdout] 382 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating tests/helpers.rs from 2021 edition to 2024 [INFO] [stderr] Migrating tests/repo.rs from 2021 edition to 2024 [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 13.69s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Compiling git-repo-manager v0.7.18 (/tmp/fixit) [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/path.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | std::env::set_var("HOME", "/home/test"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stderr] error: could not compile `git-repo-manager` (lib test) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "5593ff7908978ced3b0c978e074eb6725168a6612c9ef2cf6c5bb0fee448d6f1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5593ff7908978ced3b0c978e074eb6725168a6612c9ef2cf6c5bb0fee448d6f1", kill_on_drop: false }` [INFO] [stdout] 5593ff7908978ced3b0c978e074eb6725168a6612c9ef2cf6c5bb0fee448d6f1