[INFO] fetching crate garbage 0.4.3... [INFO] checking garbage-0.4.3 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate garbage 0.4.3 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate garbage 0.4.3 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-5-tc2/source/.cargo/config.toml [INFO] started tweaking crates.io crate garbage 0.4.3 [INFO] finished tweaking crates.io crate garbage 0.4.3 [INFO] tweaked toml for crates.io crate garbage 0.4.3 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate garbage 0.4.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8a79890d543bba578bda480ff9cb316fd5a34cc6402ab0d4bcbe2a6b907b5d47 [INFO] running `Command { std: "docker" "start" "-a" "8a79890d543bba578bda480ff9cb316fd5a34cc6402ab0d4bcbe2a6b907b5d47", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8a79890d543bba578bda480ff9cb316fd5a34cc6402ab0d4bcbe2a6b907b5d47", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8a79890d543bba578bda480ff9cb316fd5a34cc6402ab0d4bcbe2a6b907b5d47", kill_on_drop: false }` [INFO] [stdout] 8a79890d543bba578bda480ff9cb316fd5a34cc6402ab0d4bcbe2a6b907b5d47 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 587effdb22ec31441e66c32a8e4de9a160918ff5f1f2a03b03fba033dd3aad09 [INFO] running `Command { std: "docker" "start" "-a" "587effdb22ec31441e66c32a8e4de9a160918ff5f1f2a03b03fba033dd3aad09", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling proc-macro2 v1.0.84 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Compiling cc v1.0.98 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking miniz_oxide v0.7.3 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Compiling garbage v0.4.3 (/tmp/fixit) [INFO] [stderr] Migrating build.rs from 2021 edition to 2024 [INFO] [stderr] Checking unicode-width v0.1.12 [INFO] [stderr] Checking encode_unicode v1.0.0 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking xdg v2.5.2 [INFO] [stderr] Checking garbage-fs v0.1.0 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling backtrace v0.3.71 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking term v0.7.0 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Checking prettytable-rs v0.10.0 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking clap_complete v4.5.2 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking serde_json v1.0.117 [INFO] [stderr] Checking chrono-humanize v0.2.3 [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `garbage` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/ops/empty.rs [INFO] [stderr] * src/utils.rs [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/utils.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | ($($str:expr),* $(,)?) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 123 | ($($str:expr_2021),* $(,)?) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/ops/empty.rs:38:1 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn empty(options: EmptyOptions, fs: &impl Filesystem) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromIterator<()>` will fail [INFO] [stdout] --> src/ops/empty.rs:81:16 [INFO] [stdout] | [INFO] [stdout] 81 | .collect::>()?; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] = note: `#[warn(dependency_on_unit_never_type_fallback)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/utils.rs:123:8 [INFO] [stderr] | [INFO] [stderr] 123 | ($($str:expr_2021),* $(,)?) => { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] warning: this function depends on never type fallback being `()` [INFO] [stderr] --> src/ops/empty.rs:38:1 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn empty(options: EmptyOptions, fs: &impl Filesystem) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #123748 [INFO] [stderr] = help: specify the types explicitly [INFO] [stderr] note: in edition 2024, the requirement `!: FromIterator<()>` will fail [INFO] [stderr] --> src/ops/empty.rs:81:16 [INFO] [stderr] | [INFO] [stderr] 81 | .collect::>()?; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = note: `#[warn(dependency_on_unit_never_type_fallback)]` on by default [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: fields `mount_id`, `parent_id`, `major`, `minor`, and `root` are never read [INFO] [stdout] --> src/mounts.rs:16:7 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct MountPoint { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 16 | pub mount_id: c_ulong, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 17 | pub parent_id: c_ulong, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 18 | pub major: c_ulong, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 19 | pub minor: c_ulong, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 20 | pub root: PathBuf, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MountPoint` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/ops/empty.rs:62:16 [INFO] [stdout] | [INFO] [stdout] 62 | if let Err(err) = fs::remove_dir_all(&info.deleted_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^-------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/ops/empty.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 65 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 62 ~ match fs::remove_dir_all(&info.deleted_path) { Err(err) => { [INFO] [stdout] 63 | error!(?info.deleted_path, "Failed to remove original directory."); [INFO] [stdout] 64 | return Err(err.into()); [INFO] [stdout] 65 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/ops/empty.rs:67:16 [INFO] [stdout] | [INFO] [stdout] 67 | if let Err(err) = fs::remove_file(&info.deleted_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^----------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/ops/empty.rs:70:13 [INFO] [stdout] | [INFO] [stdout] 70 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 67 ~ match fs::remove_file(&info.deleted_path) { Err(err) => { [INFO] [stdout] 68 | error!(?info.deleted_path, "Failed to remove original file."); [INFO] [stdout] 69 | return Err(err.into()); [INFO] [stdout] 70 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/ops/put/mod.rs:91:15 [INFO] [stdout] | [INFO] [stdout] 91 | } else if let Err(err) = strategy.delete(abs_path, &options, fs) { [INFO] [stdout] | ^^^^^^^^^^^^^^^--------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/ops/put/mod.rs:93:5 [INFO] [stdout] | [INFO] [stdout] 93 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 91 ~ } else { match strategy.delete(abs_path, &options, fs) { Err(err) => { [INFO] [stdout] 92 | eprintln!("{}", err); [INFO] [stdout] 93 ~ } _ => {}}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating src/main.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `garbage` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/ops/empty.rs [INFO] [stderr] * src/utils.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/utils.rs:123:8 [INFO] [stderr] | [INFO] [stderr] 123 | ($($str:expr_2021),* $(,)?) => { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/utils.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | ($($str:expr),* $(,)?) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 123 | ($($str:expr_2021),* $(,)?) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/ops/empty.rs:38:1 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn empty(options: EmptyOptions, fs: &impl Filesystem) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromIterator<()>` will fail [INFO] [stdout] --> src/ops/empty.rs:81:16 [INFO] [stdout] | [INFO] [stdout] 81 | .collect::>()?; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] = note: `#[warn(dependency_on_unit_never_type_fallback)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stderr] warning: this function depends on never type fallback being `()` [INFO] [stderr] --> src/ops/empty.rs:38:1 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn empty(options: EmptyOptions, fs: &impl Filesystem) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #123748 [INFO] [stderr] = help: specify the types explicitly [INFO] [stderr] note: in edition 2024, the requirement `!: FromIterator<()>` will fail [INFO] [stderr] --> src/ops/empty.rs:81:16 [INFO] [stderr] | [INFO] [stderr] 81 | .collect::>()?; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = note: `#[warn(dependency_on_unit_never_type_fallback)]` on by default [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: fields `mount_id`, `parent_id`, `major`, `minor`, and `root` are never read [INFO] [stdout] --> src/mounts.rs:16:7 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct MountPoint { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 16 | pub mount_id: c_ulong, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 17 | pub parent_id: c_ulong, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 18 | pub major: c_ulong, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 19 | pub minor: c_ulong, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 20 | pub root: PathBuf, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MountPoint` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/ops/empty.rs:62:16 [INFO] [stdout] | [INFO] [stdout] 62 | if let Err(err) = fs::remove_dir_all(&info.deleted_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^-------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/ops/empty.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 65 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 62 ~ match fs::remove_dir_all(&info.deleted_path) { Err(err) => { [INFO] [stdout] 63 | error!(?info.deleted_path, "Failed to remove original directory."); [INFO] [stdout] 64 | return Err(err.into()); [INFO] [stdout] 65 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/ops/empty.rs:67:16 [INFO] [stdout] | [INFO] [stdout] 67 | if let Err(err) = fs::remove_file(&info.deleted_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^----------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/ops/empty.rs:70:13 [INFO] [stdout] | [INFO] [stdout] 70 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 67 ~ match fs::remove_file(&info.deleted_path) { Err(err) => { [INFO] [stdout] 68 | error!(?info.deleted_path, "Failed to remove original file."); [INFO] [stdout] 69 | return Err(err.into()); [INFO] [stdout] 70 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/ops/put/mod.rs:91:15 [INFO] [stdout] | [INFO] [stdout] 91 | } else if let Err(err) = strategy.delete(abs_path, &options, fs) { [INFO] [stdout] | ^^^^^^^^^^^^^^^--------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/ops/put/mod.rs:93:5 [INFO] [stdout] | [INFO] [stdout] 93 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 91 ~ } else { match strategy.delete(abs_path, &options, fs) { Err(err) => { [INFO] [stdout] 92 | eprintln!("{}", err); [INFO] [stdout] 93 ~ } _ => {}}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 10.26s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Compiling garbage v0.4.3 (/tmp/fixit) [INFO] [stdout] error[E0277]: a value of type `!` cannot be built from an iterator over elements of type `()` [INFO] [stdout] --> src/ops/empty.rs:81:16 [INFO] [stdout] | [INFO] [stdout] 81 | .collect::>()?; [INFO] [stdout] | ------- ^^^^^^^^^ value of type `!` cannot be built from `std::iter::Iterator` [INFO] [stdout] | | [INFO] [stdout] | required by a bound introduced by this call [INFO] [stdout] | [INFO] [stdout] = help: the trait `FromIterator<()>` is not implemented for `!`, which is required by `Result<_, anyhow::Error>: FromIterator>` [INFO] [stdout] = help: the trait `FromIterator>` is implemented for `Result` [INFO] [stdout] = note: this error might have been caused by changes to Rust's type-inference algorithm (see issue #48950 for more information) [INFO] [stdout] = help: did you intend to use the type `()` here instead? [INFO] [stdout] = note: required for `Result` to implement `FromIterator>` [INFO] [stdout] note: required by a bound in `collect` [INFO] [stdout] --> /rustc/ccf408f4326a858c00dd845a64a86b16f360a801/library/core/src/iter/traits/iterator.rs:1996:5 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0277]: a value of type `!` cannot be built from an iterator over elements of type `()` [INFO] [stdout] --> src/ops/empty.rs:81:16 [INFO] [stdout] | [INFO] [stdout] 81 | .collect::>()?; [INFO] [stdout] | ------- ^^^^^^^^^ value of type `!` cannot be built from `std::iter::Iterator` [INFO] [stdout] | | [INFO] [stdout] | required by a bound introduced by this call [INFO] [stdout] | [INFO] [stdout] = help: the trait `FromIterator<()>` is not implemented for `!`, which is required by `Result<_, anyhow::Error>: FromIterator>` [INFO] [stdout] = help: the trait `FromIterator>` is implemented for `Result` [INFO] [stdout] = note: this error might have been caused by changes to Rust's type-inference algorithm (see issue #48950 for more information) [INFO] [stdout] = help: did you intend to use the type `()` here instead? [INFO] [stdout] = note: required for `Result` to implement `FromIterator>` [INFO] [stdout] note: required by a bound in `collect` [INFO] [stdout] --> /rustc/ccf408f4326a858c00dd845a64a86b16f360a801/library/core/src/iter/traits/iterator.rs:1996:5 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0277`. [INFO] [stdout] [INFO] [stderr] error: could not compile `garbage` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0277`. [INFO] [stdout] [INFO] [stderr] error: could not compile `garbage` (lib test) due to 2 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "587effdb22ec31441e66c32a8e4de9a160918ff5f1f2a03b03fba033dd3aad09", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "587effdb22ec31441e66c32a8e4de9a160918ff5f1f2a03b03fba033dd3aad09", kill_on_drop: false }` [INFO] [stdout] 587effdb22ec31441e66c32a8e4de9a160918ff5f1f2a03b03fba033dd3aad09