[INFO] fetching crate finality-grandpa 0.16.2... [INFO] checking finality-grandpa-0.16.2 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate finality-grandpa 0.16.2 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate finality-grandpa 0.16.2 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate finality-grandpa 0.16.2 [INFO] finished tweaking crates.io crate finality-grandpa 0.16.2 [INFO] tweaked toml for crates.io crate finality-grandpa 0.16.2 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 77 packages to latest compatible versions [INFO] [stderr] Adding derive_more v0.99.18 (available: v1.0.0) [INFO] [stderr] Adding env_logger v0.8.4 (available: v0.11.5) [INFO] [stderr] Adding radium v0.7.0 (available: v1.1.0) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wyz v0.5.1 (available: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 289b5eadaf7e595325f10b70f2a742c660dc23a3ef8fc0baace758c888537e63 [INFO] running `Command { std: "docker" "start" "-a" "289b5eadaf7e595325f10b70f2a742c660dc23a3ef8fc0baace758c888537e63", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "289b5eadaf7e595325f10b70f2a742c660dc23a3ef8fc0baace758c888537e63", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "289b5eadaf7e595325f10b70f2a742c660dc23a3ef8fc0baace758c888537e63", kill_on_drop: false }` [INFO] [stdout] 289b5eadaf7e595325f10b70f2a742c660dc23a3ef8fc0baace758c888537e63 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6a6c63c744c2cbe4696a60b4d1866f698949cf8e9cb66cf87a31384601d9c394 [INFO] running `Command { std: "docker" "start" "-a" "6a6c63c744c2cbe4696a60b4d1866f698949cf8e9cb66cf87a31384601d9c394", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Fixed Cargo.toml (8 fixes) [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Compiling winnow v0.6.20 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking byte-slice-cast v1.2.2 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling indexmap v2.5.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling toml_edit v0.22.22 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking env_logger v0.8.4 [INFO] [stderr] Compiling proc-macro-crate v3.2.0 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking quickcheck v1.0.3 [INFO] [stderr] Compiling parity-scale-codec-derive v3.6.12 [INFO] [stderr] Compiling impl-trait-for-tuples v0.2.2 [INFO] [stderr] Compiling scale-info-derive v2.11.3 [INFO] [stderr] Checking parity-scale-codec v3.6.12 [INFO] [stderr] Checking scale-info v2.11.3 [INFO] [stderr] Checking finality-grandpa v0.16.2 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `finality_grandpa` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/voter/mod.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared type `StreamExt` [INFO] [stderr] --> src/voter/mod.rs:1340:5 [INFO] [stderr] | [INFO] [stderr] 1340 | StreamExt::into_future(round_stream) [INFO] [stderr] | ^^^^^^^^^ use of undeclared type `StreamExt` [INFO] [stderr] | [INFO] [stderr] help: a trait with a similar name exists [INFO] [stderr] | [INFO] [stderr] 1340 | Stream::into_future(round_stream) [INFO] [stderr] | ~~~~~~ [INFO] [stderr] help: consider importing one of these traits [INFO] [stderr] | [INFO] [stderr] 1080 + use crate::voter::stream::StreamExt; [INFO] [stderr] | [INFO] [stderr] 1080 + use futures::StreamExt; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared type `StreamExt` [INFO] [stderr] --> src/voter/mod.rs:1378:4 [INFO] [stderr] | [INFO] [stderr] 1378 | StreamExt::into_future(commits_stream).then(|(_, stream)| { [INFO] [stderr] | ^^^^^^^^^ use of undeclared type `StreamExt` [INFO] [stderr] | [INFO] [stderr] help: a trait with a similar name exists [INFO] [stderr] | [INFO] [stderr] 1378 | Stream::into_future(commits_stream).then(|(_, stream)| { [INFO] [stderr] | ~~~~~~ [INFO] [stderr] help: consider importing one of these traits [INFO] [stderr] | [INFO] [stderr] 1080 + use crate::voter::stream::StreamExt; [INFO] [stderr] | [INFO] [stderr] 1080 + use futures::StreamExt; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared type `StreamExt` [INFO] [stderr] --> src/voter/mod.rs:1450:15 [INFO] [stderr] | [INFO] [stderr] 1450 | .run_until(StreamExt::into_future(env.finalized_stream()).map(move |(msg, _)| msg.unwrap().2)); [INFO] [stderr] | ^^^^^^^^^ use of undeclared type `StreamExt` [INFO] [stderr] | [INFO] [stderr] help: a trait with a similar name exists [INFO] [stderr] | [INFO] [stderr] 1450 | .run_until(Stream::into_future(env.finalized_stream()).map(move |(msg, _)| msg.unwrap().2)); [INFO] [stderr] | ~~~~~~ [INFO] [stderr] help: consider importing one of these traits [INFO] [stderr] | [INFO] [stderr] 1080 + use crate::voter::stream::StreamExt; [INFO] [stderr] | [INFO] [stderr] 1080 + use futures::StreamExt; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared type `StreamExt` [INFO] [stderr] --> src/voter/mod.rs:1532:19 [INFO] [stderr] | [INFO] [stderr] 1532 | let finalized = StreamExt::into_future(env.finalized_stream().take(1)); [INFO] [stderr] | ^^^^^^^^^ use of undeclared type `StreamExt` [INFO] [stderr] | [INFO] [stderr] help: a trait with a similar name exists [INFO] [stderr] | [INFO] [stderr] 1532 | let finalized = Stream::into_future(env.finalized_stream().take(1)); [INFO] [stderr] | ~~~~~~ [INFO] [stderr] help: consider importing one of these traits [INFO] [stderr] | [INFO] [stderr] 1080 + use crate::voter::stream::StreamExt; [INFO] [stderr] | [INFO] [stderr] 1080 + use futures::StreamExt; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared type `StreamExt` [INFO] [stderr] --> src/voter/mod.rs:1688:4 [INFO] [stderr] | [INFO] [stderr] 1688 | StreamExt::into_future(round_stream [INFO] [stderr] | ^^^^^^^^^ use of undeclared type `StreamExt` [INFO] [stderr] | [INFO] [stderr] help: a trait with a similar name exists [INFO] [stderr] | [INFO] [stderr] 1688 | Stream::into_future(round_stream [INFO] [stderr] | ~~~~~~ [INFO] [stderr] help: consider importing one of these traits [INFO] [stderr] | [INFO] [stderr] 1080 + use crate::voter::stream::StreamExt; [INFO] [stderr] | [INFO] [stderr] 1080 + use futures::StreamExt; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0433`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: trait method `into_future` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/voter/mod.rs:1340:5 [INFO] [stdout] | [INFO] [stdout] 1340 | / round_stream [INFO] [stdout] 1341 | | .into_future() [INFO] [stdout] | |__________________________________^ help: disambiguate the associated function: `StreamExt::into_future(round_stream)` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `--force-warn rust-2024-prelude-collisions` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `into_future` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/voter/mod.rs:1379:4 [INFO] [stdout] | [INFO] [stdout] 1379 | commits_stream.into_future().then(|(_, stream)| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: disambiguate the associated function: `StreamExt::into_future(commits_stream)` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `into_future` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/voter/mod.rs:1451:15 [INFO] [stdout] | [INFO] [stdout] 1451 | .run_until(env.finalized_stream().into_future().map(move |(msg, _)| msg.unwrap().2)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: disambiguate the associated function: `StreamExt::into_future(env.finalized_stream())` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `into_future` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/voter/mod.rs:1533:19 [INFO] [stdout] | [INFO] [stdout] 1533 | let finalized = env.finalized_stream().take(1).into_future(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: disambiguate the associated function: `StreamExt::into_future(env.finalized_stream().take(1))` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `into_future` will become ambiguous in Rust 2024 [INFO] [stdout] --> src/voter/mod.rs:1689:4 [INFO] [stdout] | [INFO] [stdout] 1689 | / round_stream [INFO] [stdout] 1690 | | .skip_while(move |v| { [INFO] [stdout] 1691 | | let v = v.as_ref().unwrap(); [INFO] [stdout] 1692 | | if let Message::Prevote(_) = v.message { [INFO] [stdout] ... | [INFO] [stdout] 1697 | | }) [INFO] [stdout] 1698 | | .into_future() [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: disambiguate the associated function [INFO] [stdout] | [INFO] [stdout] 1689 ~ StreamExt::into_future(round_stream [INFO] [stdout] 1690 ~ .skip_while(move |v| { [INFO] [stdout] 1691 ~ let v = v.as_ref().unwrap(); [INFO] [stdout] 1692 ~ if let Message::Prevote(_) = v.message { [INFO] [stdout] 1693 ~ future::ready(v.id != local_id) [INFO] [stdout] 1694 ~ } else { [INFO] [stdout] 1695 ~ future::ready(true) [INFO] [stdout] 1696 ~ } [INFO] [stdout] 1697 ~ })) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/round.rs:485:8 [INFO] [stdout] | [INFO] [stdout] 485 | if let VoteMultiplicity::Single(ref v, _) = *multiplicity { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/round.rs:489:5 [INFO] [stdout] | [INFO] [stdout] 489 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 485 ~ match *multiplicity { VoteMultiplicity::Single(ref v, _) => { [INFO] [stdout] 486 | // if there is a single vote from this voter, we only include it [INFO] [stdout] 487 | // if it branches off of the target. [INFO] [stdout] 488 | chain.is_equal_or_descendent_of(f_hash.clone(), v.target_hash.clone()) [INFO] [stdout] 489 ~ } _ => { [INFO] [stdout] 490 | // equivocations count for everything, so we always include them. [INFO] [stdout] 491 | true [INFO] [stdout] 492 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/vote_graph.rs:171:6 [INFO] [stdout] | [INFO] [stdout] 171 | if let Some(containing) = self.find_containing_nodes(hash.clone(), number) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^------------------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/vote_graph.rs:177:3 [INFO] [stdout] | [INFO] [stdout] 177 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 171 ~ match self.find_containing_nodes(hash.clone(), number) { Some(containing) => { [INFO] [stdout] 172 | if containing.is_empty() { [INFO] [stdout] ... [INFO] [stdout] 176 | } [INFO] [stdout] 177 ~ } _ => { [INFO] [stdout] 178 | // this entry already exists [INFO] [stdout] 179 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/vote_graph.rs:336:9 [INFO] [stdout] | [INFO] [stdout] 336 | if let (true, Some(&(ref h, n))) = (force_constrain, current_best.as_ref()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------------^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/vote_graph.rs:338:6 [INFO] [stdout] | [INFO] [stdout] 338 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 336 ~ match (force_constrain, current_best.as_ref()) { (true, Some(&(ref h, n))) => { [INFO] [stdout] 337 | node.in_direct_ancestry(h, n).unwrap_or(false) [INFO] [stdout] 338 ~ } _ => { [INFO] [stdout] 339 | true [INFO] [stdout] 340 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/vote_graph.rs:387:8 [INFO] [stdout] | [INFO] [stdout] 387 | if let Some((ref h, num)) = force_constrain { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^--------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/vote_graph.rs:389:5 [INFO] [stdout] | [INFO] [stdout] 389 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 387 ~ match force_constrain { Some((ref h, num)) => { [INFO] [stdout] 388 | n.in_direct_ancestry(h, num).unwrap_or(false) [INFO] [stdout] 389 ~ } _ => { [INFO] [stdout] 390 | true [INFO] [stdout] 391 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/vote_graph.rs:475:10 [INFO] [stdout] | [INFO] [stdout] 475 | if let Some(prev) = active_entry.ancestor_node() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^---------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/vote_graph.rs:478:7 [INFO] [stdout] | [INFO] [stdout] 478 | }, [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 475 ~ match active_entry.ancestor_node() { Some(prev) => { [INFO] [stdout] 476 | head = prev; [INFO] [stdout] 477 | continue // iterate backwards [INFO] [stdout] 478 ~ } _ => {}}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/vote_graph.rs:536:6 [INFO] [stdout] | [INFO] [stdout] 536 | if let Some((new_entry, prev_ancestor)) = produced_entry { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/vote_graph.rs:551:3 [INFO] [stdout] | [INFO] [stdout] 551 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 536 ~ match produced_entry { Some((new_entry, prev_ancestor)) => { [INFO] [stdout] 537 | if let Some(prev_ancestor) = prev_ancestor { [INFO] [stdout] ... [INFO] [stdout] 550 | ) [INFO] [stdout] 551 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/vote_graph.rs:562:7 [INFO] [stdout] | [INFO] [stdout] 562 | if let Some(entry) = self.entries.get_mut(ancestor) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------------^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/vote_graph.rs:566:4 [INFO] [stdout] | [INFO] [stdout] 566 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 562 ~ match self.entries.get_mut(ancestor) { Some(entry) => { [INFO] [stdout] 563 | entry.descendents.push(hash.clone()); [INFO] [stdout] 564 | ancestor_index = Some(i); [INFO] [stdout] 565 | break [INFO] [stdout] 566 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/voter/mod.rs:564:7 [INFO] [stdout] | [INFO] [stdout] 564 | if let Some(mut last_round) = maybe_completed_last_round { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^-------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/voter/mod.rs:567:4 [INFO] [stdout] | [INFO] [stdout] 567 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 564 ~ match maybe_completed_last_round { Some(mut last_round) => { [INFO] [stdout] 565 | last_round_state = last_round.bridge_state(); [INFO] [stdout] 566 | past_rounds.push(&*env, last_round); [INFO] [stdout] 567 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/voter/mod.rs:605:10 [INFO] [stdout] | [INFO] [stdout] 605 | while let Poll::Ready(Some(item)) = [INFO] [stdout] | ___________________^ [INFO] [stdout] 606 | | Stream::poll_next(Pin::new(&mut inner.past_rounds), cx) [INFO] [stdout] | |_________________------------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/voter/mod.rs:610:4 [INFO] [stdout] | [INFO] [stdout] 610 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/voter/mod.rs:613:9 [INFO] [stdout] | [INFO] [stdout] 613 | while let Poll::Ready(res) = [INFO] [stdout] | _______________^ [INFO] [stdout] 614 | | Stream::poll_next(Pin::new(&mut self.finalized_notifications), cx) [INFO] [stdout] | |_____________-----------------------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/voter/mod.rs:631:3 [INFO] [stdout] | [INFO] [stdout] 631 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/voter/mod.rs:645:9 [INFO] [stdout] | [INFO] [stdout] 645 | while let Poll::Ready(Some(item)) = Stream::poll_next(Pin::new(&mut self.global_in), cx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/voter/mod.rs:766:3 [INFO] [stdout] | [INFO] [stdout] 766 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/voter/mod.rs:662:9 [INFO] [stdout] | [INFO] [stdout] 662 | if let Some(commit) = inner.past_rounds.import_commit(round_number, commit) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^----------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/voter/mod.rs:694:6 [INFO] [stdout] | [INFO] [stdout] 694 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 662 ~ match inner.past_rounds.import_commit(round_number, commit) { Some(commit) => { [INFO] [stdout] 663 | // otherwise validate the commit and signal the finalized block from the [INFO] [stdout] ... [INFO] [stdout] 693 | } [INFO] [stdout] 694 ~ } _ => { [INFO] [stdout] 695 | // Import to backgrounded round is good. [INFO] [stdout] 696 | process_commit_outcome [INFO] [stdout] 697 | .run(CommitProcessingOutcome::Good(GoodCommit::new())); [INFO] [stdout] 698 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/voter/mod.rs:709:21 [INFO] [stdout] | [INFO] [stdout] 709 | let round = if let Some(round) = validate_catch_up( [INFO] [stdout] | ____________________________________^ - [INFO] [stdout] | |______________________________________________________| [INFO] [stdout] 710 | || catch_up, [INFO] [stdout] 711 | || &*self.env, [INFO] [stdout] 712 | || &self.voters, [INFO] [stdout] 713 | || inner.best_round.round_number(), [INFO] [stdout] 714 | || ) { [INFO] [stdout] | ||_____________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |_____________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/voter/mod.rs:716:6 [INFO] [stdout] | [INFO] [stdout] 716 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 709 ~ let round = match validate_catch_up( [INFO] [stdout] 710 | catch_up, [INFO] [stdout] ... [INFO] [stdout] 713 | inner.best_round.round_number(), [INFO] [stdout] 714 ~ ) { Some(round) => { [INFO] [stdout] 715 | round [INFO] [stdout] 716 ~ } _ => { [INFO] [stdout] 717 | process_catch_up_outcome [INFO] [stdout] 718 | .run(CatchUpProcessingOutcome::Bad(BadCatchUp::new())); [INFO] [stdout] 719 | return Ok(()) [INFO] [stdout] 720 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/voter/past_rounds.rs:89:7 [INFO] [stdout] | [INFO] [stdout] 89 | if let Some(ref waker) = self.waker { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^---------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/voter/past_rounds.rs:91:4 [INFO] [stdout] | [INFO] [stdout] 91 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 89 ~ match self.waker { Some(ref waker) => { [INFO] [stdout] 90 | waker.wake_by_ref(); [INFO] [stdout] 91 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/voter/past_rounds.rs:193:9 [INFO] [stdout] | [INFO] [stdout] 193 | while let Poll::Ready(Some(commit)) = [INFO] [stdout] | _______________^ [INFO] [stdout] 194 | | Stream::poll_next(Pin::new(&mut self.import_commits), cx) [INFO] [stdout] | |_____________--------------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/voter/past_rounds.rs:199:3 [INFO] [stdout] | [INFO] [stdout] 199 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/voter/past_rounds.rs:225:6 [INFO] [stdout] | [INFO] [stdout] 225 | if let Some(ref mut inner) = self.inner { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^---------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/voter/past_rounds.rs:227:3 [INFO] [stdout] | [INFO] [stdout] 227 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 225 ~ match self.inner { Some(ref mut inner) => { [INFO] [stdout] 226 | x(inner) [INFO] [stdout] 227 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/voter/past_rounds.rs:309:6 [INFO] [stdout] | [INFO] [stdout] 309 | if let Some(sender) = self.commit_senders.get(&round_number) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^-------------------^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/voter/past_rounds.rs:311:3 [INFO] [stdout] | [INFO] [stdout] 311 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 309 ~ match self.commit_senders.get(&round_number) { Some(sender) => { [INFO] [stdout] 310 | sender.unbounded_send(commit).map_err(|e| e.into_inner()).err() [INFO] [stdout] 311 ~ } _ => { [INFO] [stdout] 312 | Some(commit) [INFO] [stdout] 313 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl Iterator>::Id>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/voter/voting_round.rs:303:38 [INFO] [stdout] | [INFO] [stdout] 303 | pub(super) fn prevote_ids(&self) -> impl Iterator { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/voter/voting_round.rs:303:28 [INFO] [stdout] | [INFO] [stdout] 303 | pub(super) fn prevote_ids(&self) -> impl Iterator { [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] = note: `--force-warn impl-trait-overcaptures` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 303 | pub(super) fn prevote_ids(&self) -> impl Iterator + use { [INFO] [stdout] | ++++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl Iterator>::Id>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/voter/voting_round.rs:308:40 [INFO] [stdout] | [INFO] [stdout] 308 | pub(super) fn precommit_ids(&self) -> impl Iterator { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/voter/voting_round.rs:308:30 [INFO] [stdout] | [INFO] [stdout] 308 | pub(super) fn precommit_ids(&self) -> impl Iterator { [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 308 | pub(super) fn precommit_ids(&self) -> impl Iterator + use { [INFO] [stdout] | ++++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/voter/voting_round.rs:325:7 [INFO] [stdout] | [INFO] [stdout] 325 | if let ImportResult { equivocation: Some(e), .. } = import_result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/voter/voting_round.rs:327:4 [INFO] [stdout] | [INFO] [stdout] 327 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 325 ~ match import_result { ImportResult { equivocation: Some(e), .. } => { [INFO] [stdout] 326 | self.env.precommit_equivocation(self.round_number(), e); [INFO] [stdout] 327 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/voter/voting_round.rs:390:8 [INFO] [stdout] | [INFO] [stdout] 390 | if let ImportResult { equivocation: Some(e), .. } = import_result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/voter/voting_round.rs:392:5 [INFO] [stdout] | [INFO] [stdout] 392 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 390 ~ match import_result { ImportResult { equivocation: Some(e), .. } => { [INFO] [stdout] 391 | self.env.prevote_equivocation(self.votes.number(), e); [INFO] [stdout] 392 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/voter/voting_round.rs:397:8 [INFO] [stdout] | [INFO] [stdout] 397 | if let ImportResult { equivocation: Some(e), .. } = import_result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/voter/voting_round.rs:399:5 [INFO] [stdout] | [INFO] [stdout] 399 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 397 ~ match import_result { ImportResult { equivocation: Some(e), .. } => { [INFO] [stdout] 398 | self.env.precommit_equivocation(self.votes.number(), e); [INFO] [stdout] 399 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/voter/voting_round.rs:449:9 [INFO] [stdout] | [INFO] [stdout] 449 | while let Poll::Ready(Some(incoming)) = Stream::poll_next(Pin::new(&mut self.incoming), cx) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/voter/voting_round.rs:453:3 [INFO] [stdout] | [INFO] [stdout] 453 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/voter/voting_round.rs:576:7 [INFO] [stdout] | [INFO] [stdout] 576 | if let Some(target) = best_chain { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^---------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/voter/voting_round.rs:584:4 [INFO] [stdout] | [INFO] [stdout] 584 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 576 ~ match best_chain { Some(target) => { [INFO] [stdout] 577 | let prevote = Prevote { target_hash: target.0, target_number: target.1 }; [INFO] [stdout] ... [INFO] [stdout] 583 | this.state = Some(State::Prevoted(precommit_timer)); [INFO] [stdout] 584 ~ } _ => { [INFO] [stdout] 585 | // if this block is considered unknown, something has gone wrong. [INFO] [stdout] ... [INFO] [stdout] 594 | this.voting = Voting::No; [INFO] [stdout] 595 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/voter/voting_round.rs:752:7 [INFO] [stdout] | [INFO] [stdout] 752 | if let Some(ref b) = self.bridged_round_state { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/voter/voting_round.rs:754:4 [INFO] [stdout] | [INFO] [stdout] 754 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 752 ~ match self.bridged_round_state { Some(ref b) => { [INFO] [stdout] 753 | b.update(new_state.clone()); [INFO] [stdout] 754 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/voter/voting_round.rs:774:8 [INFO] [stdout] | [INFO] [stdout] 774 | if let Some((f_hash, f_number)) = new_state.finalized { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/voter/voting_round.rs:785:5 [INFO] [stdout] | [INFO] [stdout] 785 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 774 ~ match new_state.finalized { Some((f_hash, f_number)) => { [INFO] [stdout] 775 | let commit = Commit { [INFO] [stdout] ... [INFO] [stdout] 784 | self.best_finalized = Some(commit); [INFO] [stdout] 785 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/voter_set.rs:203:8 [INFO] [stdout] | [INFO] [stdout] 203 | if let Some(set) = VoterSet::new(ids.into_iter().zip(weights)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/voter_set.rs:205:5 [INFO] [stdout] | [INFO] [stdout] 205 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 203 ~ match VoterSet::new(ids.into_iter().zip(weights)) { Some(set) => { [INFO] [stdout] 204 | break set [INFO] [stdout] 205 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl futures::Stream>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/testing.rs:383:9 [INFO] [stdout] | [INFO] [stdout] 383 | ) -> (impl Stream>, impl Sink) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/testing.rs:381:4 [INFO] [stdout] | [INFO] [stdout] 381 | &mut self, [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 383 | ) -> (impl Stream> + use, impl Sink) { [INFO] [stdout] | ++++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl futures::Sink` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/testing.rs:383:47 [INFO] [stdout] | [INFO] [stdout] 383 | ) -> (impl Stream>, impl Sink) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/testing.rs:381:4 [INFO] [stdout] | [INFO] [stdout] 381 | &mut self, [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 383 | ) -> (impl Stream>, impl Sink + use) { [INFO] [stdout] | ++++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl futures::Stream, Error>>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/testing.rs:446:4 [INFO] [stdout] | [INFO] [stdout] 446 | impl Stream, Error>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/testing.rs:442:4 [INFO] [stdout] | [INFO] [stdout] 442 | &self, [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 446 | impl Stream, Error>> + use<>, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl futures::Sink, Error = Error>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/testing.rs:447:4 [INFO] [stdout] | [INFO] [stdout] 447 | impl Sink, Error = Error>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/testing.rs:442:4 [INFO] [stdout] | [INFO] [stdout] 442 | &self, [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 447 | impl Sink, Error = Error> + use<>, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl futures::Stream, Error>>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/testing.rs:463:4 [INFO] [stdout] | [INFO] [stdout] 463 | impl Stream, Error>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/testing.rs:461:4 [INFO] [stdout] | [INFO] [stdout] 461 | &self, [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 463 | impl Stream, Error>> + use<>, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl futures::Sink, Error = Error>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/testing.rs:464:4 [INFO] [stdout] | [INFO] [stdout] 464 | impl Sink, Error = Error>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/testing.rs:461:4 [INFO] [stdout] | [INFO] [stdout] 461 | &self, [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 464 | impl Sink, Error = Error> + use<>, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 38 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Fixed src/vote_graph.rs (6 fixes) [INFO] [stderr] Fixed src/voter/past_rounds.rs (3 fixes) [INFO] [stderr] Fixed src/voter/mod.rs (3 fixes) [INFO] [stderr] Fixed src/round.rs (1 fix) [INFO] [stderr] Fixed src/voter/voting_round.rs (8 fixes) [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/voter/mod.rs:605:10 [INFO] [stdout] | [INFO] [stdout] 605 | while let Poll::Ready(Some(item)) = [INFO] [stdout] | ___________________^ [INFO] [stdout] 606 | | Stream::poll_next(Pin::new(&mut inner.past_rounds), cx) [INFO] [stdout] | |_________________------------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/voter/mod.rs:610:4 [INFO] [stdout] | [INFO] [stdout] 610 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/voter/mod.rs:613:9 [INFO] [stdout] | [INFO] [stdout] 613 | while let Poll::Ready(res) = [INFO] [stdout] | _______________^ [INFO] [stdout] 614 | | Stream::poll_next(Pin::new(&mut self.finalized_notifications), cx) [INFO] [stdout] | |_____________-----------------------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/voter/mod.rs:631:3 [INFO] [stdout] | [INFO] [stdout] 631 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/voter/mod.rs:645:9 [INFO] [stdout] | [INFO] [stdout] 645 | while let Poll::Ready(Some(item)) = Stream::poll_next(Pin::new(&mut self.global_in), cx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/voter/mod.rs:766:3 [INFO] [stdout] | [INFO] [stdout] 766 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/voter/past_rounds.rs:193:9 [INFO] [stdout] | [INFO] [stdout] 193 | while let Poll::Ready(Some(commit)) = [INFO] [stdout] | _______________^ [INFO] [stdout] 194 | | Stream::poll_next(Pin::new(&mut self.import_commits), cx) [INFO] [stdout] | |_____________--------------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/voter/past_rounds.rs:199:3 [INFO] [stdout] | [INFO] [stdout] 199 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/voter/voting_round.rs:449:9 [INFO] [stdout] | [INFO] [stdout] 449 | while let Poll::Ready(Some(incoming)) = Stream::poll_next(Pin::new(&mut self.incoming), cx) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/voter/voting_round.rs:453:3 [INFO] [stdout] | [INFO] [stdout] 453 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.41s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking finality-grandpa v0.16.2 (/tmp/fixit) [INFO] [stdout] error[E0597]: `rounds` does not live long enough [INFO] [stdout] --> src/testing.rs:450:4 [INFO] [stdout] | [INFO] [stdout] 442 | &self, [INFO] [stdout] | - let's call the lifetime of this reference `'1` [INFO] [stdout] ... [INFO] [stdout] 449 | let mut rounds = self.rounds.lock(); [INFO] [stdout] | ---------- binding `rounds` declared here [INFO] [stdout] 450 | rounds [INFO] [stdout] | -^^^^^ [INFO] [stdout] | | [INFO] [stdout] | _____________borrowed value does not live long enough [INFO] [stdout] | | [INFO] [stdout] 451 | | .entry(round_number) [INFO] [stdout] 452 | | .or_insert_with(RoundNetwork::new) [INFO] [stdout] 453 | | .add_node(move |message| SignedMessage { [INFO] [stdout] ... | [INFO] [stdout] 456 | | id: node_id, [INFO] [stdout] 457 | | }) [INFO] [stdout] | |__________________- argument requires that `rounds` is borrowed for `'1` [INFO] [stdout] 458 | } [INFO] [stdout] | - `rounds` dropped here while still borrowed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0597]: `global_messages` does not live long enough [INFO] [stdout] --> src/testing.rs:467:4 [INFO] [stdout] | [INFO] [stdout] 461 | &self, [INFO] [stdout] | - let's call the lifetime of this reference `'1` [INFO] [stdout] ... [INFO] [stdout] 466 | let mut global_messages = self.global_messages.lock(); [INFO] [stdout] | ------------------- binding `global_messages` declared here [INFO] [stdout] 467 | global_messages.add_node(|message| match message { [INFO] [stdout] | -^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | _____________borrowed value does not live long enough [INFO] [stdout] | | [INFO] [stdout] 468 | | CommunicationOut::Commit(r, commit) => [INFO] [stdout] 469 | | CommunicationIn::Commit(r, commit.into(), Callback::Blank), [INFO] [stdout] 470 | | }) [INFO] [stdout] | |______________- argument requires that `global_messages` is borrowed for `'1` [INFO] [stdout] 471 | } [INFO] [stdout] | - `global_messages` dropped here while still borrowed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0597]: `network` does not live long enough [INFO] [stdout] --> src/voter/mod.rs:1101:22 [INFO] [stdout] | [INFO] [stdout] 1099 | let (network, routing_task) = testing::environment::make_network(); [INFO] [stdout] | ------- binding `network` declared here [INFO] [stdout] 1100 | [INFO] [stdout] 1101 | let global_comms = network.make_global_comms(); [INFO] [stdout] | ^^^^^^^-------------------- [INFO] [stdout] | | [INFO] [stdout] | borrowed value does not live long enough [INFO] [stdout] | argument requires that `network` is borrowed for `'static` [INFO] [stdout] ... [INFO] [stdout] 1132 | } [INFO] [stdout] | - `network` dropped here while still borrowed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0505]: cannot move out of `network` because it is borrowed [INFO] [stdout] --> src/voter/mod.rs:1102:39 [INFO] [stdout] | [INFO] [stdout] 1099 | let (network, routing_task) = testing::environment::make_network(); [INFO] [stdout] | ------- binding `network` declared here [INFO] [stdout] 1100 | [INFO] [stdout] 1101 | let global_comms = network.make_global_comms(); [INFO] [stdout] | --------------------------- [INFO] [stdout] | | [INFO] [stdout] | borrow of `network` occurs here [INFO] [stdout] | argument requires that `network` is borrowed for `'static` [INFO] [stdout] 1102 | let env = Arc::new(Environment::new(network, local_id)); [INFO] [stdout] | ^^^^^^^ move out of `network` occurs here [INFO] [stdout] | [INFO] [stdout] help: consider cloning the value if the performance cost is acceptable [INFO] [stdout] | [INFO] [stdout] 1101 | let global_comms = network.clone().make_global_comms(); [INFO] [stdout] | ++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0597]: `network` does not live long enough [INFO] [stdout] --> src/voter/mod.rs:1147:41 [INFO] [stdout] | [INFO] [stdout] 1139 | let (network, routing_task) = testing::environment::make_network(); [INFO] [stdout] | ------- binding `network` declared here [INFO] [stdout] ... [INFO] [stdout] 1144 | .map(|i| { [INFO] [stdout] | --- value captured here [INFO] [stdout] ... [INFO] [stdout] 1147 | let env = Arc::new(Environment::new(network.clone(), local_id)); [INFO] [stdout] | ^^^^^^^ borrowed value does not live long enough [INFO] [stdout] ... [INFO] [stdout] 1158 | network.make_global_comms(), [INFO] [stdout] | --------------------------- argument requires that `network` is borrowed for `'static` [INFO] [stdout] ... [INFO] [stdout] 1177 | } [INFO] [stdout] | - `network` dropped here while still borrowed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0597]: `network` does not live long enough [INFO] [stdout] --> src/voter/mod.rs:1193:41 [INFO] [stdout] | [INFO] [stdout] 1185 | let (network, routing_task) = testing::environment::make_network(); [INFO] [stdout] | ------- binding `network` declared here [INFO] [stdout] ... [INFO] [stdout] 1190 | .map(|i| { [INFO] [stdout] | --- value captured here [INFO] [stdout] ... [INFO] [stdout] 1193 | let env = Arc::new(Environment::new(network.clone(), local_id)); [INFO] [stdout] | ^^^^^^^ borrowed value does not live long enough [INFO] [stdout] ... [INFO] [stdout] 1204 | network.make_global_comms(), [INFO] [stdout] | --------------------------- argument requires that `network` is borrowed for `'static` [INFO] [stdout] ... [INFO] [stdout] 1248 | } [INFO] [stdout] | - `network` dropped here while still borrowed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0597]: `network` does not live long enough [INFO] [stdout] --> src/voter/mod.rs:1258:22 [INFO] [stdout] | [INFO] [stdout] 1255 | let (network, routing_task) = testing::environment::make_network(); [INFO] [stdout] | ------- binding `network` declared here [INFO] [stdout] ... [INFO] [stdout] 1258 | let global_comms = network.make_global_comms(); [INFO] [stdout] | ^^^^^^^-------------------- [INFO] [stdout] | | [INFO] [stdout] | borrowed value does not live long enough [INFO] [stdout] | argument requires that `network` is borrowed for `'static` [INFO] [stdout] ... [INFO] [stdout] 1284 | } [INFO] [stdout] | - `network` dropped here while still borrowed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0505]: cannot move out of `network` because it is borrowed [INFO] [stdout] --> src/voter/mod.rs:1259:39 [INFO] [stdout] | [INFO] [stdout] 1255 | let (network, routing_task) = testing::environment::make_network(); [INFO] [stdout] | ------- binding `network` declared here [INFO] [stdout] 1256 | let (commits, _) = network.make_global_comms(); [INFO] [stdout] | ------- borrow of `network` occurs here [INFO] [stdout] ... [INFO] [stdout] 1259 | let env = Arc::new(Environment::new(network, local_id)); [INFO] [stdout] | ^^^^^^^ move out of `network` occurs here [INFO] [stdout] ... [INFO] [stdout] 1283 | pool.run_until(commits.take(1).for_each(|_| future::ready(()))) [INFO] [stdout] | ------- borrow later used here [INFO] [stdout] | [INFO] [stdout] help: consider cloning the value if the performance cost is acceptable [INFO] [stdout] | [INFO] [stdout] 1256 | let (commits, _) = network.clone().make_global_comms(); [INFO] [stdout] | ++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0597]: `network` does not live long enough [INFO] [stdout] --> src/voter/mod.rs:1294:40 [INFO] [stdout] | [INFO] [stdout] 1293 | let (network, routing_task) = testing::environment::make_network(); [INFO] [stdout] | ------- binding `network` declared here [INFO] [stdout] 1294 | let (commits_stream, commits_sink) = network.make_global_comms(); [INFO] [stdout] | ^^^^^^^-------------------- [INFO] [stdout] | | [INFO] [stdout] | borrowed value does not live long enough [INFO] [stdout] | argument requires that `network` is borrowed for `'static` [INFO] [stdout] ... [INFO] [stdout] 1393 | } [INFO] [stdout] | - `network` dropped here while still borrowed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0597]: `network` does not live long enough [INFO] [stdout] --> src/voter/mod.rs:1295:36 [INFO] [stdout] | [INFO] [stdout] 1293 | let (network, routing_task) = testing::environment::make_network(); [INFO] [stdout] | ------- binding `network` declared here [INFO] [stdout] 1294 | let (commits_stream, commits_sink) = network.make_global_comms(); [INFO] [stdout] 1295 | let (round_stream, round_sink) = network.make_round_comms(1, test_id); [INFO] [stdout] | ^^^^^^^----------------------------- [INFO] [stdout] | | [INFO] [stdout] | borrowed value does not live long enough [INFO] [stdout] | argument requires that `network` is borrowed for `'static` [INFO] [stdout] ... [INFO] [stdout] 1393 | } [INFO] [stdout] | - `network` dropped here while still borrowed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0597]: `network` does not live long enough [INFO] [stdout] --> src/voter/mod.rs:1314:22 [INFO] [stdout] | [INFO] [stdout] 1293 | let (network, routing_task) = testing::environment::make_network(); [INFO] [stdout] | ------- binding `network` declared here [INFO] [stdout] ... [INFO] [stdout] 1314 | let global_comms = network.make_global_comms(); [INFO] [stdout] | ^^^^^^^-------------------- [INFO] [stdout] | | [INFO] [stdout] | borrowed value does not live long enough [INFO] [stdout] | argument requires that `network` is borrowed for `'static` [INFO] [stdout] ... [INFO] [stdout] 1393 | } [INFO] [stdout] | - `network` dropped here while still borrowed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0505]: cannot move out of `network` because it is borrowed [INFO] [stdout] --> src/voter/mod.rs:1315:39 [INFO] [stdout] | [INFO] [stdout] 1293 | let (network, routing_task) = testing::environment::make_network(); [INFO] [stdout] | ------- binding `network` declared here [INFO] [stdout] 1294 | let (commits_stream, commits_sink) = network.make_global_comms(); [INFO] [stdout] | --------------------------- [INFO] [stdout] | | [INFO] [stdout] | borrow of `network` occurs here [INFO] [stdout] | argument requires that `network` is borrowed for `'static` [INFO] [stdout] ... [INFO] [stdout] 1315 | let env = Arc::new(Environment::new(network, local_id)); [INFO] [stdout] | ^^^^^^^ move out of `network` occurs here [INFO] [stdout] | [INFO] [stdout] help: consider cloning the value if the performance cost is acceptable [INFO] [stdout] | [INFO] [stdout] 1294 | let (commits_stream, commits_sink) = network.clone().make_global_comms(); [INFO] [stdout] | ++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0597]: `network` does not live long enough [INFO] [stdout] --> src/voter/mod.rs:1403:27 [INFO] [stdout] | [INFO] [stdout] 1402 | let (network, routing_task) = testing::environment::make_network(); [INFO] [stdout] | ------- binding `network` declared here [INFO] [stdout] 1403 | let (_, commits_sink) = network.make_global_comms(); [INFO] [stdout] | ^^^^^^^-------------------- [INFO] [stdout] | | [INFO] [stdout] | borrowed value does not live long enough [INFO] [stdout] | argument requires that `network` is borrowed for `'static` [INFO] [stdout] ... [INFO] [stdout] 1454 | } [INFO] [stdout] | - `network` dropped here while still borrowed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0597]: `network` does not live long enough [INFO] [stdout] --> src/voter/mod.rs:1416:22 [INFO] [stdout] | [INFO] [stdout] 1402 | let (network, routing_task) = testing::environment::make_network(); [INFO] [stdout] | ------- binding `network` declared here [INFO] [stdout] ... [INFO] [stdout] 1416 | let global_comms = network.make_global_comms(); [INFO] [stdout] | ^^^^^^^-------------------- [INFO] [stdout] | | [INFO] [stdout] | borrowed value does not live long enough [INFO] [stdout] | argument requires that `network` is borrowed for `'static` [INFO] [stdout] ... [INFO] [stdout] 1454 | } [INFO] [stdout] | - `network` dropped here while still borrowed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0505]: cannot move out of `network` because it is borrowed [INFO] [stdout] --> src/voter/mod.rs:1417:39 [INFO] [stdout] | [INFO] [stdout] 1402 | let (network, routing_task) = testing::environment::make_network(); [INFO] [stdout] | ------- binding `network` declared here [INFO] [stdout] 1403 | let (_, commits_sink) = network.make_global_comms(); [INFO] [stdout] | --------------------------- [INFO] [stdout] | | [INFO] [stdout] | borrow of `network` occurs here [INFO] [stdout] | argument requires that `network` is borrowed for `'static` [INFO] [stdout] ... [INFO] [stdout] 1417 | let env = Arc::new(Environment::new(network, local_id)); [INFO] [stdout] | ^^^^^^^ move out of `network` occurs here [INFO] [stdout] | [INFO] [stdout] help: consider cloning the value if the performance cost is acceptable [INFO] [stdout] | [INFO] [stdout] 1403 | let (_, commits_sink) = network.clone().make_global_comms(); [INFO] [stdout] | ++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0597]: `network` does not live long enough [INFO] [stdout] --> src/voter/mod.rs:1482:5 [INFO] [stdout] | [INFO] [stdout] 1464 | let (network, routing_task) = testing::environment::make_network(); [INFO] [stdout] | ------- binding `network` declared here [INFO] [stdout] ... [INFO] [stdout] 1482 | network.make_global_comms(), [INFO] [stdout] | ^^^^^^^-------------------- [INFO] [stdout] | | [INFO] [stdout] | borrowed value does not live long enough [INFO] [stdout] | argument requires that `network` is borrowed for `'static` [INFO] [stdout] ... [INFO] [stdout] 1563 | } [INFO] [stdout] | - `network` dropped here while still borrowed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0597]: `network` does not live long enough [INFO] [stdout] --> src/voter/mod.rs:1572:22 [INFO] [stdout] | [INFO] [stdout] 1570 | let (network, routing_task) = testing::environment::make_network(); [INFO] [stdout] | ------- binding `network` declared here [INFO] [stdout] 1571 | [INFO] [stdout] 1572 | let global_comms = network.make_global_comms(); [INFO] [stdout] | ^^^^^^^-------------------- [INFO] [stdout] | | [INFO] [stdout] | borrowed value does not live long enough [INFO] [stdout] | argument requires that `network` is borrowed for `'static` [INFO] [stdout] ... [INFO] [stdout] 1602 | } [INFO] [stdout] | - `network` dropped here while still borrowed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0505]: cannot move out of `network` because it is borrowed [INFO] [stdout] --> src/voter/mod.rs:1573:39 [INFO] [stdout] | [INFO] [stdout] 1570 | let (network, routing_task) = testing::environment::make_network(); [INFO] [stdout] | ------- binding `network` declared here [INFO] [stdout] 1571 | [INFO] [stdout] 1572 | let global_comms = network.make_global_comms(); [INFO] [stdout] | --------------------------- [INFO] [stdout] | | [INFO] [stdout] | borrow of `network` occurs here [INFO] [stdout] | argument requires that `network` is borrowed for `'static` [INFO] [stdout] 1573 | let env = Arc::new(Environment::new(network, local_id)); [INFO] [stdout] | ^^^^^^^ move out of `network` occurs here [INFO] [stdout] | [INFO] [stdout] help: consider cloning the value if the performance cost is acceptable [INFO] [stdout] | [INFO] [stdout] 1572 | let global_comms = network.clone().make_global_comms(); [INFO] [stdout] | ++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0597]: `network` does not live long enough [INFO] [stdout] --> src/voter/mod.rs:1611:22 [INFO] [stdout] | [INFO] [stdout] 1609 | let (network, routing_task) = testing::environment::make_network(); [INFO] [stdout] | ------- binding `network` declared here [INFO] [stdout] 1610 | [INFO] [stdout] 1611 | let global_comms = network.make_global_comms(); [INFO] [stdout] | ^^^^^^^-------------------- [INFO] [stdout] | | [INFO] [stdout] | borrowed value does not live long enough [INFO] [stdout] | argument requires that `network` is borrowed for `'static` [INFO] [stdout] ... [INFO] [stdout] 1703 | } [INFO] [stdout] | - `network` dropped here while still borrowed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0597]: `network` does not live long enough [INFO] [stdout] --> src/voter/mod.rs:1650:26 [INFO] [stdout] | [INFO] [stdout] 1609 | let (network, routing_task) = testing::environment::make_network(); [INFO] [stdout] | ------- binding `network` declared here [INFO] [stdout] ... [INFO] [stdout] 1650 | let (_, round_sink) = network.make_round_comms(2, Id(id)); [INFO] [stdout] | ^^^^^^^---------------------------- [INFO] [stdout] | | [INFO] [stdout] | borrowed value does not live long enough [INFO] [stdout] | argument requires that `network` is borrowed for `'static` [INFO] [stdout] ... [INFO] [stdout] 1703 | } [INFO] [stdout] | - `network` dropped here while still borrowed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0597]: `network` does not live long enough [INFO] [stdout] --> src/voter/mod.rs:1658:25 [INFO] [stdout] | [INFO] [stdout] 1609 | let (network, routing_task) = testing::environment::make_network(); [INFO] [stdout] | ------- binding `network` declared here [INFO] [stdout] ... [INFO] [stdout] 1658 | let (_, round_sink) = network.make_round_comms(1, sender); [INFO] [stdout] | ^^^^^^^---------------------------- [INFO] [stdout] | | [INFO] [stdout] | borrowed value does not live long enough [INFO] [stdout] | argument requires that `network` is borrowed for `'static` [INFO] [stdout] ... [INFO] [stdout] 1703 | } [INFO] [stdout] | - `network` dropped here while still borrowed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: lifetime may not live long enough [INFO] [stdout] --> src/testing.rs:247:4 [INFO] [stdout] | [INFO] [stdout] 243 | fn round_data(&self, round: u64) -> RoundData { [INFO] [stdout] | - let's call the lifetime of this reference `'1` [INFO] [stdout] ... [INFO] [stdout] 247 | / RoundData { [INFO] [stdout] 248 | | voter_id: Some(self.local_id), [INFO] [stdout] 249 | | prevote_timer: Box::new(Delay::new(GOSSIP_DURATION).map(Ok)), [INFO] [stdout] 250 | | precommit_timer: Box::new(Delay::new(GOSSIP_DURATION + GOSSIP_DURATION).map(Ok)), [INFO] [stdout] 251 | | incoming: Box::new(incoming), [INFO] [stdout] 252 | | outgoing: Box::pin(outgoing), [INFO] [stdout] 253 | | } [INFO] [stdout] | |_____________^ returning this value requires that `'1` must outlive `'static` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 22 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] Some errors have detailed explanations: E0505, E0597. [INFO] [stdout] [INFO] [stdout] For more information about an error, try `rustc --explain E0505`. [INFO] [stdout] [INFO] [stderr] error: could not compile `finality-grandpa` (lib test) due to 23 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "6a6c63c744c2cbe4696a60b4d1866f698949cf8e9cb66cf87a31384601d9c394", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6a6c63c744c2cbe4696a60b4d1866f698949cf8e9cb66cf87a31384601d9c394", kill_on_drop: false }` [INFO] [stdout] 6a6c63c744c2cbe4696a60b4d1866f698949cf8e9cb66cf87a31384601d9c394