[INFO] fetching crate efiloader 0.0.1... [INFO] checking efiloader-0.0.1 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate efiloader 0.0.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate efiloader 0.0.1 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate efiloader 0.0.1 [INFO] finished tweaking crates.io crate efiloader 0.0.1 [INFO] tweaked toml for crates.io crate efiloader 0.0.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 26 packages to latest compatible versions [INFO] [stderr] Adding spinning_top v0.2.5 (available: v0.3.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0b18feeca91f04cfef4a61ee86b551058c6e26f47dc7cf898e3b4d1435c309a9 [INFO] running `Command { std: "docker" "start" "-a" "0b18feeca91f04cfef4a61ee86b551058c6e26f47dc7cf898e3b4d1435c309a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0b18feeca91f04cfef4a61ee86b551058c6e26f47dc7cf898e3b4d1435c309a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0b18feeca91f04cfef4a61ee86b551058c6e26f47dc7cf898e3b4d1435c309a9", kill_on_drop: false }` [INFO] [stdout] 0b18feeca91f04cfef4a61ee86b551058c6e26f47dc7cf898e3b4d1435c309a9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1159460f1aecd3966a96733c10d22790bd62307448290af030cf1655f16c6001 [INFO] running `Command { std: "docker" "start" "-a" "1159460f1aecd3966a96733c10d22790bd62307448290af030cf1655f16c6001", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Checking crc-catalog v2.4.0 [INFO] [stderr] Checking widestring v1.1.0 [INFO] [stderr] Checking const-utf16 v0.2.1 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking spinning_top v0.2.5 [INFO] [stderr] Checking linked_list_allocator v0.10.5 [INFO] [stderr] Checking crc v3.2.1 [INFO] [stderr] Checking efiloader v0.0.1 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `efiloader` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/lib.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/lib.rs:54:6 [INFO] [stderr] | [INFO] [stderr] 54 | ($value:expr_2021, $alignment:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/lib.rs:54:24 [INFO] [stderr] | [INFO] [stderr] 54 | ($value:expr_2021, $alignment:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/lib.rs:134:43 [INFO] [stderr] | [INFO] [stderr] 134 | ($a:literal, $b:literal, $c: literal, $d:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: unsafe attribute used without unsafe [INFO] [stdout] --> src/bootservices.rs:1058:3 [INFO] [stdout] | [INFO] [stdout] 1058 | #[no_mangle] [INFO] [stdout] | ^^^^^^^^^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123757 [INFO] [stdout] = note: `--force-warn unsafe-attr-outside-unsafe` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 1058 | #[unsafe(no_mangle)] [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe attribute used without unsafe [INFO] [stdout] --> src/bootservices.rs:1120:3 [INFO] [stdout] | [INFO] [stdout] 1120 | #[no_mangle] [INFO] [stdout] | ^^^^^^^^^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123757 [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 1120 | #[unsafe(no_mangle)] [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/lib.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | ($value:expr, $alignment:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 54 | ($value:expr_2021, $alignment:expr) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/lib.rs:54:30 [INFO] [stdout] | [INFO] [stdout] 54 | ($value:expr, $alignment:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 54 | ($value:expr, $alignment:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/bootservices.rs:1035:1 [INFO] [stdout] | [INFO] [stdout] 1035 | extern "efiapi" { [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | _help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | | [INFO] [stdout] 1036 | | fn install_multiple_protocol_interfaces_wrapper(handle: *mut Handle) -> Status; [INFO] [stdout] 1037 | | fn uninstall_multiple_protocol_interfaces_wrapper(handle: Handle) -> Status; [INFO] [stdout] 1038 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] = note: `--force-warn missing-unsafe-on-extern` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/loadedimage.rs:175:1 [INFO] [stdout] | [INFO] [stdout] 175 | extern "C" { [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | _help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | | [INFO] [stdout] 176 | | fn start_image( [INFO] [stdout] 177 | | image_handle: Handle, [INFO] [stdout] 178 | | system_table: *const SystemTable, [INFO] [stdout] ... | [INFO] [stdout] 184 | | pub fn exit_image(status: Status, sp: usize) -> !; [INFO] [stdout] 185 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/lib.rs:134:46 [INFO] [stdout] | [INFO] [stdout] 134 | ($a:literal, $b:literal, $c: literal, $d:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 134 | ($a:literal, $b:literal, $c: literal, $d:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::intrinsics::copy` is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:745:9 [INFO] [stdout] | [INFO] [stdout] 745 | ptr::copy(src.offset(offset as isize), dst, len); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/bootservices.rs:732:5 [INFO] [stdout] | [INFO] [stdout] 732 | / unsafe fn load_range<'a>( [INFO] [stdout] 733 | | &self, [INFO] [stdout] 734 | | loadbuffer: *mut (), [INFO] [stdout] 735 | | offset: usize, [INFO] [stdout] 736 | | size: usize, [INFO] [stdout] 737 | | ) -> Result<(), &str> { [INFO] [stdout] | |_________________________^ [INFO] [stdout] = note: `--force-warn unsafe-op-in-unsafe-fn` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::const_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:745:19 [INFO] [stdout] | [INFO] [stdout] 745 | ptr::copy(src.offset(offset as isize), dst, len); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::intrinsics::write_bytes` is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:747:13 [INFO] [stdout] | [INFO] [stdout] 747 | ptr::write_bytes(dst.offset(len as isize), 0, size - len); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:747:30 [INFO] [stdout] | [INFO] [stdout] 747 | ptr::write_bytes(dst.offset(len as isize), 0, size - len); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:1043:12 [INFO] [stdout] | [INFO] [stdout] 1043 | while !(*p).is_null() { [INFO] [stdout] | ^^^^ dereference of raw pointer [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/bootservices.rs:1040:1 [INFO] [stdout] | [INFO] [stdout] 1040 | unsafe fn parse_multiproto_varargs(p: *const *const ()) -> Option> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:1044:18 [INFO] [stdout] | [INFO] [stdout] 1044 | let g = &*(*p as *const Guid); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ dereference of raw pointer [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:1044:20 [INFO] [stdout] | [INFO] [stdout] 1044 | let g = &*(*p as *const Guid); [INFO] [stdout] | ^^ dereference of raw pointer [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:1045:25 [INFO] [stdout] | [INFO] [stdout] 1045 | if m.insert(*g, *p.offset(1)).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^ dereference of raw pointer [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::const_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:1045:26 [INFO] [stdout] | [INFO] [stdout] 1045 | if m.insert(*g, *p.offset(1)).is_some() { [INFO] [stdout] | ^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::const_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:1049:13 [INFO] [stdout] | [INFO] [stdout] 1049 | p = p.offset(2); [INFO] [stdout] | ^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:276:20 [INFO] [stdout] | [INFO] [stdout] 276 | (base, base.offset(l)) [INFO] [stdout] | ^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/peloader.rs:272:5 [INFO] [stdout] | [INFO] [stdout] 272 | unsafe fn apply_relocations(buf: &mut [MaybeUninit], tbl: &PeTable) -> Result<(), ()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:279:25 [INFO] [stdout] | [INFO] [stdout] 279 | let mut reloc = base.offset(tbl.rva as isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:280:25 [INFO] [stdout] | [INFO] [stdout] 280 | let reloc_end = reloc.offset(tbl.size as isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:288:26 [INFO] [stdout] | [INFO] [stdout] 288 | let block = &*(reloc as *const BaseRelocationBlock); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ dereference of raw pointer [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | reloc = reloc.offset(BSIZE as isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::slice::from_raw_parts` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:296:35 [INFO] [stdout] | [INFO] [stdout] 296 | let entries: &[u16] = slice::from_raw_parts(reloc as _, block_len); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:297:21 [INFO] [stdout] | [INFO] [stdout] 297 | reloc = reloc.offset(block_size as isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:304:25 [INFO] [stdout] | [INFO] [stdout] 304 | let p = base.offset(offset as isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:305:20 [INFO] [stdout] | [INFO] [stdout] 305 | if p.offset(size_of::() as isize) > limit { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::write_unaligned` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:315:25 [INFO] [stdout] | [INFO] [stdout] 315 | p.write_unaligned(p.read_unaligned() + base as u64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::read_unaligned` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:315:43 [INFO] [stdout] | [INFO] [stdout] 315 | p.write_unaligned(p.read_unaligned() + base as u64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/bootservices.rs:310:18 [INFO] [stdout] | [INFO] [stdout] 310 | let ret = if let Some(region) = EFI.allocate_pages(pages, memory_type, placement) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^---^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/bootservices.rs:313:5 [INFO] [stdout] | [INFO] [stdout] 313 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 310 ~ let ret = match EFI.allocate_pages(pages, memory_type, placement) { Some(region) => { [INFO] [stdout] 311 | *m = region.as_ptr() as PhysicalAddress; [INFO] [stdout] 312 | Status::EFI_SUCCESS [INFO] [stdout] 313 ~ } _ => { [INFO] [stdout] 314 | Status::EFI_OUT_OF_RESOURCES [INFO] [stdout] 315 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/bootservices.rs:324:18 [INFO] [stdout] | [INFO] [stdout] 324 | let ret = if let Ok(_) = EFI.free_pages(memory, pages) { [INFO] [stdout] | ^^^^^^^^^^^^---^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/bootservices.rs:326:5 [INFO] [stdout] | [INFO] [stdout] 326 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 324 ~ let ret = match EFI.free_pages(memory, pages) { Ok(_) => { [INFO] [stdout] 325 | Status::EFI_SUCCESS [INFO] [stdout] 326 ~ } _ => { [INFO] [stdout] 327 | Status::EFI_NOT_FOUND [INFO] [stdout] 328 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/bootservices.rs:355:8 [INFO] [stdout] | [INFO] [stdout] 355 | if let Some((key, len)) = EFI.memmap.get_memory_map(buffer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^---^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/bootservices.rs:361:5 [INFO] [stdout] | [INFO] [stdout] 361 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 355 ~ match EFI.memmap.get_memory_map(buffer) { Some((key, len)) => { [INFO] [stdout] 356 | *map_size = len * desc_size; [INFO] [stdout] ... [INFO] [stdout] 360 | Status::EFI_SUCCESS [INFO] [stdout] 361 ~ } _ => { [INFO] [stdout] 362 | Status::EFI_BUFFER_TOO_SMALL [INFO] [stdout] 363 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/bootservices.rs:376:8 [INFO] [stdout] | [INFO] [stdout] 376 | if let Ok(buf) = EFI.allocate_pool(pool_type, size) { [INFO] [stdout] | ^^^^^^^^^^^^^^---^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/bootservices.rs:379:5 [INFO] [stdout] | [INFO] [stdout] 379 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 376 ~ match EFI.allocate_pool(pool_type, size) { Ok(buf) => { [INFO] [stdout] 377 | unsafe { *buffer = buf.as_ptr() as _ }; [INFO] [stdout] 378 | Status::EFI_SUCCESS [INFO] [stdout] 379 ~ } _ => { [INFO] [stdout] 380 | Status::EFI_OUT_OF_RESOURCES [INFO] [stdout] 381 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/bootservices.rs:676:18 [INFO] [stdout] | [INFO] [stdout] 676 | let ret = if let Some(entry) = db [INFO] [stdout] | ^ -- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | __________________| [INFO] [stdout] | | [INFO] [stdout] 677 | | .iter() [INFO] [stdout] 678 | | .filter_map( [INFO] [stdout] 679 | | |entry: (&(Handle, Guid), &Pin>)| { [INFO] [stdout] ... | [INFO] [stdout] 682 | | ) [INFO] [stdout] 683 | | .max_by(|a, b| a.0.cmp(&b.0)) [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/bootservices.rs:694:5 [INFO] [stdout] | [INFO] [stdout] 694 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 676 ~ let ret = match db [INFO] [stdout] 677 | .iter() [INFO] [stdout] ... [INFO] [stdout] 683 | .max_by(|a, b| a.0.cmp(&b.0)) [INFO] [stdout] 684 ~ { Some(entry) => { [INFO] [stdout] 685 | if !device.is_null() { [INFO] [stdout] ... [INFO] [stdout] 693 | } [INFO] [stdout] 694 ~ } _ => { [INFO] [stdout] 695 | Status::EFI_NOT_FOUND [INFO] [stdout] 696 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/bootservices.rs:771:8 [INFO] [stdout] | [INFO] [stdout] 771 | if let Some(li) = EFI.load_image(&ldr) { [INFO] [stdout] | ^^^^^^^^^^^^^^^-------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/bootservices.rs:776:5 [INFO] [stdout] | [INFO] [stdout] 776 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 771 ~ match EFI.load_image(&ldr) { Some(li) => { [INFO] [stdout] 772 | unsafe { [INFO] [stdout] ... [INFO] [stdout] 775 | Status::EFI_SUCCESS [INFO] [stdout] 776 ~ } _ => { [INFO] [stdout] 777 | Status::EFI_LOAD_ERROR [INFO] [stdout] 778 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/bootservices.rs:789:8 [INFO] [stdout] | [INFO] [stdout] 789 | if let Some(proto) = db.get(&key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^--^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/bootservices.rs:795:5 [INFO] [stdout] | [INFO] [stdout] 795 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 789 ~ match db.get(&key) { Some(proto) => { [INFO] [stdout] 790 | let li = unsafe { &*(proto.as_proto_ptr() as *const EfiLoadedImage) }; [INFO] [stdout] ... [INFO] [stdout] 794 | ret [INFO] [stdout] 795 ~ } _ => { [INFO] [stdout] 796 | Status::EFI_INVALID_PARAMETER [INFO] [stdout] 797 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/bootservices.rs:889:18 [INFO] [stdout] | [INFO] [stdout] 889 | let ret = if let Some(proto) = EFI.protocol_db.borrow().get(&key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------------------------^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/bootservices.rs:895:5 [INFO] [stdout] | [INFO] [stdout] 895 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 889 ~ let ret = match EFI.protocol_db.borrow().get(&key) { Some(proto) => { [INFO] [stdout] 890 | if attributes != EFI_OPEN_PROTOCOL_TEST_PROTOCOL { [INFO] [stdout] ... [INFO] [stdout] 894 | Status::EFI_SUCCESS [INFO] [stdout] 895 ~ } _ => { [INFO] [stdout] 896 | Status::EFI_UNSUPPORTED [INFO] [stdout] 897 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/bootservices.rs:948:18 [INFO] [stdout] | [INFO] [stdout] 948 | let ret = if let Ok(buf) = EFI [INFO] [stdout] | ^ --- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | __________________| [INFO] [stdout] | | [INFO] [stdout] 949 | | .memmap [INFO] [stdout] 950 | | .allocate_pool::<*const Guid>(EfiMemoryType::EfiLoaderData, guids.len()) [INFO] [stdout] | |________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/bootservices.rs:958:5 [INFO] [stdout] | [INFO] [stdout] 958 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 948 ~ let ret = match EFI [INFO] [stdout] 949 | .memmap [INFO] [stdout] 950 | .allocate_pool::<*const Guid>(EfiMemoryType::EfiLoaderData, guids.len()) [INFO] [stdout] 951 ~ { Ok(buf) => { [INFO] [stdout] 952 | unsafe { [INFO] [stdout] ... [INFO] [stdout] 957 | Status::EFI_SUCCESS [INFO] [stdout] 958 ~ } _ => { [INFO] [stdout] 959 | Status::EFI_OUT_OF_RESOURCES [INFO] [stdout] 960 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/bootservices.rs:983:12 [INFO] [stdout] | [INFO] [stdout] 983 | if let Ok(buf) = EFI [INFO] [stdout] | ^ --- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | ____________| [INFO] [stdout] | | [INFO] [stdout] 984 | | .memmap [INFO] [stdout] 985 | | .allocate_pool::(EfiMemoryType::EfiLoaderData, handles.len()) [INFO] [stdout] | |_________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/bootservices.rs:993:9 [INFO] [stdout] | [INFO] [stdout] 993 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 983 ~ match EFI [INFO] [stdout] 984 | .memmap [INFO] [stdout] 985 | .allocate_pool::(EfiMemoryType::EfiLoaderData, handles.len()) [INFO] [stdout] 986 ~ { Ok(buf) => { [INFO] [stdout] 987 | unsafe { [INFO] [stdout] ... [INFO] [stdout] 992 | Status::EFI_SUCCESS [INFO] [stdout] 993 ~ } _ => { [INFO] [stdout] 994 | Status::EFI_OUT_OF_RESOURCES [INFO] [stdout] 995 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/bootservices.rs:1012:18 [INFO] [stdout] | [INFO] [stdout] 1012 | let ret = if let Some(entry) = EFI [INFO] [stdout] | ___________________^ - [INFO] [stdout] | | ____________________________________| [INFO] [stdout] 1013 | || .protocol_db [INFO] [stdout] 1014 | || .borrow() [INFO] [stdout] | ||_________________- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] 1015 | | .iter() [INFO] [stdout] 1016 | | .find(|e: &(&(usize, Guid), &Pin>)| e.0 .1 == protocol) [INFO] [stdout] | |____________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/bootservices.rs:1020:5 [INFO] [stdout] | [INFO] [stdout] 1020 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 1012 ~ let ret = match EFI [INFO] [stdout] 1013 | .protocol_db [INFO] [stdout] ... [INFO] [stdout] 1016 | .find(|e: &(&(usize, Guid), &Pin>)| e.0 .1 == protocol) [INFO] [stdout] 1017 ~ { Some(entry) => { [INFO] [stdout] 1018 | *interface = entry.1.as_proto_ptr(); [INFO] [stdout] 1019 | Status::EFI_SUCCESS [INFO] [stdout] 1020 ~ } _ => { [INFO] [stdout] 1021 | *interface = ptr::null(); [INFO] [stdout] 1022 | Status::EFI_NOT_FOUND [INFO] [stdout] 1023 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/bootservices.rs:1088:12 [INFO] [stdout] | [INFO] [stdout] 1088 | if let Some(_) = db.iter().find(|e| { [INFO] [stdout] | ^ -- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | ____________| [INFO] [stdout] | | [INFO] [stdout] 1089 | | let p = e.1.as_proto_ptr(); [INFO] [stdout] 1090 | | !p.is_null() && e.0 .1 == EFI_DEVICE_PATH_PROTOCOL_GUID && { [INFO] [stdout] 1091 | | let dp = unsafe { &*(p as *const DevicePath) }; [INFO] [stdout] 1092 | | devpath.equals(dp) [INFO] [stdout] 1093 | | } [INFO] [stdout] 1094 | | }) { [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/bootservices.rs:1096:9 [INFO] [stdout] | [INFO] [stdout] 1096 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 1088 ~ match db.iter().find(|e| { [INFO] [stdout] 1089 | let p = e.1.as_proto_ptr(); [INFO] [stdout] ... [INFO] [stdout] 1093 | } [INFO] [stdout] 1094 ~ }) { Some(_) => { [INFO] [stdout] 1095 | return Status::EFI_INVALID_PARAMETER; [INFO] [stdout] 1096 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/initrdloadfile2.rs:90:8 [INFO] [stdout] | [INFO] [stdout] 90 | if let Ok(_) = this.loader.load_file(buffer) { [INFO] [stdout] | ^^^^^^^^^^^^-----------^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/initrdloadfile2.rs:93:5 [INFO] [stdout] | [INFO] [stdout] 93 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 90 ~ match this.loader.load_file(buffer) { Ok(_) => { [INFO] [stdout] 91 | *buffer_size = filesize; [INFO] [stdout] 92 | Status::EFI_SUCCESS [INFO] [stdout] 93 ~ } _ => { [INFO] [stdout] 94 | Status::EFI_DEVICE_ERROR [INFO] [stdout] 95 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/memmap.rs:145:12 [INFO] [stdout] | [INFO] [stdout] 145 | if let Some((pool_type, layout)) = db.allocations.remove(&buffer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^--^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/memmap.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 151 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 145 ~ match db.allocations.remove(&buffer) { Some((pool_type, layout)) => { [INFO] [stdout] 146 | Ok(db [INFO] [stdout] ... [INFO] [stdout] 150 | .deallocate(buffer, layout)) [INFO] [stdout] 151 ~ } _ => { [INFO] [stdout] 152 | Err(()) [INFO] [stdout] 153 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/memmap.rs:445:20 [INFO] [stdout] | [INFO] [stdout] 445 | if let Some(desc) = mm [INFO] [stdout] | ^ -- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | ____________________| [INFO] [stdout] | | [INFO] [stdout] 446 | | .values() [INFO] [stdout] 447 | | .take_while(|d| ((d.physical_start - 1) | mask) + (p << EFI_PAGE_SHIFT) <= max) [INFO] [stdout] 448 | | .filter(|d| { [INFO] [stdout] ... | [INFO] [stdout] 452 | | }) [INFO] [stdout] 453 | | .last() [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/memmap.rs:461:17 [INFO] [stdout] | [INFO] [stdout] 461 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 445 ~ match mm [INFO] [stdout] 446 | .values() [INFO] [stdout] ... [INFO] [stdout] 453 | .last() [INFO] [stdout] 454 ~ { Some(desc) => { [INFO] [stdout] 455 | // Find the highest possible base resulting from the limit in 'max' [INFO] [stdout] ... [INFO] [stdout] 460 | highest_base.min(desc.physical_start + offset) & !mask as u64 [INFO] [stdout] 461 ~ } _ => { [INFO] [stdout] 462 | return None; [INFO] [stdout] 463 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/memmap.rs:529:16 [INFO] [stdout] | [INFO] [stdout] 529 | if let Some(table) = self.get_memattr_table(&mm, key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^--^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/memmap.rs:539:13 [INFO] [stdout] | [INFO] [stdout] 539 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 529 ~ match self.get_memattr_table(&mm, key) { Some(table) => { [INFO] [stdout] 530 | drop(mm); [INFO] [stdout] ... [INFO] [stdout] 538 | (self.memmap.borrow(), self.mapkey.load(Ordering::Acquire)) [INFO] [stdout] 539 ~ } _ => { [INFO] [stdout] 540 | (mm, key) [INFO] [stdout] 541 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 44 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `efiloader` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/lib.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/lib.rs:54:6 [INFO] [stderr] | [INFO] [stderr] 54 | ($value:expr_2021, $alignment:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/lib.rs:54:24 [INFO] [stderr] | [INFO] [stderr] 54 | ($value:expr_2021, $alignment:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/lib.rs:134:43 [INFO] [stderr] | [INFO] [stderr] 134 | ($a:literal, $b:literal, $c: literal, $d:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: unsafe attribute used without unsafe [INFO] [stdout] --> src/bootservices.rs:1058:3 [INFO] [stdout] | [INFO] [stdout] 1058 | #[no_mangle] [INFO] [stdout] | ^^^^^^^^^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123757 [INFO] [stdout] = note: `--force-warn unsafe-attr-outside-unsafe` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 1058 | #[unsafe(no_mangle)] [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe attribute used without unsafe [INFO] [stdout] --> src/bootservices.rs:1120:3 [INFO] [stdout] | [INFO] [stdout] 1120 | #[no_mangle] [INFO] [stdout] | ^^^^^^^^^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123757 [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 1120 | #[unsafe(no_mangle)] [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/lib.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | ($value:expr, $alignment:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 54 | ($value:expr_2021, $alignment:expr) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/lib.rs:54:30 [INFO] [stdout] | [INFO] [stdout] 54 | ($value:expr, $alignment:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 54 | ($value:expr, $alignment:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/bootservices.rs:1035:1 [INFO] [stdout] | [INFO] [stdout] 1035 | extern "efiapi" { [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | _help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | | [INFO] [stdout] 1036 | | fn install_multiple_protocol_interfaces_wrapper(handle: *mut Handle) -> Status; [INFO] [stdout] 1037 | | fn uninstall_multiple_protocol_interfaces_wrapper(handle: Handle) -> Status; [INFO] [stdout] 1038 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] = note: `--force-warn missing-unsafe-on-extern` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/loadedimage.rs:175:1 [INFO] [stdout] | [INFO] [stdout] 175 | extern "C" { [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | _help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | | [INFO] [stdout] 176 | | fn start_image( [INFO] [stdout] 177 | | image_handle: Handle, [INFO] [stdout] 178 | | system_table: *const SystemTable, [INFO] [stdout] ... | [INFO] [stdout] 184 | | pub fn exit_image(status: Status, sp: usize) -> !; [INFO] [stdout] 185 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/lib.rs:134:46 [INFO] [stdout] | [INFO] [stdout] 134 | ($a:literal, $b:literal, $c: literal, $d:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 134 | ($a:literal, $b:literal, $c: literal, $d:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::intrinsics::copy` is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:745:9 [INFO] [stdout] | [INFO] [stdout] 745 | ptr::copy(src.offset(offset as isize), dst, len); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/bootservices.rs:732:5 [INFO] [stdout] | [INFO] [stdout] 732 | / unsafe fn load_range<'a>( [INFO] [stdout] 733 | | &self, [INFO] [stdout] 734 | | loadbuffer: *mut (), [INFO] [stdout] 735 | | offset: usize, [INFO] [stdout] 736 | | size: usize, [INFO] [stdout] 737 | | ) -> Result<(), &str> { [INFO] [stdout] | |_________________________^ [INFO] [stdout] = note: `--force-warn unsafe-op-in-unsafe-fn` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::const_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:745:19 [INFO] [stdout] | [INFO] [stdout] 745 | ptr::copy(src.offset(offset as isize), dst, len); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::intrinsics::write_bytes` is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:747:13 [INFO] [stdout] | [INFO] [stdout] 747 | ptr::write_bytes(dst.offset(len as isize), 0, size - len); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:747:30 [INFO] [stdout] | [INFO] [stdout] 747 | ptr::write_bytes(dst.offset(len as isize), 0, size - len); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:1043:12 [INFO] [stdout] | [INFO] [stdout] 1043 | while !(*p).is_null() { [INFO] [stdout] | ^^^^ dereference of raw pointer [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/bootservices.rs:1040:1 [INFO] [stdout] | [INFO] [stdout] 1040 | unsafe fn parse_multiproto_varargs(p: *const *const ()) -> Option> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:1044:18 [INFO] [stdout] | [INFO] [stdout] 1044 | let g = &*(*p as *const Guid); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ dereference of raw pointer [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:1044:20 [INFO] [stdout] | [INFO] [stdout] 1044 | let g = &*(*p as *const Guid); [INFO] [stdout] | ^^ dereference of raw pointer [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:1045:25 [INFO] [stdout] | [INFO] [stdout] 1045 | if m.insert(*g, *p.offset(1)).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^ dereference of raw pointer [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::const_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:1045:26 [INFO] [stdout] | [INFO] [stdout] 1045 | if m.insert(*g, *p.offset(1)).is_some() { [INFO] [stdout] | ^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::const_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:1049:13 [INFO] [stdout] | [INFO] [stdout] 1049 | p = p.offset(2); [INFO] [stdout] | ^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:276:20 [INFO] [stdout] | [INFO] [stdout] 276 | (base, base.offset(l)) [INFO] [stdout] | ^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/peloader.rs:272:5 [INFO] [stdout] | [INFO] [stdout] 272 | unsafe fn apply_relocations(buf: &mut [MaybeUninit], tbl: &PeTable) -> Result<(), ()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:279:25 [INFO] [stdout] | [INFO] [stdout] 279 | let mut reloc = base.offset(tbl.rva as isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:280:25 [INFO] [stdout] | [INFO] [stdout] 280 | let reloc_end = reloc.offset(tbl.size as isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:288:26 [INFO] [stdout] | [INFO] [stdout] 288 | let block = &*(reloc as *const BaseRelocationBlock); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ dereference of raw pointer [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | reloc = reloc.offset(BSIZE as isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::slice::from_raw_parts` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:296:35 [INFO] [stdout] | [INFO] [stdout] 296 | let entries: &[u16] = slice::from_raw_parts(reloc as _, block_len); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:297:21 [INFO] [stdout] | [INFO] [stdout] 297 | reloc = reloc.offset(block_size as isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:304:25 [INFO] [stdout] | [INFO] [stdout] 304 | let p = base.offset(offset as isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:305:20 [INFO] [stdout] | [INFO] [stdout] 305 | if p.offset(size_of::() as isize) > limit { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::write_unaligned` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:315:25 [INFO] [stdout] | [INFO] [stdout] 315 | p.write_unaligned(p.read_unaligned() + base as u64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::read_unaligned` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:315:43 [INFO] [stdout] | [INFO] [stdout] 315 | p.write_unaligned(p.read_unaligned() + base as u64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/bootservices.rs:310:18 [INFO] [stdout] | [INFO] [stdout] 310 | let ret = if let Some(region) = EFI.allocate_pages(pages, memory_type, placement) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^---^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/bootservices.rs:313:5 [INFO] [stdout] | [INFO] [stdout] 313 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 310 ~ let ret = match EFI.allocate_pages(pages, memory_type, placement) { Some(region) => { [INFO] [stdout] 311 | *m = region.as_ptr() as PhysicalAddress; [INFO] [stdout] 312 | Status::EFI_SUCCESS [INFO] [stdout] 313 ~ } _ => { [INFO] [stdout] 314 | Status::EFI_OUT_OF_RESOURCES [INFO] [stdout] 315 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/bootservices.rs:324:18 [INFO] [stdout] | [INFO] [stdout] 324 | let ret = if let Ok(_) = EFI.free_pages(memory, pages) { [INFO] [stdout] | ^^^^^^^^^^^^---^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/bootservices.rs:326:5 [INFO] [stdout] | [INFO] [stdout] 326 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 324 ~ let ret = match EFI.free_pages(memory, pages) { Ok(_) => { [INFO] [stdout] 325 | Status::EFI_SUCCESS [INFO] [stdout] 326 ~ } _ => { [INFO] [stdout] 327 | Status::EFI_NOT_FOUND [INFO] [stdout] 328 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/bootservices.rs:355:8 [INFO] [stdout] | [INFO] [stdout] 355 | if let Some((key, len)) = EFI.memmap.get_memory_map(buffer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^---^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/bootservices.rs:361:5 [INFO] [stdout] | [INFO] [stdout] 361 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 355 ~ match EFI.memmap.get_memory_map(buffer) { Some((key, len)) => { [INFO] [stdout] 356 | *map_size = len * desc_size; [INFO] [stdout] ... [INFO] [stdout] 360 | Status::EFI_SUCCESS [INFO] [stdout] 361 ~ } _ => { [INFO] [stdout] 362 | Status::EFI_BUFFER_TOO_SMALL [INFO] [stdout] 363 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/bootservices.rs:376:8 [INFO] [stdout] | [INFO] [stdout] 376 | if let Ok(buf) = EFI.allocate_pool(pool_type, size) { [INFO] [stdout] | ^^^^^^^^^^^^^^---^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/bootservices.rs:379:5 [INFO] [stdout] | [INFO] [stdout] 379 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 376 ~ match EFI.allocate_pool(pool_type, size) { Ok(buf) => { [INFO] [stdout] 377 | unsafe { *buffer = buf.as_ptr() as _ }; [INFO] [stdout] 378 | Status::EFI_SUCCESS [INFO] [stdout] 379 ~ } _ => { [INFO] [stdout] 380 | Status::EFI_OUT_OF_RESOURCES [INFO] [stdout] 381 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/bootservices.rs:676:18 [INFO] [stdout] | [INFO] [stdout] 676 | let ret = if let Some(entry) = db [INFO] [stdout] | ^ -- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | __________________| [INFO] [stdout] | | [INFO] [stdout] 677 | | .iter() [INFO] [stdout] 678 | | .filter_map( [INFO] [stdout] 679 | | |entry: (&(Handle, Guid), &Pin>)| { [INFO] [stdout] ... | [INFO] [stdout] 682 | | ) [INFO] [stdout] 683 | | .max_by(|a, b| a.0.cmp(&b.0)) [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/bootservices.rs:694:5 [INFO] [stdout] | [INFO] [stdout] 694 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 676 ~ let ret = match db [INFO] [stdout] 677 | .iter() [INFO] [stdout] ... [INFO] [stdout] 683 | .max_by(|a, b| a.0.cmp(&b.0)) [INFO] [stdout] 684 ~ { Some(entry) => { [INFO] [stdout] 685 | if !device.is_null() { [INFO] [stdout] ... [INFO] [stdout] 693 | } [INFO] [stdout] 694 ~ } _ => { [INFO] [stdout] 695 | Status::EFI_NOT_FOUND [INFO] [stdout] 696 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/bootservices.rs:771:8 [INFO] [stdout] | [INFO] [stdout] 771 | if let Some(li) = EFI.load_image(&ldr) { [INFO] [stdout] | ^^^^^^^^^^^^^^^-------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/bootservices.rs:776:5 [INFO] [stdout] | [INFO] [stdout] 776 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 771 ~ match EFI.load_image(&ldr) { Some(li) => { [INFO] [stdout] 772 | unsafe { [INFO] [stdout] ... [INFO] [stdout] 775 | Status::EFI_SUCCESS [INFO] [stdout] 776 ~ } _ => { [INFO] [stdout] 777 | Status::EFI_LOAD_ERROR [INFO] [stdout] 778 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/bootservices.rs:789:8 [INFO] [stdout] | [INFO] [stdout] 789 | if let Some(proto) = db.get(&key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^--^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/bootservices.rs:795:5 [INFO] [stdout] | [INFO] [stdout] 795 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 789 ~ match db.get(&key) { Some(proto) => { [INFO] [stdout] 790 | let li = unsafe { &*(proto.as_proto_ptr() as *const EfiLoadedImage) }; [INFO] [stdout] ... [INFO] [stdout] 794 | ret [INFO] [stdout] 795 ~ } _ => { [INFO] [stdout] 796 | Status::EFI_INVALID_PARAMETER [INFO] [stdout] 797 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/bootservices.rs:889:18 [INFO] [stdout] | [INFO] [stdout] 889 | let ret = if let Some(proto) = EFI.protocol_db.borrow().get(&key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------------------------^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/bootservices.rs:895:5 [INFO] [stdout] | [INFO] [stdout] 895 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 889 ~ let ret = match EFI.protocol_db.borrow().get(&key) { Some(proto) => { [INFO] [stdout] 890 | if attributes != EFI_OPEN_PROTOCOL_TEST_PROTOCOL { [INFO] [stdout] ... [INFO] [stdout] 894 | Status::EFI_SUCCESS [INFO] [stdout] 895 ~ } _ => { [INFO] [stdout] 896 | Status::EFI_UNSUPPORTED [INFO] [stdout] 897 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/bootservices.rs:948:18 [INFO] [stdout] | [INFO] [stdout] 948 | let ret = if let Ok(buf) = EFI [INFO] [stdout] | ^ --- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | __________________| [INFO] [stdout] | | [INFO] [stdout] 949 | | .memmap [INFO] [stdout] 950 | | .allocate_pool::<*const Guid>(EfiMemoryType::EfiLoaderData, guids.len()) [INFO] [stdout] | |________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/bootservices.rs:958:5 [INFO] [stdout] | [INFO] [stdout] 958 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 948 ~ let ret = match EFI [INFO] [stdout] 949 | .memmap [INFO] [stdout] 950 | .allocate_pool::<*const Guid>(EfiMemoryType::EfiLoaderData, guids.len()) [INFO] [stdout] 951 ~ { Ok(buf) => { [INFO] [stdout] 952 | unsafe { [INFO] [stdout] ... [INFO] [stdout] 957 | Status::EFI_SUCCESS [INFO] [stdout] 958 ~ } _ => { [INFO] [stdout] 959 | Status::EFI_OUT_OF_RESOURCES [INFO] [stdout] 960 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/bootservices.rs:983:12 [INFO] [stdout] | [INFO] [stdout] 983 | if let Ok(buf) = EFI [INFO] [stdout] | ^ --- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | ____________| [INFO] [stdout] | | [INFO] [stdout] 984 | | .memmap [INFO] [stdout] 985 | | .allocate_pool::(EfiMemoryType::EfiLoaderData, handles.len()) [INFO] [stdout] | |_________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/bootservices.rs:993:9 [INFO] [stdout] | [INFO] [stdout] 993 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 983 ~ match EFI [INFO] [stdout] 984 | .memmap [INFO] [stdout] 985 | .allocate_pool::(EfiMemoryType::EfiLoaderData, handles.len()) [INFO] [stdout] 986 ~ { Ok(buf) => { [INFO] [stdout] 987 | unsafe { [INFO] [stdout] ... [INFO] [stdout] 992 | Status::EFI_SUCCESS [INFO] [stdout] 993 ~ } _ => { [INFO] [stdout] 994 | Status::EFI_OUT_OF_RESOURCES [INFO] [stdout] 995 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/bootservices.rs:1012:18 [INFO] [stdout] | [INFO] [stdout] 1012 | let ret = if let Some(entry) = EFI [INFO] [stdout] | ___________________^ - [INFO] [stdout] | | ____________________________________| [INFO] [stdout] 1013 | || .protocol_db [INFO] [stdout] 1014 | || .borrow() [INFO] [stdout] | ||_________________- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] 1015 | | .iter() [INFO] [stdout] 1016 | | .find(|e: &(&(usize, Guid), &Pin>)| e.0 .1 == protocol) [INFO] [stdout] | |____________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/bootservices.rs:1020:5 [INFO] [stdout] | [INFO] [stdout] 1020 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 1012 ~ let ret = match EFI [INFO] [stdout] 1013 | .protocol_db [INFO] [stdout] ... [INFO] [stdout] 1016 | .find(|e: &(&(usize, Guid), &Pin>)| e.0 .1 == protocol) [INFO] [stdout] 1017 ~ { Some(entry) => { [INFO] [stdout] 1018 | *interface = entry.1.as_proto_ptr(); [INFO] [stdout] 1019 | Status::EFI_SUCCESS [INFO] [stdout] 1020 ~ } _ => { [INFO] [stdout] 1021 | *interface = ptr::null(); [INFO] [stdout] 1022 | Status::EFI_NOT_FOUND [INFO] [stdout] 1023 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/bootservices.rs:1088:12 [INFO] [stdout] | [INFO] [stdout] 1088 | if let Some(_) = db.iter().find(|e| { [INFO] [stdout] | ^ -- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | ____________| [INFO] [stdout] | | [INFO] [stdout] 1089 | | let p = e.1.as_proto_ptr(); [INFO] [stdout] 1090 | | !p.is_null() && e.0 .1 == EFI_DEVICE_PATH_PROTOCOL_GUID && { [INFO] [stdout] 1091 | | let dp = unsafe { &*(p as *const DevicePath) }; [INFO] [stdout] 1092 | | devpath.equals(dp) [INFO] [stdout] 1093 | | } [INFO] [stdout] 1094 | | }) { [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/bootservices.rs:1096:9 [INFO] [stdout] | [INFO] [stdout] 1096 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 1088 ~ match db.iter().find(|e| { [INFO] [stdout] 1089 | let p = e.1.as_proto_ptr(); [INFO] [stdout] ... [INFO] [stdout] 1093 | } [INFO] [stdout] 1094 ~ }) { Some(_) => { [INFO] [stdout] 1095 | return Status::EFI_INVALID_PARAMETER; [INFO] [stdout] 1096 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/initrdloadfile2.rs:90:8 [INFO] [stdout] | [INFO] [stdout] 90 | if let Ok(_) = this.loader.load_file(buffer) { [INFO] [stdout] | ^^^^^^^^^^^^-----------^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/initrdloadfile2.rs:93:5 [INFO] [stdout] | [INFO] [stdout] 93 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 90 ~ match this.loader.load_file(buffer) { Ok(_) => { [INFO] [stdout] 91 | *buffer_size = filesize; [INFO] [stdout] 92 | Status::EFI_SUCCESS [INFO] [stdout] 93 ~ } _ => { [INFO] [stdout] 94 | Status::EFI_DEVICE_ERROR [INFO] [stdout] 95 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/memmap.rs:145:12 [INFO] [stdout] | [INFO] [stdout] 145 | if let Some((pool_type, layout)) = db.allocations.remove(&buffer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^--^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/memmap.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 151 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 145 ~ match db.allocations.remove(&buffer) { Some((pool_type, layout)) => { [INFO] [stdout] 146 | Ok(db [INFO] [stdout] ... [INFO] [stdout] 150 | .deallocate(buffer, layout)) [INFO] [stdout] 151 ~ } _ => { [INFO] [stdout] 152 | Err(()) [INFO] [stdout] 153 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/memmap.rs:445:20 [INFO] [stdout] | [INFO] [stdout] 445 | if let Some(desc) = mm [INFO] [stdout] | ^ -- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | ____________________| [INFO] [stdout] | | [INFO] [stdout] 446 | | .values() [INFO] [stdout] 447 | | .take_while(|d| ((d.physical_start - 1) | mask) + (p << EFI_PAGE_SHIFT) <= max) [INFO] [stdout] 448 | | .filter(|d| { [INFO] [stdout] ... | [INFO] [stdout] 452 | | }) [INFO] [stdout] 453 | | .last() [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/memmap.rs:461:17 [INFO] [stdout] | [INFO] [stdout] 461 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 445 ~ match mm [INFO] [stdout] 446 | .values() [INFO] [stdout] ... [INFO] [stdout] 453 | .last() [INFO] [stdout] 454 ~ { Some(desc) => { [INFO] [stdout] 455 | // Find the highest possible base resulting from the limit in 'max' [INFO] [stdout] ... [INFO] [stdout] 460 | highest_base.min(desc.physical_start + offset) & !mask as u64 [INFO] [stdout] 461 ~ } _ => { [INFO] [stdout] 462 | return None; [INFO] [stdout] 463 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/memmap.rs:529:16 [INFO] [stdout] | [INFO] [stdout] 529 | if let Some(table) = self.get_memattr_table(&mm, key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^--^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/memmap.rs:539:13 [INFO] [stdout] | [INFO] [stdout] 539 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 529 ~ match self.get_memattr_table(&mm, key) { Some(table) => { [INFO] [stdout] 530 | drop(mm); [INFO] [stdout] ... [INFO] [stdout] 538 | (self.memmap.borrow(), self.mapkey.load(Ordering::Acquire)) [INFO] [stdout] 539 ~ } _ => { [INFO] [stdout] 540 | (mm, key) [INFO] [stdout] 541 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 44 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.66s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking efiloader v0.0.1 (/tmp/fixit) [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/bootservices.rs:1035:1 [INFO] [stdout] | [INFO] [stdout] 1035 | / extern "efiapi" { [INFO] [stdout] 1036 | | fn install_multiple_protocol_interfaces_wrapper(handle: *mut Handle) -> Status; [INFO] [stdout] 1037 | | fn uninstall_multiple_protocol_interfaces_wrapper(handle: Handle) -> Status; [INFO] [stdout] 1038 | | } [INFO] [stdout] | |_^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> src/bootservices.rs:1058:3 [INFO] [stdout] | [INFO] [stdout] 1058 | #[no_mangle] [INFO] [stdout] | ^^^^^^^^^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 1058 | #[unsafe(no_mangle)] [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> src/bootservices.rs:1120:3 [INFO] [stdout] | [INFO] [stdout] 1120 | #[no_mangle] [INFO] [stdout] | ^^^^^^^^^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 1120 | #[unsafe(no_mangle)] [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/loadedimage.rs:175:1 [INFO] [stdout] | [INFO] [stdout] 175 | / extern "C" { [INFO] [stdout] 176 | | fn start_image( [INFO] [stdout] 177 | | image_handle: Handle, [INFO] [stdout] 178 | | system_table: *const SystemTable, [INFO] [stdout] ... | [INFO] [stdout] 184 | | pub fn exit_image(status: Status, sp: usize) -> !; [INFO] [stdout] 185 | | } [INFO] [stdout] | |_^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/bootservices.rs:1035:1 [INFO] [stdout] | [INFO] [stdout] 1035 | / extern "efiapi" { [INFO] [stdout] 1036 | | fn install_multiple_protocol_interfaces_wrapper(handle: *mut Handle) -> Status; [INFO] [stdout] 1037 | | fn uninstall_multiple_protocol_interfaces_wrapper(handle: Handle) -> Status; [INFO] [stdout] 1038 | | } [INFO] [stdout] | |_^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> src/bootservices.rs:1058:3 [INFO] [stdout] | [INFO] [stdout] 1058 | #[no_mangle] [INFO] [stdout] | ^^^^^^^^^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 1058 | #[unsafe(no_mangle)] [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> src/bootservices.rs:1120:3 [INFO] [stdout] | [INFO] [stdout] 1120 | #[no_mangle] [INFO] [stdout] | ^^^^^^^^^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 1120 | #[unsafe(no_mangle)] [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/loadedimage.rs:175:1 [INFO] [stdout] | [INFO] [stdout] 175 | / extern "C" { [INFO] [stdout] 176 | | fn start_image( [INFO] [stdout] 177 | | image_handle: Handle, [INFO] [stdout] 178 | | system_table: *const SystemTable, [INFO] [stdout] ... | [INFO] [stdout] 184 | | pub fn exit_image(status: Status, sp: usize) -> !; [INFO] [stdout] 185 | | } [INFO] [stdout] | |_^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::intrinsics::copy` is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:745:9 [INFO] [stdout] | [INFO] [stdout] 745 | ptr::copy(src.offset(offset as isize), dst, len); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/bootservices.rs:732:5 [INFO] [stdout] | [INFO] [stdout] 732 | / unsafe fn load_range<'a>( [INFO] [stdout] 733 | | &self, [INFO] [stdout] 734 | | loadbuffer: *mut (), [INFO] [stdout] 735 | | offset: usize, [INFO] [stdout] 736 | | size: usize, [INFO] [stdout] 737 | | ) -> Result<(), &str> { [INFO] [stdout] | |_________________________^ [INFO] [stdout] = note: `#[warn(unsafe_op_in_unsafe_fn)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::const_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:745:19 [INFO] [stdout] | [INFO] [stdout] 745 | ptr::copy(src.offset(offset as isize), dst, len); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::intrinsics::write_bytes` is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:747:13 [INFO] [stdout] | [INFO] [stdout] 747 | ptr::write_bytes(dst.offset(len as isize), 0, size - len); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:747:30 [INFO] [stdout] | [INFO] [stdout] 747 | ptr::write_bytes(dst.offset(len as isize), 0, size - len); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::intrinsics::copy` is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:745:9 [INFO] [stdout] | [INFO] [stdout] 745 | ptr::copy(src.offset(offset as isize), dst, len); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/bootservices.rs:732:5 [INFO] [stdout] | [INFO] [stdout] 732 | / unsafe fn load_range<'a>( [INFO] [stdout] 733 | | &self, [INFO] [stdout] 734 | | loadbuffer: *mut (), [INFO] [stdout] 735 | | offset: usize, [INFO] [stdout] 736 | | size: usize, [INFO] [stdout] 737 | | ) -> Result<(), &str> { [INFO] [stdout] | |_________________________^ [INFO] [stdout] = note: `#[warn(unsafe_op_in_unsafe_fn)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::const_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:745:19 [INFO] [stdout] | [INFO] [stdout] 745 | ptr::copy(src.offset(offset as isize), dst, len); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::intrinsics::write_bytes` is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:747:13 [INFO] [stdout] | [INFO] [stdout] 747 | ptr::write_bytes(dst.offset(len as isize), 0, size - len); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:747:30 [INFO] [stdout] | [INFO] [stdout] 747 | ptr::write_bytes(dst.offset(len as isize), 0, size - len); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:1043:12 [INFO] [stdout] | [INFO] [stdout] 1043 | while !(*p).is_null() { [INFO] [stdout] | ^^^^ dereference of raw pointer [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/bootservices.rs:1040:1 [INFO] [stdout] | [INFO] [stdout] 1040 | unsafe fn parse_multiproto_varargs(p: *const *const ()) -> Option> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:1044:18 [INFO] [stdout] | [INFO] [stdout] 1044 | let g = &*(*p as *const Guid); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ dereference of raw pointer [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:1044:20 [INFO] [stdout] | [INFO] [stdout] 1044 | let g = &*(*p as *const Guid); [INFO] [stdout] | ^^ dereference of raw pointer [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:1045:25 [INFO] [stdout] | [INFO] [stdout] 1045 | if m.insert(*g, *p.offset(1)).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^ dereference of raw pointer [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::const_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:1045:26 [INFO] [stdout] | [INFO] [stdout] 1045 | if m.insert(*g, *p.offset(1)).is_some() { [INFO] [stdout] | ^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::const_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:1049:13 [INFO] [stdout] | [INFO] [stdout] 1049 | p = p.offset(2); [INFO] [stdout] | ^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:1043:12 [INFO] [stdout] | [INFO] [stdout] 1043 | while !(*p).is_null() { [INFO] [stdout] | ^^^^ dereference of raw pointer [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/bootservices.rs:1040:1 [INFO] [stdout] | [INFO] [stdout] 1040 | unsafe fn parse_multiproto_varargs(p: *const *const ()) -> Option> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:1044:18 [INFO] [stdout] | [INFO] [stdout] 1044 | let g = &*(*p as *const Guid); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ dereference of raw pointer [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:1044:20 [INFO] [stdout] | [INFO] [stdout] 1044 | let g = &*(*p as *const Guid); [INFO] [stdout] | ^^ dereference of raw pointer [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:1045:25 [INFO] [stdout] | [INFO] [stdout] 1045 | if m.insert(*g, *p.offset(1)).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^ dereference of raw pointer [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::const_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:1045:26 [INFO] [stdout] | [INFO] [stdout] 1045 | if m.insert(*g, *p.offset(1)).is_some() { [INFO] [stdout] | ^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::const_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/bootservices.rs:1049:13 [INFO] [stdout] | [INFO] [stdout] 1049 | p = p.offset(2); [INFO] [stdout] | ^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:276:20 [INFO] [stdout] | [INFO] [stdout] 276 | (base, base.offset(l)) [INFO] [stdout] | ^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/peloader.rs:272:5 [INFO] [stdout] | [INFO] [stdout] 272 | unsafe fn apply_relocations(buf: &mut [MaybeUninit], tbl: &PeTable) -> Result<(), ()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:279:25 [INFO] [stdout] | [INFO] [stdout] 279 | let mut reloc = base.offset(tbl.rva as isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:280:25 [INFO] [stdout] | [INFO] [stdout] 280 | let reloc_end = reloc.offset(tbl.size as isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:288:26 [INFO] [stdout] | [INFO] [stdout] 288 | let block = &*(reloc as *const BaseRelocationBlock); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ dereference of raw pointer [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | reloc = reloc.offset(BSIZE as isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::slice::from_raw_parts` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:296:35 [INFO] [stdout] | [INFO] [stdout] 296 | let entries: &[u16] = slice::from_raw_parts(reloc as _, block_len); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:297:21 [INFO] [stdout] | [INFO] [stdout] 297 | reloc = reloc.offset(block_size as isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:304:25 [INFO] [stdout] | [INFO] [stdout] 304 | let p = base.offset(offset as isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:305:20 [INFO] [stdout] | [INFO] [stdout] 305 | if p.offset(size_of::() as isize) > limit { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::write_unaligned` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:315:25 [INFO] [stdout] | [INFO] [stdout] 315 | p.write_unaligned(p.read_unaligned() + base as u64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::read_unaligned` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:315:43 [INFO] [stdout] | [INFO] [stdout] 315 | p.write_unaligned(p.read_unaligned() + base as u64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:276:20 [INFO] [stdout] | [INFO] [stdout] 276 | (base, base.offset(l)) [INFO] [stdout] | ^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/peloader.rs:272:5 [INFO] [stdout] | [INFO] [stdout] 272 | unsafe fn apply_relocations(buf: &mut [MaybeUninit], tbl: &PeTable) -> Result<(), ()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:279:25 [INFO] [stdout] | [INFO] [stdout] 279 | let mut reloc = base.offset(tbl.rva as isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:280:25 [INFO] [stdout] | [INFO] [stdout] 280 | let reloc_end = reloc.offset(tbl.size as isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:288:26 [INFO] [stdout] | [INFO] [stdout] 288 | let block = &*(reloc as *const BaseRelocationBlock); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ dereference of raw pointer [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | reloc = reloc.offset(BSIZE as isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::slice::from_raw_parts` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:296:35 [INFO] [stdout] | [INFO] [stdout] 296 | let entries: &[u16] = slice::from_raw_parts(reloc as _, block_len); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:297:21 [INFO] [stdout] | [INFO] [stdout] 297 | reloc = reloc.offset(block_size as isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:304:25 [INFO] [stdout] | [INFO] [stdout] 304 | let p = base.offset(offset as isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::offset` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:305:20 [INFO] [stdout] | [INFO] [stdout] 305 | if p.offset(size_of::() as isize) > limit { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::write_unaligned` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:315:25 [INFO] [stdout] | [INFO] [stdout] 315 | p.write_unaligned(p.read_unaligned() + base as u64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::mut_ptr::::read_unaligned` is unsafe and requires unsafe block [INFO] [stdout] --> src/peloader.rs:315:43 [INFO] [stdout] | [INFO] [stdout] 315 | p.write_unaligned(p.read_unaligned() + base as u64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 21 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 21 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stderr] error: could not compile `efiloader` (lib test) due to 5 previous errors; 21 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `efiloader` (lib) due to 5 previous errors; 21 warnings emitted [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "1159460f1aecd3966a96733c10d22790bd62307448290af030cf1655f16c6001", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1159460f1aecd3966a96733c10d22790bd62307448290af030cf1655f16c6001", kill_on_drop: false }` [INFO] [stdout] 1159460f1aecd3966a96733c10d22790bd62307448290af030cf1655f16c6001