[INFO] fetching crate datafusion-functions-aggregate-common 42.0.0... [INFO] checking datafusion-functions-aggregate-common-42.0.0 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate datafusion-functions-aggregate-common 42.0.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate datafusion-functions-aggregate-common 42.0.0 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate datafusion-functions-aggregate-common 42.0.0 [INFO] finished tweaking crates.io crate datafusion-functions-aggregate-common 42.0.0 [INFO] tweaked toml for crates.io crate datafusion-functions-aggregate-common 42.0.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 137 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding chrono-tz v0.9.0 (available: v0.10.0) [INFO] [stderr] Adding chrono-tz-build v0.3.0 (available: v0.4.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding lexical-core v0.8.5 (available: v1.0.2) [INFO] [stderr] Adding lexical-parse-float v0.8.5 (available: v1.0.2) [INFO] [stderr] Adding lexical-parse-integer v0.8.6 (available: v1.0.2) [INFO] [stderr] Adding lexical-util v0.8.5 (available: v1.0.3) [INFO] [stderr] Adding lexical-write-float v0.8.5 (available: v1.0.2) [INFO] [stderr] Adding lexical-write-integer v0.8.5 (available: v1.0.2) [INFO] [stderr] Adding siphasher v0.3.11 (available: v1.0.1) [INFO] [stderr] Adding sqlparser v0.50.0 (available: v0.51.0) [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (available: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2a164651280ec1ecf4d18a29c8a68057bf00805539616516789e75d589bceb16 [INFO] running `Command { std: "docker" "start" "-a" "2a164651280ec1ecf4d18a29c8a68057bf00805539616516789e75d589bceb16", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2a164651280ec1ecf4d18a29c8a68057bf00805539616516789e75d589bceb16", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2a164651280ec1ecf4d18a29c8a68057bf00805539616516789e75d589bceb16", kill_on_drop: false }` [INFO] [stdout] 2a164651280ec1ecf4d18a29c8a68057bf00805539616516789e75d589bceb16 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b3f688db8abd5d2de3a890a2b97422a6c69d8a9bb4bd31d480ebd8eb3e9118fa [INFO] running `Command { std: "docker" "start" "-a" "b3f688db8abd5d2de3a890a2b97422a6c69d8a9bb4bd31d480ebd8eb3e9118fa", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking iana-time-zone v0.1.61 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking arrow-schema v53.0.0 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking lexical-util v0.8.5 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling serde_json v1.0.128 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling phf v0.11.2 [INFO] [stderr] Compiling sqlparser_derive v0.2.2 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking lexical-parse-integer v0.8.6 [INFO] [stderr] Checking lexical-write-integer v0.8.5 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Checking lexical-write-float v0.8.5 [INFO] [stderr] Checking lexical-parse-float v0.8.5 [INFO] [stderr] Compiling flatbuffers v24.3.25 [INFO] [stderr] Checking sqlparser v0.50.0 [INFO] [stderr] Compiling phf_codegen v0.11.2 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking atoi v2.0.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking lexical-core v0.8.5 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking comfy-table v7.1.1 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking arrow-buffer v53.0.0 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Compiling parse-zoneinfo v0.3.1 [INFO] [stderr] Checking arrow-data v53.0.0 [INFO] [stderr] Compiling chrono-tz-build v0.3.0 [INFO] [stderr] Compiling chrono-tz v0.9.0 [INFO] [stderr] Checking arrow-array v53.0.0 [INFO] [stderr] Checking arrow-select v53.0.0 [INFO] [stderr] Checking arrow-row v53.0.0 [INFO] [stderr] Checking arrow-arith v53.0.0 [INFO] [stderr] Checking arrow-cast v53.0.0 [INFO] [stderr] Checking arrow-ord v53.0.0 [INFO] [stderr] Checking arrow-string v53.0.0 [INFO] [stderr] Checking arrow-json v53.0.0 [INFO] [stderr] Checking arrow-ipc v53.0.0 [INFO] [stderr] Checking arrow-csv v53.0.0 [INFO] [stderr] Checking arrow v53.0.0 [INFO] [stderr] Checking datafusion-common v42.0.0 [INFO] [stderr] Checking datafusion-expr-common v42.0.0 [INFO] [stderr] Checking datafusion-physical-expr-common v42.0.0 [INFO] [stderr] Checking datafusion-functions-aggregate-common v42.0.0 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `datafusion_functions_aggregate_common` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/tdigest.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/tdigest.rs:42:6 [INFO] [stderr] | [INFO] [stderr] 42 | ($value:expr_2021 ) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/tdigest.rs:53:6 [INFO] [stderr] | [INFO] [stderr] 53 | ($value:expr_2021 ) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/aggregate/groups_accumulator/accumulate.rs:558:64 [INFO] [stdout] | [INFO] [stdout] 558 | let values: Vec = (0..num_values).map(|_| rng.gen()).collect(); [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/aggregate/groups_accumulator/accumulate.rs:585:34 [INFO] [stdout] | [INFO] [stdout] 585 | Some(rng.gen()) [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/tdigest.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 42 | ($value:expr ) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 42 | ($value:expr_2021 ) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/tdigest.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | ($value:expr ) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 53 | ($value:expr_2021 ) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/merge_arrays.rs:139:26 [INFO] [stdout] | [INFO] [stdout] 139 | let minimum = if let Some(minimum) = heap.pop() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^---------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/merge_arrays.rs:141:9 [INFO] [stdout] | [INFO] [stdout] 141 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 139 ~ let minimum = match heap.pop() { Some(minimum) => { [INFO] [stdout] 140 | minimum [INFO] [stdout] 141 ~ } _ => { [INFO] [stdout] 142 | // Heap is empty, fill it with the next entries from each branch. [INFO] [stdout] ... [INFO] [stdout] 167 | } [INFO] [stdout] 168 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/merge_arrays.rs:144:20 [INFO] [stdout] | [INFO] [stdout] 144 | if let Some(orderings) = ordering_values[branch_idx].pop_front() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^--------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/merge_arrays.rs:154:17 [INFO] [stdout] | [INFO] [stdout] 154 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 144 ~ match ordering_values[branch_idx].pop_front() { Some(orderings) => { [INFO] [stdout] 145 | // Their size should be same, we can safely .unwrap here. [INFO] [stdout] ... [INFO] [stdout] 153 | )); [INFO] [stdout] 154 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/merge_arrays.rs:160:16 [INFO] [stdout] | [INFO] [stdout] 160 | if let Some(minimum) = heap.pop() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^---------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/merge_arrays.rs:162:13 [INFO] [stdout] | [INFO] [stdout] 162 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 160 ~ match heap.pop() { Some(minimum) => { [INFO] [stdout] 161 | minimum [INFO] [stdout] 162 ~ } _ => { [INFO] [stdout] 163 | // Heap is empty, this means that all indices are same with [INFO] [stdout] ... [INFO] [stdout] 166 | break; [INFO] [stdout] 167 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/merge_arrays.rs:181:12 [INFO] [stdout] | [INFO] [stdout] 181 | if let Some(orderings) = ordering_values[branch_idx].pop_front() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^--------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/merge_arrays.rs:191:9 [INFO] [stdout] | [INFO] [stdout] 191 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 181 ~ match ordering_values[branch_idx].pop_front() { Some(orderings) => { [INFO] [stdout] 182 | // Their size should be same, we can safely .unwrap here. [INFO] [stdout] ... [INFO] [stdout] 190 | )); [INFO] [stdout] 191 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/utils.rs:194:12 [INFO] [stdout] | [INFO] [stdout] 194 | if let Ok(value) = sum.mul_checked(self.target_mul.div_wrapping(self.sum_mul)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^----------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/utils.rs:205:9 [INFO] [stdout] | [INFO] [stdout] 205 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 194 ~ match sum.mul_checked(self.target_mul.div_wrapping(self.sum_mul)) { Ok(value) => { [INFO] [stdout] 195 | let new_value = value.div_wrapping(count); [INFO] [stdout] ... [INFO] [stdout] 204 | } [INFO] [stdout] 205 ~ } _ => { [INFO] [stdout] 206 | // can't convert the lit decimal to the returned data type [INFO] [stdout] 207 | exec_err!("Arithmetic Overflow in AvgAccumulator") [INFO] [stdout] 208 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `datafusion_functions_aggregate_common` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/tdigest.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/tdigest.rs:42:6 [INFO] [stderr] | [INFO] [stderr] 42 | ($value:expr_2021 ) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/tdigest.rs:53:6 [INFO] [stderr] | [INFO] [stderr] 53 | ($value:expr_2021 ) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/aggregate/groups_accumulator/accumulate.rs:558:64 [INFO] [stdout] | [INFO] [stdout] 558 | let values: Vec = (0..num_values).map(|_| rng.gen()).collect(); [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/aggregate/groups_accumulator/accumulate.rs:585:34 [INFO] [stdout] | [INFO] [stdout] 585 | Some(rng.gen()) [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/tdigest.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 42 | ($value:expr ) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 42 | ($value:expr_2021 ) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/tdigest.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | ($value:expr ) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 53 | ($value:expr_2021 ) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/merge_arrays.rs:139:26 [INFO] [stdout] | [INFO] [stdout] 139 | let minimum = if let Some(minimum) = heap.pop() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^---------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/merge_arrays.rs:141:9 [INFO] [stdout] | [INFO] [stdout] 141 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 139 ~ let minimum = match heap.pop() { Some(minimum) => { [INFO] [stdout] 140 | minimum [INFO] [stdout] 141 ~ } _ => { [INFO] [stdout] 142 | // Heap is empty, fill it with the next entries from each branch. [INFO] [stdout] ... [INFO] [stdout] 167 | } [INFO] [stdout] 168 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/merge_arrays.rs:144:20 [INFO] [stdout] | [INFO] [stdout] 144 | if let Some(orderings) = ordering_values[branch_idx].pop_front() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^--------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/merge_arrays.rs:154:17 [INFO] [stdout] | [INFO] [stdout] 154 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 144 ~ match ordering_values[branch_idx].pop_front() { Some(orderings) => { [INFO] [stdout] 145 | // Their size should be same, we can safely .unwrap here. [INFO] [stdout] ... [INFO] [stdout] 153 | )); [INFO] [stdout] 154 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/merge_arrays.rs:160:16 [INFO] [stdout] | [INFO] [stdout] 160 | if let Some(minimum) = heap.pop() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^---------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/merge_arrays.rs:162:13 [INFO] [stdout] | [INFO] [stdout] 162 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 160 ~ match heap.pop() { Some(minimum) => { [INFO] [stdout] 161 | minimum [INFO] [stdout] 162 ~ } _ => { [INFO] [stdout] 163 | // Heap is empty, this means that all indices are same with [INFO] [stdout] ... [INFO] [stdout] 166 | break; [INFO] [stdout] 167 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/merge_arrays.rs:181:12 [INFO] [stdout] | [INFO] [stdout] 181 | if let Some(orderings) = ordering_values[branch_idx].pop_front() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^--------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/merge_arrays.rs:191:9 [INFO] [stdout] | [INFO] [stdout] 191 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 181 ~ match ordering_values[branch_idx].pop_front() { Some(orderings) => { [INFO] [stdout] 182 | // Their size should be same, we can safely .unwrap here. [INFO] [stdout] ... [INFO] [stdout] 190 | )); [INFO] [stdout] 191 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/utils.rs:194:12 [INFO] [stdout] | [INFO] [stdout] 194 | if let Ok(value) = sum.mul_checked(self.target_mul.div_wrapping(self.sum_mul)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^----------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/utils.rs:205:9 [INFO] [stdout] | [INFO] [stdout] 205 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 194 ~ match sum.mul_checked(self.target_mul.div_wrapping(self.sum_mul)) { Ok(value) => { [INFO] [stdout] 195 | let new_value = value.div_wrapping(count); [INFO] [stdout] ... [INFO] [stdout] 204 | } [INFO] [stdout] 205 ~ } _ => { [INFO] [stdout] 206 | // can't convert the lit decimal to the returned data type [INFO] [stdout] 207 | exec_err!("Arithmetic Overflow in AvgAccumulator") [INFO] [stdout] 208 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 13.16s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking datafusion-functions-aggregate-common v42.0.0 (/tmp/fixit) [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/aggregate/groups_accumulator/accumulate.rs:558:64 [INFO] [stdout] | [INFO] [stdout] 558 | let values: Vec = (0..num_values).map(|_| rng.gen()).collect(); [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 558 | let values: Vec = (0..num_values).map(|_| rng.r#gen()).collect(); [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/aggregate/groups_accumulator/accumulate.rs:558:64 [INFO] [stdout] | [INFO] [stdout] 558 | let values: Vec = (0..num_values).map(|_| rng.gen()).collect(); [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 558 | let values: Vec = (0..num_values).map(|_| rng.r#gen()).collect(); [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/aggregate/groups_accumulator/accumulate.rs:585:34 [INFO] [stdout] | [INFO] [stdout] 585 | Some(rng.gen()) [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 585 | Some(rng.r#gen()) [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/aggregate/groups_accumulator/accumulate.rs:585:34 [INFO] [stdout] | [INFO] [stdout] 585 | Some(rng.gen()) [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 585 | Some(rng.r#gen()) [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `datafusion-functions-aggregate-common` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `datafusion-functions-aggregate-common` (lib test) due to 3 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "b3f688db8abd5d2de3a890a2b97422a6c69d8a9bb4bd31d480ebd8eb3e9118fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b3f688db8abd5d2de3a890a2b97422a6c69d8a9bb4bd31d480ebd8eb3e9118fa", kill_on_drop: false }` [INFO] [stdout] b3f688db8abd5d2de3a890a2b97422a6c69d8a9bb4bd31d480ebd8eb3e9118fa