[INFO] fetching crate cruzbit 1.0.1... [INFO] checking cruzbit-1.0.1 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate cruzbit 1.0.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate cruzbit 1.0.1 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cruzbit 1.0.1 [INFO] finished tweaking crates.io crate cruzbit 1.0.1 [INFO] tweaked toml for crates.io crate cruzbit 1.0.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate cruzbit 1.0.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 44ab0e284ae9b63a72dcf3b4728edf5c71d5736711e31de91365809113e7d4b3 [INFO] running `Command { std: "docker" "start" "-a" "44ab0e284ae9b63a72dcf3b4728edf5c71d5736711e31de91365809113e7d4b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "44ab0e284ae9b63a72dcf3b4728edf5c71d5736711e31de91365809113e7d4b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "44ab0e284ae9b63a72dcf3b4728edf5c71d5736711e31de91365809113e7d4b3", kill_on_drop: false }` [INFO] [stdout] 44ab0e284ae9b63a72dcf3b4728edf5c71d5736711e31de91365809113e7d4b3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ed0896cf17b8be6e8372b28f42c381bf593f29b298bb43a2e288da2ea43d58a7 [INFO] running `Command { std: "docker" "start" "-a" "ed0896cf17b8be6e8372b28f42c381bf593f29b298bb43a2e288da2ea43d58a7", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Compiling proc-macro2 v1.0.76 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Checking encoding_index_tests v0.1.4 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking rustls-pki-types v1.1.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Compiling serde v1.0.195 [INFO] [stderr] Checking unicode-bidi v0.3.14 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling rustls v0.22.2 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Compiling rustix v0.38.28 [INFO] [stderr] Checking encoding-index-singlebyte v1.20141219.5 [INFO] [stderr] Checking encoding-index-tradchinese v1.20141219.5 [INFO] [stderr] Checking encoding-index-japanese v1.20141219.5 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking encoding-index-korean v1.20141219.5 [INFO] [stderr] Checking encoding-index-simpchinese v1.20141219.5 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking base64 v0.21.5 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Checking smallvec v1.11.2 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking encoding v0.2.33 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking http v0.2.11 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking http v1.0.0 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking wildmatch v1.1.0 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking time v0.3.31 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot_core v0.8.6 [INFO] [stderr] Checking iana-time-zone v0.1.59 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Compiling network-interface v1.1.1 [INFO] [stderr] Checking xml-rs v0.8.19 [INFO] [stderr] Checking data-encoding v2.5.0 [INFO] [stderr] Compiling serde_json v1.0.111 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking ffi-opaque v2.0.1 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking salsa20 v0.10.2 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Compiling cmake v0.1.50 [INFO] [stderr] Checking yasna v0.5.2 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Checking console v0.15.7 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking password-hash v0.5.0 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking pem v3.0.3 [INFO] [stderr] Checking xmltree v0.10.3 [INFO] [stderr] Checking webpki-roots v0.26.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking keccak v0.1.4 [INFO] [stderr] Checking ct-codecs v1.1.1 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking octseq v0.3.2 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking ed25519-compact v2.0.6 [INFO] [stderr] Checking argon2 v0.5.2 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Checking crypto_secretbox v0.1.1 [INFO] [stderr] Checking env_logger v0.10.1 [INFO] [stderr] Checking ibig v0.3.6 [INFO] [stderr] Checking domain v0.9.3 [INFO] [stderr] Checking rustls-pemfile v2.0.0 [INFO] [stderr] Checking cuckoofilter v0.5.0 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking attohttpc v0.16.3 [INFO] [stderr] Compiling ring v0.17.7 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Compiling lz4-sys v1.9.4 [INFO] [stderr] Compiling cruzbit-leveldb-sys v1.0.0 [INFO] [stderr] Compiling cruzbit v1.0.1 (/tmp/fixit) [INFO] [stderr] Migrating build.rs from 2021 edition to 2024 [INFO] [stderr] Checking tempfile v3.9.0 [INFO] [stderr] Checking igd v0.12.1 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Compiling darling_core v0.20.3 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Compiling serde_derive v1.0.195 [INFO] [stderr] Compiling pin-project-internal v1.1.3 [INFO] [stderr] Checking tokio v1.35.1 [INFO] [stderr] Checking pin-project v1.1.3 [INFO] [stderr] Checking webpki v0.21.4 [INFO] [stderr] Checking sct v0.6.1 [INFO] [stderr] Checking dialoguer v0.11.0 [INFO] [stderr] Checking rustls v0.19.1 [INFO] [stderr] Checking webpki-roots v0.20.0 [INFO] [stderr] Compiling darling_macro v0.20.3 [INFO] [stderr] Checking rustls-webpki v0.102.1 [INFO] [stderr] Checking rcgen v0.12.0 [INFO] [stderr] Compiling darling v0.20.3 [INFO] [stderr] Compiling serde_with_macros v3.4.0 [INFO] [stderr] Checking tungstenite v0.21.0 [INFO] [stderr] Checking tokio-util v0.6.10 [INFO] [stderr] Checking tokio-rustls v0.25.0 [INFO] [stderr] Checking tokio-rustls v0.22.0 [INFO] [stderr] Checking tokio-stream v0.1.14 [INFO] [stderr] Checking tokio-tungstenite v0.21.0 [INFO] [stderr] Checking irc-proto v0.15.0 [INFO] [stderr] Checking irc v0.15.0 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking serde_with v3.4.0 [INFO] [stderr] Checking faster-hex v0.9.0 [INFO] [stderr] Checking cruzbit-leveldb v1.0.0 [INFO] [stderr] Checking lz4 v1.24.0 [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `cruzbit` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/error.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/error.rs:27:16 [INFO] [stderr] | [INFO] [stderr] 27 | ($t:ident, $type:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/irc.rs:157:41 [INFO] [stdout] | [INFO] [stdout] 157 | let nick_bytes = rand::thread_rng().gen::<[u8; 6]>(); [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/error.rs:27:22 [INFO] [stdout] | [INFO] [stdout] 27 | ($t:ident, $type:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 27 | ($t:ident, $type:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/irc.rs:138:28 [INFO] [stdout] | [INFO] [stdout] 138 | if let Err(err) = self [INFO] [stdout] | ____________________________^ - [INFO] [stdout] | |___________________________________________| [INFO] [stdout] 139 | || .addr_chan_tx [INFO] [stdout] 140 | || .send(addr_str) [INFO] [stdout] 141 | || .await [INFO] [stdout] 142 | || .map_err(IrcError::from) [INFO] [stdout] | ||____________________________________________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |____________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/irc.rs:145:25 [INFO] [stdout] | [INFO] [stdout] 145 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 138 ~ match self [INFO] [stdout] 139 | .addr_chan_tx [INFO] [stdout] ... [INFO] [stdout] 142 | .map_err(IrcError::from) [INFO] [stdout] 143 ~ { Err(err) => { [INFO] [stdout] 144 | error!("{:?}", err); [INFO] [stdout] 145 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/miner.rs:256:20 [INFO] [stdout] | [INFO] [stdout] 256 | if let Err(err) = [INFO] [stdout] | ____________________^ [INFO] [stdout] 257 | | block_new_tx.add_transaction(new_tx.transaction_id, new_tx.transaction) [INFO] [stdout] | |_____________________----------------------------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/miner.rs:265:17 [INFO] [stdout] | [INFO] [stdout] 265 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 256 ~ match block_new_tx.add_transaction(new_tx.transaction_id, new_tx.transaction) [INFO] [stdout] 257 ~ { Err(err) => { [INFO] [stdout] 258 | info!( [INFO] [stdout] ... [INFO] [stdout] 263 | block = None; [INFO] [stdout] 264 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/miner.rs:329:24 [INFO] [stdout] | [INFO] [stdout] 329 | if let Err(err) = self [INFO] [stdout] | ________________________^ - [INFO] [stdout] | |_______________________________________| [INFO] [stdout] 330 | || .processor [INFO] [stdout] 331 | || .process_candidate_block(id, candidate_block, PEER_ADDR_SELF) [INFO] [stdout] 332 | || .await [INFO] [stdout] 333 | || .map_err(MinerError::ProcessBlock) [INFO] [stdout] | ||__________________________________________________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |__________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/miner.rs:336:21 [INFO] [stdout] | [INFO] [stdout] 336 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 329 ~ match self [INFO] [stdout] 330 | .processor [INFO] [stdout] ... [INFO] [stdout] 333 | .map_err(MinerError::ProcessBlock) [INFO] [stdout] 334 ~ { Err(err) => { [INFO] [stdout] 335 | error!("{:?}", err); [INFO] [stdout] 336 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:261:23 [INFO] [stdout] | [INFO] [stdout] 261 | while let Some(block_in_flight) = local_inflight_queue.peek() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------------------^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:264:17 [INFO] [stdout] | [INFO] [stdout] 264 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:275:16 [INFO] [stdout] | [INFO] [stdout] 275 | if let Err(_err) = on_connect_chan_tx.send(true).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:277:13 [INFO] [stdout] | [INFO] [stdout] 277 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 275 ~ match on_connect_chan_tx.send(true).await { Err(_err) => { [INFO] [stdout] 276 | error!("failed to send on-connect, peer must have shut down"); [INFO] [stdout] 277 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:327:20 [INFO] [stdout] | [INFO] [stdout] 327 | if let Err(err) = peer_store [INFO] [stdout] | ____________________^ - [INFO] [stdout] | |___________________________________| [INFO] [stdout] 328 | || .on_disconnect(self.addr) [INFO] [stdout] 329 | || .map_err(PeerError::PeerStorage) [INFO] [stdout] | ||____________________________________________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |____________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:332:17 [INFO] [stdout] | [INFO] [stdout] 332 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 327 ~ match peer_store [INFO] [stdout] 328 | .on_disconnect(self.addr) [INFO] [stdout] 329 | .map_err(PeerError::PeerStorage) [INFO] [stdout] 330 ~ { Err(err) => { [INFO] [stdout] 331 | error!("{:?}", err); [INFO] [stdout] 332 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:385:40 [INFO] [stdout] | [INFO] [stdout] 385 | ... if let Some(block) = b.block { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^-^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:393:37 [INFO] [stdout] | [INFO] [stdout] 393 | ... } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 385 ~ match b.block { Some(block) => { [INFO] [stdout] 386 | if let Err(err) = self.on_block(block, ibd, &out_chan_tx).await { [INFO] [stdout] ... [INFO] [stdout] 392 | } [INFO] [stdout] 393 ~ } _ => { [INFO] [stdout] 394 | break Err(PeerError::EmptyBlockReceived(self.addr)) [INFO] [stdout] 395 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:386:44 [INFO] [stdout] | [INFO] [stdout] 386 | ... if let Err(err) = self.on_block(block, ibd, &out_chan_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^--------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:390:41 [INFO] [stdout] | [INFO] [stdout] 390 | ... } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 386 ~ match self.on_block(block, ibd, &out_chan_tx).await { Err(err) => { [INFO] [stdout] 387 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 388 | continue [INFO] [stdout] 389 | [INFO] [stdout] 390 ~ } _ => { [INFO] [stdout] 391 | last_new_block_time = Instant::now(); [INFO] [stdout] 392 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:399:40 [INFO] [stdout] | [INFO] [stdout] 399 | ... if let Err(err) = self.on_filter_add(fa.public_keys, &out_chan_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:402:37 [INFO] [stdout] | [INFO] [stdout] 402 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 399 ~ match self.on_filter_add(fa.public_keys, &out_chan_tx).await { Err(err) => { [INFO] [stdout] 400 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 401 | continue [INFO] [stdout] 402 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:406:40 [INFO] [stdout] | [INFO] [stdout] 406 | ... if let Err(err) = self.on_filter_load(fl.r#type, fl.filter, &out_chan_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:409:37 [INFO] [stdout] | [INFO] [stdout] 409 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 406 ~ match self.on_filter_load(fl.r#type, fl.filter, &out_chan_tx).await { Err(err) => { [INFO] [stdout] 407 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 408 | continue [INFO] [stdout] 409 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:434:40 [INFO] [stdout] | [INFO] [stdout] 434 | ... if let Err(err) = self.on_get_balance(gb.public_key, &out_chan_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:438:37 [INFO] [stdout] | [INFO] [stdout] 438 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 434 ~ match self.on_get_balance(gb.public_key, &out_chan_tx).await { Err(err) => { [INFO] [stdout] 435 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 436 | continue; [INFO] [stdout] 437 | [INFO] [stdout] 438 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:442:40 [INFO] [stdout] | [INFO] [stdout] 442 | ... if let Err(err) = self.on_get_balances(gb.public_keys, &out_chan_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^-------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:445:37 [INFO] [stdout] | [INFO] [stdout] 445 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 442 ~ match self.on_get_balances(gb.public_keys, &out_chan_tx).await { Err(err) => { [INFO] [stdout] 443 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 444 | continue [INFO] [stdout] 445 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:449:40 [INFO] [stdout] | [INFO] [stdout] 449 | ... if let Err(err) = self.on_get_block(gb.block_id, &out_chan_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^-------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:452:37 [INFO] [stdout] | [INFO] [stdout] 452 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 449 ~ match self.on_get_block(gb.block_id, &out_chan_tx).await { Err(err) => { [INFO] [stdout] 450 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 451 | continue [INFO] [stdout] 452 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:456:40 [INFO] [stdout] | [INFO] [stdout] 456 | ... if let Err(err) = self.on_get_block_by_height(gbbh.height, &out_chan_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------------------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:459:37 [INFO] [stdout] | [INFO] [stdout] 459 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 456 ~ match self.on_get_block_by_height(gbbh.height, &out_chan_tx).await { Err(err) => { [INFO] [stdout] 457 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 458 | continue [INFO] [stdout] 459 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:463:40 [INFO] [stdout] | [INFO] [stdout] 463 | ... if let Err(err) = self.on_get_block_header(gbh.block_id, &out_chan_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^---------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:466:37 [INFO] [stdout] | [INFO] [stdout] 466 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 463 ~ match self.on_get_block_header(gbh.block_id, &out_chan_tx).await { Err(err) => { [INFO] [stdout] 464 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 465 | continue [INFO] [stdout] 466 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:470:40 [INFO] [stdout] | [INFO] [stdout] 470 | ... if let Err(err) = self [INFO] [stdout] | __________________________^ - [INFO] [stdout] | |_________________________________________| [INFO] [stdout] 471 | || ... .on_get_block_header_by_height(gbhbh.height, &out_chan_tx).await { [INFO] [stdout] | ||__________________________________________________________________________________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |__________________________________________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:474:41 [INFO] [stdout] | [INFO] [stdout] 474 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 470 ~ match self [INFO] [stdout] 471 ~ .on_get_block_header_by_height(gbhbh.height, &out_chan_tx).await { Err(err) => { [INFO] [stdout] 472 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 473 | continue [INFO] [stdout] 474 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:478:40 [INFO] [stdout] | [INFO] [stdout] 478 | ... if let Err(err) = self.on_get_filter_transaction_queue(&out_chan_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^-------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:481:37 [INFO] [stdout] | [INFO] [stdout] 481 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 478 ~ match self.on_get_filter_transaction_queue(&out_chan_tx).await { Err(err) => { [INFO] [stdout] 479 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 480 | continue [INFO] [stdout] 481 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:485:40 [INFO] [stdout] | [INFO] [stdout] 485 | ... if let Err(err) = self.on_get_peer_addresses(&out_chan_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^---------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:488:37 [INFO] [stdout] | [INFO] [stdout] 488 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 485 ~ match self.on_get_peer_addresses(&out_chan_tx).await { Err(err) => { [INFO] [stdout] 486 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 487 | continue [INFO] [stdout] 488 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:492:40 [INFO] [stdout] | [INFO] [stdout] 492 | ... if let Err(err) = self [INFO] [stdout] | __________________________^ - [INFO] [stdout] | |_________________________________________| [INFO] [stdout] 493 | || ... .on_get_public_key_transactions( [INFO] [stdout] 494 | || ... gpkt.public_key, [INFO] [stdout] 495 | || ... gpkt.start_height, [INFO] [stdout] ... || [INFO] [stdout] 499 | || ... &out_chan_tx [INFO] [stdout] 500 | || ... ).await { [INFO] [stdout] | ||_________________________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |_________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:503:41 [INFO] [stdout] | [INFO] [stdout] 503 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 492 ~ match self [INFO] [stdout] 493 | .on_get_public_key_transactions( [INFO] [stdout] ... [INFO] [stdout] 499 | &out_chan_tx [INFO] [stdout] 500 ~ ).await { Err(err) => { [INFO] [stdout] 501 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 502 | continue [INFO] [stdout] 503 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:507:40 [INFO] [stdout] | [INFO] [stdout] 507 | ... if let Err(err) = self.on_get_tip_header(&out_chan_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:510:37 [INFO] [stdout] | [INFO] [stdout] 510 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 507 ~ match self.on_get_tip_header(&out_chan_tx).await { Err(err) => { [INFO] [stdout] 508 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 509 | continue [INFO] [stdout] 510 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:514:40 [INFO] [stdout] | [INFO] [stdout] 514 | ... if let Err(err) = self.on_get_transaction(gt.transaction_id, &out_chan_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^-------------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:517:37 [INFO] [stdout] | [INFO] [stdout] 517 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 514 ~ match self.on_get_transaction(gt.transaction_id, &out_chan_tx).await { Err(err) => { [INFO] [stdout] 515 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 516 | continue [INFO] [stdout] 517 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:542:44 [INFO] [stdout] | [INFO] [stdout] 542 | ... if let Err(err) = self.on_inv_block(id, i, block_ids_len, &out_chan_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^----------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:545:41 [INFO] [stdout] | [INFO] [stdout] 545 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 542 ~ match self.on_inv_block(id, i, block_ids_len, &out_chan_tx).await { Err(err) => { [INFO] [stdout] 543 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 544 | continue [INFO] [stdout] 545 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:550:40 [INFO] [stdout] | [INFO] [stdout] 550 | ... if let Err(err) = self.on_peer_addresses(pa.addresses).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:553:37 [INFO] [stdout] | [INFO] [stdout] 553 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 550 ~ match self.on_peer_addresses(pa.addresses).await { Err(err) => { [INFO] [stdout] 551 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 552 | continue [INFO] [stdout] 553 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:557:40 [INFO] [stdout] | [INFO] [stdout] 557 | ... if let Err(err) = self.on_push_transaction(pt.transaction, &out_chan_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------------------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:560:37 [INFO] [stdout] | [INFO] [stdout] 560 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 557 ~ match self.on_push_transaction(pt.transaction, &out_chan_tx).await { Err(err) => { [INFO] [stdout] 558 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 559 | continue [INFO] [stdout] 560 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:699:24 [INFO] [stdout] | [INFO] [stdout] 699 | if let Err(err) = self.on_get_work(gw, &out_chan_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^---------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:701:21 [INFO] [stdout] | [INFO] [stdout] 701 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 699 ~ match self.on_get_work(gw, &out_chan_tx).await { Err(err) => { [INFO] [stdout] 700 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 701 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:705:24 [INFO] [stdout] | [INFO] [stdout] 705 | if let Err(err) = self.on_submit_work(sw, &out_chan_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:707:21 [INFO] [stdout] | [INFO] [stdout] 707 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 705 ~ match self.on_submit_work(sw, &out_chan_tx).await { Err(err) => { [INFO] [stdout] 706 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 707 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:716:24 [INFO] [stdout] | [INFO] [stdout] 716 | if let Err(err) = self.peer_store.on_connect_success(self.addr).map_err(PeerError::PeerStorage) { [INFO] [stdout] | ^^^^^^^^^^^^^^^----------------------------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:718:21 [INFO] [stdout] | [INFO] [stdout] 718 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 716 ~ match self.peer_store.on_connect_success(self.addr).map_err(PeerError::PeerStorage) { Err(err) => { [INFO] [stdout] 717 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 718 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:1623:16 [INFO] [stdout] | [INFO] [stdout] 1623 | if let Err(err) = self [INFO] [stdout] | ________________^ - [INFO] [stdout] | |_______________________________| [INFO] [stdout] 1624 | || .processor [INFO] [stdout] 1625 | || .process_candidate_transaction(&id, &tx, &self.addr) [INFO] [stdout] 1626 | || .await [INFO] [stdout] | ||______________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |______________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:1629:13 [INFO] [stdout] | [INFO] [stdout] 1629 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 1623 ~ match self [INFO] [stdout] 1624 | .processor [INFO] [stdout] 1625 | .process_candidate_transaction(&id, &tx, &self.addr) [INFO] [stdout] 1626 | .await [INFO] [stdout] 1627 ~ { Err(err) => { [INFO] [stdout] 1628 | err_str = Some(format!("{:?}", err)); [INFO] [stdout] 1629 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:2013:26 [INFO] [stdout] | [INFO] [stdout] 2013 | let message = if let Err(ref err) = block_id { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^-------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:2018:9 [INFO] [stdout] | [INFO] [stdout] 2018 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 2013 ~ let message = match block_id { Err(ref err) => { [INFO] [stdout] 2014 | Message::SubmitWorkResult(SubmitWorkResultMessage { [INFO] [stdout] ... [INFO] [stdout] 2017 | }) [INFO] [stdout] 2018 ~ } _ => { [INFO] [stdout] 2019 | Message::SubmitWorkResult(SubmitWorkResultMessage { [INFO] [stdout] ... [INFO] [stdout] 2022 | }) [INFO] [stdout] 2023 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:2026:12 [INFO] [stdout] | [INFO] [stdout] 2026 | if let Err(err) = block_id { [INFO] [stdout] | ^^^^^^^^^^^^^^^-------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:2028:9 [INFO] [stdout] | [INFO] [stdout] 2028 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 2026 ~ match block_id { Err(err) => { [INFO] [stdout] 2027 | Err(err.into()) [INFO] [stdout] 2028 ~ } _ => { [INFO] [stdout] 2029 | Ok(()) [INFO] [stdout] 2030 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer_manager.rs:252:32 [INFO] [stdout] | [INFO] [stdout] 252 | ... if let Err(err) = self.connect_to_peers().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^----------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer_manager.rs:255:29 [INFO] [stdout] | [INFO] [stdout] 255 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 252 ~ match self.connect_to_peers().await { Err(err) => { [INFO] [stdout] 253 | error!("{:?}", err); [INFO] [stdout] 254 | continue [INFO] [stdout] 255 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer_manager.rs:280:24 [INFO] [stdout] | [INFO] [stdout] 280 | if let Err(err) = self.connect_to_peers().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^----------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer_manager.rs:282:21 [INFO] [stdout] | [INFO] [stdout] 282 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 280 ~ match self.connect_to_peers().await { Err(err) => { [INFO] [stdout] 281 | error!("{:?}", err); [INFO] [stdout] 282 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer_manager.rs:533:24 [INFO] [stdout] | [INFO] [stdout] 533 | if let Some(shutdown) = out_peer { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^-------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer_manager.rs:535:21 [INFO] [stdout] | [INFO] [stdout] 535 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 533 ~ match out_peer { Some(shutdown) => { [INFO] [stdout] 534 | shutdown.send().await; [INFO] [stdout] 535 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer_manager.rs:639:12 [INFO] [stdout] | [INFO] [stdout] 639 | if let Some(_shutdown) = out_peers.remove(addr) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer_manager.rs:641:9 [INFO] [stdout] | [INFO] [stdout] 641 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 639 ~ match out_peers.remove(addr) { Some(_shutdown) => { [INFO] [stdout] 640 | info!("Outbound peer count: {}", out_peers.len()); [INFO] [stdout] 641 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer_manager.rs:671:12 [INFO] [stdout] | [INFO] [stdout] 671 | if let Some((addr, shutdown)) = out_peer { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer_manager.rs:674:9 [INFO] [stdout] | [INFO] [stdout] 674 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 671 ~ match out_peer { Some((addr, shutdown)) => { [INFO] [stdout] 672 | info!("Dropping random peer: {}", addr); [INFO] [stdout] 673 | shutdown.send().await; [INFO] [stdout] 674 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer_manager.rs:808:24 [INFO] [stdout] | [INFO] [stdout] 808 | if let Ok(tls_stream) = TlsAcceptor::from(server_config).accept(stream).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^----------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer_manager.rs:813:21 [INFO] [stdout] | [INFO] [stdout] 813 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 808 ~ match TlsAcceptor::from(server_config).accept(stream).await { Ok(tls_stream) => { [INFO] [stdout] 809 | if let Err(err) = self.handle_connection(tls_stream, remote_addr).await { [INFO] [stdout] ... [INFO] [stdout] 812 | } [INFO] [stdout] 813 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer_manager.rs:809:28 [INFO] [stdout] | [INFO] [stdout] 809 | if let Err(err) = self.handle_connection(tls_stream, remote_addr).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^----------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer_manager.rs:812:25 [INFO] [stdout] | [INFO] [stdout] 812 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 809 ~ match self.handle_connection(tls_stream, remote_addr).await { Err(err) => { [INFO] [stdout] 810 | error!("{:?}", err); [INFO] [stdout] 811 | continue; [INFO] [stdout] 812 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer_manager.rs:927:24 [INFO] [stdout] | [INFO] [stdout] 927 | if let Err(err) = self.peer_manager.peer_store.store(addr) { [INFO] [stdout] | ^^^^^^^^^^^^^^^---------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer_manager.rs:929:21 [INFO] [stdout] | [INFO] [stdout] 929 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 927 ~ match self.peer_manager.peer_store.store(addr) { Err(err) => { [INFO] [stdout] 928 | info!("Error saving peer: {}, address: {}", err, &addr); [INFO] [stdout] 929 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/processor.rs:237:24 [INFO] [stdout] | [INFO] [stdout] 237 | if let Err(err) = tx_to_process.result_chan.send(result).map_err(ProcessTransactionError::from) { [INFO] [stdout] | ^^^^^^^^^^^^^^^----------------------------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/processor.rs:239:21 [INFO] [stdout] | [INFO] [stdout] 239 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 237 ~ match tx_to_process.result_chan.send(result).map_err(ProcessTransactionError::from) { Err(err) => { [INFO] [stdout] 238 | error!("{:?}", err); [INFO] [stdout] 239 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/processor.rs:263:24 [INFO] [stdout] | [INFO] [stdout] 263 | if let Err(err) = block_to_process.result_chan.send(result).map_err(ProcessBlockError::from) { [INFO] [stdout] | ^^^^^^^^^^^^^^^-------------------------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/processor.rs:265:21 [INFO] [stdout] | [INFO] [stdout] 265 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 263 ~ match block_to_process.result_chan.send(result).map_err(ProcessBlockError::from) { Err(err) => { [INFO] [stdout] 264 | error!("{:?}", err); [INFO] [stdout] 265 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/processor.rs:275:24 [INFO] [stdout] | [INFO] [stdout] 275 | if let Some(index) = new_tx_channels [INFO] [stdout] | ^ --------------- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | ________________________| [INFO] [stdout] | | [INFO] [stdout] 276 | | .iter() [INFO] [stdout] 277 | | .position(|c| c.same_channel(&ch)) { [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/processor.rs:279:25 [INFO] [stdout] | [INFO] [stdout] 279 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 275 ~ match new_tx_channels [INFO] [stdout] 276 | .iter() [INFO] [stdout] 277 ~ .position(|c| c.same_channel(&ch)) { Some(index) => { [INFO] [stdout] 278 | new_tx_channels.remove(index); [INFO] [stdout] 279 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/processor.rs:291:24 [INFO] [stdout] | [INFO] [stdout] 291 | if let Some(index) = tip_change_channels [INFO] [stdout] | ^ ------------------- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | ________________________| [INFO] [stdout] | | [INFO] [stdout] 292 | | .iter() [INFO] [stdout] 293 | | .position(|c| c.same_channel(&ch)) { [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/processor.rs:295:25 [INFO] [stdout] | [INFO] [stdout] 295 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 291 ~ match tip_change_channels [INFO] [stdout] 292 | .iter() [INFO] [stdout] 293 ~ .position(|c| c.same_channel(&ch)) { Some(index) => { [INFO] [stdout] 294 | tip_change_channels.remove(index); [INFO] [stdout] 295 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/processor.rs:458:16 [INFO] [stdout] | [INFO] [stdout] 458 | if let Err(err) = new_tx [INFO] [stdout] | ________________^ - [INFO] [stdout] | |_______________________________| [INFO] [stdout] 459 | || .send(NewTx { [INFO] [stdout] 460 | || transaction_id: id, [INFO] [stdout] 461 | || transaction: tx.clone(), [INFO] [stdout] ... || [INFO] [stdout] 464 | || .await [INFO] [stdout] 465 | || .map_err(ProcessTransactionError::from) [INFO] [stdout] | ||_______________________________________________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |_______________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/processor.rs:468:13 [INFO] [stdout] | [INFO] [stdout] 468 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 458 ~ match new_tx [INFO] [stdout] 459 | .send(NewTx { [INFO] [stdout] ... [INFO] [stdout] 465 | .map_err(ProcessTransactionError::from) [INFO] [stdout] 466 ~ { Err(err) => { [INFO] [stdout] 467 | error!("{:?}", err) [INFO] [stdout] 468 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/processor.rs:1200:16 [INFO] [stdout] | [INFO] [stdout] 1200 | if let Err(err) = tip_tx [INFO] [stdout] | ________________^ - [INFO] [stdout] | |_______________________________| [INFO] [stdout] 1201 | || .send(TipChange { [INFO] [stdout] 1202 | || block_id: *id, [INFO] [stdout] 1203 | || block: block.clone(), [INFO] [stdout] ... || [INFO] [stdout] 1207 | || }) [INFO] [stdout] 1208 | || .map_err(ProcessorError::from) [INFO] [stdout] | ||______________________________________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |______________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/processor.rs:1211:13 [INFO] [stdout] | [INFO] [stdout] 1211 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 1200 ~ match tip_tx [INFO] [stdout] 1201 | .send(TipChange { [INFO] [stdout] ... [INFO] [stdout] 1208 | .map_err(ProcessorError::from) [INFO] [stdout] 1209 ~ { Err(err) => { [INFO] [stdout] 1210 | error!("{:?}", err); [INFO] [stdout] 1211 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/processor.rs:1240:16 [INFO] [stdout] | [INFO] [stdout] 1240 | if let Err(err) = tip_tx [INFO] [stdout] | ________________^ - [INFO] [stdout] | |_______________________________| [INFO] [stdout] 1241 | || .send(TipChange { [INFO] [stdout] 1242 | || block_id: *id, [INFO] [stdout] 1243 | || block: block.clone(), [INFO] [stdout] ... || [INFO] [stdout] 1247 | || }) [INFO] [stdout] 1248 | || .map_err(ProcessBlockError::from) [INFO] [stdout] | ||_________________________________________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |_________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/processor.rs:1251:13 [INFO] [stdout] | [INFO] [stdout] 1251 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 1240 ~ match tip_tx [INFO] [stdout] 1241 | .send(TipChange { [INFO] [stdout] ... [INFO] [stdout] 1248 | .map_err(ProcessBlockError::from) [INFO] [stdout] 1249 ~ { Err(err) => { [INFO] [stdout] 1250 | error!("{:?}", err); [INFO] [stdout] 1251 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/shutdown.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 38 | if let Err(err) = self.monitor_handle.await { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/shutdown.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 38 ~ match self.monitor_handle.await { Err(err) => { [INFO] [stdout] 39 | error!("{:?}", ShutdownError::Join(err)); [INFO] [stdout] 40 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/transaction_queue_memory.rs:136:20 [INFO] [stdout] | [INFO] [stdout] 136 | if let Some(index) = tx_queue [INFO] [stdout] | ^ -------- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | ____________________| [INFO] [stdout] | | [INFO] [stdout] 137 | | .iter() [INFO] [stdout] 138 | | .position(|queue_tx_id| *queue_tx_id == tx_id) [INFO] [stdout] | |__________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/transaction_queue_memory.rs:142:17 [INFO] [stdout] | [INFO] [stdout] 142 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 136 ~ match tx_queue [INFO] [stdout] 137 | .iter() [INFO] [stdout] 138 | .position(|queue_tx_id| *queue_tx_id == tx_id) [INFO] [stdout] 139 ~ { Some(index) => { [INFO] [stdout] 140 | // remove it from its current position [INFO] [stdout] 141 | tx_queue.remove(index); [INFO] [stdout] 142 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/transaction_queue_memory.rs:188:12 [INFO] [stdout] | [INFO] [stdout] 188 | if let Some(tx) = self.tx_map.read().unwrap().get(id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^---------------------------^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/transaction_queue_memory.rs:190:9 [INFO] [stdout] | [INFO] [stdout] 190 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 188 ~ match self.tx_map.read().unwrap().get(id) { Some(tx) => { [INFO] [stdout] 189 | tx.signature.expect("transaction should have a signature") == signature [INFO] [stdout] 190 ~ } _ => { [INFO] [stdout] 191 | false [INFO] [stdout] 192 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/wallet.rs:161:16 [INFO] [stdout] | [INFO] [stdout] 161 | if let Err(err) = inner.filter.add(&pub_key[..]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/wallet.rs:164:13 [INFO] [stdout] | [INFO] [stdout] 164 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 161 ~ match inner.filter.add(&pub_key[..]) { Err(err) => { [INFO] [stdout] 162 | let err = WalletError::FilterInsertFailed(err); [INFO] [stdout] 163 | error!("{:?}", err); [INFO] [stdout] 164 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/wallet.rs:563:12 [INFO] [stdout] | [INFO] [stdout] 563 | if let Some(transaction_callback) = self.inner().transaction_callback.as_ref() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------------------------^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/wallet.rs:565:9 [INFO] [stdout] | [INFO] [stdout] 565 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 563 ~ match self.inner().transaction_callback.as_ref() { Some(transaction_callback) => { [INFO] [stdout] 564 | transaction_callback(self, pt); [INFO] [stdout] 565 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/wallet.rs:592:16 [INFO] [stdout] | [INFO] [stdout] 592 | if let Err(err) = inner.filter.add(&pub_key[..]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/wallet.rs:595:13 [INFO] [stdout] | [INFO] [stdout] 595 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 592 ~ match inner.filter.add(&pub_key[..]) { Err(err) => { [INFO] [stdout] 593 | let err = WalletError::FilterInsertFailed(err); [INFO] [stdout] 594 | error!("{:?}", err); [INFO] [stdout] 595 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/wallet.rs:883:24 [INFO] [stdout] | [INFO] [stdout] 883 | if let Err(err) = self.send_with_timeout(&mut ws_sender, WsMessage::Text(json)).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/wallet.rs:889:21 [INFO] [stdout] | [INFO] [stdout] 889 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 883 ~ match self.send_with_timeout(&mut ws_sender, WsMessage::Text(json)).await { Err(err) => { [INFO] [stdout] 884 | result_chan_tx.send(WalletResult { [INFO] [stdout] ... [INFO] [stdout] 888 | break Ok(()) [INFO] [stdout] 889 ~ } _ => { [INFO] [stdout] 890 | result_chan = Some(result_chan_tx); [INFO] [stdout] 891 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/wallet.rs:899:32 [INFO] [stdout] | [INFO] [stdout] 899 | ... if let Some(result_chan) = result_chan.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/wallet.rs:904:29 [INFO] [stdout] | [INFO] [stdout] 904 | ... } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 899 ~ match result_chan.take() { Some(result_chan) => { [INFO] [stdout] 900 | result_chan.send(WalletResult { [INFO] [stdout] ... [INFO] [stdout] 903 | })?; [INFO] [stdout] 904 ~ } _ => { [INFO] [stdout] 905 | break Err(PeerConnectionError::Websocket(err).into()) [INFO] [stdout] 906 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/wallet.rs:919:40 [INFO] [stdout] | [INFO] [stdout] 919 | ... if let Some(result_chan) = result_chan.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/wallet.rs:924:37 [INFO] [stdout] | [INFO] [stdout] 924 | ... } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 919 ~ match result_chan.take() { Some(result_chan) => { [INFO] [stdout] 920 | result_chan.send(WalletResult{ [INFO] [stdout] ... [INFO] [stdout] 923 | })?; [INFO] [stdout] 924 ~ } _ => { [INFO] [stdout] 925 | break Err(err.into()) [INFO] [stdout] 926 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/wallet.rs:947:40 [INFO] [stdout] | [INFO] [stdout] 947 | ... if let Some(result_chan) = result_chan.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/wallet.rs:952:37 [INFO] [stdout] | [INFO] [stdout] 952 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 947 ~ match result_chan.take() { Some(result_chan) => { [INFO] [stdout] 948 | result_chan.send(WalletResult { [INFO] [stdout] ... [INFO] [stdout] 951 | })?; [INFO] [stdout] 952 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/wallet.rs:1001:12 [INFO] [stdout] | [INFO] [stdout] 1001 | if let Some(ref conn) = self.conn { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^--------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/wallet.rs:1003:9 [INFO] [stdout] | [INFO] [stdout] 1003 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 1001 ~ match self.conn { Some(ref conn) => { [INFO] [stdout] 1002 | info!("Closed connection with: {}", conn.addr); [INFO] [stdout] 1003 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 58 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating src/bin/wallet/main.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `cruzbit` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/error.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/error.rs:27:16 [INFO] [stderr] | [INFO] [stderr] 27 | ($t:ident, $type:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/irc.rs:157:41 [INFO] [stdout] | [INFO] [stdout] 157 | let nick_bytes = rand::thread_rng().gen::<[u8; 6]>(); [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/error.rs:27:22 [INFO] [stdout] | [INFO] [stdout] 27 | ($t:ident, $type:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 27 | ($t:ident, $type:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/irc.rs:138:28 [INFO] [stdout] | [INFO] [stdout] 138 | if let Err(err) = self [INFO] [stdout] | ____________________________^ - [INFO] [stdout] | |___________________________________________| [INFO] [stdout] 139 | || .addr_chan_tx [INFO] [stdout] 140 | || .send(addr_str) [INFO] [stdout] 141 | || .await [INFO] [stdout] 142 | || .map_err(IrcError::from) [INFO] [stdout] | ||____________________________________________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |____________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/irc.rs:145:25 [INFO] [stdout] | [INFO] [stdout] 145 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 138 ~ match self [INFO] [stdout] 139 | .addr_chan_tx [INFO] [stdout] ... [INFO] [stdout] 142 | .map_err(IrcError::from) [INFO] [stdout] 143 ~ { Err(err) => { [INFO] [stdout] 144 | error!("{:?}", err); [INFO] [stdout] 145 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/miner.rs:256:20 [INFO] [stdout] | [INFO] [stdout] 256 | if let Err(err) = [INFO] [stdout] | ____________________^ [INFO] [stdout] 257 | | block_new_tx.add_transaction(new_tx.transaction_id, new_tx.transaction) [INFO] [stdout] | |_____________________----------------------------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/miner.rs:265:17 [INFO] [stdout] | [INFO] [stdout] 265 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 256 ~ match block_new_tx.add_transaction(new_tx.transaction_id, new_tx.transaction) [INFO] [stdout] 257 ~ { Err(err) => { [INFO] [stdout] 258 | info!( [INFO] [stdout] ... [INFO] [stdout] 263 | block = None; [INFO] [stdout] 264 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/miner.rs:329:24 [INFO] [stdout] | [INFO] [stdout] 329 | if let Err(err) = self [INFO] [stdout] | ________________________^ - [INFO] [stdout] | |_______________________________________| [INFO] [stdout] 330 | || .processor [INFO] [stdout] 331 | || .process_candidate_block(id, candidate_block, PEER_ADDR_SELF) [INFO] [stdout] 332 | || .await [INFO] [stdout] 333 | || .map_err(MinerError::ProcessBlock) [INFO] [stdout] | ||__________________________________________________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |__________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/miner.rs:336:21 [INFO] [stdout] | [INFO] [stdout] 336 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 329 ~ match self [INFO] [stdout] 330 | .processor [INFO] [stdout] ... [INFO] [stdout] 333 | .map_err(MinerError::ProcessBlock) [INFO] [stdout] 334 ~ { Err(err) => { [INFO] [stdout] 335 | error!("{:?}", err); [INFO] [stdout] 336 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:261:23 [INFO] [stdout] | [INFO] [stdout] 261 | while let Some(block_in_flight) = local_inflight_queue.peek() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------------------^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:264:17 [INFO] [stdout] | [INFO] [stdout] 264 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:275:16 [INFO] [stdout] | [INFO] [stdout] 275 | if let Err(_err) = on_connect_chan_tx.send(true).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:277:13 [INFO] [stdout] | [INFO] [stdout] 277 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 275 ~ match on_connect_chan_tx.send(true).await { Err(_err) => { [INFO] [stdout] 276 | error!("failed to send on-connect, peer must have shut down"); [INFO] [stdout] 277 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:327:20 [INFO] [stdout] | [INFO] [stdout] 327 | if let Err(err) = peer_store [INFO] [stdout] | ____________________^ - [INFO] [stdout] | |___________________________________| [INFO] [stdout] 328 | || .on_disconnect(self.addr) [INFO] [stdout] 329 | || .map_err(PeerError::PeerStorage) [INFO] [stdout] | ||____________________________________________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |____________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:332:17 [INFO] [stdout] | [INFO] [stdout] 332 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 327 ~ match peer_store [INFO] [stdout] 328 | .on_disconnect(self.addr) [INFO] [stdout] 329 | .map_err(PeerError::PeerStorage) [INFO] [stdout] 330 ~ { Err(err) => { [INFO] [stdout] 331 | error!("{:?}", err); [INFO] [stdout] 332 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:385:40 [INFO] [stdout] | [INFO] [stdout] 385 | ... if let Some(block) = b.block { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^-^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:393:37 [INFO] [stdout] | [INFO] [stdout] 393 | ... } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 385 ~ match b.block { Some(block) => { [INFO] [stdout] 386 | if let Err(err) = self.on_block(block, ibd, &out_chan_tx).await { [INFO] [stdout] ... [INFO] [stdout] 392 | } [INFO] [stdout] 393 ~ } _ => { [INFO] [stdout] 394 | break Err(PeerError::EmptyBlockReceived(self.addr)) [INFO] [stdout] 395 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:386:44 [INFO] [stdout] | [INFO] [stdout] 386 | ... if let Err(err) = self.on_block(block, ibd, &out_chan_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^--------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:390:41 [INFO] [stdout] | [INFO] [stdout] 390 | ... } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 386 ~ match self.on_block(block, ibd, &out_chan_tx).await { Err(err) => { [INFO] [stdout] 387 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 388 | continue [INFO] [stdout] 389 | [INFO] [stdout] 390 ~ } _ => { [INFO] [stdout] 391 | last_new_block_time = Instant::now(); [INFO] [stdout] 392 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:399:40 [INFO] [stdout] | [INFO] [stdout] 399 | ... if let Err(err) = self.on_filter_add(fa.public_keys, &out_chan_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:402:37 [INFO] [stdout] | [INFO] [stdout] 402 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 399 ~ match self.on_filter_add(fa.public_keys, &out_chan_tx).await { Err(err) => { [INFO] [stdout] 400 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 401 | continue [INFO] [stdout] 402 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:406:40 [INFO] [stdout] | [INFO] [stdout] 406 | ... if let Err(err) = self.on_filter_load(fl.r#type, fl.filter, &out_chan_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:409:37 [INFO] [stdout] | [INFO] [stdout] 409 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 406 ~ match self.on_filter_load(fl.r#type, fl.filter, &out_chan_tx).await { Err(err) => { [INFO] [stdout] 407 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 408 | continue [INFO] [stdout] 409 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:434:40 [INFO] [stdout] | [INFO] [stdout] 434 | ... if let Err(err) = self.on_get_balance(gb.public_key, &out_chan_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:438:37 [INFO] [stdout] | [INFO] [stdout] 438 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 434 ~ match self.on_get_balance(gb.public_key, &out_chan_tx).await { Err(err) => { [INFO] [stdout] 435 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 436 | continue; [INFO] [stdout] 437 | [INFO] [stdout] 438 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:442:40 [INFO] [stdout] | [INFO] [stdout] 442 | ... if let Err(err) = self.on_get_balances(gb.public_keys, &out_chan_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^-------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:445:37 [INFO] [stdout] | [INFO] [stdout] 445 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 442 ~ match self.on_get_balances(gb.public_keys, &out_chan_tx).await { Err(err) => { [INFO] [stdout] 443 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 444 | continue [INFO] [stdout] 445 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:449:40 [INFO] [stdout] | [INFO] [stdout] 449 | ... if let Err(err) = self.on_get_block(gb.block_id, &out_chan_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^-------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:452:37 [INFO] [stdout] | [INFO] [stdout] 452 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 449 ~ match self.on_get_block(gb.block_id, &out_chan_tx).await { Err(err) => { [INFO] [stdout] 450 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 451 | continue [INFO] [stdout] 452 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:456:40 [INFO] [stdout] | [INFO] [stdout] 456 | ... if let Err(err) = self.on_get_block_by_height(gbbh.height, &out_chan_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------------------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:459:37 [INFO] [stdout] | [INFO] [stdout] 459 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 456 ~ match self.on_get_block_by_height(gbbh.height, &out_chan_tx).await { Err(err) => { [INFO] [stdout] 457 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 458 | continue [INFO] [stdout] 459 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:463:40 [INFO] [stdout] | [INFO] [stdout] 463 | ... if let Err(err) = self.on_get_block_header(gbh.block_id, &out_chan_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^---------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:466:37 [INFO] [stdout] | [INFO] [stdout] 466 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 463 ~ match self.on_get_block_header(gbh.block_id, &out_chan_tx).await { Err(err) => { [INFO] [stdout] 464 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 465 | continue [INFO] [stdout] 466 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:470:40 [INFO] [stdout] | [INFO] [stdout] 470 | ... if let Err(err) = self [INFO] [stdout] | __________________________^ - [INFO] [stdout] | |_________________________________________| [INFO] [stdout] 471 | || ... .on_get_block_header_by_height(gbhbh.height, &out_chan_tx).await { [INFO] [stdout] | ||__________________________________________________________________________________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |__________________________________________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:474:41 [INFO] [stdout] | [INFO] [stdout] 474 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 470 ~ match self [INFO] [stdout] 471 ~ .on_get_block_header_by_height(gbhbh.height, &out_chan_tx).await { Err(err) => { [INFO] [stdout] 472 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 473 | continue [INFO] [stdout] 474 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:478:40 [INFO] [stdout] | [INFO] [stdout] 478 | ... if let Err(err) = self.on_get_filter_transaction_queue(&out_chan_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^-------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:481:37 [INFO] [stdout] | [INFO] [stdout] 481 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 478 ~ match self.on_get_filter_transaction_queue(&out_chan_tx).await { Err(err) => { [INFO] [stdout] 479 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 480 | continue [INFO] [stdout] 481 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:485:40 [INFO] [stdout] | [INFO] [stdout] 485 | ... if let Err(err) = self.on_get_peer_addresses(&out_chan_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^---------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:488:37 [INFO] [stdout] | [INFO] [stdout] 488 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 485 ~ match self.on_get_peer_addresses(&out_chan_tx).await { Err(err) => { [INFO] [stdout] 486 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 487 | continue [INFO] [stdout] 488 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:492:40 [INFO] [stdout] | [INFO] [stdout] 492 | ... if let Err(err) = self [INFO] [stdout] | __________________________^ - [INFO] [stdout] | |_________________________________________| [INFO] [stdout] 493 | || ... .on_get_public_key_transactions( [INFO] [stdout] 494 | || ... gpkt.public_key, [INFO] [stdout] 495 | || ... gpkt.start_height, [INFO] [stdout] ... || [INFO] [stdout] 499 | || ... &out_chan_tx [INFO] [stdout] 500 | || ... ).await { [INFO] [stdout] | ||_________________________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |_________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:503:41 [INFO] [stdout] | [INFO] [stdout] 503 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 492 ~ match self [INFO] [stdout] 493 | .on_get_public_key_transactions( [INFO] [stdout] ... [INFO] [stdout] 499 | &out_chan_tx [INFO] [stdout] 500 ~ ).await { Err(err) => { [INFO] [stdout] 501 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 502 | continue [INFO] [stdout] 503 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:507:40 [INFO] [stdout] | [INFO] [stdout] 507 | ... if let Err(err) = self.on_get_tip_header(&out_chan_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:510:37 [INFO] [stdout] | [INFO] [stdout] 510 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 507 ~ match self.on_get_tip_header(&out_chan_tx).await { Err(err) => { [INFO] [stdout] 508 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 509 | continue [INFO] [stdout] 510 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:514:40 [INFO] [stdout] | [INFO] [stdout] 514 | ... if let Err(err) = self.on_get_transaction(gt.transaction_id, &out_chan_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^-------------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:517:37 [INFO] [stdout] | [INFO] [stdout] 517 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 514 ~ match self.on_get_transaction(gt.transaction_id, &out_chan_tx).await { Err(err) => { [INFO] [stdout] 515 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 516 | continue [INFO] [stdout] 517 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:542:44 [INFO] [stdout] | [INFO] [stdout] 542 | ... if let Err(err) = self.on_inv_block(id, i, block_ids_len, &out_chan_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^----------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:545:41 [INFO] [stdout] | [INFO] [stdout] 545 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 542 ~ match self.on_inv_block(id, i, block_ids_len, &out_chan_tx).await { Err(err) => { [INFO] [stdout] 543 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 544 | continue [INFO] [stdout] 545 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:550:40 [INFO] [stdout] | [INFO] [stdout] 550 | ... if let Err(err) = self.on_peer_addresses(pa.addresses).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:553:37 [INFO] [stdout] | [INFO] [stdout] 553 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 550 ~ match self.on_peer_addresses(pa.addresses).await { Err(err) => { [INFO] [stdout] 551 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 552 | continue [INFO] [stdout] 553 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:557:40 [INFO] [stdout] | [INFO] [stdout] 557 | ... if let Err(err) = self.on_push_transaction(pt.transaction, &out_chan_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------------------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:560:37 [INFO] [stdout] | [INFO] [stdout] 560 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 557 ~ match self.on_push_transaction(pt.transaction, &out_chan_tx).await { Err(err) => { [INFO] [stdout] 558 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 559 | continue [INFO] [stdout] 560 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:699:24 [INFO] [stdout] | [INFO] [stdout] 699 | if let Err(err) = self.on_get_work(gw, &out_chan_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^---------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:701:21 [INFO] [stdout] | [INFO] [stdout] 701 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 699 ~ match self.on_get_work(gw, &out_chan_tx).await { Err(err) => { [INFO] [stdout] 700 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 701 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:705:24 [INFO] [stdout] | [INFO] [stdout] 705 | if let Err(err) = self.on_submit_work(sw, &out_chan_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:707:21 [INFO] [stdout] | [INFO] [stdout] 707 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 705 ~ match self.on_submit_work(sw, &out_chan_tx).await { Err(err) => { [INFO] [stdout] 706 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 707 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:716:24 [INFO] [stdout] | [INFO] [stdout] 716 | if let Err(err) = self.peer_store.on_connect_success(self.addr).map_err(PeerError::PeerStorage) { [INFO] [stdout] | ^^^^^^^^^^^^^^^----------------------------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:718:21 [INFO] [stdout] | [INFO] [stdout] 718 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 716 ~ match self.peer_store.on_connect_success(self.addr).map_err(PeerError::PeerStorage) { Err(err) => { [INFO] [stdout] 717 | error!("{:?}, from: {}", err, self.addr); [INFO] [stdout] 718 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:1623:16 [INFO] [stdout] | [INFO] [stdout] 1623 | if let Err(err) = self [INFO] [stdout] | ________________^ - [INFO] [stdout] | |_______________________________| [INFO] [stdout] 1624 | || .processor [INFO] [stdout] 1625 | || .process_candidate_transaction(&id, &tx, &self.addr) [INFO] [stdout] 1626 | || .await [INFO] [stdout] | ||______________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |______________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:1629:13 [INFO] [stdout] | [INFO] [stdout] 1629 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 1623 ~ match self [INFO] [stdout] 1624 | .processor [INFO] [stdout] 1625 | .process_candidate_transaction(&id, &tx, &self.addr) [INFO] [stdout] 1626 | .await [INFO] [stdout] 1627 ~ { Err(err) => { [INFO] [stdout] 1628 | err_str = Some(format!("{:?}", err)); [INFO] [stdout] 1629 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:2013:26 [INFO] [stdout] | [INFO] [stdout] 2013 | let message = if let Err(ref err) = block_id { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^-------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:2018:9 [INFO] [stdout] | [INFO] [stdout] 2018 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 2013 ~ let message = match block_id { Err(ref err) => { [INFO] [stdout] 2014 | Message::SubmitWorkResult(SubmitWorkResultMessage { [INFO] [stdout] ... [INFO] [stdout] 2017 | }) [INFO] [stdout] 2018 ~ } _ => { [INFO] [stdout] 2019 | Message::SubmitWorkResult(SubmitWorkResultMessage { [INFO] [stdout] ... [INFO] [stdout] 2022 | }) [INFO] [stdout] 2023 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer.rs:2026:12 [INFO] [stdout] | [INFO] [stdout] 2026 | if let Err(err) = block_id { [INFO] [stdout] | ^^^^^^^^^^^^^^^-------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer.rs:2028:9 [INFO] [stdout] | [INFO] [stdout] 2028 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 2026 ~ match block_id { Err(err) => { [INFO] [stdout] 2027 | Err(err.into()) [INFO] [stdout] 2028 ~ } _ => { [INFO] [stdout] 2029 | Ok(()) [INFO] [stdout] 2030 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer_manager.rs:252:32 [INFO] [stdout] | [INFO] [stdout] 252 | ... if let Err(err) = self.connect_to_peers().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^----------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer_manager.rs:255:29 [INFO] [stdout] | [INFO] [stdout] 255 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 252 ~ match self.connect_to_peers().await { Err(err) => { [INFO] [stdout] 253 | error!("{:?}", err); [INFO] [stdout] 254 | continue [INFO] [stdout] 255 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer_manager.rs:280:24 [INFO] [stdout] | [INFO] [stdout] 280 | if let Err(err) = self.connect_to_peers().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^----------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer_manager.rs:282:21 [INFO] [stdout] | [INFO] [stdout] 282 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 280 ~ match self.connect_to_peers().await { Err(err) => { [INFO] [stdout] 281 | error!("{:?}", err); [INFO] [stdout] 282 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer_manager.rs:533:24 [INFO] [stdout] | [INFO] [stdout] 533 | if let Some(shutdown) = out_peer { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^-------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer_manager.rs:535:21 [INFO] [stdout] | [INFO] [stdout] 535 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 533 ~ match out_peer { Some(shutdown) => { [INFO] [stdout] 534 | shutdown.send().await; [INFO] [stdout] 535 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer_manager.rs:639:12 [INFO] [stdout] | [INFO] [stdout] 639 | if let Some(_shutdown) = out_peers.remove(addr) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer_manager.rs:641:9 [INFO] [stdout] | [INFO] [stdout] 641 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 639 ~ match out_peers.remove(addr) { Some(_shutdown) => { [INFO] [stdout] 640 | info!("Outbound peer count: {}", out_peers.len()); [INFO] [stdout] 641 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer_manager.rs:671:12 [INFO] [stdout] | [INFO] [stdout] 671 | if let Some((addr, shutdown)) = out_peer { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer_manager.rs:674:9 [INFO] [stdout] | [INFO] [stdout] 674 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 671 ~ match out_peer { Some((addr, shutdown)) => { [INFO] [stdout] 672 | info!("Dropping random peer: {}", addr); [INFO] [stdout] 673 | shutdown.send().await; [INFO] [stdout] 674 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer_manager.rs:808:24 [INFO] [stdout] | [INFO] [stdout] 808 | if let Ok(tls_stream) = TlsAcceptor::from(server_config).accept(stream).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^----------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer_manager.rs:813:21 [INFO] [stdout] | [INFO] [stdout] 813 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 808 ~ match TlsAcceptor::from(server_config).accept(stream).await { Ok(tls_stream) => { [INFO] [stdout] 809 | if let Err(err) = self.handle_connection(tls_stream, remote_addr).await { [INFO] [stdout] ... [INFO] [stdout] 812 | } [INFO] [stdout] 813 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer_manager.rs:809:28 [INFO] [stdout] | [INFO] [stdout] 809 | if let Err(err) = self.handle_connection(tls_stream, remote_addr).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^----------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer_manager.rs:812:25 [INFO] [stdout] | [INFO] [stdout] 812 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 809 ~ match self.handle_connection(tls_stream, remote_addr).await { Err(err) => { [INFO] [stdout] 810 | error!("{:?}", err); [INFO] [stdout] 811 | continue; [INFO] [stdout] 812 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/peer_manager.rs:927:24 [INFO] [stdout] | [INFO] [stdout] 927 | if let Err(err) = self.peer_manager.peer_store.store(addr) { [INFO] [stdout] | ^^^^^^^^^^^^^^^---------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/peer_manager.rs:929:21 [INFO] [stdout] | [INFO] [stdout] 929 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 927 ~ match self.peer_manager.peer_store.store(addr) { Err(err) => { [INFO] [stdout] 928 | info!("Error saving peer: {}, address: {}", err, &addr); [INFO] [stdout] 929 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/processor.rs:237:24 [INFO] [stdout] | [INFO] [stdout] 237 | if let Err(err) = tx_to_process.result_chan.send(result).map_err(ProcessTransactionError::from) { [INFO] [stdout] | ^^^^^^^^^^^^^^^----------------------------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/processor.rs:239:21 [INFO] [stdout] | [INFO] [stdout] 239 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 237 ~ match tx_to_process.result_chan.send(result).map_err(ProcessTransactionError::from) { Err(err) => { [INFO] [stdout] 238 | error!("{:?}", err); [INFO] [stdout] 239 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/processor.rs:263:24 [INFO] [stdout] | [INFO] [stdout] 263 | if let Err(err) = block_to_process.result_chan.send(result).map_err(ProcessBlockError::from) { [INFO] [stdout] | ^^^^^^^^^^^^^^^-------------------------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/processor.rs:265:21 [INFO] [stdout] | [INFO] [stdout] 265 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 263 ~ match block_to_process.result_chan.send(result).map_err(ProcessBlockError::from) { Err(err) => { [INFO] [stdout] 264 | error!("{:?}", err); [INFO] [stdout] 265 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/processor.rs:275:24 [INFO] [stdout] | [INFO] [stdout] 275 | if let Some(index) = new_tx_channels [INFO] [stdout] | ^ --------------- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | ________________________| [INFO] [stdout] | | [INFO] [stdout] 276 | | .iter() [INFO] [stdout] 277 | | .position(|c| c.same_channel(&ch)) { [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/processor.rs:279:25 [INFO] [stdout] | [INFO] [stdout] 279 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 275 ~ match new_tx_channels [INFO] [stdout] 276 | .iter() [INFO] [stdout] 277 ~ .position(|c| c.same_channel(&ch)) { Some(index) => { [INFO] [stdout] 278 | new_tx_channels.remove(index); [INFO] [stdout] 279 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/processor.rs:291:24 [INFO] [stdout] | [INFO] [stdout] 291 | if let Some(index) = tip_change_channels [INFO] [stdout] | ^ ------------------- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | ________________________| [INFO] [stdout] | | [INFO] [stdout] 292 | | .iter() [INFO] [stdout] 293 | | .position(|c| c.same_channel(&ch)) { [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/processor.rs:295:25 [INFO] [stdout] | [INFO] [stdout] 295 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 291 ~ match tip_change_channels [INFO] [stdout] 292 | .iter() [INFO] [stdout] 293 ~ .position(|c| c.same_channel(&ch)) { Some(index) => { [INFO] [stdout] 294 | tip_change_channels.remove(index); [INFO] [stdout] 295 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/processor.rs:458:16 [INFO] [stdout] | [INFO] [stdout] 458 | if let Err(err) = new_tx [INFO] [stdout] | ________________^ - [INFO] [stdout] | |_______________________________| [INFO] [stdout] 459 | || .send(NewTx { [INFO] [stdout] 460 | || transaction_id: id, [INFO] [stdout] 461 | || transaction: tx.clone(), [INFO] [stdout] ... || [INFO] [stdout] 464 | || .await [INFO] [stdout] 465 | || .map_err(ProcessTransactionError::from) [INFO] [stdout] | ||_______________________________________________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |_______________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/processor.rs:468:13 [INFO] [stdout] | [INFO] [stdout] 468 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 458 ~ match new_tx [INFO] [stdout] 459 | .send(NewTx { [INFO] [stdout] ... [INFO] [stdout] 465 | .map_err(ProcessTransactionError::from) [INFO] [stdout] 466 ~ { Err(err) => { [INFO] [stdout] 467 | error!("{:?}", err) [INFO] [stdout] 468 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/processor.rs:1200:16 [INFO] [stdout] | [INFO] [stdout] 1200 | if let Err(err) = tip_tx [INFO] [stdout] | ________________^ - [INFO] [stdout] | |_______________________________| [INFO] [stdout] 1201 | || .send(TipChange { [INFO] [stdout] 1202 | || block_id: *id, [INFO] [stdout] 1203 | || block: block.clone(), [INFO] [stdout] ... || [INFO] [stdout] 1207 | || }) [INFO] [stdout] 1208 | || .map_err(ProcessorError::from) [INFO] [stdout] | ||______________________________________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |______________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/processor.rs:1211:13 [INFO] [stdout] | [INFO] [stdout] 1211 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 1200 ~ match tip_tx [INFO] [stdout] 1201 | .send(TipChange { [INFO] [stdout] ... [INFO] [stdout] 1208 | .map_err(ProcessorError::from) [INFO] [stdout] 1209 ~ { Err(err) => { [INFO] [stdout] 1210 | error!("{:?}", err); [INFO] [stdout] 1211 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/processor.rs:1240:16 [INFO] [stdout] | [INFO] [stdout] 1240 | if let Err(err) = tip_tx [INFO] [stdout] | ________________^ - [INFO] [stdout] | |_______________________________| [INFO] [stdout] 1241 | || .send(TipChange { [INFO] [stdout] 1242 | || block_id: *id, [INFO] [stdout] 1243 | || block: block.clone(), [INFO] [stdout] ... || [INFO] [stdout] 1247 | || }) [INFO] [stdout] 1248 | || .map_err(ProcessBlockError::from) [INFO] [stdout] | ||_________________________________________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |_________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/processor.rs:1251:13 [INFO] [stdout] | [INFO] [stdout] 1251 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 1240 ~ match tip_tx [INFO] [stdout] 1241 | .send(TipChange { [INFO] [stdout] ... [INFO] [stdout] 1248 | .map_err(ProcessBlockError::from) [INFO] [stdout] 1249 ~ { Err(err) => { [INFO] [stdout] 1250 | error!("{:?}", err); [INFO] [stdout] 1251 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/shutdown.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 38 | if let Err(err) = self.monitor_handle.await { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/shutdown.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 38 ~ match self.monitor_handle.await { Err(err) => { [INFO] [stdout] 39 | error!("{:?}", ShutdownError::Join(err)); [INFO] [stdout] 40 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/transaction_queue_memory.rs:136:20 [INFO] [stdout] | [INFO] [stdout] 136 | if let Some(index) = tx_queue [INFO] [stdout] | ^ -------- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | ____________________| [INFO] [stdout] | | [INFO] [stdout] 137 | | .iter() [INFO] [stdout] 138 | | .position(|queue_tx_id| *queue_tx_id == tx_id) [INFO] [stdout] | |__________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/transaction_queue_memory.rs:142:17 [INFO] [stdout] | [INFO] [stdout] 142 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 136 ~ match tx_queue [INFO] [stdout] 137 | .iter() [INFO] [stdout] 138 | .position(|queue_tx_id| *queue_tx_id == tx_id) [INFO] [stdout] 139 ~ { Some(index) => { [INFO] [stdout] 140 | // remove it from its current position [INFO] [stdout] 141 | tx_queue.remove(index); [INFO] [stdout] 142 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/transaction_queue_memory.rs:188:12 [INFO] [stdout] | [INFO] [stdout] 188 | if let Some(tx) = self.tx_map.read().unwrap().get(id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^---------------------------^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/transaction_queue_memory.rs:190:9 [INFO] [stdout] | [INFO] [stdout] 190 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 188 ~ match self.tx_map.read().unwrap().get(id) { Some(tx) => { [INFO] [stdout] 189 | tx.signature.expect("transaction should have a signature") == signature [INFO] [stdout] 190 ~ } _ => { [INFO] [stdout] 191 | false [INFO] [stdout] 192 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/wallet.rs:161:16 [INFO] [stdout] | [INFO] [stdout] 161 | if let Err(err) = inner.filter.add(&pub_key[..]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/wallet.rs:164:13 [INFO] [stdout] | [INFO] [stdout] 164 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 161 ~ match inner.filter.add(&pub_key[..]) { Err(err) => { [INFO] [stdout] 162 | let err = WalletError::FilterInsertFailed(err); [INFO] [stdout] 163 | error!("{:?}", err); [INFO] [stdout] 164 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/wallet.rs:563:12 [INFO] [stdout] | [INFO] [stdout] 563 | if let Some(transaction_callback) = self.inner().transaction_callback.as_ref() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------------------------^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/wallet.rs:565:9 [INFO] [stdout] | [INFO] [stdout] 565 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 563 ~ match self.inner().transaction_callback.as_ref() { Some(transaction_callback) => { [INFO] [stdout] 564 | transaction_callback(self, pt); [INFO] [stdout] 565 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/wallet.rs:592:16 [INFO] [stdout] | [INFO] [stdout] 592 | if let Err(err) = inner.filter.add(&pub_key[..]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/wallet.rs:595:13 [INFO] [stdout] | [INFO] [stdout] 595 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 592 ~ match inner.filter.add(&pub_key[..]) { Err(err) => { [INFO] [stdout] 593 | let err = WalletError::FilterInsertFailed(err); [INFO] [stdout] 594 | error!("{:?}", err); [INFO] [stdout] 595 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/wallet.rs:883:24 [INFO] [stdout] | [INFO] [stdout] 883 | if let Err(err) = self.send_with_timeout(&mut ws_sender, WsMessage::Text(json)).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/wallet.rs:889:21 [INFO] [stdout] | [INFO] [stdout] 889 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 883 ~ match self.send_with_timeout(&mut ws_sender, WsMessage::Text(json)).await { Err(err) => { [INFO] [stdout] 884 | result_chan_tx.send(WalletResult { [INFO] [stdout] ... [INFO] [stdout] 888 | break Ok(()) [INFO] [stdout] 889 ~ } _ => { [INFO] [stdout] 890 | result_chan = Some(result_chan_tx); [INFO] [stdout] 891 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/wallet.rs:899:32 [INFO] [stdout] | [INFO] [stdout] 899 | ... if let Some(result_chan) = result_chan.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/wallet.rs:904:29 [INFO] [stdout] | [INFO] [stdout] 904 | ... } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 899 ~ match result_chan.take() { Some(result_chan) => { [INFO] [stdout] 900 | result_chan.send(WalletResult { [INFO] [stdout] ... [INFO] [stdout] 903 | })?; [INFO] [stdout] 904 ~ } _ => { [INFO] [stdout] 905 | break Err(PeerConnectionError::Websocket(err).into()) [INFO] [stdout] 906 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/wallet.rs:919:40 [INFO] [stdout] | [INFO] [stdout] 919 | ... if let Some(result_chan) = result_chan.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/wallet.rs:924:37 [INFO] [stdout] | [INFO] [stdout] 924 | ... } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 919 ~ match result_chan.take() { Some(result_chan) => { [INFO] [stdout] 920 | result_chan.send(WalletResult{ [INFO] [stdout] ... [INFO] [stdout] 923 | })?; [INFO] [stdout] 924 ~ } _ => { [INFO] [stdout] 925 | break Err(err.into()) [INFO] [stdout] 926 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/wallet.rs:947:40 [INFO] [stdout] | [INFO] [stdout] 947 | ... if let Some(result_chan) = result_chan.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/wallet.rs:952:37 [INFO] [stdout] | [INFO] [stdout] 952 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 947 ~ match result_chan.take() { Some(result_chan) => { [INFO] [stdout] 948 | result_chan.send(WalletResult { [INFO] [stdout] ... [INFO] [stdout] 951 | })?; [INFO] [stdout] 952 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/wallet.rs:1001:12 [INFO] [stdout] | [INFO] [stdout] 1001 | if let Some(ref conn) = self.conn { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^--------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/wallet.rs:1003:9 [INFO] [stdout] | [INFO] [stdout] 1003 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 1001 ~ match self.conn { Some(ref conn) => { [INFO] [stdout] 1002 | info!("Closed connection with: {}", conn.addr); [INFO] [stdout] 1003 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 58 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating src/bin/client/main.rs from 2021 edition to 2024 [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 21.92s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Compiling cruzbit v1.0.1 (/tmp/fixit) [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/irc.rs:157:41 [INFO] [stdout] | [INFO] [stdout] 157 | let nick_bytes = rand::thread_rng().gen::<[u8; 6]>(); [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 157 | let nick_bytes = rand::thread_rng().r#gen::<[u8; 6]>(); [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/irc.rs:157:41 [INFO] [stdout] | [INFO] [stdout] 157 | let nick_bytes = rand::thread_rng().gen::<[u8; 6]>(); [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 157 | let nick_bytes = rand::thread_rng().r#gen::<[u8; 6]>(); [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cruzbit` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cruzbit` (lib test) due to 2 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "ed0896cf17b8be6e8372b28f42c381bf593f29b298bb43a2e288da2ea43d58a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ed0896cf17b8be6e8372b28f42c381bf593f29b298bb43a2e288da2ea43d58a7", kill_on_drop: false }` [INFO] [stdout] ed0896cf17b8be6e8372b28f42c381bf593f29b298bb43a2e288da2ea43d58a7