[INFO] fetching crate coreos-installer 0.22.1... [INFO] checking coreos-installer-0.22.1 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate coreos-installer 0.22.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate coreos-installer 0.22.1 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate coreos-installer 0.22.1 [INFO] finished tweaking crates.io crate coreos-installer 0.22.1 [INFO] tweaked toml for crates.io crate coreos-installer 0.22.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate coreos-installer 0.22.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `nix` dependency) [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dc01689cf5374a2df49e320bc769715f137570626748a52a527f546ef9b69657 [INFO] running `Command { std: "docker" "start" "-a" "dc01689cf5374a2df49e320bc769715f137570626748a52a527f546ef9b69657", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dc01689cf5374a2df49e320bc769715f137570626748a52a527f546ef9b69657", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dc01689cf5374a2df49e320bc769715f137570626748a52a527f546ef9b69657", kill_on_drop: false }` [INFO] [stdout] dc01689cf5374a2df49e320bc769715f137570626748a52a527f546ef9b69657 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 01c9cd224ba231beb96dc01f8ac3387909faa881a118ea8ba1e35a5c7b0e0222 [INFO] running `Command { std: "docker" "start" "-a" "01c9cd224ba231beb96dc01f8ac3387909faa881a118ea8ba1e35a5c7b0e0222", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Fixed Cargo.toml (1 fix) [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Checking bytes v1.6.1 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling openssl v0.10.66 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling httparse v1.9.4 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Compiling indexmap v2.2.6 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Compiling cc v1.1.6 [INFO] [stderr] Compiling toml_datetime v0.6.6 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling strsim v0.11.1 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking tokio v1.39.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Compiling zstd-sys v2.0.12+zstd.1.5.6 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Compiling lzma-sys v0.1.20 [INFO] [stderr] Compiling zstd-safe v7.2.0 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Compiling ignition-config v0.3.0 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking crc-catalog v2.4.0 [INFO] [stderr] Checking rustls-pki-types v1.7.0 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking clap_builder v4.5.10 [INFO] [stderr] Checking crc v3.2.1 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking h2 v0.4.5 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling clap_derive v4.5.8 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Compiling serde_with_macros v3.9.0 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Compiling zvariant_derive v2.10.0 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking utf8-width v0.1.7 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Checking zstd v0.13.2 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking pipe v0.4.0 [INFO] [stderr] Checking xz2 v0.1.7 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking cpio v0.4.0 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking clap v4.5.10 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking hyper-util v0.1.6 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking zvariant v2.10.0 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking serde_ignored v0.1.10 [INFO] [stderr] Checking byte-unit v4.0.19 [INFO] [stderr] Checking serde_with v3.9.0 [INFO] [stderr] Checking reqwest v0.12.5 [INFO] [stderr] Checking gptman v1.1.2 [INFO] [stderr] Checking nmstate v2.2.33 [INFO] [stderr] Checking coreos-installer v0.22.1 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `libcoreinst` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/util.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/util.rs:23:6 [INFO] [stderr] | [INFO] [stderr] 23 | ($cmd:expr_2021) => (runcmd!($cmd,)); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/util.rs:24:6 [INFO] [stderr] | [INFO] [stderr] 24 | ($cmd:expr_2021, $($args:expr_2021),*) => {{ [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/util.rs:24:24 [INFO] [stderr] | [INFO] [stderr] 24 | ($cmd:expr_2021, $($args:expr_2021),*) => {{ [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/util.rs:42:6 [INFO] [stderr] | [INFO] [stderr] 42 | ($cmd:expr_2021) => (runcmd_output!($cmd,)); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/util.rs:43:6 [INFO] [stderr] | [INFO] [stderr] 43 | ($cmd:expr_2021, $($args:expr_2021),*) => {{ [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/util.rs:23:11 [INFO] [stdout] | [INFO] [stdout] 23 | ($cmd:expr) => (runcmd!($cmd,)); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 23 | ($cmd:expr_2021) => (runcmd!($cmd,)); [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/util.rs:43:24 [INFO] [stderr] | [INFO] [stderr] 43 | ($cmd:expr_2021, $($args:expr_2021),*) => {{ [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/util.rs:24:11 [INFO] [stdout] | [INFO] [stdout] 24 | ($cmd:expr, $($args:expr),*) => {{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 24 | ($cmd:expr_2021, $($args:expr),*) => {{ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/util.rs:24:25 [INFO] [stdout] | [INFO] [stdout] 24 | ($cmd:expr, $($args:expr),*) => {{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 24 | ($cmd:expr, $($args:expr_2021),*) => {{ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/util.rs:42:11 [INFO] [stdout] | [INFO] [stdout] 42 | ($cmd:expr) => (runcmd_output!($cmd,)); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 42 | ($cmd:expr_2021) => (runcmd_output!($cmd,)); [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/util.rs:43:11 [INFO] [stdout] | [INFO] [stdout] 43 | ($cmd:expr, $($args:expr),*) => {{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 43 | ($cmd:expr_2021, $($args:expr),*) => {{ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/util.rs:43:25 [INFO] [stdout] | [INFO] [stdout] 43 | ($cmd:expr, $($args:expr),*) => {{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 43 | ($cmd:expr, $($args:expr_2021),*) => {{ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/blockdev.rs:315:16 [INFO] [stdout] | [INFO] [stdout] 315 | if let Err(e) = self.run_kpartx("-d") { [INFO] [stdout] | ^^^^^^^^^^^^^--------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/blockdev.rs:317:13 [INFO] [stdout] | [INFO] [stdout] 317 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 315 ~ match self.run_kpartx("-d") { Err(e) => { [INFO] [stdout] 316 | eprintln!("{e}") [INFO] [stdout] 317 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/blockdev.rs:511:12 [INFO] [stdout] | [INFO] [stdout] 511 | if let Err(err) = remove_dir(&self.mountpoint) { [INFO] [stdout] | ^^^^^^^^^^^^^^^---------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/blockdev.rs:513:9 [INFO] [stdout] | [INFO] [stdout] 513 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 511 ~ match remove_dir(&self.mountpoint) { Err(err) => { [INFO] [stdout] 512 | eprintln!("removing {}: {}", self.mountpoint.display(), err); [INFO] [stdout] 513 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/blockdev.rs:818:16 [INFO] [stdout] | [INFO] [stdout] 818 | if let Ok(mut fd) = std::fs::File::open(dev) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/blockdev.rs:821:13 [INFO] [stdout] | [INFO] [stdout] 821 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 818 ~ match std::fs::File::open(dev) { Ok(mut fd) => { [INFO] [stdout] 819 | // best-effort reread of disk that may have busy partitions; don't retry [INFO] [stdout] 820 | let _ = reread_partition_table(&mut fd, false); [INFO] [stdout] 821 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl std::io::Read + '_` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/iso9660.rs:135:56 [INFO] [stdout] | [INFO] [stdout] 135 | pub fn read_file(&mut self, file: &File) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/iso9660.rs:135:39 [INFO] [stdout] | [INFO] [stdout] 135 | pub fn read_file(&mut self, file: &File) -> Result { [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] = note: `--force-warn impl-trait-overcaptures` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 135 | pub fn read_file(&mut self, file: &File) -> Result> { [INFO] [stdout] | +++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl std::io::Write + '_` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/iso9660.rs:146:61 [INFO] [stdout] | [INFO] [stdout] 146 | pub fn overwrite_file(&mut self, file: &File) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/iso9660.rs:146:44 [INFO] [stdout] | [INFO] [stdout] 146 | pub fn overwrite_file(&mut self, file: &File) -> Result { [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 146 | pub fn overwrite_file(&mut self, file: &File) -> Result> { [INFO] [stdout] | +++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/iso9660.rs:252:11 [INFO] [stdout] | [INFO] [stdout] 252 | while let Some(d) = get_next_volume_descriptor(f) [INFO] [stdout] | ___________^ - [INFO] [stdout] | |_________________________| [INFO] [stdout] 253 | || .with_context(|| format!("getting volume descriptor #{}", descriptors.len() + 1))? [INFO] [stdout] | ||__________________________________________________________________________________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |__________________________________________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/iso9660.rs:256:5 [INFO] [stdout] | [INFO] [stdout] 256 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/iso9660.rs:384:15 [INFO] [stdout] | [INFO] [stdout] 384 | while let Some(ref mut current_dir) = self.current_dir { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/iso9660.rs:408:9 [INFO] [stdout] | [INFO] [stdout] 408 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl std::io::Read + Send` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/osmet/file.rs:139:79 [INFO] [stdout] | [INFO] [stdout] 139 | pub(super) fn osmet_file_read(path: &Path) -> Result<(OsmetFileHeader, Osmet, impl Read + Send)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/osmet/file.rs:139:37 [INFO] [stdout] | [INFO] [stdout] 139 | pub(super) fn osmet_file_read(path: &Path) -> Result<(OsmetFileHeader, Osmet, impl Read + Send)> { [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 139 | pub(super) fn osmet_file_read(path: &Path) -> Result<(OsmetFileHeader, Osmet, impl Read + Send + use<>)> { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/osmet/unpacker.rs:78:16 [INFO] [stdout] | [INFO] [stdout] 78 | if let Some(thread_handle) = self.thread_handle.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/osmet/unpacker.rs:86:13 [INFO] [stdout] | [INFO] [stdout] 86 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 78 ~ match self.thread_handle.take() { Some(thread_handle) => { [INFO] [stdout] 79 | return match thread_handle.join().expect("joining thread") { [INFO] [stdout] ... [INFO] [stdout] 85 | }; [INFO] [stdout] 86 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/source.rs:312:12 [INFO] [stdout] | [INFO] [stdout] 312 | if let Some((osmet_path, description)) = [INFO] [stdout] | ____________^ [INFO] [stdout] 313 | | find_matching_osmet_in_dir(osmet_dir, architecture, sector_size)? [INFO] [stdout] | |_____________----------------------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/source.rs:321:9 [INFO] [stdout] | [INFO] [stdout] 321 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 312 ~ match find_matching_osmet_in_dir(osmet_dir, architecture, sector_size)? [INFO] [stdout] 313 ~ { Some((osmet_path, description)) => { [INFO] [stdout] 314 | Ok(Some(Self { [INFO] [stdout] ... [INFO] [stdout] 319 | })) [INFO] [stdout] 320 ~ } _ => { [INFO] [stdout] 321 | Ok(None) [INFO] [stdout] 322 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 16 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating src/main.rs from 2021 edition to 2024 [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/util.rs:23:11 [INFO] [stdout] | [INFO] [stdout] 23 | ($cmd:expr) => (runcmd!($cmd,)); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 23 | ($cmd:expr_2021) => (runcmd!($cmd,)); [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `libcoreinst` [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/util.rs:24:11 [INFO] [stdout] | [INFO] [stdout] 24 | ($cmd:expr, $($args:expr),*) => {{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 24 | ($cmd:expr_2021, $($args:expr),*) => {{ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/util.rs:24:25 [INFO] [stdout] | [INFO] [stdout] 24 | ($cmd:expr, $($args:expr),*) => {{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 24 | ($cmd:expr, $($args:expr_2021),*) => {{ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/util.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/util.rs:23:6 [INFO] [stderr] | [INFO] [stderr] 23 | ($cmd:expr_2021) => (runcmd!($cmd,)); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/util.rs:24:6 [INFO] [stderr] | [INFO] [stderr] 24 | ($cmd:expr_2021, $($args:expr_2021),*) => {{ [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/util.rs:24:24 [INFO] [stderr] | [INFO] [stderr] 24 | ($cmd:expr_2021, $($args:expr_2021),*) => {{ [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/util.rs:42:6 [INFO] [stderr] | [INFO] [stderr] 42 | ($cmd:expr_2021) => (runcmd_output!($cmd,)); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/util.rs:43:6 [INFO] [stderr] | [INFO] [stderr] 43 | ($cmd:expr_2021, $($args:expr_2021),*) => {{ [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/util.rs:43:24 [INFO] [stderr] | [INFO] [stderr] 43 | ($cmd:expr_2021, $($args:expr_2021),*) => {{ [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/util.rs:42:11 [INFO] [stdout] | [INFO] [stdout] 42 | ($cmd:expr) => (runcmd_output!($cmd,)); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 42 | ($cmd:expr_2021) => (runcmd_output!($cmd,)); [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/util.rs:43:11 [INFO] [stdout] | [INFO] [stdout] 43 | ($cmd:expr, $($args:expr),*) => {{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 43 | ($cmd:expr_2021, $($args:expr),*) => {{ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/util.rs:43:25 [INFO] [stdout] | [INFO] [stdout] 43 | ($cmd:expr, $($args:expr),*) => {{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 43 | ($cmd:expr, $($args:expr_2021),*) => {{ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/blockdev.rs:315:16 [INFO] [stdout] | [INFO] [stdout] 315 | if let Err(e) = self.run_kpartx("-d") { [INFO] [stdout] | ^^^^^^^^^^^^^--------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/blockdev.rs:317:13 [INFO] [stdout] | [INFO] [stdout] 317 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 315 ~ match self.run_kpartx("-d") { Err(e) => { [INFO] [stdout] 316 | eprintln!("{e}") [INFO] [stdout] 317 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/blockdev.rs:511:12 [INFO] [stdout] | [INFO] [stdout] 511 | if let Err(err) = remove_dir(&self.mountpoint) { [INFO] [stdout] | ^^^^^^^^^^^^^^^---------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/blockdev.rs:513:9 [INFO] [stdout] | [INFO] [stdout] 513 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 511 ~ match remove_dir(&self.mountpoint) { Err(err) => { [INFO] [stdout] 512 | eprintln!("removing {}: {}", self.mountpoint.display(), err); [INFO] [stdout] 513 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/blockdev.rs:818:16 [INFO] [stdout] | [INFO] [stdout] 818 | if let Ok(mut fd) = std::fs::File::open(dev) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/blockdev.rs:821:13 [INFO] [stdout] | [INFO] [stdout] 821 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 818 ~ match std::fs::File::open(dev) { Ok(mut fd) => { [INFO] [stdout] 819 | // best-effort reread of disk that may have busy partitions; don't retry [INFO] [stdout] 820 | let _ = reread_partition_table(&mut fd, false); [INFO] [stdout] 821 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl std::io::Read + '_` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/iso9660.rs:135:56 [INFO] [stdout] | [INFO] [stdout] 135 | pub fn read_file(&mut self, file: &File) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/iso9660.rs:135:39 [INFO] [stdout] | [INFO] [stdout] 135 | pub fn read_file(&mut self, file: &File) -> Result { [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] = note: `--force-warn impl-trait-overcaptures` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 135 | pub fn read_file(&mut self, file: &File) -> Result> { [INFO] [stdout] | +++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl std::io::Write + '_` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/iso9660.rs:146:61 [INFO] [stdout] | [INFO] [stdout] 146 | pub fn overwrite_file(&mut self, file: &File) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/iso9660.rs:146:44 [INFO] [stdout] | [INFO] [stdout] 146 | pub fn overwrite_file(&mut self, file: &File) -> Result { [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 146 | pub fn overwrite_file(&mut self, file: &File) -> Result> { [INFO] [stdout] | +++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/iso9660.rs:252:11 [INFO] [stdout] | [INFO] [stdout] 252 | while let Some(d) = get_next_volume_descriptor(f) [INFO] [stdout] | ___________^ - [INFO] [stdout] | |_________________________| [INFO] [stdout] 253 | || .with_context(|| format!("getting volume descriptor #{}", descriptors.len() + 1))? [INFO] [stdout] | ||__________________________________________________________________________________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |__________________________________________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/iso9660.rs:256:5 [INFO] [stdout] | [INFO] [stdout] 256 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/iso9660.rs:384:15 [INFO] [stdout] | [INFO] [stdout] 384 | while let Some(ref mut current_dir) = self.current_dir { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/iso9660.rs:408:9 [INFO] [stdout] | [INFO] [stdout] 408 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl std::io::Read + Send` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/osmet/file.rs:139:79 [INFO] [stdout] | [INFO] [stdout] 139 | pub(super) fn osmet_file_read(path: &Path) -> Result<(OsmetFileHeader, Osmet, impl Read + Send)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/osmet/file.rs:139:37 [INFO] [stdout] | [INFO] [stdout] 139 | pub(super) fn osmet_file_read(path: &Path) -> Result<(OsmetFileHeader, Osmet, impl Read + Send)> { [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 139 | pub(super) fn osmet_file_read(path: &Path) -> Result<(OsmetFileHeader, Osmet, impl Read + Send + use<>)> { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/osmet/unpacker.rs:78:16 [INFO] [stdout] | [INFO] [stdout] 78 | if let Some(thread_handle) = self.thread_handle.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/osmet/unpacker.rs:86:13 [INFO] [stdout] | [INFO] [stdout] 86 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 78 ~ match self.thread_handle.take() { Some(thread_handle) => { [INFO] [stdout] 79 | return match thread_handle.join().expect("joining thread") { [INFO] [stdout] ... [INFO] [stdout] 85 | }; [INFO] [stdout] 86 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/source.rs:312:12 [INFO] [stdout] | [INFO] [stdout] 312 | if let Some((osmet_path, description)) = [INFO] [stdout] | ____________^ [INFO] [stdout] 313 | | find_matching_osmet_in_dir(osmet_dir, architecture, sector_size)? [INFO] [stdout] | |_____________----------------------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/source.rs:321:9 [INFO] [stdout] | [INFO] [stdout] 321 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 312 ~ match find_matching_osmet_in_dir(osmet_dir, architecture, sector_size)? [INFO] [stdout] 313 ~ { Some((osmet_path, description)) => { [INFO] [stdout] 314 | Ok(Some(Self { [INFO] [stdout] ... [INFO] [stdout] 319 | })) [INFO] [stdout] 320 ~ } _ => { [INFO] [stdout] 321 | Ok(None) [INFO] [stdout] 322 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 16 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 23.76s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking coreos-installer v0.22.1 (/tmp/fixit) [INFO] [stdout] error[E0521]: borrowed data escapes outside of associated function [INFO] [stdout] --> src/osmet/unpacker.rs:40:42 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn new(osmet: &Path, repo: &Path) -> Result { [INFO] [stdout] | ----- - let's call the lifetime of this reference `'1` [INFO] [stdout] | | [INFO] [stdout] | `osmet` is a reference that is only valid in the associated function body [INFO] [stdout] 40 | let (_, osmet, xzpacked_image) = osmet_file_read(osmet)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `osmet` escapes the associated function body here [INFO] [stdout] | argument requires that `'1` must outlive `'static` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0521]: borrowed data escapes outside of associated function [INFO] [stdout] --> src/osmet/unpacker.rs:45:42 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn new_from_sysroot(osmet: &Path) -> Result { [INFO] [stdout] | ----- - let's call the lifetime of this reference `'1` [INFO] [stdout] | | [INFO] [stdout] | `osmet` is a reference that is only valid in the associated function body [INFO] [stdout] 45 | let (_, osmet, xzpacked_image) = osmet_file_read(osmet)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `osmet` escapes the associated function body here [INFO] [stdout] | argument requires that `'1` must outlive `'static` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0521`. [INFO] [stdout] [INFO] [stderr] error: could not compile `coreos-installer` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error[E0521]: borrowed data escapes outside of associated function [INFO] [stdout] --> src/osmet/unpacker.rs:40:42 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn new(osmet: &Path, repo: &Path) -> Result { [INFO] [stdout] | ----- - let's call the lifetime of this reference `'1` [INFO] [stdout] | | [INFO] [stdout] | `osmet` is a reference that is only valid in the associated function body [INFO] [stdout] 40 | let (_, osmet, xzpacked_image) = osmet_file_read(osmet)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `osmet` escapes the associated function body here [INFO] [stdout] | argument requires that `'1` must outlive `'static` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0521]: borrowed data escapes outside of associated function [INFO] [stdout] --> src/osmet/unpacker.rs:45:42 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn new_from_sysroot(osmet: &Path) -> Result { [INFO] [stdout] | ----- - let's call the lifetime of this reference `'1` [INFO] [stdout] | | [INFO] [stdout] | `osmet` is a reference that is only valid in the associated function body [INFO] [stdout] 45 | let (_, osmet, xzpacked_image) = osmet_file_read(osmet)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `osmet` escapes the associated function body here [INFO] [stdout] | argument requires that `'1` must outlive `'static` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0521`. [INFO] [stdout] [INFO] [stderr] error: could not compile `coreos-installer` (lib test) due to 3 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "01c9cd224ba231beb96dc01f8ac3387909faa881a118ea8ba1e35a5c7b0e0222", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "01c9cd224ba231beb96dc01f8ac3387909faa881a118ea8ba1e35a5c7b0e0222", kill_on_drop: false }` [INFO] [stdout] 01c9cd224ba231beb96dc01f8ac3387909faa881a118ea8ba1e35a5c7b0e0222