[INFO] fetching crate coffeevis 0.5.1... [INFO] checking coffeevis-0.5.1 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate coffeevis 0.5.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate coffeevis 0.5.1 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate coffeevis 0.5.1 [INFO] finished tweaking crates.io crate coffeevis 0.5.1 [INFO] tweaked toml for crates.io crate coffeevis 0.5.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate coffeevis 0.5.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 912077b0537bb2146b7abc421e4468a1ababe476ada5ab912c32b7d84dfc4986 [INFO] running `Command { std: "docker" "start" "-a" "912077b0537bb2146b7abc421e4468a1ababe476ada5ab912c32b7d84dfc4986", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "912077b0537bb2146b7abc421e4468a1ababe476ada5ab912c32b7d84dfc4986", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "912077b0537bb2146b7abc421e4468a1ababe476ada5ab912c32b7d84dfc4986", kill_on_drop: false }` [INFO] [stdout] 912077b0537bb2146b7abc421e4468a1ababe476ada5ab912c32b7d84dfc4986 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ec0d00bbce60451ddaa4e8e868427264ae130ebaadc481b9dbf33984f6bd7b4c [INFO] running `Command { std: "docker" "start" "-a" "ec0d00bbce60451ddaa4e8e868427264ae130ebaadc481b9dbf33984f6bd7b4c", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking libloading v0.8.5 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Compiling cc v1.1.14 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking downcast-rs v1.2.1 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling wayland-client v0.31.5 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling wayland-sys v0.31.4 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling syn v2.0.75 [INFO] [stderr] Compiling quick-xml v0.34.0 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Compiling drm-sys v0.7.0 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking cursor-icon v1.1.0 [INFO] [stderr] Checking ttf-parser v0.24.1 [INFO] [stderr] Compiling drm-fourcc v2.2.0 [INFO] [stderr] Checking strict-num v0.1.1 [INFO] [stderr] Checking xcursor v0.3.8 [INFO] [stderr] Checking arrayref v0.3.8 [INFO] [stderr] Checking xkeysym v0.2.1 [INFO] [stderr] Compiling smithay-client-toolkit v0.19.2 [INFO] [stderr] Checking as-raw-xcb-connection v1.0.1 [INFO] [stderr] Checking linux-raw-sys v0.6.5 [INFO] [stderr] Compiling wayland-scanner v0.31.4 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling wayland-backend v0.3.6 [INFO] [stderr] Compiling tiny-xlib v0.2.3 [INFO] [stderr] Compiling x11-dl v2.21.0 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking x11rb-protocol v0.13.1 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.8 [INFO] [stderr] Compiling softbuffer v0.4.5 [INFO] [stderr] Compiling winit v0.30.5 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking raw-window-handle v0.6.2 [INFO] [stderr] Compiling cpal v0.15.3 [INFO] [stderr] Checking ctor-lite v0.1.0 [INFO] [stderr] Checking alsa v0.9.1 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking dasp_sample v0.11.0 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking smol_str v0.2.2 [INFO] [stderr] Checking dpi v0.1.1 [INFO] [stderr] Compiling bytemuck_derive v1.7.1 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking owned_ttf_parser v0.24.0 [INFO] [stderr] Checking ab_glyph v0.2.28 [INFO] [stderr] Checking bytemuck v1.17.0 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking polling v3.7.3 [INFO] [stderr] Checking drm-ffi v0.8.0 [INFO] [stderr] Checking drm v0.12.0 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Checking wayland-protocols v0.32.3 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Checking wayland-cursor v0.31.5 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.3 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.3 [INFO] [stderr] Checking x11rb v0.13.1 [INFO] [stderr] Checking sctk-adwaita v0.10.1 [INFO] [stderr] Checking coffeevis v0.5.1 (/tmp/fixit) [INFO] [stderr] Migrating src/main.rs from 2021 edition to 2024 [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/data/vislist.rs:12:15 [INFO] [stdout] | [INFO] [stdout] 12 | ($visfunc:expr, $name:literal, $request:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 12 | ($visfunc:expr_2021, $name:literal, $request:expr) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `coffeevis` [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/data/vislist.rs:12:45 [INFO] [stdout] | [INFO] [stdout] 12 | ($visfunc:expr, $name:literal, $request:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 12 | ($visfunc:expr, $name:literal, $request:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/data/reader.rs:268:13 [INFO] [stdout] | [INFO] [stdout] 268 | std::env::set_var("WAYLAND_DISPLAY", ""); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] = note: `--force-warn deprecated-safe-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 268 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 269 ~ unsafe { std::env::set_var("WAYLAND_DISPLAY", "") }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/modes/windowed_mode.rs:270:5 [INFO] [stdout] | [INFO] [stdout] 270 | std::env::set_var("WINIT_X11_SCALE_FACTOR", prog.scale().to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 270 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 271 ~ unsafe { std::env::set_var("WINIT_X11_SCALE_FACTOR", prog.scale().to_string()) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/main.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | std::env::set_var("LC_CTYPE", "en_US.utf8"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 36 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 37 ~ unsafe { std::env::set_var("LC_CTYPE", "en_US.utf8") }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] * src/data/reader.rs [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/modes/windowed_mode.rs:184:24 [INFO] [stdout] | [INFO] [stdout] 184 | if let Err(err) = self.window.drag_window() { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/modes/windowed_mode.rs:186:21 [INFO] [stdout] | [INFO] [stdout] 186 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 184 ~ match self.window.drag_window() { Err(err) => { [INFO] [stdout] 185 | eprintln!("Error starting window drag: {err}"); [INFO] [stdout] 186 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] * src/data/vislist.rs [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/modes/windowed_mode.rs:345:16 [INFO] [stdout] | [INFO] [stdout] 345 | if let Some(monitor) = window_updates.current_monitor() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^-------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/modes/windowed_mode.rs:358:13 [INFO] [stdout] | [INFO] [stdout] 358 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 345 ~ match window_updates.current_monitor() { Some(monitor) => { [INFO] [stdout] 346 | if let Some(milli_hz) = monitor.refresh_rate_millihertz() { [INFO] [stdout] ... [INFO] [stdout] 357 | } [INFO] [stdout] 358 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] * src/main.rs [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/modes/windowed_mode.rs:346:20 [INFO] [stdout] | [INFO] [stdout] 346 | if let Some(milli_hz) = monitor.refresh_rate_millihertz() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^-------^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/modes/windowed_mode.rs:357:17 [INFO] [stdout] | [INFO] [stdout] 357 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 346 ~ match monitor.refresh_rate_millihertz() { Some(milli_hz) => { [INFO] [stdout] 347 | let Ok(mut cmd) = commands_updates.try_write() else { [INFO] [stdout] ... [INFO] [stdout] 356 | return; [INFO] [stdout] 357 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] * src/modes/windowed_mode.rs [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/modes/windowed_mode.rs:488:20 [INFO] [stdout] | [INFO] [stdout] 488 | if let Ok(mut time) = average_render_time_draw.try_write() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/modes/windowed_mode.rs:490:17 [INFO] [stdout] | [INFO] [stdout] 490 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 488 ~ match average_render_time_draw.try_write() { Ok(mut time) => { [INFO] [stdout] 489 | *time += render_end - render_begin; [INFO] [stdout] 490 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stdout] warning: 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/data/vislist.rs:12:6 [INFO] [stderr] | [INFO] [stderr] 12 | ($visfunc:expr_2021, $name:literal, $request:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/data/vislist.rs:12:41 [INFO] [stderr] | [INFO] [stderr] 12 | ($visfunc:expr_2021, $name:literal, $request:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: usage of an `unsafe` block [INFO] [stderr] --> src/data/reader.rs:269:13 [INFO] [stderr] | [INFO] [stderr] 269 | unsafe { std::env::set_var("WAYLAND_DISPLAY", "") }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: the lint level is defined here [INFO] [stderr] --> src/main.rs:3:11 [INFO] [stderr] | [INFO] [stderr] 3 | #![forbid(unsafe_code)] [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: usage of an `unsafe` block [INFO] [stderr] --> src/modes/windowed_mode.rs:271:5 [INFO] [stderr] | [INFO] [stderr] 271 | unsafe { std::env::set_var("WINIT_X11_SCALE_FACTOR", prog.scale().to_string()) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: usage of an `unsafe` block [INFO] [stderr] --> src/main.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | unsafe { std::env::set_var("LC_CTYPE", "en_US.utf8") }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `coffeevis` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/data/reader.rs [INFO] [stderr] * src/data/vislist.rs [INFO] [stderr] * src/main.rs [INFO] [stderr] * src/modes/windowed_mode.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/data/vislist.rs:12:6 [INFO] [stderr] | [INFO] [stderr] 12 | ($visfunc:expr_2021, $name:literal, $request:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/data/vislist.rs:12:41 [INFO] [stderr] | [INFO] [stderr] 12 | ($visfunc:expr_2021, $name:literal, $request:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: usage of an `unsafe` block [INFO] [stderr] --> src/data/reader.rs:269:13 [INFO] [stderr] | [INFO] [stderr] 269 | unsafe { std::env::set_var("WAYLAND_DISPLAY", "") }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: the lint level is defined here [INFO] [stderr] --> src/main.rs:3:11 [INFO] [stderr] | [INFO] [stderr] 3 | #![forbid(unsafe_code)] [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: usage of an `unsafe` block [INFO] [stderr] --> src/modes/windowed_mode.rs:271:5 [INFO] [stderr] | [INFO] [stderr] 271 | unsafe { std::env::set_var("WINIT_X11_SCALE_FACTOR", prog.scale().to_string()) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: usage of an `unsafe` block [INFO] [stderr] --> src/main.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | unsafe { std::env::set_var("LC_CTYPE", "en_US.utf8") }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 32.33s [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/data/vislist.rs:12:15 [INFO] [stdout] | [INFO] [stdout] 12 | ($visfunc:expr, $name:literal, $request:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 12 | ($visfunc:expr_2021, $name:literal, $request:expr) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/data/vislist.rs:12:45 [INFO] [stdout] | [INFO] [stdout] 12 | ($visfunc:expr, $name:literal, $request:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 12 | ($visfunc:expr, $name:literal, $request:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/data/reader.rs:268:13 [INFO] [stdout] | [INFO] [stdout] 268 | std::env::set_var("WAYLAND_DISPLAY", ""); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] = note: `--force-warn deprecated-safe-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 268 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 269 ~ unsafe { std::env::set_var("WAYLAND_DISPLAY", "") }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/modes/windowed_mode.rs:270:5 [INFO] [stdout] | [INFO] [stdout] 270 | std::env::set_var("WINIT_X11_SCALE_FACTOR", prog.scale().to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 270 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 271 ~ unsafe { std::env::set_var("WINIT_X11_SCALE_FACTOR", prog.scale().to_string()) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/main.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | std::env::set_var("LC_CTYPE", "en_US.utf8"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 36 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 37 ~ unsafe { std::env::set_var("LC_CTYPE", "en_US.utf8") }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/modes/windowed_mode.rs:184:24 [INFO] [stdout] | [INFO] [stdout] 184 | if let Err(err) = self.window.drag_window() { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/modes/windowed_mode.rs:186:21 [INFO] [stdout] | [INFO] [stdout] 186 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 184 ~ match self.window.drag_window() { Err(err) => { [INFO] [stdout] 185 | eprintln!("Error starting window drag: {err}"); [INFO] [stdout] 186 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/modes/windowed_mode.rs:345:16 [INFO] [stdout] | [INFO] [stdout] 345 | if let Some(monitor) = window_updates.current_monitor() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^-------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/modes/windowed_mode.rs:358:13 [INFO] [stdout] | [INFO] [stdout] 358 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 345 ~ match window_updates.current_monitor() { Some(monitor) => { [INFO] [stdout] 346 | if let Some(milli_hz) = monitor.refresh_rate_millihertz() { [INFO] [stdout] ... [INFO] [stdout] 357 | } [INFO] [stdout] 358 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/modes/windowed_mode.rs:346:20 [INFO] [stdout] | [INFO] [stdout] 346 | if let Some(milli_hz) = monitor.refresh_rate_millihertz() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^-------^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/modes/windowed_mode.rs:357:17 [INFO] [stdout] | [INFO] [stdout] 357 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 346 ~ match monitor.refresh_rate_millihertz() { Some(milli_hz) => { [INFO] [stdout] 347 | let Ok(mut cmd) = commands_updates.try_write() else { [INFO] [stdout] ... [INFO] [stdout] 356 | return; [INFO] [stdout] 357 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/modes/windowed_mode.rs:488:20 [INFO] [stdout] | [INFO] [stdout] 488 | if let Ok(mut time) = average_render_time_draw.try_write() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/modes/windowed_mode.rs:490:17 [INFO] [stdout] | [INFO] [stdout] 490 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 488 ~ match average_render_time_draw.try_write() { Ok(mut time) => { [INFO] [stdout] 489 | *time += render_end - render_begin; [INFO] [stdout] 490 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking coffeevis v0.5.1 (/tmp/fixit) [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/data/reader.rs:268:13 [INFO] [stdout] | [INFO] [stdout] 268 | std::env::set_var("WAYLAND_DISPLAY", ""); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/data/reader.rs:268:13 [INFO] [stdout] | [INFO] [stdout] 268 | std::env::set_var("WAYLAND_DISPLAY", ""); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe function or block [INFO] [stdout] --> src/modes/windowed_mode.rs:270:5 [INFO] [stdout] | [INFO] [stdout] 270 | std::env::set_var("WINIT_X11_SCALE_FACTOR", prog.scale().to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe function or block [INFO] [stdout] --> src/modes/windowed_mode.rs:270:5 [INFO] [stdout] | [INFO] [stdout] 270 | std::env::set_var("WINIT_X11_SCALE_FACTOR", prog.scale().to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/main.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | std::env::set_var("LC_CTYPE", "en_US.utf8"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/main.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | std::env::set_var("LC_CTYPE", "en_US.utf8"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stderr] error: could not compile `coffeevis` (bin "coffeevis") due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `coffeevis` (bin "coffeevis" test) due to 4 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "ec0d00bbce60451ddaa4e8e868427264ae130ebaadc481b9dbf33984f6bd7b4c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ec0d00bbce60451ddaa4e8e868427264ae130ebaadc481b9dbf33984f6bd7b4c", kill_on_drop: false }` [INFO] [stdout] ec0d00bbce60451ddaa4e8e868427264ae130ebaadc481b9dbf33984f6bd7b4c