[INFO] fetching crate cargo-fixture 1.2.2... [INFO] checking cargo-fixture-1.2.2 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate cargo-fixture 1.2.2 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate cargo-fixture 1.2.2 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cargo-fixture 1.2.2 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate cargo-fixture 1.2.2 [INFO] tweaked toml for crates.io crate cargo-fixture 1.2.2 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate cargo-fixture 1.2.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 59fe9afbed79f69183273cd26f0d906bef6b830a2e6ec16aa873981faae90249 [INFO] running `Command { std: "docker" "start" "-a" "59fe9afbed79f69183273cd26f0d906bef6b830a2e6ec16aa873981faae90249", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "59fe9afbed79f69183273cd26f0d906bef6b830a2e6ec16aa873981faae90249", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "59fe9afbed79f69183273cd26f0d906bef6b830a2e6ec16aa873981faae90249", kill_on_drop: false }` [INFO] [stdout] 59fe9afbed79f69183273cd26f0d906bef6b830a2e6ec16aa873981faae90249 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 939593aded9b6e04878f429ed806504fe3525a30a1b3d25b30c94b04008de0b9 [INFO] running `Command { std: "docker" "start" "-a" "939593aded9b6e04878f429ed806504fe3525a30a1b3d25b30c94b04008de0b9", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling proc-macro2 v1.0.83 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling rustix v0.37.27 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Checking async-lock v2.8.0 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking piper v0.2.2 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Compiling async-fs v1.6.0 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Compiling serde v1.0.202 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking event-listener v4.0.3 [INFO] [stderr] Checking event-listener v5.3.0 [INFO] [stderr] Checking event-listener v3.1.0 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Checking event-listener-strategy v0.4.0 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Checking unicode-width v0.1.12 [INFO] [stderr] Checking async-executor v1.11.0 [INFO] [stderr] Checking tabular v0.2.0 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking async-lock v3.3.0 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking os_str_bytes v7.0.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking blocking v1.6.0 [INFO] [stderr] Compiling syn v2.0.65 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking ctrlc v3.4.4 [INFO] [stderr] Checking async-net v1.8.0 [INFO] [stderr] Compiling smol-potat-macro v0.6.0 [INFO] [stderr] Checking polling v3.7.0 [INFO] [stderr] Checking smol-potat v1.1.2 [INFO] [stderr] Checking async-io v2.3.2 [INFO] [stderr] Checking async-signal v0.2.6 [INFO] [stderr] Checking async-process v1.8.1 [INFO] [stderr] Compiling serde_derive v1.0.202 [INFO] [stderr] Compiling strum_macros v0.25.3 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling cargo-fixture-macros v1.2.2 [INFO] [stderr] Checking smol v1.3.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking strum v0.25.0 [INFO] [stderr] Checking cargo-fixture-lib v1.2.2 [INFO] [stderr] Checking cargo-fixture v1.2.2 (/tmp/fixit) [INFO] [stderr] Migrating src/main.rs from 2021 edition to 2024 [INFO] [stderr] Migrating tests/basics.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `cargo_fixture` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/cli/flags.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/cli/flags.rs:64:12 [INFO] [stderr] | [INFO] [stderr] 64 | [$($acc:expr_2021,)*] [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/cli/flags.rs:86:29 [INFO] [stderr] | [INFO] [stderr] 86 | (@flag $output:ident [$($acc:expr_2021,)*]) => { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/cli/flags.rs:64:17 [INFO] [stdout] | [INFO] [stdout] 64 | [$($acc:expr,)*] [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 64 | [$($acc:expr_2021,)*] [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/cli/flags.rs:86:34 [INFO] [stdout] | [INFO] [stdout] 86 | (@flag $output:ident [$($acc:expr,)*]) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 86 | (@flag $output:ident [$($acc:expr_2021,)*]) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/config.rs:27:17 [INFO] [stdout] | [INFO] [stdout] 27 | env::set_var("CARGO", "cargo"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] = note: `--force-warn deprecated-safe-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 27 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 28 ~ unsafe { env::set_var("CARGO", "cargo") }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/server.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 143 | env::set_var(name, value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 143 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 144 ~ unsafe { env::set_var(name, value) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/main.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | env::set_var(ENV_CARGO_FIXTURE, "1"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 29 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 30 ~ unsafe { env::set_var(ENV_CARGO_FIXTURE, "1") }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/main.rs:99:27 [INFO] [stdout] | [INFO] [stdout] 99 | return if let Ok(0) = test_res { [INFO] [stdout] | ^^^^^^^^^^^^-------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/main.rs:101:17 [INFO] [stdout] | [INFO] [stdout] 101 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 99 ~ return match test_res { Ok(0) => { [INFO] [stdout] 100 | res.map(|_| 0) [INFO] [stdout] 101 ~ } _ => { [INFO] [stdout] 102 | test_res [INFO] [stdout] 103 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/cli/parser.rs:152:16 [INFO] [stdout] | [INFO] [stdout] 152 | if let Some(cargo_ext) = iter.next_if(|arg| arg.as_os_str() == cargo_ext.as_str()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/cli/parser.rs:154:13 [INFO] [stdout] | [INFO] [stdout] 154 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 152 ~ match iter.next_if(|arg| arg.as_os_str() == cargo_ext.as_str()) { Some(cargo_ext) => { [INFO] [stdout] 153 | deq.push_back(NormalizedArg::CargoExt(cargo_ext)); [INFO] [stdout] 154 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/fixture_program.rs:117:12 [INFO] [stdout] | [INFO] [stdout] 117 | if let Err(err) = self.child.kill() { [INFO] [stdout] | ^^^^^^^^^^^^^^^----------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/fixture_program.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 119 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 117 ~ match self.child.kill() { Err(err) => { [INFO] [stdout] 118 | error!("Failed to kill fixture process: {err:?}"); [INFO] [stdout] 119 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/server.rs:220:12 [INFO] [stdout] | [INFO] [stdout] 220 | if let Err(err) = self.run_inner().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/server.rs:222:9 [INFO] [stdout] | [INFO] [stdout] 222 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 220 ~ match self.run_inner().await { Err(err) => { [INFO] [stdout] 221 | warn!("Test connection error: {err}"); [INFO] [stdout] 222 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/utils.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 24 | if let Err(err) = self { [INFO] [stdout] | ^^^^^^^^^^^^^^^---- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/utils.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 24 ~ match self { Err(err) => { [INFO] [stdout] 25 | error!("{err:?}") [INFO] [stdout] 26 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/utils.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 81 | if let Err(err) = fs::remove_file(p) { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/utils.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 81 ~ match fs::remove_file(p) { Err(err) => { [INFO] [stdout] 82 | warn!("could not remove file `{}`: {}", p.display(), err); [INFO] [stdout] 83 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/utils.rs:176:16 [INFO] [stdout] | [INFO] [stdout] 176 | if let Some(timestamp) = ready!(this.rx.poll_next_unpin(cx)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/utils.rs:181:13 [INFO] [stdout] | [INFO] [stdout] 181 | } else { [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Fixed tests/common/mod.rs (1 fix) [INFO] [stderr] Migrating tests/serial.rs from 2021 edition to 2024 [INFO] [stderr] Migrating tests/args.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `cargo_fixture` [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/cli/flags.rs:64:17 [INFO] [stdout] | [INFO] [stdout] 64 | [$($acc:expr,)*] [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 64 | [$($acc:expr_2021,)*] [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/cli/flags.rs:86:34 [INFO] [stdout] | [INFO] [stdout] 86 | (@flag $output:ident [$($acc:expr,)*]) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 86 | (@flag $output:ident [$($acc:expr_2021,)*]) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/config.rs:27:17 [INFO] [stdout] | [INFO] [stdout] 27 | env::set_var("CARGO", "cargo"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] = note: `--force-warn deprecated-safe-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 27 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 28 ~ unsafe { env::set_var("CARGO", "cargo") }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] * src/cli/flags.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/server.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 143 | env::set_var(name, value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 143 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 144 ~ unsafe { env::set_var(name, value) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/main.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | env::set_var(ENV_CARGO_FIXTURE, "1"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 29 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 30 ~ unsafe { env::set_var(ENV_CARGO_FIXTURE, "1") }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/cli/flags.rs:64:12 [INFO] [stderr] | [INFO] [stderr] 64 | [$($acc:expr_2021,)*] [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/cli/flags.rs:86:29 [INFO] [stderr] | [INFO] [stderr] 86 | (@flag $output:ident [$($acc:expr_2021,)*]) => { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/main.rs:99:27 [INFO] [stdout] | [INFO] [stdout] 99 | return if let Ok(0) = test_res { [INFO] [stdout] | ^^^^^^^^^^^^-------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/main.rs:101:17 [INFO] [stdout] | [INFO] [stdout] 101 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 99 ~ return match test_res { Ok(0) => { [INFO] [stdout] 100 | res.map(|_| 0) [INFO] [stdout] 101 ~ } _ => { [INFO] [stdout] 102 | test_res [INFO] [stdout] 103 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/cli/parser.rs:152:16 [INFO] [stdout] | [INFO] [stdout] 152 | if let Some(cargo_ext) = iter.next_if(|arg| arg.as_os_str() == cargo_ext.as_str()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/cli/parser.rs:154:13 [INFO] [stdout] | [INFO] [stdout] 154 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 152 ~ match iter.next_if(|arg| arg.as_os_str() == cargo_ext.as_str()) { Some(cargo_ext) => { [INFO] [stdout] 153 | deq.push_back(NormalizedArg::CargoExt(cargo_ext)); [INFO] [stdout] 154 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/fixture_program.rs:117:12 [INFO] [stdout] | [INFO] [stdout] 117 | if let Err(err) = self.child.kill() { [INFO] [stdout] | ^^^^^^^^^^^^^^^----------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/fixture_program.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 119 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 117 ~ match self.child.kill() { Err(err) => { [INFO] [stdout] 118 | error!("Failed to kill fixture process: {err:?}"); [INFO] [stdout] 119 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/server.rs:220:12 [INFO] [stdout] | [INFO] [stdout] 220 | if let Err(err) = self.run_inner().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/server.rs:222:9 [INFO] [stdout] | [INFO] [stdout] 222 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 220 ~ match self.run_inner().await { Err(err) => { [INFO] [stdout] 221 | warn!("Test connection error: {err}"); [INFO] [stdout] 222 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/utils.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 24 | if let Err(err) = self { [INFO] [stdout] | ^^^^^^^^^^^^^^^---- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/utils.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 24 ~ match self { Err(err) => { [INFO] [stdout] 25 | error!("{err:?}") [INFO] [stdout] 26 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/utils.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 81 | if let Err(err) = fs::remove_file(p) { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/utils.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 81 ~ match fs::remove_file(p) { Err(err) => { [INFO] [stdout] 82 | warn!("could not remove file `{}`: {}", p.display(), err); [INFO] [stdout] 83 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/utils.rs:176:16 [INFO] [stdout] | [INFO] [stdout] 176 | if let Some(timestamp) = ready!(this.rx.poll_next_unpin(cx)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/utils.rs:181:13 [INFO] [stdout] | [INFO] [stdout] 181 | } else { [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.97s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking cargo-fixture v1.2.2 (/tmp/fixit) [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/config.rs:27:17 [INFO] [stdout] | [INFO] [stdout] 27 | env::set_var("CARGO", "cargo"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/config.rs:27:17 [INFO] [stdout] | [INFO] [stdout] 27 | env::set_var("CARGO", "cargo"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/server.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 143 | env::set_var(name, value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/server.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 143 | env::set_var(name, value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/main.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | env::set_var(ENV_CARGO_FIXTURE, "1"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/main.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | env::set_var(ENV_CARGO_FIXTURE, "1"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stderr] error: could not compile `cargo-fixture` (bin "cargo-fixture") due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `cargo-fixture` (bin "cargo-fixture" test) due to 4 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "939593aded9b6e04878f429ed806504fe3525a30a1b3d25b30c94b04008de0b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "939593aded9b6e04878f429ed806504fe3525a30a1b3d25b30c94b04008de0b9", kill_on_drop: false }` [INFO] [stdout] 939593aded9b6e04878f429ed806504fe3525a30a1b3d25b30c94b04008de0b9