[INFO] fetching crate boa_ast 0.19.1... [INFO] checking boa_ast-0.19.1 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate boa_ast 0.19.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate boa_ast 0.19.1 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate boa_ast 0.19.1 [INFO] finished tweaking crates.io crate boa_ast 0.19.1 [INFO] tweaked toml for crates.io crate boa_ast 0.19.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 36 packages to latest compatible versions [INFO] [stderr] Adding siphasher v0.3.11 (available: v1.0.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 43a95c8707662a07b2a762562410a7c56f90e51e059c4eb061cfca165d3d8dca [INFO] running `Command { std: "docker" "start" "-a" "43a95c8707662a07b2a762562410a7c56f90e51e059c4eb061cfca165d3d8dca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "43a95c8707662a07b2a762562410a7c56f90e51e059c4eb061cfca165d3d8dca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "43a95c8707662a07b2a762562410a7c56f90e51e059c4eb061cfca165d3d8dca", kill_on_drop: false }` [INFO] [stdout] 43a95c8707662a07b2a762562410a7c56f90e51e059c4eb061cfca165d3d8dca [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aa439e30070e330c9adcd728b2e5b8442e5a45326e0d988949f8341e844f7ced [INFO] running `Command { std: "docker" "start" "-a" "aa439e30070e330c9adcd728b2e5b8442e5a45326e0d988949f8341e844f7ced", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking boa_profiler v0.19.1 [INFO] [stderr] Checking rustc-hash v2.0.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling boa_macros v0.19.1 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Compiling phf_macros v0.11.2 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking boa_gc v0.19.1 [INFO] [stderr] Checking boa_interner v0.19.1 [INFO] [stderr] Checking boa_ast v0.19.1 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `boa_ast` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/visitor.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/visitor.rs:49:6 [INFO] [stderr] | [INFO] [stderr] 49 | ($expr:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/expression/mod.rs:196:29 [INFO] [stdout] | [INFO] [stdout] 196 | Self::Generator(gen) => gen.to_indented_string(interner, indentation), [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/expression/mod.rs:196:37 [INFO] [stdout] | [INFO] [stdout] 196 | Self::Generator(gen) => gen.to_indented_string(interner, indentation), [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/visitor.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 49 | ($expr:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 49 | ($expr:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/expression/yield.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 73 | if let Some(expr) = &self.target { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^----------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/expression/yield.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 73 ~ match &self.target { Some(expr) => { [INFO] [stdout] 74 | visitor.visit_expression(expr) [INFO] [stdout] 75 ~ } _ => { [INFO] [stdout] 76 | ControlFlow::Continue(()) [INFO] [stdout] 77 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/expression/yield.rs:84:12 [INFO] [stdout] | [INFO] [stdout] 84 | if let Some(expr) = &mut self.target { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^----------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/expression/yield.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 84 ~ match &mut self.target { Some(expr) => { [INFO] [stdout] 85 | visitor.visit_expression_mut(expr) [INFO] [stdout] 86 ~ } _ => { [INFO] [stdout] 87 | ControlFlow::Continue(()) [INFO] [stdout] 88 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/operations.rs:1280:16 [INFO] [stdout] | [INFO] [stdout] 1280 | if let Some(continue_labels) = &mut self.continue_labels { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/operations.rs:1282:13 [INFO] [stdout] | [INFO] [stdout] 1282 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 1280 ~ match &mut self.continue_labels { Some(continue_labels) => { [INFO] [stdout] 1281 | continue_labels.insert(node.label()); [INFO] [stdout] 1282 ~ } _ => { [INFO] [stdout] 1283 | let mut continue_labels = FxHashSet::default(); [INFO] [stdout] 1284 | continue_labels.insert(node.label()); [INFO] [stdout] 1285 | self.continue_labels = Some(continue_labels); [INFO] [stdout] 1286 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/operations.rs:1347:8 [INFO] [stdout] | [INFO] [stdout] 1347 | if let ControlFlow::Break(error) = node.visit_with(&mut visitor) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/operations.rs:1349:5 [INFO] [stdout] | [INFO] [stdout] 1349 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 1347 ~ match node.visit_with(&mut visitor) { ControlFlow::Break(error) => { [INFO] [stdout] 1348 | Err(error) [INFO] [stdout] 1349 ~ } _ => { [INFO] [stdout] 1350 | Ok(()) [INFO] [stdout] 1351 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/statement/return.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 67 | if let Some(expr) = &self.target { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^----------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/statement/return.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 67 ~ match &self.target { Some(expr) => { [INFO] [stdout] 68 | visitor.visit_expression(expr) [INFO] [stdout] 69 ~ } _ => { [INFO] [stdout] 70 | ControlFlow::Continue(()) [INFO] [stdout] 71 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/statement/return.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 78 | if let Some(expr) = &mut self.target { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^----------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/statement/return.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 80 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 78 ~ match &mut self.target { Some(expr) => { [INFO] [stdout] 79 | visitor.visit_expression_mut(expr) [INFO] [stdout] 80 ~ } _ => { [INFO] [stdout] 81 | ControlFlow::Continue(()) [INFO] [stdout] 82 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `boa_ast` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/visitor.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/expression/mod.rs:196:29 [INFO] [stdout] | [INFO] [stdout] 196 | Self::Generator(gen) => gen.to_indented_string(interner, indentation), [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] --> src/visitor.rs:49:6 [INFO] [stderr] | [INFO] [stderr] 49 | ($expr:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/expression/mod.rs:196:37 [INFO] [stdout] | [INFO] [stdout] 196 | Self::Generator(gen) => gen.to_indented_string(interner, indentation), [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/visitor.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 49 | ($expr:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 49 | ($expr:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/expression/yield.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 73 | if let Some(expr) = &self.target { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^----------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/expression/yield.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 73 ~ match &self.target { Some(expr) => { [INFO] [stdout] 74 | visitor.visit_expression(expr) [INFO] [stdout] 75 ~ } _ => { [INFO] [stdout] 76 | ControlFlow::Continue(()) [INFO] [stdout] 77 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/expression/yield.rs:84:12 [INFO] [stdout] | [INFO] [stdout] 84 | if let Some(expr) = &mut self.target { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^----------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/expression/yield.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 84 ~ match &mut self.target { Some(expr) => { [INFO] [stdout] 85 | visitor.visit_expression_mut(expr) [INFO] [stdout] 86 ~ } _ => { [INFO] [stdout] 87 | ControlFlow::Continue(()) [INFO] [stdout] 88 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/operations.rs:1280:16 [INFO] [stdout] | [INFO] [stdout] 1280 | if let Some(continue_labels) = &mut self.continue_labels { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/operations.rs:1282:13 [INFO] [stdout] | [INFO] [stdout] 1282 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 1280 ~ match &mut self.continue_labels { Some(continue_labels) => { [INFO] [stdout] 1281 | continue_labels.insert(node.label()); [INFO] [stdout] 1282 ~ } _ => { [INFO] [stdout] 1283 | let mut continue_labels = FxHashSet::default(); [INFO] [stdout] 1284 | continue_labels.insert(node.label()); [INFO] [stdout] 1285 | self.continue_labels = Some(continue_labels); [INFO] [stdout] 1286 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/operations.rs:1347:8 [INFO] [stdout] | [INFO] [stdout] 1347 | if let ControlFlow::Break(error) = node.visit_with(&mut visitor) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/operations.rs:1349:5 [INFO] [stdout] | [INFO] [stdout] 1349 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 1347 ~ match node.visit_with(&mut visitor) { ControlFlow::Break(error) => { [INFO] [stdout] 1348 | Err(error) [INFO] [stdout] 1349 ~ } _ => { [INFO] [stdout] 1350 | Ok(()) [INFO] [stdout] 1351 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/statement/return.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 67 | if let Some(expr) = &self.target { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^----------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/statement/return.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 67 ~ match &self.target { Some(expr) => { [INFO] [stdout] 68 | visitor.visit_expression(expr) [INFO] [stdout] 69 ~ } _ => { [INFO] [stdout] 70 | ControlFlow::Continue(()) [INFO] [stdout] 71 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/statement/return.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 78 | if let Some(expr) = &mut self.target { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^----------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/statement/return.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 80 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 78 ~ match &mut self.target { Some(expr) => { [INFO] [stdout] 79 | visitor.visit_expression_mut(expr) [INFO] [stdout] 80 ~ } _ => { [INFO] [stdout] 81 | ControlFlow::Continue(()) [INFO] [stdout] 82 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.44s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking boa_ast v0.19.1 (/tmp/fixit) [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/expression/mod.rs:196:29 [INFO] [stdout] | [INFO] [stdout] 196 | Self::Generator(gen) => gen.to_indented_string(interner, indentation), [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 196 | Self::Generator(r#gen) => gen.to_indented_string(interner, indentation), [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/expression/mod.rs:196:29 [INFO] [stdout] | [INFO] [stdout] 196 | Self::Generator(gen) => gen.to_indented_string(interner, indentation), [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 196 | Self::Generator(r#gen) => gen.to_indented_string(interner, indentation), [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected expression, found reserved keyword `gen` [INFO] [stdout] --> src/expression/mod.rs:196:37 [INFO] [stdout] | [INFO] [stdout] 196 | Self::Generator(gen) => gen.to_indented_string(interner, indentation), [INFO] [stdout] | -- ^^^ expected expression [INFO] [stdout] | | [INFO] [stdout] | while parsing the `match` arm starting here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected expression, found reserved keyword `gen` [INFO] [stdout] --> src/expression/mod.rs:196:37 [INFO] [stdout] | [INFO] [stdout] 196 | Self::Generator(gen) => gen.to_indented_string(interner, indentation), [INFO] [stdout] | -- ^^^ expected expression [INFO] [stdout] | | [INFO] [stdout] | while parsing the `match` arm starting here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `boa_ast` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `boa_ast` (lib test) due to 3 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "aa439e30070e330c9adcd728b2e5b8442e5a45326e0d988949f8341e844f7ced", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aa439e30070e330c9adcd728b2e5b8442e5a45326e0d988949f8341e844f7ced", kill_on_drop: false }` [INFO] [stdout] aa439e30070e330c9adcd728b2e5b8442e5a45326e0d988949f8341e844f7ced