[INFO] fetching crate blocking 1.6.1... [INFO] checking blocking-1.6.1 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate blocking 1.6.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate blocking 1.6.1 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate blocking 1.6.1 [INFO] finished tweaking crates.io crate blocking 1.6.1 [INFO] tweaked toml for crates.io crate blocking 1.6.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate blocking 1.6.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5d25c86a3585f02f644987a9d7c31a3312b066da2ccdf4c726ca9f6d37c8c504 [INFO] running `Command { std: "docker" "start" "-a" "5d25c86a3585f02f644987a9d7c31a3312b066da2ccdf4c726ca9f6d37c8c504", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5d25c86a3585f02f644987a9d7c31a3312b066da2ccdf4c726ca9f6d37c8c504", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5d25c86a3585f02f644987a9d7c31a3312b066da2ccdf4c726ca9f6d37c8c504", kill_on_drop: false }` [INFO] [stdout] 5d25c86a3585f02f644987a9d7c31a3312b066da2ccdf4c726ca9f6d37c8c504 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 089dd3c19d07bbb0c0b2795aeb327a1213fa619672030b8d8e4ce5008bbae327 [INFO] running `Command { std: "docker" "start" "-a" "089dd3c19d07bbb0c0b2795aeb327a1213fa619672030b8d8e4ce5008bbae327", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Fixed Cargo.toml (1 fix) [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling futures-core v0.3.29 [INFO] [stderr] Checking futures-io v0.3.29 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking waker-fn v1.1.1 [INFO] [stderr] Checking async-task v4.5.0 [INFO] [stderr] Checking piper v0.2.1 [INFO] [stderr] Checking concurrent-queue v2.3.0 [INFO] [stderr] Checking event-listener v3.0.1 [INFO] [stderr] Checking futures-lite v2.0.0 [INFO] [stderr] Checking event-listener-strategy v0.3.0 [INFO] [stderr] Checking async-channel v2.0.0 [INFO] [stderr] Checking blocking v1.6.1 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Fixed src/lib.rs (1 fix) [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/lib.rs:246:19 [INFO] [stdout] | [INFO] [stdout] 246 | while let Some(runnable) = inner.queue().pop_front() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/lib.rs:255:13 [INFO] [stdout] | [INFO] [stdout] 255 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating examples/ls.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `blocking` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/lib.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error: usage of an `unsafe` block [INFO] [stderr] --> src/lib.rs:1007:9 [INFO] [stderr] | [INFO] [stderr] 1007 | unsafe { env::set_var(MAX_THREADS_ENV, "100") }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: the lint level is defined here [INFO] [stderr] --> src/lib.rs:79:11 [INFO] [stderr] | [INFO] [stderr] 79 | #![forbid(unsafe_code)] [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: usage of an `unsafe` block [INFO] [stderr] --> src/lib.rs:1012:9 [INFO] [stderr] | [INFO] [stderr] 1012 | unsafe { env::set_var(MAX_THREADS_ENV, "0") }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: usage of an `unsafe` block [INFO] [stderr] --> src/lib.rs:1017:9 [INFO] [stderr] | [INFO] [stderr] 1017 | unsafe { env::set_var(MAX_THREADS_ENV, "50000") }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: usage of an `unsafe` block [INFO] [stderr] --> src/lib.rs:1022:9 [INFO] [stderr] | [INFO] [stderr] 1022 | unsafe { env::set_var(MAX_THREADS_ENV, "") }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: usage of an `unsafe` block [INFO] [stderr] --> src/lib.rs:1027:9 [INFO] [stderr] | [INFO] [stderr] 1027 | unsafe { env::set_var(MAX_THREADS_ENV, "NOTINT") }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stderr] --> src/lib.rs:246:19 [INFO] [stderr] | [INFO] [stderr] 246 | while let Some(runnable) = inner.queue().pop_front() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^------------------------- [INFO] [stderr] | | [INFO] [stderr] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stderr] | [INFO] [stderr] = warning: this changes meaning in Rust 2024 [INFO] [stderr] = note: for more information, see issue #124085 [INFO] [stderr] help: the value is now dropped here in Edition 2024 [INFO] [stderr] --> src/lib.rs:255:13 [INFO] [stderr] | [INFO] [stderr] 255 | } [INFO] [stderr] | ^ [INFO] [stderr] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stderr] [INFO] [stderr] Original diagnostics will follow. [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/lib.rs:1006:9 [INFO] [stdout] | [INFO] [stdout] 1006 | env::set_var(MAX_THREADS_ENV, "100"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] = note: `--force-warn deprecated-safe-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 1006 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 1007 ~ unsafe { env::set_var(MAX_THREADS_ENV, "100") }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/lib.rs:1010:9 [INFO] [stdout] | [INFO] [stdout] 1010 | env::set_var(MAX_THREADS_ENV, "0"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 1010 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 1011 ~ unsafe { env::set_var(MAX_THREADS_ENV, "0") }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/lib.rs:1014:9 [INFO] [stdout] | [INFO] [stdout] 1014 | env::set_var(MAX_THREADS_ENV, "50000"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 1014 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 1015 ~ unsafe { env::set_var(MAX_THREADS_ENV, "50000") }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/lib.rs:1018:9 [INFO] [stdout] | [INFO] [stdout] 1018 | env::set_var(MAX_THREADS_ENV, ""); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 1018 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 1019 ~ unsafe { env::set_var(MAX_THREADS_ENV, "") }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/lib.rs:1022:9 [INFO] [stdout] | [INFO] [stdout] 1022 | env::set_var(MAX_THREADS_ENV, "NOTINT"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 1022 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 1023 ~ unsafe { env::set_var(MAX_THREADS_ENV, "NOTINT") }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/lib.rs:246:19 [INFO] [stdout] | [INFO] [stdout] 246 | while let Some(runnable) = inner.queue().pop_front() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/lib.rs:255:13 [INFO] [stdout] | [INFO] [stdout] 255 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> examples/ls.rs:20:15 [INFO] [stdout] | [INFO] [stdout] 20 | while let Some(item) = dir.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^---------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> examples/ls.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating tests/unblock.rs from 2021 edition to 2024 [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Fixed tests/unblock.rs (2 fixes) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.49s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking blocking v1.6.1 (/tmp/fixit) [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/lib.rs:1006:9 [INFO] [stdout] | [INFO] [stdout] 1006 | env::set_var(MAX_THREADS_ENV, "100"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/lib.rs:1010:9 [INFO] [stdout] | [INFO] [stdout] 1010 | env::set_var(MAX_THREADS_ENV, "0"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/lib.rs:1014:9 [INFO] [stdout] | [INFO] [stdout] 1014 | env::set_var(MAX_THREADS_ENV, "50000"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/lib.rs:1018:9 [INFO] [stdout] | [INFO] [stdout] 1018 | env::set_var(MAX_THREADS_ENV, ""); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/lib.rs:1022:9 [INFO] [stdout] | [INFO] [stdout] 1022 | env::set_var(MAX_THREADS_ENV, "NOTINT"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stderr] error: could not compile `blocking` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "089dd3c19d07bbb0c0b2795aeb327a1213fa619672030b8d8e4ce5008bbae327", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "089dd3c19d07bbb0c0b2795aeb327a1213fa619672030b8d8e4ce5008bbae327", kill_on_drop: false }` [INFO] [stdout] 089dd3c19d07bbb0c0b2795aeb327a1213fa619672030b8d8e4ce5008bbae327