[INFO] fetching crate biome_analyze 0.5.7... [INFO] checking biome_analyze-0.5.7 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate biome_analyze 0.5.7 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate biome_analyze 0.5.7 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate biome_analyze 0.5.7 [INFO] finished tweaking crates.io crate biome_analyze 0.5.7 [INFO] tweaked toml for crates.io crate biome_analyze 0.5.7 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 82 packages to latest compatible versions [INFO] [stderr] Adding hashbrown v0.12.3 (available: v0.14.5) [INFO] [stderr] Adding memoffset v0.8.0 (available: v0.9.1) [INFO] [stderr] Adding rustc-hash v1.1.0 (available: v2.0.0) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1c06cd7605ace4785afc281cf2699003a05f85241d7b60030cfb386a9cfd7c12 [INFO] running `Command { std: "docker" "start" "-a" "1c06cd7605ace4785afc281cf2699003a05f85241d7b60030cfb386a9cfd7c12", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1c06cd7605ace4785afc281cf2699003a05f85241d7b60030cfb386a9cfd7c12", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1c06cd7605ace4785afc281cf2699003a05f85241d7b60030cfb386a9cfd7c12", kill_on_drop: false }` [INFO] [stdout] 1c06cd7605ace4785afc281cf2699003a05f85241d7b60030cfb386a9cfd7c12 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 56bc0652f28688ed9a71431eaacd6daea8e1261e53f1321cc28704f6c0c793a2 [INFO] running `Command { std: "docker" "start" "-a" "56bc0652f28688ed9a71431eaacd6daea8e1261e53f1321cc28704f6c0c793a2", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Fixed Cargo.toml (1 fix) [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling serde_json v1.0.128 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking unicode-segmentation v1.12.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling memoffset v0.8.0 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling thiserror v1.0.64 [INFO] [stderr] Compiling schemars v0.8.21 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Compiling biome_diagnostics_categories v0.5.7 [INFO] [stderr] Checking gimli v0.31.0 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking dyn-clone v1.0.17 [INFO] [stderr] Compiling biome_markup v0.5.7 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking json-strip-comments v1.0.4 [INFO] [stderr] Checking dashmap v6.1.0 [INFO] [stderr] Checking rustc-hash v2.0.0 [INFO] [stderr] Checking simdutf8 v0.1.5 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking dunce v1.0.5 [INFO] [stderr] Checking countme v3.0.1 [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Compiling biome_diagnostics_macros v0.5.7 [INFO] [stderr] Checking addr2line v0.24.1 [INFO] [stderr] Compiling serde_derive_internals v0.29.1 [INFO] [stderr] Checking backtrace v0.3.74 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling schemars_derive v0.8.21 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling bpaf_derive v0.5.13 [INFO] [stderr] Checking bpaf v0.9.14 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking biome_text_size v0.5.7 [INFO] [stderr] Checking biome_text_edit v0.5.7 [INFO] [stderr] Checking biome_rowan v0.5.7 [INFO] [stderr] Checking oxc_resolver v1.12.0 [INFO] [stderr] Checking biome_console v0.5.7 [INFO] [stderr] Checking biome_diagnostics v0.5.7 [INFO] [stderr] Checking biome_analyze v0.5.7 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `biome_analyze` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/rule.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/rule.rs:304:24 [INFO] [stderr] | [INFO] [stderr] 304 | $( $key:ident: $value:expr_2021, )* [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/categories.rs:276:20 [INFO] [stdout] | [INFO] [stdout] 276 | fn json_schema(gen: &mut schemars::gen::SchemaGenerator) -> schemars::schema::Schema { [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/categories.rs:276:40 [INFO] [stdout] | [INFO] [stdout] 276 | fn json_schema(gen: &mut schemars::gen::SchemaGenerator) -> schemars::schema::Schema { [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/categories.rs:277:42 [INFO] [stdout] | [INFO] [stdout] 277 | >::json_schema(gen) [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/rule.rs:304:31 [INFO] [stdout] | [INFO] [stdout] 304 | $( $key:ident: $value:expr, )* [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 304 | $( $key:ident: $value:expr_2021, )* [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/lib.rs:188:16 [INFO] [stdout] | [INFO] [stdout] 188 | if let ControlFlow::Break(br) = (emit_signal)(&signal) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/lib.rs:190:13 [INFO] [stdout] | [INFO] [stdout] 190 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 188 ~ match (emit_signal)(&signal) { ControlFlow::Break(br) => { [INFO] [stdout] 189 | return Some(br); [INFO] [stdout] 190 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/lib.rs:340:16 [INFO] [stdout] | [INFO] [stdout] 340 | if let Some(comment) = piece.as_comments() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/lib.rs:342:13 [INFO] [stdout] | [INFO] [stdout] 342 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 340 ~ match piece.as_comments() { Some(comment) => { [INFO] [stdout] 341 | self.handle_comment(&token, true, index, comment.text(), piece.text_range())?; [INFO] [stdout] 342 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/lib.rs:357:16 [INFO] [stdout] | [INFO] [stdout] 357 | if let Some(comment) = piece.as_comments() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/lib.rs:359:13 [INFO] [stdout] | [INFO] [stdout] 359 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 357 ~ match piece.as_comments() { Some(comment) => { [INFO] [stdout] 358 | self.handle_comment(&token, false, index, comment.text(), piece.text_range())?; [INFO] [stdout] 359 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/lib.rs:370:15 [INFO] [stdout] | [INFO] [stdout] 370 | while let Some(entry) = self.signal_queue.peek() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^-----------------^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/lib.rs:427:9 [INFO] [stdout] | [INFO] [stdout] 427 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/signals.rs:87:12 [INFO] [stdout] | [INFO] [stdout] 87 | if let Some(action) = (self.action)() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^--------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/signals.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 87 ~ match (self.action)() { Some(action) => { [INFO] [stdout] 88 | AnalyzerActionIter::new([action]) [INFO] [stdout] 89 ~ } _ => { [INFO] [stdout] 90 | AnalyzerActionIter::new(vec![]) [INFO] [stdout] 91 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/signals.rs:95:12 [INFO] [stdout] | [INFO] [stdout] 95 | if let Some(transformation) = (self.transformation)() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/signals.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 95 ~ match (self.transformation)() { Some(transformation) => { [INFO] [stdout] 96 | AnalyzerTransformationIter::new([transformation]) [INFO] [stdout] 97 ~ } _ => { [INFO] [stdout] 98 | AnalyzerTransformationIter::new(vec![]) [INFO] [stdout] 99 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/signals.rs:380:12 [INFO] [stdout] | [INFO] [stdout] 380 | if let Some(ctx) = ctx { [INFO] [stdout] | ^^^^^^^^^^^^^^^^--- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/signals.rs:407:9 [INFO] [stdout] | [INFO] [stdout] 407 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 380 ~ match ctx { Some(ctx) => { [INFO] [stdout] 381 | let mut actions = Vec::new(); [INFO] [stdout] ... [INFO] [stdout] 406 | AnalyzerActionIter::new(actions) [INFO] [stdout] 407 ~ } _ => { [INFO] [stdout] 408 | AnalyzerActionIter::new(vec![]) [INFO] [stdout] 409 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/signals.rs:392:20 [INFO] [stdout] | [INFO] [stdout] 392 | if let Some(suppression_action) = [INFO] [stdout] | ____________________^ [INFO] [stdout] 393 | | R::suppress(&ctx, &text_range, self.apply_suppression_comment) [INFO] [stdout] | |_____________________-------------------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/signals.rs:403:17 [INFO] [stdout] | [INFO] [stdout] 403 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 392 ~ match R::suppress(&ctx, &text_range, self.apply_suppression_comment) [INFO] [stdout] 393 ~ { Some(suppression_action) => { [INFO] [stdout] 394 | let action = AnalyzerAction { [INFO] [stdout] ... [INFO] [stdout] 401 | actions.push(action); [INFO] [stdout] 402 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/signals.rs:425:12 [INFO] [stdout] | [INFO] [stdout] 425 | if let Some(ctx) = ctx { [INFO] [stdout] | ^^^^^^^^^^^^^^^^--- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/signals.rs:433:9 [INFO] [stdout] | [INFO] [stdout] 433 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 425 ~ match ctx { Some(ctx) => { [INFO] [stdout] 426 | let mut transformations = Vec::new(); [INFO] [stdout] ... [INFO] [stdout] 432 | AnalyzerTransformationIter::new(transformations) [INFO] [stdout] 433 ~ } _ => { [INFO] [stdout] 434 | AnalyzerTransformationIter::new(vec![]) [INFO] [stdout] 435 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `biome_analyze` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/rule.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/rule.rs:304:24 [INFO] [stderr] | [INFO] [stderr] 304 | $( $key:ident: $value:expr_2021, )* [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/categories.rs:276:20 [INFO] [stdout] | [INFO] [stdout] 276 | fn json_schema(gen: &mut schemars::gen::SchemaGenerator) -> schemars::schema::Schema { [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/categories.rs:276:40 [INFO] [stdout] | [INFO] [stdout] 276 | fn json_schema(gen: &mut schemars::gen::SchemaGenerator) -> schemars::schema::Schema { [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/categories.rs:277:42 [INFO] [stdout] | [INFO] [stdout] 277 | >::json_schema(gen) [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/rule.rs:304:31 [INFO] [stdout] | [INFO] [stdout] 304 | $( $key:ident: $value:expr, )* [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 304 | $( $key:ident: $value:expr_2021, )* [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/lib.rs:188:16 [INFO] [stdout] | [INFO] [stdout] 188 | if let ControlFlow::Break(br) = (emit_signal)(&signal) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/lib.rs:190:13 [INFO] [stdout] | [INFO] [stdout] 190 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 188 ~ match (emit_signal)(&signal) { ControlFlow::Break(br) => { [INFO] [stdout] 189 | return Some(br); [INFO] [stdout] 190 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/lib.rs:340:16 [INFO] [stdout] | [INFO] [stdout] 340 | if let Some(comment) = piece.as_comments() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/lib.rs:342:13 [INFO] [stdout] | [INFO] [stdout] 342 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 340 ~ match piece.as_comments() { Some(comment) => { [INFO] [stdout] 341 | self.handle_comment(&token, true, index, comment.text(), piece.text_range())?; [INFO] [stdout] 342 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/lib.rs:357:16 [INFO] [stdout] | [INFO] [stdout] 357 | if let Some(comment) = piece.as_comments() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/lib.rs:359:13 [INFO] [stdout] | [INFO] [stdout] 359 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 357 ~ match piece.as_comments() { Some(comment) => { [INFO] [stdout] 358 | self.handle_comment(&token, false, index, comment.text(), piece.text_range())?; [INFO] [stdout] 359 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/lib.rs:370:15 [INFO] [stdout] | [INFO] [stdout] 370 | while let Some(entry) = self.signal_queue.peek() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^-----------------^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/lib.rs:427:9 [INFO] [stdout] | [INFO] [stdout] 427 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/signals.rs:87:12 [INFO] [stdout] | [INFO] [stdout] 87 | if let Some(action) = (self.action)() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^--------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/signals.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 87 ~ match (self.action)() { Some(action) => { [INFO] [stdout] 88 | AnalyzerActionIter::new([action]) [INFO] [stdout] 89 ~ } _ => { [INFO] [stdout] 90 | AnalyzerActionIter::new(vec![]) [INFO] [stdout] 91 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/signals.rs:95:12 [INFO] [stdout] | [INFO] [stdout] 95 | if let Some(transformation) = (self.transformation)() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/signals.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 95 ~ match (self.transformation)() { Some(transformation) => { [INFO] [stdout] 96 | AnalyzerTransformationIter::new([transformation]) [INFO] [stdout] 97 ~ } _ => { [INFO] [stdout] 98 | AnalyzerTransformationIter::new(vec![]) [INFO] [stdout] 99 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/signals.rs:380:12 [INFO] [stdout] | [INFO] [stdout] 380 | if let Some(ctx) = ctx { [INFO] [stdout] | ^^^^^^^^^^^^^^^^--- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/signals.rs:407:9 [INFO] [stdout] | [INFO] [stdout] 407 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 380 ~ match ctx { Some(ctx) => { [INFO] [stdout] 381 | let mut actions = Vec::new(); [INFO] [stdout] ... [INFO] [stdout] 406 | AnalyzerActionIter::new(actions) [INFO] [stdout] 407 ~ } _ => { [INFO] [stdout] 408 | AnalyzerActionIter::new(vec![]) [INFO] [stdout] 409 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/signals.rs:392:20 [INFO] [stdout] | [INFO] [stdout] 392 | if let Some(suppression_action) = [INFO] [stdout] | ____________________^ [INFO] [stdout] 393 | | R::suppress(&ctx, &text_range, self.apply_suppression_comment) [INFO] [stdout] | |_____________________-------------------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/signals.rs:403:17 [INFO] [stdout] | [INFO] [stdout] 403 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 392 ~ match R::suppress(&ctx, &text_range, self.apply_suppression_comment) [INFO] [stdout] 393 ~ { Some(suppression_action) => { [INFO] [stdout] 394 | let action = AnalyzerAction { [INFO] [stdout] ... [INFO] [stdout] 401 | actions.push(action); [INFO] [stdout] 402 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/signals.rs:425:12 [INFO] [stdout] | [INFO] [stdout] 425 | if let Some(ctx) = ctx { [INFO] [stdout] | ^^^^^^^^^^^^^^^^--- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/signals.rs:433:9 [INFO] [stdout] | [INFO] [stdout] 433 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 425 ~ match ctx { Some(ctx) => { [INFO] [stdout] 426 | let mut transformations = Vec::new(); [INFO] [stdout] ... [INFO] [stdout] 432 | AnalyzerTransformationIter::new(transformations) [INFO] [stdout] 433 ~ } _ => { [INFO] [stdout] 434 | AnalyzerTransformationIter::new(vec![]) [INFO] [stdout] 435 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 13.14s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking biome_analyze v0.5.7 (/tmp/fixit) [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/categories.rs:276:20 [INFO] [stdout] | [INFO] [stdout] 276 | fn json_schema(gen: &mut schemars::gen::SchemaGenerator) -> schemars::schema::Schema { [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 276 | fn json_schema(r#gen: &mut schemars::gen::SchemaGenerator) -> schemars::schema::Schema { [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/categories.rs:276:40 [INFO] [stdout] | [INFO] [stdout] 276 | fn json_schema(gen: &mut schemars::gen::SchemaGenerator) -> schemars::schema::Schema { [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 276 | fn json_schema(gen: &mut schemars::r#gen::SchemaGenerator) -> schemars::schema::Schema { [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected expression, found reserved keyword `gen` [INFO] [stdout] --> src/categories.rs:277:42 [INFO] [stdout] | [INFO] [stdout] 277 | >::json_schema(gen) [INFO] [stdout] | ^^^ expected expression [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/categories.rs:276:20 [INFO] [stdout] | [INFO] [stdout] 276 | fn json_schema(gen: &mut schemars::gen::SchemaGenerator) -> schemars::schema::Schema { [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 276 | fn json_schema(r#gen: &mut schemars::gen::SchemaGenerator) -> schemars::schema::Schema { [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/categories.rs:276:40 [INFO] [stdout] | [INFO] [stdout] 276 | fn json_schema(gen: &mut schemars::gen::SchemaGenerator) -> schemars::schema::Schema { [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 276 | fn json_schema(gen: &mut schemars::r#gen::SchemaGenerator) -> schemars::schema::Schema { [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected expression, found reserved keyword `gen` [INFO] [stdout] --> src/categories.rs:277:42 [INFO] [stdout] | [INFO] [stdout] 277 | >::json_schema(gen) [INFO] [stdout] | ^^^ expected expression [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `biome_analyze` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `biome_analyze` (lib test) due to 4 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "56bc0652f28688ed9a71431eaacd6daea8e1261e53f1321cc28704f6c0c793a2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "56bc0652f28688ed9a71431eaacd6daea8e1261e53f1321cc28704f6c0c793a2", kill_on_drop: false }` [INFO] [stdout] 56bc0652f28688ed9a71431eaacd6daea8e1261e53f1321cc28704f6c0c793a2