[INFO] fetching crate barsh 0.0.0... [INFO] checking barsh-0.0.0 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate barsh 0.0.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate barsh 0.0.0 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate barsh 0.0.0 [INFO] finished tweaking crates.io crate barsh 0.0.0 [INFO] tweaked toml for crates.io crate barsh 0.0.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate barsh 0.0.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] be43a337c9ebeaa45d8da782b649a848147128edcd80a7d3d2190180e1f460d6 [INFO] running `Command { std: "docker" "start" "-a" "be43a337c9ebeaa45d8da782b649a848147128edcd80a7d3d2190180e1f460d6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "be43a337c9ebeaa45d8da782b649a848147128edcd80a7d3d2190180e1f460d6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "be43a337c9ebeaa45d8da782b649a848147128edcd80a7d3d2190180e1f460d6", kill_on_drop: false }` [INFO] [stdout] be43a337c9ebeaa45d8da782b649a848147128edcd80a7d3d2190180e1f460d6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 43785e919b8fb942b0ccc1bcef1b4a84e2015de6d268b47a63695f8c24a3a267 [INFO] running `Command { std: "docker" "start" "-a" "43785e919b8fb942b0ccc1bcef1b4a84e2015de6d268b47a63695f8c24a3a267", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling libc v0.2.140 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking similar v2.2.1 [INFO] [stderr] Checking barsh v0.0.0 (/tmp/fixit) [INFO] [stderr] Migrating src/main.rs from 2021 edition to 2024 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `barsh` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/shell/builtins/mod.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/shell/builtins/mod.rs:13:6 [INFO] [stderr] | [INFO] [stderr] 13 | ($a:expr_2021,$b:ident) => { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/libc/mod.rs:17:1 [INFO] [stdout] | [INFO] [stdout] 17 | extern "C" { [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | _help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | | [INFO] [stdout] 18 | | pub fn isatty(fd: i32) -> i32; [INFO] [stdout] 19 | | pub fn tcgetattr(fd: i32, termios: *mut Termios) -> i32; [INFO] [stdout] 20 | | pub fn tcsetattr(fd: i32, optional_actions: i32, termios: *const Termios) -> i32; [INFO] [stdout] ... | [INFO] [stdout] 24 | | [INFO] [stdout] 25 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] = note: `--force-warn missing-unsafe-on-extern` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/shell/builtins/mod.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | ($a:expr,$b:ident) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 13 | ($a:expr_2021,$b:ident) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `libc::isatty` is unsafe and requires unsafe block [INFO] [stdout] --> src/shell/repl/tty.rs:182:8 [INFO] [stdout] | [INFO] [stdout] 182 | if libc::isatty(libc::STDIN_FILENO) == 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/shell/repl/tty.rs:180:1 [INFO] [stdout] | [INFO] [stdout] 180 | unsafe fn get_stdin_fd() -> libc::int { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `--force-warn unsafe-op-in-unsafe-fn` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/shell/repl/mod.rs:71:16 [INFO] [stdout] | [INFO] [stdout] 71 | if let Err(err) = self._run_cmd(line) { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/shell/repl/mod.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 73 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 71 ~ match self._run_cmd(line) { Err(err) => { [INFO] [stdout] 72 | eprintln!("io error: {}", err); [INFO] [stdout] 73 ~ } _ => { [INFO] [stdout] 74 | self.state.hist.add(line.to_owned()); [INFO] [stdout] 75 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/shell/repl/history.rs:116:12 [INFO] [stdout] | [INFO] [stdout] 116 | if let Ok(lines) = read_lines(&self.path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/shell/repl/history.rs:127:9 [INFO] [stdout] | [INFO] [stdout] 127 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 116 ~ match read_lines(&self.path) { Ok(lines) => { [INFO] [stdout] 117 | for line in lines { [INFO] [stdout] ... [INFO] [stdout] 126 | self.size = idx; [INFO] [stdout] 127 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/shell/repl/history.rs:118:20 [INFO] [stdout] | [INFO] [stdout] 118 | if let Ok(ip) = line { [INFO] [stdout] | ^^^^^^^^^^^^^---- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/shell/repl/history.rs:124:17 [INFO] [stdout] | [INFO] [stdout] 124 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 118 ~ match line { Ok(ip) => { [INFO] [stdout] 119 | if ip != "" { [INFO] [stdout] ... [INFO] [stdout] 123 | } [INFO] [stdout] 124 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stderr] Checking console v0.15.5 [INFO] [stderr] Checking insta v1.28.0 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `barsh` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/shell/builtins/mod.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/shell/builtins/mod.rs:13:6 [INFO] [stderr] | [INFO] [stderr] 13 | ($a:expr_2021,$b:ident) => { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.24s [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/libc/mod.rs:17:1 [INFO] [stdout] | [INFO] [stdout] 17 | extern "C" { [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | _help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | | [INFO] [stdout] 18 | | pub fn isatty(fd: i32) -> i32; [INFO] [stdout] 19 | | pub fn tcgetattr(fd: i32, termios: *mut Termios) -> i32; [INFO] [stdout] 20 | | pub fn tcsetattr(fd: i32, optional_actions: i32, termios: *const Termios) -> i32; [INFO] [stdout] ... | [INFO] [stdout] 24 | | [INFO] [stdout] 25 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] = note: `--force-warn missing-unsafe-on-extern` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/shell/builtins/mod.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | ($a:expr,$b:ident) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 13 | ($a:expr_2021,$b:ident) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `libc::isatty` is unsafe and requires unsafe block [INFO] [stdout] --> src/shell/repl/tty.rs:182:8 [INFO] [stdout] | [INFO] [stdout] 182 | if libc::isatty(libc::STDIN_FILENO) == 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/shell/repl/tty.rs:180:1 [INFO] [stdout] | [INFO] [stdout] 180 | unsafe fn get_stdin_fd() -> libc::int { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `--force-warn unsafe-op-in-unsafe-fn` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/runtime/eval.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 172 | evaluator.eval_udf(0, &locals); // compute initial value of global vars [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 172 | let _ = evaluator.eval_udf(0, &locals); // compute initial value of global vars [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/runtime/eval.rs:178:9 [INFO] [stdout] | [INFO] [stdout] 178 | evaluator.eval(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 178 | let _ = evaluator.eval(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/runtime/eval.rs:186:9 [INFO] [stdout] | [INFO] [stdout] 186 | evaluator.eval_udf(2, &args); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 186 | let _ = evaluator.eval_udf(2, &args); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/shell/repl/mod.rs:71:16 [INFO] [stdout] | [INFO] [stdout] 71 | if let Err(err) = self._run_cmd(line) { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/shell/repl/mod.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 73 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 71 ~ match self._run_cmd(line) { Err(err) => { [INFO] [stdout] 72 | eprintln!("io error: {}", err); [INFO] [stdout] 73 ~ } _ => { [INFO] [stdout] 74 | self.state.hist.add(line.to_owned()); [INFO] [stdout] 75 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/shell/repl/history.rs:116:12 [INFO] [stdout] | [INFO] [stdout] 116 | if let Ok(lines) = read_lines(&self.path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/shell/repl/history.rs:127:9 [INFO] [stdout] | [INFO] [stdout] 127 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 116 ~ match read_lines(&self.path) { Ok(lines) => { [INFO] [stdout] 117 | for line in lines { [INFO] [stdout] ... [INFO] [stdout] 126 | self.size = idx; [INFO] [stdout] 127 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/shell/repl/history.rs:118:20 [INFO] [stdout] | [INFO] [stdout] 118 | if let Ok(ip) = line { [INFO] [stdout] | ^^^^^^^^^^^^^---- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/shell/repl/history.rs:124:17 [INFO] [stdout] | [INFO] [stdout] 124 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 118 ~ match line { Ok(ip) => { [INFO] [stdout] 119 | if ip != "" { [INFO] [stdout] ... [INFO] [stdout] 123 | } [INFO] [stdout] 124 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking barsh v0.0.0 (/tmp/fixit) [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/libc/mod.rs:17:1 [INFO] [stdout] | [INFO] [stdout] 17 | / extern "C" { [INFO] [stdout] 18 | | pub fn isatty(fd: i32) -> i32; [INFO] [stdout] 19 | | pub fn tcgetattr(fd: i32, termios: *mut Termios) -> i32; [INFO] [stdout] 20 | | pub fn tcsetattr(fd: i32, optional_actions: i32, termios: *const Termios) -> i32; [INFO] [stdout] ... | [INFO] [stdout] 24 | | [INFO] [stdout] 25 | | } [INFO] [stdout] | |_^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/libc/mod.rs:17:1 [INFO] [stdout] | [INFO] [stdout] 17 | / extern "C" { [INFO] [stdout] 18 | | pub fn isatty(fd: i32) -> i32; [INFO] [stdout] 19 | | pub fn tcgetattr(fd: i32, termios: *mut Termios) -> i32; [INFO] [stdout] 20 | | pub fn tcsetattr(fd: i32, optional_actions: i32, termios: *const Termios) -> i32; [INFO] [stdout] ... | [INFO] [stdout] 24 | | [INFO] [stdout] 25 | | } [INFO] [stdout] | |_^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `libc::isatty` is unsafe and requires unsafe block [INFO] [stdout] --> src/shell/repl/tty.rs:182:8 [INFO] [stdout] | [INFO] [stdout] 182 | if libc::isatty(libc::STDIN_FILENO) == 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/shell/repl/tty.rs:180:1 [INFO] [stdout] | [INFO] [stdout] 180 | unsafe fn get_stdin_fd() -> libc::int { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(unsafe_op_in_unsafe_fn)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `libc::isatty` is unsafe and requires unsafe block [INFO] [stdout] --> src/shell/repl/tty.rs:182:8 [INFO] [stdout] | [INFO] [stdout] 182 | if libc::isatty(libc::STDIN_FILENO) == 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/shell/repl/tty.rs:180:1 [INFO] [stdout] | [INFO] [stdout] 180 | unsafe fn get_stdin_fd() -> libc::int { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(unsafe_op_in_unsafe_fn)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `barsh` (bin "barsh") due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stderr] error: could not compile `barsh` (bin "barsh" test) due to 2 previous errors; 1 warning emitted [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "43785e919b8fb942b0ccc1bcef1b4a84e2015de6d268b47a63695f8c24a3a267", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "43785e919b8fb942b0ccc1bcef1b4a84e2015de6d268b47a63695f8c24a3a267", kill_on_drop: false }` [INFO] [stdout] 43785e919b8fb942b0ccc1bcef1b4a84e2015de6d268b47a63695f8c24a3a267