[INFO] fetching crate asciinema 3.0.0-rc.3... [INFO] checking asciinema-3.0.0-rc.3 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate asciinema 3.0.0-rc.3 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate asciinema 3.0.0-rc.3 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-4-tc2/source/.cargo/config.toml [INFO] started tweaking crates.io crate asciinema 3.0.0-rc.3 [INFO] finished tweaking crates.io crate asciinema 3.0.0-rc.3 [INFO] tweaked toml for crates.io crate asciinema 3.0.0-rc.3 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate asciinema 3.0.0-rc.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 827eac2ed656582a55f1b089e0e4d56ff0a5f17d7531bb76537c8afdbb6843a4 [INFO] running `Command { std: "docker" "start" "-a" "827eac2ed656582a55f1b089e0e4d56ff0a5f17d7531bb76537c8afdbb6843a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "827eac2ed656582a55f1b089e0e4d56ff0a5f17d7531bb76537c8afdbb6843a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "827eac2ed656582a55f1b089e0e4d56ff0a5f17d7531bb76537c8afdbb6843a4", kill_on_drop: false }` [INFO] [stdout] 827eac2ed656582a55f1b089e0e4d56ff0a5f17d7531bb76537c8afdbb6843a4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1934dcb3c8105a41df040a2f54f78dc0de0423698090381665a70b9606b54c87 [INFO] running `Command { std: "docker" "start" "-a" "1934dcb3c8105a41df040a2f54f78dc0de0423698090381665a70b9606b54c87", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling serde v1.0.196 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling ppv-lite86 v0.2.17 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling phf_shared v0.10.0 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Compiling getrandom v0.2.12 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking http v1.0.0 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Checking indexmap v2.2.2 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling proc-macro-hack v0.5.20+deprecated [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling rustversion v1.0.14 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling utf8parse v0.2.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling anstyle-parse v0.2.3 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Compiling phf_generator v0.10.0 [INFO] [stderr] Compiling phf_codegen v0.10.0 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking new_debug_unreachable v1.0.4 [INFO] [stderr] Compiling colorchoice v1.0.0 [INFO] [stderr] Compiling anstyle-query v1.0.2 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Checking rustls-pki-types v1.4.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling anstyle v1.0.6 [INFO] [stderr] Compiling anstream v0.6.11 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Compiling rustls v0.22.3 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling tinyvec_macros v0.1.1 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Compiling clap_lex v0.6.0 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Compiling const-random-macro v0.1.16 [INFO] [stderr] Compiling clap_builder v4.4.18 [INFO] [stderr] Compiling tinyvec v1.6.0 [INFO] [stderr] Compiling string_cache_codegen v0.5.2 [INFO] [stderr] Checking http v0.2.11 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Checking precomputed-hash v0.1.1 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Compiling rustls v0.21.11 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Checking mac v0.1.1 [INFO] [stderr] Checking futf v0.1.5 [INFO] [stderr] Compiling markup5ever v0.11.0 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking const-random v0.1.17 [INFO] [stderr] Compiling async-trait v0.1.77 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Compiling percent-encoding v2.3.1 [INFO] [stderr] Checking dtoa v1.0.9 [INFO] [stderr] Compiling unicode-bidi v0.3.15 [INFO] [stderr] Compiling form_urlencoded v1.2.1 [INFO] [stderr] Checking dtoa-short v0.3.4 [INFO] [stderr] Compiling sha2 v0.10.8 [INFO] [stderr] Compiling walkdir v2.4.0 [INFO] [stderr] Checking rustls-webpki v0.102.2 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling serde_derive v1.0.196 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Compiling phf_macros v0.10.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Checking phf v0.10.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Compiling html5ever v0.26.0 [INFO] [stderr] Compiling pin-project-internal v1.1.4 [INFO] [stderr] Compiling clap v4.4.18 [INFO] [stderr] Compiling cssparser-macros v0.6.1 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Compiling mime_guess v2.0.4 [INFO] [stderr] Checking dlv-list v0.5.2 [INFO] [stderr] Checking tendril v0.4.3 [INFO] [stderr] Checking http-body-util v0.1.0 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Compiling axum-core v0.4.3 [INFO] [stderr] Compiling selectors v0.25.0 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking hashbrown v0.13.2 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking winnow v0.5.39 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Compiling serde_json v1.0.113 [INFO] [stderr] Compiling roff v0.2.1 [INFO] [stderr] Checking data-encoding v2.5.0 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking tokio-rustls v0.25.0 [INFO] [stderr] Compiling clap_mangen v0.2.19 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking tungstenite v0.21.0 [INFO] [stderr] Checking ordered-multimap v0.6.0 [INFO] [stderr] Checking h2 v0.4.2 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking servo_arc v0.3.0 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking pin-project v1.1.4 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking cssparser v0.31.2 [INFO] [stderr] Compiling clap_complete v4.4.10 [INFO] [stderr] Checking string_cache v0.8.7 [INFO] [stderr] Checking serde_spanned v0.6.5 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Checking toml_edit v0.22.4 [INFO] [stderr] Compiling rust-embed-utils v8.2.0 [INFO] [stderr] Compiling axum v0.7.4 [INFO] [stderr] Checking webpki-roots v0.26.1 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking zerocopy v0.7.34 [INFO] [stderr] Checking bytemuck v1.14.2 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Compiling anyhow v1.0.79 [INFO] [stderr] Checking rgb v0.8.37 [INFO] [stderr] Checking hyper v1.1.0 [INFO] [stderr] Checking hyper v0.14.28 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking tokio-tungstenite v0.21.0 [INFO] [stderr] Compiling asciinema v3.0.0-rc.3 (/tmp/fixit) [INFO] [stderr] Migrating build.rs from 2021 edition to 2024 [INFO] [stderr] Checking toml v0.8.10 [INFO] [stderr] Checking hyper-util v0.1.3 [INFO] [stderr] Compiling rust-embed-impl v8.2.0 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/cli.rs:201:14 [INFO] [stdout] | [INFO] [stdout] 201 | StreamId(String), [INFO] [stdout] | -------- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `RelayTarget` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 201 | StreamId(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/cli.rs:202:19 [INFO] [stdout] | [INFO] [stdout] 202 | WsProducerUrl(url::Url), [INFO] [stdout] | ------------- ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `RelayTarget` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 202 | WsProducerUrl(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking async-compression v0.4.6 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking rust-ini v0.19.0 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Checking fd-lock v4.0.2 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Checking encoding_rs v0.8.33 [INFO] [stderr] Checking webpki-roots v0.25.4 [INFO] [stderr] Checking ego-tree v0.6.2 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking numtoa v0.1.0 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking matchit v0.7.3 [INFO] [stderr] Checking pathdiff v0.2.1 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking termion v3.0.0 [INFO] [stderr] Checking config v0.14.0 [INFO] [stderr] Checking tempfile v3.10.0 [INFO] [stderr] Checking scraper v0.19.0 [INFO] [stderr] Checking which v6.0.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking rust-embed v8.2.0 [INFO] [stderr] Checking avt v0.11.0 [INFO] [stderr] Checking tokio-stream v0.1.14 [INFO] [stderr] Checking tower-http v0.5.1 [INFO] [stderr] Checking uuid v1.7.0 [INFO] [stderr] Checking hostname v0.4.0 [INFO] [stderr] Checking reqwest v0.11.24 [INFO] [stderr] Checking rustyline v13.0.0 [INFO] [stderr] Migrating src/main.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `asciinema` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/logger.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/logger.rs:9:6 [INFO] [stderr] | [INFO] [stderr] 9 | ($fmt:expr_2021) => (crate::logger::println(format!($fmt))); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/logger.rs:10:6 [INFO] [stderr] | [INFO] [stderr] 10 | ($fmt:expr_2021, $($arg:tt)*) => (crate::logger::println(format!($fmt, $($arg)*))); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/logger.rs:9:11 [INFO] [stdout] | [INFO] [stdout] 9 | ($fmt:expr) => (crate::logger::println(format!($fmt))); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 9 | ($fmt:expr_2021) => (crate::logger::println(format!($fmt))); [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/logger.rs:10:11 [INFO] [stdout] | [INFO] [stdout] 10 | ($fmt:expr, $($arg:tt)*) => (crate::logger::println(format!($fmt, $($arg)*))); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 10 | ($fmt:expr_2021, $($arg:tt)*) => (crate::logger::println(format!($fmt, $($arg)*))); [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/config.rs:103:13 [INFO] [stdout] | [INFO] [stdout] 103 | env::set_var("ASCIINEMA_SERVER_URL", url); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] = note: `--force-warn deprecated-safe-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 103 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 104 ~ unsafe { env::set_var("ASCIINEMA_SERVER_URL", url) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/pty.rs:283:9 [INFO] [stdout] | [INFO] [stdout] 283 | env::set_var(k, v); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 283 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 284 ~ unsafe { env::set_var(k, v) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/asciicast.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 54 | if let Ok(parser) = v2::open(&first_line) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^--------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/asciicast.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 54 ~ match v2::open(&first_line) { Ok(parser) => { [INFO] [stdout] 55 | Ok(parser.parse(lines)) [INFO] [stdout] 56 ~ } _ => { [INFO] [stdout] 57 | let json = std::iter::once(Ok(first_line)) [INFO] [stdout] ... [INFO] [stdout] 61 | v1::load(json) [INFO] [stdout] 62 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/asciicast.rs:396:20 [INFO] [stdout] | [INFO] [stdout] 396 | if let Ok(Event { [INFO] [stdout] | ____________________^ [INFO] [stdout] 397 | | time, [INFO] [stdout] 398 | | data: EventData::Output(data), [INFO] [stdout] 399 | | }) = r [INFO] [stdout] | | ^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |______________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/asciicast.rs:402:17 [INFO] [stdout] | [INFO] [stdout] 402 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 396 ~ match r [INFO] [stdout] 397 ~ { Ok(Event { [INFO] [stdout] 398 + time, [INFO] [stdout] 399 + data: EventData::Output(data), [INFO] [stdout] 400 ~ }) => { [INFO] [stdout] 401 | Some((time, data)) [INFO] [stdout] 402 ~ } _ => { [INFO] [stdout] 403 | None [INFO] [stdout] 404 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/cmd/rec.rs:159:19 [INFO] [stdout] | [INFO] [stdout] 159 | } else if let Ok(dev_tty) = tty::DevTty::open() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/cmd/rec.rs:161:9 [INFO] [stdout] | [INFO] [stdout] 161 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 159 ~ } else { match tty::DevTty::open() { Ok(dev_tty) => { [INFO] [stdout] 160 | Ok(Box::new(dev_tty)) [INFO] [stdout] 161 ~ } _ => { [INFO] [stdout] 162 | logger::info!("TTY not available, recording in headless mode"); [INFO] [stdout] 163 | Ok(Box::new(tty::NullTty::open()?)) [INFO] [stdout] 164 ~ }}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/cmd/stream.rs:144:19 [INFO] [stdout] | [INFO] [stdout] 144 | } else if let Ok(dev_tty) = tty::DevTty::open() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/cmd/stream.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 146 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 144 ~ } else { match tty::DevTty::open() { Ok(dev_tty) => { [INFO] [stdout] 145 | Ok(Box::new(dev_tty)) [INFO] [stdout] 146 ~ } _ => { [INFO] [stdout] 147 | logger::info!("TTY not available, streaming in headless mode"); [INFO] [stdout] 148 | Ok(Box::new(tty::NullTty::open()?)) [INFO] [stdout] 149 ~ }}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/config.rs:125:12 [INFO] [stdout] | [INFO] [stdout] 125 | if let Some(id) = read_install_id(&path)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^----------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/config.rs:127:9 [INFO] [stdout] | [INFO] [stdout] 127 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 125 ~ match read_install_id(&path)? { Some(id) => { [INFO] [stdout] 126 | Ok(id) [INFO] [stdout] 127 ~ } _ => { [INFO] [stdout] 128 | let id = create_install_id(); [INFO] [stdout] ... [INFO] [stdout] 131 | Ok(id) [INFO] [stdout] 132 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/player.rs:45:16 [INFO] [stdout] | [INFO] [stdout] 45 | if let Some(input) = read_input(&mut tty, 1_000_000)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^-------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/player.rs:83:13 [INFO] [stdout] | [INFO] [stdout] 83 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 45 ~ match read_input(&mut tty, 1_000_000)? { Some(input) => { [INFO] [stdout] 46 | if keys.quit.as_ref().is_some_and(|k| k == &input) { [INFO] [stdout] ... [INFO] [stdout] 82 | } [INFO] [stdout] 83 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/player.rs:91:24 [INFO] [stdout] | [INFO] [stdout] 91 | if let Some(key) = read_input(&mut tty, delay)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^---------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/player.rs:103:21 [INFO] [stdout] | [INFO] [stdout] 103 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 91 ~ match read_input(&mut tty, delay)? { Some(key) => { [INFO] [stdout] 92 | if keys.quit.as_ref().is_some_and(|k| k == &key) { [INFO] [stdout] ... [INFO] [stdout] 102 | continue; [INFO] [stdout] 103 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/player.rs:157:15 [INFO] [stdout] | [INFO] [stdout] 157 | while let Ok(n) = tty.read(&mut buf) { [INFO] [stdout] | ^^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/player.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 163 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pty.rs:155:19 [INFO] [stdout] | [INFO] [stdout] 155 | while let Some(n) = read_non_blocking(&mut master, &mut buf)? { [INFO] [stdout] | ^^^^^^^^^^^^^^----------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pty.rs:165:13 [INFO] [stdout] | [INFO] [stdout] 165 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pty.rs:171:19 [INFO] [stdout] | [INFO] [stdout] 171 | while let Some(n) = write_non_blocking(&mut master, buf)? { [INFO] [stdout] | ^^^^^^^^^^^^^^------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pty.rs:177:13 [INFO] [stdout] | [INFO] [stdout] 177 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pty.rs:191:19 [INFO] [stdout] | [INFO] [stdout] 191 | while let Some(n) = write_non_blocking(tty, buf)? { [INFO] [stdout] | ^^^^^^^^^^^^^^----------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pty.rs:197:13 [INFO] [stdout] | [INFO] [stdout] 197 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pty.rs:213:19 [INFO] [stdout] | [INFO] [stdout] 213 | while let Some(n) = read_non_blocking(tty, &mut buf)? { [INFO] [stdout] | ^^^^^^^^^^^^^^--------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pty.rs:221:13 [INFO] [stdout] | [INFO] [stdout] 221 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pty.rs:383:15 [INFO] [stdout] | [INFO] [stdout] 383 | while let Ok(n) = unistd::read(self.rx.as_raw_fd(), &mut buf) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^-------^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pty.rs:387:9 [INFO] [stdout] | [INFO] [stdout] 387 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 17 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `asciinema` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/logger.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/logger.rs:9:6 [INFO] [stderr] | [INFO] [stderr] 9 | ($fmt:expr_2021) => (crate::logger::println(format!($fmt))); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/logger.rs:10:6 [INFO] [stderr] | [INFO] [stderr] 10 | ($fmt:expr_2021, $($arg:tt)*) => (crate::logger::println(format!($fmt, $($arg)*))); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/logger.rs:9:11 [INFO] [stdout] | [INFO] [stdout] 9 | ($fmt:expr) => (crate::logger::println(format!($fmt))); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 9 | ($fmt:expr_2021) => (crate::logger::println(format!($fmt))); [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/logger.rs:10:11 [INFO] [stdout] | [INFO] [stdout] 10 | ($fmt:expr, $($arg:tt)*) => (crate::logger::println(format!($fmt, $($arg)*))); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 10 | ($fmt:expr_2021, $($arg:tt)*) => (crate::logger::println(format!($fmt, $($arg)*))); [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/config.rs:103:13 [INFO] [stdout] | [INFO] [stdout] 103 | env::set_var("ASCIINEMA_SERVER_URL", url); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] = note: `--force-warn deprecated-safe-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 103 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 104 ~ unsafe { env::set_var("ASCIINEMA_SERVER_URL", url) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/pty.rs:283:9 [INFO] [stdout] | [INFO] [stdout] 283 | env::set_var(k, v); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 283 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 284 ~ unsafe { env::set_var(k, v) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `version` is never read [INFO] [stdout] --> src/asciicast.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct Header { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 18 | pub version: u8, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/cmd/rec.rs:159:19 [INFO] [stdout] | [INFO] [stdout] 159 | } else if let Ok(dev_tty) = tty::DevTty::open() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/cmd/rec.rs:161:9 [INFO] [stdout] | [INFO] [stdout] 161 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 159 ~ } else { match tty::DevTty::open() { Ok(dev_tty) => { [INFO] [stdout] 160 | Ok(Box::new(dev_tty)) [INFO] [stdout] 161 ~ } _ => { [INFO] [stdout] 162 | logger::info!("TTY not available, recording in headless mode"); [INFO] [stdout] 163 | Ok(Box::new(tty::NullTty::open()?)) [INFO] [stdout] 164 ~ }}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/cmd/stream.rs:144:19 [INFO] [stdout] | [INFO] [stdout] 144 | } else if let Ok(dev_tty) = tty::DevTty::open() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/cmd/stream.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 146 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 144 ~ } else { match tty::DevTty::open() { Ok(dev_tty) => { [INFO] [stdout] 145 | Ok(Box::new(dev_tty)) [INFO] [stdout] 146 ~ } _ => { [INFO] [stdout] 147 | logger::info!("TTY not available, streaming in headless mode"); [INFO] [stdout] 148 | Ok(Box::new(tty::NullTty::open()?)) [INFO] [stdout] 149 ~ }}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/config.rs:125:12 [INFO] [stdout] | [INFO] [stdout] 125 | if let Some(id) = read_install_id(&path)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^----------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/config.rs:127:9 [INFO] [stdout] | [INFO] [stdout] 127 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 125 ~ match read_install_id(&path)? { Some(id) => { [INFO] [stdout] 126 | Ok(id) [INFO] [stdout] 127 ~ } _ => { [INFO] [stdout] 128 | let id = create_install_id(); [INFO] [stdout] ... [INFO] [stdout] 131 | Ok(id) [INFO] [stdout] 132 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/player.rs:45:16 [INFO] [stdout] | [INFO] [stdout] 45 | if let Some(input) = read_input(&mut tty, 1_000_000)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^-------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/player.rs:83:13 [INFO] [stdout] | [INFO] [stdout] 83 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 45 ~ match read_input(&mut tty, 1_000_000)? { Some(input) => { [INFO] [stdout] 46 | if keys.quit.as_ref().is_some_and(|k| k == &input) { [INFO] [stdout] ... [INFO] [stdout] 82 | } [INFO] [stdout] 83 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/player.rs:91:24 [INFO] [stdout] | [INFO] [stdout] 91 | if let Some(key) = read_input(&mut tty, delay)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^---------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/player.rs:103:21 [INFO] [stdout] | [INFO] [stdout] 103 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 91 ~ match read_input(&mut tty, delay)? { Some(key) => { [INFO] [stdout] 92 | if keys.quit.as_ref().is_some_and(|k| k == &key) { [INFO] [stdout] ... [INFO] [stdout] 102 | continue; [INFO] [stdout] 103 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/player.rs:157:15 [INFO] [stdout] | [INFO] [stdout] 157 | while let Ok(n) = tty.read(&mut buf) { [INFO] [stdout] | ^^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/player.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 163 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pty.rs:155:19 [INFO] [stdout] | [INFO] [stdout] 155 | while let Some(n) = read_non_blocking(&mut master, &mut buf)? { [INFO] [stdout] | ^^^^^^^^^^^^^^----------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pty.rs:165:13 [INFO] [stdout] | [INFO] [stdout] 165 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pty.rs:171:19 [INFO] [stdout] | [INFO] [stdout] 171 | while let Some(n) = write_non_blocking(&mut master, buf)? { [INFO] [stdout] | ^^^^^^^^^^^^^^------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pty.rs:177:13 [INFO] [stdout] | [INFO] [stdout] 177 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pty.rs:191:19 [INFO] [stdout] | [INFO] [stdout] 191 | while let Some(n) = write_non_blocking(tty, buf)? { [INFO] [stdout] | ^^^^^^^^^^^^^^----------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pty.rs:197:13 [INFO] [stdout] | [INFO] [stdout] 197 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pty.rs:213:19 [INFO] [stdout] | [INFO] [stdout] 213 | while let Some(n) = read_non_blocking(tty, &mut buf)? { [INFO] [stdout] | ^^^^^^^^^^^^^^--------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pty.rs:221:13 [INFO] [stdout] | [INFO] [stdout] 221 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pty.rs:383:15 [INFO] [stdout] | [INFO] [stdout] 383 | while let Ok(n) = unistd::read(self.rx.as_raw_fd(), &mut buf) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^-------^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pty.rs:387:9 [INFO] [stdout] | [INFO] [stdout] 387 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 16 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 23.58s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Compiling asciinema v3.0.0-rc.3 (/tmp/fixit) [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/cli.rs:201:14 [INFO] [stdout] | [INFO] [stdout] 201 | StreamId(String), [INFO] [stdout] | -------- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `RelayTarget` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 201 | StreamId(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/cli.rs:202:19 [INFO] [stdout] | [INFO] [stdout] 202 | WsProducerUrl(url::Url), [INFO] [stdout] | ------------- ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `RelayTarget` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 202 | WsProducerUrl(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/config.rs:103:13 [INFO] [stdout] | [INFO] [stdout] 103 | env::set_var("ASCIINEMA_SERVER_URL", url); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/config.rs:103:13 [INFO] [stdout] | [INFO] [stdout] 103 | env::set_var("ASCIINEMA_SERVER_URL", url); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/pty.rs:283:9 [INFO] [stdout] | [INFO] [stdout] 283 | env::set_var(k, v); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/pty.rs:283:9 [INFO] [stdout] | [INFO] [stdout] 283 | env::set_var(k, v); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stderr] error: could not compile `asciinema` (bin "asciinema") due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `asciinema` (bin "asciinema" test) due to 3 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "1934dcb3c8105a41df040a2f54f78dc0de0423698090381665a70b9606b54c87", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1934dcb3c8105a41df040a2f54f78dc0de0423698090381665a70b9606b54c87", kill_on_drop: false }` [INFO] [stdout] 1934dcb3c8105a41df040a2f54f78dc0de0423698090381665a70b9606b54c87