[INFO] fetching crate anvil_db 0.2.1... [INFO] checking anvil_db-0.2.1 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate anvil_db 0.2.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate anvil_db 0.2.1 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate anvil_db 0.2.1 [INFO] finished tweaking crates.io crate anvil_db 0.2.1 [INFO] tweaked toml for crates.io crate anvil_db 0.2.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 711253450f478494514c3d32b0921e3c62829f986ea4b8eec79a786668531958 [INFO] running `Command { std: "docker" "start" "-a" "711253450f478494514c3d32b0921e3c62829f986ea4b8eec79a786668531958", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "711253450f478494514c3d32b0921e3c62829f986ea4b8eec79a786668531958", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "711253450f478494514c3d32b0921e3c62829f986ea4b8eec79a786668531958", kill_on_drop: false }` [INFO] [stdout] 711253450f478494514c3d32b0921e3c62829f986ea4b8eec79a786668531958 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ec4cb389b6265242f66cc4bcf58744aff08eebe21e45df0f29dc2f8641286ee7 [INFO] running `Command { std: "docker" "start" "-a" "ec4cb389b6265242f66cc4bcf58744aff08eebe21e45df0f29dc2f8641286ee7", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Checking anvil_db v0.2.1 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `anvil_db` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/helpful_macros.rs [INFO] [stderr] * src/logging.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/helpful_macros.rs:14:6 [INFO] [stderr] | [INFO] [stderr] 14 | ($stmt:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/helpful_macros.rs:23:6 [INFO] [stderr] | [INFO] [stderr] 23 | ($stmt:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/helpful_macros.rs:31:6 [INFO] [stderr] | [INFO] [stderr] 31 | ($stmt:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/logging.rs:70:6 [INFO] [stderr] | [INFO] [stderr] 70 | ($logger:expr_2021, $($arg:tt)*) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/logging.rs:77:6 [INFO] [stderr] | [INFO] [stderr] 77 | ($logger:expr_2021, $($arg:tt)*) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/concurrent_skip_list.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 21 | fn gen(&self) -> u64 { [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/concurrent_skip_list.rs:600:26 [INFO] [stdout] | [INFO] [stdout] 600 | while ((self.rng.gen() % 10_000) as f64) < p * 10_000.0 && lvl < self.max_level - 1 { [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/concurrent_skip_list.rs:837:31 [INFO] [stdout] | [INFO] [stdout] 837 | let num = rng.gen(); [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/helpful_macros.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 14 | ($stmt:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 14 | ($stmt:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/helpful_macros.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 23 | ($stmt:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 23 | ($stmt:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/helpful_macros.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 31 | ($stmt:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 31 | ($stmt:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/logging.rs:70:14 [INFO] [stdout] | [INFO] [stdout] 70 | ($logger:expr, $($arg:tt)*) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 70 | ($logger:expr_2021, $($arg:tt)*) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/logging.rs:77:14 [INFO] [stdout] | [INFO] [stdout] 77 | ($logger:expr, $($arg:tt)*) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 77 | ($logger:expr_2021, $($arg:tt)*) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `KeyValuePointReader` is never used [INFO] [stdout] --> src/kv.rs:10:18 [INFO] [stdout] | [INFO] [stdout] 10 | pub(crate) trait KeyValuePointReader { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `AsyncTombstoneIterator` is never used [INFO] [stdout] --> src/kv.rs:201:18 [INFO] [stdout] | [INFO] [stdout] 201 | pub(crate) trait AsyncTombstoneIterator: [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `TryAsyncTombstoneScanner` is never used [INFO] [stdout] --> src/kv.rs:223:18 [INFO] [stdout] | [INFO] [stdout] 223 | pub(crate) trait TryAsyncTombstoneScanner { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `read_exact` is never used [INFO] [stdout] --> src/sst/block_cache/cache.rs:19:8 [INFO] [stdout] | [INFO] [stdout] 15 | pub(crate) trait BlockCache: Clone { [INFO] [stdout] | ---------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 19 | fn read_exact( [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `BlockTooSmall` is never constructed [INFO] [stdout] --> src/sst/block_cache/common.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub(crate) enum CacheError { [INFO] [stdout] | ---------- variant in this enum [INFO] [stdout] 8 | Read(String), [INFO] [stdout] 9 | BlockTooSmall, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CacheError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_sst_reader` is never used [INFO] [stdout] --> src/tablet.rs:117:8 [INFO] [stdout] | [INFO] [stdout] 102 | pub(crate) trait TabletSstStore: Clone + TombstonePointReader + TryTombstoneScanner { [INFO] [stdout] | -------------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 117 | fn get_sst_reader(&self, blob_id: &str) -> Option; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/compactor.rs:429:28 [INFO] [stdout] | [INFO] [stdout] 429 | if let Some(order) = [INFO] [stdout] | ____________________________^ [INFO] [stdout] 430 | | self.sst_store.request_task(&TaskCategory::MajorCompaction) [INFO] [stdout] | |_____________________________----------------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/compactor.rs:442:25 [INFO] [stdout] | [INFO] [stdout] 442 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 429 ~ match self.sst_store.request_task(&TaskCategory::MajorCompaction) [INFO] [stdout] 430 ~ { Some(order) => { [INFO] [stdout] 431 | match self.compact_result(&order) { [INFO] [stdout] ... [INFO] [stdout] 440 | } [INFO] [stdout] 441 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/compactor.rs:446:28 [INFO] [stdout] | [INFO] [stdout] 446 | if let Some(done_tx) = done_tx { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/compactor.rs:453:25 [INFO] [stdout] | [INFO] [stdout] 453 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 446 ~ match done_tx { Some(done_tx) => { [INFO] [stdout] 447 | done_tx [INFO] [stdout] ... [INFO] [stdout] 452 | .unwrap(); [INFO] [stdout] 453 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/compactor.rs:464:20 [INFO] [stdout] | [INFO] [stdout] 464 | if let Ok(new_sst_readers) = self.compact_result(&order) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^--------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/compactor.rs:468:17 [INFO] [stdout] | [INFO] [stdout] 468 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 464 ~ match self.compact_result(&order) { Ok(new_sst_readers) => { [INFO] [stdout] 465 | self.sst_store [INFO] [stdout] 466 | .handle_finished_task(&order, new_sst_readers.into_iter()); [INFO] [stdout] 467 | continue; [INFO] [stdout] 468 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/concurrent_skip_list.rs:873:20 [INFO] [stdout] | [INFO] [stdout] 873 | if let Some(unwrap) = option { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/concurrent_skip_list.rs:875:17 [INFO] [stdout] | [INFO] [stdout] 875 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 873 ~ match option { Some(unwrap) => { [INFO] [stdout] 874 | assert_eq!(*unwrap, k + 1); [INFO] [stdout] 875 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:96:45 [INFO] [stdout] | [INFO] [stdout] 96 | let (check_key, _) = if let PairWrapper::Pair((check_key, check_value)) = &*pair [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:99:21 [INFO] [stdout] | [INFO] [stdout] 99 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 96 ~ let (check_key, _) = match &*pair [INFO] [stdout] 97 ~ { PairWrapper::Pair((check_key, check_value)) => { [INFO] [stdout] 98 | (check_key, check_value) [INFO] [stdout] 99 ~ } _ => { [INFO] [stdout] 100| continue; [INFO] [stdout] 101~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:108:41 [INFO] [stdout] | [INFO] [stdout] 108 | let (check_key, _) = if let PairWrapper::Pair((check_key, check_value)) = &*pair { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:110:17 [INFO] [stdout] | [INFO] [stdout] 110 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 108 ~ let (check_key, _) = match &*pair { PairWrapper::Pair((check_key, check_value)) => { [INFO] [stdout] 109 | (check_key, check_value) [INFO] [stdout] 110 ~ } _ => { [INFO] [stdout] 111 | continue; [INFO] [stdout] 112 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:139:41 [INFO] [stdout] | [INFO] [stdout] 139 | let (check_key, _) = if let PairWrapper::Pair((check_key, check_value)) = &*pair { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:141:17 [INFO] [stdout] | [INFO] [stdout] 141 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 139 ~ let (check_key, _) = match &*pair { PairWrapper::Pair((check_key, check_value)) => { [INFO] [stdout] 140 | (check_key, check_value) [INFO] [stdout] 141 ~ } _ => { [INFO] [stdout] 142 | continue; [INFO] [stdout] 143 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:150:37 [INFO] [stdout] | [INFO] [stdout] 150 | let (check_key, _) = if let PairWrapper::Pair((check_key, check_value)) = &*pair { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:152:13 [INFO] [stdout] | [INFO] [stdout] 152 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 150 ~ let (check_key, _) = match &*pair { PairWrapper::Pair((check_key, check_value)) => { [INFO] [stdout] 151 | (check_key, check_value) [INFO] [stdout] 152 ~ } _ => { [INFO] [stdout] 153 | continue; [INFO] [stdout] 154 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:221:31 [INFO] [stdout] | [INFO] [stdout] 221 | let (key, value) = if let Some((key, value)) = refund { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:223:9 [INFO] [stdout] | [INFO] [stdout] 223 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 221 ~ let (key, value) = match refund { Some((key, value)) => { [INFO] [stdout] 222 | (key, value) [INFO] [stdout] 223 ~ } _ => { [INFO] [stdout] 224 | start_bucket.unlock(); [INFO] [stdout] 225 | return None; [INFO] [stdout] 226 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:276:20 [INFO] [stdout] | [INFO] [stdout] 276 | if let PairWrapper::Pair((check_key, check_value)) = &*pair { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:278:17 [INFO] [stdout] | [INFO] [stdout] 278 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 276 ~ match &*pair { PairWrapper::Pair((check_key, check_value)) => { [INFO] [stdout] 277 | (check_key, check_value) [INFO] [stdout] 278 ~ } _ => { [INFO] [stdout] 279 | return None; [INFO] [stdout] 280 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:347:20 [INFO] [stdout] | [INFO] [stdout] 347 | if let PairWrapper::Pair((check_key, _)) = &*pair { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:351:17 [INFO] [stdout] | [INFO] [stdout] 351 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 347 ~ match &*pair { PairWrapper::Pair((check_key, _)) => { [INFO] [stdout] 348 | if key != check_key { [INFO] [stdout] 349 | continue; [INFO] [stdout] 350 | } [INFO] [stdout] 351 ~ } _ => { [INFO] [stdout] 352 | continue; [INFO] [stdout] 353 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:357:16 [INFO] [stdout] | [INFO] [stdout] 357 | if let PairWrapper::Pair((check_key, _)) = &*pair { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:361:13 [INFO] [stdout] | [INFO] [stdout] 361 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 357 ~ match &*pair { PairWrapper::Pair((check_key, _)) => { [INFO] [stdout] 358 | if key != check_key { [INFO] [stdout] 359 | continue; [INFO] [stdout] 360 | } [INFO] [stdout] 361 ~ } _ => { [INFO] [stdout] 362 | continue; [INFO] [stdout] 363 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:389:41 [INFO] [stdout] | [INFO] [stdout] 389 | let (check_key, _) = if let PairWrapper::Pair((check_key, check_value)) = &*pair { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:391:17 [INFO] [stdout] | [INFO] [stdout] 391 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 389 ~ let (check_key, _) = match &*pair { PairWrapper::Pair((check_key, check_value)) => { [INFO] [stdout] 390 | (check_key, check_value) [INFO] [stdout] 391 ~ } _ => { [INFO] [stdout] 392 | continue; [INFO] [stdout] 393 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:417:37 [INFO] [stdout] | [INFO] [stdout] 417 | let (check_key, _) = if let PairWrapper::Pair((check_key, check_value)) = &*pair { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:419:13 [INFO] [stdout] | [INFO] [stdout] 419 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 417 ~ let (check_key, _) = match &*pair { PairWrapper::Pair((check_key, check_value)) => { [INFO] [stdout] 418 | (check_key, check_value) [INFO] [stdout] 419 ~ } _ => { [INFO] [stdout] 420 | continue; [INFO] [stdout] 421 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:496:35 [INFO] [stdout] | [INFO] [stdout] 496 | let (key, value) = if let PairWrapper::Pair((key, value)) = pair { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:498:13 [INFO] [stdout] | [INFO] [stdout] 498 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 496 ~ let (key, value) = match pair { PairWrapper::Pair((key, value)) => { [INFO] [stdout] 497 | (key, value) [INFO] [stdout] 498 ~ } _ => { [INFO] [stdout] 499 | continue; [INFO] [stdout] 500 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:514:20 [INFO] [stdout] | [INFO] [stdout] 514 | if let Some((my_key, my_value)) = segment.set(key, value) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:517:17 [INFO] [stdout] | [INFO] [stdout] 517 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 514 ~ match segment.set(key, value) { Some((my_key, my_value)) => { [INFO] [stdout] 515 | key = my_key; [INFO] [stdout] 516 | value = my_value; [INFO] [stdout] 517 ~ } _ => { [INFO] [stdout] 518 | return; [INFO] [stdout] 519 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/kv.rs:252:16 [INFO] [stdout] | [INFO] [stdout] 252 | if let Some(result) = self.iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^---------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/kv.rs:258:13 [INFO] [stdout] | [INFO] [stdout] 258 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 252 ~ match self.iter.next() { Some(result) => { [INFO] [stdout] 253 | self.still_running = true; [INFO] [stdout] ... [INFO] [stdout] 257 | }; [INFO] [stdout] 258 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/kv.rs:295:20 [INFO] [stdout] | [INFO] [stdout] 295 | if let Err(err) = runner.step() { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/kv.rs:297:17 [INFO] [stdout] | [INFO] [stdout] 297 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 295 ~ match runner.step() { Err(err) => { [INFO] [stdout] 296 | return Some(Err(err)); [INFO] [stdout] 297 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/kv.rs:334:16 [INFO] [stdout] | [INFO] [stdout] 334 | if let Err(err) = self.runners[idx].step() { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/kv.rs:336:13 [INFO] [stdout] | [INFO] [stdout] 336 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 334 ~ match self.runners[idx].step() { Err(err) => { [INFO] [stdout] 335 | return Some(Err(err)); [INFO] [stdout] 336 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/kv.rs:427:12 [INFO] [stdout] | [INFO] [stdout] 427 | if let Some(last_a) = self.a.last_pair.as_ref() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^------^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 448 | } else if let Some(last_b) = self.b.last_pair.as_ref() { [INFO] [stdout] | ------ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/kv.rs:448:9 [INFO] [stdout] | [INFO] [stdout] 448 | } else if let Some(last_b) = self.b.last_pair.as_ref() { [INFO] [stdout] | ^ [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/kv.rs:451:9 [INFO] [stdout] | [INFO] [stdout] 451 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 427 ~ match self.a.last_pair.as_ref() { Some(last_a) => { [INFO] [stdout] 428 | if let Some(last_b) = self.b.last_pair.as_ref() { [INFO] [stdout] ... [INFO] [stdout] 447 | } [INFO] [stdout] 448 ~ } _ => { match self.b.last_pair.as_ref() { Some(last_b) => { [INFO] [stdout] 449 | step_b = true; [INFO] [stdout] 450 | next_pair = Some(last_b.clone()); [INFO] [stdout] 451 ~ } _ => {}}}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/kv.rs:428:16 [INFO] [stdout] | [INFO] [stdout] 428 | if let Some(last_b) = self.b.last_pair.as_ref() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^------^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/kv.rs:444:13 [INFO] [stdout] | [INFO] [stdout] 444 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 428 ~ match self.b.last_pair.as_ref() { Some(last_b) => { [INFO] [stdout] 429 | match cmp_key(last_a.key_ref(), last_b.key_ref()) { [INFO] [stdout] ... [INFO] [stdout] 443 | } [INFO] [stdout] 444 ~ } _ => { [INFO] [stdout] 445 | step_a = true; [INFO] [stdout] 446 | next_pair = Some(last_a.clone()); [INFO] [stdout] 447 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/kv.rs:453:16 [INFO] [stdout] | [INFO] [stdout] 453 | if let Err(err) = self.a.step() { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/kv.rs:455:13 [INFO] [stdout] | [INFO] [stdout] 455 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 453 ~ match self.a.step() { Err(err) => { [INFO] [stdout] 454 | return Some(Err(E::from(err))); [INFO] [stdout] 455 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/kv.rs:458:16 [INFO] [stdout] | [INFO] [stdout] 458 | if let Err(err) = self.b.step() { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/kv.rs:460:13 [INFO] [stdout] | [INFO] [stdout] 460 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 458 ~ match self.b.step() { Err(err) => { [INFO] [stdout] 459 | return Some(Err(E::from(err))); [INFO] [stdout] 460 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/mem_queue.rs:289:12 [INFO] [stdout] | [INFO] [stdout] 289 | if let Some(arc) = last_non_compacted { [INFO] [stdout] | ^^^^^^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/mem_queue.rs:292:9 [INFO] [stdout] | [INFO] [stdout] 292 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 289 ~ match last_non_compacted { Some(arc) => { [INFO] [stdout] 290 | let mut entry = arc.write().unwrap(); [INFO] [stdout] 291 | entry.next = None; [INFO] [stdout] 292 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/mem_table.rs:242:16 [INFO] [stdout] | [INFO] [stdout] 242 | if let Err(err) = mem_table.rotate() { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/mem_table.rs:244:13 [INFO] [stdout] | [INFO] [stdout] 244 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 242 ~ match mem_table.rotate() { Err(err) => { [INFO] [stdout] 243 | error!(mem_table.ctx.logger(), "error rotating wal: {:?}", err); [INFO] [stdout] 244 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/mem_table.rs:337:28 [INFO] [stdout] | [INFO] [stdout] 337 | if let Err(err) = my_self.rotate() { [INFO] [stdout] | ^^^^^^^^^^^^^^^---------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/mem_table.rs:339:25 [INFO] [stdout] | [INFO] [stdout] 339 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 337 ~ match my_self.rotate() { Err(err) => { [INFO] [stdout] 338 | error!(my_self.ctx.logger(), "error rotating wal: {:?}", err); [INFO] [stdout] 339 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/sst/reader.rs:267:16 [INFO] [stdout] | [INFO] [stdout] 267 | if let Some(Ok(pair)) = self.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^----------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/sst/reader.rs:273:13 [INFO] [stdout] | [INFO] [stdout] 273 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 267 ~ match self.next() { Some(Ok(pair)) => { [INFO] [stdout] 268 | if cmp_key(pair.key_ref(), key) == Ordering::Less { [INFO] [stdout] ... [INFO] [stdout] 272 | break; [INFO] [stdout] 273 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/sst/reader.rs:435:16 [INFO] [stdout] | [INFO] [stdout] 435 | if let Some(result) = scanner.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^-------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/sst/reader.rs:447:13 [INFO] [stdout] | [INFO] [stdout] 447 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 435 ~ match scanner.next() { Some(result) => { [INFO] [stdout] 436 | match result { [INFO] [stdout] ... [INFO] [stdout] 446 | } [INFO] [stdout] 447 ~ } _ => { [INFO] [stdout] 448 | return Ok(None); [INFO] [stdout] 449 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/sst/writer.rs:288:30 [INFO] [stdout] | [INFO] [stdout] 288 | let highest_key = if let Some(k) = self.highest_key { [INFO] [stdout] | ^^^^^^^^^^^^^^----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/sst/writer.rs:290:9 [INFO] [stdout] | [INFO] [stdout] 290 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 288 ~ let highest_key = match self.highest_key { Some(k) => { [INFO] [stdout] 289 | k [INFO] [stdout] 290 ~ } _ => { [INFO] [stdout] 291 | return Err(SstError::EmptySst("highest key is none".to_string())); [INFO] [stdout] 292 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/sst/writer.rs:293:29 [INFO] [stdout] | [INFO] [stdout] 293 | let lowest_key = if let Some(k) = self.lowest_key { [INFO] [stdout] | ^^^^^^^^^^^^^^----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/sst/writer.rs:295:9 [INFO] [stdout] | [INFO] [stdout] 295 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 293 ~ let lowest_key = match self.lowest_key { Some(k) => { [INFO] [stdout] 294 | k [INFO] [stdout] 295 ~ } _ => { [INFO] [stdout] 296 | return Err(SstError::EmptySst("lowest key is none".to_string())); [INFO] [stdout] 297 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/sst/writer.rs:358:20 [INFO] [stdout] | [INFO] [stdout] 358 | if let Ok(n) = f.read(&mut buf) { [INFO] [stdout] | ^^^^^^^^^^^^---------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/sst/writer.rs:362:17 [INFO] [stdout] | [INFO] [stdout] 362 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 358 ~ match f.read(&mut buf) { Ok(n) => { [INFO] [stdout] 359 | if n == 16 { [INFO] [stdout] 360 | base_name = buf.map(|b| b.to_string()).into_iter().collect(); [INFO] [stdout] 361 | } [INFO] [stdout] 362 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/storage/blob_store.rs:189:23 [INFO] [stdout] | [INFO] [stdout] 189 | let blob = if let Some(blob) = blob_store.blobs.get(&self.blob_name) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^----------^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/storage/blob_store.rs:191:9 [INFO] [stdout] | [INFO] [stdout] 191 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 189 ~ let blob = match blob_store.blobs.get(&self.blob_name) { Some(blob) => { [INFO] [stdout] 190 | blob [INFO] [stdout] 191 ~ } _ => { [INFO] [stdout] 192 | return Err(BlobStoreError::NotFound); [INFO] [stdout] 193 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/storage/blob_store.rs:530:40 [INFO] [stdout] | [INFO] [stdout] 530 | let file_name = if let Some(name) = dir_entry.file_name().to_str() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^---------^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/storage/blob_store.rs:532:21 [INFO] [stdout] | [INFO] [stdout] 532 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 530 ~ let file_name = match dir_entry.file_name().to_str() { Some(name) => { [INFO] [stdout] 531 | name.to_string() [INFO] [stdout] 532 ~ } _ => { [INFO] [stdout] 533 | return Err(BlobStoreError::UnknownError); [INFO] [stdout] 534 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/tablet.rs:223:16 [INFO] [stdout] | [INFO] [stdout] 223 | if let Some((i, _)) = levels [INFO] [stdout] | ^ ------ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | ________________| [INFO] [stdout] | | [INFO] [stdout] 224 | | .iter() [INFO] [stdout] 225 | | .enumerate() [INFO] [stdout] 226 | | .take(MAX_NUM_LEVELS - 1) [INFO] [stdout] 227 | | .find(|(_, level)| !level.is_empty()) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/tablet.rs:230:13 [INFO] [stdout] | [INFO] [stdout] 230 | } else if !minors.is_empty() { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 223 ~ match levels [INFO] [stdout] 224 | .iter() [INFO] [stdout] ... [INFO] [stdout] 227 | .find(|(_, level)| !level.is_empty()) [INFO] [stdout] 228 ~ { Some((i, _)) => { [INFO] [stdout] 229 | source_level = i; [INFO] [stdout] 230 ~ } _ => if !minors.is_empty() { [INFO] [stdout] 231 | return Some(CompactOrder::major( [INFO] [stdout] ... [INFO] [stdout] 239 | return None; [INFO] [stdout] 240 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/tablet.rs:351:16 [INFO] [stdout] | [INFO] [stdout] 351 | if let Some(value) = minor.get(ctx, key)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^-------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/tablet.rs:353:13 [INFO] [stdout] | [INFO] [stdout] 353 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 351 ~ match minor.get(ctx, key)? { Some(value) => { [INFO] [stdout] 352 | return Ok(Some(value)); [INFO] [stdout] 353 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/tablet.rs:559:19 [INFO] [stdout] | [INFO] [stdout] 559 | while let Ok(message) = compactor_rx.recv() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/tablet.rs:561:13 [INFO] [stdout] | [INFO] [stdout] 561 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/tablet.rs:857:20 [INFO] [stdout] | [INFO] [stdout] 857 | if let Err(err) = child.join() { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/tablet.rs:859:17 [INFO] [stdout] | [INFO] [stdout] 859 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 857 ~ match child.join() { Err(err) => { [INFO] [stdout] 858 | panic!("Error joining thread: {:?}", err); [INFO] [stdout] 859 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/wal/wal_wrapper.rs:348:15 [INFO] [stdout] | [INFO] [stdout] 348 | while let Ok((block, next_checksum)) = WalEntryBlock::recover(&mut reader, checksum) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/wal/wal_wrapper.rs:409:9 [INFO] [stdout] | [INFO] [stdout] 409 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/wal/wal_writer.rs:68:15 [INFO] [stdout] | [INFO] [stdout] 68 | while let Ok(WalRequestWrapper { request, result_tx }) = self.request_rx.recv() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/wal/wal_writer.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/wal/wal_writer.rs:92:20 [INFO] [stdout] | [INFO] [stdout] 92 | if let Some(tx) = wal_entry_tx { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/wal/wal_writer.rs:94:17 [INFO] [stdout] | [INFO] [stdout] 94 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 92 ~ match wal_entry_tx { Some(tx) => { [INFO] [stdout] 93 | tx.send(Ok(())).unwrap(); [INFO] [stdout] 94 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/wal/wal_writer.rs:117:28 [INFO] [stdout] | [INFO] [stdout] 117 | if let Some(tx) = tx { [INFO] [stdout] | ^^^^^^^^^^^^^^^-- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/wal/wal_writer.rs:119:25 [INFO] [stdout] | [INFO] [stdout] 119 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 117 ~ match tx { Some(tx) => { [INFO] [stdout] 118 | tx.send(Err(err.clone())).unwrap(); [INFO] [stdout] 119 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 55 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `anvil_db` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/helpful_macros.rs [INFO] [stderr] * src/logging.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/helpful_macros.rs:31:6 [INFO] [stderr] | [INFO] [stderr] 31 | ($stmt:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/logging.rs:70:6 [INFO] [stderr] | [INFO] [stderr] 70 | ($logger:expr_2021, $($arg:tt)*) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/logging.rs:77:6 [INFO] [stderr] | [INFO] [stderr] 77 | ($logger:expr_2021, $($arg:tt)*) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/concurrent_skip_list.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 21 | fn gen(&self) -> u64 { [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/concurrent_skip_list.rs:600:26 [INFO] [stdout] | [INFO] [stdout] 600 | while ((self.rng.gen() % 10_000) as f64) < p * 10_000.0 && lvl < self.max_level - 1 { [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/concurrent_skip_list.rs:837:31 [INFO] [stdout] | [INFO] [stdout] 837 | let num = rng.gen(); [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/helpful_macros.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 31 | ($stmt:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 31 | ($stmt:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/logging.rs:70:14 [INFO] [stdout] | [INFO] [stdout] 70 | ($logger:expr, $($arg:tt)*) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 70 | ($logger:expr_2021, $($arg:tt)*) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/logging.rs:77:14 [INFO] [stdout] | [INFO] [stdout] 77 | ($logger:expr, $($arg:tt)*) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 77 | ($logger:expr_2021, $($arg:tt)*) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `KeyValuePointReader` is never used [INFO] [stdout] --> src/kv.rs:10:18 [INFO] [stdout] | [INFO] [stdout] 10 | pub(crate) trait KeyValuePointReader { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `AsyncTombstoneIterator` is never used [INFO] [stdout] --> src/kv.rs:201:18 [INFO] [stdout] | [INFO] [stdout] 201 | pub(crate) trait AsyncTombstoneIterator: [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `TryAsyncTombstoneScanner` is never used [INFO] [stdout] --> src/kv.rs:223:18 [INFO] [stdout] | [INFO] [stdout] 223 | pub(crate) trait TryAsyncTombstoneScanner { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `read_exact` is never used [INFO] [stdout] --> src/sst/block_cache/cache.rs:19:8 [INFO] [stdout] | [INFO] [stdout] 15 | pub(crate) trait BlockCache: Clone { [INFO] [stdout] | ---------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 19 | fn read_exact( [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `BlockTooSmall` is never constructed [INFO] [stdout] --> src/sst/block_cache/common.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub(crate) enum CacheError { [INFO] [stdout] | ---------- variant in this enum [INFO] [stdout] 8 | Read(String), [INFO] [stdout] 9 | BlockTooSmall, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CacheError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_sst_reader` is never used [INFO] [stdout] --> src/tablet.rs:117:8 [INFO] [stdout] | [INFO] [stdout] 102 | pub(crate) trait TabletSstStore: Clone + TombstonePointReader + TryTombstoneScanner { [INFO] [stdout] | -------------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 117 | fn get_sst_reader(&self, blob_id: &str) -> Option; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/compactor.rs:429:28 [INFO] [stdout] | [INFO] [stdout] 429 | if let Some(order) = [INFO] [stdout] | ____________________________^ [INFO] [stdout] 430 | | self.sst_store.request_task(&TaskCategory::MajorCompaction) [INFO] [stdout] | |_____________________________----------------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/compactor.rs:442:25 [INFO] [stdout] | [INFO] [stdout] 442 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 429 ~ match self.sst_store.request_task(&TaskCategory::MajorCompaction) [INFO] [stdout] 430 ~ { Some(order) => { [INFO] [stdout] 431 | match self.compact_result(&order) { [INFO] [stdout] ... [INFO] [stdout] 440 | } [INFO] [stdout] 441 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/compactor.rs:446:28 [INFO] [stdout] | [INFO] [stdout] 446 | if let Some(done_tx) = done_tx { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/compactor.rs:453:25 [INFO] [stdout] | [INFO] [stdout] 453 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 446 ~ match done_tx { Some(done_tx) => { [INFO] [stdout] 447 | done_tx [INFO] [stdout] ... [INFO] [stdout] 452 | .unwrap(); [INFO] [stdout] 453 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/compactor.rs:464:20 [INFO] [stdout] | [INFO] [stdout] 464 | if let Ok(new_sst_readers) = self.compact_result(&order) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^--------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/compactor.rs:468:17 [INFO] [stdout] | [INFO] [stdout] 468 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 464 ~ match self.compact_result(&order) { Ok(new_sst_readers) => { [INFO] [stdout] 465 | self.sst_store [INFO] [stdout] 466 | .handle_finished_task(&order, new_sst_readers.into_iter()); [INFO] [stdout] 467 | continue; [INFO] [stdout] 468 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:96:45 [INFO] [stdout] | [INFO] [stdout] 96 | let (check_key, _) = if let PairWrapper::Pair((check_key, check_value)) = &*pair [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:99:21 [INFO] [stdout] | [INFO] [stdout] 99 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 96 ~ let (check_key, _) = match &*pair [INFO] [stdout] 97 ~ { PairWrapper::Pair((check_key, check_value)) => { [INFO] [stdout] 98 | (check_key, check_value) [INFO] [stdout] 99 ~ } _ => { [INFO] [stdout] 100| continue; [INFO] [stdout] 101~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:108:41 [INFO] [stdout] | [INFO] [stdout] 108 | let (check_key, _) = if let PairWrapper::Pair((check_key, check_value)) = &*pair { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:110:17 [INFO] [stdout] | [INFO] [stdout] 110 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 108 ~ let (check_key, _) = match &*pair { PairWrapper::Pair((check_key, check_value)) => { [INFO] [stdout] 109 | (check_key, check_value) [INFO] [stdout] 110 ~ } _ => { [INFO] [stdout] 111 | continue; [INFO] [stdout] 112 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:139:41 [INFO] [stdout] | [INFO] [stdout] 139 | let (check_key, _) = if let PairWrapper::Pair((check_key, check_value)) = &*pair { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:141:17 [INFO] [stdout] | [INFO] [stdout] 141 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 139 ~ let (check_key, _) = match &*pair { PairWrapper::Pair((check_key, check_value)) => { [INFO] [stdout] 140 | (check_key, check_value) [INFO] [stdout] 141 ~ } _ => { [INFO] [stdout] 142 | continue; [INFO] [stdout] 143 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:150:37 [INFO] [stdout] | [INFO] [stdout] 150 | let (check_key, _) = if let PairWrapper::Pair((check_key, check_value)) = &*pair { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:152:13 [INFO] [stdout] | [INFO] [stdout] 152 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 150 ~ let (check_key, _) = match &*pair { PairWrapper::Pair((check_key, check_value)) => { [INFO] [stdout] 151 | (check_key, check_value) [INFO] [stdout] 152 ~ } _ => { [INFO] [stdout] 153 | continue; [INFO] [stdout] 154 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:221:31 [INFO] [stdout] | [INFO] [stdout] 221 | let (key, value) = if let Some((key, value)) = refund { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:223:9 [INFO] [stdout] | [INFO] [stdout] 223 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 221 ~ let (key, value) = match refund { Some((key, value)) => { [INFO] [stdout] 222 | (key, value) [INFO] [stdout] 223 ~ } _ => { [INFO] [stdout] 224 | start_bucket.unlock(); [INFO] [stdout] 225 | return None; [INFO] [stdout] 226 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:276:20 [INFO] [stdout] | [INFO] [stdout] 276 | if let PairWrapper::Pair((check_key, check_value)) = &*pair { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:278:17 [INFO] [stdout] | [INFO] [stdout] 278 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 276 ~ match &*pair { PairWrapper::Pair((check_key, check_value)) => { [INFO] [stdout] 277 | (check_key, check_value) [INFO] [stdout] 278 ~ } _ => { [INFO] [stdout] 279 | return None; [INFO] [stdout] 280 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:347:20 [INFO] [stdout] | [INFO] [stdout] 347 | if let PairWrapper::Pair((check_key, _)) = &*pair { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:351:17 [INFO] [stdout] | [INFO] [stdout] 351 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 347 ~ match &*pair { PairWrapper::Pair((check_key, _)) => { [INFO] [stdout] 348 | if key != check_key { [INFO] [stdout] 349 | continue; [INFO] [stdout] 350 | } [INFO] [stdout] 351 ~ } _ => { [INFO] [stdout] 352 | continue; [INFO] [stdout] 353 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:357:16 [INFO] [stdout] | [INFO] [stdout] 357 | if let PairWrapper::Pair((check_key, _)) = &*pair { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:361:13 [INFO] [stdout] | [INFO] [stdout] 361 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 357 ~ match &*pair { PairWrapper::Pair((check_key, _)) => { [INFO] [stdout] 358 | if key != check_key { [INFO] [stdout] 359 | continue; [INFO] [stdout] 360 | } [INFO] [stdout] 361 ~ } _ => { [INFO] [stdout] 362 | continue; [INFO] [stdout] 363 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:389:41 [INFO] [stdout] | [INFO] [stdout] 389 | let (check_key, _) = if let PairWrapper::Pair((check_key, check_value)) = &*pair { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:391:17 [INFO] [stdout] | [INFO] [stdout] 391 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 389 ~ let (check_key, _) = match &*pair { PairWrapper::Pair((check_key, check_value)) => { [INFO] [stdout] 390 | (check_key, check_value) [INFO] [stdout] 391 ~ } _ => { [INFO] [stdout] 392 | continue; [INFO] [stdout] 393 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:417:37 [INFO] [stdout] | [INFO] [stdout] 417 | let (check_key, _) = if let PairWrapper::Pair((check_key, check_value)) = &*pair { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:419:13 [INFO] [stdout] | [INFO] [stdout] 419 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 417 ~ let (check_key, _) = match &*pair { PairWrapper::Pair((check_key, check_value)) => { [INFO] [stdout] 418 | (check_key, check_value) [INFO] [stdout] 419 ~ } _ => { [INFO] [stdout] 420 | continue; [INFO] [stdout] 421 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:496:35 [INFO] [stdout] | [INFO] [stdout] 496 | let (key, value) = if let PairWrapper::Pair((key, value)) = pair { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:498:13 [INFO] [stdout] | [INFO] [stdout] 498 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 496 ~ let (key, value) = match pair { PairWrapper::Pair((key, value)) => { [INFO] [stdout] 497 | (key, value) [INFO] [stdout] 498 ~ } _ => { [INFO] [stdout] 499 | continue; [INFO] [stdout] 500 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:514:20 [INFO] [stdout] | [INFO] [stdout] 514 | if let Some((my_key, my_value)) = segment.set(key, value) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/hopscotch.rs:517:17 [INFO] [stdout] | [INFO] [stdout] 517 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 514 ~ match segment.set(key, value) { Some((my_key, my_value)) => { [INFO] [stdout] 515 | key = my_key; [INFO] [stdout] 516 | value = my_value; [INFO] [stdout] 517 ~ } _ => { [INFO] [stdout] 518 | return; [INFO] [stdout] 519 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/kv.rs:252:16 [INFO] [stdout] | [INFO] [stdout] 252 | if let Some(result) = self.iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^---------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/kv.rs:258:13 [INFO] [stdout] | [INFO] [stdout] 258 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 252 ~ match self.iter.next() { Some(result) => { [INFO] [stdout] 253 | self.still_running = true; [INFO] [stdout] ... [INFO] [stdout] 257 | }; [INFO] [stdout] 258 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/kv.rs:295:20 [INFO] [stdout] | [INFO] [stdout] 295 | if let Err(err) = runner.step() { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/kv.rs:297:17 [INFO] [stdout] | [INFO] [stdout] 297 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 295 ~ match runner.step() { Err(err) => { [INFO] [stdout] 296 | return Some(Err(err)); [INFO] [stdout] 297 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/kv.rs:334:16 [INFO] [stdout] | [INFO] [stdout] 334 | if let Err(err) = self.runners[idx].step() { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/kv.rs:336:13 [INFO] [stdout] | [INFO] [stdout] 336 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 334 ~ match self.runners[idx].step() { Err(err) => { [INFO] [stdout] 335 | return Some(Err(err)); [INFO] [stdout] 336 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/kv.rs:427:12 [INFO] [stdout] | [INFO] [stdout] 427 | if let Some(last_a) = self.a.last_pair.as_ref() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^------^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 448 | } else if let Some(last_b) = self.b.last_pair.as_ref() { [INFO] [stdout] | ------ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/kv.rs:448:9 [INFO] [stdout] | [INFO] [stdout] 448 | } else if let Some(last_b) = self.b.last_pair.as_ref() { [INFO] [stdout] | ^ [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/kv.rs:451:9 [INFO] [stdout] | [INFO] [stdout] 451 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 427 ~ match self.a.last_pair.as_ref() { Some(last_a) => { [INFO] [stdout] 428 | if let Some(last_b) = self.b.last_pair.as_ref() { [INFO] [stdout] ... [INFO] [stdout] 447 | } [INFO] [stdout] 448 ~ } _ => { match self.b.last_pair.as_ref() { Some(last_b) => { [INFO] [stdout] 449 | step_b = true; [INFO] [stdout] 450 | next_pair = Some(last_b.clone()); [INFO] [stdout] 451 ~ } _ => {}}}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/kv.rs:428:16 [INFO] [stdout] | [INFO] [stdout] 428 | if let Some(last_b) = self.b.last_pair.as_ref() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^------^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/kv.rs:444:13 [INFO] [stdout] | [INFO] [stdout] 444 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 428 ~ match self.b.last_pair.as_ref() { Some(last_b) => { [INFO] [stdout] 429 | match cmp_key(last_a.key_ref(), last_b.key_ref()) { [INFO] [stdout] ... [INFO] [stdout] 443 | } [INFO] [stdout] 444 ~ } _ => { [INFO] [stdout] 445 | step_a = true; [INFO] [stdout] 446 | next_pair = Some(last_a.clone()); [INFO] [stdout] 447 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/kv.rs:453:16 [INFO] [stdout] | [INFO] [stdout] 453 | if let Err(err) = self.a.step() { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/kv.rs:455:13 [INFO] [stdout] | [INFO] [stdout] 455 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 453 ~ match self.a.step() { Err(err) => { [INFO] [stdout] 454 | return Some(Err(E::from(err))); [INFO] [stdout] 455 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/kv.rs:458:16 [INFO] [stdout] | [INFO] [stdout] 458 | if let Err(err) = self.b.step() { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/kv.rs:460:13 [INFO] [stdout] | [INFO] [stdout] 460 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 458 ~ match self.b.step() { Err(err) => { [INFO] [stdout] 459 | return Some(Err(E::from(err))); [INFO] [stdout] 460 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/mem_queue.rs:289:12 [INFO] [stdout] | [INFO] [stdout] 289 | if let Some(arc) = last_non_compacted { [INFO] [stdout] | ^^^^^^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/mem_queue.rs:292:9 [INFO] [stdout] | [INFO] [stdout] 292 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 289 ~ match last_non_compacted { Some(arc) => { [INFO] [stdout] 290 | let mut entry = arc.write().unwrap(); [INFO] [stdout] 291 | entry.next = None; [INFO] [stdout] 292 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/mem_table.rs:242:16 [INFO] [stdout] | [INFO] [stdout] 242 | if let Err(err) = mem_table.rotate() { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/mem_table.rs:244:13 [INFO] [stdout] | [INFO] [stdout] 244 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 242 ~ match mem_table.rotate() { Err(err) => { [INFO] [stdout] 243 | error!(mem_table.ctx.logger(), "error rotating wal: {:?}", err); [INFO] [stdout] 244 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/mem_table.rs:337:28 [INFO] [stdout] | [INFO] [stdout] 337 | if let Err(err) = my_self.rotate() { [INFO] [stdout] | ^^^^^^^^^^^^^^^---------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/mem_table.rs:339:25 [INFO] [stdout] | [INFO] [stdout] 339 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 337 ~ match my_self.rotate() { Err(err) => { [INFO] [stdout] 338 | error!(my_self.ctx.logger(), "error rotating wal: {:?}", err); [INFO] [stdout] 339 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/sst/reader.rs:267:16 [INFO] [stdout] | [INFO] [stdout] 267 | if let Some(Ok(pair)) = self.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^----------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/sst/reader.rs:273:13 [INFO] [stdout] | [INFO] [stdout] 273 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 267 ~ match self.next() { Some(Ok(pair)) => { [INFO] [stdout] 268 | if cmp_key(pair.key_ref(), key) == Ordering::Less { [INFO] [stdout] ... [INFO] [stdout] 272 | break; [INFO] [stdout] 273 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/sst/reader.rs:435:16 [INFO] [stdout] | [INFO] [stdout] 435 | if let Some(result) = scanner.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^-------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/sst/reader.rs:447:13 [INFO] [stdout] | [INFO] [stdout] 447 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 435 ~ match scanner.next() { Some(result) => { [INFO] [stdout] 436 | match result { [INFO] [stdout] ... [INFO] [stdout] 446 | } [INFO] [stdout] 447 ~ } _ => { [INFO] [stdout] 448 | return Ok(None); [INFO] [stdout] 449 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/sst/writer.rs:288:30 [INFO] [stdout] | [INFO] [stdout] 288 | let highest_key = if let Some(k) = self.highest_key { [INFO] [stdout] | ^^^^^^^^^^^^^^----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/sst/writer.rs:290:9 [INFO] [stdout] | [INFO] [stdout] 290 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 288 ~ let highest_key = match self.highest_key { Some(k) => { [INFO] [stdout] 289 | k [INFO] [stdout] 290 ~ } _ => { [INFO] [stdout] 291 | return Err(SstError::EmptySst("highest key is none".to_string())); [INFO] [stdout] 292 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/sst/writer.rs:293:29 [INFO] [stdout] | [INFO] [stdout] 293 | let lowest_key = if let Some(k) = self.lowest_key { [INFO] [stdout] | ^^^^^^^^^^^^^^----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/sst/writer.rs:295:9 [INFO] [stdout] | [INFO] [stdout] 295 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 293 ~ let lowest_key = match self.lowest_key { Some(k) => { [INFO] [stdout] 294 | k [INFO] [stdout] 295 ~ } _ => { [INFO] [stdout] 296 | return Err(SstError::EmptySst("lowest key is none".to_string())); [INFO] [stdout] 297 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/sst/writer.rs:358:20 [INFO] [stdout] | [INFO] [stdout] 358 | if let Ok(n) = f.read(&mut buf) { [INFO] [stdout] | ^^^^^^^^^^^^---------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/sst/writer.rs:362:17 [INFO] [stdout] | [INFO] [stdout] 362 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 358 ~ match f.read(&mut buf) { Ok(n) => { [INFO] [stdout] 359 | if n == 16 { [INFO] [stdout] 360 | base_name = buf.map(|b| b.to_string()).into_iter().collect(); [INFO] [stdout] 361 | } [INFO] [stdout] 362 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/storage/blob_store.rs:189:23 [INFO] [stdout] | [INFO] [stdout] 189 | let blob = if let Some(blob) = blob_store.blobs.get(&self.blob_name) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^----------^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/storage/blob_store.rs:191:9 [INFO] [stdout] | [INFO] [stdout] 191 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 189 ~ let blob = match blob_store.blobs.get(&self.blob_name) { Some(blob) => { [INFO] [stdout] 190 | blob [INFO] [stdout] 191 ~ } _ => { [INFO] [stdout] 192 | return Err(BlobStoreError::NotFound); [INFO] [stdout] 193 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/storage/blob_store.rs:530:40 [INFO] [stdout] | [INFO] [stdout] 530 | let file_name = if let Some(name) = dir_entry.file_name().to_str() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^---------^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/storage/blob_store.rs:532:21 [INFO] [stdout] | [INFO] [stdout] 532 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 530 ~ let file_name = match dir_entry.file_name().to_str() { Some(name) => { [INFO] [stdout] 531 | name.to_string() [INFO] [stdout] 532 ~ } _ => { [INFO] [stdout] 533 | return Err(BlobStoreError::UnknownError); [INFO] [stdout] 534 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/tablet.rs:223:16 [INFO] [stdout] | [INFO] [stdout] 223 | if let Some((i, _)) = levels [INFO] [stdout] | ^ ------ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | ________________| [INFO] [stdout] | | [INFO] [stdout] 224 | | .iter() [INFO] [stdout] 225 | | .enumerate() [INFO] [stdout] 226 | | .take(MAX_NUM_LEVELS - 1) [INFO] [stdout] 227 | | .find(|(_, level)| !level.is_empty()) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/tablet.rs:230:13 [INFO] [stdout] | [INFO] [stdout] 230 | } else if !minors.is_empty() { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 223 ~ match levels [INFO] [stdout] 224 | .iter() [INFO] [stdout] ... [INFO] [stdout] 227 | .find(|(_, level)| !level.is_empty()) [INFO] [stdout] 228 ~ { Some((i, _)) => { [INFO] [stdout] 229 | source_level = i; [INFO] [stdout] 230 ~ } _ => if !minors.is_empty() { [INFO] [stdout] 231 | return Some(CompactOrder::major( [INFO] [stdout] ... [INFO] [stdout] 239 | return None; [INFO] [stdout] 240 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/tablet.rs:351:16 [INFO] [stdout] | [INFO] [stdout] 351 | if let Some(value) = minor.get(ctx, key)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^-------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/tablet.rs:353:13 [INFO] [stdout] | [INFO] [stdout] 353 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 351 ~ match minor.get(ctx, key)? { Some(value) => { [INFO] [stdout] 352 | return Ok(Some(value)); [INFO] [stdout] 353 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/wal/wal_wrapper.rs:348:15 [INFO] [stdout] | [INFO] [stdout] 348 | while let Ok((block, next_checksum)) = WalEntryBlock::recover(&mut reader, checksum) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/wal/wal_wrapper.rs:409:9 [INFO] [stdout] | [INFO] [stdout] 409 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/wal/wal_writer.rs:68:15 [INFO] [stdout] | [INFO] [stdout] 68 | while let Ok(WalRequestWrapper { request, result_tx }) = self.request_rx.recv() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/wal/wal_writer.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/wal/wal_writer.rs:92:20 [INFO] [stdout] | [INFO] [stdout] 92 | if let Some(tx) = wal_entry_tx { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/wal/wal_writer.rs:94:17 [INFO] [stdout] | [INFO] [stdout] 94 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 92 ~ match wal_entry_tx { Some(tx) => { [INFO] [stdout] 93 | tx.send(Ok(())).unwrap(); [INFO] [stdout] 94 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/wal/wal_writer.rs:117:28 [INFO] [stdout] | [INFO] [stdout] 117 | if let Some(tx) = tx { [INFO] [stdout] | ^^^^^^^^^^^^^^^-- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/wal/wal_writer.rs:119:25 [INFO] [stdout] | [INFO] [stdout] 119 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 117 ~ match tx { Some(tx) => { [INFO] [stdout] 118 | tx.send(Err(err.clone())).unwrap(); [INFO] [stdout] 119 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 50 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.94s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking anvil_db v0.2.1 (/tmp/fixit) [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/concurrent_skip_list.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 21 | fn gen(&self) -> u64 { [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 21 | fn r#gen(&self) -> u64 { [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/concurrent_skip_list.rs:600:26 [INFO] [stdout] | [INFO] [stdout] 600 | while ((self.rng.gen() % 10_000) as f64) < p * 10_000.0 && lvl < self.max_level - 1 { [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 600 | while ((self.rng.r#gen() % 10_000) as f64) < p * 10_000.0 && lvl < self.max_level - 1 { [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/concurrent_skip_list.rs:837:31 [INFO] [stdout] | [INFO] [stdout] 837 | let num = rng.gen(); [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 837 | let num = rng.r#gen(); [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/concurrent_skip_list.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 21 | fn gen(&self) -> u64 { [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 21 | fn r#gen(&self) -> u64 { [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/concurrent_skip_list.rs:600:26 [INFO] [stdout] | [INFO] [stdout] 600 | while ((self.rng.gen() % 10_000) as f64) < p * 10_000.0 && lvl < self.max_level - 1 { [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 600 | while ((self.rng.r#gen() % 10_000) as f64) < p * 10_000.0 && lvl < self.max_level - 1 { [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/concurrent_skip_list.rs:837:31 [INFO] [stdout] | [INFO] [stdout] 837 | let num = rng.gen(); [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 837 | let num = rng.r#gen(); [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `anvil_db` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `anvil_db` (lib test) due to 4 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "ec4cb389b6265242f66cc4bcf58744aff08eebe21e45df0f29dc2f8641286ee7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ec4cb389b6265242f66cc4bcf58744aff08eebe21e45df0f29dc2f8641286ee7", kill_on_drop: false }` [INFO] [stdout] ec4cb389b6265242f66cc4bcf58744aff08eebe21e45df0f29dc2f8641286ee7