[INFO] fetching crate ab-av1 0.7.17... [INFO] checking ab-av1-0.7.17 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate ab-av1 0.7.17 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate ab-av1 0.7.17 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ab-av1 0.7.17 [INFO] finished tweaking crates.io crate ab-av1 0.7.17 [INFO] tweaked toml for crates.io crate ab-av1 0.7.17 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate ab-av1 0.7.17 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2c459a997eee97927aa20790b99f30ba5c4e05fbab1207374704914fd8a4111b [INFO] running `Command { std: "docker" "start" "-a" "2c459a997eee97927aa20790b99f30ba5c4e05fbab1207374704914fd8a4111b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2c459a997eee97927aa20790b99f30ba5c4e05fbab1207374704914fd8a4111b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2c459a997eee97927aa20790b99f30ba5c4e05fbab1207374704914fd8a4111b", kill_on_drop: false }` [INFO] [stdout] 2c459a997eee97927aa20790b99f30ba5c4e05fbab1207374704914fd8a4111b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4247c1ff2534e73a787f063ef9176ba79faa85d5568d610daa05bf129472af79 [INFO] running `Command { std: "docker" "start" "-a" "4247c1ff2534e73a787f063ef9176ba79faa85d5568d610daa05bf129472af79", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking bytes v1.6.1 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling cc v1.1.6 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Compiling portable-atomic v1.7.0 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking constant_time_eq v0.3.0 [INFO] [stderr] Checking arrayref v0.3.8 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking infer v0.16.0 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking shell-escape v0.1.5 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Compiling blake3 v1.5.3 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking clap_builder v4.5.11 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Checking sled v0.34.7 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling clap_derive v4.5.11 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking tokio v1.39.2 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking clap v4.5.11 [INFO] [stderr] Checking clap_complete v4.5.11 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tokio-process-stream v0.4.0 [INFO] [stderr] Checking ffprobe v0.4.0 [INFO] [stderr] Checking ab-av1 v0.7.17 (/tmp/fixit) [INFO] [stderr] Migrating src/main.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `ab_av1` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/command/crf_search/err.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/command/crf_search/err.rs:34:6 [INFO] [stderr] | [INFO] [stderr] 34 | ($condition:expr_2021, $reason:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/command/crf_search/err.rs:34:28 [INFO] [stderr] | [INFO] [stderr] 34 | ($condition:expr_2021, $reason:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/command/crf_search/err.rs:46:6 [INFO] [stderr] | [INFO] [stderr] 46 | ($condition:expr_2021, $last_sample:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/command/crf_search/err.rs:46:28 [INFO] [stderr] | [INFO] [stderr] 46 | ($condition:expr_2021, $last_sample:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/command/crf_search/err.rs:34:17 [INFO] [stdout] | [INFO] [stdout] 34 | ($condition:expr, $reason:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 34 | ($condition:expr_2021, $reason:expr) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/command/crf_search/err.rs:34:31 [INFO] [stdout] | [INFO] [stdout] 34 | ($condition:expr, $reason:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 34 | ($condition:expr, $reason:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/command/crf_search/err.rs:46:17 [INFO] [stdout] | [INFO] [stdout] 46 | ($condition:expr, $last_sample:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 46 | ($condition:expr_2021, $last_sample:expr) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/command/crf_search/err.rs:46:36 [INFO] [stdout] | [INFO] [stdout] 46 | ($condition:expr, $last_sample:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 46 | ($condition:expr, $last_sample:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/main.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | env::set_var("RUST_LOG", "ab_av1=info"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] = note: `--force-warn deprecated-safe-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 34 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 35 ~ unsafe { env::set_var("RUST_LOG", "ab_av1=info") }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/main.rs:64:8 [INFO] [stdout] | [INFO] [stdout] 64 | if let Err(err) = out { [INFO] [stdout] | ^^^^^^^^^^^^^^^--- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/main.rs:67:5 [INFO] [stdout] | [INFO] [stdout] 67 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 64 ~ match out { Err(err) => { [INFO] [stdout] 65 | eprintln!("Error: {err}"); [INFO] [stdout] 66 | std::process::exit(1); [INFO] [stdout] 67 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/command/encode.rs:102:11 [INFO] [stdout] | [INFO] [stdout] 102 | while let Some(progress) = enc.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^---------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/command/encode.rs:120:5 [INFO] [stdout] | [INFO] [stdout] 120 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/command/encode.rs:108:20 [INFO] [stdout] | [INFO] [stdout] 108 | if let Ok(d) = &probe.duration { [INFO] [stdout] | ^^^^^^^^^^^^^-----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/command/encode.rs:111:17 [INFO] [stdout] | [INFO] [stdout] 111 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 108 ~ match &probe.duration { Ok(d) => { [INFO] [stdout] 109 | bar.set_position(time.as_micros_u64()); [INFO] [stdout] 110 | logger.update(*d, time, fps); [INFO] [stdout] 111 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/command/sample_encode.rs:219:23 [INFO] [stdout] | [INFO] [stdout] 219 | while let Some(progress) = output.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/command/sample_encode.rs:229:17 [INFO] [stdout] | [INFO] [stdout] 229 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/command/sample_encode.rs:220:24 [INFO] [stdout] | [INFO] [stdout] 220 | if let FfmpegOut::Progress { time, fps, .. } = progress? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/command/sample_encode.rs:228:21 [INFO] [stdout] | [INFO] [stdout] 228 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 220 ~ match progress? { FfmpegOut::Progress { time, fps, .. } => { [INFO] [stdout] 221 | bar.set_position( [INFO] [stdout] ... [INFO] [stdout] 227 | logger.update(sample_duration, time, fps); [INFO] [stdout] 228 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/command/sample_encode.rs:249:23 [INFO] [stdout] | [INFO] [stdout] 249 | while let Some(vmaf) = vmaf.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^----------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/command/sample_encode.rs:270:17 [INFO] [stdout] | [INFO] [stdout] 270 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/command/vmaf.rs:80:11 [INFO] [stdout] | [INFO] [stdout] 80 | while let Some(vmaf) = vmaf.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^----------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/command/vmaf.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl tokio_stream::Stream>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/ffmpeg.rs:75:31 [INFO] [stdout] | [INFO] [stdout] 75 | ) -> anyhow::Result<(PathBuf, impl Stream>)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, these lifetimes are in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/ffmpeg.rs:72:8 [INFO] [stdout] | [INFO] [stdout] 72 | }: FfmpegEncodeArgs, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 73 | temp_dir: Option, [INFO] [stdout] 74 | dest_ext: &str, [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] = note: `--force-warn impl-trait-overcaptures` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 75 | ) -> anyhow::Result<(PathBuf, impl Stream> + use<>)> { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl tokio_stream::Stream>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/ffmpeg.rs:130:21 [INFO] [stdout] | [INFO] [stdout] 130 | ) -> anyhow::Result>> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, these lifetimes are in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/ffmpeg.rs:125:8 [INFO] [stdout] | [INFO] [stdout] 125 | }: FfmpegEncodeArgs, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 126 | output: &Path, [INFO] [stdout] | ^ [INFO] [stdout] 127 | has_audio: bool, [INFO] [stdout] 128 | audio_codec: Option<&str>, [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 130 | ) -> anyhow::Result> + use<>> { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl tokio_stream::Stream` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/vmaf.rs:16:21 [INFO] [stdout] | [INFO] [stdout] 16 | ) -> anyhow::Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, these lifetimes are in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/vmaf.rs:13:16 [INFO] [stdout] | [INFO] [stdout] 13 | reference: &Path, [INFO] [stdout] | ^ [INFO] [stdout] 14 | distorted: &Path, [INFO] [stdout] | ^ [INFO] [stdout] 15 | filter_complex: &str, [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 16 | ) -> anyhow::Result + use<>> { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/vmaf.rs:39:15 [INFO] [stdout] | [INFO] [stdout] 39 | while let Some(next) = vmaf.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^----------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/vmaf.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/vmaf.rs:42:24 [INFO] [stdout] | [INFO] [stdout] 42 | if let Some(out) = VmafOut::try_from_chunk(&chunk, &mut chunks) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^-------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/vmaf.rs:47:21 [INFO] [stdout] | [INFO] [stdout] 47 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 42 ~ match VmafOut::try_from_chunk(&chunk, &mut chunks) { Some(out) => { [INFO] [stdout] 43 | if matches!(out, VmafOut::Done(_)) { [INFO] [stdout] ... [INFO] [stdout] 46 | yield out; [INFO] [stdout] 47 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/vmaf.rs:51:24 [INFO] [stdout] | [INFO] [stdout] 51 | if let Err(err) = exit_ok_stderr("ffmpeg vmaf", code, &cmd_str, &chunks) { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/vmaf.rs:53:21 [INFO] [stdout] | [INFO] [stdout] 53 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 51 ~ match exit_ok_stderr("ffmpeg vmaf", code, &cmd_str, &chunks) { Err(err) => { [INFO] [stdout] 52 | yield VmafOut::Err(err); [INFO] [stdout] 53 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 18 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `ab_av1` [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/command/crf_search/err.rs:34:17 [INFO] [stdout] | [INFO] [stdout] 34 | ($condition:expr, $reason:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 34 | ($condition:expr_2021, $reason:expr) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/command/crf_search/err.rs:34:31 [INFO] [stdout] | [INFO] [stdout] 34 | ($condition:expr, $reason:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 34 | ($condition:expr, $reason:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/command/crf_search/err.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/command/crf_search/err.rs:46:17 [INFO] [stdout] | [INFO] [stdout] 46 | ($condition:expr, $last_sample:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 46 | ($condition:expr_2021, $last_sample:expr) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/command/crf_search/err.rs:46:36 [INFO] [stdout] | [INFO] [stdout] 46 | ($condition:expr, $last_sample:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 46 | ($condition:expr, $last_sample:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/command/crf_search/err.rs:34:6 [INFO] [stderr] | [INFO] [stderr] 34 | ($condition:expr_2021, $reason:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/command/crf_search/err.rs:34:28 [INFO] [stderr] | [INFO] [stderr] 34 | ($condition:expr_2021, $reason:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/main.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | env::set_var("RUST_LOG", "ab_av1=info"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] = note: `--force-warn deprecated-safe-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 34 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 35 ~ unsafe { env::set_var("RUST_LOG", "ab_av1=info") }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/command/crf_search/err.rs:46:6 [INFO] [stderr] | [INFO] [stderr] 46 | ($condition:expr_2021, $last_sample:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/main.rs:64:8 [INFO] [stdout] | [INFO] [stdout] 64 | if let Err(err) = out { [INFO] [stdout] | ^^^^^^^^^^^^^^^--- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/main.rs:67:5 [INFO] [stdout] | [INFO] [stdout] 67 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 64 ~ match out { Err(err) => { [INFO] [stdout] 65 | eprintln!("Error: {err}"); [INFO] [stdout] 66 | std::process::exit(1); [INFO] [stdout] 67 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/command/encode.rs:102:11 [INFO] [stdout] | [INFO] [stdout] 102 | while let Some(progress) = enc.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^---------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/command/encode.rs:120:5 [INFO] [stdout] | [INFO] [stdout] 120 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/command/crf_search/err.rs:46:28 [INFO] [stderr] | [INFO] [stderr] 46 | ($condition:expr_2021, $last_sample:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/command/encode.rs:108:20 [INFO] [stdout] | [INFO] [stdout] 108 | if let Ok(d) = &probe.duration { [INFO] [stdout] | ^^^^^^^^^^^^^-----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/command/encode.rs:111:17 [INFO] [stdout] | [INFO] [stdout] 111 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 108 ~ match &probe.duration { Ok(d) => { [INFO] [stdout] 109 | bar.set_position(time.as_micros_u64()); [INFO] [stdout] 110 | logger.update(*d, time, fps); [INFO] [stdout] 111 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/command/sample_encode.rs:219:23 [INFO] [stdout] | [INFO] [stdout] 219 | while let Some(progress) = output.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/command/sample_encode.rs:229:17 [INFO] [stdout] | [INFO] [stdout] 229 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/command/sample_encode.rs:220:24 [INFO] [stdout] | [INFO] [stdout] 220 | if let FfmpegOut::Progress { time, fps, .. } = progress? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/command/sample_encode.rs:228:21 [INFO] [stdout] | [INFO] [stdout] 228 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 220 ~ match progress? { FfmpegOut::Progress { time, fps, .. } => { [INFO] [stdout] 221 | bar.set_position( [INFO] [stdout] ... [INFO] [stdout] 227 | logger.update(sample_duration, time, fps); [INFO] [stdout] 228 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/command/sample_encode.rs:249:23 [INFO] [stdout] | [INFO] [stdout] 249 | while let Some(vmaf) = vmaf.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^----------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/command/sample_encode.rs:270:17 [INFO] [stdout] | [INFO] [stdout] 270 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/command/vmaf.rs:80:11 [INFO] [stdout] | [INFO] [stdout] 80 | while let Some(vmaf) = vmaf.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^----------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/command/vmaf.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl tokio_stream::Stream>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/ffmpeg.rs:75:31 [INFO] [stdout] | [INFO] [stdout] 75 | ) -> anyhow::Result<(PathBuf, impl Stream>)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, these lifetimes are in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/ffmpeg.rs:72:8 [INFO] [stdout] | [INFO] [stdout] 72 | }: FfmpegEncodeArgs, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 73 | temp_dir: Option, [INFO] [stdout] 74 | dest_ext: &str, [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] = note: `--force-warn impl-trait-overcaptures` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 75 | ) -> anyhow::Result<(PathBuf, impl Stream> + use<>)> { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl tokio_stream::Stream>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/ffmpeg.rs:130:21 [INFO] [stdout] | [INFO] [stdout] 130 | ) -> anyhow::Result>> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, these lifetimes are in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/ffmpeg.rs:125:8 [INFO] [stdout] | [INFO] [stdout] 125 | }: FfmpegEncodeArgs, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 126 | output: &Path, [INFO] [stdout] | ^ [INFO] [stdout] 127 | has_audio: bool, [INFO] [stdout] 128 | audio_codec: Option<&str>, [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 130 | ) -> anyhow::Result> + use<>> { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl tokio_stream::Stream` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/vmaf.rs:16:21 [INFO] [stdout] | [INFO] [stdout] 16 | ) -> anyhow::Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, these lifetimes are in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/vmaf.rs:13:16 [INFO] [stdout] | [INFO] [stdout] 13 | reference: &Path, [INFO] [stdout] | ^ [INFO] [stdout] 14 | distorted: &Path, [INFO] [stdout] | ^ [INFO] [stdout] 15 | filter_complex: &str, [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 16 | ) -> anyhow::Result + use<>> { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/vmaf.rs:39:15 [INFO] [stdout] | [INFO] [stdout] 39 | while let Some(next) = vmaf.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^----------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/vmaf.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/vmaf.rs:42:24 [INFO] [stdout] | [INFO] [stdout] 42 | if let Some(out) = VmafOut::try_from_chunk(&chunk, &mut chunks) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^-------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/vmaf.rs:47:21 [INFO] [stdout] | [INFO] [stdout] 47 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 42 ~ match VmafOut::try_from_chunk(&chunk, &mut chunks) { Some(out) => { [INFO] [stdout] 43 | if matches!(out, VmafOut::Done(_)) { [INFO] [stdout] ... [INFO] [stdout] 46 | yield out; [INFO] [stdout] 47 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/vmaf.rs:51:24 [INFO] [stdout] | [INFO] [stdout] 51 | if let Err(err) = exit_ok_stderr("ffmpeg vmaf", code, &cmd_str, &chunks) { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/vmaf.rs:53:21 [INFO] [stdout] | [INFO] [stdout] 53 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 51 ~ match exit_ok_stderr("ffmpeg vmaf", code, &cmd_str, &chunks) { Err(err) => { [INFO] [stdout] 52 | yield VmafOut::Err(err); [INFO] [stdout] 53 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/vmaf.rs:191:20 [INFO] [stdout] | [INFO] [stdout] 191 | if let VmafOut::Done(score) = vmaf { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^---- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/vmaf.rs:193:17 [INFO] [stdout] | [INFO] [stdout] 193 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 191 ~ match vmaf { VmafOut::Done(score) => { [INFO] [stdout] 192 | vmaf_score = Some(score); [INFO] [stdout] 193 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 19 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.22s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking ab-av1 v0.7.17 (/tmp/fixit) [INFO] [stdout] error[E0716]: temporary value dropped while borrowed [INFO] [stdout] --> src/command/sample_encode.rs:239:22 [INFO] [stdout] | [INFO] [stdout] 236 | let mut vmaf = pin!(vmaf::run( [INFO] [stdout] | _________________________________- [INFO] [stdout] 237 | | &sample, [INFO] [stdout] 238 | | &encoded_sample, [INFO] [stdout] 239 | | &vmaf.ffmpeg_lavfi( [INFO] [stdout] | | ______________________^ [INFO] [stdout] 240 | || encoded_probe.resolution, [INFO] [stdout] 241 | || enc_args [INFO] [stdout] 242 | || .pix_fmt [INFO] [stdout] 243 | || .max(input_pixel_format.unwrap_or(PixelFormat::Yuv444p10le)), [INFO] [stdout] 244 | || args.vfilter.as_deref(), [INFO] [stdout] 245 | || ), [INFO] [stdout] | ||_____________________^ creates a temporary value which is freed while still in use [INFO] [stdout] 246 | | )?); [INFO] [stdout] | | -- temporary value is freed at the end of this statement [INFO] [stdout] | |____________________| [INFO] [stdout] | a temporary with access to the borrow is created here ... [INFO] [stdout] ... [INFO] [stdout] 312 | } [INFO] [stdout] | - ... and the borrow might be used here, when that temporary is dropped and runs the destructor for type `impl tokio_stream::Stream` [INFO] [stdout] | [INFO] [stdout] = note: consider using a `let` binding to create a longer lived value [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0716]: temporary value dropped while borrowed [INFO] [stdout] --> src/command/sample_encode.rs:239:22 [INFO] [stdout] | [INFO] [stdout] 236 | let mut vmaf = pin!(vmaf::run( [INFO] [stdout] | _________________________________- [INFO] [stdout] 237 | | &sample, [INFO] [stdout] 238 | | &encoded_sample, [INFO] [stdout] 239 | | &vmaf.ffmpeg_lavfi( [INFO] [stdout] | | ______________________^ [INFO] [stdout] 240 | || encoded_probe.resolution, [INFO] [stdout] 241 | || enc_args [INFO] [stdout] 242 | || .pix_fmt [INFO] [stdout] 243 | || .max(input_pixel_format.unwrap_or(PixelFormat::Yuv444p10le)), [INFO] [stdout] 244 | || args.vfilter.as_deref(), [INFO] [stdout] 245 | || ), [INFO] [stdout] | ||_____________________^ creates a temporary value which is freed while still in use [INFO] [stdout] 246 | | )?); [INFO] [stdout] | | -- temporary value is freed at the end of this statement [INFO] [stdout] | |____________________| [INFO] [stdout] | a temporary with access to the borrow is created here ... [INFO] [stdout] ... [INFO] [stdout] 312 | } [INFO] [stdout] | - ... and the borrow might be used here, when that temporary is dropped and runs the destructor for type `impl tokio_stream::Stream` [INFO] [stdout] | [INFO] [stdout] = note: consider using a `let` binding to create a longer lived value [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0505]: cannot move out of `encoded_sample` because it is borrowed [INFO] [stdout] --> src/command/sample_encode.rs:308:52 [INFO] [stdout] | [INFO] [stdout] 211 | let (encoded_sample, mut output) = ffmpeg::encode_sample( [INFO] [stdout] | -------------- binding `encoded_sample` declared here [INFO] [stdout] ... [INFO] [stdout] 236 | let mut vmaf = pin!(vmaf::run( [INFO] [stdout] | ________________________________- [INFO] [stdout] 237 | | &sample, [INFO] [stdout] 238 | | &encoded_sample, [INFO] [stdout] | | --------------- borrow of `encoded_sample` occurs here [INFO] [stdout] 239 | | &vmaf.ffmpeg_lavfi( [INFO] [stdout] ... | [INFO] [stdout] 245 | | ), [INFO] [stdout] 246 | | )?); [INFO] [stdout] | |___________________- a temporary with access to the borrow is created here ... [INFO] [stdout] ... [INFO] [stdout] 308 | let _ = tokio::fs::remove_file(encoded_sample).await; [INFO] [stdout] | ^^^^^^^^^^^^^^ move out of `encoded_sample` occurs here [INFO] [stdout] ... [INFO] [stdout] 312 | } [INFO] [stdout] | - ... and the borrow might be used here, when that temporary is dropped and runs the destructor for type `impl tokio_stream::Stream` [INFO] [stdout] | [INFO] [stdout] help: consider cloning the value if the performance cost is acceptable [INFO] [stdout] | [INFO] [stdout] 238 | &encoded_sample.clone(), [INFO] [stdout] | ++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0505]: cannot move out of `encoded_sample` because it is borrowed [INFO] [stdout] --> src/command/sample_encode.rs:308:52 [INFO] [stdout] | [INFO] [stdout] 211 | let (encoded_sample, mut output) = ffmpeg::encode_sample( [INFO] [stdout] | -------------- binding `encoded_sample` declared here [INFO] [stdout] ... [INFO] [stdout] 236 | let mut vmaf = pin!(vmaf::run( [INFO] [stdout] | ________________________________- [INFO] [stdout] 237 | | &sample, [INFO] [stdout] 238 | | &encoded_sample, [INFO] [stdout] | | --------------- borrow of `encoded_sample` occurs here [INFO] [stdout] 239 | | &vmaf.ffmpeg_lavfi( [INFO] [stdout] ... | [INFO] [stdout] 245 | | ), [INFO] [stdout] 246 | | )?); [INFO] [stdout] | |___________________- a temporary with access to the borrow is created here ... [INFO] [stdout] ... [INFO] [stdout] 308 | let _ = tokio::fs::remove_file(encoded_sample).await; [INFO] [stdout] | ^^^^^^^^^^^^^^ move out of `encoded_sample` occurs here [INFO] [stdout] ... [INFO] [stdout] 312 | } [INFO] [stdout] | - ... and the borrow might be used here, when that temporary is dropped and runs the destructor for type `impl tokio_stream::Stream` [INFO] [stdout] | [INFO] [stdout] help: consider cloning the value if the performance cost is acceptable [INFO] [stdout] | [INFO] [stdout] 238 | &encoded_sample.clone(), [INFO] [stdout] | ++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0716]: temporary value dropped while borrowed [INFO] [stdout] --> src/command/vmaf.rs:72:10 [INFO] [stdout] | [INFO] [stdout] 69 | let mut vmaf = pin!(vmaf::run( [INFO] [stdout] | _____________________- [INFO] [stdout] 70 | | &reference, [INFO] [stdout] 71 | | &distorted, [INFO] [stdout] 72 | | &vmaf.ffmpeg_lavfi( [INFO] [stdout] | | __________^ [INFO] [stdout] 73 | || dprobe.resolution, [INFO] [stdout] 74 | || dpix_fmt.max(rpix_fmt), [INFO] [stdout] 75 | || vmaf.reference_vfilter.as_deref(), [INFO] [stdout] 76 | || ), [INFO] [stdout] | ||_________^ creates a temporary value which is freed while still in use [INFO] [stdout] 77 | | )?); [INFO] [stdout] | | -- temporary value is freed at the end of this statement [INFO] [stdout] | |________| [INFO] [stdout] | a temporary with access to the borrow is created here ... [INFO] [stdout] ... [INFO] [stdout] 107 | } [INFO] [stdout] | - ... and the borrow might be used here, when that temporary is dropped and runs the destructor for type `impl tokio_stream::Stream` [INFO] [stdout] | [INFO] [stdout] = note: consider using a `let` binding to create a longer lived value [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0716]: temporary value dropped while borrowed [INFO] [stdout] --> src/command/vmaf.rs:72:10 [INFO] [stdout] | [INFO] [stdout] 69 | let mut vmaf = pin!(vmaf::run( [INFO] [stdout] | _____________________- [INFO] [stdout] 70 | | &reference, [INFO] [stdout] 71 | | &distorted, [INFO] [stdout] 72 | | &vmaf.ffmpeg_lavfi( [INFO] [stdout] | | __________^ [INFO] [stdout] 73 | || dprobe.resolution, [INFO] [stdout] 74 | || dpix_fmt.max(rpix_fmt), [INFO] [stdout] 75 | || vmaf.reference_vfilter.as_deref(), [INFO] [stdout] 76 | || ), [INFO] [stdout] | ||_________^ creates a temporary value which is freed while still in use [INFO] [stdout] 77 | | )?); [INFO] [stdout] | | -- temporary value is freed at the end of this statement [INFO] [stdout] | |________| [INFO] [stdout] | a temporary with access to the borrow is created here ... [INFO] [stdout] ... [INFO] [stdout] 107 | } [INFO] [stdout] | - ... and the borrow might be used here, when that temporary is dropped and runs the destructor for type `impl tokio_stream::Stream` [INFO] [stdout] | [INFO] [stdout] = note: consider using a `let` binding to create a longer lived value [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/main.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | env::set_var("RUST_LOG", "ab_av1=info"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] Some errors have detailed explanations: E0133, E0505, E0716. [INFO] [stdout] [INFO] [stdout] For more information about an error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/main.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | env::set_var("RUST_LOG", "ab_av1=info"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ab-av1` (bin "ab-av1") due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] Some errors have detailed explanations: E0133, E0505, E0716. [INFO] [stdout] [INFO] [stdout] For more information about an error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stderr] error: could not compile `ab-av1` (bin "ab-av1" test) due to 5 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "4247c1ff2534e73a787f063ef9176ba79faa85d5568d610daa05bf129472af79", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4247c1ff2534e73a787f063ef9176ba79faa85d5568d610daa05bf129472af79", kill_on_drop: false }` [INFO] [stdout] 4247c1ff2534e73a787f063ef9176ba79faa85d5568d610daa05bf129472af79