[INFO] cloning repository https://github.com/desbma/shh [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/desbma/shh" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdesbma%2Fshh", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdesbma%2Fshh'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 57fbeb52b4ddc0f41a3b6bd44357135c68367e10 [INFO] checking desbma/shh/57fbeb52b4ddc0f41a3b6bd44357135c68367e10 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdesbma%2Fshh" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/desbma/shh on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/desbma/shh [INFO] finished tweaking git repo https://github.com/desbma/shh [INFO] tweaked toml for git repo https://github.com/desbma/shh written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/desbma/shh already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 963f257313839c8fbd8cac5cc63aa5855d2494d43b58a709d600dd20f66950d8 [INFO] running `Command { std: "docker" "start" "-a" "963f257313839c8fbd8cac5cc63aa5855d2494d43b58a709d600dd20f66950d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "963f257313839c8fbd8cac5cc63aa5855d2494d43b58a709d600dd20f66950d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "963f257313839c8fbd8cac5cc63aa5855d2494d43b58a709d600dd20f66950d8", kill_on_drop: false }` [INFO] [stdout] 963f257313839c8fbd8cac5cc63aa5855d2494d43b58a709d600dd20f66950d8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2e451d803c13ad513795efdd104b9f4aa1976db43eced68ccdd24a89aa3805da [INFO] running `Command { std: "docker" "start" "-a" "2e451d803c13ad513795efdd104b9f4aa1976db43eced68ccdd24a89aa3805da", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Compiling cc v1.0.98 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Checking miniz_oxide v0.7.3 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Compiling function_name-proc-macro v0.3.0 [INFO] [stderr] Checking either v1.12.0 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Compiling assert_cmd v2.0.14 [INFO] [stderr] Checking simple_logger v4.3.3 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking object v0.35.0 [INFO] [stderr] Checking predicates v3.1.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking predicates-tree v1.0.9 [INFO] [stderr] Checking function_name v0.3.0 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Compiling backtrace v0.3.72 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Compiling strum_macros v0.25.3 [INFO] [stderr] Checking strum v0.25.0 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking shh v2024.6.4 (/tmp/fixit) [INFO] [stderr] Migrating tests/cl.rs from 2021 edition to 2024 [INFO] [stderr] Migrating src/main.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `shh` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/strace/parser/combinator.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/strace/parser/combinator.rs:26:6 [INFO] [stderr] | [INFO] [stderr] 26 | ($input:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/systemd/service.rs:104:17 [INFO] [stdout] | [INFO] [stdout] 104 | rng.gen::() [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/strace/parser/combinator.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | ($input:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 26 | ($input:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/strace/parser/mod.rs:113:20 [INFO] [stdout] | [INFO] [stdout] 113 | if let Err(e) = writeln!(log, "{line}") { [INFO] [stdout] | ^^^^^^^^^^^^^----------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/strace/parser/mod.rs:115:17 [INFO] [stdout] | [INFO] [stdout] 115 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/strace/parser/mod.rs:128:47 [INFO] [stdout] | [INFO] [stdout] 128 | let unfinished_index = if let Some(index) = self [INFO] [stdout] | ________________________________________________^ - [INFO] [stdout] | | _________________________________________________________________| [INFO] [stdout] 129 | || .unfinished_syscalls [INFO] [stdout] | ||____________________________________________- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] 130 | | .iter() [INFO] [stdout] 131 | | .position(|sc| (sc.name == sc_end.name) && (sc.pid == sc_end.pid)) [INFO] [stdout] | |___________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/strace/parser/mod.rs:134:21 [INFO] [stdout] | [INFO] [stdout] 134 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 128 ~ let unfinished_index = match self [INFO] [stdout] 129 | .unfinished_syscalls [INFO] [stdout] 130 | .iter() [INFO] [stdout] 131 | .position(|sc| (sc.name == sc_end.name) && (sc.pid == sc_end.pid)) [INFO] [stdout] 132 ~ { Some(index) => { [INFO] [stdout] 133 | index [INFO] [stdout] 134 ~ } _ => { [INFO] [stdout] 135 | log::warn!("Unable to find first part of syscall"); [INFO] [stdout] 136 | continue; [INFO] [stdout] 137 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/strace/parser/combinator.rs:166:16 [INFO] [stdout] | [INFO] [stdout] 166 | if let IntegerExpressionValue::Literal(v) = e.value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/strace/parser/combinator.rs:168:13 [INFO] [stdout] | [INFO] [stdout] 168 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 166 ~ match e.value { IntegerExpressionValue::Literal(v) => { [INFO] [stdout] 167 | Ok(v) [INFO] [stdout] 168 ~ } _ => { [INFO] [stdout] 169 | Err("Failed to get return value: {e:?}") [INFO] [stdout] 170 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/strace/parser/combinator.rs:260:28 [INFO] [stdout] | [INFO] [stdout] 260 | if let Expression::Macro { args, .. } = &e { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/strace/parser/combinator.rs:268:25 [INFO] [stdout] | [INFO] [stdout] 268 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 260 ~ match &e { Expression::Macro { args, .. } => { [INFO] [stdout] 261 | args.iter().find_map(|a| { [INFO] [stdout] ... [INFO] [stdout] 267 | }) [INFO] [stdout] 268 ~ } _ => { [INFO] [stdout] 269 | None [INFO] [stdout] 270 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/strace/parser/combinator.rs:349:28 [INFO] [stdout] | [INFO] [stdout] 349 | if let IntegerExpressionValue::BinaryOr(es) = e { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/strace/parser/combinator.rs:351:25 [INFO] [stdout] | [INFO] [stdout] 351 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 349 ~ match e { IntegerExpressionValue::BinaryOr(es) => { [INFO] [stdout] 350 | es.into_iter() [INFO] [stdout] 351 ~ } _ => { [INFO] [stdout] 352 | vec![e].into_iter() [INFO] [stdout] 353 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/strace/parser/combinator.rs:376:28 [INFO] [stdout] | [INFO] [stdout] 376 | if let IntegerExpressionValue::Multiplication(es) = e { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/strace/parser/combinator.rs:378:25 [INFO] [stdout] | [INFO] [stdout] 378 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 376 ~ match e { IntegerExpressionValue::Multiplication(es) => { [INFO] [stdout] 377 | es.into_iter() [INFO] [stdout] 378 ~ } _ => { [INFO] [stdout] 379 | vec![e].into_iter() [INFO] [stdout] 380 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/summarize.rs:282:44 [INFO] [stdout] | [INFO] [stdout] 282 | let (mut path, flags) = if let ( [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 283 | | Some(Expression::Buffer(BufferExpression { [INFO] [stdout] 284 | | value: b, [INFO] [stdout] 285 | | type_: BufferType::Unknown, [INFO] [stdout] ... | [INFO] [stdout] 288 | | ) = [INFO] [stdout] 289 | | (syscall.args.get(*path_idx), syscall.args.get(*flags_idx)) [INFO] [stdout] | |______________________------------_____________________________________________^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/summarize.rs:292:17 [INFO] [stdout] | [INFO] [stdout] 292 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 282 ~ let (mut path, flags) = match (syscall.args.get(*path_idx), syscall.args.get(*flags_idx)) [INFO] [stdout] 283 ~ { ( [INFO] [stdout] 284 + Some(Expression::Buffer(BufferExpression { [INFO] [stdout] 285 + value: b, [INFO] [stdout] 286 + type_: BufferType::Unknown, [INFO] [stdout] 287 + })), [INFO] [stdout] 288 + Some(Expression::Integer(IntegerExpression { value: e, .. })), [INFO] [stdout] 289 ~ ) => { [INFO] [stdout] 290 | (PathBuf::from(OsStr::from_bytes(b)), e) [INFO] [stdout] 291 ~ } _ => { [INFO] [stdout] 292 | anyhow::bail!("Unexpected args for {}: {:?}", name, syscall.args); [INFO] [stdout] 293 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/summarize.rs:296:27 [INFO] [stdout] | [INFO] [stdout] 296 | path = if let Some(path) = resolve_path(&path, *relfd_idx, &syscall) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/summarize.rs:298:17 [INFO] [stdout] | [INFO] [stdout] 298 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 296 ~ path = match resolve_path(&path, *relfd_idx, &syscall) { Some(path) => { [INFO] [stdout] 297 | path [INFO] [stdout] 298 ~ } _ => { [INFO] [stdout] 299 | continue; [INFO] [stdout] 300 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/summarize.rs:322:55 [INFO] [stdout] | [INFO] [stdout] 322 | let (mut path_src, mut path_dst) = if let ( [INFO] [stdout] | _______________________________________________________^ [INFO] [stdout] 323 | | Some(Expression::Buffer(BufferExpression { [INFO] [stdout] 324 | | value: b1, [INFO] [stdout] 325 | | type_: BufferType::Unknown, [INFO] [stdout] ... | [INFO] [stdout] 332 | | syscall.args.get(*path_src_idx), [INFO] [stdout] | | ------------ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] 333 | | syscall.args.get(*path_dst_idx), [INFO] [stdout] 334 | | ) { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/summarize.rs:339:17 [INFO] [stdout] | [INFO] [stdout] 339 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 322 ~ let (mut path_src, mut path_dst) = match ( [INFO] [stdout] 323 | syscall.args.get(*path_src_idx), [INFO] [stdout] 324 | syscall.args.get(*path_dst_idx), [INFO] [stdout] 325 ~ ) { ( [INFO] [stdout] 326 + Some(Expression::Buffer(BufferExpression { [INFO] [stdout] 327 + value: b1, [INFO] [stdout] 328 + type_: BufferType::Unknown, [INFO] [stdout] 329 + })), [INFO] [stdout] 330 + Some(Expression::Buffer(BufferExpression { [INFO] [stdout] 331 + value: b2, [INFO] [stdout] 332 + type_: BufferType::Unknown, [INFO] [stdout] 333 + })), [INFO] [stdout] 334 ~ ) => { [INFO] [stdout] 335 | ( [INFO] [stdout] ... [INFO] [stdout] 338 | ) [INFO] [stdout] 339 ~ } _ => { [INFO] [stdout] 340 | anyhow::bail!("Unexpected args for {}: {:?}", name, syscall.args); [INFO] [stdout] 341 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/summarize.rs:343:43 [INFO] [stdout] | [INFO] [stdout] 343 | (path_src, path_dst) = if let (Some(path_src), Some(path_dst)) = ( [INFO] [stdout] | ___________________________________________^ [INFO] [stdout] 344 | | resolve_path(&path_src, *relfd_src_idx, &syscall), [INFO] [stdout] | | ------- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] 345 | | resolve_path(&path_dst, *relfd_dst_idx, &syscall), [INFO] [stdout] 346 | | ) { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/summarize.rs:348:17 [INFO] [stdout] | [INFO] [stdout] 348 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 343 ~ (path_src, path_dst) = match ( [INFO] [stdout] 344 | resolve_path(&path_src, *relfd_src_idx, &syscall), [INFO] [stdout] 345 | resolve_path(&path_dst, *relfd_dst_idx, &syscall), [INFO] [stdout] 346 ~ ) { (Some(path_src), Some(path_dst)) => { [INFO] [stdout] 347 | (path_src, path_dst) [INFO] [stdout] 348 ~ } _ => { [INFO] [stdout] 349 | continue; [INFO] [stdout] 350 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/summarize.rs:353:36 [INFO] [stdout] | [INFO] [stdout] 353 | let flags = if let Some(Expression::Integer(IntegerExpression { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 354 | | value: flags, [INFO] [stdout] 355 | | .. [INFO] [stdout] 356 | | })) = syscall.args.get(*flags_idx) [INFO] [stdout] | |___________________________------------_______________^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/summarize.rs:359:21 [INFO] [stdout] | [INFO] [stdout] 359 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 353 ~ let flags = match syscall.args.get(*flags_idx) [INFO] [stdout] 354 ~ { Some(Expression::Integer(IntegerExpression { [INFO] [stdout] 355 + value: flags, [INFO] [stdout] 356 + .. [INFO] [stdout] 357 ~ })) => { [INFO] [stdout] 358 | flags [INFO] [stdout] 359 ~ } _ => { [INFO] [stdout] 360 | anyhow::bail!("Unexpected args for {}: {:?}", name, syscall.args); [INFO] [stdout] 361 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/summarize.rs:384:27 [INFO] [stdout] | [INFO] [stdout] 384 | path = if let Some(path) = resolve_path(&path, None, &syscall) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/summarize.rs:386:17 [INFO] [stdout] | [INFO] [stdout] 386 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 384 ~ path = match resolve_path(&path, None, &syscall) { Some(path) => { [INFO] [stdout] 385 | path [INFO] [stdout] 386 ~ } _ => { [INFO] [stdout] 387 | continue; [INFO] [stdout] 388 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/summarize.rs:395:35 [INFO] [stdout] | [INFO] [stdout] 395 | let mut path = if let Some(Expression::Buffer(BufferExpression { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 396 | | value: b, [INFO] [stdout] 397 | | type_: BufferType::Unknown, [INFO] [stdout] 398 | | })) = syscall.args.get(*path_idx) [INFO] [stdout] | |_______________________------------______________^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/summarize.rs:401:17 [INFO] [stdout] | [INFO] [stdout] 401 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 395 ~ let mut path = match syscall.args.get(*path_idx) [INFO] [stdout] 396 ~ { Some(Expression::Buffer(BufferExpression { [INFO] [stdout] 397 + value: b, [INFO] [stdout] 398 + type_: BufferType::Unknown, [INFO] [stdout] 399 ~ })) => { [INFO] [stdout] 400 | PathBuf::from(OsStr::from_bytes(b)) [INFO] [stdout] 401 ~ } _ => { [INFO] [stdout] 402 | anyhow::bail!("Unexpected args for {}: {:?}", name, syscall.args); [INFO] [stdout] 403 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/summarize.rs:404:27 [INFO] [stdout] | [INFO] [stdout] 404 | path = if let Some(path) = resolve_path(&path, *relfd_idx, &syscall) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/summarize.rs:406:17 [INFO] [stdout] | [INFO] [stdout] 406 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 404 ~ path = match resolve_path(&path, *relfd_idx, &syscall) { Some(path) => { [INFO] [stdout] 405 | path [INFO] [stdout] 406 ~ } _ => { [INFO] [stdout] 407 | continue; [INFO] [stdout] 408 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/summarize.rs:413:24 [INFO] [stdout] | [INFO] [stdout] 413 | if let Some(Expression::Struct(members)) = syscall.args.get(*sockaddr_idx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------------^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/summarize.rs:424:21 [INFO] [stdout] | [INFO] [stdout] 424 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 413 ~ match syscall.args.get(*sockaddr_idx) { Some(Expression::Struct(members)) => { [INFO] [stdout] 414 | let af = if let Some(Expression::Integer(IntegerExpression { [INFO] [stdout] ... [INFO] [stdout] 423 | (af.as_str(), members) [INFO] [stdout] 424 ~ } _ => { [INFO] [stdout] 425 | // Can be NULL in some cases, ie AF_NETLINK sockets [INFO] [stdout] 426 | continue; [INFO] [stdout] 427 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/summarize.rs:440:33 [INFO] [stdout] | [INFO] [stdout] 440 | let fd = if let Some(Expression::Integer(IntegerExpression { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 441 | | value: IntegerExpressionValue::Literal(fd), [INFO] [stdout] 442 | | .. [INFO] [stdout] 443 | | })) = syscall.args.first() [INFO] [stdout] | |___________________________------------_______^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/summarize.rs:446:21 [INFO] [stdout] | [INFO] [stdout] 446 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 440 ~ let fd = match syscall.args.first() [INFO] [stdout] 441 ~ { Some(Expression::Integer(IntegerExpression { [INFO] [stdout] 442 + value: IntegerExpressionValue::Literal(fd), [INFO] [stdout] 443 + .. [INFO] [stdout] 444 ~ })) => { [INFO] [stdout] 445 | fd [INFO] [stdout] 446 ~ } _ => { [INFO] [stdout] 447 | anyhow::bail!("Unexpected args for {}: {:?}", name, syscall.args); [INFO] [stdout] 448 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/summarize.rs:452:24 [INFO] [stdout] | [INFO] [stdout] 452 | if let Some(proto) = known_sockets_proto.get(&(syscall.pid, *fd)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/summarize.rs:458:21 [INFO] [stdout] | [INFO] [stdout] 458 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 452 ~ match known_sockets_proto.get(&(syscall.pid, *fd)) { Some(proto) => { [INFO] [stdout] 453 | actions.push(ProgramAction::NetworkActivity(NetworkActivity { [INFO] [stdout] ... [INFO] [stdout] 457 | })); [INFO] [stdout] 458 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/summarize.rs:462:33 [INFO] [stdout] | [INFO] [stdout] 462 | let policy = if let Some(Expression::Integer(IntegerExpression { value, .. })) = [INFO] [stdout] | _________________________________^ [INFO] [stdout] 463 | | syscall.args.get(1) [INFO] [stdout] | |_____________________------------______^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/summarize.rs:466:17 [INFO] [stdout] | [INFO] [stdout] 466 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 462 ~ let policy = match syscall.args.get(1) [INFO] [stdout] 463 ~ { Some(Expression::Integer(IntegerExpression { value, .. })) => { [INFO] [stdout] 464 | value [INFO] [stdout] 465 ~ } _ => { [INFO] [stdout] 466 | anyhow::bail!("Unexpected args for {}: {:?}", name, syscall.args); [INFO] [stdout] 467 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/summarize.rs:474:29 [INFO] [stdout] | [INFO] [stdout] 474 | let af = if let Some(Expression::Integer(IntegerExpression { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 475 | | value: IntegerExpressionValue::NamedConst(af), [INFO] [stdout] 476 | | .. [INFO] [stdout] 477 | | })) = syscall.args.first() [INFO] [stdout] | |_______________________------------_______^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/summarize.rs:481:17 [INFO] [stdout] | [INFO] [stdout] 481 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 474 ~ let af = match syscall.args.first() [INFO] [stdout] 475 ~ { Some(Expression::Integer(IntegerExpression { [INFO] [stdout] 476 + value: IntegerExpressionValue::NamedConst(af), [INFO] [stdout] 477 + .. [INFO] [stdout] 478 ~ })) => { [INFO] [stdout] 479 | af.parse() [INFO] [stdout] 480 | .map_err(|_| anyhow::anyhow!("Unable to parse socket family {af:?}"))? [INFO] [stdout] 481 ~ } _ => { [INFO] [stdout] 482 | anyhow::bail!("Unexpected args for {}: {:?}", name, syscall.args); [INFO] [stdout] 483 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/summarize.rs:485:32 [INFO] [stdout] | [INFO] [stdout] 485 | let flags = if let Some(Expression::Integer(IntegerExpression { value, .. })) = [INFO] [stdout] | ________________________________^ [INFO] [stdout] 486 | | syscall.args.get(1) [INFO] [stdout] | |_____________________------------______^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/summarize.rs:489:17 [INFO] [stdout] | [INFO] [stdout] 489 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 485 ~ let flags = match syscall.args.get(1) [INFO] [stdout] 486 ~ { Some(Expression::Integer(IntegerExpression { value, .. })) => { [INFO] [stdout] 487 | value.flags() [INFO] [stdout] 488 ~ } _ => { [INFO] [stdout] 489 | anyhow::bail!("Unexpected args for {}: {:?}", name, syscall.args); [INFO] [stdout] 490 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/summarize.rs:512:24 [INFO] [stdout] | [INFO] [stdout] 512 | if let Some(Expression::Integer(IntegerExpression { value: prot, .. })) = [INFO] [stdout] | ________________________^ [INFO] [stdout] 513 | | syscall.args.get(*prot_idx) [INFO] [stdout] | |_________________________------------______________^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/summarize.rs:516:21 [INFO] [stdout] | [INFO] [stdout] 516 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 512 ~ match syscall.args.get(*prot_idx) [INFO] [stdout] 513 ~ { Some(Expression::Integer(IntegerExpression { value: prot, .. })) => { [INFO] [stdout] 514 | prot [INFO] [stdout] 515 ~ } _ => { [INFO] [stdout] 516 | anyhow::bail!("Unexpected args for {}: {:?}", name, syscall.args); [INFO] [stdout] 517 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/systemd/service.rs:291:19 [INFO] [stdout] | [INFO] [stdout] 291 | while let Some(line) = lines.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/systemd/service.rs:317:13 [INFO] [stdout] | [INFO] [stdout] 317 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 24 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `shh` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/strace/parser/combinator.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/strace/parser/combinator.rs:26:6 [INFO] [stderr] | [INFO] [stderr] 26 | ($input:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/systemd/service.rs:104:17 [INFO] [stdout] | [INFO] [stdout] 104 | rng.gen::() [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/strace/parser/combinator.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | ($input:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 26 | ($input:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/strace/parser/mod.rs:113:20 [INFO] [stdout] | [INFO] [stdout] 113 | if let Err(e) = writeln!(log, "{line}") { [INFO] [stdout] | ^^^^^^^^^^^^^----------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/strace/parser/mod.rs:115:17 [INFO] [stdout] | [INFO] [stdout] 115 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/strace/parser/mod.rs:128:47 [INFO] [stdout] | [INFO] [stdout] 128 | let unfinished_index = if let Some(index) = self [INFO] [stdout] | ________________________________________________^ - [INFO] [stdout] | | _________________________________________________________________| [INFO] [stdout] 129 | || .unfinished_syscalls [INFO] [stdout] | ||____________________________________________- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] 130 | | .iter() [INFO] [stdout] 131 | | .position(|sc| (sc.name == sc_end.name) && (sc.pid == sc_end.pid)) [INFO] [stdout] | |___________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/strace/parser/mod.rs:134:21 [INFO] [stdout] | [INFO] [stdout] 134 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 128 ~ let unfinished_index = match self [INFO] [stdout] 129 | .unfinished_syscalls [INFO] [stdout] 130 | .iter() [INFO] [stdout] 131 | .position(|sc| (sc.name == sc_end.name) && (sc.pid == sc_end.pid)) [INFO] [stdout] 132 ~ { Some(index) => { [INFO] [stdout] 133 | index [INFO] [stdout] 134 ~ } _ => { [INFO] [stdout] 135 | log::warn!("Unable to find first part of syscall"); [INFO] [stdout] 136 | continue; [INFO] [stdout] 137 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/strace/parser/combinator.rs:166:16 [INFO] [stdout] | [INFO] [stdout] 166 | if let IntegerExpressionValue::Literal(v) = e.value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/strace/parser/combinator.rs:168:13 [INFO] [stdout] | [INFO] [stdout] 168 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 166 ~ match e.value { IntegerExpressionValue::Literal(v) => { [INFO] [stdout] 167 | Ok(v) [INFO] [stdout] 168 ~ } _ => { [INFO] [stdout] 169 | Err("Failed to get return value: {e:?}") [INFO] [stdout] 170 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/strace/parser/combinator.rs:260:28 [INFO] [stdout] | [INFO] [stdout] 260 | if let Expression::Macro { args, .. } = &e { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/strace/parser/combinator.rs:268:25 [INFO] [stdout] | [INFO] [stdout] 268 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 260 ~ match &e { Expression::Macro { args, .. } => { [INFO] [stdout] 261 | args.iter().find_map(|a| { [INFO] [stdout] ... [INFO] [stdout] 267 | }) [INFO] [stdout] 268 ~ } _ => { [INFO] [stdout] 269 | None [INFO] [stdout] 270 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/strace/parser/combinator.rs:349:28 [INFO] [stdout] | [INFO] [stdout] 349 | if let IntegerExpressionValue::BinaryOr(es) = e { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/strace/parser/combinator.rs:351:25 [INFO] [stdout] | [INFO] [stdout] 351 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 349 ~ match e { IntegerExpressionValue::BinaryOr(es) => { [INFO] [stdout] 350 | es.into_iter() [INFO] [stdout] 351 ~ } _ => { [INFO] [stdout] 352 | vec![e].into_iter() [INFO] [stdout] 353 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/strace/parser/combinator.rs:376:28 [INFO] [stdout] | [INFO] [stdout] 376 | if let IntegerExpressionValue::Multiplication(es) = e { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/strace/parser/combinator.rs:378:25 [INFO] [stdout] | [INFO] [stdout] 378 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 376 ~ match e { IntegerExpressionValue::Multiplication(es) => { [INFO] [stdout] 377 | es.into_iter() [INFO] [stdout] 378 ~ } _ => { [INFO] [stdout] 379 | vec![e].into_iter() [INFO] [stdout] 380 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/summarize.rs:282:44 [INFO] [stdout] | [INFO] [stdout] 282 | let (mut path, flags) = if let ( [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 283 | | Some(Expression::Buffer(BufferExpression { [INFO] [stdout] 284 | | value: b, [INFO] [stdout] 285 | | type_: BufferType::Unknown, [INFO] [stdout] ... | [INFO] [stdout] 288 | | ) = [INFO] [stdout] 289 | | (syscall.args.get(*path_idx), syscall.args.get(*flags_idx)) [INFO] [stdout] | |______________________------------_____________________________________________^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/summarize.rs:292:17 [INFO] [stdout] | [INFO] [stdout] 292 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 282 ~ let (mut path, flags) = match (syscall.args.get(*path_idx), syscall.args.get(*flags_idx)) [INFO] [stdout] 283 ~ { ( [INFO] [stdout] 284 + Some(Expression::Buffer(BufferExpression { [INFO] [stdout] 285 + value: b, [INFO] [stdout] 286 + type_: BufferType::Unknown, [INFO] [stdout] 287 + })), [INFO] [stdout] 288 + Some(Expression::Integer(IntegerExpression { value: e, .. })), [INFO] [stdout] 289 ~ ) => { [INFO] [stdout] 290 | (PathBuf::from(OsStr::from_bytes(b)), e) [INFO] [stdout] 291 ~ } _ => { [INFO] [stdout] 292 | anyhow::bail!("Unexpected args for {}: {:?}", name, syscall.args); [INFO] [stdout] 293 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/summarize.rs:296:27 [INFO] [stdout] | [INFO] [stdout] 296 | path = if let Some(path) = resolve_path(&path, *relfd_idx, &syscall) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/summarize.rs:298:17 [INFO] [stdout] | [INFO] [stdout] 298 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 296 ~ path = match resolve_path(&path, *relfd_idx, &syscall) { Some(path) => { [INFO] [stdout] 297 | path [INFO] [stdout] 298 ~ } _ => { [INFO] [stdout] 299 | continue; [INFO] [stdout] 300 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/summarize.rs:322:55 [INFO] [stdout] | [INFO] [stdout] 322 | let (mut path_src, mut path_dst) = if let ( [INFO] [stdout] | _______________________________________________________^ [INFO] [stdout] 323 | | Some(Expression::Buffer(BufferExpression { [INFO] [stdout] 324 | | value: b1, [INFO] [stdout] 325 | | type_: BufferType::Unknown, [INFO] [stdout] ... | [INFO] [stdout] 332 | | syscall.args.get(*path_src_idx), [INFO] [stdout] | | ------------ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] 333 | | syscall.args.get(*path_dst_idx), [INFO] [stdout] 334 | | ) { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/summarize.rs:339:17 [INFO] [stdout] | [INFO] [stdout] 339 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 322 ~ let (mut path_src, mut path_dst) = match ( [INFO] [stdout] 323 | syscall.args.get(*path_src_idx), [INFO] [stdout] 324 | syscall.args.get(*path_dst_idx), [INFO] [stdout] 325 ~ ) { ( [INFO] [stdout] 326 + Some(Expression::Buffer(BufferExpression { [INFO] [stdout] 327 + value: b1, [INFO] [stdout] 328 + type_: BufferType::Unknown, [INFO] [stdout] 329 + })), [INFO] [stdout] 330 + Some(Expression::Buffer(BufferExpression { [INFO] [stdout] 331 + value: b2, [INFO] [stdout] 332 + type_: BufferType::Unknown, [INFO] [stdout] 333 + })), [INFO] [stdout] 334 ~ ) => { [INFO] [stdout] 335 | ( [INFO] [stdout] ... [INFO] [stdout] 338 | ) [INFO] [stdout] 339 ~ } _ => { [INFO] [stdout] 340 | anyhow::bail!("Unexpected args for {}: {:?}", name, syscall.args); [INFO] [stdout] 341 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/summarize.rs:343:43 [INFO] [stdout] | [INFO] [stdout] 343 | (path_src, path_dst) = if let (Some(path_src), Some(path_dst)) = ( [INFO] [stdout] | ___________________________________________^ [INFO] [stdout] 344 | | resolve_path(&path_src, *relfd_src_idx, &syscall), [INFO] [stdout] | | ------- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] 345 | | resolve_path(&path_dst, *relfd_dst_idx, &syscall), [INFO] [stdout] 346 | | ) { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/summarize.rs:348:17 [INFO] [stdout] | [INFO] [stdout] 348 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 343 ~ (path_src, path_dst) = match ( [INFO] [stdout] 344 | resolve_path(&path_src, *relfd_src_idx, &syscall), [INFO] [stdout] 345 | resolve_path(&path_dst, *relfd_dst_idx, &syscall), [INFO] [stdout] 346 ~ ) { (Some(path_src), Some(path_dst)) => { [INFO] [stdout] 347 | (path_src, path_dst) [INFO] [stdout] 348 ~ } _ => { [INFO] [stdout] 349 | continue; [INFO] [stdout] 350 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/summarize.rs:353:36 [INFO] [stdout] | [INFO] [stdout] 353 | let flags = if let Some(Expression::Integer(IntegerExpression { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 354 | | value: flags, [INFO] [stdout] 355 | | .. [INFO] [stdout] 356 | | })) = syscall.args.get(*flags_idx) [INFO] [stdout] | |___________________________------------_______________^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/summarize.rs:359:21 [INFO] [stdout] | [INFO] [stdout] 359 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 353 ~ let flags = match syscall.args.get(*flags_idx) [INFO] [stdout] 354 ~ { Some(Expression::Integer(IntegerExpression { [INFO] [stdout] 355 + value: flags, [INFO] [stdout] 356 + .. [INFO] [stdout] 357 ~ })) => { [INFO] [stdout] 358 | flags [INFO] [stdout] 359 ~ } _ => { [INFO] [stdout] 360 | anyhow::bail!("Unexpected args for {}: {:?}", name, syscall.args); [INFO] [stdout] 361 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/summarize.rs:384:27 [INFO] [stdout] | [INFO] [stdout] 384 | path = if let Some(path) = resolve_path(&path, None, &syscall) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/summarize.rs:386:17 [INFO] [stdout] | [INFO] [stdout] 386 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 384 ~ path = match resolve_path(&path, None, &syscall) { Some(path) => { [INFO] [stdout] 385 | path [INFO] [stdout] 386 ~ } _ => { [INFO] [stdout] 387 | continue; [INFO] [stdout] 388 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/summarize.rs:395:35 [INFO] [stdout] | [INFO] [stdout] 395 | let mut path = if let Some(Expression::Buffer(BufferExpression { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 396 | | value: b, [INFO] [stdout] 397 | | type_: BufferType::Unknown, [INFO] [stdout] 398 | | })) = syscall.args.get(*path_idx) [INFO] [stdout] | |_______________________------------______________^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/summarize.rs:401:17 [INFO] [stdout] | [INFO] [stdout] 401 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 395 ~ let mut path = match syscall.args.get(*path_idx) [INFO] [stdout] 396 ~ { Some(Expression::Buffer(BufferExpression { [INFO] [stdout] 397 + value: b, [INFO] [stdout] 398 + type_: BufferType::Unknown, [INFO] [stdout] 399 ~ })) => { [INFO] [stdout] 400 | PathBuf::from(OsStr::from_bytes(b)) [INFO] [stdout] 401 ~ } _ => { [INFO] [stdout] 402 | anyhow::bail!("Unexpected args for {}: {:?}", name, syscall.args); [INFO] [stdout] 403 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/summarize.rs:404:27 [INFO] [stdout] | [INFO] [stdout] 404 | path = if let Some(path) = resolve_path(&path, *relfd_idx, &syscall) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/summarize.rs:406:17 [INFO] [stdout] | [INFO] [stdout] 406 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 404 ~ path = match resolve_path(&path, *relfd_idx, &syscall) { Some(path) => { [INFO] [stdout] 405 | path [INFO] [stdout] 406 ~ } _ => { [INFO] [stdout] 407 | continue; [INFO] [stdout] 408 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/summarize.rs:413:24 [INFO] [stdout] | [INFO] [stdout] 413 | if let Some(Expression::Struct(members)) = syscall.args.get(*sockaddr_idx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------------^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/summarize.rs:424:21 [INFO] [stdout] | [INFO] [stdout] 424 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 413 ~ match syscall.args.get(*sockaddr_idx) { Some(Expression::Struct(members)) => { [INFO] [stdout] 414 | let af = if let Some(Expression::Integer(IntegerExpression { [INFO] [stdout] ... [INFO] [stdout] 423 | (af.as_str(), members) [INFO] [stdout] 424 ~ } _ => { [INFO] [stdout] 425 | // Can be NULL in some cases, ie AF_NETLINK sockets [INFO] [stdout] 426 | continue; [INFO] [stdout] 427 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/summarize.rs:440:33 [INFO] [stdout] | [INFO] [stdout] 440 | let fd = if let Some(Expression::Integer(IntegerExpression { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 441 | | value: IntegerExpressionValue::Literal(fd), [INFO] [stdout] 442 | | .. [INFO] [stdout] 443 | | })) = syscall.args.first() [INFO] [stdout] | |___________________________------------_______^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/summarize.rs:446:21 [INFO] [stdout] | [INFO] [stdout] 446 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 440 ~ let fd = match syscall.args.first() [INFO] [stdout] 441 ~ { Some(Expression::Integer(IntegerExpression { [INFO] [stdout] 442 + value: IntegerExpressionValue::Literal(fd), [INFO] [stdout] 443 + .. [INFO] [stdout] 444 ~ })) => { [INFO] [stdout] 445 | fd [INFO] [stdout] 446 ~ } _ => { [INFO] [stdout] 447 | anyhow::bail!("Unexpected args for {}: {:?}", name, syscall.args); [INFO] [stdout] 448 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/summarize.rs:452:24 [INFO] [stdout] | [INFO] [stdout] 452 | if let Some(proto) = known_sockets_proto.get(&(syscall.pid, *fd)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/summarize.rs:458:21 [INFO] [stdout] | [INFO] [stdout] 458 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 452 ~ match known_sockets_proto.get(&(syscall.pid, *fd)) { Some(proto) => { [INFO] [stdout] 453 | actions.push(ProgramAction::NetworkActivity(NetworkActivity { [INFO] [stdout] ... [INFO] [stdout] 457 | })); [INFO] [stdout] 458 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/summarize.rs:462:33 [INFO] [stdout] | [INFO] [stdout] 462 | let policy = if let Some(Expression::Integer(IntegerExpression { value, .. })) = [INFO] [stdout] | _________________________________^ [INFO] [stdout] 463 | | syscall.args.get(1) [INFO] [stdout] | |_____________________------------______^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/summarize.rs:466:17 [INFO] [stdout] | [INFO] [stdout] 466 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 462 ~ let policy = match syscall.args.get(1) [INFO] [stdout] 463 ~ { Some(Expression::Integer(IntegerExpression { value, .. })) => { [INFO] [stdout] 464 | value [INFO] [stdout] 465 ~ } _ => { [INFO] [stdout] 466 | anyhow::bail!("Unexpected args for {}: {:?}", name, syscall.args); [INFO] [stdout] 467 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/summarize.rs:474:29 [INFO] [stdout] | [INFO] [stdout] 474 | let af = if let Some(Expression::Integer(IntegerExpression { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 475 | | value: IntegerExpressionValue::NamedConst(af), [INFO] [stdout] 476 | | .. [INFO] [stdout] 477 | | })) = syscall.args.first() [INFO] [stdout] | |_______________________------------_______^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/summarize.rs:481:17 [INFO] [stdout] | [INFO] [stdout] 481 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 474 ~ let af = match syscall.args.first() [INFO] [stdout] 475 ~ { Some(Expression::Integer(IntegerExpression { [INFO] [stdout] 476 + value: IntegerExpressionValue::NamedConst(af), [INFO] [stdout] 477 + .. [INFO] [stdout] 478 ~ })) => { [INFO] [stdout] 479 | af.parse() [INFO] [stdout] 480 | .map_err(|_| anyhow::anyhow!("Unable to parse socket family {af:?}"))? [INFO] [stdout] 481 ~ } _ => { [INFO] [stdout] 482 | anyhow::bail!("Unexpected args for {}: {:?}", name, syscall.args); [INFO] [stdout] 483 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/summarize.rs:485:32 [INFO] [stdout] | [INFO] [stdout] 485 | let flags = if let Some(Expression::Integer(IntegerExpression { value, .. })) = [INFO] [stdout] | ________________________________^ [INFO] [stdout] 486 | | syscall.args.get(1) [INFO] [stdout] | |_____________________------------______^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/summarize.rs:489:17 [INFO] [stdout] | [INFO] [stdout] 489 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 485 ~ let flags = match syscall.args.get(1) [INFO] [stdout] 486 ~ { Some(Expression::Integer(IntegerExpression { value, .. })) => { [INFO] [stdout] 487 | value.flags() [INFO] [stdout] 488 ~ } _ => { [INFO] [stdout] 489 | anyhow::bail!("Unexpected args for {}: {:?}", name, syscall.args); [INFO] [stdout] 490 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/summarize.rs:512:24 [INFO] [stdout] | [INFO] [stdout] 512 | if let Some(Expression::Integer(IntegerExpression { value: prot, .. })) = [INFO] [stdout] | ________________________^ [INFO] [stdout] 513 | | syscall.args.get(*prot_idx) [INFO] [stdout] | |_________________________------------______________^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/summarize.rs:516:21 [INFO] [stdout] | [INFO] [stdout] 516 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 512 ~ match syscall.args.get(*prot_idx) [INFO] [stdout] 513 ~ { Some(Expression::Integer(IntegerExpression { value: prot, .. })) => { [INFO] [stdout] 514 | prot [INFO] [stdout] 515 ~ } _ => { [INFO] [stdout] 516 | anyhow::bail!("Unexpected args for {}: {:?}", name, syscall.args); [INFO] [stdout] 517 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/systemd/service.rs:291:19 [INFO] [stdout] | [INFO] [stdout] 291 | while let Some(line) = lines.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/systemd/service.rs:317:13 [INFO] [stdout] | [INFO] [stdout] 317 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 24 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.70s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking shh v2024.6.4 (/tmp/fixit) [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/systemd/service.rs:104:17 [INFO] [stdout] | [INFO] [stdout] 104 | rng.gen::() [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 104 | rng.r#gen::() [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/systemd/service.rs:104:17 [INFO] [stdout] | [INFO] [stdout] 104 | rng.gen::() [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 104 | rng.r#gen::() [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `shh` (bin "shh") due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `shh` (bin "shh" test) due to 2 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "2e451d803c13ad513795efdd104b9f4aa1976db43eced68ccdd24a89aa3805da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2e451d803c13ad513795efdd104b9f4aa1976db43eced68ccdd24a89aa3805da", kill_on_drop: false }` [INFO] [stdout] 2e451d803c13ad513795efdd104b9f4aa1976db43eced68ccdd24a89aa3805da