[INFO] cloning repository https://github.com/cristim/resolve-aws-secrets [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/cristim/resolve-aws-secrets" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcristim%2Fresolve-aws-secrets", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcristim%2Fresolve-aws-secrets'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c8a95f0b542186b47b1c48627bd783b7ad6567d8 [INFO] checking cristim/resolve-aws-secrets/c8a95f0b542186b47b1c48627bd783b7ad6567d8 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcristim%2Fresolve-aws-secrets" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/cristim/resolve-aws-secrets on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/cristim/resolve-aws-secrets [INFO] finished tweaking git repo https://github.com/cristim/resolve-aws-secrets [INFO] tweaked toml for git repo https://github.com/cristim/resolve-aws-secrets written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/cristim/resolve-aws-secrets already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f027d254a644dbf0ecb26112d679c4d6e493472bdf58b7c562fc8a7d24cbf8cb [INFO] running `Command { std: "docker" "start" "-a" "f027d254a644dbf0ecb26112d679c4d6e493472bdf58b7c562fc8a7d24cbf8cb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f027d254a644dbf0ecb26112d679c4d6e493472bdf58b7c562fc8a7d24cbf8cb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f027d254a644dbf0ecb26112d679c4d6e493472bdf58b7c562fc8a7d24cbf8cb", kill_on_drop: false }` [INFO] [stdout] f027d254a644dbf0ecb26112d679c4d6e493472bdf58b7c562fc8a7d24cbf8cb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a5ed450b19f511ad60204b86b539add1389df28c97494a4f044320ff0ac3b89d [INFO] running `Command { std: "docker" "start" "-a" "a5ed450b19f511ad60204b86b539add1389df28c97494a4f044320ff0ac3b89d", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Compiling serde v1.0.207 [INFO] [stderr] Checking vsimd v0.8.0 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking outref v0.5.1 [INFO] [stderr] Checking bytes-utils v0.1.4 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.74 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking base64-simd v0.8.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling cc v1.1.10 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling serde_json v1.0.124 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Compiling httparse v1.9.4 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking xmlparser v0.13.6 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Compiling aws-types v1.3.3 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking cpufeatures v0.2.13 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking rustls-native-certs v0.6.3 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking roxmltree v0.14.1 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking regex-lite v0.1.6 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling mockall_derive v0.13.0 [INFO] [stderr] Checking predicates-core v1.0.8 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking urlencoding v2.1.3 [INFO] [stderr] Checking aws-smithy-xml v0.60.8 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking predicates-tree v1.0.11 [INFO] [stderr] Checking predicates v3.1.2 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking downcast v0.11.0 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking fragile v2.0.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling serde_derive v1.0.207 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling extend v0.1.2 [INFO] [stderr] Compiling serial_test_derive v0.10.0 [INFO] [stderr] Checking tokio v1.39.2 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking mockall v0.13.0 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking serial_test v0.10.0 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking aws-smithy-async v1.2.1 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking aws-smithy-types v1.2.0 [INFO] [stderr] Checking indexmap v2.3.0 [INFO] [stderr] Checking tracing-serde v0.1.3 [INFO] [stderr] Checking aws-smithy-runtime-api v1.7.2 [INFO] [stderr] Checking aws-smithy-json v0.60.7 [INFO] [stderr] Checking aws-smithy-query v0.60.7 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking aws-smithy-http v0.60.9 [INFO] [stderr] Checking aws-credential-types v1.2.0 [INFO] [stderr] Checking assert-json-diff v1.1.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking aws-sigv4 v1.2.3 [INFO] [stderr] Checking aws-smithy-protocol-test v0.60.8 [INFO] [stderr] Checking aws-runtime v1.4.0 [INFO] [stderr] Checking hyper v0.14.30 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking aws-smithy-runtime v1.6.2 [INFO] [stderr] Checking aws-sdk-sso v1.37.0 [INFO] [stderr] Checking aws-sdk-sts v1.37.0 [INFO] [stderr] Checking aws-sdk-ssooidc v1.38.0 [INFO] [stderr] Checking aws-sdk-secretsmanager v1.41.0 [INFO] [stderr] Checking aws-sdk-ssm v1.42.0 [INFO] [stderr] Checking aws-config v1.5.5 [INFO] [stderr] Checking resolve-aws-secrets v0.1.0 (/tmp/fixit) [INFO] [stderr] Migrating src/main.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `resolve_aws_secrets` [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/tests.rs:66:25 [INFO] [stdout] | [INFO] [stdout] 66 | ($name:ident, $body:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 66 | ($name:ident, $body:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stdout] warning: call to deprecated safe function `std::env::remove_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/tests.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | std::env::remove_var(&key); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] = note: `--force-warn deprecated-safe-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 32 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 33 ~ unsafe { std::env::remove_var(&key) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/tests.rs:223:5 [INFO] [stdout] | [INFO] [stdout] 223 | std::env::set_var("SECRETS_PARAMETER_ARN", "arn:ssm:parameter"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 223 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 224 ~ unsafe { std::env::set_var("SECRETS_PARAMETER_ARN", "arn:ssm:parameter") }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stderr] * src/tests.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/tests.rs:67:19 [INFO] [stderr] | [INFO] [stderr] 67 | ($name:ident, $body:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/tests.rs:253:5 [INFO] [stdout] | [INFO] [stdout] 253 | std::env::set_var("SECRET_TEST1", "arn:test1"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 253 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 254 ~ unsafe { std::env::set_var("SECRET_TEST1", "arn:test1") }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/tests.rs:254:5 [INFO] [stdout] | [INFO] [stdout] 254 | std::env::set_var("SECRET_TEST2", "arn:test2"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 254 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 255 ~ unsafe { std::env::set_var("SECRET_TEST2", "arn:test2") }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/tests.rs:255:5 [INFO] [stdout] | [INFO] [stdout] 255 | std::env::set_var("SECRETS_PARAMETER_ARN", "arn:ssm:parameter"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 255 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 256 ~ unsafe { std::env::set_var("SECRETS_PARAMETER_ARN", "arn:ssm:parameter") }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/tests.rs:303:5 [INFO] [stdout] | [INFO] [stdout] 303 | std::env::set_var("SECRETS_PARAMETER_NAME", "test-parameter-name"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 303 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 304 ~ unsafe { std::env::set_var("SECRETS_PARAMETER_NAME", "test-parameter-name") }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/environment_processor.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 54 | if let Value::Object(obj) = json_value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^---------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/environment_processor.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 65 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 54 ~ match json_value { Value::Object(obj) => { [INFO] [stdout] 55 | for (key, value) in obj { [INFO] [stdout] ... [INFO] [stdout] 64 | } [INFO] [stdout] 65 ~ } _ => { [INFO] [stdout] 66 | warn!("SSM parameter value is not an object"); [INFO] [stdout] 67 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/environment_processor.rs:56:16 [INFO] [stdout] | [INFO] [stdout] 56 | if let Value::String(arn) = value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/environment_processor.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 56 ~ match value { Value::String(arn) => { [INFO] [stdout] 57 | let stripped_key = key.strip_prefix("SECRET_").unwrap_or(&key); [INFO] [stdout] ... [INFO] [stdout] 60 | results.push((stripped_key.to_string(), secret_value)); [INFO] [stdout] 61 ~ } _ => { [INFO] [stdout] 62 | warn!("Unexpected value type for key {} in SSM parameter", key); [INFO] [stdout] 63 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Fixed src/environment_processor.rs (2 fixes) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 28.82s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking resolve-aws-secrets v0.1.0 (/tmp/fixit) [INFO] [stdout] error[E0133]: call to unsafe function `remove_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/tests.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | std::env::remove_var(&key); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/tests.rs:223:5 [INFO] [stdout] | [INFO] [stdout] 223 | std::env::set_var("SECRETS_PARAMETER_ARN", "arn:ssm:parameter"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/tests.rs:253:5 [INFO] [stdout] | [INFO] [stdout] 253 | std::env::set_var("SECRET_TEST1", "arn:test1"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/tests.rs:254:5 [INFO] [stdout] | [INFO] [stdout] 254 | std::env::set_var("SECRET_TEST2", "arn:test2"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/tests.rs:255:5 [INFO] [stdout] | [INFO] [stdout] 255 | std::env::set_var("SECRETS_PARAMETER_ARN", "arn:ssm:parameter"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/tests.rs:303:5 [INFO] [stdout] | [INFO] [stdout] 303 | std::env::set_var("SECRETS_PARAMETER_NAME", "test-parameter-name"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stderr] error: could not compile `resolve-aws-secrets` (bin "resolve-aws-secrets" test) due to 7 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "a5ed450b19f511ad60204b86b539add1389df28c97494a4f044320ff0ac3b89d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a5ed450b19f511ad60204b86b539add1389df28c97494a4f044320ff0ac3b89d", kill_on_drop: false }` [INFO] [stdout] a5ed450b19f511ad60204b86b539add1389df28c97494a4f044320ff0ac3b89d