[INFO] cloning repository https://github.com/YukiCoco/ssh-utils [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/YukiCoco/ssh-utils" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FYukiCoco%2Fssh-utils", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FYukiCoco%2Fssh-utils'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] bb43e9269ab8f6d29145d470ff08fee48d4d455b [INFO] checking YukiCoco/ssh-utils/bb43e9269ab8f6d29145d470ff08fee48d4d455b against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FYukiCoco%2Fssh-utils" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/YukiCoco/ssh-utils on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/YukiCoco/ssh-utils [INFO] finished tweaking git repo https://github.com/YukiCoco/ssh-utils [INFO] tweaked toml for git repo https://github.com/YukiCoco/ssh-utils written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/YukiCoco/ssh-utils already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6d89c9a3bf28b7a50bad07ebf13d6e81a785487cc8babe759abb656217383dde [INFO] running `Command { std: "docker" "start" "-a" "6d89c9a3bf28b7a50bad07ebf13d6e81a785487cc8babe759abb656217383dde", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6d89c9a3bf28b7a50bad07ebf13d6e81a785487cc8babe759abb656217383dde", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6d89c9a3bf28b7a50bad07ebf13d6e81a785487cc8babe759abb656217383dde", kill_on_drop: false }` [INFO] [stdout] 6d89c9a3bf28b7a50bad07ebf13d6e81a785487cc8babe759abb656217383dde [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a0618d766690efb7ff0c4e1d0a414029684624cd8258e5ff8d1cd573516c6939 [INFO] running `Command { std: "docker" "start" "-a" "a0618d766690efb7ff0c4e1d0a414029684624cd8258e5ff8d1cd573516c6939", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking base16ct v0.2.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling syn v2.0.68 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Compiling cc v1.0.101 [INFO] [stderr] Checking zerocopy v0.7.34 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling num-bigint-dig v0.8.4 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking pem-rfc7468 v0.7.0 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking der v0.7.9 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking winnow v0.6.16 [INFO] [stderr] Checking data-encoding v2.6.0 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Compiling openssl v0.10.66 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking block-padding v0.3.3 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking castaway v0.2.3 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking ff v0.13.0 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking password-hash v0.4.2 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking cbc v0.1.2 [INFO] [stderr] Checking salsa20 v0.10.2 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking blowfish v0.9.1 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking russh-cryptovec v0.7.3 [INFO] [stderr] Checking md5 v0.7.0 [INFO] [stderr] Checking scrypt v0.11.0 [INFO] [stderr] Checking ssh-encoding v0.2.0 [INFO] [stderr] Checking bcrypt-pbkdf v0.10.0 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking pbkdf2 v0.11.0 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking constant_time_eq v0.3.0 [INFO] [stderr] Checking pkcs5 v0.7.1 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Checking unicode-truncate v1.0.0 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking compact_str v0.8.0 [INFO] [stderr] Checking des v0.8.1 [INFO] [stderr] Checking blake2b_simd v1.0.2 [INFO] [stderr] Checking clap_builder v4.5.7 [INFO] [stderr] Checking ssh-cipher v0.2.0 [INFO] [stderr] Checking lru v0.12.3 [INFO] [stderr] Checking flate2 v1.0.31 [INFO] [stderr] Checking rtoolbox v0.0.2 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking object v0.36.0 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Checking pkcs1 v0.7.5 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking hex-literal v0.4.1 [INFO] [stderr] Checking rpassword v7.3.1 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking rust-argon2 v2.1.0 [INFO] [stderr] Checking elliptic-curve v0.13.8 [INFO] [stderr] Checking rsa v0.9.6 [INFO] [stderr] Checking primeorder v0.13.6 [INFO] [stderr] Checking ecdsa v0.16.9 [INFO] [stderr] Checking p256 v0.13.2 [INFO] [stderr] Checking p384 v0.13.0 [INFO] [stderr] Checking p521 v0.13.3 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling instability v0.3.2 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling clap_derive v4.5.5 [INFO] [stderr] Checking tokio v1.39.3 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking ratatui v0.28.0 [INFO] [stderr] Checking ed25519-dalek v2.1.1 [INFO] [stderr] Checking clap v4.5.7 [INFO] [stderr] Checking ssh-key v0.6.6 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking toml_datetime v0.6.7 [INFO] [stderr] Checking toml_edit v0.22.17 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking tokio-fd v0.3.0 [INFO] [stderr] Checking russh-keys v0.45.0 [INFO] [stderr] Checking russh v0.45.0 [INFO] [stderr] Checking toml v0.8.16 [INFO] [stderr] Checking ssh-utils v0.1.0 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `ssh_utils_lib` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/macros.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/macros.rs:3:6 [INFO] [stderr] | [INFO] [stderr] 3 | ($file:expr_2021, $($arg:tt)*) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/macros.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | ($file:expr, $($arg:tt)*) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 3 | ($file:expr_2021, $($arg:tt)*) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/app.rs:276:16 [INFO] [stdout] | [INFO] [stdout] 276 | if let Event::Key(key) = event::read()? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^-------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/app.rs:488:13 [INFO] [stdout] | [INFO] [stdout] 488 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 276 ~ match event::read()? { Event::Key(key) => { [INFO] [stdout] 277 | if key.kind == KeyEventKind::Press { [INFO] [stdout] ... [INFO] [stdout] 487 | } [INFO] [stdout] 488 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/app.rs:342:36 [INFO] [stdout] | [INFO] [stdout] 342 | ... if let Some(password) = self.vault.servers.iter().find_map(|s| { [INFO] [stdout] | __________________________^ - [INFO] [stdout] | |_______________________________________________| [INFO] [stdout] 343 | || ... (s.id == server_id).then(|| { [INFO] [stdout] 344 | || ... decrypt_password( [INFO] [stdout] 345 | || ... &s.id, [INFO] [stdout] ... || [INFO] [stdout] 352 | || ... }) [INFO] [stdout] 353 | || ... }).transpose()? { [INFO] [stdout] | ||_____________________________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |_____________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/app.rs:477:33 [INFO] [stdout] | [INFO] [stdout] 477 | ... } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 342 ~ match self.vault.servers.iter().find_map(|s| { [INFO] [stdout] 343 | (s.id == server_id).then(|| { [INFO] [stdout] ... [INFO] [stdout] 352 | }) [INFO] [stdout] 353 ~ }).transpose()? { Some(password) => { [INFO] [stdout] 354 | if cfg!(debug_assertions) { [INFO] [stdout] ... [INFO] [stdout] 476 | } [INFO] [stdout] 477 ~ } _ => { [INFO] [stdout] 478 | self.render_popup( [INFO] [stdout] ... [INFO] [stdout] 481 | )?; [INFO] [stdout] 482 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/app.rs:547:12 [INFO] [stdout] | [INFO] [stdout] 547 | if let russh_keys::Error::KeyIsEncrypted = e { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/app.rs:553:9 [INFO] [stdout] | [INFO] [stdout] 553 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 547 ~ match e { russh_keys::Error::KeyIsEncrypted => { [INFO] [stdout] 548 | let mut input_box = PopupInputBox::new(" Input key's passphrase: ".to_string()); [INFO] [stdout] ... [INFO] [stdout] 552 | load_secret_key(key_path, Some(passphrase.as_str())).map_err(|e| e.into()) [INFO] [stdout] 553 ~ } _ => { [INFO] [stdout] 554 | Err(e.into()) [INFO] [stdout] 555 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/widgets/server_creator.rs:363:16 [INFO] [stdout] | [INFO] [stdout] 363 | if let Event::Key(key) = event::read()? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^-------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/widgets/server_creator.rs:457:13 [INFO] [stdout] | [INFO] [stdout] 457 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 363 ~ match event::read()? { Event::Key(key) => { [INFO] [stdout] 364 | if key.kind == KeyEventKind::Press { [INFO] [stdout] ... [INFO] [stdout] 456 | } [INFO] [stdout] 457 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/widgets/popup_input_box.rs:57:16 [INFO] [stdout] | [INFO] [stdout] 57 | if let Event::Key(key) = event::read()? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^-------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/widgets/popup_input_box.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 57 ~ match event::read()? { Event::Key(key) => { [INFO] [stdout] 58 | if key.kind == KeyEventKind::Press { [INFO] [stdout] ... [INFO] [stdout] 74 | } [INFO] [stdout] 75 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating src/main.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `ssh_utils_lib` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/macros.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/macros.rs:3:6 [INFO] [stderr] | [INFO] [stderr] 3 | ($file:expr_2021, $($arg:tt)*) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/macros.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | ($file:expr, $($arg:tt)*) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 3 | ($file:expr_2021, $($arg:tt)*) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/app.rs:574:9 [INFO] [stdout] | [INFO] [stdout] 574 | std::env::set_var("HOME", home_dir.to_str().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] = note: `--force-warn deprecated-safe-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 574 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 575 ~ unsafe { std::env::set_var("HOME", home_dir.to_str().unwrap()) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/app.rs:276:16 [INFO] [stdout] | [INFO] [stdout] 276 | if let Event::Key(key) = event::read()? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^-------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/app.rs:488:13 [INFO] [stdout] | [INFO] [stdout] 488 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 276 ~ match event::read()? { Event::Key(key) => { [INFO] [stdout] 277 | if key.kind == KeyEventKind::Press { [INFO] [stdout] ... [INFO] [stdout] 487 | } [INFO] [stdout] 488 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/app.rs:342:36 [INFO] [stdout] | [INFO] [stdout] 342 | ... if let Some(password) = self.vault.servers.iter().find_map(|s| { [INFO] [stdout] | __________________________^ - [INFO] [stdout] | |_______________________________________________| [INFO] [stdout] 343 | || ... (s.id == server_id).then(|| { [INFO] [stdout] 344 | || ... decrypt_password( [INFO] [stdout] 345 | || ... &s.id, [INFO] [stdout] ... || [INFO] [stdout] 352 | || ... }) [INFO] [stdout] 353 | || ... }).transpose()? { [INFO] [stdout] | ||_____________________________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |_____________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/app.rs:477:33 [INFO] [stdout] | [INFO] [stdout] 477 | ... } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 342 ~ match self.vault.servers.iter().find_map(|s| { [INFO] [stdout] 343 | (s.id == server_id).then(|| { [INFO] [stdout] ... [INFO] [stdout] 352 | }) [INFO] [stdout] 353 ~ }).transpose()? { Some(password) => { [INFO] [stdout] 354 | if cfg!(debug_assertions) { [INFO] [stdout] ... [INFO] [stdout] 476 | } [INFO] [stdout] 477 ~ } _ => { [INFO] [stdout] 478 | self.render_popup( [INFO] [stdout] ... [INFO] [stdout] 481 | )?; [INFO] [stdout] 482 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/app.rs:547:12 [INFO] [stdout] | [INFO] [stdout] 547 | if let russh_keys::Error::KeyIsEncrypted = e { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/app.rs:553:9 [INFO] [stdout] | [INFO] [stdout] 553 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 547 ~ match e { russh_keys::Error::KeyIsEncrypted => { [INFO] [stdout] 548 | let mut input_box = PopupInputBox::new(" Input key's passphrase: ".to_string()); [INFO] [stdout] ... [INFO] [stdout] 552 | load_secret_key(key_path, Some(passphrase.as_str())).map_err(|e| e.into()) [INFO] [stdout] 553 ~ } _ => { [INFO] [stdout] 554 | Err(e.into()) [INFO] [stdout] 555 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/config/app_vault.rs:261:16 [INFO] [stdout] | [INFO] [stdout] 261 | if let Some(_) = e.downcast_ref::() { [INFO] [stdout] | ^^^^^^^^^^^^^^-^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/config/app_vault.rs:264:13 [INFO] [stdout] | [INFO] [stdout] 264 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 261 ~ match e.downcast_ref::() { Some(_) => { [INFO] [stdout] 262 | println!("wrong password"); [INFO] [stdout] 263 | return Err(e); [INFO] [stdout] 264 ~ } _ => { [INFO] [stdout] 265 | println!("An unexpected error occurred: {}", e); [INFO] [stdout] 266 | return Err(e); [INFO] [stdout] 267 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/widgets/server_creator.rs:363:16 [INFO] [stdout] | [INFO] [stdout] 363 | if let Event::Key(key) = event::read()? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^-------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/widgets/server_creator.rs:457:13 [INFO] [stdout] | [INFO] [stdout] 457 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 363 ~ match event::read()? { Event::Key(key) => { [INFO] [stdout] 364 | if key.kind == KeyEventKind::Press { [INFO] [stdout] ... [INFO] [stdout] 456 | } [INFO] [stdout] 457 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/widgets/popup_input_box.rs:57:16 [INFO] [stdout] | [INFO] [stdout] 57 | if let Event::Key(key) = event::read()? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^-------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/widgets/popup_input_box.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 57 ~ match event::read()? { Event::Key(key) => { [INFO] [stdout] 58 | if key.kind == KeyEventKind::Press { [INFO] [stdout] ... [INFO] [stdout] 74 | } [INFO] [stdout] 75 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating tests/password_session_integration_tests.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `ssh_utils` [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/macros.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | ($file:expr, $($arg:tt)*) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 3 | ($file:expr_2021, $($arg:tt)*) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/main.rs:28:19 [INFO] [stdout] | [INFO] [stdout] 28 | panic::{self, PanicInfo}, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/main.rs:199:28 [INFO] [stdout] | [INFO] [stdout] 199 | fn panic_hook(panic_info: &PanicInfo<'_>) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/app.rs:574:9 [INFO] [stdout] | [INFO] [stdout] 574 | std::env::set_var("HOME", home_dir.to_str().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] = note: `--force-warn deprecated-safe-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 574 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 575 ~ unsafe { std::env::set_var("HOME", home_dir.to_str().unwrap()) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] * src/macros.rs [INFO] [stderr] * src/main.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/macros.rs:3:6 [INFO] [stderr] | [INFO] [stderr] 3 | ($file:expr_2021, $($arg:tt)*) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stderr] --> src/main.rs:28:19 [INFO] [stderr] | [INFO] [stderr] 28 | panic::{self, PanicInfo}, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(deprecated)]` on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stderr] --> src/main.rs:199:28 [INFO] [stderr] | [INFO] [stderr] 199 | fn panic_hook(panic_info: &PanicInfo<'_>) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/main.rs:128:24 [INFO] [stdout] | [INFO] [stdout] 128 | if let Some(_) = e.downcast_ref::() { [INFO] [stdout] | ^^^^^^^^^^^^^^-^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/main.rs:134:21 [INFO] [stdout] | [INFO] [stdout] 134 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 128 ~ match e.downcast_ref::() { Some(_) => { [INFO] [stdout] 129 | println!("Incorrect passphrase. Please try again."); [INFO] [stdout] ... [INFO] [stdout] 133 | } [INFO] [stdout] 134 ~ } _ => { [INFO] [stdout] 135 | return Err(anyhow::anyhow!("Failed to decrypt vault: {:?}", e)); [INFO] [stdout] 136 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/app.rs:276:16 [INFO] [stdout] | [INFO] [stdout] 276 | if let Event::Key(key) = event::read()? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^-------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/app.rs:488:13 [INFO] [stdout] | [INFO] [stdout] 488 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 276 ~ match event::read()? { Event::Key(key) => { [INFO] [stdout] 277 | if key.kind == KeyEventKind::Press { [INFO] [stdout] ... [INFO] [stdout] 487 | } [INFO] [stdout] 488 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/app.rs:342:36 [INFO] [stdout] | [INFO] [stdout] 342 | ... if let Some(password) = self.vault.servers.iter().find_map(|s| { [INFO] [stdout] | __________________________^ - [INFO] [stdout] | |_______________________________________________| [INFO] [stdout] 343 | || ... (s.id == server_id).then(|| { [INFO] [stdout] 344 | || ... decrypt_password( [INFO] [stdout] 345 | || ... &s.id, [INFO] [stdout] ... || [INFO] [stdout] 352 | || ... }) [INFO] [stdout] 353 | || ... }).transpose()? { [INFO] [stdout] | ||_____________________________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |_____________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/app.rs:477:33 [INFO] [stdout] | [INFO] [stdout] 477 | ... } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 342 ~ match self.vault.servers.iter().find_map(|s| { [INFO] [stdout] 343 | (s.id == server_id).then(|| { [INFO] [stdout] ... [INFO] [stdout] 352 | }) [INFO] [stdout] 353 ~ }).transpose()? { Some(password) => { [INFO] [stdout] 354 | if cfg!(debug_assertions) { [INFO] [stdout] ... [INFO] [stdout] 476 | } [INFO] [stdout] 477 ~ } _ => { [INFO] [stdout] 478 | self.render_popup( [INFO] [stdout] ... [INFO] [stdout] 481 | )?; [INFO] [stdout] 482 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/app.rs:547:12 [INFO] [stdout] | [INFO] [stdout] 547 | if let russh_keys::Error::KeyIsEncrypted = e { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/app.rs:553:9 [INFO] [stdout] | [INFO] [stdout] 553 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 547 ~ match e { russh_keys::Error::KeyIsEncrypted => { [INFO] [stdout] 548 | let mut input_box = PopupInputBox::new(" Input key's passphrase: ".to_string()); [INFO] [stdout] ... [INFO] [stdout] 552 | load_secret_key(key_path, Some(passphrase.as_str())).map_err(|e| e.into()) [INFO] [stdout] 553 ~ } _ => { [INFO] [stdout] 554 | Err(e.into()) [INFO] [stdout] 555 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/config/app_vault.rs:261:16 [INFO] [stdout] | [INFO] [stdout] 261 | if let Some(_) = e.downcast_ref::() { [INFO] [stdout] | ^^^^^^^^^^^^^^-^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/config/app_vault.rs:264:13 [INFO] [stdout] | [INFO] [stdout] 264 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 261 ~ match e.downcast_ref::() { Some(_) => { [INFO] [stdout] 262 | println!("wrong password"); [INFO] [stdout] 263 | return Err(e); [INFO] [stdout] 264 ~ } _ => { [INFO] [stdout] 265 | println!("An unexpected error occurred: {}", e); [INFO] [stdout] 266 | return Err(e); [INFO] [stdout] 267 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/widgets/server_creator.rs:363:16 [INFO] [stdout] | [INFO] [stdout] 363 | if let Event::Key(key) = event::read()? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^-------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/widgets/server_creator.rs:457:13 [INFO] [stdout] | [INFO] [stdout] 457 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 363 ~ match event::read()? { Event::Key(key) => { [INFO] [stdout] 364 | if key.kind == KeyEventKind::Press { [INFO] [stdout] ... [INFO] [stdout] 456 | } [INFO] [stdout] 457 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/widgets/popup_input_box.rs:57:16 [INFO] [stdout] | [INFO] [stdout] 57 | if let Event::Key(key) = event::read()? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^-------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/widgets/popup_input_box.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 57 ~ match event::read()? { Event::Key(key) => { [INFO] [stdout] 58 | if key.kind == KeyEventKind::Press { [INFO] [stdout] ... [INFO] [stdout] 74 | } [INFO] [stdout] 75 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating tests/key_session_integration_tests.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `ssh_utils` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/macros.rs [INFO] [stderr] * src/main.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/macros.rs:3:6 [INFO] [stderr] | [INFO] [stderr] 3 | ($file:expr_2021, $($arg:tt)*) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stderr] --> src/main.rs:28:19 [INFO] [stderr] | [INFO] [stderr] 28 | panic::{self, PanicInfo}, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(deprecated)]` on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stderr] --> src/main.rs:199:28 [INFO] [stderr] | [INFO] [stderr] 199 | fn panic_hook(panic_info: &PanicInfo<'_>) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/macros.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | ($file:expr, $($arg:tt)*) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 3 | ($file:expr_2021, $($arg:tt)*) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/main.rs:28:19 [INFO] [stdout] | [INFO] [stdout] 28 | panic::{self, PanicInfo}, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/main.rs:199:28 [INFO] [stdout] | [INFO] [stdout] 199 | fn panic_hook(panic_info: &PanicInfo<'_>) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/main.rs:128:24 [INFO] [stdout] | [INFO] [stdout] 128 | if let Some(_) = e.downcast_ref::() { [INFO] [stdout] | ^^^^^^^^^^^^^^-^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/main.rs:134:21 [INFO] [stdout] | [INFO] [stdout] 134 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 128 ~ match e.downcast_ref::() { Some(_) => { [INFO] [stdout] 129 | println!("Incorrect passphrase. Please try again."); [INFO] [stdout] ... [INFO] [stdout] 133 | } [INFO] [stdout] 134 ~ } _ => { [INFO] [stdout] 135 | return Err(anyhow::anyhow!("Failed to decrypt vault: {:?}", e)); [INFO] [stdout] 136 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/app.rs:276:16 [INFO] [stdout] | [INFO] [stdout] 276 | if let Event::Key(key) = event::read()? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^-------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/app.rs:488:13 [INFO] [stdout] | [INFO] [stdout] 488 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 276 ~ match event::read()? { Event::Key(key) => { [INFO] [stdout] 277 | if key.kind == KeyEventKind::Press { [INFO] [stdout] ... [INFO] [stdout] 487 | } [INFO] [stdout] 488 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/app.rs:342:36 [INFO] [stdout] | [INFO] [stdout] 342 | ... if let Some(password) = self.vault.servers.iter().find_map(|s| { [INFO] [stdout] | __________________________^ - [INFO] [stdout] | |_______________________________________________| [INFO] [stdout] 343 | || ... (s.id == server_id).then(|| { [INFO] [stdout] 344 | || ... decrypt_password( [INFO] [stdout] 345 | || ... &s.id, [INFO] [stdout] ... || [INFO] [stdout] 352 | || ... }) [INFO] [stdout] 353 | || ... }).transpose()? { [INFO] [stdout] | ||_____________________________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |_____________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/app.rs:477:33 [INFO] [stdout] | [INFO] [stdout] 477 | ... } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 342 ~ match self.vault.servers.iter().find_map(|s| { [INFO] [stdout] 343 | (s.id == server_id).then(|| { [INFO] [stdout] ... [INFO] [stdout] 352 | }) [INFO] [stdout] 353 ~ }).transpose()? { Some(password) => { [INFO] [stdout] 354 | if cfg!(debug_assertions) { [INFO] [stdout] ... [INFO] [stdout] 476 | } [INFO] [stdout] 477 ~ } _ => { [INFO] [stdout] 478 | self.render_popup( [INFO] [stdout] ... [INFO] [stdout] 481 | )?; [INFO] [stdout] 482 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/app.rs:547:12 [INFO] [stdout] | [INFO] [stdout] 547 | if let russh_keys::Error::KeyIsEncrypted = e { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/app.rs:553:9 [INFO] [stdout] | [INFO] [stdout] 553 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 547 ~ match e { russh_keys::Error::KeyIsEncrypted => { [INFO] [stdout] 548 | let mut input_box = PopupInputBox::new(" Input key's passphrase: ".to_string()); [INFO] [stdout] ... [INFO] [stdout] 552 | load_secret_key(key_path, Some(passphrase.as_str())).map_err(|e| e.into()) [INFO] [stdout] 553 ~ } _ => { [INFO] [stdout] 554 | Err(e.into()) [INFO] [stdout] 555 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/widgets/server_creator.rs:363:16 [INFO] [stdout] | [INFO] [stdout] 363 | if let Event::Key(key) = event::read()? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^-------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/widgets/server_creator.rs:457:13 [INFO] [stdout] | [INFO] [stdout] 457 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 363 ~ match event::read()? { Event::Key(key) => { [INFO] [stdout] 364 | if key.kind == KeyEventKind::Press { [INFO] [stdout] ... [INFO] [stdout] 456 | } [INFO] [stdout] 457 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/widgets/popup_input_box.rs:57:16 [INFO] [stdout] | [INFO] [stdout] 57 | if let Event::Key(key) = event::read()? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^-------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/widgets/popup_input_box.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 57 ~ match event::read()? { Event::Key(key) => { [INFO] [stdout] 58 | if key.kind == KeyEventKind::Press { [INFO] [stdout] ... [INFO] [stdout] 74 | } [INFO] [stdout] 75 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 20.70s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking ssh-utils v0.1.0 (/tmp/fixit) [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/app.rs:574:9 [INFO] [stdout] | [INFO] [stdout] 574 | std::env::set_var("HOME", home_dir.to_str().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stderr] error: could not compile `ssh-utils` (lib test) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "a0618d766690efb7ff0c4e1d0a414029684624cd8258e5ff8d1cd573516c6939", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a0618d766690efb7ff0c4e1d0a414029684624cd8258e5ff8d1cd573516c6939", kill_on_drop: false }` [INFO] [stdout] a0618d766690efb7ff0c4e1d0a414029684624cd8258e5ff8d1cd573516c6939