[INFO] cloning repository https://github.com/Obirvalger/vml [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Obirvalger/vml" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FObirvalger%2Fvml", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FObirvalger%2Fvml'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4116b43705f314b39f8056604614382ae64b70e8 [INFO] checking Obirvalger/vml/4116b43705f314b39f8056604614382ae64b70e8 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FObirvalger%2Fvml" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] [stderr] Updating files: 40% (6745/16536) Updating files: 41% (6780/16536) Updating files: 42% (6946/16536) Updating files: 43% (7111/16536) Updating files: 44% (7276/16536) Updating files: 45% (7442/16536) Updating files: 46% (7607/16536) Updating files: 47% (7772/16536) Updating files: 48% (7938/16536) Updating files: 49% (8103/16536) Updating files: 50% (8268/16536) Updating files: 51% (8434/16536) Updating files: 52% (8599/16536) Updating files: 53% (8765/16536) Updating files: 54% (8930/16536) Updating files: 55% (9095/16536) Updating files: 56% (9261/16536) Updating files: 57% (9426/16536) Updating files: 58% (9591/16536) Updating files: 59% (9757/16536) Updating files: 60% (9922/16536) Updating files: 61% (10087/16536) Updating files: 62% (10253/16536) Updating files: 63% (10418/16536) Updating files: 64% (10584/16536) Updating files: 65% (10749/16536) Updating files: 66% (10914/16536) Updating files: 67% (11080/16536) Updating files: 68% (11245/16536) Updating files: 69% (11410/16536) Updating files: 70% (11576/16536) Updating files: 71% (11741/16536) Updating files: 72% (11906/16536) Updating files: 73% (12072/16536) Updating files: 74% (12237/16536) Updating files: 75% (12402/16536) Updating files: 76% (12568/16536) Updating files: 77% (12733/16536) Updating files: 78% (12899/16536) Updating files: 79% (13064/16536) Updating files: 80% (13229/16536) Updating files: 81% (13395/16536) Updating files: 82% (13560/16536) Updating files: 83% (13725/16536) Updating files: 84% (13891/16536) Updating files: 85% (14056/16536) Updating files: 86% (14221/16536) Updating files: 87% (14387/16536) Updating files: 88% (14552/16536) Updating files: 89% (14718/16536) Updating files: 90% (14883/16536) Updating files: 91% (15048/16536) Updating files: 92% (15214/16536) Updating files: 93% (15379/16536) Updating files: 94% (15544/16536) Updating files: 95% (15710/16536) Updating files: 95% (15788/16536) Updating files: 96% (15875/16536) Updating files: 97% (16040/16536) Updating files: 98% (16206/16536) Updating files: 99% (16371/16536) Updating files: 100% (16536/16536) Updating files: 100% (16536/16536), done. [INFO] validating manifest of git repo https://github.com/Obirvalger/vml on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-6-tc2/source/.cargo/config.toml [INFO] started tweaking git repo https://github.com/Obirvalger/vml [INFO] finished tweaking git repo https://github.com/Obirvalger/vml [INFO] tweaked toml for git repo https://github.com/Obirvalger/vml written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Obirvalger/vml already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f5ee922666d9808d8b57c5b15c22d79e83cbed2ebc6af8face11288634e02a32 [INFO] running `Command { std: "docker" "start" "-a" "f5ee922666d9808d8b57c5b15c22d79e83cbed2ebc6af8face11288634e02a32", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f5ee922666d9808d8b57c5b15c22d79e83cbed2ebc6af8face11288634e02a32", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f5ee922666d9808d8b57c5b15c22d79e83cbed2ebc6af8face11288634e02a32", kill_on_drop: false }` [INFO] [stdout] f5ee922666d9808d8b57c5b15c22d79e83cbed2ebc6af8face11288634e02a32 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a56800aaa104d04dd45e963e34fd2b51924c7706e88203187f007b91b794063d [INFO] running `Command { std: "docker" "start" "-a" "a56800aaa104d04dd45e963e34fd2b51924c7706e88203187f007b91b794063d", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling cc v1.1.6 [INFO] [stderr] Checking bytes v1.6.1 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking rustls-pki-types v1.7.0 [INFO] [stderr] Compiling regex v1.10.5 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Compiling rustls v0.23.11 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Compiling same-file v1.0.6 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Compiling cpufeatures v0.2.12 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Compiling parse-zoneinfo v0.3.1 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking tokio v1.38.1 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Compiling walkdir v2.5.0 [INFO] [stderr] Checking signal-hook v0.3.17 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling chrono-tz-build v0.3.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling block-buffer v0.10.4 [INFO] [stderr] Compiling crypto-common v0.1.6 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling unicode-segmentation v1.11.0 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Compiling digest v0.10.7 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Compiling sha2 v0.10.8 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking webpki-roots v0.26.3 [INFO] [stderr] Compiling rust-embed-utils v8.5.0 [INFO] [stderr] Compiling chrono-tz v0.9.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Compiling procfs v0.16.0 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking winnow v0.6.14 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling file-lock v2.1.11 [INFO] [stderr] Checking slug v0.1.5 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking cfb v0.7.3 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking faccess v0.2.4 [INFO] [stderr] Checking os_pipe v1.2.0 [INFO] [stderr] Checking strum v0.22.0 [INFO] [stderr] Checking procfs-core v0.16.0 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking utf8-width v0.1.7 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking shellexpand v3.1.0 [INFO] [stderr] Checking urlencoding v2.1.3 [INFO] [stderr] Checking json v0.12.4 [INFO] [stderr] Checking infer v0.16.0 (https://github.com/Obirvalger/infer#e99a2b3c) [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling rust-embed-impl v8.5.0 [INFO] [stderr] Checking clap_complete v3.2.5 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking rust-embed v8.5.0 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking pest v2.7.11 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking hyper-util v0.1.6 [INFO] [stderr] Compiling cmd_lib_macros v1.9.4 [INFO] [stderr] Compiling strum_macros v0.22.0 [INFO] [stderr] Compiling pest_meta v2.7.11 [INFO] [stderr] Checking serde v1.0.204 [INFO] [stderr] Compiling pest_generator v2.7.11 [INFO] [stderr] Checking rustls-webpki v0.102.6 [INFO] [stderr] Compiling pest_derive v2.7.11 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking toml_datetime v0.6.6 [INFO] [stderr] Checking serde_spanned v0.6.6 [INFO] [stderr] Checking serde_json v1.0.120 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking byte-unit v4.0.19 [INFO] [stderr] Checking toml_edit v0.22.16 [INFO] [stderr] Checking mio v0.7.14 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Checking ignore v0.4.22 [INFO] [stderr] Checking cmd_lib v1.9.4 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking crossterm v0.22.1 [INFO] [stderr] Checking globwalk v0.9.1 [INFO] [stderr] Checking tera v1.20.0 [INFO] [stderr] Checking comfy-table v5.0.0 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stderr] Checking hyper-rustls v0.27.2 [INFO] [stderr] Checking reqwest v0.12.5 [INFO] [stderr] Checking toml v0.8.15 [INFO] [stderr] Checking vml v0.1.10 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `vml` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/images.rs [INFO] [stderr] * src/vms_creator.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error: expected one of `.`, `;`, `?`, `}`, or an operator, found `=>` [INFO] [stderr] --> src/images.rs:100:53 [INFO] [stderr] | [INFO] [stderr] 100 | if let Ok(output) = match { Ok(output) => { [INFO] [stderr] | ^^ expected one of `.`, `;`, `?`, `}`, or an operator [INFO] [stderr] | [INFO] [stderr] help: you might have meant to write a "greater than or equal to" comparison [INFO] [stderr] | [INFO] [stderr] 100 | if let Ok(output) = match { Ok(output) >= { [INFO] [stderr] | ~~ [INFO] [stderr] [INFO] [stderr] error: expected one of `.`, `?`, `{`, or an operator, found `}` [INFO] [stderr] --> src/images.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 100 | if let Ok(output) = match { Ok(output) => { [INFO] [stderr] | ----- while parsing this `match` expression [INFO] [stderr] ... [INFO] [stderr] 104 | } _ => {}} [INFO] [stderr] | - expected one of `.`, `?`, `{`, or an operator [INFO] [stderr] 105 | }; [INFO] [stderr] | ^ unexpected token [INFO] [stderr] [INFO] [stderr] warning: unused import: `cmd_lib::run_fun` [INFO] [stderr] --> src/images.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use cmd_lib::run_fun; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: elided lifetime has a name [INFO] [stderr] --> src/vms_creator.rs:37:39 [INFO] [stderr] | [INFO] [stderr] 36 | impl<'a> VMsCreator<'a> { [INFO] [stderr] | -- lifetime `'a` declared here [INFO] [stderr] 37 | pub fn new(config: &'a Config) -> VMsCreator { [INFO] [stderr] | ^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stderr] [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/cli.rs:9:36 [INFO] [stdout] | [INFO] [stdout] 9 | fn print_completions(gen: G, app: &mut Command) { [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/cli.rs:10:14 [INFO] [stdout] | [INFO] [stdout] 10 | generate(gen, app, app.get_name().to_string(), &mut io::stdout()); [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/cli.rs:15:15 [INFO] [stdout] | [INFO] [stdout] 15 | if let Ok(gen) = Shell::from_str(shell, true) { [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/cli.rs:16:27 [INFO] [stdout] | [INFO] [stdout] 16 | print_completions(gen, &mut app) [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/vm.rs:113:46 [INFO] [stdout] | [INFO] [stdout] 113 | (0..5).map(|_| format!("{:02x}", rng.gen::())).collect::>().join(":"); [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/vms_creator.rs:37:39 [INFO] [stdout] | [INFO] [stdout] 36 | impl<'a> VMsCreator<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] 37 | pub fn new(config: &'a Config) -> VMsCreator { [INFO] [stdout] | ^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/images.rs:100:16 [INFO] [stdout] | [INFO] [stdout] 100 | if let Ok(output) = run_fun!($prog $name) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^--------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/images.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 104 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 100 ~ if let Ok(output) = match { Ok(output) => { [INFO] [stdout] 101 | if !output.is_empty() { [INFO] [stdout] 102 | url = output [INFO] [stdout] 103 | } [INFO] [stdout] 104 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/images.rs:120:12 [INFO] [stdout] | [INFO] [stdout] 120 | if let Ok(Some(mtype)) = infer::get_from_path(tmp.path()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^-------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/images.rs:128:9 [INFO] [stdout] | [INFO] [stdout] 128 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 120 ~ match infer::get_from_path(tmp.path()) { Ok(Some(mtype)) => { [INFO] [stdout] 121 | let mime_type = mtype.mime_type(); [INFO] [stdout] ... [INFO] [stdout] 127 | } [INFO] [stdout] 128 ~ } _ => { [INFO] [stdout] 129 | bail!(Error::PullUnknownTypeImage) [INFO] [stdout] 130 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/vm.rs:434:20 [INFO] [stdout] | [INFO] [stdout] 434 | if let Ok(mut filelock) = FileLock::lock(lock_path, block, options) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^----------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/vm.rs:455:17 [INFO] [stdout] | [INFO] [stdout] 455 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 434 ~ match FileLock::lock(lock_path, block, options) { Ok(mut filelock) => { [INFO] [stdout] 435 | let port = get_available_port().unwrap(); [INFO] [stdout] ... [INFO] [stdout] 454 | return Ok(()); [INFO] [stdout] 455 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/vms_creator.rs:125:27 [INFO] [stdout] | [INFO] [stdout] 125 | } else if let Some(parent) = self.parents.iter().find(|p| vm.has_parent(p)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/vms_creator.rs:128:17 [INFO] [stdout] | [INFO] [stdout] 128 | } else if vm.has_common_tags(&self.tags) { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 125 ~ } else { match self.parents.iter().find(|p| vm.has_parent(p)) { Some(parent) => { [INFO] [stdout] 126 | vm.specify(SpecifiedBy::Parent(parent.trim_end_matches('/').to_owned())); [INFO] [stdout] 127 | insert_vm = true; [INFO] [stdout] 128 ~ } _ => if vm.has_common_tags(&self.tags) { [INFO] [stdout] 129 | vm.specify(SpecifiedBy::Tag); [INFO] [stdout] ... [INFO] [stdout] 133 | insert_vm = true; [INFO] [stdout] 134 ~ }}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/vms_creator.rs:156:20 [INFO] [stdout] | [INFO] [stdout] 156 | if let Ok(path) = proc.exe() { [INFO] [stdout] | ^^^^^^^^^^^^^^^---------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/vms_creator.rs:171:17 [INFO] [stdout] | [INFO] [stdout] 171 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 156 ~ match proc.exe() { Ok(path) => { [INFO] [stdout] 157 | if let Some(file_name) = path.file_name() { [INFO] [stdout] ... [INFO] [stdout] 170 | } [INFO] [stdout] 171 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/vms_creator.rs:159:32 [INFO] [stdout] | [INFO] [stdout] 159 | ... if let Ok(fds) = proc.fd() { [INFO] [stdout] | ^^^^^^^^^^^^^^--------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/vms_creator.rs:168:29 [INFO] [stdout] | [INFO] [stdout] 168 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 159 ~ match proc.fd() { Ok(fds) => { [INFO] [stdout] 160 | for fd in fds { [INFO] [stdout] ... [INFO] [stdout] 167 | } [INFO] [stdout] 168 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/vms_creator.rs:161:40 [INFO] [stdout] | [INFO] [stdout] 161 | ... if let FDTarget::Path(f) = fd?.target { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^---^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/vms_creator.rs:166:37 [INFO] [stdout] | [INFO] [stdout] 166 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 161 ~ match fd?.target { FDTarget::Path(f) => { [INFO] [stdout] 162 | if let Some(vm) = vms.get_mut(&f) { [INFO] [stdout] ... [INFO] [stdout] 165 | } [INFO] [stdout] 166 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/vms_creator.rs:162:44 [INFO] [stdout] | [INFO] [stdout] 162 | ... if let Some(vm) = vms.get_mut(&f) { [INFO] [stdout] | ^^^^^^^^^^^^^^^---^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/vms_creator.rs:165:41 [INFO] [stdout] | [INFO] [stdout] 165 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 162 ~ match vms.get_mut(&f) { Some(vm) => { [INFO] [stdout] 163 | vm.set_pid(proc.pid); [INFO] [stdout] 164 | with_pid_vms.insert(vm.name.to_string()); [INFO] [stdout] 165 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/vms_creator.rs:178:24 [INFO] [stdout] | [INFO] [stdout] 178 | if let Some(vm) = vms.values().find(|v| !v.has_pid()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^---^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/vms_creator.rs:180:21 [INFO] [stdout] | [INFO] [stdout] 180 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 178 ~ match vms.values().find(|v| !v.has_pid()) { Some(vm) => { [INFO] [stdout] 179 | Err(Error::VMHasNoPid(vm.name.to_string()).into()) [INFO] [stdout] 180 ~ } _ => { [INFO] [stdout] 181 | Ok(vms.values().cloned().collect()) [INFO] [stdout] 182 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating src/main.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `vml` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/images.rs [INFO] [stderr] * src/vms_creator.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error: expected one of `.`, `;`, `?`, `}`, or an operator, found `=>` [INFO] [stderr] --> src/images.rs:100:53 [INFO] [stderr] | [INFO] [stderr] 100 | if let Ok(output) = match { Ok(output) => { [INFO] [stderr] | ^^ expected one of `.`, `;`, `?`, `}`, or an operator [INFO] [stderr] | [INFO] [stderr] help: you might have meant to write a "greater than or equal to" comparison [INFO] [stderr] | [INFO] [stderr] 100 | if let Ok(output) = match { Ok(output) >= { [INFO] [stderr] | ~~ [INFO] [stderr] [INFO] [stderr] error: expected one of `.`, `?`, `{`, or an operator, found `}` [INFO] [stderr] --> src/images.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 100 | if let Ok(output) = match { Ok(output) => { [INFO] [stderr] | ----- while parsing this `match` expression [INFO] [stderr] ... [INFO] [stderr] 104 | } _ => {}} [INFO] [stderr] | - expected one of `.`, `?`, `{`, or an operator [INFO] [stderr] 105 | }; [INFO] [stderr] | ^ unexpected token [INFO] [stderr] [INFO] [stderr] warning: unused import: `cmd_lib::run_fun` [INFO] [stderr] --> src/images.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use cmd_lib::run_fun; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: elided lifetime has a name [INFO] [stderr] --> src/vms_creator.rs:37:39 [INFO] [stderr] | [INFO] [stderr] 36 | impl<'a> VMsCreator<'a> { [INFO] [stderr] | -- lifetime `'a` declared here [INFO] [stderr] 37 | pub fn new(config: &'a Config) -> VMsCreator { [INFO] [stderr] | ^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stderr] [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/cli.rs:9:36 [INFO] [stdout] | [INFO] [stdout] 9 | fn print_completions(gen: G, app: &mut Command) { [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/cli.rs:10:14 [INFO] [stdout] | [INFO] [stdout] 10 | generate(gen, app, app.get_name().to_string(), &mut io::stdout()); [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/cli.rs:15:15 [INFO] [stdout] | [INFO] [stdout] 15 | if let Ok(gen) = Shell::from_str(shell, true) { [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/cli.rs:16:27 [INFO] [stdout] | [INFO] [stdout] 16 | print_completions(gen, &mut app) [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/vm.rs:113:46 [INFO] [stdout] | [INFO] [stdout] 113 | (0..5).map(|_| format!("{:02x}", rng.gen::())).collect::>().join(":"); [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/vms_creator.rs:37:39 [INFO] [stdout] | [INFO] [stdout] 36 | impl<'a> VMsCreator<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] 37 | pub fn new(config: &'a Config) -> VMsCreator { [INFO] [stdout] | ^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/images.rs:100:16 [INFO] [stdout] | [INFO] [stdout] 100 | if let Ok(output) = run_fun!($prog $name) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^--------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/images.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 104 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 100 ~ if let Ok(output) = match { Ok(output) => { [INFO] [stdout] 101 | if !output.is_empty() { [INFO] [stdout] 102 | url = output [INFO] [stdout] 103 | } [INFO] [stdout] 104 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/images.rs:120:12 [INFO] [stdout] | [INFO] [stdout] 120 | if let Ok(Some(mtype)) = infer::get_from_path(tmp.path()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^-------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/images.rs:128:9 [INFO] [stdout] | [INFO] [stdout] 128 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 120 ~ match infer::get_from_path(tmp.path()) { Ok(Some(mtype)) => { [INFO] [stdout] 121 | let mime_type = mtype.mime_type(); [INFO] [stdout] ... [INFO] [stdout] 127 | } [INFO] [stdout] 128 ~ } _ => { [INFO] [stdout] 129 | bail!(Error::PullUnknownTypeImage) [INFO] [stdout] 130 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/vm.rs:434:20 [INFO] [stdout] | [INFO] [stdout] 434 | if let Ok(mut filelock) = FileLock::lock(lock_path, block, options) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^----------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/vm.rs:455:17 [INFO] [stdout] | [INFO] [stdout] 455 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 434 ~ match FileLock::lock(lock_path, block, options) { Ok(mut filelock) => { [INFO] [stdout] 435 | let port = get_available_port().unwrap(); [INFO] [stdout] ... [INFO] [stdout] 454 | return Ok(()); [INFO] [stdout] 455 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/vms_creator.rs:125:27 [INFO] [stdout] | [INFO] [stdout] 125 | } else if let Some(parent) = self.parents.iter().find(|p| vm.has_parent(p)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/vms_creator.rs:128:17 [INFO] [stdout] | [INFO] [stdout] 128 | } else if vm.has_common_tags(&self.tags) { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 125 ~ } else { match self.parents.iter().find(|p| vm.has_parent(p)) { Some(parent) => { [INFO] [stdout] 126 | vm.specify(SpecifiedBy::Parent(parent.trim_end_matches('/').to_owned())); [INFO] [stdout] 127 | insert_vm = true; [INFO] [stdout] 128 ~ } _ => if vm.has_common_tags(&self.tags) { [INFO] [stdout] 129 | vm.specify(SpecifiedBy::Tag); [INFO] [stdout] ... [INFO] [stdout] 133 | insert_vm = true; [INFO] [stdout] 134 ~ }}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/vms_creator.rs:156:20 [INFO] [stdout] | [INFO] [stdout] 156 | if let Ok(path) = proc.exe() { [INFO] [stdout] | ^^^^^^^^^^^^^^^---------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/vms_creator.rs:171:17 [INFO] [stdout] | [INFO] [stdout] 171 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 156 ~ match proc.exe() { Ok(path) => { [INFO] [stdout] 157 | if let Some(file_name) = path.file_name() { [INFO] [stdout] ... [INFO] [stdout] 170 | } [INFO] [stdout] 171 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/vms_creator.rs:159:32 [INFO] [stdout] | [INFO] [stdout] 159 | ... if let Ok(fds) = proc.fd() { [INFO] [stdout] | ^^^^^^^^^^^^^^--------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/vms_creator.rs:168:29 [INFO] [stdout] | [INFO] [stdout] 168 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 159 ~ match proc.fd() { Ok(fds) => { [INFO] [stdout] 160 | for fd in fds { [INFO] [stdout] ... [INFO] [stdout] 167 | } [INFO] [stdout] 168 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/vms_creator.rs:161:40 [INFO] [stdout] | [INFO] [stdout] 161 | ... if let FDTarget::Path(f) = fd?.target { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^---^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/vms_creator.rs:166:37 [INFO] [stdout] | [INFO] [stdout] 166 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 161 ~ match fd?.target { FDTarget::Path(f) => { [INFO] [stdout] 162 | if let Some(vm) = vms.get_mut(&f) { [INFO] [stdout] ... [INFO] [stdout] 165 | } [INFO] [stdout] 166 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/vms_creator.rs:162:44 [INFO] [stdout] | [INFO] [stdout] 162 | ... if let Some(vm) = vms.get_mut(&f) { [INFO] [stdout] | ^^^^^^^^^^^^^^^---^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/vms_creator.rs:165:41 [INFO] [stdout] | [INFO] [stdout] 165 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 162 ~ match vms.get_mut(&f) { Some(vm) => { [INFO] [stdout] 163 | vm.set_pid(proc.pid); [INFO] [stdout] 164 | with_pid_vms.insert(vm.name.to_string()); [INFO] [stdout] 165 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/vms_creator.rs:178:24 [INFO] [stdout] | [INFO] [stdout] 178 | if let Some(vm) = vms.values().find(|v| !v.has_pid()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^---^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/vms_creator.rs:180:21 [INFO] [stdout] | [INFO] [stdout] 180 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 178 ~ match vms.values().find(|v| !v.has_pid()) { Some(vm) => { [INFO] [stdout] 179 | Err(Error::VMHasNoPid(vm.name.to_string()).into()) [INFO] [stdout] 180 ~ } _ => { [INFO] [stdout] 181 | Ok(vms.values().cloned().collect()) [INFO] [stdout] 182 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 13.76s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking vml v0.1.10 (/tmp/fixit) [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/cli.rs:9:36 [INFO] [stdout] | [INFO] [stdout] 9 | fn print_completions(gen: G, app: &mut Command) { [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 9 | fn print_completions(r#gen: G, app: &mut Command) { [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/cli.rs:9:36 [INFO] [stdout] | [INFO] [stdout] 9 | fn print_completions(gen: G, app: &mut Command) { [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 9 | fn print_completions(r#gen: G, app: &mut Command) { [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected expression, found reserved keyword `gen` [INFO] [stdout] --> src/cli.rs:10:14 [INFO] [stdout] | [INFO] [stdout] 10 | generate(gen, app, app.get_name().to_string(), &mut io::stdout()); [INFO] [stdout] | ^^^ expected expression [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected expression, found reserved keyword `gen` [INFO] [stdout] --> src/cli.rs:10:14 [INFO] [stdout] | [INFO] [stdout] 10 | generate(gen, app, app.get_name().to_string(), &mut io::stdout()); [INFO] [stdout] | ^^^ expected expression [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/cli.rs:15:15 [INFO] [stdout] | [INFO] [stdout] 15 | if let Ok(gen) = Shell::from_str(shell, true) { [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 15 | if let Ok(r#gen) = Shell::from_str(shell, true) { [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/cli.rs:15:15 [INFO] [stdout] | [INFO] [stdout] 15 | if let Ok(gen) = Shell::from_str(shell, true) { [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 15 | if let Ok(r#gen) = Shell::from_str(shell, true) { [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected expression, found reserved keyword `gen` [INFO] [stdout] --> src/cli.rs:16:27 [INFO] [stdout] | [INFO] [stdout] 16 | print_completions(gen, &mut app) [INFO] [stdout] | ^^^ expected expression [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected expression, found reserved keyword `gen` [INFO] [stdout] --> src/cli.rs:16:27 [INFO] [stdout] | [INFO] [stdout] 16 | print_completions(gen, &mut app) [INFO] [stdout] | ^^^ expected expression [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/vm.rs:113:46 [INFO] [stdout] | [INFO] [stdout] 113 | (0..5).map(|_| format!("{:02x}", rng.gen::())).collect::>().join(":"); [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 113 | (0..5).map(|_| format!("{:02x}", rng.r#gen::())).collect::>().join(":"); [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/vm.rs:113:46 [INFO] [stdout] | [INFO] [stdout] 113 | (0..5).map(|_| format!("{:02x}", rng.gen::())).collect::>().join(":"); [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 113 | (0..5).map(|_| format!("{:02x}", rng.r#gen::())).collect::>().join(":"); [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io` [INFO] [stdout] --> src/cli.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::io; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `generate` [INFO] [stdout] --> src/cli.rs:7:21 [INFO] [stdout] | [INFO] [stdout] 7 | use clap_complete::{generate, Generator, Shell}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io` [INFO] [stdout] --> src/cli.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::io; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `generate` [INFO] [stdout] --> src/cli.rs:7:21 [INFO] [stdout] | [INFO] [stdout] 7 | use clap_complete::{generate, Generator, Shell}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/vms_creator.rs:37:39 [INFO] [stdout] | [INFO] [stdout] 36 | impl<'a> VMsCreator<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] 37 | pub fn new(config: &'a Config) -> VMsCreator { [INFO] [stdout] | ^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/vms_creator.rs:37:39 [INFO] [stdout] | [INFO] [stdout] 36 | impl<'a> VMsCreator<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] 37 | pub fn new(config: &'a Config) -> VMsCreator { [INFO] [stdout] | ^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vml` (lib test) due to 6 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 5 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vml` (lib) due to 6 previous errors; 3 warnings emitted [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "a56800aaa104d04dd45e963e34fd2b51924c7706e88203187f007b91b794063d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a56800aaa104d04dd45e963e34fd2b51924c7706e88203187f007b91b794063d", kill_on_drop: false }` [INFO] [stdout] a56800aaa104d04dd45e963e34fd2b51924c7706e88203187f007b91b794063d