[INFO] cloning repository https://github.com/LokyinZHAO/blob-store [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/LokyinZHAO/blob-store" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLokyinZHAO%2Fblob-store", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLokyinZHAO%2Fblob-store'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ff6dfe9f371dee5189987548d2e02f5851e25fe2 [INFO] checking LokyinZHAO/blob-store/ff6dfe9f371dee5189987548d2e02f5851e25fe2 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLokyinZHAO%2Fblob-store" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/LokyinZHAO/blob-store on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/LokyinZHAO/blob-store [INFO] finished tweaking git repo https://github.com/LokyinZHAO/blob-store [INFO] tweaked toml for git repo https://github.com/LokyinZHAO/blob-store written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/LokyinZHAO/blob-store already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f7a014046beec15722ac30428cdec45a55303a252b27db9f09b5585e37125448 [INFO] running `Command { std: "docker" "start" "-a" "f7a014046beec15722ac30428cdec45a55303a252b27db9f09b5585e37125448", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f7a014046beec15722ac30428cdec45a55303a252b27db9f09b5585e37125448", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f7a014046beec15722ac30428cdec45a55303a252b27db9f09b5585e37125448", kill_on_drop: false }` [INFO] [stdout] f7a014046beec15722ac30428cdec45a55303a252b27db9f09b5585e37125448 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6fb7b851f07b80f2b351711b9171be7450185584ccc0b373d71a3f8bc5816663 [INFO] running `Command { std: "docker" "start" "-a" "6fb7b851f07b80f2b351711b9171be7450185584ccc0b373d71a3f8bc5816663", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling proc-macro2 v1.0.84 [INFO] [stderr] Compiling cc v1.0.98 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Compiling scratch v1.0.7 [INFO] [stderr] Compiling unicode-width v0.1.13 [INFO] [stderr] Compiling termcolor v1.4.1 [INFO] [stderr] Compiling cxxbridge-flags v1.0.124 [INFO] [stderr] Checking zerocopy v0.7.34 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking either v1.12.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling codespan-reporting v0.11.1 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling link-cplusplus v1.0.9 [INFO] [stderr] Compiling cxx v1.0.124 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking lru v0.12.3 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Compiling cxx-build v1.0.124 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling cxxbridge-macro v1.0.124 [INFO] [stderr] Compiling blob-store v0.1.0 (/tmp/fixit) [INFO] [stderr] Migrating build.rs from 2021 edition to 2024 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `blob_store` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/ffi/local_file_system.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error: expected one of `:`, `;`, `<`, `=`, or `where`, found `(` [INFO] [stderr] --> src/ffi/local_file_system.rs:56:22 [INFO] [stderr] | [INFO] [stderr] 54 | extern "Rust" { [INFO] [stderr] | - while parsing this item list starting here [INFO] [stderr] 55 | #[cxx_name = "blob_store_t"] [INFO] [stderr] 56 | type Lounsafe(calFileSystemBlobStoreFF)I; [INFO] [stderr] | ^ expected one of `:`, `;`, `<`, `=`, or `where` [INFO] [stderr] ... [INFO] [stderr] 67 | } [INFO] [stderr] | - the item list ends here [INFO] [stderr] [INFO] [stderr] error: expected `;` [INFO] [stderr] --> src/ffi/local_file_system.rs:56:22 [INFO] [stderr] | [INFO] [stderr] 56 | type Lounsafe(calFileSystemBlobStoreFF)I; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:56:14 [INFO] [stdout] | [INFO] [stdout] 56 | type LocalFileSystemBlobStoreFFI; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123757 [INFO] [stdout] = note: `--force-warn unsafe-attr-outside-unsafe` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 56 | type Lounsafe(calFileSystemBlobStoreFF)I; [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:57:92 [INFO] [stdout] | [INFO] [stdout] 57 | fn blob_store_connect(path: &CxxString) -> Result>; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123757 [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 57 | fn blob_store_connect(path: &CxxString) -> Result>unsafe(;) [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:58:53 [INFO] [stdout] | [INFO] [stdout] 58 | fn contains(&self, key: u64) -> Result; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123757 [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 58 | fn contains(&self, key: u64) -> Resultunsafe(;) [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:59:55 [INFO] [stdout] | [INFO] [stdout] 59 | fn blob_size(&self, key: u64) -> Result; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123757 [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 59 | fn blob_size(&self, key: u64) -> Resultunsafe(;) [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:60:63 [INFO] [stdout] | [INFO] [stdout] 60 | fn create(&self, key: u64, value: &[u8]) -> Result<()>; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123757 [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 60 | fn create(&self, key: u64, value: &[u8]) -> Result<()>unsafe(;) [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:61:75 [INFO] [stdout] | [INFO] [stdout] 61 | fn put(&self, key: u64, value: &[u8], offset: usize) -> Result<()>; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123757 [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 61 | fn put(&self, key: u64, value: &[u8], offset: usize) -> Result<()>unsafe(;) [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:62:70 [INFO] [stdout] | [INFO] [stdout] 62 | fn put_or_create(&self, key: u64, value: &[u8]) -> Result<()>; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123757 [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 62 | fn put_or_create(&self, key: u64, value: &[u8]) -> Result<()>unsafe(;) [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:63:66 [INFO] [stdout] | [INFO] [stdout] 63 | fn get_all(&self, key: u64, buf: &mut [u8]) -> Result<()>; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123757 [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 63 | fn get_all(&self, key: u64, buf: &mut [u8]) -> Result<()>unsafe(;) [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:64:84 [INFO] [stdout] | [INFO] [stdout] 64 | fn get_offset(&self, key: u64, buf: &mut [u8], offset: usize) -> Result<()>; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123757 [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 64 | fn get_offset(&self, key: u64, buf: &mut [u8], offset: usize) -> Result<()>unsafe(;) [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:66:49 [INFO] [stdout] | [INFO] [stdout] 66 | fn delete(&self, key: u64) -> Result<()>; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123757 [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 66 | fn delete(&self, key: u64) -> Result<()>unsafe(;) [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:57:90 [INFO] [stdout] | [INFO] [stdout] 57 | fn blob_store_connect(path: &CxxString) -> Result>; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123757 [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 57 | fn blob_store_connect(path: &CxxString) -> Result)>; [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl std::fmt::Display` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/ffi/local_file_system.rs:57:52 [INFO] [stdout] | [INFO] [stdout] 57 | fn blob_store_connect(path: &CxxString) -> Result>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/ffi/local_file_system.rs:57:37 [INFO] [stdout] | [INFO] [stdout] 57 | fn blob_store_connect(path: &CxxString) -> Result>; [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] = note: `--force-warn impl-trait-overcaptures` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl std::fmt::Display` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/ffi/local_file_system.rs:58:41 [INFO] [stdout] | [INFO] [stdout] 58 | fn contains(&self, key: u64) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/ffi/local_file_system.rs:56:14 [INFO] [stdout] | [INFO] [stdout] 56 | type LocalFileSystemBlobStoreFFI; [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl std::fmt::Display` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/ffi/local_file_system.rs:59:42 [INFO] [stdout] | [INFO] [stdout] 59 | fn blob_size(&self, key: u64) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/ffi/local_file_system.rs:56:14 [INFO] [stdout] | [INFO] [stdout] 56 | type LocalFileSystemBlobStoreFFI; [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl std::fmt::Display` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/ffi/local_file_system.rs:60:53 [INFO] [stdout] | [INFO] [stdout] 60 | fn create(&self, key: u64, value: &[u8]) -> Result<()>; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, these lifetimes are in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/ffi/local_file_system.rs:56:14 [INFO] [stdout] | [INFO] [stdout] 56 | type LocalFileSystemBlobStoreFFI; [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 60 | fn create(&self, key: u64, value: &[u8]) -> Result<()>; [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl std::fmt::Display` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/ffi/local_file_system.rs:61:65 [INFO] [stdout] | [INFO] [stdout] 61 | fn put(&self, key: u64, value: &[u8], offset: usize) -> Result<()>; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, these lifetimes are in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/ffi/local_file_system.rs:56:14 [INFO] [stdout] | [INFO] [stdout] 56 | type LocalFileSystemBlobStoreFFI; [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 61 | fn put(&self, key: u64, value: &[u8], offset: usize) -> Result<()>; [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl std::fmt::Display` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/ffi/local_file_system.rs:62:60 [INFO] [stdout] | [INFO] [stdout] 62 | fn put_or_create(&self, key: u64, value: &[u8]) -> Result<()>; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, these lifetimes are in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/ffi/local_file_system.rs:56:14 [INFO] [stdout] | [INFO] [stdout] 56 | type LocalFileSystemBlobStoreFFI; [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 62 | fn put_or_create(&self, key: u64, value: &[u8]) -> Result<()>; [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl std::fmt::Display` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/ffi/local_file_system.rs:63:56 [INFO] [stdout] | [INFO] [stdout] 63 | fn get_all(&self, key: u64, buf: &mut [u8]) -> Result<()>; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, these lifetimes are in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/ffi/local_file_system.rs:56:14 [INFO] [stdout] | [INFO] [stdout] 56 | type LocalFileSystemBlobStoreFFI; [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 63 | fn get_all(&self, key: u64, buf: &mut [u8]) -> Result<()>; [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl std::fmt::Display` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/ffi/local_file_system.rs:64:74 [INFO] [stdout] | [INFO] [stdout] 64 | fn get_offset(&self, key: u64, buf: &mut [u8], offset: usize) -> Result<()>; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, these lifetimes are in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/ffi/local_file_system.rs:56:14 [INFO] [stdout] | [INFO] [stdout] 56 | type LocalFileSystemBlobStoreFFI; [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 64 | fn get_offset(&self, key: u64, buf: &mut [u8], offset: usize) -> Result<()>; [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl std::fmt::Display` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/ffi/local_file_system.rs:66:39 [INFO] [stdout] | [INFO] [stdout] 66 | fn delete(&self, key: u64) -> Result<()>; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/ffi/local_file_system.rs:56:14 [INFO] [stdout] | [INFO] [stdout] 56 | type LocalFileSystemBlobStoreFFI; [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 20 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `blob_store` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/ffi/local_file_system.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error: expected one of `:`, `;`, `<`, `=`, or `where`, found `(` [INFO] [stderr] --> src/ffi/local_file_system.rs:56:22 [INFO] [stderr] | [INFO] [stderr] 54 | extern "Rust" { [INFO] [stderr] | - while parsing this item list starting here [INFO] [stderr] 55 | #[cxx_name = "blob_store_t"] [INFO] [stderr] 56 | type Lounsafe(calFileSystemBlobStoreFF)I; [INFO] [stderr] | ^ expected one of `:`, `;`, `<`, `=`, or `where` [INFO] [stderr] ... [INFO] [stderr] 67 | } [INFO] [stderr] | - the item list ends here [INFO] [stderr] [INFO] [stderr] error: expected `;` [INFO] [stderr] --> src/ffi/local_file_system.rs:56:22 [INFO] [stderr] | [INFO] [stderr] 56 | type Lounsafe(calFileSystemBlobStoreFF)I; [INFO] [stderr] | ^ [INFO] [stdout] warning: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:56:14 [INFO] [stdout] | [INFO] [stdout] 56 | type LocalFileSystemBlobStoreFFI; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123757 [INFO] [stdout] = note: `--force-warn unsafe-attr-outside-unsafe` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 56 | type Lounsafe(calFileSystemBlobStoreFF)I; [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:57:92 [INFO] [stdout] | [INFO] [stdout] 57 | fn blob_store_connect(path: &CxxString) -> Result>; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123757 [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 57 | fn blob_store_connect(path: &CxxString) -> Result>unsafe(;) [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:58:53 [INFO] [stdout] | [INFO] [stdout] 58 | fn contains(&self, key: u64) -> Result; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123757 [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 58 | fn contains(&self, key: u64) -> Resultunsafe(;) [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:59:55 [INFO] [stdout] | [INFO] [stdout] 59 | fn blob_size(&self, key: u64) -> Result; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123757 [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 59 | fn blob_size(&self, key: u64) -> Resultunsafe(;) [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:60:63 [INFO] [stdout] | [INFO] [stdout] 60 | fn create(&self, key: u64, value: &[u8]) -> Result<()>; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123757 [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 60 | fn create(&self, key: u64, value: &[u8]) -> Result<()>unsafe(;) [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:61:75 [INFO] [stdout] | [INFO] [stdout] 61 | fn put(&self, key: u64, value: &[u8], offset: usize) -> Result<()>; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123757 [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 61 | fn put(&self, key: u64, value: &[u8], offset: usize) -> Result<()>unsafe(;) [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:62:70 [INFO] [stdout] | [INFO] [stdout] 62 | fn put_or_create(&self, key: u64, value: &[u8]) -> Result<()>; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123757 [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 62 | fn put_or_create(&self, key: u64, value: &[u8]) -> Result<()>unsafe(;) [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:63:66 [INFO] [stdout] | [INFO] [stdout] 63 | fn get_all(&self, key: u64, buf: &mut [u8]) -> Result<()>; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123757 [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 63 | fn get_all(&self, key: u64, buf: &mut [u8]) -> Result<()>unsafe(;) [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:64:84 [INFO] [stdout] | [INFO] [stdout] 64 | fn get_offset(&self, key: u64, buf: &mut [u8], offset: usize) -> Result<()>; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123757 [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 64 | fn get_offset(&self, key: u64, buf: &mut [u8], offset: usize) -> Result<()>unsafe(;) [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:66:49 [INFO] [stdout] | [INFO] [stdout] 66 | fn delete(&self, key: u64) -> Result<()>; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123757 [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 66 | fn delete(&self, key: u64) -> Result<()>unsafe(;) [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:57:90 [INFO] [stdout] | [INFO] [stdout] 57 | fn blob_store_connect(path: &CxxString) -> Result>; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123757 [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 57 | fn blob_store_connect(path: &CxxString) -> Result)>; [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl std::fmt::Display` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/ffi/local_file_system.rs:57:52 [INFO] [stdout] | [INFO] [stdout] 57 | fn blob_store_connect(path: &CxxString) -> Result>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/ffi/local_file_system.rs:57:37 [INFO] [stdout] | [INFO] [stdout] 57 | fn blob_store_connect(path: &CxxString) -> Result>; [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] = note: `--force-warn impl-trait-overcaptures` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl std::fmt::Display` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/ffi/local_file_system.rs:58:41 [INFO] [stdout] | [INFO] [stdout] 58 | fn contains(&self, key: u64) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/ffi/local_file_system.rs:56:14 [INFO] [stdout] | [INFO] [stdout] 56 | type LocalFileSystemBlobStoreFFI; [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl std::fmt::Display` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/ffi/local_file_system.rs:59:42 [INFO] [stdout] | [INFO] [stdout] 59 | fn blob_size(&self, key: u64) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/ffi/local_file_system.rs:56:14 [INFO] [stdout] | [INFO] [stdout] 56 | type LocalFileSystemBlobStoreFFI; [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl std::fmt::Display` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/ffi/local_file_system.rs:60:53 [INFO] [stdout] | [INFO] [stdout] 60 | fn create(&self, key: u64, value: &[u8]) -> Result<()>; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, these lifetimes are in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/ffi/local_file_system.rs:56:14 [INFO] [stdout] | [INFO] [stdout] 56 | type LocalFileSystemBlobStoreFFI; [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 60 | fn create(&self, key: u64, value: &[u8]) -> Result<()>; [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl std::fmt::Display` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/ffi/local_file_system.rs:61:65 [INFO] [stdout] | [INFO] [stdout] 61 | fn put(&self, key: u64, value: &[u8], offset: usize) -> Result<()>; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, these lifetimes are in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/ffi/local_file_system.rs:56:14 [INFO] [stdout] | [INFO] [stdout] 56 | type LocalFileSystemBlobStoreFFI; [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 61 | fn put(&self, key: u64, value: &[u8], offset: usize) -> Result<()>; [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl std::fmt::Display` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/ffi/local_file_system.rs:62:60 [INFO] [stdout] | [INFO] [stdout] 62 | fn put_or_create(&self, key: u64, value: &[u8]) -> Result<()>; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, these lifetimes are in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/ffi/local_file_system.rs:56:14 [INFO] [stdout] | [INFO] [stdout] 56 | type LocalFileSystemBlobStoreFFI; [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 62 | fn put_or_create(&self, key: u64, value: &[u8]) -> Result<()>; [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl std::fmt::Display` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/ffi/local_file_system.rs:63:56 [INFO] [stdout] | [INFO] [stdout] 63 | fn get_all(&self, key: u64, buf: &mut [u8]) -> Result<()>; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, these lifetimes are in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/ffi/local_file_system.rs:56:14 [INFO] [stdout] | [INFO] [stdout] 56 | type LocalFileSystemBlobStoreFFI; [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 63 | fn get_all(&self, key: u64, buf: &mut [u8]) -> Result<()>; [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl std::fmt::Display` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/ffi/local_file_system.rs:64:74 [INFO] [stdout] | [INFO] [stdout] 64 | fn get_offset(&self, key: u64, buf: &mut [u8], offset: usize) -> Result<()>; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, these lifetimes are in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/ffi/local_file_system.rs:56:14 [INFO] [stdout] | [INFO] [stdout] 56 | type LocalFileSystemBlobStoreFFI; [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 64 | fn get_offset(&self, key: u64, buf: &mut [u8], offset: usize) -> Result<()>; [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl std::fmt::Display` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/ffi/local_file_system.rs:66:39 [INFO] [stdout] | [INFO] [stdout] 66 | fn delete(&self, key: u64) -> Result<()>; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/ffi/local_file_system.rs:56:14 [INFO] [stdout] | [INFO] [stdout] 56 | type LocalFileSystemBlobStoreFFI; [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 20 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating src/main.rs from 2021 edition to 2024 [INFO] [stderr] Fixed src/main.rs (1 fix) [INFO] [stderr] Migrating tests/blob_store_impl.rs from 2021 edition to 2024 [INFO] [stderr] Fixed tests/common/blob_store_helper.rs (4 fixes) [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> tests/common/blob_store_helper.rs:266:23 [INFO] [stdout] | [INFO] [stdout] 266 | while let Ok((key, data)) = consumer.recv() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^--------^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> tests/common/blob_store_helper.rs:272:17 [INFO] [stdout] | [INFO] [stdout] 272 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> tests/common/blob_store_helper.rs:282:23 [INFO] [stdout] | [INFO] [stdout] 282 | while let Ok((key, _)) = consumer.recv() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^--------^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> tests/common/blob_store_helper.rs:284:17 [INFO] [stdout] | [INFO] [stdout] 284 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.81s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Compiling blob-store v0.1.0 (/tmp/fixit) [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:56:14 [INFO] [stdout] | [INFO] [stdout] 56 | type LocalFileSystemBlobStoreFFI; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 56 | type Lounsafe(calFileSystemBlobStoreFF)I; [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:56:14 [INFO] [stdout] | [INFO] [stdout] 56 | type LocalFileSystemBlobStoreFFI; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 56 | type Lounsafe(calFileSystemBlobStoreFF)I; [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:57:92 [INFO] [stdout] | [INFO] [stdout] 57 | fn blob_store_connect(path: &CxxString) -> Result>; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 57 | fn blob_store_connect(path: &CxxString) -> Result>unsafe(;) [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:58:53 [INFO] [stdout] | [INFO] [stdout] 58 | fn contains(&self, key: u64) -> Result; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 58 | fn contains(&self, key: u64) -> Resultunsafe(;) [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:57:92 [INFO] [stdout] | [INFO] [stdout] 57 | fn blob_store_connect(path: &CxxString) -> Result>; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 57 | fn blob_store_connect(path: &CxxString) -> Result>unsafe(;) [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:59:55 [INFO] [stdout] | [INFO] [stdout] 59 | fn blob_size(&self, key: u64) -> Result; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 59 | fn blob_size(&self, key: u64) -> Resultunsafe(;) [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:58:53 [INFO] [stdout] | [INFO] [stdout] 58 | fn contains(&self, key: u64) -> Result; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 58 | fn contains(&self, key: u64) -> Resultunsafe(;) [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:59:55 [INFO] [stdout] | [INFO] [stdout] 59 | fn blob_size(&self, key: u64) -> Result; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 59 | fn blob_size(&self, key: u64) -> Resultunsafe(;) [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:60:63 [INFO] [stdout] | [INFO] [stdout] 60 | fn create(&self, key: u64, value: &[u8]) -> Result<()>; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 60 | fn create(&self, key: u64, value: &[u8]) -> Result<()>unsafe(;) [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:60:63 [INFO] [stdout] | [INFO] [stdout] 60 | fn create(&self, key: u64, value: &[u8]) -> Result<()>; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 60 | fn create(&self, key: u64, value: &[u8]) -> Result<()>unsafe(;) [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:61:75 [INFO] [stdout] | [INFO] [stdout] 61 | fn put(&self, key: u64, value: &[u8], offset: usize) -> Result<()>; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 61 | fn put(&self, key: u64, value: &[u8], offset: usize) -> Result<()>unsafe(;) [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:61:75 [INFO] [stdout] | [INFO] [stdout] 61 | fn put(&self, key: u64, value: &[u8], offset: usize) -> Result<()>; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 61 | fn put(&self, key: u64, value: &[u8], offset: usize) -> Result<()>unsafe(;) [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:62:70 [INFO] [stdout] | [INFO] [stdout] 62 | fn put_or_create(&self, key: u64, value: &[u8]) -> Result<()>; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 62 | fn put_or_create(&self, key: u64, value: &[u8]) -> Result<()>unsafe(;) [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:62:70 [INFO] [stdout] | [INFO] [stdout] 62 | fn put_or_create(&self, key: u64, value: &[u8]) -> Result<()>; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 62 | fn put_or_create(&self, key: u64, value: &[u8]) -> Result<()>unsafe(;) [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:63:66 [INFO] [stdout] | [INFO] [stdout] 63 | fn get_all(&self, key: u64, buf: &mut [u8]) -> Result<()>; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 63 | fn get_all(&self, key: u64, buf: &mut [u8]) -> Result<()>unsafe(;) [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:64:84 [INFO] [stdout] | [INFO] [stdout] 64 | fn get_offset(&self, key: u64, buf: &mut [u8], offset: usize) -> Result<()>; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 64 | fn get_offset(&self, key: u64, buf: &mut [u8], offset: usize) -> Result<()>unsafe(;) [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:63:66 [INFO] [stdout] | [INFO] [stdout] 63 | fn get_all(&self, key: u64, buf: &mut [u8]) -> Result<()>; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 63 | fn get_all(&self, key: u64, buf: &mut [u8]) -> Result<()>unsafe(;) [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:66:49 [INFO] [stdout] | [INFO] [stdout] 66 | fn delete(&self, key: u64) -> Result<()>; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 66 | fn delete(&self, key: u64) -> Result<()>unsafe(;) [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:64:84 [INFO] [stdout] | [INFO] [stdout] 64 | fn get_offset(&self, key: u64, buf: &mut [u8], offset: usize) -> Result<()>; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 64 | fn get_offset(&self, key: u64, buf: &mut [u8], offset: usize) -> Result<()>unsafe(;) [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:57:90 [INFO] [stdout] | [INFO] [stdout] 57 | fn blob_store_connect(path: &CxxString) -> Result>; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 57 | fn blob_store_connect(path: &CxxString) -> Result)>; [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:66:49 [INFO] [stdout] | [INFO] [stdout] 66 | fn delete(&self, key: u64) -> Result<()>; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 66 | fn delete(&self, key: u64) -> Result<()>unsafe(;) [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> src/ffi/local_file_system.rs:57:90 [INFO] [stdout] | [INFO] [stdout] 57 | fn blob_store_connect(path: &CxxString) -> Result>; [INFO] [stdout] | ^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 57 | fn blob_store_connect(path: &CxxString) -> Result)>; [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `blob-store` (lib) due to 12 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `blob-store` (lib test) due to 12 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "6fb7b851f07b80f2b351711b9171be7450185584ccc0b373d71a3f8bc5816663", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6fb7b851f07b80f2b351711b9171be7450185584ccc0b373d71a3f8bc5816663", kill_on_drop: false }` [INFO] [stdout] 6fb7b851f07b80f2b351711b9171be7450185584ccc0b373d71a3f8bc5816663