[INFO] cloning repository https://github.com/Lauchmelder23/rusty-nes [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Lauchmelder23/rusty-nes" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLauchmelder23%2Frusty-nes", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLauchmelder23%2Frusty-nes'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d40fc7588bce1793781a9768759d8ad8b7bbf4b6 [INFO] checking Lauchmelder23/rusty-nes/d40fc7588bce1793781a9768759d8ad8b7bbf4b6 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLauchmelder23%2Frusty-nes" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Lauchmelder23/rusty-nes on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Lauchmelder23/rusty-nes [INFO] finished tweaking git repo https://github.com/Lauchmelder23/rusty-nes [INFO] tweaked toml for git repo https://github.com/Lauchmelder23/rusty-nes written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Lauchmelder23/rusty-nes already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ef1500cf6a6e236766c502df00eca3f3a86aaf5813d44ea1999173863514ab4e [INFO] running `Command { std: "docker" "start" "-a" "ef1500cf6a6e236766c502df00eca3f3a86aaf5813d44ea1999173863514ab4e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ef1500cf6a6e236766c502df00eca3f3a86aaf5813d44ea1999173863514ab4e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ef1500cf6a6e236766c502df00eca3f3a86aaf5813d44ea1999173863514ab4e", kill_on_drop: false }` [INFO] [stdout] ef1500cf6a6e236766c502df00eca3f3a86aaf5813d44ea1999173863514ab4e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a55ec5911d47a2030b1881dc496234a5a87a4cba5060724a741ed3c2be63d617 [INFO] running `Command { std: "docker" "start" "-a" "a55ec5911d47a2030b1881dc496234a5a87a4cba5060724a741ed3c2be63d617", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Checking raw-window-handle v0.4.3 [INFO] [stderr] Compiling cmake v0.1.48 [INFO] [stderr] Compiling glfw-sys v4.0.0+3.3.5 [INFO] [stderr] Compiling rusty-nes v0.1.0 (/tmp/fixit) [INFO] [stderr] Migrating build.rs from 2021 edition to 2024 [INFO] [stderr] Checking glfw v0.45.0 [INFO] [stderr] Migrating src/main.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `rusty_nes` [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/nes/instructions.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 53 | ($target: expr, $flag: expr) => [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 53 | ($target: expr_2021, $flag: expr) => [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/nes/cartridge.rs [INFO] [stderr] * src/nes/instructions.rs [INFO] [stderr] * src/nes/ppu.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/nes/instructions.rs:53:3 [INFO] [stderr] | [INFO] [stderr] 53 | ($target: expr_2021, $flag: expr_2021) => [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/nes/instructions.rs:53:23 [INFO] [stderr] | [INFO] [stderr] 53 | ($target: expr_2021, $flag: expr_2021) => [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/nes/instructions.rs:61:3 [INFO] [stderr] | [INFO] [stderr] 61 | ($target: expr_2021, $flag: expr_2021) => [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/nes/instructions.rs:61:23 [INFO] [stderr] | [INFO] [stderr] 61 | ($target: expr_2021, $flag: expr_2021) => [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/nes/instructions.rs:69:3 [INFO] [stderr] | [INFO] [stderr] 69 | ($target: expr_2021, $flag: expr_2021, $value: expr_2021) => [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/nes/instructions.rs:69:23 [INFO] [stderr] | [INFO] [stderr] 69 | ($target: expr_2021, $flag: expr_2021, $value: expr_2021) => [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/nes/instructions.rs:69:41 [INFO] [stderr] | [INFO] [stderr] 69 | ($target: expr_2021, $flag: expr_2021, $value: expr_2021) => [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/nes/instructions.rs:77:3 [INFO] [stderr] | [INFO] [stderr] 77 | ($target: expr_2021, $flag: expr_2021) => [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/nes/instructions.rs:77:23 [INFO] [stderr] | [INFO] [stderr] 77 | ($target: expr_2021, $flag: expr_2021) => [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/nes/instructions.rs:85:3 [INFO] [stderr] | [INFO] [stderr] 85 | ($bus: expr_2021, $sp: expr_2021, $val: expr_2021) => [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/nes/instructions.rs:85:20 [INFO] [stderr] | [INFO] [stderr] 85 | ($bus: expr_2021, $sp: expr_2021, $val: expr_2021) => [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/nes/instructions.rs:85:36 [INFO] [stderr] | [INFO] [stderr] 85 | ($bus: expr_2021, $sp: expr_2021, $val: expr_2021) => [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/nes/instructions.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | ($name: ident, $flag: expr_2021, $result: literal) => [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/nes/instructions.rs:130:17 [INFO] [stderr] | [INFO] [stderr] 130 | ($name: ident, $flag: expr_2021, $result: literal) => [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] warning: unused variable: `val` [INFO] [stderr] --> src/nes/ppu.rs:27:44 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn set_regsiter(&mut self, addr: u16, val: u8) [INFO] [stderr] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bus` [INFO] [stderr] --> src/nes/instructions.rs:546:7 [INFO] [stderr] | [INFO] [stderr] 546 | let bus = self.bus.upgrade().unwrap(); [INFO] [stderr] | ^^^ help: if this is intentional, prefix it with an underscore: `_bus` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/nes/cartridge.rs:56:30 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn write_prg(&mut self, addr: u16, val: u8) [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `val` [INFO] [stderr] --> src/nes/cartridge.rs:56:41 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn write_prg(&mut self, addr: u16, val: u8) [INFO] [stderr] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stderr] [INFO] [stderr] error: aborting due to 14 previous errors; 4 warnings emitted [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/nes/instructions.rs:53:25 [INFO] [stdout] | [INFO] [stdout] 53 | ($target: expr, $flag: expr) => [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 53 | ($target: expr, $flag: expr_2021) => [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/nes/instructions.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 61 | ($target: expr, $flag: expr) => [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 61 | ($target: expr_2021, $flag: expr) => [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/nes/instructions.rs:61:25 [INFO] [stdout] | [INFO] [stdout] 61 | ($target: expr, $flag: expr) => [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 61 | ($target: expr, $flag: expr_2021) => [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/nes/instructions.rs:69:12 [INFO] [stdout] | [INFO] [stdout] 69 | ($target: expr, $flag: expr, $value: expr) => [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 69 | ($target: expr_2021, $flag: expr, $value: expr) => [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/nes/instructions.rs:69:25 [INFO] [stdout] | [INFO] [stdout] 69 | ($target: expr, $flag: expr, $value: expr) => [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 69 | ($target: expr, $flag: expr_2021, $value: expr) => [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/nes/instructions.rs:69:39 [INFO] [stdout] | [INFO] [stdout] 69 | ($target: expr, $flag: expr, $value: expr) => [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 69 | ($target: expr, $flag: expr, $value: expr_2021) => [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/nes/instructions.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 77 | ($target: expr, $flag: expr) => [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 77 | ($target: expr_2021, $flag: expr) => [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/nes/instructions.rs:77:25 [INFO] [stdout] | [INFO] [stdout] 77 | ($target: expr, $flag: expr) => [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 77 | ($target: expr, $flag: expr_2021) => [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/nes/instructions.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | ($bus: expr, $sp: expr, $val: expr) => [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 85 | ($bus: expr_2021, $sp: expr, $val: expr) => [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/nes/instructions.rs:85:20 [INFO] [stdout] | [INFO] [stdout] 85 | ($bus: expr, $sp: expr, $val: expr) => [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 85 | ($bus: expr, $sp: expr_2021, $val: expr) => [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/nes/instructions.rs:85:32 [INFO] [stdout] | [INFO] [stdout] 85 | ($bus: expr, $sp: expr, $val: expr) => [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 85 | ($bus: expr, $sp: expr, $val: expr_2021) => [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/nes/instructions.rs:116:24 [INFO] [stdout] | [INFO] [stdout] 116 | ($name: ident, $flag: expr, $result: literal) => [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 116 | ($name: ident, $flag: expr_2021, $result: literal) => [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/nes/instructions.rs:130:24 [INFO] [stdout] | [INFO] [stdout] 130 | ($name: ident, $flag: expr, $result: literal) => [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 130 | ($name: ident, $flag: expr_2021, $result: literal) => [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/renderer/context.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | extern "C" [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | _help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | | [INFO] [stdout] 4 | | { [INFO] [stdout] 5 | | #[allow(improper_ctypes)] [INFO] [stdout] 6 | | pub fn init_opengl( [INFO] [stdout] ... | [INFO] [stdout] 11 | | pub fn clear(); [INFO] [stdout] 12 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] = note: `--force-warn missing-unsafe-on-extern` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/nes/ppu.rs:27:44 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn set_regsiter(&mut self, addr: u16, val: u8) [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `bus` [INFO] [stdout] --> src/nes/instructions.rs:546:7 [INFO] [stdout] | [INFO] [stdout] 546 | let bus = self.bus.upgrade().unwrap(); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_bus` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr` [INFO] [stdout] --> src/nes/cartridge.rs:56:30 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn write_prg(&mut self, addr: u16, val: u8) [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/nes/cartridge.rs:56:41 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn write_prg(&mut self, addr: u16, val: u8) [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `bus` is never read [INFO] [stdout] --> src/nes/nes.rs:9:2 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct NES [INFO] [stdout] | --- field in this struct [INFO] [stdout] 8 | { [INFO] [stdout] 9 | bus: Rc>, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `clock` and `single_step` are never used [INFO] [stdout] --> src/nes/nes.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 31 | impl NES [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 55 | pub fn clock(&self) [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 63 | pub fn single_step(&self) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `sync` is never used [INFO] [stdout] --> src/nes/cpu.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 33 | impl CPU [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 90 | pub fn sync(&self) -> bool [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `bus` is never read [INFO] [stdout] --> src/nes/ppu.rs:11:2 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct PPU [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 11 | bus: Weak> [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `cli` and `brk` are never used [INFO] [stdout] --> src/nes/instructions.rs:357:15 [INFO] [stdout] | [INFO] [stdout] 313 | impl CPU [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 357 | set_flag_fn!(cli, Bit::Interrupt, false); [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 544 | fn brk(&mut self) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `set_flag_fn` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 24 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `rusty_nes` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/nes/cartridge.rs [INFO] [stderr] * src/nes/instructions.rs [INFO] [stderr] * src/nes/ppu.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/nes/instructions.rs:53:3 [INFO] [stderr] | [INFO] [stderr] 53 | ($target: expr_2021, $flag: expr_2021) => [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/nes/instructions.rs:53:23 [INFO] [stderr] | [INFO] [stderr] 53 | ($target: expr_2021, $flag: expr_2021) => [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/nes/instructions.rs:61:3 [INFO] [stderr] | [INFO] [stderr] 61 | ($target: expr_2021, $flag: expr_2021) => [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/nes/instructions.rs:61:23 [INFO] [stderr] | [INFO] [stderr] 61 | ($target: expr_2021, $flag: expr_2021) => [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/nes/instructions.rs:69:3 [INFO] [stderr] | [INFO] [stderr] 69 | ($target: expr_2021, $flag: expr_2021, $value: expr_2021) => [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/nes/instructions.rs:69:23 [INFO] [stderr] | [INFO] [stderr] 69 | ($target: expr_2021, $flag: expr_2021, $value: expr_2021) => [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/nes/instructions.rs:69:41 [INFO] [stderr] | [INFO] [stderr] 69 | ($target: expr_2021, $flag: expr_2021, $value: expr_2021) => [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/nes/instructions.rs:77:3 [INFO] [stderr] | [INFO] [stderr] 77 | ($target: expr_2021, $flag: expr_2021) => [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/nes/instructions.rs:77:23 [INFO] [stderr] | [INFO] [stderr] 77 | ($target: expr_2021, $flag: expr_2021) => [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/nes/instructions.rs:85:3 [INFO] [stderr] | [INFO] [stderr] 85 | ($bus: expr_2021, $sp: expr_2021, $val: expr_2021) => [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/nes/instructions.rs:85:20 [INFO] [stderr] | [INFO] [stderr] 85 | ($bus: expr_2021, $sp: expr_2021, $val: expr_2021) => [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/nes/instructions.rs:85:36 [INFO] [stderr] | [INFO] [stderr] 85 | ($bus: expr_2021, $sp: expr_2021, $val: expr_2021) => [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/nes/instructions.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | ($name: ident, $flag: expr_2021, $result: literal) => [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/nes/instructions.rs:130:17 [INFO] [stderr] | [INFO] [stderr] 130 | ($name: ident, $flag: expr_2021, $result: literal) => [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/nes/instructions.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 53 | ($target: expr, $flag: expr) => [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 53 | ($target: expr_2021, $flag: expr) => [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/nes/instructions.rs:53:25 [INFO] [stdout] | [INFO] [stdout] 53 | ($target: expr, $flag: expr) => [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 53 | ($target: expr, $flag: expr_2021) => [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] | [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/nes/instructions.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 61 | ($target: expr, $flag: expr) => [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 61 | ($target: expr_2021, $flag: expr) => [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/nes/instructions.rs:61:25 [INFO] [stdout] | [INFO] [stdout] 61 | ($target: expr, $flag: expr) => [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 61 | ($target: expr, $flag: expr_2021) => [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/nes/instructions.rs:69:12 [INFO] [stdout] | [INFO] [stdout] 69 | ($target: expr, $flag: expr, $value: expr) => [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 69 | ($target: expr_2021, $flag: expr, $value: expr) => [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/nes/instructions.rs:69:25 [INFO] [stdout] | [INFO] [stdout] 69 | ($target: expr, $flag: expr, $value: expr) => [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 69 | ($target: expr, $flag: expr_2021, $value: expr) => [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/nes/instructions.rs:69:39 [INFO] [stdout] | [INFO] [stdout] 69 | ($target: expr, $flag: expr, $value: expr) => [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 69 | ($target: expr, $flag: expr, $value: expr_2021) => [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: unused variable: `val` [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/nes/instructions.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 77 | ($target: expr, $flag: expr) => [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 77 | ($target: expr_2021, $flag: expr) => [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] --> src/nes/ppu.rs:27:44 [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/nes/instructions.rs:77:25 [INFO] [stdout] | [INFO] [stdout] 77 | ($target: expr, $flag: expr) => [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 77 | ($target: expr, $flag: expr_2021) => [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] | [INFO] [stderr] 27 | pub fn set_regsiter(&mut self, addr: u16, val: u8) [INFO] [stderr] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bus` [INFO] [stderr] --> src/nes/instructions.rs:546:7 [INFO] [stderr] | [INFO] [stderr] 546 | let bus = self.bus.upgrade().unwrap(); [INFO] [stderr] | ^^^ help: if this is intentional, prefix it with an underscore: `_bus` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/nes/cartridge.rs:56:30 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn write_prg(&mut self, addr: u16, val: u8) [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `val` [INFO] [stderr] --> src/nes/cartridge.rs:56:41 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn write_prg(&mut self, addr: u16, val: u8) [INFO] [stderr] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stderr] [INFO] [stderr] error: aborting due to 14 previous errors; 4 warnings emitted [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/nes/instructions.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | ($bus: expr, $sp: expr, $val: expr) => [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 85 | ($bus: expr_2021, $sp: expr, $val: expr) => [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/nes/instructions.rs:85:20 [INFO] [stdout] | [INFO] [stdout] 85 | ($bus: expr, $sp: expr, $val: expr) => [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 85 | ($bus: expr, $sp: expr_2021, $val: expr) => [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/nes/instructions.rs:85:32 [INFO] [stdout] | [INFO] [stdout] 85 | ($bus: expr, $sp: expr, $val: expr) => [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 85 | ($bus: expr, $sp: expr, $val: expr_2021) => [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/nes/instructions.rs:116:24 [INFO] [stdout] | [INFO] [stdout] 116 | ($name: ident, $flag: expr, $result: literal) => [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 116 | ($name: ident, $flag: expr_2021, $result: literal) => [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/nes/instructions.rs:130:24 [INFO] [stdout] | [INFO] [stdout] 130 | ($name: ident, $flag: expr, $result: literal) => [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 130 | ($name: ident, $flag: expr_2021, $result: literal) => [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/renderer/context.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | extern "C" [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | _help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | | [INFO] [stdout] 4 | | { [INFO] [stdout] 5 | | #[allow(improper_ctypes)] [INFO] [stdout] 6 | | pub fn init_opengl( [INFO] [stdout] ... | [INFO] [stdout] 11 | | pub fn clear(); [INFO] [stdout] 12 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] = note: `--force-warn missing-unsafe-on-extern` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/nes/ppu.rs:27:44 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn set_regsiter(&mut self, addr: u16, val: u8) [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `bus` [INFO] [stdout] --> src/nes/instructions.rs:546:7 [INFO] [stdout] | [INFO] [stdout] 546 | let bus = self.bus.upgrade().unwrap(); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_bus` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr` [INFO] [stdout] --> src/nes/cartridge.rs:56:30 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn write_prg(&mut self, addr: u16, val: u8) [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/nes/cartridge.rs:56:41 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn write_prg(&mut self, addr: u16, val: u8) [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `bus` is never read [INFO] [stdout] --> src/nes/nes.rs:9:2 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct NES [INFO] [stdout] | --- field in this struct [INFO] [stdout] 8 | { [INFO] [stdout] 9 | bus: Rc>, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `clock` and `single_step` are never used [INFO] [stdout] --> src/nes/nes.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 31 | impl NES [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 55 | pub fn clock(&self) [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 63 | pub fn single_step(&self) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `sync` is never used [INFO] [stdout] --> src/nes/cpu.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 33 | impl CPU [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 90 | pub fn sync(&self) -> bool [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `bus` is never read [INFO] [stdout] --> src/nes/ppu.rs:11:2 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct PPU [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 11 | bus: Weak> [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `cli` and `brk` are never used [INFO] [stdout] --> src/nes/instructions.rs:357:15 [INFO] [stdout] | [INFO] [stdout] 313 | impl CPU [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 357 | set_flag_fn!(cli, Bit::Interrupt, false); [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 544 | fn brk(&mut self) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `set_flag_fn` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 24 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.65s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Compiling rusty-nes v0.1.0 (/tmp/fixit) [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/renderer/context.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / extern "C" [INFO] [stdout] 4 | | { [INFO] [stdout] 5 | | #[allow(improper_ctypes)] [INFO] [stdout] 6 | | pub fn init_opengl( [INFO] [stdout] ... | [INFO] [stdout] 11 | | pub fn clear(); [INFO] [stdout] 12 | | } [INFO] [stdout] | |_^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/renderer/context.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / extern "C" [INFO] [stdout] 4 | | { [INFO] [stdout] 5 | | #[allow(improper_ctypes)] [INFO] [stdout] 6 | | pub fn init_opengl( [INFO] [stdout] ... | [INFO] [stdout] 11 | | pub fn clear(); [INFO] [stdout] 12 | | } [INFO] [stdout] | |_^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/nes/ppu.rs:27:44 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn set_regsiter(&mut self, addr: u16, val: u8) [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/nes/ppu.rs:27:44 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn set_regsiter(&mut self, addr: u16, val: u8) [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `bus` [INFO] [stdout] --> src/nes/instructions.rs:546:7 [INFO] [stdout] | [INFO] [stdout] 546 | let bus = self.bus.upgrade().unwrap(); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_bus` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `bus` [INFO] [stdout] --> src/nes/instructions.rs:546:7 [INFO] [stdout] | [INFO] [stdout] 546 | let bus = self.bus.upgrade().unwrap(); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_bus` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr` [INFO] [stdout] --> src/nes/cartridge.rs:56:30 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn write_prg(&mut self, addr: u16, val: u8) [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/nes/cartridge.rs:56:41 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn write_prg(&mut self, addr: u16, val: u8) [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr` [INFO] [stdout] --> src/nes/cartridge.rs:56:30 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn write_prg(&mut self, addr: u16, val: u8) [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/nes/cartridge.rs:56:41 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn write_prg(&mut self, addr: u16, val: u8) [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rusty-nes` (bin "rusty-nes") due to 2 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `rusty-nes` (bin "rusty-nes" test) due to 2 previous errors; 4 warnings emitted [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "a55ec5911d47a2030b1881dc496234a5a87a4cba5060724a741ed3c2be63d617", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a55ec5911d47a2030b1881dc496234a5a87a4cba5060724a741ed3c2be63d617", kill_on_drop: false }` [INFO] [stdout] a55ec5911d47a2030b1881dc496234a5a87a4cba5060724a741ed3c2be63d617