[INFO] cloning repository https://github.com/HansBlackCat/ritcoin [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/HansBlackCat/ritcoin" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHansBlackCat%2Fritcoin", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHansBlackCat%2Fritcoin'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8d3d12c1ff9f9d1c06b47236f3b1fcece41bad1d [INFO] checking HansBlackCat/ritcoin/8d3d12c1ff9f9d1c06b47236f3b1fcece41bad1d against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHansBlackCat%2Fritcoin" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/HansBlackCat/ritcoin on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/HansBlackCat/ritcoin [INFO] finished tweaking git repo https://github.com/HansBlackCat/ritcoin [INFO] tweaked toml for git repo https://github.com/HansBlackCat/ritcoin written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/HansBlackCat/ritcoin already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ddb1b0825eb0f09ea9acff0049fc7426ad056803e3a9b84365a2115af0c307fa [INFO] running `Command { std: "docker" "start" "-a" "ddb1b0825eb0f09ea9acff0049fc7426ad056803e3a9b84365a2115af0c307fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ddb1b0825eb0f09ea9acff0049fc7426ad056803e3a9b84365a2115af0c307fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ddb1b0825eb0f09ea9acff0049fc7426ad056803e3a9b84365a2115af0c307fa", kill_on_drop: false }` [INFO] [stdout] ddb1b0825eb0f09ea9acff0049fc7426ad056803e3a9b84365a2115af0c307fa [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6283d1c2942d7763adf7c004c9e3f91adb2ca0b4facc98fd3bf70370bc58955a [INFO] running `Command { std: "docker" "start" "-a" "6283d1c2942d7763adf7c004c9e3f91adb2ca0b4facc98fd3bf70370bc58955a", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling libc v0.2.139 [INFO] [stderr] Compiling typenum v1.16.0 [INFO] [stderr] Compiling io-lifetimes v1.0.4 [INFO] [stderr] Compiling rustix v0.36.7 [INFO] [stderr] Compiling libm v0.2.6 [INFO] [stderr] Checking linux-raw-sys v0.1.4 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling serde v1.0.152 [INFO] [stderr] Compiling num-bigint-dig v0.8.2 [INFO] [stderr] Checking regex-syntax v0.6.28 [INFO] [stderr] Compiling generic-array v0.14.6 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling num-iter v0.1.43 [INFO] [stderr] Compiling anyhow v1.0.68 [INFO] [stderr] Checking aho-corasick v0.7.20 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking smallvec v1.10.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking termcolor v1.2.0 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking cpufeatures v0.2.5 [INFO] [stderr] Checking regex v1.7.1 [INFO] [stderr] Checking getrandom v0.2.8 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking block-buffer v0.10.3 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking digest v0.10.6 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking sha2 v0.10.6 [INFO] [stderr] Checking ripemd v0.1.3 [INFO] [stderr] Checking is-terminal v0.4.2 [INFO] [stderr] Checking env_logger v0.10.0 [INFO] [stderr] Checking ritcoin v0.1.0 (/tmp/fixit) [INFO] [stderr] Migrating src/main.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `ritcoin` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/libs/ecc.rs [INFO] [stderr] * src/libs/key.rs [INFO] [stderr] * src/libs/macros.rs [INFO] [stderr] * src/libs/transaction.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/libs/macros.rs:90:6 [INFO] [stderr] | [INFO] [stderr] 90 | ($e:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] warning: unused import: `ToBigUint` [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/libs/ecc.rs:550:13 [INFO] [stdout] | [INFO] [stdout] 550 | let gen = EccPoint::new_secp256k1( [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] --> src/libs/ecc.rs:4:61 [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/libs/ecc.rs:555:47 [INFO] [stdout] | [INFO] [stdout] 555 | (*SECP256K1GENS_ORDER).clone() * &gen, [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] | [INFO] [stdout] warning: unused import: `crate::libs::ecc::Ecc` [INFO] [stdout] --> src/libs/key.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::libs::ecc::Ecc; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] 4 | use num_bigint_dig::{BigInt, BigUint, ModInverse, ToBigInt, ToBigUint}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `n` [INFO] [stderr] --> src/libs/transaction.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | let n: i64 = -1; [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_n` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/libs/macros.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | ($e:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 90 | ($e:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: unused variable: `array` [INFO] [stdout] warning: unused import: `base58_encode` [INFO] [stdout] --> src/libs/ecc.rs:14:17 [INFO] [stdout] | [INFO] [stdout] 14 | signature::{base58_encode, base58_encode_with_checksum, Signature}, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] --> src/libs/transaction.rs:123:13 [INFO] [stdout] warning: unused import: `std::fmt::format` [INFO] [stdout] --> src/libs/ecc.rs:369:9 [INFO] [stdout] | [INFO] [stdout] 369 | use std::fmt::format; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] | [INFO] [stdout] warning: unused import: `Ecc` [INFO] [stdout] --> src/libs/ecc.rs:376:17 [INFO] [stdout] | [INFO] [stdout] 376 | use super::{Ecc, EccPoint, SECP256K1GENS_ORDER, SECP256K1GENS_X, SECP256K1GENS_Y}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] 123 | let array = Self::parse_nbytes::<4>(&mut stream); [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_array` [INFO] [stderr] [INFO] [stdout] warning: unused import: `ModInverse` [INFO] [stdout] --> src/libs/finite_field.rs:97:34 [INFO] [stdout] | [INFO] [stdout] 97 | use num_bigint_dig::{BigInt, ModInverse}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: unused variable: `z` [INFO] [stdout] warning: unused import: `One` [INFO] [stdout] --> src/libs/finite_field.rs:98:22 [INFO] [stdout] | [INFO] [stdout] 98 | use num_traits::{One, Pow}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] --> src/libs/key.rs:24:23 [INFO] [stdout] warning: unused import: `ToBigUint` [INFO] [stdout] --> src/libs/ecc.rs:4:61 [INFO] [stdout] | [INFO] [stdout] 4 | use num_bigint_dig::{BigInt, BigUint, ModInverse, ToBigInt, ToBigUint}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] | [INFO] [stdout] warning: unused variable: `n` [INFO] [stdout] --> src/libs/transaction.rs:120:17 [INFO] [stdout] | [INFO] [stdout] 120 | let mut n: i64 = -1; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_n` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] 24 | fn rfc6979(&self, z: BigUint) -> BigUint { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_z` [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: unused variable: `array` [INFO] [stdout] --> src/libs/transaction.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | let array = Self::parse_nbytes::<4>(&mut stream); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_array` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/libs/transaction.rs:120:13 [INFO] [stdout] | [INFO] [stdout] 120 | let mut n: i64 = -1; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `z` [INFO] [stdout] --> src/libs/key.rs:25:23 [INFO] [stdout] | [INFO] [stdout] 25 | fn rfc6979(&self, z: BigUint) -> BigUint { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_z` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `locktime_type` is never read [INFO] [stdout] --> src/libs/transaction.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 48 | pub struct TransactionLocktime { [INFO] [stdout] | ------------------- field in this struct [INFO] [stdout] 49 | locktime: [u8; 4], [INFO] [stdout] 50 | locktime_type: TransactionLocktimeType, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TransactionLocktime` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `previous_tx_id`, `previous_tx_idx`, `script_signature`, and `sequence` are never read [INFO] [stdout] --> src/libs/transaction.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 77 | pub struct TransactionInput { [INFO] [stdout] | ---------------- fields in this struct [INFO] [stdout] 78 | previous_tx_id: [u8; 32], [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 79 | previous_tx_idx: [u8; 4], [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 80 | script_signature: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 81 | sequence: [u8; 4], [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TransactionInput` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `amount` and `script_pubkey` are never read [INFO] [stdout] --> src/libs/transaction.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 101 | pub struct TransactionOutput { [INFO] [stdout] | ----------------- fields in this struct [INFO] [stdout] 102 | amount: Vec, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 103 | script_pubkey: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TransactionOutput` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `version`, `transaction_inputs_varint`, `transaction_inputs`, `transaction_outputs_varint`, `transaction_outputs`, and `locktime` are never read [INFO] [stdout] --> src/libs/transaction.rs:108:5 [INFO] [stdout] | [INFO] [stdout] 107 | pub struct Transaction { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 108 | version: TransactionVersion, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 109 | transaction_inputs_varint: Varint, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 110 | transaction_inputs: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 111 | transaction_outputs_varint: Varint, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 112 | transaction_outputs: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 113 | locktime: TransactionLocktime, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Transaction` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/libs/transaction.rs:146:19 [INFO] [stdout] | [INFO] [stdout] 146 | pub struct Varint(Vec); [INFO] [stdout] | ------ ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `Varint` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `magic` is never read [INFO] [stdout] --> src/libs/network.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct NetworkMagic { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 17 | magic: [u8; 4], [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `command` is never read [INFO] [stdout] --> src/libs/network.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 20 | pub struct NetworkCommand { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 21 | command: [u8; 12], [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `payload_length`, `payload_checksum`, and `payload` are never read [INFO] [stdout] --> src/libs/network.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 24 | pub struct NetworkPayload { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] 25 | payload_length: [u8; 4], [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 26 | payload_checksum: [u8; 4], [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 27 | payload: Vec, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `rfc6979` is never used [INFO] [stdout] --> src/libs/key.rs:25:8 [INFO] [stdout] | [INFO] [stdout] 19 | impl Key { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 25 | fn rfc6979(&self, z: BigUint) -> BigUint { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `verify` is never used [INFO] [stdout] --> src/libs/ecc.rs:128:8 [INFO] [stdout] | [INFO] [stdout] 107 | impl EccPoint { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 128 | fn verify() { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/libs/ecc.rs:301:16 [INFO] [stdout] | [INFO] [stdout] 301 | if let EccPoint::Point(ecc) = r.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^--------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/libs/ecc.rs:307:13 [INFO] [stdout] | [INFO] [stdout] 307 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 301 ~ match r.clone() { EccPoint::Point(ecc) => { [INFO] [stdout] 302 | if let Some(order) = &ecc.order { [INFO] [stdout] ... [INFO] [stdout] 306 | } [INFO] [stdout] 307 ~ } _ => { [INFO] [stdout] 308 | coef = l.clone(); [INFO] [stdout] 309 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/libs/ecc.rs:302:20 [INFO] [stdout] | [INFO] [stdout] 302 | if let Some(order) = &ecc.order { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^--------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/libs/ecc.rs:304:17 [INFO] [stdout] | [INFO] [stdout] 304 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 302 ~ match &ecc.order { Some(order) => { [INFO] [stdout] 303 | coef = l.clone() % order; [INFO] [stdout] 304 ~ } _ => { [INFO] [stdout] 305 | coef = l.clone(); [INFO] [stdout] 306 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/libs/ecc.rs:339:16 [INFO] [stdout] | [INFO] [stdout] 339 | if let EccPoint::Point(ecc) = r.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^--------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/libs/ecc.rs:345:13 [INFO] [stdout] | [INFO] [stdout] 345 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 339 ~ match r.clone() { EccPoint::Point(ecc) => { [INFO] [stdout] 340 | if let Some(order) = &ecc.order { [INFO] [stdout] ... [INFO] [stdout] 344 | } [INFO] [stdout] 345 ~ } _ => { [INFO] [stdout] 346 | coef = l.clone(); [INFO] [stdout] 347 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/libs/ecc.rs:340:20 [INFO] [stdout] | [INFO] [stdout] 340 | if let Some(order) = &ecc.order { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^--------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/libs/ecc.rs:342:17 [INFO] [stdout] | [INFO] [stdout] 342 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 340 ~ match &ecc.order { Some(order) => { [INFO] [stdout] 341 | coef = l.clone() % order; [INFO] [stdout] 342 ~ } _ => { [INFO] [stdout] 343 | coef = l.clone(); [INFO] [stdout] 344 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/libs/ecc.rs:600:12 [INFO] [stdout] | [INFO] [stdout] 600 | if let EccPoint::Point(lhs) = u * gen_point + v * point { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/libs/ecc.rs:602:9 [INFO] [stdout] | [INFO] [stdout] 602 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 600 ~ match u * gen_point + v * point { EccPoint::Point(lhs) => { [INFO] [stdout] 601 | assert_eq!(lhs.x.num, r.to_bigint().unwrap()); [INFO] [stdout] 602 ~ } _ => { [INFO] [stdout] 603 | panic!("POA"); [INFO] [stdout] 604 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 29 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `ritcoin` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/libs/ecc.rs [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/libs/ecc.rs:550:13 [INFO] [stdout] | [INFO] [stdout] 550 | let gen = EccPoint::new_secp256k1( [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] * src/libs/key.rs [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/libs/ecc.rs:555:47 [INFO] [stdout] | [INFO] [stdout] 555 | (*SECP256K1GENS_ORDER).clone() * &gen, [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] * src/libs/macros.rs [INFO] [stderr] * src/libs/transaction.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stdout] warning: unused import: `crate::libs::ecc::Ecc` [INFO] [stdout] --> src/libs/key.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::libs::ecc::Ecc; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/libs/macros.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | ($e:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 90 | ($e:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stdout] warning: unused import: `base58_encode` [INFO] [stdout] --> src/libs/ecc.rs:14:17 [INFO] [stdout] | [INFO] [stdout] 14 | signature::{base58_encode, base58_encode_with_checksum, Signature}, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stdout] warning: unused import: `ToBigUint` [INFO] [stdout] --> src/libs/ecc.rs:4:61 [INFO] [stdout] | [INFO] [stdout] 4 | use num_bigint_dig::{BigInt, BigUint, ModInverse, ToBigInt, ToBigUint}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stdout] warning: unused variable: `n` [INFO] [stdout] --> src/libs/transaction.rs:120:17 [INFO] [stdout] | [INFO] [stdout] 120 | let mut n: i64 = -1; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_n` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stdout] warning: unused variable: `array` [INFO] [stdout] --> src/libs/transaction.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | let array = Self::parse_nbytes::<4>(&mut stream); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_array` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/libs/macros.rs:90:6 [INFO] [stderr] | [INFO] [stderr] 90 | ($e:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/libs/transaction.rs:120:13 [INFO] [stdout] | [INFO] [stdout] 120 | let mut n: i64 = -1; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stdout] warning: unused variable: `z` [INFO] [stdout] --> src/libs/key.rs:25:23 [INFO] [stdout] | [INFO] [stdout] 25 | fn rfc6979(&self, z: BigUint) -> BigUint { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_z` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stdout] warning: field `locktime_type` is never read [INFO] [stdout] --> src/libs/transaction.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 48 | pub struct TransactionLocktime { [INFO] [stdout] | ------------------- field in this struct [INFO] [stdout] 49 | locktime: [u8; 4], [INFO] [stdout] 50 | locktime_type: TransactionLocktimeType, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TransactionLocktime` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stdout] warning: fields `previous_tx_id`, `previous_tx_idx`, `script_signature`, and `sequence` are never read [INFO] [stdout] --> src/libs/transaction.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 77 | pub struct TransactionInput { [INFO] [stdout] | ---------------- fields in this struct [INFO] [stdout] 78 | previous_tx_id: [u8; 32], [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 79 | previous_tx_idx: [u8; 4], [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 80 | script_signature: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 81 | sequence: [u8; 4], [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TransactionInput` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stdout] warning: fields `amount` and `script_pubkey` are never read [INFO] [stdout] --> src/libs/transaction.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 101 | pub struct TransactionOutput { [INFO] [stdout] | ----------------- fields in this struct [INFO] [stdout] 102 | amount: Vec, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 103 | script_pubkey: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TransactionOutput` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: unused import: `ToBigUint` [INFO] [stdout] warning: fields `version`, `transaction_inputs_varint`, `transaction_inputs`, `transaction_outputs_varint`, `transaction_outputs`, and `locktime` are never read [INFO] [stdout] --> src/libs/transaction.rs:108:5 [INFO] [stdout] | [INFO] [stdout] 107 | pub struct Transaction { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 108 | version: TransactionVersion, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 109 | transaction_inputs_varint: Varint, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 110 | transaction_inputs: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 111 | transaction_outputs_varint: Varint, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 112 | transaction_outputs: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 113 | locktime: TransactionLocktime, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Transaction` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] --> src/libs/ecc.rs:4:61 [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/libs/transaction.rs:146:19 [INFO] [stdout] | [INFO] [stdout] 146 | pub struct Varint(Vec); [INFO] [stdout] | ------ ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `Varint` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] | [INFO] [stdout] warning: field `magic` is never read [INFO] [stdout] --> src/libs/network.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct NetworkMagic { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 17 | magic: [u8; 4], [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] 4 | use num_bigint_dig::{BigInt, BigUint, ModInverse, ToBigInt, ToBigUint}; [INFO] [stdout] warning: field `command` is never read [INFO] [stdout] --> src/libs/network.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 20 | pub struct NetworkCommand { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 21 | command: [u8; 12], [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stdout] warning: fields `payload_length`, `payload_checksum`, and `payload` are never read [INFO] [stdout] --> src/libs/network.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 24 | pub struct NetworkPayload { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] 25 | payload_length: [u8; 4], [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 26 | payload_checksum: [u8; 4], [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 27 | payload: Vec, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] | [INFO] [stdout] warning: method `rfc6979` is never used [INFO] [stdout] --> src/libs/key.rs:25:8 [INFO] [stdout] | [INFO] [stdout] 19 | impl Key { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 25 | fn rfc6979(&self, z: BigUint) -> BigUint { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] warning: associated function `verify` is never used [INFO] [stdout] --> src/libs/ecc.rs:128:8 [INFO] [stdout] | [INFO] [stdout] 107 | impl EccPoint { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 128 | fn verify() { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stderr] warning: unused variable: `n` [INFO] [stderr] --> src/libs/transaction.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | let n: i64 = -1; [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_n` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `array` [INFO] [stderr] --> src/libs/transaction.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | let array = Self::parse_nbytes::<4>(&mut stream); [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_array` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `z` [INFO] [stderr] --> src/libs/key.rs:24:23 [INFO] [stderr] | [INFO] [stderr] 24 | fn rfc6979(&self, z: BigUint) -> BigUint { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_z` [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/libs/ecc.rs:301:16 [INFO] [stdout] | [INFO] [stdout] 301 | if let EccPoint::Point(ecc) = r.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^--------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/libs/ecc.rs:307:13 [INFO] [stdout] | [INFO] [stdout] 307 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 301 ~ match r.clone() { EccPoint::Point(ecc) => { [INFO] [stdout] 302 | if let Some(order) = &ecc.order { [INFO] [stdout] ... [INFO] [stdout] 306 | } [INFO] [stdout] 307 ~ } _ => { [INFO] [stdout] 308 | coef = l.clone(); [INFO] [stdout] 309 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/libs/ecc.rs:302:20 [INFO] [stdout] | [INFO] [stdout] 302 | if let Some(order) = &ecc.order { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^--------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/libs/ecc.rs:304:17 [INFO] [stdout] | [INFO] [stdout] 304 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 302 ~ match &ecc.order { Some(order) => { [INFO] [stdout] 303 | coef = l.clone() % order; [INFO] [stdout] 304 ~ } _ => { [INFO] [stdout] 305 | coef = l.clone(); [INFO] [stdout] 306 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/libs/ecc.rs:339:16 [INFO] [stdout] | [INFO] [stdout] 339 | if let EccPoint::Point(ecc) = r.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^--------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/libs/ecc.rs:345:13 [INFO] [stdout] | [INFO] [stdout] 345 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 339 ~ match r.clone() { EccPoint::Point(ecc) => { [INFO] [stdout] 340 | if let Some(order) = &ecc.order { [INFO] [stdout] ... [INFO] [stdout] 344 | } [INFO] [stdout] 345 ~ } _ => { [INFO] [stdout] 346 | coef = l.clone(); [INFO] [stdout] 347 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/libs/ecc.rs:340:20 [INFO] [stdout] | [INFO] [stdout] 340 | if let Some(order) = &ecc.order { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^--------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/libs/ecc.rs:342:17 [INFO] [stdout] | [INFO] [stdout] 342 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 340 ~ match &ecc.order { Some(order) => { [INFO] [stdout] 341 | coef = l.clone() % order; [INFO] [stdout] 342 ~ } _ => { [INFO] [stdout] 343 | coef = l.clone(); [INFO] [stdout] 344 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 24 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.30s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking ritcoin v0.1.0 (/tmp/fixit) [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/libs/ecc.rs:550:13 [INFO] [stdout] | [INFO] [stdout] 550 | let gen = EccPoint::new_secp256k1( [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 550 | let r#gen = EccPoint::new_secp256k1( [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/libs/ecc.rs:550:13 [INFO] [stdout] | [INFO] [stdout] 550 | let gen = EccPoint::new_secp256k1( [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 550 | let r#gen = EccPoint::new_secp256k1( [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected expression, found reserved keyword `gen` [INFO] [stdout] --> src/libs/ecc.rs:555:47 [INFO] [stdout] | [INFO] [stdout] 555 | (*SECP256K1GENS_ORDER).clone() * &gen, [INFO] [stdout] | ^^^ expected expression [INFO] [stdout] --> /rustc/ccf408f4326a858c00dd845a64a86b16f360a801/library/core/src/macros/mod.rs:43:6 [INFO] [stdout] | [INFO] [stdout] = note: while parsing argument for this `expr` macro fragment [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::libs::ecc::Ecc` [INFO] [stdout] --> src/libs/key.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::libs::ecc::Ecc; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `base58_encode` [INFO] [stdout] --> src/libs/ecc.rs:14:17 [INFO] [stdout] | [INFO] [stdout] 14 | signature::{base58_encode, base58_encode_with_checksum, Signature}, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::libs::ecc::Ecc` [INFO] [stdout] --> src/libs/key.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::libs::ecc::Ecc; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `base58_encode` [INFO] [stdout] --> src/libs/ecc.rs:14:17 [INFO] [stdout] | [INFO] [stdout] 14 | signature::{base58_encode, base58_encode_with_checksum, Signature}, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::format` [INFO] [stdout] --> src/libs/ecc.rs:369:9 [INFO] [stdout] | [INFO] [stdout] 369 | use std::fmt::format; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Ecc` [INFO] [stdout] --> src/libs/ecc.rs:376:17 [INFO] [stdout] | [INFO] [stdout] 376 | use super::{Ecc, EccPoint, SECP256K1GENS_ORDER, SECP256K1GENS_X, SECP256K1GENS_Y}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ModInverse` [INFO] [stdout] --> src/libs/finite_field.rs:97:34 [INFO] [stdout] | [INFO] [stdout] 97 | use num_bigint_dig::{BigInt, ModInverse}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `One` [INFO] [stdout] --> src/libs/finite_field.rs:98:22 [INFO] [stdout] | [INFO] [stdout] 98 | use num_traits::{One, Pow}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ToBigUint` [INFO] [stdout] --> src/libs/ecc.rs:4:61 [INFO] [stdout] | [INFO] [stdout] 4 | use num_bigint_dig::{BigInt, BigUint, ModInverse, ToBigInt, ToBigUint}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `n` [INFO] [stdout] --> src/libs/transaction.rs:120:17 [INFO] [stdout] | [INFO] [stdout] 120 | let mut n: i64 = -1; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_n` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `array` [INFO] [stdout] --> src/libs/transaction.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | let array = Self::parse_nbytes::<4>(&mut stream); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_array` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/libs/transaction.rs:120:13 [INFO] [stdout] | [INFO] [stdout] 120 | let mut n: i64 = -1; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `z` [INFO] [stdout] --> src/libs/key.rs:25:23 [INFO] [stdout] | [INFO] [stdout] 25 | fn rfc6979(&self, z: BigUint) -> BigUint { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_z` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ToBigUint` [INFO] [stdout] --> src/libs/ecc.rs:4:61 [INFO] [stdout] | [INFO] [stdout] 4 | use num_bigint_dig::{BigInt, BigUint, ModInverse, ToBigInt, ToBigUint}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `n` [INFO] [stdout] --> src/libs/transaction.rs:120:17 [INFO] [stdout] | [INFO] [stdout] 120 | let mut n: i64 = -1; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_n` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `array` [INFO] [stdout] --> src/libs/transaction.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | let array = Self::parse_nbytes::<4>(&mut stream); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_array` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/libs/transaction.rs:120:13 [INFO] [stdout] | [INFO] [stdout] 120 | let mut n: i64 = -1; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `z` [INFO] [stdout] --> src/libs/key.rs:25:23 [INFO] [stdout] | [INFO] [stdout] 25 | fn rfc6979(&self, z: BigUint) -> BigUint { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_z` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ritcoin` (bin "ritcoin") due to 2 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 2 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ritcoin` (bin "ritcoin" test) due to 3 previous errors; 11 warnings emitted [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "6283d1c2942d7763adf7c004c9e3f91adb2ca0b4facc98fd3bf70370bc58955a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6283d1c2942d7763adf7c004c9e3f91adb2ca0b4facc98fd3bf70370bc58955a", kill_on_drop: false }` [INFO] [stdout] 6283d1c2942d7763adf7c004c9e3f91adb2ca0b4facc98fd3bf70370bc58955a