[INFO] cloning repository https://github.com/DatAsianBoi123/scoreboard [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/DatAsianBoi123/scoreboard" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDatAsianBoi123%2Fscoreboard", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDatAsianBoi123%2Fscoreboard'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9b4cf660206761b2910c405d057e2264305913e1 [INFO] checking DatAsianBoi123/scoreboard/9b4cf660206761b2910c405d057e2264305913e1 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDatAsianBoi123%2Fscoreboard" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/DatAsianBoi123/scoreboard on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/DatAsianBoi123/scoreboard [INFO] finished tweaking git repo https://github.com/DatAsianBoi123/scoreboard [INFO] tweaked toml for git repo https://github.com/DatAsianBoi123/scoreboard written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/DatAsianBoi123/scoreboard already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fa29da3a85a258b663e68732e196fd20a780311a4708ddcc687df8ba60385b87 [INFO] running `Command { std: "docker" "start" "-a" "fa29da3a85a258b663e68732e196fd20a780311a4708ddcc687df8ba60385b87", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fa29da3a85a258b663e68732e196fd20a780311a4708ddcc687df8ba60385b87", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fa29da3a85a258b663e68732e196fd20a780311a4708ddcc687df8ba60385b87", kill_on_drop: false }` [INFO] [stdout] fa29da3a85a258b663e68732e196fd20a780311a4708ddcc687df8ba60385b87 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4945e04b408ca23809f980909be173b44f9707acb6fa643c3423eafd73ae05ac [INFO] running `Command { std: "docker" "start" "-a" "4945e04b408ca23809f980909be173b44f9707acb6fa643c3423eafd73ae05ac", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Compiling rustversion v1.0.14 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling syn v2.0.55 [INFO] [stderr] Compiling anyhow v1.0.81 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Compiling serde_json v1.0.115 [INFO] [stderr] Checking urlencoding v2.1.3 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Compiling either v1.10.0 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Compiling itertools v0.11.0 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Compiling semver v1.0.22 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking matchit v0.7.3 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking strum v0.24.1 [INFO] [stderr] Checking crossbeam-channel v0.5.12 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking strfmt v0.2.4 [INFO] [stderr] Checking sync_wrapper v1.0.0 [INFO] [stderr] Compiling axum-core v0.3.4 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Compiling axum v0.6.20 [INFO] [stderr] Compiling axum-core v0.4.3 [INFO] [stderr] Compiling axum v0.7.5 [INFO] [stderr] Checking http-range-header v0.4.0 [INFO] [stderr] Compiling mime_guess v2.0.4 [INFO] [stderr] Checking http-body-util v0.1.1 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking ordered-float v4.2.0 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking crossterm v0.26.1 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling strum_macros v0.24.3 [INFO] [stderr] Checking comfy-table v6.2.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling async-trait v0.1.79 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling prost-derive v0.12.3 [INFO] [stderr] Compiling strum_macros v0.26.2 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Compiling shuttle-codegen v0.44.0 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking thiserror v1.0.58 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking opentelemetry v0.21.0 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking strum v0.26.2 [INFO] [stderr] Checking prost v0.12.3 [INFO] [stderr] Checking opentelemetry-http v0.10.0 [INFO] [stderr] Checking prost-types v0.12.3 [INFO] [stderr] Checking serde v1.0.197 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking opentelemetry_sdk v0.21.2 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking tokio-io-timeout v1.2.0 [INFO] [stderr] Checking hyper v1.2.0 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking tracing-serde v0.1.3 [INFO] [stderr] Checking uuid v1.8.0 [INFO] [stderr] Checking chrono v0.4.37 [INFO] [stderr] Checking serde_path_to_error v0.1.16 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking h2 v0.3.25 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking tower-http v0.5.2 [INFO] [stderr] Checking hyper-util v0.1.3 [INFO] [stderr] Checking tungstenite v0.21.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking tokio-tungstenite v0.21.0 [INFO] [stderr] Checking tracing-opentelemetry v0.22.0 [INFO] [stderr] Checking shuttle-common v0.44.0 [INFO] [stderr] Checking shuttle-service v0.44.0 [INFO] [stderr] Checking hyper v0.14.28 [INFO] [stderr] Checking hyper-timeout v0.4.1 [INFO] [stderr] Checking tonic v0.10.2 [INFO] [stderr] Checking shuttle-proto v0.44.0 [INFO] [stderr] Checking shuttle-runtime v0.44.0 [INFO] [stderr] Checking shuttle-axum v0.44.0 [INFO] [stderr] Checking scoreboard5071 v0.1.0 (/tmp/fixit) [INFO] [stderr] Migrating src/main.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `scoreboard5071` [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/host.rs:12:35 [INFO] [stdout] | [INFO] [stdout] 12 | let session_id = thread_rng().gen(); [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/game.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/game.rs:132:34 [INFO] [stderr] | [INFO] [stderr] 132 | ($($n: literal : { duration: $d: expr_2021, data: { $($c: literal : { $($s: literal : $p: literal),+ $(,)? }),* $(,)? } $(,)? }),* $(... [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/game.rs:132:38 [INFO] [stdout] | [INFO] [stdout] 132 | ($($n: literal : { duration: $d: expr, data: { $($c: literal : { $($s: literal : $p: literal),+ $(,)? }),* $(,)? } $(,)? }),* $(,)?) ... [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 132 | ($($n: literal : { duration: $d: expr_2021, data: { $($c: literal : { $($s: literal : $p: literal),+ $(,)? }),* $(,)? } $(,)? }),* $(,)?) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/host.rs:18:8 [INFO] [stdout] | [INFO] [stdout] 18 | if let Ok(Some(Ok(message))) = timeout(Duration::from_secs(3), async { ws.recv().await }).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/host.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | } else { ws.close().await.expect("can close ws"); }; [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 18 ~ match timeout(Duration::from_secs(3), async { ws.recv().await }).await { Ok(Some(Ok(message))) => { [INFO] [stdout] 19 | if let Some(ServerboundHostPacket::GameData { game_type }) = ServerboundHostPacket::from_message(message) { [INFO] [stdout] ... [INFO] [stdout] 25 | } [INFO] [stdout] 26 ~ } _ => { ws.close().await.expect("can close ws"); }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/host.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 19 | if let Some(ServerboundHostPacket::GameData { game_type }) = ServerboundHostPacket::from_message(message) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/host.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 19 ~ match ServerboundHostPacket::from_message(message) { Some(ServerboundHostPacket::GameData { game_type }) => { [INFO] [stdout] 20 | let game_data = match game_type { [INFO] [stdout] ... [INFO] [stdout] 24 | session_start(ws, session_id, game_data, state).await; [INFO] [stdout] 25 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/host.rs:49:15 [INFO] [stdout] | [INFO] [stdout] 49 | while let Ok(message) = host_recv.recv().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/host.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | }; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/host.rs:82:15 [INFO] [stdout] | [INFO] [stdout] 82 | while let Some(Ok(message)) = receiver.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^--------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/host.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 142 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/host.rs:83:16 [INFO] [stdout] | [INFO] [stdout] 83 | if let Some(packet) = ServerboundHostPacket::from_message(message) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^-------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/host.rs:139:13 [INFO] [stdout] | [INFO] [stdout] 139 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 83 ~ match ServerboundHostPacket::from_message(message) { Some(packet) => { [INFO] [stdout] 84 | info!("[{session_id}] received message: {packet:?}"); [INFO] [stdout] ... [INFO] [stdout] 138 | }; [INFO] [stdout] 139 ~ } _ => { [INFO] [stdout] 140 | break; [INFO] [stdout] 141 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/user.rs:20:59 [INFO] [stdout] | [INFO] [stdout] 20 | let (started, game_data, host_sender, user_recv) = if let Some((started, game_data, host_sender, user_recv)) = res { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^--- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/user.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 20 ~ let (started, game_data, host_sender, user_recv) = match res { Some((started, game_data, host_sender, user_recv)) => { [INFO] [stdout] 21 | (started, game_data, host_sender, user_recv) [INFO] [stdout] 22 ~ } _ => { [INFO] [stdout] 23 | return (StatusCode::BAD_REQUEST, "invalid session id").into_response(); [INFO] [stdout] 24 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/user.rs:49:15 [INFO] [stdout] | [INFO] [stdout] 49 | while let Ok(message) = user_recv.recv().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/user.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/user.rs:65:15 [INFO] [stdout] | [INFO] [stdout] 65 | while let Some(Ok(message)) = recv.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^----------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/user.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/view.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 24 | if let Some((viewer_recv, data, state)) = res { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^--- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/view.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 24 ~ match res { Some((viewer_recv, data, state)) => { [INFO] [stdout] 25 | info!("[{session_id}] viewer connected"); [INFO] [stdout] ... [INFO] [stdout] 36 | Sse::new(stream).keep_alive(KeepAlive::new().interval(Duration::from_secs(15)).text("keep-alive-text")).into_response() [INFO] [stdout] 37 ~ } _ => { [INFO] [stdout] 38 | (StatusCode::BAD_REQUEST, "invalid session id").into_response() [INFO] [stdout] 39 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `scoreboard5071` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/game.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/game.rs:132:34 [INFO] [stderr] | [INFO] [stderr] 132 | ($($n: literal : { duration: $d: expr_2021, data: { $($c: literal : { $($s: literal : $p: literal),+ $(,)? }),* $(,)? } $(,)? }),* $(... [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/host.rs:12:35 [INFO] [stdout] | [INFO] [stdout] 12 | let session_id = thread_rng().gen(); [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/game.rs:132:38 [INFO] [stdout] | [INFO] [stdout] 132 | ($($n: literal : { duration: $d: expr, data: { $($c: literal : { $($s: literal : $p: literal),+ $(,)? }),* $(,)? } $(,)? }),* $(,)?) ... [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 132 | ($($n: literal : { duration: $d: expr_2021, data: { $($c: literal : { $($s: literal : $p: literal),+ $(,)? }),* $(,)? } $(,)? }),* $(,)?) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/host.rs:18:8 [INFO] [stdout] | [INFO] [stdout] 18 | if let Ok(Some(Ok(message))) = timeout(Duration::from_secs(3), async { ws.recv().await }).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/host.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | } else { ws.close().await.expect("can close ws"); }; [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 18 ~ match timeout(Duration::from_secs(3), async { ws.recv().await }).await { Ok(Some(Ok(message))) => { [INFO] [stdout] 19 | if let Some(ServerboundHostPacket::GameData { game_type }) = ServerboundHostPacket::from_message(message) { [INFO] [stdout] ... [INFO] [stdout] 25 | } [INFO] [stdout] 26 ~ } _ => { ws.close().await.expect("can close ws"); }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/host.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 19 | if let Some(ServerboundHostPacket::GameData { game_type }) = ServerboundHostPacket::from_message(message) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/host.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 19 ~ match ServerboundHostPacket::from_message(message) { Some(ServerboundHostPacket::GameData { game_type }) => { [INFO] [stdout] 20 | let game_data = match game_type { [INFO] [stdout] ... [INFO] [stdout] 24 | session_start(ws, session_id, game_data, state).await; [INFO] [stdout] 25 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/host.rs:49:15 [INFO] [stdout] | [INFO] [stdout] 49 | while let Ok(message) = host_recv.recv().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/host.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | }; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/host.rs:82:15 [INFO] [stdout] | [INFO] [stdout] 82 | while let Some(Ok(message)) = receiver.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^--------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/host.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 142 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/host.rs:83:16 [INFO] [stdout] | [INFO] [stdout] 83 | if let Some(packet) = ServerboundHostPacket::from_message(message) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^-------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/host.rs:139:13 [INFO] [stdout] | [INFO] [stdout] 139 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 83 ~ match ServerboundHostPacket::from_message(message) { Some(packet) => { [INFO] [stdout] 84 | info!("[{session_id}] received message: {packet:?}"); [INFO] [stdout] ... [INFO] [stdout] 138 | }; [INFO] [stdout] 139 ~ } _ => { [INFO] [stdout] 140 | break; [INFO] [stdout] 141 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/user.rs:20:59 [INFO] [stdout] | [INFO] [stdout] 20 | let (started, game_data, host_sender, user_recv) = if let Some((started, game_data, host_sender, user_recv)) = res { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^--- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/user.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 20 ~ let (started, game_data, host_sender, user_recv) = match res { Some((started, game_data, host_sender, user_recv)) => { [INFO] [stdout] 21 | (started, game_data, host_sender, user_recv) [INFO] [stdout] 22 ~ } _ => { [INFO] [stdout] 23 | return (StatusCode::BAD_REQUEST, "invalid session id").into_response(); [INFO] [stdout] 24 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/user.rs:49:15 [INFO] [stdout] | [INFO] [stdout] 49 | while let Ok(message) = user_recv.recv().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/user.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/user.rs:65:15 [INFO] [stdout] | [INFO] [stdout] 65 | while let Some(Ok(message)) = recv.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^----------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/user.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/view.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 24 | if let Some((viewer_recv, data, state)) = res { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^--- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/view.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 24 ~ match res { Some((viewer_recv, data, state)) => { [INFO] [stdout] 25 | info!("[{session_id}] viewer connected"); [INFO] [stdout] ... [INFO] [stdout] 36 | Sse::new(stream).keep_alive(KeepAlive::new().interval(Duration::from_secs(15)).text("keep-alive-text")).into_response() [INFO] [stdout] 37 ~ } _ => { [INFO] [stdout] 38 | (StatusCode::BAD_REQUEST, "invalid session id").into_response() [INFO] [stdout] 39 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 22.48s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking scoreboard5071 v0.1.0 (/tmp/fixit) [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/host.rs:12:35 [INFO] [stdout] | [INFO] [stdout] 12 | let session_id = thread_rng().gen(); [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 12 | let session_id = thread_rng().r#gen(); [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/host.rs:12:35 [INFO] [stdout] | [INFO] [stdout] 12 | let session_id = thread_rng().gen(); [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 12 | let session_id = thread_rng().r#gen(); [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `scoreboard5071` (bin "scoreboard5071") due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `scoreboard5071` (bin "scoreboard5071" test) due to 2 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "4945e04b408ca23809f980909be173b44f9707acb6fa643c3423eafd73ae05ac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4945e04b408ca23809f980909be173b44f9707acb6fa643c3423eafd73ae05ac", kill_on_drop: false }` [INFO] [stdout] 4945e04b408ca23809f980909be173b44f9707acb6fa643c3423eafd73ae05ac