[INFO] cloning repository https://github.com/brodiealexander/fjage-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/brodiealexander/fjage-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrodiealexander%2Ffjage-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrodiealexander%2Ffjage-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] cf101aa03af301de2c3eb2574ff533c99f6e24cf [INFO] checking brodiealexander/fjage-rs/cf101aa03af301de2c3eb2574ff533c99f6e24cf against master#f609b7e0586f81fefb3523e3e17adf779ac416be for pr-129466-2 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrodiealexander%2Ffjage-rs" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/brodiealexander/fjage-rs on toolchain f609b7e0586f81fefb3523e3e17adf779ac416be [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f609b7e0586f81fefb3523e3e17adf779ac416be" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/brodiealexander/fjage-rs [INFO] finished tweaking git repo https://github.com/brodiealexander/fjage-rs [INFO] tweaked toml for git repo https://github.com/brodiealexander/fjage-rs written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/brodiealexander/fjage-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f609b7e0586f81fefb3523e3e17adf779ac416be" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tokio-serial v5.4.4 [INFO] [stderr] Downloaded unescaper v0.1.5 [INFO] [stderr] Downloaded uuid-macro-internal v1.9.1 [INFO] [stderr] Downloaded serialport v4.4.0 [INFO] [stderr] Downloaded miniz_oxide v0.7.4 [INFO] [stderr] Downloaded cc v1.0.104 [INFO] [stderr] Downloaded uuid v1.9.1 [INFO] [stderr] Downloaded mio-serial v5.0.5 [INFO] [stderr] Downloaded serde_json v1.0.120 [INFO] [stderr] Downloaded object v0.36.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+f609b7e0586f81fefb3523e3e17adf779ac416be" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d1c55de0a06c479b5471050152f4b8ca88cec3e217f95ec8dab55d4a7bcba56c [INFO] running `Command { std: "docker" "start" "-a" "d1c55de0a06c479b5471050152f4b8ca88cec3e217f95ec8dab55d4a7bcba56c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d1c55de0a06c479b5471050152f4b8ca88cec3e217f95ec8dab55d4a7bcba56c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d1c55de0a06c479b5471050152f4b8ca88cec3e217f95ec8dab55d4a7bcba56c", kill_on_drop: false }` [INFO] [stdout] d1c55de0a06c479b5471050152f4b8ca88cec3e217f95ec8dab55d4a7bcba56c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+f609b7e0586f81fefb3523e3e17adf779ac416be" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e14610832facd1d329e54f21135977e5bfe38f504599bea61c649e3697049dec [INFO] running `Command { std: "docker" "start" "-a" "e14610832facd1d329e54f21135977e5bfe38f504599bea61c649e3697049dec", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling memoffset v0.7.1 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Checking lock_api v0.4.12 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.68 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Compiling uuid-macro-internal v1.9.1 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking thiserror v1.0.61 [INFO] [stderr] Checking unescaper v0.1.5 [INFO] [stderr] Checking serialport v4.4.0 [INFO] [stderr] Checking mio-serial v5.0.5 [INFO] [stderr] Checking serde v1.0.203 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-serial v5.4.4 [INFO] [stderr] Checking uuid v1.9.1 [INFO] [stderr] Checking fjage_rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/protocol/connector.rs:32:16 [INFO] [stdout] | [INFO] [stdout] 32 | if (bytes_read.is_err()) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 32 - if (bytes_read.is_err()) { [INFO] [stdout] 32 + if bytes_read.is_err() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/protocol/connector.rs:36:16 [INFO] [stdout] | [INFO] [stdout] 36 | if (bytes_read == 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 36 - if (bytes_read == 0) { [INFO] [stdout] 36 + if bytes_read == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/protocol/connector.rs:106:16 [INFO] [stdout] | [INFO] [stdout] 106 | if (bytes_read.is_err()) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 106 - if (bytes_read.is_err()) { [INFO] [stdout] 106 + if bytes_read.is_err() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/protocol/connector.rs:113:16 [INFO] [stdout] | [INFO] [stdout] 113 | if (bytes_read == 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 113 - if (bytes_read == 0) { [INFO] [stdout] 113 + if bytes_read == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/protocol/connector.rs:32:16 [INFO] [stdout] | [INFO] [stdout] 32 | if (bytes_read.is_err()) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 32 - if (bytes_read.is_err()) { [INFO] [stdout] 32 + if bytes_read.is_err() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/protocol/connector.rs:36:16 [INFO] [stdout] | [INFO] [stdout] 36 | if (bytes_read == 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 36 - if (bytes_read == 0) { [INFO] [stdout] 36 + if bytes_read == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/protocol/connector.rs:106:16 [INFO] [stdout] | [INFO] [stdout] 106 | if (bytes_read.is_err()) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 106 - if (bytes_read.is_err()) { [INFO] [stdout] 106 + if bytes_read.is_err() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/protocol/connector.rs:113:16 [INFO] [stdout] | [INFO] [stdout] 113 | if (bytes_read == 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 113 - if (bytes_read == 0) { [INFO] [stdout] 113 + if bytes_read == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/protocol/connector.rs:27:57 [INFO] [stdout] | [INFO] [stdout] 27 | async fn read_task(stream: T, mut sender: UnboundedSender) { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/protocol/connector.rs:27:57 [INFO] [stdout] | [INFO] [stdout] 27 | async fn read_task(stream: T, mut sender: UnboundedSender) { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/protocol/connector.rs:101:57 [INFO] [stdout] | [INFO] [stdout] 101 | async fn read_task(stream: T, mut sender: UnboundedSender) { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/protocol/connector.rs:101:57 [INFO] [stdout] | [INFO] [stdout] 101 | async fn read_task(stream: T, mut sender: UnboundedSender) { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `settings` [INFO] [stdout] --> src/ffi/mod.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | settings: *const c_char, [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_settings` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `devname` [INFO] [stdout] --> src/ffi/mod.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | devname: *const c_char, [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_devname` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `baud` [INFO] [stdout] --> src/ffi/mod.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 58 | baud: c_int, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_baud` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `settings` [INFO] [stdout] --> src/ffi/mod.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | settings: *const c_char, [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_settings` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `settings` [INFO] [stdout] --> src/ffi/mod.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | settings: *const c_char, [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_settings` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `devname` [INFO] [stdout] --> src/ffi/mod.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | devname: *const c_char, [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_devname` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `baud` [INFO] [stdout] --> src/ffi/mod.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 58 | baud: c_int, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_baud` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `settings` [INFO] [stdout] --> src/ffi/mod.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | settings: *const c_char, [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_settings` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified [INFO] [stdout] --> src/protocol/connector.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | async fn connect(&self) -> (UnboundedSender, UnboundedReceiver); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future` [INFO] [stdout] = note: `#[warn(async_fn_in_trait)]` on by default [INFO] [stdout] help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change [INFO] [stdout] | [INFO] [stdout] 12 - async fn connect(&self) -> (UnboundedSender, UnboundedReceiver); [INFO] [stdout] 12 + fn connect(&self) -> impl std::future::Future, UnboundedReceiver)> + Send; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified [INFO] [stdout] --> src/protocol/connector.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | async fn connect(&self) -> (UnboundedSender, UnboundedReceiver); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future` [INFO] [stdout] = note: `#[warn(async_fn_in_trait)]` on by default [INFO] [stdout] help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change [INFO] [stdout] | [INFO] [stdout] 12 - async fn connect(&self) -> (UnboundedSender, UnboundedReceiver); [INFO] [stdout] 12 + fn connect(&self) -> impl std::future::Future, UnboundedReceiver)> + Send; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/util/put_file.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | let mut file = OpenOptions::new().read(true).open(&path).unwrap(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/util/put_file.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | let mut file = OpenOptions::new().read(true).open(&path).unwrap(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.98s [INFO] running `Command { std: "docker" "inspect" "e14610832facd1d329e54f21135977e5bfe38f504599bea61c649e3697049dec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e14610832facd1d329e54f21135977e5bfe38f504599bea61c649e3697049dec", kill_on_drop: false }` [INFO] [stdout] e14610832facd1d329e54f21135977e5bfe38f504599bea61c649e3697049dec