[INFO] fetching crate go-types 0.1.5... [INFO] checking go-types-0.1.5 against try#0edd13c68435d50367c79cef43ac2768d2ec4f3d for pr-129422 [INFO] extracting crate go-types 0.1.5 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate go-types 0.1.5 on toolchain 0edd13c68435d50367c79cef43ac2768d2ec4f3d [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+0edd13c68435d50367c79cef43ac2768d2ec4f3d" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate go-types 0.1.5 [INFO] finished tweaking crates.io crate go-types 0.1.5 [INFO] tweaked toml for crates.io crate go-types 0.1.5 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+0edd13c68435d50367c79cef43ac2768d2ec4f3d" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 13 packages to latest compatible versions [INFO] [stderr] Adding ordered-float v3.9.2 (latest: v4.2.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+0edd13c68435d50367c79cef43ac2768d2ec4f3d" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+0edd13c68435d50367c79cef43ac2768d2ec4f3d" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d98a7978bb9255da20b9237f56df3ac1a4934349eb73c513ec9195e40b7ba410 [INFO] running `Command { std: "docker" "start" "-a" "d98a7978bb9255da20b9237f56df3ac1a4934349eb73c513ec9195e40b7ba410", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d98a7978bb9255da20b9237f56df3ac1a4934349eb73c513ec9195e40b7ba410", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d98a7978bb9255da20b9237f56df3ac1a4934349eb73c513ec9195e40b7ba410", kill_on_drop: false }` [INFO] [stdout] d98a7978bb9255da20b9237f56df3ac1a4934349eb73c513ec9195e40b7ba410 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+0edd13c68435d50367c79cef43ac2768d2ec4f3d" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7875dbf9a7d1f3514cc3dc5a090382258f66967afa10a555c9c61bf32bebe7ce [INFO] running `Command { std: "docker" "start" "-a" "7875dbf9a7d1f3514cc3dc5a090382258f66967afa10a555c9c61bf32bebe7ce", kill_on_drop: false }` [INFO] [stderr] Checking go-parser v0.1.5 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking ordered-float v3.9.2 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking go-types v0.1.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/check/typexpr.rs:632:61 [INFO] [stdout] | [INFO] [stdout] 632 | if info.is_none() || info.as_ref().unwrap().as_ref().borrow().is_empty() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `IfaceInfo` does not implement `Borrow`, so calling `borrow` on `&IfaceInfo` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 632 - if info.is_none() || info.as_ref().unwrap().as_ref().borrow().is_empty() { [INFO] [stdout] 632 + if info.is_none() || info.as_ref().unwrap().as_ref().is_empty() { [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `IfaceInfo`, implement `Clone` for it [INFO] [stdout] --> src/check/interface.rs:143:1 [INFO] [stdout] | [INFO] [stdout] 143 + #[derive(Clone)] [INFO] [stdout] 144 | pub struct IfaceInfo { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/check/typexpr.rs:654:55 [INFO] [stdout] | [INFO] [stdout] 654 | let info_ref = info.as_ref().unwrap().as_ref().borrow(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `IfaceInfo` does not implement `Borrow`, so calling `borrow` on `&IfaceInfo` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 654 - let info_ref = info.as_ref().unwrap().as_ref().borrow(); [INFO] [stdout] 654 + let info_ref = info.as_ref().unwrap().as_ref(); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `IfaceInfo`, implement `Clone` for it [INFO] [stdout] --> src/check/interface.rs:143:1 [INFO] [stdout] | [INFO] [stdout] 143 + #[derive(Clone)] [INFO] [stdout] 144 | pub struct IfaceInfo { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/check/typexpr.rs:632:61 [INFO] [stdout] | [INFO] [stdout] 632 | if info.is_none() || info.as_ref().unwrap().as_ref().borrow().is_empty() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `IfaceInfo` does not implement `Borrow`, so calling `borrow` on `&IfaceInfo` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 632 - if info.is_none() || info.as_ref().unwrap().as_ref().borrow().is_empty() { [INFO] [stdout] 632 + if info.is_none() || info.as_ref().unwrap().as_ref().is_empty() { [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `IfaceInfo`, implement `Clone` for it [INFO] [stdout] --> src/check/interface.rs:143:1 [INFO] [stdout] | [INFO] [stdout] 143 + #[derive(Clone)] [INFO] [stdout] 144 | pub struct IfaceInfo { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/check/typexpr.rs:654:55 [INFO] [stdout] | [INFO] [stdout] 654 | let info_ref = info.as_ref().unwrap().as_ref().borrow(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `IfaceInfo` does not implement `Borrow`, so calling `borrow` on `&IfaceInfo` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 654 - let info_ref = info.as_ref().unwrap().as_ref().borrow(); [INFO] [stdout] 654 + let info_ref = info.as_ref().unwrap().as_ref(); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `IfaceInfo`, implement `Clone` for it [INFO] [stdout] --> src/check/interface.rs:143:1 [INFO] [stdout] | [INFO] [stdout] 143 + #[derive(Clone)] [INFO] [stdout] 144 | pub struct IfaceInfo { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.87s [INFO] running `Command { std: "docker" "inspect" "7875dbf9a7d1f3514cc3dc5a090382258f66967afa10a555c9c61bf32bebe7ce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7875dbf9a7d1f3514cc3dc5a090382258f66967afa10a555c9c61bf32bebe7ce", kill_on_drop: false }` [INFO] [stdout] 7875dbf9a7d1f3514cc3dc5a090382258f66967afa10a555c9c61bf32bebe7ce