[INFO] cloning repository https://github.com/ddprrt/refactoring-rust-workshop-examples [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ddprrt/refactoring-rust-workshop-examples" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fddprrt%2Frefactoring-rust-workshop-examples", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fddprrt%2Frefactoring-rust-workshop-examples'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4d58f61217707438d167cf6ed1cd8509c29dc6eb [INFO] checking ddprrt/refactoring-rust-workshop-examples against try#9543f8ea2aae74b8f13ac2a6e6c0ecdca9810869 for pr-129249 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fddprrt%2Frefactoring-rust-workshop-examples" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ddprrt/refactoring-rust-workshop-examples on toolchain 9543f8ea2aae74b8f13ac2a6e6c0ecdca9810869 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+9543f8ea2aae74b8f13ac2a6e6c0ecdca9810869" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/ddprrt/refactoring-rust-workshop-examples [INFO] finished tweaking git repo https://github.com/ddprrt/refactoring-rust-workshop-examples [INFO] tweaked toml for git repo https://github.com/ddprrt/refactoring-rust-workshop-examples written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/ddprrt/refactoring-rust-workshop-examples already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+9543f8ea2aae74b8f13ac2a6e6c0ecdca9810869" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+9543f8ea2aae74b8f13ac2a6e6c0ecdca9810869" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 061b03a75824c913d4cfcc5d6e50a504a6f32805f0e42786db9f781b9cd1b019 [INFO] running `Command { std: "docker" "start" "-a" "061b03a75824c913d4cfcc5d6e50a504a6f32805f0e42786db9f781b9cd1b019", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "061b03a75824c913d4cfcc5d6e50a504a6f32805f0e42786db9f781b9cd1b019", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "061b03a75824c913d4cfcc5d6e50a504a6f32805f0e42786db9f781b9cd1b019", kill_on_drop: false }` [INFO] [stdout] 061b03a75824c913d4cfcc5d6e50a504a6f32805f0e42786db9f781b9cd1b019 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+9543f8ea2aae74b8f13ac2a6e6c0ecdca9810869" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 510ac7371d9c5b1ff88d57cbb85eb516d5e89c229e28591a685b2c2b39169141 [INFO] running `Command { std: "docker" "start" "-a" "510ac7371d9c5b1ff88d57cbb85eb516d5e89c229e28591a685b2c2b39169141", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Checking iterator-ex v0.1.0 (/opt/rustwide/workdir/iterator-ex) [INFO] [stderr] Checking progress v0.1.0 (/opt/rustwide/workdir/progress) [INFO] [stderr] Checking default-trait v0.1.0 (/opt/rustwide/workdir/default-trait) [INFO] [stderr] Checking errors v0.1.0 (/opt/rustwide/workdir/errors) [INFO] [stderr] Checking clippy v0.1.0 (/opt/rustwide/workdir/clippy) [INFO] [stderr] Checking fibonacci v0.1.0 (/opt/rustwide/workdir/fibonacci) [INFO] [stdout] warning: unused variable: `slice` [INFO] [stdout] --> iterator-ex/src/main.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | let slice = vec.as_slice(); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_slice` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `slice_arr` [INFO] [stdout] --> iterator-ex/src/main.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | let slice_arr = arr.as_slice(); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_slice_arr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> iterator-ex/src/main.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | let x = "abc".to_string(); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `a` [INFO] [stdout] --> iterator-ex/src/main.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | let a = A::new("Hello"); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `b` [INFO] [stdout] --> iterator-ex/src/main.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | let b = A::new(String::from("Yolo")); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_b` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `slice` [INFO] [stdout] --> iterator-ex/src/main.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | let slice = strng_2.as_str(); // Same data [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_slice` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> iterator-ex/src/main.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 1 | struct A { [INFO] [stdout] | - field in this struct [INFO] [stdout] 2 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `slice` [INFO] [stdout] --> iterator-ex/src/main.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | let slice = vec.as_slice(); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_slice` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `slice_arr` [INFO] [stdout] --> iterator-ex/src/main.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | let slice_arr = arr.as_slice(); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_slice_arr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> iterator-ex/src/main.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | let x = "abc".to_string(); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `a` [INFO] [stdout] --> iterator-ex/src/main.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | let a = A::new("Hello"); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `b` [INFO] [stdout] --> iterator-ex/src/main.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | let b = A::new(String::from("Yolo")); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_b` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `slice` [INFO] [stdout] --> iterator-ex/src/main.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | let slice = strng_2.as_str(); // Same data [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_slice` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> iterator-ex/src/main.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 1 | struct A { [INFO] [stdout] | - field in this struct [INFO] [stdout] 2 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this conversion is useless `String` to `String` [INFO] [stdout] --> iterator-ex/src/main.rs:22:27 [INFO] [stdout] | [INFO] [stdout] 22 | let strng_1: String = strng.into(); // No re-allocation See impl From for T [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `iterator-ex` (bin "iterator-ex" test) due to 1 previous error; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this conversion is useless `String` to `String` [INFO] [stdout] --> iterator-ex/src/main.rs:22:27 [INFO] [stdout] | [INFO] [stdout] 22 | let strng_1: String = strng.into(); // No re-allocation See impl From for T [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `clock` [INFO] [stdout] --> default-trait/src/main.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | let clock = Clock::default(); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_clock` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `clock` [INFO] [stdout] --> default-trait/src/main.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | let clock: Clock = Default::default(); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_clock` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `clock` [INFO] [stdout] --> default-trait/src/main.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | let clock = Clock { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_clock` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `clock` [INFO] [stdout] --> default-trait/src/main.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | let clock = Clock { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_clock` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `clock` [INFO] [stdout] --> default-trait/src/main.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | let clock: Clock = X::x(); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_clock` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `z` [INFO] [stdout] --> default-trait/src/main.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | let z: Option = Clock::default().into(); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_z` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `clock` [INFO] [stdout] --> default-trait/src/main.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | let clock = anything::(); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_clock` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `hours` and `minutes` are never read [INFO] [stdout] --> default-trait/src/main.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 2 | struct Clock { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 3 | hours: usize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 4 | minutes: usize, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Clock` has a derived impl for the trait `Default`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `None` is never constructed [INFO] [stdout] --> default-trait/src/main.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 21 | enum MyOption { [INFO] [stdout] | -------- variant in this enum [INFO] [stdout] 22 | Some(T), [INFO] [stdout] 23 | None, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `iterator-ex` (bin "iterator-ex") due to 1 previous error; 7 warnings emitted [INFO] [stdout] warning: unused variable: `clock` [INFO] [stdout] --> default-trait/src/main.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | let clock = Clock::default(); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_clock` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `clock` [INFO] [stdout] --> default-trait/src/main.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | let clock: Clock = Default::default(); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_clock` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `clock` [INFO] [stdout] --> default-trait/src/main.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | let clock = Clock { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_clock` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `clock` [INFO] [stdout] --> default-trait/src/main.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | let clock = Clock { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_clock` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `clock` [INFO] [stdout] --> default-trait/src/main.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | let clock: Clock = X::x(); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_clock` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `z` [INFO] [stdout] --> default-trait/src/main.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | let z: Option = Clock::default().into(); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_z` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `clock` [INFO] [stdout] --> default-trait/src/main.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | let clock = anything::(); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_clock` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `hours` and `minutes` are never read [INFO] [stdout] --> default-trait/src/main.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 2 | struct Clock { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 3 | hours: usize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 4 | minutes: usize, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Clock` has a derived impl for the trait `Default`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `None` is never constructed [INFO] [stdout] --> default-trait/src/main.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 21 | enum MyOption { [INFO] [stdout] | -------- variant in this enum [INFO] [stdout] 22 | Some(T), [INFO] [stdout] 23 | None, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "510ac7371d9c5b1ff88d57cbb85eb516d5e89c229e28591a685b2c2b39169141", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "510ac7371d9c5b1ff88d57cbb85eb516d5e89c229e28591a685b2c2b39169141", kill_on_drop: false }` [INFO] [stdout] 510ac7371d9c5b1ff88d57cbb85eb516d5e89c229e28591a685b2c2b39169141