[INFO] cloning repository https://github.com/sum12/rs9p [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/sum12/rs9p" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsum12%2Frs9p", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsum12%2Frs9p'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 510bef12938ea0208a90da2fed072eef0270de92 [INFO] checking sum12/rs9p against 52995a223f2919dd3e2e427231db90a257350ded for pr-129249-4 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsum12%2Frs9p" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/sum12/rs9p [INFO] finished tweaking git repo https://github.com/sum12/rs9p [INFO] tweaked toml for git repo https://github.com/sum12/rs9p written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/sum12/rs9p on toolchain 52995a223f2919dd3e2e427231db90a257350ded [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+52995a223f2919dd3e2e427231db90a257350ded" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/sum12/rs9p already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+52995a223f2919dd3e2e427231db90a257350ded" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:c0af3998e971868164375a7dfb646c9933ddd1a3bdb00fa2041266763dc1eeab" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] 1eae223235cb8dfe4f7a36bef4e073f49bdf555692777c0521cc9258f35e8cbc [INFO] running `Command { std: "docker" "start" "1eae223235cb8dfe4f7a36bef4e073f49bdf555692777c0521cc9258f35e8cbc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1eae223235cb8dfe4f7a36bef4e073f49bdf555692777c0521cc9258f35e8cbc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "1eae223235cb8dfe4f7a36bef4e073f49bdf555692777c0521cc9258f35e8cbc" "/opt/rustwide/cargo-home/bin/cargo" "+52995a223f2919dd3e2e427231db90a257350ded" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1eae223235cb8dfe4f7a36bef4e073f49bdf555692777c0521cc9258f35e8cbc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "1eae223235cb8dfe4f7a36bef4e073f49bdf555692777c0521cc9258f35e8cbc" "/opt/rustwide/cargo-home/bin/cargo" "+52995a223f2919dd3e2e427231db90a257350ded" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stderr] Checking proto v0.1.0 (/opt/rustwide/workdir/proto) [INFO] [stdout] warning: unused import: `crate::qid` [INFO] [stdout] --> proto/src/write.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::qid; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::qid` [INFO] [stdout] --> proto/src/read.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::qid; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking client v0.1.0 (/opt/rustwide/workdir/client) [INFO] [stdout] warning: unused import: `std::rc` [INFO] [stdout] --> client/src/file.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::rc; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `buf` [INFO] [stdout] --> client/src/file.rs:15:25 [INFO] [stdout] | [INFO] [stdout] 15 | fn write(&mut self, buf: &[u8]) -> io::Result { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_buf` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `offset` [INFO] [stdout] --> client/src/file.rs:66:40 [INFO] [stdout] | [INFO] [stdout] 66 | fn twrite(&mut self, buf: Vec, offset: u64) -> Result { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_offset` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> client/src/file.rs:91:45 [INFO] [stdout] | [INFO] [stdout] 91 | Some(proto::Message::RError(x)) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `p` [INFO] [stdout] --> client/src/file.rs:97:29 [INFO] [stdout] | [INFO] [stdout] 97 | let (_, p) = p.split_at(x.count as usize); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_p` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `twrite` is never used [INFO] [stdout] --> client/src/file.rs:66:8 [INFO] [stdout] | [INFO] [stdout] 65 | impl File<'_> { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] 66 | fn twrite(&mut self, buf: Vec, offset: u64) -> Result { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `Message` [INFO] [stdout] --> client/src/client.rs:54:48 [INFO] [stdout] | [INFO] [stdout] 54 | Some(tx) => Ok(tx.send(f.into()).unwrap()), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 54 - Some(tx) => Ok(tx.send(f.into()).unwrap()), [INFO] [stdout] 54 + Some(tx) => Ok(tx.send(f).unwrap()), [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 54 - Some(tx) => Ok(tx.send(f.into()).unwrap()), [INFO] [stdout] 54 + Some(tx) => Ok(tx.send(>::into(f)).unwrap()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `Message` [INFO] [stdout] --> client/src/client.rs:124:14 [INFO] [stdout] | [INFO] [stdout] 124 | Some(fcall.into()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 124 - Some(fcall.into()) [INFO] [stdout] 124 + Some(fcall) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 124 - Some(fcall.into()) [INFO] [stdout] 124 + Some(>::into(fcall)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> client/src/client.rs:193:17 [INFO] [stdout] | [INFO] [stdout] 193 | pub fn open(&mut self, path: String, mode: proto::Mode) -> Option { [INFO] [stdout] | ^^^^^^^^^ the lifetime is elided here ^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 193 | pub fn open(&mut self, path: String, mode: proto::Mode) -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `client` (lib) due to 2 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "1eae223235cb8dfe4f7a36bef4e073f49bdf555692777c0521cc9258f35e8cbc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1eae223235cb8dfe4f7a36bef4e073f49bdf555692777c0521cc9258f35e8cbc", kill_on_drop: false }` [INFO] [stdout] 1eae223235cb8dfe4f7a36bef4e073f49bdf555692777c0521cc9258f35e8cbc