[INFO] cloning repository https://github.com/H3Jones/BattleSnake [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/H3Jones/BattleSnake" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FH3Jones%2FBattleSnake", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FH3Jones%2FBattleSnake'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ddf248a2ba4c57365fa6844721aa53e0af8149b8 [INFO] checking H3Jones/BattleSnake against 52995a223f2919dd3e2e427231db90a257350ded for pr-129249-4 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FH3Jones%2FBattleSnake" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/H3Jones/BattleSnake [INFO] finished tweaking git repo https://github.com/H3Jones/BattleSnake [INFO] tweaked toml for git repo https://github.com/H3Jones/BattleSnake written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/H3Jones/BattleSnake on toolchain 52995a223f2919dd3e2e427231db90a257350ded [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+52995a223f2919dd3e2e427231db90a257350ded" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/H3Jones/BattleSnake already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+52995a223f2919dd3e2e427231db90a257350ded" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:77db811e55d90add9212f6832c23229e3de5f1c1f9905e8cb07319ea15df73ac" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] 572f2938d2f0bc5afb1546f315a7380cf1b0a2740cfd71d98ae1387cc620f130 [INFO] running `Command { std: "docker" "start" "572f2938d2f0bc5afb1546f315a7380cf1b0a2740cfd71d98ae1387cc620f130", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "572f2938d2f0bc5afb1546f315a7380cf1b0a2740cfd71d98ae1387cc620f130", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "572f2938d2f0bc5afb1546f315a7380cf1b0a2740cfd71d98ae1387cc620f130" "/opt/rustwide/cargo-home/bin/cargo" "+52995a223f2919dd3e2e427231db90a257350ded" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "572f2938d2f0bc5afb1546f315a7380cf1b0a2740cfd71d98ae1387cc620f130", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "572f2938d2f0bc5afb1546f315a7380cf1b0a2740cfd71d98ae1387cc620f130" "/opt/rustwide/cargo-home/bin/cargo" "+52995a223f2919dd3e2e427231db90a257350ded" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.107 [INFO] [stderr] Compiling unicode-ident v1.0.26 [INFO] [stderr] Compiling libc v0.2.190 [INFO] [stderr] Checking cfg-if v1.0.5 [INFO] [stderr] Checking log v0.4.34 [INFO] [stderr] Compiling zerocopy v0.8.62 [INFO] [stderr] Compiling serde_core v1.0.229 [INFO] [stderr] Checking smallvec v1.16.2 [INFO] [stderr] Compiling serde v1.0.229 [INFO] [stderr] Checking futures-core v0.3.34 [INFO] [stderr] Checking http v1.5.0 [INFO] [stderr] Compiling rustversion v1.0.23 [INFO] [stderr] Checking typenum v1.20.1 [INFO] [stderr] Checking futures-sink v0.3.34 [INFO] [stderr] Checking slab v0.4.12 [INFO] [stderr] Checking futures-task v0.3.34 [INFO] [stderr] Checking bitflags v2.13.2 [INFO] [stderr] Compiling zmij v1.0.23 [INFO] [stderr] Compiling signal-hook v0.3.18 [INFO] [stderr] Checking data-encoding v2.11.1 [INFO] [stderr] Compiling strsim v0.11.1 [INFO] [stderr] Compiling serde_json v1.0.151 [INFO] [stderr] Compiling unicase v2.10.0 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Checking allocator-api2 v0.2.21 [INFO] [stderr] Checking either v1.19.0 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Checking unicode-segmentation v1.13.3 [INFO] [stderr] Compiling indoc v2.0.7 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Checking http-range-header v0.4.2 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking castaway v0.2.4 [INFO] [stderr] Checking compact_str v0.8.2 [INFO] [stderr] Compiling quote v1.0.47 [INFO] [stderr] Compiling syn v3.0.6 [INFO] [stderr] Compiling syn v2.0.119 [INFO] [stderr] Checking http-body v1.1.0 [INFO] [stderr] Checking lru v0.12.5 [INFO] [stderr] Checking http-body-util v0.1.5 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking mio v1.2.4 [INFO] [stderr] Checking socket2 v0.6.5 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Checking signal-hook-mio v0.2.5 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking sha1 v0.10.7 [INFO] [stderr] Checking unicode-truncate v1.1.0 [INFO] [stderr] Checking serde_path_to_error v0.1.20 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Compiling darling_core v0.24.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking rand v0.8.8 [INFO] [stderr] Compiling serde_derive v1.0.229 [INFO] [stderr] Compiling tokio-macros v2.7.2 [INFO] [stderr] Compiling futures-macro v0.3.34 [INFO] [stderr] Compiling async-trait v0.1.92 [INFO] [stderr] Checking tokio v1.53.2 [INFO] [stderr] Checking tungstenite v0.24.0 [INFO] [stderr] Checking futures-util v0.3.34 [INFO] [stderr] Compiling darling_macro v0.24.1 [INFO] [stderr] Compiling darling v0.24.1 [INFO] [stderr] Compiling instability v0.3.14 [INFO] [stderr] Checking ratatui v0.28.1 [INFO] [stderr] Checking battlesnake-core v0.1.0 (/opt/rustwide/workdir/crates/core) [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking axum-core v0.4.5 [INFO] [stderr] Checking battlesnake-proto v0.1.0 (/opt/rustwide/workdir/crates/proto) [INFO] [stderr] Checking battlesnake-ai v0.1.0 (/opt/rustwide/workdir/crates/ai) [INFO] [stderr] Checking tokio-tungstenite v0.24.0 [INFO] [stderr] Checking hyper v1.12.0 [INFO] [stderr] Checking tokio-util v0.7.19 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking battlesnake-tui v0.1.0 (/opt/rustwide/workdir/crates/tui) [INFO] [stderr] Checking tower-http v0.7.1 [INFO] [stdout] error: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> crates/tui/src/main.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 63 | / serde_json::to_string(&ClientMessage::Join { [INFO] [stdout] 64 | | room, [INFO] [stdout] 65 | | name, [INFO] [stdout] 66 | | vs_bot, [INFO] [stdout] 67 | | bot_vs_bot: spectating, [INFO] [stdout] 68 | | })? [INFO] [stdout] 69 | | .into(), [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 68 - })? [INFO] [stdout] 69 - .into(), [INFO] [stdout] 68 + })?, [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 63 ~ >::into(serde_json::to_string(&ClientMessage::Join { [INFO] [stdout] 64 | room, [INFO] [stdout] ... [INFO] [stdout] 67 | bot_vs_bot: spectating, [INFO] [stdout] 68 ~ })?), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> crates/tui/src/main.rs:240:29 [INFO] [stdout] | [INFO] [stdout] 240 | .send(Message::Text(serde_json::to_string(&message)?.into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 240 - .send(Message::Text(serde_json::to_string(&message)?.into())) [INFO] [stdout] 240 + .send(Message::Text(serde_json::to_string(&message)?)) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 240 - .send(Message::Text(serde_json::to_string(&message)?.into())) [INFO] [stdout] 240 + .send(Message::Text(>::into(serde_json::to_string(&message)?))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `battlesnake-tui` (bin "battlesnake-tui") due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> crates/tui/src/main.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 63 | / serde_json::to_string(&ClientMessage::Join { [INFO] [stdout] 64 | | room, [INFO] [stdout] 65 | | name, [INFO] [stdout] 66 | | vs_bot, [INFO] [stdout] 67 | | bot_vs_bot: spectating, [INFO] [stdout] 68 | | })? [INFO] [stdout] 69 | | .into(), [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 68 - })? [INFO] [stdout] 69 - .into(), [INFO] [stdout] 68 + })?, [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 63 ~ >::into(serde_json::to_string(&ClientMessage::Join { [INFO] [stdout] 64 | room, [INFO] [stdout] ... [INFO] [stdout] 67 | bot_vs_bot: spectating, [INFO] [stdout] 68 ~ })?), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> crates/tui/src/main.rs:240:29 [INFO] [stdout] | [INFO] [stdout] 240 | .send(Message::Text(serde_json::to_string(&message)?.into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 240 - .send(Message::Text(serde_json::to_string(&message)?.into())) [INFO] [stdout] 240 + .send(Message::Text(serde_json::to_string(&message)?)) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 240 - .send(Message::Text(serde_json::to_string(&message)?.into())) [INFO] [stdout] 240 + .send(Message::Text(>::into(serde_json::to_string(&message)?))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `battlesnake-tui` (bin "battlesnake-tui" test) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "572f2938d2f0bc5afb1546f315a7380cf1b0a2740cfd71d98ae1387cc620f130", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "572f2938d2f0bc5afb1546f315a7380cf1b0a2740cfd71d98ae1387cc620f130", kill_on_drop: false }` [INFO] [stdout] 572f2938d2f0bc5afb1546f315a7380cf1b0a2740cfd71d98ae1387cc620f130