[INFO] fetching crate libreda-lefdef 0.0.5...
[INFO] checking libreda-lefdef-0.0.5 against a5689b034ad287112f709693384a37f1377eb9cc for pr-129249-3
[INFO] extracting crate libreda-lefdef 0.0.5 into /workspace/builds/worker-0-tc2/source
[INFO] started tweaking crates.io crate libreda-lefdef 0.0.5
[INFO] finished tweaking crates.io crate libreda-lefdef 0.0.5
[INFO] tweaked toml for crates.io crate libreda-lefdef 0.0.5 written to /workspace/builds/worker-0-tc2/source/Cargo.toml
[INFO] validating manifest of crates.io crate libreda-lefdef 0.0.5 on toolchain a5689b034ad287112f709693384a37f1377eb9cc
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]      Locking 53 packages to highest compatible versions
[INFO] [stderr]       Adding itertools v0.13.0 (available: v0.15.0)
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:77db811e55d90add9212f6832c23229e3de5f1c1f9905e8cb07319ea15df73ac" "sleep" "infinity", kill_on_drop: false }`
[INFO] [stdout] e6cbb0b73817f4d4be9252a2c0e19b21074dc8b454abda2e4597938765adcc73
[INFO] running `Command { std: "docker" "start" "e6cbb0b73817f4d4be9252a2c0e19b21074dc8b454abda2e4597938765adcc73", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "e6cbb0b73817f4d4be9252a2c0e19b21074dc8b454abda2e4597938765adcc73", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "e6cbb0b73817f4d4be9252a2c0e19b21074dc8b454abda2e4597938765adcc73" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "e6cbb0b73817f4d4be9252a2c0e19b21074dc8b454abda2e4597938765adcc73", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "e6cbb0b73817f4d4be9252a2c0e19b21074dc8b454abda2e4597938765adcc73" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stderr]    Compiling libc v0.2.191
[INFO] [stderr]    Compiling zerocopy v0.8.63
[INFO] [stderr]     Checking either v1.19.0
[INFO] [stderr]    Compiling heck v0.4.1
[INFO] [stderr]     Checking hash32 v0.2.1
[INFO] [stderr]    Compiling heapless v0.7.17
[INFO] [stderr]     Checking spin v0.9.9
[INFO] [stderr]     Checking smallvec v1.16.3
[INFO] [stderr]     Checking libreda-splay v0.1.1
[INFO] [stderr]    Compiling syn v3.0.9
[INFO] [stderr]    Compiling syn v2.0.119
[INFO] [stderr]     Checking num-integer v0.1.47
[INFO] [stderr]    Compiling itertools v0.10.5
[INFO] [stderr]     Checking itertools v0.13.0
[INFO] [stderr]     Checking num-bigint v0.4.8
[INFO] [stderr]     Checking rstar v0.9.3
[INFO] [stderr]    Compiling getrandom v0.2.17
[INFO] [stderr]     Checking num-rational v0.4.2
[INFO] [stderr]    Compiling rand_core v0.6.4
[INFO] [stderr]     Checking libreda-stream-parser v0.2.0
[INFO] [stderr]    Compiling serde_derive v1.0.229
[INFO] [stderr]    Compiling ppv-lite86 v0.2.21
[INFO] [stderr]     Checking serde v1.0.229
[INFO] [stderr]    Compiling rand_chacha v0.3.1
[INFO] [stderr]     Checking iron-shapes v0.1.1
[INFO] [stderr]    Compiling rand v0.8.8
[INFO] [stderr]    Compiling portrait-framework v0.2.1
[INFO] [stderr]    Compiling portrait-codegen v0.2.3
[INFO] [stderr]     Checking iron-shapes-booleanop v0.1.0
[INFO] [stderr]     Checking portrait v0.2.3
[INFO] [stderr]     Checking libreda-db v0.0.12
[INFO] [stderr]     Checking libreda-lefdef v0.0.5 (/opt/rustwide/workdir)
[INFO] [stdout] error: useless conversion to the same type: `&str`
[INFO] [stdout]    --> src/def_parser.rs:209:68
[INFO] [stdout]     |
[INFO] [stdout] 209 | ...   .ok_or_else(|| LefDefParseError::Other("Appearance of 'RECT' in a route but no current path point is defined.".into()))?
[INFO] [stdout]     |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout]     = note: `#[deny(self_type_conversion)]` on by default
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]     |
[INFO] [stdout] 209 -                             .ok_or_else(|| LefDefParseError::Other("Appearance of 'RECT' in a route but no current path point is defined.".into()))?
[INFO] [stdout] 209 +                             .ok_or_else(|| LefDefParseError::Other("Appearance of 'RECT' in a route but no current path point is defined."))?
[INFO] [stdout]     |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]     |
[INFO] [stdout] 209 -                             .ok_or_else(|| LefDefParseError::Other("Appearance of 'RECT' in a route but no current path point is defined.".into()))?
[INFO] [stdout] 209 +                             .ok_or_else(|| LefDefParseError::Other(<&str as Into<_>>::into("Appearance of 'RECT' in a route but no current path point is defined.")))?
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: useless conversion to the same type: `(i32, i32)`
[INFO] [stdout]    --> src/def_parser.rs:238:39
[INFO] [stdout]     |
[INFO] [stdout] 238 |                     prev_point = Some(p.into());
[INFO] [stdout]     |                                       ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]     |
[INFO] [stdout] 238 -                     prev_point = Some(p.into());
[INFO] [stdout] 238 +                     prev_point = Some(p);
[INFO] [stdout]     |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]     |
[INFO] [stdout] 238 -                     prev_point = Some(p.into());
[INFO] [stdout] 238 +                     prev_point = Some(<(i32, i32) as Into<_>>::into(p));
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement
[INFO] [stdout]   --> src/def_writer.rs:65:14
[INFO] [stdout]    |
[INFO] [stdout] 65 |     for v in &def.version {
[INFO] [stdout]    |              ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(for_loops_over_fallibles)]` on by default
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]    |
[INFO] [stdout] 65 -     for v in &def.version {
[INFO] [stdout] 65 +     while let Some(v) = &def.version {
[INFO] [stdout]    |
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]    |
[INFO] [stdout] 65 -     for v in &def.version {
[INFO] [stdout] 65 +     if let Some(v) = &def.version {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement
[INFO] [stdout]   --> src/def_writer.rs:83:14
[INFO] [stdout]    |
[INFO] [stdout] 83 |     for n in &def.design_name {
[INFO] [stdout]    |              ^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]    |
[INFO] [stdout] 83 -     for n in &def.design_name {
[INFO] [stdout] 83 +     while let Some(n) = &def.design_name {
[INFO] [stdout]    |
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]    |
[INFO] [stdout] 83 -     for n in &def.design_name {
[INFO] [stdout] 83 +     if let Some(n) = &def.design_name {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement
[INFO] [stdout]   --> src/def_writer.rs:88:14
[INFO] [stdout]    |
[INFO] [stdout] 88 |     for n in &def.technology {
[INFO] [stdout]    |              ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]    |
[INFO] [stdout] 88 -     for n in &def.technology {
[INFO] [stdout] 88 +     while let Some(n) = &def.technology {
[INFO] [stdout]    |
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]    |
[INFO] [stdout] 88 -     for n in &def.technology {
[INFO] [stdout] 88 +     if let Some(n) = &def.technology {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement
[INFO] [stdout]    --> src/def_writer.rs:204:32
[INFO] [stdout]     |
[INFO] [stdout] 204 |             for region_type in &region.region_type {
[INFO] [stdout]     |                                ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]     |
[INFO] [stdout] 204 -             for region_type in &region.region_type {
[INFO] [stdout] 204 +             while let Some(region_type) = &region.region_type {
[INFO] [stdout]     |
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]     |
[INFO] [stdout] 204 -             for region_type in &region.region_type {
[INFO] [stdout] 204 +             if let Some(region_type) = &region.region_type {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement
[INFO] [stdout]    --> src/def_writer.rs:223:22
[INFO] [stdout]     |
[INFO] [stdout] 223 |             for m in &comp.eeq_master {
[INFO] [stdout]     |                      ^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]     |
[INFO] [stdout] 223 -             for m in &comp.eeq_master {
[INFO] [stdout] 223 +             while let Some(m) = &comp.eeq_master {
[INFO] [stdout]     |
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]     |
[INFO] [stdout] 223 -             for m in &comp.eeq_master {
[INFO] [stdout] 223 +             if let Some(m) = &comp.eeq_master {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement
[INFO] [stdout]    --> src/def_writer.rs:242:53
[INFO] [stdout]     |
[INFO] [stdout] 242 |             for (soft, left, bottom, right, top) in &comp.halo {
[INFO] [stdout]     |                                                     ^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]     |
[INFO] [stdout] 242 -             for (soft, left, bottom, right, top) in &comp.halo {
[INFO] [stdout] 242 +             while let Some((soft, left, bottom, right, top)) = &comp.halo {
[INFO] [stdout]     |
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]     |
[INFO] [stdout] 242 -             for (soft, left, bottom, right, top) in &comp.halo {
[INFO] [stdout] 242 +             if let Some((soft, left, bottom, right, top)) = &comp.halo {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement
[INFO] [stdout]    --> src/def_writer.rs:250:49
[INFO] [stdout]     |
[INFO] [stdout] 250 |             for (dist, min_layer, max_layer) in &comp.route_halo {
[INFO] [stdout]     |                                                 ^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]     |
[INFO] [stdout] 250 -             for (dist, min_layer, max_layer) in &comp.route_halo {
[INFO] [stdout] 250 +             while let Some((dist, min_layer, max_layer)) = &comp.route_halo {
[INFO] [stdout]     |
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]     |
[INFO] [stdout] 250 -             for (dist, min_layer, max_layer) in &comp.route_halo {
[INFO] [stdout] 250 +             if let Some((dist, min_layer, max_layer)) = &comp.route_halo {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement
[INFO] [stdout]    --> src/def_writer.rs:260:22
[INFO] [stdout]     |
[INFO] [stdout] 260 |             for r in &comp.region {
[INFO] [stdout]     |                      ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]     |
[INFO] [stdout] 260 -             for r in &comp.region {
[INFO] [stdout] 260 +             while let Some(r) = &comp.region {
[INFO] [stdout]     |
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]     |
[INFO] [stdout] 260 -             for r in &comp.region {
[INFO] [stdout] 260 +             if let Some(r) = &comp.region {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: useless conversion to the same type: `&str`
[INFO] [stdout]    --> src/def_parser.rs:209:68
[INFO] [stdout]     |
[INFO] [stdout] 209 | ...   .ok_or_else(|| LefDefParseError::Other("Appearance of 'RECT' in a route but no current path point is defined.".into()))?
[INFO] [stdout]     |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout]     = note: `#[deny(self_type_conversion)]` on by default
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]     |
[INFO] [stdout] 209 -                             .ok_or_else(|| LefDefParseError::Other("Appearance of 'RECT' in a route but no current path point is defined.".into()))?
[INFO] [stdout] 209 +                             .ok_or_else(|| LefDefParseError::Other("Appearance of 'RECT' in a route but no current path point is defined."))?
[INFO] [stdout]     |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]     |
[INFO] [stdout] 209 -                             .ok_or_else(|| LefDefParseError::Other("Appearance of 'RECT' in a route but no current path point is defined.".into()))?
[INFO] [stdout] 209 +                             .ok_or_else(|| LefDefParseError::Other(<&str as Into<_>>::into("Appearance of 'RECT' in a route but no current path point is defined.")))?
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: useless conversion to the same type: `(i32, i32)`
[INFO] [stdout]    --> src/def_parser.rs:238:39
[INFO] [stdout]     |
[INFO] [stdout] 238 |                     prev_point = Some(p.into());
[INFO] [stdout]     |                                       ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]     |
[INFO] [stdout] 238 -                     prev_point = Some(p.into());
[INFO] [stdout] 238 +                     prev_point = Some(p);
[INFO] [stdout]     |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]     |
[INFO] [stdout] 238 -                     prev_point = Some(p.into());
[INFO] [stdout] 238 +                     prev_point = Some(<(i32, i32) as Into<_>>::into(p));
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement
[INFO] [stdout]   --> src/def_writer.rs:65:14
[INFO] [stdout]    |
[INFO] [stdout] 65 |     for v in &def.version {
[INFO] [stdout]    |              ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(for_loops_over_fallibles)]` on by default
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]    |
[INFO] [stdout] 65 -     for v in &def.version {
[INFO] [stdout] 65 +     while let Some(v) = &def.version {
[INFO] [stdout]    |
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]    |
[INFO] [stdout] 65 -     for v in &def.version {
[INFO] [stdout] 65 +     if let Some(v) = &def.version {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement
[INFO] [stdout]   --> src/def_writer.rs:83:14
[INFO] [stdout]    |
[INFO] [stdout] 83 |     for n in &def.design_name {
[INFO] [stdout]    |              ^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]    |
[INFO] [stdout] 83 -     for n in &def.design_name {
[INFO] [stdout] 83 +     while let Some(n) = &def.design_name {
[INFO] [stdout]    |
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]    |
[INFO] [stdout] 83 -     for n in &def.design_name {
[INFO] [stdout] 83 +     if let Some(n) = &def.design_name {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement
[INFO] [stdout]   --> src/def_writer.rs:88:14
[INFO] [stdout]    |
[INFO] [stdout] 88 |     for n in &def.technology {
[INFO] [stdout]    |              ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]    |
[INFO] [stdout] 88 -     for n in &def.technology {
[INFO] [stdout] 88 +     while let Some(n) = &def.technology {
[INFO] [stdout]    |
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]    |
[INFO] [stdout] 88 -     for n in &def.technology {
[INFO] [stdout] 88 +     if let Some(n) = &def.technology {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement
[INFO] [stdout]    --> src/def_writer.rs:204:32
[INFO] [stdout]     |
[INFO] [stdout] 204 |             for region_type in &region.region_type {
[INFO] [stdout]     |                                ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]     |
[INFO] [stdout] 204 -             for region_type in &region.region_type {
[INFO] [stdout] 204 +             while let Some(region_type) = &region.region_type {
[INFO] [stdout]     |
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]     |
[INFO] [stdout] 204 -             for region_type in &region.region_type {
[INFO] [stdout] 204 +             if let Some(region_type) = &region.region_type {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement
[INFO] [stdout]    --> src/def_writer.rs:223:22
[INFO] [stdout]     |
[INFO] [stdout] 223 |             for m in &comp.eeq_master {
[INFO] [stdout]     |                      ^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]     |
[INFO] [stdout] 223 -             for m in &comp.eeq_master {
[INFO] [stdout] 223 +             while let Some(m) = &comp.eeq_master {
[INFO] [stdout]     |
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]     |
[INFO] [stdout] 223 -             for m in &comp.eeq_master {
[INFO] [stdout] 223 +             if let Some(m) = &comp.eeq_master {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement
[INFO] [stdout]    --> src/def_writer.rs:242:53
[INFO] [stdout]     |
[INFO] [stdout] 242 |             for (soft, left, bottom, right, top) in &comp.halo {
[INFO] [stdout]     |                                                     ^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]     |
[INFO] [stdout] 242 -             for (soft, left, bottom, right, top) in &comp.halo {
[INFO] [stdout] 242 +             while let Some((soft, left, bottom, right, top)) = &comp.halo {
[INFO] [stdout]     |
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]     |
[INFO] [stdout] 242 -             for (soft, left, bottom, right, top) in &comp.halo {
[INFO] [stdout] 242 +             if let Some((soft, left, bottom, right, top)) = &comp.halo {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement
[INFO] [stdout]    --> src/def_writer.rs:250:49
[INFO] [stdout]     |
[INFO] [stdout] 250 |             for (dist, min_layer, max_layer) in &comp.route_halo {
[INFO] [stdout]     |                                                 ^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]     |
[INFO] [stdout] 250 -             for (dist, min_layer, max_layer) in &comp.route_halo {
[INFO] [stdout] 250 +             while let Some((dist, min_layer, max_layer)) = &comp.route_halo {
[INFO] [stdout]     |
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]     |
[INFO] [stdout] 250 -             for (dist, min_layer, max_layer) in &comp.route_halo {
[INFO] [stdout] 250 +             if let Some((dist, min_layer, max_layer)) = &comp.route_halo {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement
[INFO] [stdout]    --> src/def_writer.rs:260:22
[INFO] [stdout]     |
[INFO] [stdout] 260 |             for r in &comp.region {
[INFO] [stdout]     |                      ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]     |
[INFO] [stdout] 260 -             for r in &comp.region {
[INFO] [stdout] 260 +             while let Some(r) = &comp.region {
[INFO] [stdout]     |
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]     |
[INFO] [stdout] 260 -             for r in &comp.region {
[INFO] [stdout] 260 +             if let Some(r) = &comp.region {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr] error: could not compile `libreda-lefdef` (lib test) due to 2 previous errors; 8 warnings emitted
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: could not compile `libreda-lefdef` (lib) due to 2 previous errors; 8 warnings emitted
[INFO] running `Command { std: "docker" "inspect" "e6cbb0b73817f4d4be9252a2c0e19b21074dc8b454abda2e4597938765adcc73", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "e6cbb0b73817f4d4be9252a2c0e19b21074dc8b454abda2e4597938765adcc73", kill_on_drop: false }`
[INFO] [stdout] e6cbb0b73817f4d4be9252a2c0e19b21074dc8b454abda2e4597938765adcc73
