[INFO] fetching crate classif 0.0.2...
[INFO] checking classif-0.0.2 against a5689b034ad287112f709693384a37f1377eb9cc for pr-129249-3
[INFO] extracting crate classif 0.0.2 into /workspace/builds/worker-3-tc2/source
[INFO] started tweaking crates.io crate classif 0.0.2
[INFO] finished tweaking crates.io crate classif 0.0.2
[INFO] tweaked toml for crates.io crate classif 0.0.2 written to /workspace/builds/worker-3-tc2/source/Cargo.toml
[INFO] validating manifest of crates.io crate classif 0.0.2 on toolchain a5689b034ad287112f709693384a37f1377eb9cc
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]      Locking 3 packages to highest compatible versions
[INFO] [stderr]       Adding num-traits v0.1.43 (available: v0.2.19)
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr] warning: Cargo.toml: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] [stderr] warning: `classif` (manifest) generated 1 warning
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:77db811e55d90add9212f6832c23229e3de5f1c1f9905e8cb07319ea15df73ac" "sleep" "infinity", kill_on_drop: false }`
[INFO] [stdout] 43bc17b8e98cb29d296f9031a724adc2b07717f75edff20057cba5008bb8e2e2
[INFO] running `Command { std: "docker" "start" "43bc17b8e98cb29d296f9031a724adc2b07717f75edff20057cba5008bb8e2e2", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "43bc17b8e98cb29d296f9031a724adc2b07717f75edff20057cba5008bb8e2e2", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "43bc17b8e98cb29d296f9031a724adc2b07717f75edff20057cba5008bb8e2e2" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "43bc17b8e98cb29d296f9031a724adc2b07717f75edff20057cba5008bb8e2e2", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "43bc17b8e98cb29d296f9031a724adc2b07717f75edff20057cba5008bb8e2e2" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stderr] warning: Cargo.toml: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] [stderr] warning: `classif` (manifest) generated 1 warning
[INFO] [stderr]     Checking num-traits v0.1.43
[INFO] [stderr]     Checking classif v0.0.2 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unnecessary parentheses around index expression
[INFO] [stdout]   --> src/jenks.rs:71:16
[INFO] [stdout]    |
[INFO] [stdout] 71 |         kclass[(j - 2)] = n;
[INFO] [stdout]    |                ^     ^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 71 -         kclass[(j - 2)] = n;
[INFO] [stdout] 71 +         kclass[j - 2] = n;
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around index expression
[INFO] [stdout]   --> src/jenks.rs:77:35
[INFO] [stdout]    |
[INFO] [stdout] 77 |         breaks.push(sorted_values[(kclass[i - 1usize] - 1)]);
[INFO] [stdout]    |                                   ^                      ^
[INFO] [stdout]    |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 77 -         breaks.push(sorted_values[(kclass[i - 1usize] - 1)]);
[INFO] [stdout] 77 +         breaks.push(sorted_values[kclass[i - 1usize] - 1]);
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around index expression
[INFO] [stdout]   --> src/jenks.rs:79:31
[INFO] [stdout]    |
[INFO] [stdout] 79 |     breaks.push(sorted_values[(nb_elem - 1)]);
[INFO] [stdout]    |                               ^           ^
[INFO] [stdout]    |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 79 -     breaks.push(sorted_values[(nb_elem - 1)]);
[INFO] [stdout] 79 +     breaks.push(sorted_values[nb_elem - 1]);
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around index expression
[INFO] [stdout]   --> src/jenks.rs:71:16
[INFO] [stdout]    |
[INFO] [stdout] 71 |         kclass[(j - 2)] = n;
[INFO] [stdout]    |                ^     ^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 71 -         kclass[(j - 2)] = n;
[INFO] [stdout] 71 +         kclass[j - 2] = n;
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around index expression
[INFO] [stdout]   --> src/jenks.rs:77:35
[INFO] [stdout]    |
[INFO] [stdout] 77 |         breaks.push(sorted_values[(kclass[i - 1usize] - 1)]);
[INFO] [stdout]    |                                   ^                      ^
[INFO] [stdout]    |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 77 -         breaks.push(sorted_values[(kclass[i - 1usize] - 1)]);
[INFO] [stdout] 77 +         breaks.push(sorted_values[kclass[i - 1usize] - 1]);
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around index expression
[INFO] [stdout]   --> src/jenks.rs:79:31
[INFO] [stdout]    |
[INFO] [stdout] 79 |     breaks.push(sorted_values[(nb_elem - 1)]);
[INFO] [stdout]    |                               ^           ^
[INFO] [stdout]    |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 79 -     breaks.push(sorted_values[(nb_elem - 1)]);
[INFO] [stdout] 79 +     breaks.push(sorted_values[nb_elem - 1]);
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable does not need to be mutable
[INFO] [stdout]   --> src/jenks.rs:25:13
[INFO] [stdout]    |
[INFO] [stdout] 25 |         let mut v = unsafe { self.values.get_unchecked_mut(ix.0 * self.dim + ix.1) };
[INFO] [stdout]    |             ----^
[INFO] [stdout]    |             |
[INFO] [stdout]    |             help: remove this `mut`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: useless conversion to the same type: `&str`
[INFO] [stdout]   --> src/classif.rs:80:24
[INFO] [stdout]    |
[INFO] [stdout] 80 |             return Err("Too small number of values!".into());
[INFO] [stdout]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout]    = note: `#[deny(self_type_conversion)]` on by default
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]    |
[INFO] [stdout] 80 -             return Err("Too small number of values!".into());
[INFO] [stdout] 80 +             return Err("Too small number of values!");
[INFO] [stdout]    |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]    |
[INFO] [stdout] 80 -             return Err("Too small number of values!".into());
[INFO] [stdout] 80 +             return Err(<&str as Into<_>>::into("Too small number of values!"));
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused return value of `collect` that must be used
[INFO] [stdout]  --> src/stats.rs:8:5
[INFO] [stdout]   |
[INFO] [stdout] 8 |     values.iter().map(|v| sum += *v).collect::<Vec<_>>();
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead
[INFO] [stdout]   = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] help: use `let _ = ...` to ignore the resulting value
[INFO] [stdout]   |
[INFO] [stdout] 8 |     let _ = values.iter().map(|v| sum += *v).collect::<Vec<_>>();
[INFO] [stdout]   |     +++++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable does not need to be mutable
[INFO] [stdout]   --> src/jenks.rs:25:13
[INFO] [stdout]    |
[INFO] [stdout] 25 |         let mut v = unsafe { self.values.get_unchecked_mut(ix.0 * self.dim + ix.1) };
[INFO] [stdout]    |             ----^
[INFO] [stdout]    |             |
[INFO] [stdout]    |             help: remove this `mut`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr] error: could not compile `classif` (lib) due to 1 previous error; 5 warnings emitted
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stdout] error: useless conversion to the same type: `&str`
[INFO] [stdout]   --> src/classif.rs:80:24
[INFO] [stdout]    |
[INFO] [stdout] 80 |             return Err("Too small number of values!".into());
[INFO] [stdout]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout]    = note: `#[deny(self_type_conversion)]` on by default
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]    |
[INFO] [stdout] 80 -             return Err("Too small number of values!".into());
[INFO] [stdout] 80 +             return Err("Too small number of values!");
[INFO] [stdout]    |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]    |
[INFO] [stdout] 80 -             return Err("Too small number of values!".into());
[INFO] [stdout] 80 +             return Err(<&str as Into<_>>::into("Too small number of values!"));
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused return value of `collect` that must be used
[INFO] [stdout]  --> src/stats.rs:8:5
[INFO] [stdout]   |
[INFO] [stdout] 8 |     values.iter().map(|v| sum += *v).collect::<Vec<_>>();
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead
[INFO] [stdout]   = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] help: use `let _ = ...` to ignore the resulting value
[INFO] [stdout]   |
[INFO] [stdout] 8 |     let _ = values.iter().map(|v| sum += *v).collect::<Vec<_>>();
[INFO] [stdout]   |     +++++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr] error: could not compile `classif` (lib test) due to 1 previous error; 5 warnings emitted
[INFO] running `Command { std: "docker" "inspect" "43bc17b8e98cb29d296f9031a724adc2b07717f75edff20057cba5008bb8e2e2", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "43bc17b8e98cb29d296f9031a724adc2b07717f75edff20057cba5008bb8e2e2", kill_on_drop: false }`
[INFO] [stdout] 43bc17b8e98cb29d296f9031a724adc2b07717f75edff20057cba5008bb8e2e2
