[INFO] cloning repository https://github.com/siddharthborderwala/teddy
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/siddharthborderwala/teddy" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsiddharthborderwala%2Fteddy", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsiddharthborderwala%2Fteddy'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] eb71113f9353f8b5eab398c3a4d81d4c8da1212a
[INFO] checking siddharthborderwala/teddy against a5689b034ad287112f709693384a37f1377eb9cc for pr-129249-3
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsiddharthborderwala%2Fteddy" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/siddharthborderwala/teddy
[INFO] finished tweaking git repo https://github.com/siddharthborderwala/teddy
[INFO] tweaked toml for git repo https://github.com/siddharthborderwala/teddy written to /workspace/builds/worker-4-tc2/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/siddharthborderwala/teddy on toolchain a5689b034ad287112f709693384a37f1377eb9cc
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/siddharthborderwala/teddy already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"`
[INFO] [stderr]   |
[INFO] [stderr]   = note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest
[INFO] [stderr]   = note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest
[INFO] [stderr]   = note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:77db811e55d90add9212f6832c23229e3de5f1c1f9905e8cb07319ea15df73ac" "sleep" "infinity", kill_on_drop: false }`
[INFO] [stdout] 114f4506b8f95d0f09394692532b5653dc22b79a4914c6d6c52e2cfb3abd4b36
[INFO] running `Command { std: "docker" "start" "114f4506b8f95d0f09394692532b5653dc22b79a4914c6d6c52e2cfb3abd4b36", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "114f4506b8f95d0f09394692532b5653dc22b79a4914c6d6c52e2cfb3abd4b36", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "114f4506b8f95d0f09394692532b5653dc22b79a4914c6d6c52e2cfb3abd4b36" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "114f4506b8f95d0f09394692532b5653dc22b79a4914c6d6c52e2cfb3abd4b36", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "114f4506b8f95d0f09394692532b5653dc22b79a4914c6d6c52e2cfb3abd4b36" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"`
[INFO] [stderr]   |
[INFO] [stderr]   = note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest
[INFO] [stderr]   = note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest
[INFO] [stderr]   = note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions
[INFO] [stderr]    Compiling proc-macro2 v1.0.37
[INFO] [stderr]    Compiling syn v1.0.91
[INFO] [stderr]    Compiling rustversion v1.0.6
[INFO] [stderr]    Compiling heck v0.4.0
[INFO] [stderr]     Checking strum v0.24.0
[INFO] [stderr]    Compiling quote v1.0.18
[INFO] [stderr]    Compiling strum_macros v0.24.0
[INFO] [stderr]     Checking teddy-rs v0.1.0 (/opt/rustwide/workdir/teddy-rs)
[INFO] [stdout] error: useless conversion to the same type: `&str`
[INFO] [stdout]   --> teddy-rs/src/teddy.rs:30:18
[INFO] [stdout]    |
[INFO] [stdout] 30 |             .get(key.into())
[INFO] [stdout]    |                  ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout]    = note: `#[deny(self_type_conversion)]` on by default
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]    |
[INFO] [stdout] 30 -             .get(key.into())
[INFO] [stdout] 30 +             .get(key)
[INFO] [stdout]    |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]    |
[INFO] [stdout] 30 -             .get(key.into())
[INFO] [stdout] 30 +             .get(<&str as Into<_>>::into(key))
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: useless conversion to the same type: `&str`
[INFO] [stdout]   --> teddy-rs/src/teddy.rs:37:31
[INFO] [stdout]    |
[INFO] [stdout] 37 |         self.map.contains_key(key.into())
[INFO] [stdout]    |                               ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]    |
[INFO] [stdout] 37 -         self.map.contains_key(key.into())
[INFO] [stdout] 37 +         self.map.contains_key(key)
[INFO] [stdout]    |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]    |
[INFO] [stdout] 37 -         self.map.contains_key(key.into())
[INFO] [stdout] 37 +         self.map.contains_key(<&str as Into<_>>::into(key))
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: useless conversion to the same type: `&str`
[INFO] [stdout]   --> teddy-rs/src/teddy.rs:42:25
[INFO] [stdout]    |
[INFO] [stdout] 42 |         self.map.remove(key.into()).ok_or(format!(
[INFO] [stdout]    |                         ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]    |
[INFO] [stdout] 42 -         self.map.remove(key.into()).ok_or(format!(
[INFO] [stdout] 42 +         self.map.remove(key).ok_or(format!(
[INFO] [stdout]    |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]    |
[INFO] [stdout] 42 -         self.map.remove(key.into()).ok_or(format!(
[INFO] [stdout] 42 +         self.map.remove(<&str as Into<_>>::into(key)).ok_or(format!(
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]   --> teddy-rs/src/query.rs:46:48
[INFO] [stdout]    |
[INFO] [stdout] 46 |         String::from(self.original_query_string.clone())
[INFO] [stdout]    |                                                ^^^^^^^^ help: remove this redundant call
[INFO] [stdout]    |
[INFO] [stdout]    = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed
[INFO] [stdout]    = note: `#[warn(noop_method_call)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr] error: could not compile `teddy-rs` (lib) due to 3 previous errors; 1 warning emitted
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stdout] error: useless conversion to the same type: `&str`
[INFO] [stdout]   --> teddy-rs/src/teddy.rs:30:18
[INFO] [stdout]    |
[INFO] [stdout] 30 |             .get(key.into())
[INFO] [stdout]    |                  ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout]    = note: `#[deny(self_type_conversion)]` on by default
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]    |
[INFO] [stdout] 30 -             .get(key.into())
[INFO] [stdout] 30 +             .get(key)
[INFO] [stdout]    |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]    |
[INFO] [stdout] 30 -             .get(key.into())
[INFO] [stdout] 30 +             .get(<&str as Into<_>>::into(key))
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: useless conversion to the same type: `&str`
[INFO] [stdout]   --> teddy-rs/src/teddy.rs:37:31
[INFO] [stdout]    |
[INFO] [stdout] 37 |         self.map.contains_key(key.into())
[INFO] [stdout]    |                               ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]    |
[INFO] [stdout] 37 -         self.map.contains_key(key.into())
[INFO] [stdout] 37 +         self.map.contains_key(key)
[INFO] [stdout]    |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]    |
[INFO] [stdout] 37 -         self.map.contains_key(key.into())
[INFO] [stdout] 37 +         self.map.contains_key(<&str as Into<_>>::into(key))
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: useless conversion to the same type: `&str`
[INFO] [stdout]   --> teddy-rs/src/teddy.rs:42:25
[INFO] [stdout]    |
[INFO] [stdout] 42 |         self.map.remove(key.into()).ok_or(format!(
[INFO] [stdout]    |                         ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]    |
[INFO] [stdout] 42 -         self.map.remove(key.into()).ok_or(format!(
[INFO] [stdout] 42 +         self.map.remove(key).ok_or(format!(
[INFO] [stdout]    |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]    |
[INFO] [stdout] 42 -         self.map.remove(key.into()).ok_or(format!(
[INFO] [stdout] 42 +         self.map.remove(<&str as Into<_>>::into(key)).ok_or(format!(
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]   --> teddy-rs/src/query.rs:46:48
[INFO] [stdout]    |
[INFO] [stdout] 46 |         String::from(self.original_query_string.clone())
[INFO] [stdout]    |                                                ^^^^^^^^ help: remove this redundant call
[INFO] [stdout]    |
[INFO] [stdout]    = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed
[INFO] [stdout]    = note: `#[warn(noop_method_call)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr] error: could not compile `teddy-rs` (lib test) due to 3 previous errors; 1 warning emitted
[INFO] running `Command { std: "docker" "inspect" "114f4506b8f95d0f09394692532b5653dc22b79a4914c6d6c52e2cfb3abd4b36", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "114f4506b8f95d0f09394692532b5653dc22b79a4914c6d6c52e2cfb3abd4b36", kill_on_drop: false }`
[INFO] [stdout] 114f4506b8f95d0f09394692532b5653dc22b79a4914c6d6c52e2cfb3abd4b36
