[INFO] cloning repository https://github.com/shafiquejamal/rust-coding-practice
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/shafiquejamal/rust-coding-practice" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fshafiquejamal%2Frust-coding-practice", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fshafiquejamal%2Frust-coding-practice'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 5576137b21ec1db8f3824bdfe6c4faf360c6aaaa
[INFO] checking shafiquejamal/rust-coding-practice against a5689b034ad287112f709693384a37f1377eb9cc for pr-129249-3
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fshafiquejamal%2Frust-coding-practice" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/shafiquejamal/rust-coding-practice
[INFO] finished tweaking git repo https://github.com/shafiquejamal/rust-coding-practice
[INFO] tweaked toml for git repo https://github.com/shafiquejamal/rust-coding-practice written to /workspace/builds/worker-7-tc2/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/shafiquejamal/rust-coding-practice on toolchain a5689b034ad287112f709693384a37f1377eb9cc
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/shafiquejamal/rust-coding-practice already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:77db811e55d90add9212f6832c23229e3de5f1c1f9905e8cb07319ea15df73ac" "sleep" "infinity", kill_on_drop: false }`
[INFO] [stdout] 680d34577323491c5c81a2a9256c6e57b69833575282c0849739f51177bccf5e
[INFO] running `Command { std: "docker" "start" "680d34577323491c5c81a2a9256c6e57b69833575282c0849739f51177bccf5e", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "680d34577323491c5c81a2a9256c6e57b69833575282c0849739f51177bccf5e", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "680d34577323491c5c81a2a9256c6e57b69833575282c0849739f51177bccf5e" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "680d34577323491c5c81a2a9256c6e57b69833575282c0849739f51177bccf5e", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "680d34577323491c5c81a2a9256c6e57b69833575282c0849739f51177bccf5e" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stderr]     Checking playground1 v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: variable does not need to be mutable
[INFO] [stdout]  --> src/p_refs1.rs:4:9
[INFO] [stdout]   |
[INFO] [stdout] 4 |     let mut set: HashSet<&str> = HashSet::new();
[INFO] [stdout]   |         ----^^^
[INFO] [stdout]   |         |
[INFO] [stdout]   |         help: remove this `mut`
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `set`
[INFO] [stdout]  --> src/p_refs1.rs:4:9
[INFO] [stdout]   |
[INFO] [stdout] 4 |     let mut set: HashSet<&str> = HashSet::new();
[INFO] [stdout]   |         ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_set`
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `t`
[INFO] [stdout]  --> src/p_refs1.rs:9:39
[INFO] [stdout]   |
[INFO] [stdout] 9 |             Some(next_targets) => for t in *next_targets {},
[INFO] [stdout]   |                                       ^ help: if this is intentional, prefix it with an underscore: `_t`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable does not need to be mutable
[INFO] [stdout]   --> src/sg_anagrams.rs:15:17
[INFO] [stdout]    |
[INFO] [stdout] 15 |             let mut count: &mut u32 = a_map.get_mut(&c).unwrap_or(&mut default);
[INFO] [stdout]    |                 ----^^^^^
[INFO] [stdout]    |                 |
[INFO] [stdout]    |                 help: remove this `mut`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `i`
[INFO] [stdout]  --> src/sg_reversestring.rs:5:9
[INFO] [stdout]   |
[INFO] [stdout] 5 |     for i in 0..=last_index {
[INFO] [stdout]   |         ^ help: if this is intentional, prefix it with an underscore: `_i`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable does not need to be mutable
[INFO] [stdout]  --> src/p_refs1.rs:4:9
[INFO] [stdout]   |
[INFO] [stdout] 4 |     let mut set: HashSet<&str> = HashSet::new();
[INFO] [stdout]   |         ----^^^
[INFO] [stdout]   |         |
[INFO] [stdout]   |         help: remove this `mut`
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `set`
[INFO] [stdout]  --> src/p_refs1.rs:4:9
[INFO] [stdout]   |
[INFO] [stdout] 4 |     let mut set: HashSet<&str> = HashSet::new();
[INFO] [stdout]   |         ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_set`
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `recurse` is never used
[INFO] [stdout]  --> src/p_refs1.rs:6:8
[INFO] [stdout]   |
[INFO] [stdout] 6 |     fn recurse<'b>(m: &HashMap<&str, Vec<&'b str>>, new_target: &'b str) {
[INFO] [stdout]   |        ^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `fib_memo` is never used
[INFO] [stdout]   --> src/sg_fibonacci.rs:83:8
[INFO] [stdout]    |
[INFO] [stdout] 83 |     fn fib_memo(n: usize, memo: &mut [Option<usize>]) -> usize {
[INFO] [stdout]    |        ^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `t`
[INFO] [stdout]  --> src/p_refs1.rs:9:39
[INFO] [stdout]   |
[INFO] [stdout] 9 |             Some(next_targets) => for t in *next_targets {},
[INFO] [stdout]   |                                       ^ help: if this is intentional, prefix it with an underscore: `_t`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable does not need to be mutable
[INFO] [stdout]   --> src/sg_anagrams.rs:15:17
[INFO] [stdout]    |
[INFO] [stdout] 15 |             let mut count: &mut u32 = a_map.get_mut(&c).unwrap_or(&mut default);
[INFO] [stdout]    |                 ----^^^^^
[INFO] [stdout]    |                 |
[INFO] [stdout]    |                 help: remove this `mut`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: useless conversion to the same type: `sg_linked_list::linked_list::Node<T>`
[INFO] [stdout]    --> src/sg_linked_list.rs:153:37
[INFO] [stdout]     |
[INFO] [stdout] 153 |             let new_node: Node<T> = Node::new_with(data).into();
[INFO] [stdout]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout]     = note: `#[deny(self_type_conversion)]` on by default
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]     |
[INFO] [stdout] 153 -             let new_node: Node<T> = Node::new_with(data).into();
[INFO] [stdout] 153 +             let new_node: Node<T> = Node::new_with(data);
[INFO] [stdout]     |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]     |
[INFO] [stdout] 153 -             let new_node: Node<T> = Node::new_with(data).into();
[INFO] [stdout] 153 +             let new_node: Node<T> = <sg_linked_list::linked_list::Node<T> as Into<_>>::into(Node::new_with(data));
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: useless conversion to the same type: `Option<Box<sg_linked_list::linked_list::Node<T>>>`
[INFO] [stdout]    --> src/sg_linked_list.rs:222:47
[INFO] [stdout]     |
[INFO] [stdout] 222 |                         node_to_insert.next = the_rest.into();
[INFO] [stdout]     |                                               ^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]     |
[INFO] [stdout] 222 -                         node_to_insert.next = the_rest.into();
[INFO] [stdout] 222 +                         node_to_insert.next = the_rest;
[INFO] [stdout]     |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]     |
[INFO] [stdout] 222 -                         node_to_insert.next = the_rest.into();
[INFO] [stdout] 222 +                         node_to_insert.next = <Option<Box<sg_linked_list::linked_list::Node<T>>> as Into<_>>::into(the_rest);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing
[INFO] [stdout]   --> src/sg_linked_list.rs:56:21
[INFO] [stdout]    |
[INFO] [stdout] 56 |         pub fn iter(&self) -> Iter<T> {
[INFO] [stdout]    |                     ^^^^^     ^^^^^^^ the same lifetime is hidden here
[INFO] [stdout]    |                     |
[INFO] [stdout]    |                     the lifetime is elided here
[INFO] [stdout]    |
[INFO] [stdout]    = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout]    = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
[INFO] [stdout] help: use `'_` for type paths
[INFO] [stdout]    |
[INFO] [stdout] 56 |         pub fn iter(&self) -> Iter<'_, T> {
[INFO] [stdout]    |                                    +++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison is useless due to type limits
[INFO] [stdout]   --> src/sg_linked_list.rs:99:16
[INFO] [stdout]    |
[INFO] [stdout] 99 |             if index < 0 {
[INFO] [stdout]    |                ^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_comparisons)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr] error: could not compile `playground1` (lib) due to 2 previous errors; 9 warnings emitted
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stdout] warning: unused variable: `i`
[INFO] [stdout]  --> src/sg_reversestring.rs:5:9
[INFO] [stdout]   |
[INFO] [stdout] 5 |     for i in 0..=last_index {
[INFO] [stdout]   |         ^ help: if this is intentional, prefix it with an underscore: `_i`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `recurse` is never used
[INFO] [stdout]  --> src/p_refs1.rs:6:8
[INFO] [stdout]   |
[INFO] [stdout] 6 |     fn recurse<'b>(m: &HashMap<&str, Vec<&'b str>>, new_target: &'b str) {
[INFO] [stdout]   |        ^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `no_rec_depth1` is never used
[INFO] [stdout]   --> src/p_refs1.rs:22:8
[INFO] [stdout]    |
[INFO] [stdout] 22 |     fn no_rec_depth1() {
[INFO] [stdout]    |        ^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `no_rec_depth2` is never used
[INFO] [stdout]   --> src/p_refs1.rs:31:8
[INFO] [stdout]    |
[INFO] [stdout] 31 |     fn no_rec_depth2() {
[INFO] [stdout]    |        ^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `fib_memo` is never used
[INFO] [stdout]   --> src/sg_fibonacci.rs:83:8
[INFO] [stdout]    |
[INFO] [stdout] 83 |     fn fib_memo(n: usize, memo: &mut [Option<usize>]) -> usize {
[INFO] [stdout]    |        ^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `can_weave` is never used
[INFO] [stdout]   --> src/sg_queue.rs:72:8
[INFO] [stdout]    |
[INFO] [stdout] 72 |     fn can_weave() {
[INFO] [stdout]    |        ^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: useless conversion to the same type: `sg_linked_list::linked_list::Node<T>`
[INFO] [stdout]    --> src/sg_linked_list.rs:153:37
[INFO] [stdout]     |
[INFO] [stdout] 153 |             let new_node: Node<T> = Node::new_with(data).into();
[INFO] [stdout]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout]     = note: `#[deny(self_type_conversion)]` on by default
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]     |
[INFO] [stdout] 153 -             let new_node: Node<T> = Node::new_with(data).into();
[INFO] [stdout] 153 +             let new_node: Node<T> = Node::new_with(data);
[INFO] [stdout]     |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]     |
[INFO] [stdout] 153 -             let new_node: Node<T> = Node::new_with(data).into();
[INFO] [stdout] 153 +             let new_node: Node<T> = <sg_linked_list::linked_list::Node<T> as Into<_>>::into(Node::new_with(data));
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: useless conversion to the same type: `Option<Box<sg_linked_list::linked_list::Node<T>>>`
[INFO] [stdout]    --> src/sg_linked_list.rs:222:47
[INFO] [stdout]     |
[INFO] [stdout] 222 |                         node_to_insert.next = the_rest.into();
[INFO] [stdout]     |                                               ^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]     |
[INFO] [stdout] 222 -                         node_to_insert.next = the_rest.into();
[INFO] [stdout] 222 +                         node_to_insert.next = the_rest;
[INFO] [stdout]     |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]     |
[INFO] [stdout] 222 -                         node_to_insert.next = the_rest.into();
[INFO] [stdout] 222 +                         node_to_insert.next = <Option<Box<sg_linked_list::linked_list::Node<T>>> as Into<_>>::into(the_rest);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing
[INFO] [stdout]   --> src/sg_linked_list.rs:56:21
[INFO] [stdout]    |
[INFO] [stdout] 56 |         pub fn iter(&self) -> Iter<T> {
[INFO] [stdout]    |                     ^^^^^     ^^^^^^^ the same lifetime is hidden here
[INFO] [stdout]    |                     |
[INFO] [stdout]    |                     the lifetime is elided here
[INFO] [stdout]    |
[INFO] [stdout]    = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout]    = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
[INFO] [stdout] help: use `'_` for type paths
[INFO] [stdout]    |
[INFO] [stdout] 56 |         pub fn iter(&self) -> Iter<'_, T> {
[INFO] [stdout]    |                                    +++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison is useless due to type limits
[INFO] [stdout]   --> src/sg_linked_list.rs:99:16
[INFO] [stdout]    |
[INFO] [stdout] 99 |             if index < 0 {
[INFO] [stdout]    |                ^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_comparisons)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr] error: could not compile `playground1` (lib test) due to 2 previous errors; 12 warnings emitted
[INFO] running `Command { std: "docker" "inspect" "680d34577323491c5c81a2a9256c6e57b69833575282c0849739f51177bccf5e", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "680d34577323491c5c81a2a9256c6e57b69833575282c0849739f51177bccf5e", kill_on_drop: false }`
[INFO] [stdout] 680d34577323491c5c81a2a9256c6e57b69833575282c0849739f51177bccf5e
