[INFO] cloning repository https://github.com/mikerhodes/toykv
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/mikerhodes/toykv" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmikerhodes%2Ftoykv", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmikerhodes%2Ftoykv'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 3bcc37c241f09df3aa1e6b12ea166e4a68070536
[INFO] checking mikerhodes/toykv against a5689b034ad287112f709693384a37f1377eb9cc for pr-129249-3
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmikerhodes%2Ftoykv" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/mikerhodes/toykv
[INFO] finished tweaking git repo https://github.com/mikerhodes/toykv
[INFO] tweaked toml for git repo https://github.com/mikerhodes/toykv written to /workspace/builds/worker-6-tc2/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/mikerhodes/toykv on toolchain a5689b034ad287112f709693384a37f1377eb9cc
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/mikerhodes/toykv already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:77db811e55d90add9212f6832c23229e3de5f1c1f9905e8cb07319ea15df73ac" "sleep" "infinity", kill_on_drop: false }`
[INFO] [stdout] 18ac0bae572d1d9360dbf3aab6edcde88a2fa9fce2612cad026f3c69c3469d27
[INFO] running `Command { std: "docker" "start" "18ac0bae572d1d9360dbf3aab6edcde88a2fa9fce2612cad026f3c69c3469d27", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "18ac0bae572d1d9360dbf3aab6edcde88a2fa9fce2612cad026f3c69c3469d27", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "18ac0bae572d1d9360dbf3aab6edcde88a2fa9fce2612cad026f3c69c3469d27" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "18ac0bae572d1d9360dbf3aab6edcde88a2fa9fce2612cad026f3c69c3469d27", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "18ac0bae572d1d9360dbf3aab6edcde88a2fa9fce2612cad026f3c69c3469d27" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stderr]    Compiling libc v0.2.186
[INFO] [stderr]     Checking fastrange-rs v0.1.0
[INFO] [stderr]    Compiling serde_json v1.0.150
[INFO] [stderr]     Checking memchr v2.8.2
[INFO] [stderr]     Checking aliasable v0.1.3
[INFO] [stderr]     Checking xxhash-rust v0.8.15
[INFO] [stderr]     Checking once_cell v1.21.4
[INFO] [stderr]    Compiling syn v2.0.118
[INFO] [stderr]     Checking rustix v1.1.4
[INFO] [stderr]     Checking crossbeam-skiplist v0.1.3
[INFO] [stderr]     Checking sbbf-rs v0.2.8
[INFO] [stderr]     Checking sbbf-rs-safe v0.3.2
[INFO] [stderr]     Checking getrandom v0.4.2
[INFO] [stderr]     Checking tempfile v3.27.0
[INFO] [stderr]    Compiling proc-macro2-diagnostics v0.10.1
[INFO] [stderr]    Compiling serde_derive v1.0.228
[INFO] [stderr]    Compiling ouroboros_macro v0.18.5
[INFO] [stderr]     Checking ouroboros v0.18.5
[INFO] [stderr]     Checking serde v1.0.228
[INFO] [stderr]     Checking toykv v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] error: useless conversion to the same type: `ToyKVError`
[INFO] [stdout]    --> src/concat_iterator.rs:125:37
[INFO] [stdout]     |
[INFO] [stdout] 125 |                     return Some(Err(e.into()));
[INFO] [stdout]     |                                     ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout]     = note: `#[deny(self_type_conversion)]` on by default
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]     |
[INFO] [stdout] 125 -                     return Some(Err(e.into()));
[INFO] [stdout] 125 +                     return Some(Err(e));
[INFO] [stdout]     |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]     |
[INFO] [stdout] 125 -                     return Some(Err(e.into()));
[INFO] [stdout] 125 +                     return Some(Err(<ToyKVError as Into<_>>::into(e)));
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: useless conversion to the same type: `ToyKVError`
[INFO] [stdout]    --> src/merge_iterator2.rs:166:37
[INFO] [stdout]     |
[INFO] [stdout] 166 |                     return Some(Err(x.into()));
[INFO] [stdout]     |                                     ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]     |
[INFO] [stdout] 166 -                     return Some(Err(x.into()));
[INFO] [stdout] 166 +                     return Some(Err(x));
[INFO] [stdout]     |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]     |
[INFO] [stdout] 166 -                     return Some(Err(x.into()));
[INFO] [stdout] 166 +                     return Some(Err(<ToyKVError as Into<_>>::into(x)));
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: useless conversion to the same type: `ToyKVError`
[INFO] [stdout]    --> src/table.rs:312:44
[INFO] [stdout]     |
[INFO] [stdout] 312 |                 Some(Err(x)) => return Err(x.into()),
[INFO] [stdout]     |                                            ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]     |
[INFO] [stdout] 312 -                 Some(Err(x)) => return Err(x.into()),
[INFO] [stdout] 312 +                 Some(Err(x)) => return Err(x),
[INFO] [stdout]     |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]     |
[INFO] [stdout] 312 -                 Some(Err(x)) => return Err(x.into()),
[INFO] [stdout] 312 +                 Some(Err(x)) => return Err(<ToyKVError as Into<_>>::into(x)),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr] error: could not compile `toykv` (lib) due to 3 previous errors
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stdout] error: useless conversion to the same type: `Vec<u8>`
[INFO] [stdout]    --> src/compaction/compaction_v4_test.rs:652:28
[INFO] [stdout]     |
[INFO] [stdout] 652 |         match write_kv(db, k.clone().into(), v_len) {
[INFO] [stdout]     |                            ^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout]     = note: `#[deny(self_type_conversion)]` on by default
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]     |
[INFO] [stdout] 652 -         match write_kv(db, k.clone().into(), v_len) {
[INFO] [stdout] 652 +         match write_kv(db, k.clone(), v_len) {
[INFO] [stdout]     |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]     |
[INFO] [stdout] 652 -         match write_kv(db, k.clone().into(), v_len) {
[INFO] [stdout] 652 +         match write_kv(db, <Vec<u8> as Into<_>>::into(k.clone()), v_len) {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: useless conversion to the same type: `Vec<u8>`
[INFO] [stdout]    --> src/compaction/compaction_v4_test.rs:656:30
[INFO] [stdout]     |
[INFO] [stdout] 656 |                 write_kv(db, k.into(), v_len)
[INFO] [stdout]     |                              ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]     |
[INFO] [stdout] 656 -                 write_kv(db, k.into(), v_len)
[INFO] [stdout] 656 +                 write_kv(db, k, v_len)
[INFO] [stdout]     |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]     |
[INFO] [stdout] 656 -                 write_kv(db, k.into(), v_len)
[INFO] [stdout] 656 +                 write_kv(db, <Vec<u8> as Into<_>>::into(k), v_len)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: useless conversion to the same type: `error::ToyKVError`
[INFO] [stdout]    --> src/concat_iterator.rs:125:37
[INFO] [stdout]     |
[INFO] [stdout] 125 |                     return Some(Err(e.into()));
[INFO] [stdout]     |                                     ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]     |
[INFO] [stdout] 125 -                     return Some(Err(e.into()));
[INFO] [stdout] 125 +                     return Some(Err(e));
[INFO] [stdout]     |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]     |
[INFO] [stdout] 125 -                     return Some(Err(e.into()));
[INFO] [stdout] 125 +                     return Some(Err(<error::ToyKVError as Into<_>>::into(e)));
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: useless conversion to the same type: `error::ToyKVError`
[INFO] [stdout]    --> src/merge_iterator2.rs:166:37
[INFO] [stdout]     |
[INFO] [stdout] 166 |                     return Some(Err(x.into()));
[INFO] [stdout]     |                                     ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]     |
[INFO] [stdout] 166 -                     return Some(Err(x.into()));
[INFO] [stdout] 166 +                     return Some(Err(x));
[INFO] [stdout]     |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]     |
[INFO] [stdout] 166 -                     return Some(Err(x.into()));
[INFO] [stdout] 166 +                     return Some(Err(<error::ToyKVError as Into<_>>::into(x)));
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: useless conversion to the same type: `error::ToyKVError`
[INFO] [stdout]    --> src/table.rs:312:44
[INFO] [stdout]     |
[INFO] [stdout] 312 |                 Some(Err(x)) => return Err(x.into()),
[INFO] [stdout]     |                                            ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]     |
[INFO] [stdout] 312 -                 Some(Err(x)) => return Err(x.into()),
[INFO] [stdout] 312 +                 Some(Err(x)) => return Err(x),
[INFO] [stdout]     |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]     |
[INFO] [stdout] 312 -                 Some(Err(x)) => return Err(x.into()),
[INFO] [stdout] 312 +                 Some(Err(x)) => return Err(<error::ToyKVError as Into<_>>::into(x)),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: useless conversion to the same type: `kvrecord::KVValue`
[INFO] [stdout]    --> src/table.rs:490:52
[INFO] [stdout]     |
[INFO] [stdout] 490 |                 table_builder.add(key.as_bytes(), &KVValue::Some(value).into());
[INFO] [stdout]     |                                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]     |
[INFO] [stdout] 490 -                 table_builder.add(key.as_bytes(), &KVValue::Some(value).into());
[INFO] [stdout] 490 +                 table_builder.add(key.as_bytes(), &KVValue::Some(value));
[INFO] [stdout]     |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]     |
[INFO] [stdout] 490 -                 table_builder.add(key.as_bytes(), &KVValue::Some(value).into());
[INFO] [stdout] 490 +                 table_builder.add(key.as_bytes(), &<kvrecord::KVValue as Into<_>>::into(KVValue::Some(value)));
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: useless conversion to the same type: `kvrecord::KVValue`
[INFO] [stdout]    --> src/table.rs:674:39
[INFO] [stdout]     |
[INFO] [stdout] 674 |                 .add(key.as_bytes(), &KVValue::Some(value).into())
[INFO] [stdout]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]     |
[INFO] [stdout] 674 -                 .add(key.as_bytes(), &KVValue::Some(value).into())
[INFO] [stdout] 674 +                 .add(key.as_bytes(), &KVValue::Some(value))
[INFO] [stdout]     |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]     |
[INFO] [stdout] 674 -                 .add(key.as_bytes(), &KVValue::Some(value).into())
[INFO] [stdout] 674 +                 .add(key.as_bytes(), &<kvrecord::KVValue as Into<_>>::into(KVValue::Some(value)))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: useless conversion to the same type: `kvrecord::KVValue`
[INFO] [stdout]    --> src/table.rs:772:31
[INFO] [stdout]     |
[INFO] [stdout] 772 |             .add(&large_key, &KVValue::Some(large_value.to_vec()).into())
[INFO] [stdout]     |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]     |
[INFO] [stdout] 772 -             .add(&large_key, &KVValue::Some(large_value.to_vec()).into())
[INFO] [stdout] 772 +             .add(&large_key, &KVValue::Some(large_value.to_vec()))
[INFO] [stdout]     |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]     |
[INFO] [stdout] 772 -             .add(&large_key, &KVValue::Some(large_value.to_vec()).into())
[INFO] [stdout] 772 +             .add(&large_key, &<kvrecord::KVValue as Into<_>>::into(KVValue::Some(large_value.to_vec())))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: useless conversion to the same type: `kvrecord::KVValue`
[INFO] [stdout]    --> src/table.rs:940:29
[INFO] [stdout]     |
[INFO] [stdout] 940 |             .add(&max_key, &KVValue::Some(max_value.to_vec()).into())
[INFO] [stdout]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]     |
[INFO] [stdout] 940 -             .add(&max_key, &KVValue::Some(max_value.to_vec()).into())
[INFO] [stdout] 940 +             .add(&max_key, &KVValue::Some(max_value.to_vec()))
[INFO] [stdout]     |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]     |
[INFO] [stdout] 940 -             .add(&max_key, &KVValue::Some(max_value.to_vec()).into())
[INFO] [stdout] 940 +             .add(&max_key, &<kvrecord::KVValue as Into<_>>::into(KVValue::Some(max_value.to_vec())))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr] error: could not compile `toykv` (lib test) due to 9 previous errors
[INFO] running `Command { std: "docker" "inspect" "18ac0bae572d1d9360dbf3aab6edcde88a2fa9fce2612cad026f3c69c3469d27", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "18ac0bae572d1d9360dbf3aab6edcde88a2fa9fce2612cad026f3c69c3469d27", kill_on_drop: false }`
[INFO] [stdout] 18ac0bae572d1d9360dbf3aab6edcde88a2fa9fce2612cad026f3c69c3469d27
