[INFO] cloning repository https://github.com/duggurd/cli_parser
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/duggurd/cli_parser" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fduggurd%2Fcli_parser", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fduggurd%2Fcli_parser'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 27f944c83146c5a1e67bdc59785bd9857e0d14fa
[INFO] checking duggurd/cli_parser against a5689b034ad287112f709693384a37f1377eb9cc for pr-129249-3
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fduggurd%2Fcli_parser" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/duggurd/cli_parser
[INFO] finished tweaking git repo https://github.com/duggurd/cli_parser
[INFO] tweaked toml for git repo https://github.com/duggurd/cli_parser written to /workspace/builds/worker-5-tc2/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/duggurd/cli_parser on toolchain a5689b034ad287112f709693384a37f1377eb9cc
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/duggurd/cli_parser already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:77db811e55d90add9212f6832c23229e3de5f1c1f9905e8cb07319ea15df73ac" "sleep" "infinity", kill_on_drop: false }`
[INFO] [stdout] a7c34860e5273976e89fb3ede0928997d98c425d734176def8bfca2d8bb96c79
[INFO] running `Command { std: "docker" "start" "a7c34860e5273976e89fb3ede0928997d98c425d734176def8bfca2d8bb96c79", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "a7c34860e5273976e89fb3ede0928997d98c425d734176def8bfca2d8bb96c79", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "a7c34860e5273976e89fb3ede0928997d98c425d734176def8bfca2d8bb96c79" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "a7c34860e5273976e89fb3ede0928997d98c425d734176def8bfca2d8bb96c79", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "a7c34860e5273976e89fb3ede0928997d98c425d734176def8bfca2d8bb96c79" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stderr]     Checking cli_parser v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unused variable: `parse_res`
[INFO] [stdout]    --> src/lib.rs:397:13
[INFO] [stdout]     |
[INFO] [stdout] 397 |         let parse_res = CliParser::from_args(args)
[INFO] [stdout]     |             ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_parse_res`
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `args`
[INFO] [stdout]    --> src/lib.rs:452:13
[INFO] [stdout]     |
[INFO] [stdout] 452 |         let args = args().collect::<Vec<_>>();
[INFO] [stdout]     |             ^^^^ help: if this is intentional, prefix it with an underscore: `_args`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `parse_res`
[INFO] [stdout]    --> src/lib.rs:454:13
[INFO] [stdout]     |
[INFO] [stdout] 454 |         let parse_res = CliParser::<Args>::new()
[INFO] [stdout]     |             ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_parse_res`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: useless conversion to the same type: `String`
[INFO] [stdout]    --> src/lib.rs:100:17
[INFO] [stdout]     |
[INFO] [stdout] 100 |             id: new_id.into(),
[INFO] [stdout]     |                 ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout]     = note: `#[deny(self_type_conversion)]` on by default
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]     |
[INFO] [stdout] 100 -             id: new_id.into(),
[INFO] [stdout] 100 +             id: new_id,
[INFO] [stdout]     |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]     |
[INFO] [stdout] 100 -             id: new_id.into(),
[INFO] [stdout] 100 +             id: <String as Into<_>>::into(new_id),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: useless conversion to the same type: `String`
[INFO] [stdout]    --> src/lib.rs:261:38
[INFO] [stdout]     |
[INFO] [stdout] 261 |             self.parsed_flags.insert(flag_str.into(), parsed_flag);
[INFO] [stdout]     |                                      ^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]     |
[INFO] [stdout] 261 -             self.parsed_flags.insert(flag_str.into(), parsed_flag);
[INFO] [stdout] 261 +             self.parsed_flags.insert(flag_str, parsed_flag);
[INFO] [stdout]     |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]     |
[INFO] [stdout] 261 -             self.parsed_flags.insert(flag_str.into(), parsed_flag);
[INFO] [stdout] 261 +             self.parsed_flags.insert(<String as Into<_>>::into(flag_str), parsed_flag);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: useless conversion to the same type: `String`
[INFO] [stdout]    --> src/lib.rs:273:25
[INFO] [stdout]     |
[INFO] [stdout] 273 |                 .insert(flag_str.into(), parsed_flag);
[INFO] [stdout]     |                         ^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]     |
[INFO] [stdout] 273 -                 .insert(flag_str.into(), parsed_flag);
[INFO] [stdout] 273 +                 .insert(flag_str, parsed_flag);
[INFO] [stdout]     |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]     |
[INFO] [stdout] 273 -                 .insert(flag_str.into(), parsed_flag);
[INFO] [stdout] 273 +                 .insert(<String as Into<_>>::into(flag_str), parsed_flag);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr] error: could not compile `cli_parser` (lib test) due to 3 previous errors; 3 warnings emitted
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stdout] error: useless conversion to the same type: `String`
[INFO] [stdout]    --> src/lib.rs:100:17
[INFO] [stdout]     |
[INFO] [stdout] 100 |             id: new_id.into(),
[INFO] [stdout]     |                 ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout]     = note: `#[deny(self_type_conversion)]` on by default
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]     |
[INFO] [stdout] 100 -             id: new_id.into(),
[INFO] [stdout] 100 +             id: new_id,
[INFO] [stdout]     |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]     |
[INFO] [stdout] 100 -             id: new_id.into(),
[INFO] [stdout] 100 +             id: <String as Into<_>>::into(new_id),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: useless conversion to the same type: `String`
[INFO] [stdout]    --> src/lib.rs:261:38
[INFO] [stdout]     |
[INFO] [stdout] 261 |             self.parsed_flags.insert(flag_str.into(), parsed_flag);
[INFO] [stdout]     |                                      ^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]     |
[INFO] [stdout] 261 -             self.parsed_flags.insert(flag_str.into(), parsed_flag);
[INFO] [stdout] 261 +             self.parsed_flags.insert(flag_str, parsed_flag);
[INFO] [stdout]     |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]     |
[INFO] [stdout] 261 -             self.parsed_flags.insert(flag_str.into(), parsed_flag);
[INFO] [stdout] 261 +             self.parsed_flags.insert(<String as Into<_>>::into(flag_str), parsed_flag);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: useless conversion to the same type: `String`
[INFO] [stdout]    --> src/lib.rs:273:25
[INFO] [stdout]     |
[INFO] [stdout] 273 |                 .insert(flag_str.into(), parsed_flag);
[INFO] [stdout]     |                         ^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]     |
[INFO] [stdout] 273 -                 .insert(flag_str.into(), parsed_flag);
[INFO] [stdout] 273 +                 .insert(flag_str, parsed_flag);
[INFO] [stdout]     |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]     |
[INFO] [stdout] 273 -                 .insert(flag_str.into(), parsed_flag);
[INFO] [stdout] 273 +                 .insert(<String as Into<_>>::into(flag_str), parsed_flag);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr] error: could not compile `cli_parser` (lib) due to 3 previous errors
[INFO] running `Command { std: "docker" "inspect" "a7c34860e5273976e89fb3ede0928997d98c425d734176def8bfca2d8bb96c79", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "a7c34860e5273976e89fb3ede0928997d98c425d734176def8bfca2d8bb96c79", kill_on_drop: false }`
[INFO] [stdout] a7c34860e5273976e89fb3ede0928997d98c425d734176def8bfca2d8bb96c79
