[INFO] cloning repository https://github.com/cherrypaff/refactoring_idiomatic_rust
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/cherrypaff/refactoring_idiomatic_rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcherrypaff%2Frefactoring_idiomatic_rust", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcherrypaff%2Frefactoring_idiomatic_rust'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 8d81c4bb9e673641ad02cf0be6282159b391dbc3
[INFO] checking cherrypaff/refactoring_idiomatic_rust against a5689b034ad287112f709693384a37f1377eb9cc for pr-129249-3
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcherrypaff%2Frefactoring_idiomatic_rust" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/cherrypaff/refactoring_idiomatic_rust
[INFO] finished tweaking git repo https://github.com/cherrypaff/refactoring_idiomatic_rust
[INFO] tweaked toml for git repo https://github.com/cherrypaff/refactoring_idiomatic_rust written to /workspace/builds/worker-1-tc2/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/cherrypaff/refactoring_idiomatic_rust on toolchain a5689b034ad287112f709693384a37f1377eb9cc
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/cherrypaff/refactoring_idiomatic_rust already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:77db811e55d90add9212f6832c23229e3de5f1c1f9905e8cb07319ea15df73ac" "sleep" "infinity", kill_on_drop: false }`
[INFO] [stdout] 9a888c33c66d80ca639749d617e3adee20555906e6d94c8c5672cb8a89140bc8
[INFO] running `Command { std: "docker" "start" "9a888c33c66d80ca639749d617e3adee20555906e6d94c8c5672cb8a89140bc8", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "9a888c33c66d80ca639749d617e3adee20555906e6d94c8c5672cb8a89140bc8", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "9a888c33c66d80ca639749d617e3adee20555906e6d94c8c5672cb8a89140bc8" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "9a888c33c66d80ca639749d617e3adee20555906e6d94c8c5672cb8a89140bc8", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "9a888c33c66d80ca639749d617e3adee20555906e6d94c8c5672cb8a89140bc8" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stderr]     Checking analysis v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: function `quote` is never used
[INFO] [stdout]   --> src/parse.rs:80:4
[INFO] [stdout]    |
[INFO] [stdout] 80 | fn quote(input: &str) -> String {
[INFO] [stdout]    |    ^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: struct `AsIs` is never constructed
[INFO] [stdout]    --> src/parse.rs:144:8
[INFO] [stdout]     |
[INFO] [stdout] 144 | struct AsIs;
[INFO] [stdout]     |        ^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `all3` is never used
[INFO] [stdout]    --> src/parse.rs:337:4
[INFO] [stdout]     |
[INFO] [stdout] 337 | fn all3<A0: Parser, A1: Parser, A2: Parser>(a0: A0, a1: A1, a2: A2) -> All<(A0, A1, A2)> {
[INFO] [stdout]     |    ^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `all4` is never used
[INFO] [stdout]    --> src/parse.rs:362:4
[INFO] [stdout]     |
[INFO] [stdout] 362 | fn all4<A0: Parser, A1: Parser, A2: Parser, A3: Parser>(
[INFO] [stdout]     |    ^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enum `Either` is never used
[INFO] [stdout]    --> src/parse.rs:747:6
[INFO] [stdout]     |
[INFO] [stdout] 747 | enum Either<Left, Right> {
[INFO] [stdout]     |      ^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enum `Status` is never used
[INFO] [stdout]    --> src/parse.rs:753:6
[INFO] [stdout]     |
[INFO] [stdout] 753 | enum Status {
[INFO] [stdout]     |      ^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: struct `I32` is never constructed
[INFO] [stdout]   --> src/parse.rs:49:16
[INFO] [stdout]    |
[INFO] [stdout] 49 |     pub struct I32;
[INFO] [stdout]    |                ^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: struct `AsIs` is never constructed
[INFO] [stdout]    --> src/parse.rs:144:8
[INFO] [stdout]     |
[INFO] [stdout] 144 | struct AsIs;
[INFO] [stdout]     |        ^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `all3` is never used
[INFO] [stdout]    --> src/parse.rs:337:4
[INFO] [stdout]     |
[INFO] [stdout] 337 | fn all3<A0: Parser, A1: Parser, A2: Parser>(a0: A0, a1: A1, a2: A2) -> All<(A0, A1, A2)> {
[INFO] [stdout]     |    ^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `all4` is never used
[INFO] [stdout]    --> src/parse.rs:362:4
[INFO] [stdout]     |
[INFO] [stdout] 362 | fn all4<A0: Parser, A1: Parser, A2: Parser, A3: Parser>(
[INFO] [stdout]     |    ^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enum `Either` is never used
[INFO] [stdout]    --> src/parse.rs:747:6
[INFO] [stdout]     |
[INFO] [stdout] 747 | enum Either<Left, Right> {
[INFO] [stdout]     |      ^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enum `Status` is never used
[INFO] [stdout]    --> src/parse.rs:753:6
[INFO] [stdout]     |
[INFO] [stdout] 753 | enum Status {
[INFO] [stdout]     |      ^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: useless conversion to the same type: `&str`
[INFO] [stdout]     --> src/parse.rs:1566:27
[INFO] [stdout]      |
[INFO] [stdout] 1566 |             delimited(tag("[".into()), stdp::U32, tag("]".into())).parse("[0x32] nice"),
[INFO] [stdout]      |                           ^^^^^^^^^^
[INFO] [stdout]      |
[INFO] [stdout]      = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout]      = note: `#[deny(self_type_conversion)]` on by default
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]      |
[INFO] [stdout] 1566 -             delimited(tag("[".into()), stdp::U32, tag("]".into())).parse("[0x32] nice"),
[INFO] [stdout] 1566 +             delimited(tag("["), stdp::U32, tag("]".into())).parse("[0x32] nice"),
[INFO] [stdout]      |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]      |
[INFO] [stdout] 1566 -             delimited(tag("[".into()), stdp::U32, tag("]".into())).parse("[0x32] nice"),
[INFO] [stdout] 1566 +             delimited(tag(<&str as Into<_>>::into("[")), stdp::U32, tag("]".into())).parse("[0x32] nice"),
[INFO] [stdout]      |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: useless conversion to the same type: `&str`
[INFO] [stdout]     --> src/parse.rs:1566:55
[INFO] [stdout]      |
[INFO] [stdout] 1566 |             delimited(tag("[".into()), stdp::U32, tag("]".into())).parse("[0x32] nice"),
[INFO] [stdout]      |                                                       ^^^^^^^^^^
[INFO] [stdout]      |
[INFO] [stdout]      = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]      |
[INFO] [stdout] 1566 -             delimited(tag("[".into()), stdp::U32, tag("]".into())).parse("[0x32] nice"),
[INFO] [stdout] 1566 +             delimited(tag("[".into()), stdp::U32, tag("]")).parse("[0x32] nice"),
[INFO] [stdout]      |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]      |
[INFO] [stdout] 1566 -             delimited(tag("[".into()), stdp::U32, tag("]".into())).parse("[0x32] nice"),
[INFO] [stdout] 1566 +             delimited(tag("[".into()), stdp::U32, tag(<&str as Into<_>>::into("]"))).parse("[0x32] nice"),
[INFO] [stdout]      |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: useless conversion to the same type: `&str`
[INFO] [stdout]     --> src/parse.rs:1570:27
[INFO] [stdout]      |
[INFO] [stdout] 1570 |             delimited(tag("[".into()), stdp::U32, tag("]")).parse("0x32]"),
[INFO] [stdout]      |                           ^^^^^^^^^^
[INFO] [stdout]      |
[INFO] [stdout]      = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]      |
[INFO] [stdout] 1570 -             delimited(tag("[".into()), stdp::U32, tag("]")).parse("0x32]"),
[INFO] [stdout] 1570 +             delimited(tag("["), stdp::U32, tag("]")).parse("0x32]"),
[INFO] [stdout]      |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]      |
[INFO] [stdout] 1570 -             delimited(tag("[".into()), stdp::U32, tag("]")).parse("0x32]"),
[INFO] [stdout] 1570 +             delimited(tag(<&str as Into<_>>::into("[")), stdp::U32, tag("]")).parse("0x32]"),
[INFO] [stdout]      |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: useless conversion to the same type: `&str`
[INFO] [stdout]     --> src/parse.rs:1574:27
[INFO] [stdout]      |
[INFO] [stdout] 1574 |             delimited(tag("[".into()), stdp::U32, tag("]")).parse("[0x32"),
[INFO] [stdout]      |                           ^^^^^^^^^^
[INFO] [stdout]      |
[INFO] [stdout]      = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]      |
[INFO] [stdout] 1574 -             delimited(tag("[".into()), stdp::U32, tag("]")).parse("[0x32"),
[INFO] [stdout] 1574 +             delimited(tag("["), stdp::U32, tag("]")).parse("[0x32"),
[INFO] [stdout]      |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]      |
[INFO] [stdout] 1574 -             delimited(tag("[".into()), stdp::U32, tag("]")).parse("[0x32"),
[INFO] [stdout] 1574 +             delimited(tag(<&str as Into<_>>::into("[")), stdp::U32, tag("]")).parse("[0x32"),
[INFO] [stdout]      |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr] error: could not compile `analysis` (lib test) due to 4 previous errors; 5 warnings emitted
[INFO] running `Command { std: "docker" "inspect" "9a888c33c66d80ca639749d617e3adee20555906e6d94c8c5672cb8a89140bc8", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "9a888c33c66d80ca639749d617e3adee20555906e6d94c8c5672cb8a89140bc8", kill_on_drop: false }`
[INFO] [stdout] 9a888c33c66d80ca639749d617e3adee20555906e6d94c8c5672cb8a89140bc8
