[INFO] cloning repository https://github.com/LeviathanST/TodoCLI-Rust
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/LeviathanST/TodoCLI-Rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLeviathanST%2FTodoCLI-Rust", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLeviathanST%2FTodoCLI-Rust'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 442d88db0a517a7f8706e28cb9a27d44b426e13d
[INFO] checking LeviathanST/TodoCLI-Rust against a5689b034ad287112f709693384a37f1377eb9cc for pr-129249-3
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLeviathanST%2FTodoCLI-Rust" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/LeviathanST/TodoCLI-Rust
[INFO] finished tweaking git repo https://github.com/LeviathanST/TodoCLI-Rust
[INFO] tweaked toml for git repo https://github.com/LeviathanST/TodoCLI-Rust written to /workspace/builds/worker-4-tc2/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/LeviathanST/TodoCLI-Rust on toolchain a5689b034ad287112f709693384a37f1377eb9cc
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/LeviathanST/TodoCLI-Rust already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:77db811e55d90add9212f6832c23229e3de5f1c1f9905e8cb07319ea15df73ac" "sleep" "infinity", kill_on_drop: false }`
[INFO] [stdout] f434178e020b812db478499e6ca60a20cabca89836fb570209bee87e018b7cb9
[INFO] running `Command { std: "docker" "start" "f434178e020b812db478499e6ca60a20cabca89836fb570209bee87e018b7cb9", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "f434178e020b812db478499e6ca60a20cabca89836fb570209bee87e018b7cb9", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "f434178e020b812db478499e6ca60a20cabca89836fb570209bee87e018b7cb9" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "f434178e020b812db478499e6ca60a20cabca89836fb570209bee87e018b7cb9", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "f434178e020b812db478499e6ca60a20cabca89836fb570209bee87e018b7cb9" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stderr]    Compiling cc v1.0.95
[INFO] [stderr]    Compiling pkg-config v0.3.30
[INFO] [stderr]     Checking log v0.4.21
[INFO] [stderr]    Compiling ncurses v5.101.0
[INFO] [stderr]     Checking pancurses v0.17.0
[INFO] [stderr]     Checking todo v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]  --> src/utils/list.rs:2:8
[INFO] [stdout]   |
[INFO] [stdout] 2 |     if (*list_cur > 0) {
[INFO] [stdout]   |        ^             ^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]   |
[INFO] [stdout] 2 -     if (*list_cur > 0) {
[INFO] [stdout] 2 +     if *list_cur > 0 {
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]  --> src/utils/list.rs:8:8
[INFO] [stdout]   |
[INFO] [stdout] 8 |     if (*list_cur + 1 < list.len()) {
[INFO] [stdout]   |        ^                          ^
[INFO] [stdout]   |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]   |
[INFO] [stdout] 8 -     if (*list_cur + 1 < list.len()) {
[INFO] [stdout] 8 +     if *list_cur + 1 < list.len() {
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]   --> src/utils/list.rs:16:8
[INFO] [stdout]    |
[INFO] [stdout] 16 |     if (list_cur < &mut list.len()) {
[INFO] [stdout]    |        ^                          ^
[INFO] [stdout]    |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 16 -     if (list_cur < &mut list.len()) {
[INFO] [stdout] 16 +     if list_cur < &mut list.len() {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]   --> src/utils/list.rs:19:12
[INFO] [stdout]    |
[INFO] [stdout] 19 |         if (*list_cur > 0) {
[INFO] [stdout]    |            ^             ^
[INFO] [stdout]    |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 19 -         if (*list_cur > 0) {
[INFO] [stdout] 19 +         if *list_cur > 0 {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: useless conversion to the same type: `i16`
[INFO] [stdout]   --> src/ui.rs:34:21
[INFO] [stdout]    |
[INFO] [stdout] 34 |                     HIGHLIGHT_PAIR.into()
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout]    = note: `#[deny(self_type_conversion)]` on by default
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]    |
[INFO] [stdout] 34 -                     HIGHLIGHT_PAIR.into()
[INFO] [stdout] 34 +                     HIGHLIGHT_PAIR
[INFO] [stdout]    |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]    |
[INFO] [stdout] 34 -                     HIGHLIGHT_PAIR.into()
[INFO] [stdout] 34 +                     <i16 as Into<_>>::into(HIGHLIGHT_PAIR)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: useless conversion to the same type: `i16`
[INFO] [stdout]   --> src/ui.rs:36:21
[INFO] [stdout]    |
[INFO] [stdout] 36 |                     REGULAR_PAIR.into()
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]    |
[INFO] [stdout] 36 -                     REGULAR_PAIR.into()
[INFO] [stdout] 36 +                     REGULAR_PAIR
[INFO] [stdout]    |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]    |
[INFO] [stdout] 36 -                     REGULAR_PAIR.into()
[INFO] [stdout] 36 +                     <i16 as Into<_>>::into(REGULAR_PAIR)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]  --> src/utils/list.rs:2:8
[INFO] [stdout]   |
[INFO] [stdout] 2 |     if (*list_cur > 0) {
[INFO] [stdout]   |        ^             ^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]   |
[INFO] [stdout] 2 -     if (*list_cur > 0) {
[INFO] [stdout] 2 +     if *list_cur > 0 {
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]  --> src/utils/list.rs:8:8
[INFO] [stdout]   |
[INFO] [stdout] 8 |     if (*list_cur + 1 < list.len()) {
[INFO] [stdout]   |        ^                          ^
[INFO] [stdout]   |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]   |
[INFO] [stdout] 8 -     if (*list_cur + 1 < list.len()) {
[INFO] [stdout] 8 +     if *list_cur + 1 < list.len() {
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]   --> src/utils/list.rs:16:8
[INFO] [stdout]    |
[INFO] [stdout] 16 |     if (list_cur < &mut list.len()) {
[INFO] [stdout]    |        ^                          ^
[INFO] [stdout]    |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 16 -     if (list_cur < &mut list.len()) {
[INFO] [stdout] 16 +     if list_cur < &mut list.len() {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]   --> src/utils/list.rs:19:12
[INFO] [stdout]    |
[INFO] [stdout] 19 |         if (*list_cur > 0) {
[INFO] [stdout]    |            ^             ^
[INFO] [stdout]    |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 19 -         if (*list_cur > 0) {
[INFO] [stdout] 19 +         if *list_cur > 0 {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr] error: could not compile `todo` (bin "todo" test) due to 2 previous errors; 4 warnings emitted
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stdout] error: useless conversion to the same type: `i16`
[INFO] [stdout]   --> src/ui.rs:34:21
[INFO] [stdout]    |
[INFO] [stdout] 34 |                     HIGHLIGHT_PAIR.into()
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout]    = note: `#[deny(self_type_conversion)]` on by default
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]    |
[INFO] [stdout] 34 -                     HIGHLIGHT_PAIR.into()
[INFO] [stdout] 34 +                     HIGHLIGHT_PAIR
[INFO] [stdout]    |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]    |
[INFO] [stdout] 34 -                     HIGHLIGHT_PAIR.into()
[INFO] [stdout] 34 +                     <i16 as Into<_>>::into(HIGHLIGHT_PAIR)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: useless conversion to the same type: `i16`
[INFO] [stdout]   --> src/ui.rs:36:21
[INFO] [stdout]    |
[INFO] [stdout] 36 |                     REGULAR_PAIR.into()
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: this method call relies on the `impl<T> Into<T> for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors
[INFO] [stdout] help: consider removing the conversion call
[INFO] [stdout]    |
[INFO] [stdout] 36 -                     REGULAR_PAIR.into()
[INFO] [stdout] 36 +                     REGULAR_PAIR
[INFO] [stdout]    |
[INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint
[INFO] [stdout]    |
[INFO] [stdout] 36 -                     REGULAR_PAIR.into()
[INFO] [stdout] 36 +                     <i16 as Into<_>>::into(REGULAR_PAIR)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr] error: could not compile `todo` (bin "todo") due to 2 previous errors; 4 warnings emitted
[INFO] running `Command { std: "docker" "inspect" "f434178e020b812db478499e6ca60a20cabca89836fb570209bee87e018b7cb9", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "f434178e020b812db478499e6ca60a20cabca89836fb570209bee87e018b7cb9", kill_on_drop: false }`
[INFO] [stdout] f434178e020b812db478499e6ca60a20cabca89836fb570209bee87e018b7cb9
