[INFO] cloning repository https://github.com/mobiusklein/mzpeak_prototyping [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/mobiusklein/mzpeak_prototyping" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmobiusklein%2Fmzpeak_prototyping", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmobiusklein%2Fmzpeak_prototyping'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 40c65521dcfdc3d1df22c16f1ef18e6013fc6ef6 [INFO] checking mobiusklein/mzpeak_prototyping against a5689b034ad287112f709693384a37f1377eb9cc for pr-129249-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmobiusklein%2Fmzpeak_prototyping" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/mobiusklein/mzpeak_prototyping [INFO] removed 0 missing examples [INFO] finished tweaking git repo https://github.com/mobiusklein/mzpeak_prototyping [INFO] tweaked toml for git repo https://github.com/mobiusklein/mzpeak_prototyping written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/mobiusklein/mzpeak_prototyping on toolchain a5689b034ad287112f709693384a37f1377eb9cc [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/mobiusklein/mzpeak_prototyping already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:77db811e55d90add9212f6832c23229e3de5f1c1f9905e8cb07319ea15df73ac" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] fb7618b431dc6d938cdc5793249899b092c8ec15fb53dc7356f9dec1b16d9361 [INFO] running `Command { std: "docker" "start" "fb7618b431dc6d938cdc5793249899b092c8ec15fb53dc7356f9dec1b16d9361", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fb7618b431dc6d938cdc5793249899b092c8ec15fb53dc7356f9dec1b16d9361", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "fb7618b431dc6d938cdc5793249899b092c8ec15fb53dc7356f9dec1b16d9361" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fb7618b431dc6d938cdc5793249899b092c8ec15fb53dc7356f9dec1b16d9361", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "fb7618b431dc6d938cdc5793249899b092c8ec15fb53dc7356f9dec1b16d9361" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stderr] Checking hybrid-array v0.4.14 [INFO] [stderr] Checking hashbrown v0.17.1 [INFO] [stderr] Compiling syn v3.0.3 [INFO] [stderr] Compiling cc v1.4.4 [INFO] [stderr] Checking num-integer v0.1.47 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Compiling aws-lc-rs v1.18.0 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking serde_json v1.0.151 [INFO] [stderr] Compiling rustls v0.23.43 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking arrow-schema v57.3.1 [INFO] [stderr] Checking jiff-core v0.1.0 [INFO] [stderr] Checking regex-automata v0.4.18 [INFO] [stderr] Checking uuid v1.25.0 [INFO] [stderr] Checking base64 v0.23.1 [INFO] [stderr] Compiling matrixmultiply v0.3.11 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking num-bigint v0.4.8 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking directories v6.0.0 [INFO] [stderr] Compiling nalgebra-macros v0.2.2 [INFO] [stderr] Checking rustix v1.1.4 [INFO] [stderr] Checking outref v0.5.2 [INFO] [stderr] Checking vsimd v0.8.0 [INFO] [stderr] Compiling siphasher v1.0.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling phf_shared v0.14.0 [INFO] [stderr] Checking serde_with v3.22.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking identity-hash v0.1.0 [INFO] [stderr] Checking indexmap v2.14.0 [INFO] [stderr] Checking mea v0.6.7 [INFO] [stderr] Checking numpress-rs v1.1.1 [INFO] [stderr] Checking crypto-common v0.2.2 [INFO] [stderr] Checking block-buffer v0.12.1 [INFO] [stderr] Checking base64-simd v0.8.0 [INFO] [stderr] Compiling phf_generator v0.14.0 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Compiling portable-atomic v1.15.0 [INFO] [stderr] Checking simdutf8 v0.1.5 [INFO] [stderr] Compiling linktime-proc-macro v0.2.3 [INFO] [stderr] Checking jiff v0.2.35 [INFO] [stderr] Checking digest v0.11.3 [INFO] [stderr] Checking link-section v0.19.3 [INFO] [stderr] Checking hashlink v0.9.1 [INFO] [stderr] Checking sha2 v0.11.0 [INFO] [stderr] Compiling cmake v0.1.58 [INFO] [stderr] Checking sha1 v0.11.0 [INFO] [stderr] Checking hmac v0.13.0 [INFO] [stderr] Checking md-5 v0.11.0 [INFO] [stderr] Compiling phf_macros v0.14.0 [INFO] [stderr] Checking csv v1.4.0 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking rayon v1.12.0 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking ctor v1.0.13 [INFO] [stderr] Checking itertools v0.14.0 [INFO] [stderr] Checking libbz2-rs-sys v0.2.5 [INFO] [stderr] Checking twox-hash v2.1.3 [INFO] [stderr] Checking zopfli v0.8.3 [INFO] [stderr] Checking lz4_flex v0.12.2 [INFO] [stderr] Checking time v0.3.55 [INFO] [stderr] Checking phf v0.14.0 [INFO] [stderr] Compiling aws-lc-sys v0.44.0 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling zstd-sys v2.0.16+zstd.1.5.7 [INFO] [stderr] Compiling libz-sys v1.1.29 [INFO] [stderr] Compiling libsqlite3-sys v0.28.0 [INFO] [stderr] Compiling liblzma-sys v0.4.8 [INFO] [stderr] Checking xattr v1.6.1 [INFO] [stderr] Checking regex v1.13.1 [INFO] [stderr] Checking bzip2 v0.6.1 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking env_filter v2.0.0 [INFO] [stderr] Checking console v0.15.11 [INFO] [stderr] Checking futures-lite v2.6.1 [INFO] [stderr] Compiling toml_edit v0.25.13+spec-1.1.0 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking brotli v8.0.4 [INFO] [stderr] Checking sha1 v0.10.7 [INFO] [stderr] Checking deflate64 v0.1.12 [INFO] [stderr] Compiling displaydoc v0.1.7 [INFO] [stderr] Checking ppmd-rust v1.4.0 [INFO] [stderr] Checking indicatif v0.17.11 [INFO] [stderr] Checking tempfile v3.27.0 [INFO] [stderr] Checking linreg v0.2.0 [INFO] [stderr] Compiling test-log-core v0.2.21 [INFO] [stderr] Compiling serde_arrow v0.13.7 [INFO] [stderr] Compiling proc-macro-crate v3.5.0 [INFO] [stderr] Compiling test-log-macros v0.2.21 [INFO] [stderr] Checking env_logger v0.11.11 [INFO] [stderr] Checking test-log v0.2.21 [INFO] [stderr] Compiling serde_derive v1.0.229 [INFO] [stderr] Compiling bytemuck_derive v1.12.0 [INFO] [stderr] Compiling tokio-macros v2.7.2 [INFO] [stderr] Compiling zerovec-derive v0.11.6 [INFO] [stderr] Compiling displaydoc v0.2.7 [INFO] [stderr] Compiling futures-macro v0.3.34 [INFO] [stderr] Checking tokio v1.53.1 [INFO] [stderr] Checking zerotrie v0.2.5 [INFO] [stderr] Compiling thiserror-impl v2.0.20 [INFO] [stderr] Checking futures-util v0.3.34 [INFO] [stderr] Compiling async-trait v0.1.92 [INFO] [stderr] Compiling clap_derive v4.6.4 [INFO] [stderr] Checking liblzma v0.4.8 [INFO] [stderr] Compiling rstest_macros v0.26.1 [INFO] [stderr] Checking bytemuck v1.25.2 [INFO] [stderr] Checking zerovec v0.11.8 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking safe_arch v0.7.4 [INFO] [stderr] Checking arrow-buffer v57.3.1 [INFO] [stderr] Checking wide v0.7.33 [INFO] [stderr] Checking tinystr v0.8.4 [INFO] [stderr] Checking potential_utf v0.1.6 [INFO] [stderr] Checking icu_locale_core v2.3.0 [INFO] [stderr] Checking icu_collections v2.3.0 [INFO] [stderr] Checking thiserror v2.0.20 [INFO] [stderr] Checking arrow-data v57.3.1 [INFO] [stderr] Checking clap v4.6.6 [INFO] [stderr] Checking serde v1.0.229 [INFO] [stderr] Checking icu_provider v2.3.1 [INFO] [stderr] Compiling zstd-safe v7.2.4 [INFO] [stderr] Checking zstd v0.13.3 [INFO] [stderr] Checking icu_normalizer v2.3.0 [INFO] [stderr] Checking chrono v0.4.45 [INFO] [stderr] Checking icu_properties v2.3.0 [INFO] [stderr] Checking quick-xml v0.39.4 [INFO] [stderr] Checking simba v0.9.1 [INFO] [stderr] Checking bincode v2.0.1 [INFO] [stderr] Checking context_error v0.3.0 [INFO] [stderr] Checking serde-big-array v0.5.1 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking mzpeaks v1.0.9 [INFO] [stderr] Checking futures-executor v0.3.34 [INFO] [stderr] Checking rstest v0.26.1 [INFO] [stderr] Checking arrow-array v57.3.1 [INFO] [stderr] Checking futures v0.3.34 [INFO] [stderr] Checking reqsign-core v3.3.0 [INFO] [stderr] Checking idna_adapter v1.2.2 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking tokio-util v0.7.19 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking backon v1.6.0 [INFO] [stderr] Checking quick-xml v0.41.0 [INFO] [stderr] Checking tokio-stream v0.1.19 [INFO] [stderr] Checking h2 v0.4.18 [INFO] [stderr] Checking tower-http v0.6.11 [INFO] [stderr] Checking async_zip v0.0.18 [INFO] [stderr] Checking rusqlite v0.31.0 [INFO] [stderr] Checking arrow-select v57.3.1 [INFO] [stderr] Checking arrow-row v57.3.1 [INFO] [stderr] Checking arrow-arith v57.3.1 [INFO] [stderr] Checking marrow v0.2.7 [INFO] [stderr] Checking timsrust v0.4.1 [INFO] [stderr] Checking flate2 v1.1.9 [INFO] [stderr] Checking nalgebra v0.33.3 [INFO] [stderr] Checking mzcv v0.3.0 [INFO] [stderr] Checking zip v4.6.1 [INFO] [stderr] Checking arrow-ord v57.3.1 [INFO] [stderr] Checking arrow-ipc v57.3.1 [INFO] [stderr] Checking arrow-string v57.3.1 [INFO] [stderr] Checking mzdata-param v0.67.4 [INFO] [stderr] Checking arrow-cast v57.3.1 [INFO] [stderr] Checking hyper v1.11.0 [INFO] [stderr] Checking hyper-util v0.1.20 [INFO] [stderr] Checking arrow-csv v57.3.1 [INFO] [stderr] Checking arrow-json v57.3.1 [INFO] [stderr] Checking parquet v57.3.1 [INFO] [stderr] Checking arrow v57.3.1 [INFO] [stderr] Checking rustls-webpki v0.103.15 [INFO] [stderr] Checking mzsignal v1.1.12 [INFO] [stderr] Checking mzdata-bindata v0.67.4 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking rustls-platform-verifier v0.7.0 [INFO] [stderr] Checking mzdata-meta v0.67.4 [INFO] [stderr] Checking hyper-rustls v0.27.9 [INFO] [stderr] Checking reqwest v0.13.4 [INFO] [stderr] Checking reqwest v0.12.28 [INFO] [stderr] Checking object_store v0.13.2 [INFO] [stderr] Checking opendal-core v0.57.0 [INFO] [stderr] Checking mzdata-spectrum v0.67.4 [INFO] [stderr] Checking mzdata v0.67.4 [INFO] [stderr] Checking opendal-service-http v0.57.0 [INFO] [stderr] Checking opendal-service-fs v0.57.0 [INFO] [stderr] Checking opendal-layer-retry v0.57.0 [INFO] [stderr] Checking opendal-layer-concurrent-limit v0.57.0 [INFO] [stderr] Checking opendal-layer-timeout v0.57.0 [INFO] [stderr] Checking opendal-layer-logging v0.57.0 [INFO] [stderr] Checking opendal v0.57.0 [INFO] [stderr] Checking object_store_opendal v0.57.0 [INFO] [stderr] Checking mzpeak_prototyping v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: useless conversion to the same type: `mzdata::params::CURIE` [INFO] [stdout] --> src/param.rs:93:48 [INFO] [stdout] | [INFO] [stdout] 93 | Ok(v) => Ok(PathOrCURIE::CURIE(v.into())), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 93 - Ok(v) => Ok(PathOrCURIE::CURIE(v.into())), [INFO] [stdout] 93 + Ok(v) => Ok(PathOrCURIE::CURIE(v)), [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 93 - Ok(v) => Ok(PathOrCURIE::CURIE(v.into())), [INFO] [stdout] 93 + Ok(v) => Ok(PathOrCURIE::CURIE(>::into(v))), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `mzdata::params::CURIE` [INFO] [stdout] --> src/param.rs:150:34 [INFO] [stdout] | [INFO] [stdout] 150 | Ok(v) => Ok(Some(v.into())), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 150 - Ok(v) => Ok(Some(v.into())), [INFO] [stdout] 150 + Ok(v) => Ok(Some(v)), [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 150 - Ok(v) => Ok(Some(v.into())), [INFO] [stdout] 150 + Ok(v) => Ok(Some(>::into(v))), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `mzdata::params::CURIE` [INFO] [stdout] --> src/param.rs:181:29 [INFO] [stdout] | [INFO] [stdout] 181 | Ok(v) => Ok(v.into()), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 181 - Ok(v) => Ok(v.into()), [INFO] [stdout] 181 + Ok(v) => Ok(v), [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 181 - Ok(v) => Ok(v.into()), [INFO] [stdout] 181 + Ok(v) => Ok(>::into(v)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `mzdata::params::CURIE` [INFO] [stdout] --> src/param.rs:221:42 [INFO] [stdout] | [INFO] [stdout] 221 | .map(|acc| Unit::from_curie(&(acc.into()))) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 221 - .map(|acc| Unit::from_curie(&(acc.into()))) [INFO] [stdout] 221 + .map(|acc| Unit::from_curie(&(acc)) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 221 - .map(|acc| Unit::from_curie(&(acc.into()))) [INFO] [stdout] 221 + .map(|acc| Unit::from_curie(&(>::into(acc))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `Vec` [INFO] [stdout] --> src/param.rs:1472:42 [INFO] [stdout] | [INFO] [stdout] 1472 | *node.columns.as_mut() = cols.into(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 1472 - *node.columns.as_mut() = cols.into(); [INFO] [stdout] 1472 + *node.columns.as_mut() = cols; [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 1472 - *node.columns.as_mut() = cols.into(); [INFO] [stdout] 1472 + *node.columns.as_mut() = as Into<_>>::into(cols); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `mzdata::params::CURIE` [INFO] [stdout] --> src/spectrum.rs:55:34 [INFO] [stdout] | [INFO] [stdout] 55 | let acc: CURIE = method_param.curie().unwrap().into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 55 - let acc: CURIE = method_param.curie().unwrap().into(); [INFO] [stdout] 55 + let acc: CURIE = method_param.curie().unwrap(); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 55 - let acc: CURIE = method_param.curie().unwrap().into(); [INFO] [stdout] 55 + let acc: CURIE = >::into(method_param.curie().unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `mzdata::params::CURIE` [INFO] [stdout] --> src/spectrum.rs:70:48 [INFO] [stdout] | [INFO] [stdout] 70 | let dtype_acc: mzdata::params::CURIE = self.data_type.into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 70 - let dtype_acc: mzdata::params::CURIE = self.data_type.into(); [INFO] [stdout] 70 + let dtype_acc: mzdata::params::CURIE = self.data_type; [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 70 - let dtype_acc: mzdata::params::CURIE = self.data_type.into(); [INFO] [stdout] 70 + let dtype_acc: mzdata::params::CURIE = >::into(self.data_type); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `Param` [INFO] [stdout] --> src/spectrum.rs:73:27 [INFO] [stdout] | [INFO] [stdout] 73 | let name: Param = self.name.into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 73 - let name: Param = self.name.into(); [INFO] [stdout] 73 + let name: Param = self.name; [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 73 - let name: Param = self.name.into(); [INFO] [stdout] 73 + let name: Param = >::into(self.name); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `mzdata::params::CURIE` [INFO] [stdout] --> src/spectrum.rs:106:27 [INFO] [stdout] | [INFO] [stdout] 106 | let compression = BinaryCompressionType::NoCompression [INFO] [stdout] | ___________________________^ [INFO] [stdout] 107 | | .as_param() [INFO] [stdout] 108 | | .unwrap() [INFO] [stdout] 109 | | .curie() [INFO] [stdout] 110 | | .unwrap() [INFO] [stdout] 111 | | .into(); [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 110 - .unwrap() [INFO] [stdout] 111 - .into(); [INFO] [stdout] 110 + .unwrap(); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 106 ~ let compression = >::into(BinaryCompressionType::NoCompression [INFO] [stdout] 107 | .as_param() [INFO] [stdout] 108 | .unwrap() [INFO] [stdout] 109 | .curie() [INFO] [stdout] 110 ~ .unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `mzdata::params::CURIE` [INFO] [stdout] --> src/spectrum.rs:113:25 [INFO] [stdout] | [INFO] [stdout] 113 | let data_type = source [INFO] [stdout] | _________________________^ [INFO] [stdout] 114 | | .dtype [INFO] [stdout] 115 | | .curie() [INFO] [stdout] 116 | | .ok_or_else(|| mzdata::spectrum::bindata::ArrayRetrievalError::DataTypeSizeMismatch)? [INFO] [stdout] 117 | | .into(); [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 116 - .ok_or_else(|| mzdata::spectrum::bindata::ArrayRetrievalError::DataTypeSizeMismatch)? [INFO] [stdout] 117 - .into(); [INFO] [stdout] 116 + .ok_or_else(|| mzdata::spectrum::bindata::ArrayRetrievalError::DataTypeSizeMismatch)?; [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 113 ~ let data_type = >::into(source [INFO] [stdout] 114 | .dtype [INFO] [stdout] 115 | .curie() [INFO] [stdout] 116 ~ .ok_or_else(|| mzdata::spectrum::bindata::ArrayRetrievalError::DataTypeSizeMismatch)?); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `mzdata::params::CURIE` [INFO] [stdout] --> src/spectrum.rs:119:51 [INFO] [stdout] | [INFO] [stdout] 119 | let unit = source.unit.to_curie().map(|c| c.into()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 119 - let unit = source.unit.to_curie().map(|c| c.into()); [INFO] [stdout] 119 + let unit = source.unit.to_curie().map(|c| c); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 119 - let unit = source.unit.to_curie().map(|c| c.into()); [INFO] [stdout] 119 + let unit = source.unit.to_curie().map(|c| >::into(c)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `Param` [INFO] [stdout] --> src/spectrum.rs:121:20 [INFO] [stdout] | [INFO] [stdout] 121 | let name = source.name.clone().as_param(Some(source.unit)).into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 121 - let name = source.name.clone().as_param(Some(source.unit)).into(); [INFO] [stdout] 121 + let name = source.name.clone().as_param(Some(source.unit)); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 121 - let name = source.name.clone().as_param(Some(source.unit)).into(); [INFO] [stdout] 121 + let name = >::into(source.name.clone().as_param(Some(source.unit))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `parquet::errors::ParquetError` [INFO] [stdout] --> src/reader/metadata.rs:1542:13 [INFO] [stdout] | [INFO] [stdout] 1542 | Err(parquet::errors::ParquetError::ArrowError(format!( [INFO] [stdout] | _____________^ [INFO] [stdout] 1543 | | "Invalid time array data type: {:?}", [INFO] [stdout] 1544 | | time_arr.data_type() [INFO] [stdout] 1545 | | )) [INFO] [stdout] 1546 | | .into()) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 1545 - )) [INFO] [stdout] 1546 - .into()) [INFO] [stdout] 1545 + ))) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 1542 ~ Err(>::into(parquet::errors::ParquetError::ArrowError(format!( [INFO] [stdout] 1543 | "Invalid time array data type: {:?}", [INFO] [stdout] 1544 | time_arr.data_type() [INFO] [stdout] 1545 ~ )))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `parquet::errors::ParquetError` [INFO] [stdout] --> src/reader/metadata.rs:1606:24 [INFO] [stdout] | [INFO] [stdout] 1606 | return Err(parquet::errors::ParquetError::ArrowError(format!( [INFO] [stdout] | ________________________^ [INFO] [stdout] 1607 | | "Invalid selected ion m/z array data type: {:?}", [INFO] [stdout] 1608 | | selected_mz_arr.data_type() [INFO] [stdout] 1609 | | )) [INFO] [stdout] 1610 | | .into()); [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 1609 - )) [INFO] [stdout] 1610 - .into()); [INFO] [stdout] 1609 + ))); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 1606 ~ return Err(>::into(parquet::errors::ParquetError::ArrowError(format!( [INFO] [stdout] 1607 | "Invalid selected ion m/z array data type: {:?}", [INFO] [stdout] 1608 | selected_mz_arr.data_type() [INFO] [stdout] 1609 ~ )))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `reader::utils::MaskSet` [INFO] [stdout] --> src/reader/point.rs:1081:17 [INFO] [stdout] | [INFO] [stdout] 1081 | index_range.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 1081 - index_range.into(), [INFO] [stdout] 1081 + index_range, [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 1081 - index_range.into(), [INFO] [stdout] 1081 + >::into(index_range), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `EntryMetadataDerivedFromData` [INFO] [stdout] --> src/writer/base.rs:1062:68 [INFO] [stdout] | [INFO] [stdout] 1062 | mzdata::spectrum::RefPeakDataLevel::Centroid(_) => self [INFO] [stdout] | ____________________________________________________________________^ [INFO] [stdout] 1063 | | .get_or_create_spectrum_peak_writer()? [INFO] [stdout] 1064 | | .write_peaks(spectrum_index, spectrum_time, peaks)? [INFO] [stdout] 1065 | | .into(), [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 1064 - .write_peaks(spectrum_index, spectrum_time, peaks)? [INFO] [stdout] 1065 - .into(), [INFO] [stdout] 1064 + .write_peaks(spectrum_index, spectrum_time, peaks)?, [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 1062 ~ mzdata::spectrum::RefPeakDataLevel::Centroid(_) => >::into(self [INFO] [stdout] 1063 | .get_or_create_spectrum_peak_writer()? [INFO] [stdout] 1064 ~ .write_peaks(spectrum_index, spectrum_time, peaks)?), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `EntryMetadataDerivedFromData` [INFO] [stdout] --> src/writer/base.rs:1066:72 [INFO] [stdout] | [INFO] [stdout] 1066 | mzdata::spectrum::RefPeakDataLevel::Deconvoluted(_) => self [INFO] [stdout] | ________________________________________________________________________^ [INFO] [stdout] 1067 | | .get_or_create_spectrum_peak_writer()? [INFO] [stdout] 1068 | | .write_peaks(spectrum_index, spectrum_time, peaks)? [INFO] [stdout] 1069 | | .into(), [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 1068 - .write_peaks(spectrum_index, spectrum_time, peaks)? [INFO] [stdout] 1069 - .into(), [INFO] [stdout] 1068 + .write_peaks(spectrum_index, spectrum_time, peaks)?, [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 1066 ~ mzdata::spectrum::RefPeakDataLevel::Deconvoluted(_) => >::into(self [INFO] [stdout] 1067 | .get_or_create_spectrum_peak_writer()? [INFO] [stdout] 1068 ~ .write_peaks(spectrum_index, spectrum_time, peaks)?), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mzpeak_prototyping` (lib) due to 17 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: useless conversion to the same type: `mzdata::params::CURIE` [INFO] [stdout] --> src/param.rs:93:48 [INFO] [stdout] | [INFO] [stdout] 93 | Ok(v) => Ok(PathOrCURIE::CURIE(v.into())), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 93 - Ok(v) => Ok(PathOrCURIE::CURIE(v.into())), [INFO] [stdout] 93 + Ok(v) => Ok(PathOrCURIE::CURIE(v)), [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 93 - Ok(v) => Ok(PathOrCURIE::CURIE(v.into())), [INFO] [stdout] 93 + Ok(v) => Ok(PathOrCURIE::CURIE(>::into(v))), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `mzdata::params::CURIE` [INFO] [stdout] --> src/param.rs:150:34 [INFO] [stdout] | [INFO] [stdout] 150 | Ok(v) => Ok(Some(v.into())), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 150 - Ok(v) => Ok(Some(v.into())), [INFO] [stdout] 150 + Ok(v) => Ok(Some(v)), [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 150 - Ok(v) => Ok(Some(v.into())), [INFO] [stdout] 150 + Ok(v) => Ok(Some(>::into(v))), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `mzdata::params::CURIE` [INFO] [stdout] --> src/param.rs:181:29 [INFO] [stdout] | [INFO] [stdout] 181 | Ok(v) => Ok(v.into()), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 181 - Ok(v) => Ok(v.into()), [INFO] [stdout] 181 + Ok(v) => Ok(v), [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 181 - Ok(v) => Ok(v.into()), [INFO] [stdout] 181 + Ok(v) => Ok(>::into(v)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `mzdata::params::CURIE` [INFO] [stdout] --> src/param.rs:221:42 [INFO] [stdout] | [INFO] [stdout] 221 | .map(|acc| Unit::from_curie(&(acc.into()))) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 221 - .map(|acc| Unit::from_curie(&(acc.into()))) [INFO] [stdout] 221 + .map(|acc| Unit::from_curie(&(acc)) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 221 - .map(|acc| Unit::from_curie(&(acc.into()))) [INFO] [stdout] 221 + .map(|acc| Unit::from_curie(&(>::into(acc))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `Vec` [INFO] [stdout] --> src/param.rs:1472:42 [INFO] [stdout] | [INFO] [stdout] 1472 | *node.columns.as_mut() = cols.into(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 1472 - *node.columns.as_mut() = cols.into(); [INFO] [stdout] 1472 + *node.columns.as_mut() = cols; [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 1472 - *node.columns.as_mut() = cols.into(); [INFO] [stdout] 1472 + *node.columns.as_mut() = as Into<_>>::into(cols); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `mzdata::params::CURIE` [INFO] [stdout] --> src/spectrum.rs:55:34 [INFO] [stdout] | [INFO] [stdout] 55 | let acc: CURIE = method_param.curie().unwrap().into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 55 - let acc: CURIE = method_param.curie().unwrap().into(); [INFO] [stdout] 55 + let acc: CURIE = method_param.curie().unwrap(); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 55 - let acc: CURIE = method_param.curie().unwrap().into(); [INFO] [stdout] 55 + let acc: CURIE = >::into(method_param.curie().unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `mzdata::params::CURIE` [INFO] [stdout] --> src/spectrum.rs:70:48 [INFO] [stdout] | [INFO] [stdout] 70 | let dtype_acc: mzdata::params::CURIE = self.data_type.into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 70 - let dtype_acc: mzdata::params::CURIE = self.data_type.into(); [INFO] [stdout] 70 + let dtype_acc: mzdata::params::CURIE = self.data_type; [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 70 - let dtype_acc: mzdata::params::CURIE = self.data_type.into(); [INFO] [stdout] 70 + let dtype_acc: mzdata::params::CURIE = >::into(self.data_type); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `Param` [INFO] [stdout] --> src/spectrum.rs:73:27 [INFO] [stdout] | [INFO] [stdout] 73 | let name: Param = self.name.into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 73 - let name: Param = self.name.into(); [INFO] [stdout] 73 + let name: Param = self.name; [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 73 - let name: Param = self.name.into(); [INFO] [stdout] 73 + let name: Param = >::into(self.name); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `mzdata::params::CURIE` [INFO] [stdout] --> src/spectrum.rs:106:27 [INFO] [stdout] | [INFO] [stdout] 106 | let compression = BinaryCompressionType::NoCompression [INFO] [stdout] | ___________________________^ [INFO] [stdout] 107 | | .as_param() [INFO] [stdout] 108 | | .unwrap() [INFO] [stdout] 109 | | .curie() [INFO] [stdout] 110 | | .unwrap() [INFO] [stdout] 111 | | .into(); [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 110 - .unwrap() [INFO] [stdout] 111 - .into(); [INFO] [stdout] 110 + .unwrap(); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 106 ~ let compression = >::into(BinaryCompressionType::NoCompression [INFO] [stdout] 107 | .as_param() [INFO] [stdout] 108 | .unwrap() [INFO] [stdout] 109 | .curie() [INFO] [stdout] 110 ~ .unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `mzdata::params::CURIE` [INFO] [stdout] --> src/spectrum.rs:113:25 [INFO] [stdout] | [INFO] [stdout] 113 | let data_type = source [INFO] [stdout] | _________________________^ [INFO] [stdout] 114 | | .dtype [INFO] [stdout] 115 | | .curie() [INFO] [stdout] 116 | | .ok_or_else(|| mzdata::spectrum::bindata::ArrayRetrievalError::DataTypeSizeMismatch)? [INFO] [stdout] 117 | | .into(); [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 116 - .ok_or_else(|| mzdata::spectrum::bindata::ArrayRetrievalError::DataTypeSizeMismatch)? [INFO] [stdout] 117 - .into(); [INFO] [stdout] 116 + .ok_or_else(|| mzdata::spectrum::bindata::ArrayRetrievalError::DataTypeSizeMismatch)?; [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 113 ~ let data_type = >::into(source [INFO] [stdout] 114 | .dtype [INFO] [stdout] 115 | .curie() [INFO] [stdout] 116 ~ .ok_or_else(|| mzdata::spectrum::bindata::ArrayRetrievalError::DataTypeSizeMismatch)?); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `mzdata::params::CURIE` [INFO] [stdout] --> src/spectrum.rs:119:51 [INFO] [stdout] | [INFO] [stdout] 119 | let unit = source.unit.to_curie().map(|c| c.into()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 119 - let unit = source.unit.to_curie().map(|c| c.into()); [INFO] [stdout] 119 + let unit = source.unit.to_curie().map(|c| c); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 119 - let unit = source.unit.to_curie().map(|c| c.into()); [INFO] [stdout] 119 + let unit = source.unit.to_curie().map(|c| >::into(c)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `Param` [INFO] [stdout] --> src/spectrum.rs:121:20 [INFO] [stdout] | [INFO] [stdout] 121 | let name = source.name.clone().as_param(Some(source.unit)).into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 121 - let name = source.name.clone().as_param(Some(source.unit)).into(); [INFO] [stdout] 121 + let name = source.name.clone().as_param(Some(source.unit)); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 121 - let name = source.name.clone().as_param(Some(source.unit)).into(); [INFO] [stdout] 121 + let name = >::into(source.name.clone().as_param(Some(source.unit))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `parquet::errors::ParquetError` [INFO] [stdout] --> src/reader/metadata.rs:1542:13 [INFO] [stdout] | [INFO] [stdout] 1542 | Err(parquet::errors::ParquetError::ArrowError(format!( [INFO] [stdout] | _____________^ [INFO] [stdout] 1543 | | "Invalid time array data type: {:?}", [INFO] [stdout] 1544 | | time_arr.data_type() [INFO] [stdout] 1545 | | )) [INFO] [stdout] 1546 | | .into()) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 1545 - )) [INFO] [stdout] 1546 - .into()) [INFO] [stdout] 1545 + ))) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 1542 ~ Err(>::into(parquet::errors::ParquetError::ArrowError(format!( [INFO] [stdout] 1543 | "Invalid time array data type: {:?}", [INFO] [stdout] 1544 | time_arr.data_type() [INFO] [stdout] 1545 ~ )))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `parquet::errors::ParquetError` [INFO] [stdout] --> src/reader/metadata.rs:1606:24 [INFO] [stdout] | [INFO] [stdout] 1606 | return Err(parquet::errors::ParquetError::ArrowError(format!( [INFO] [stdout] | ________________________^ [INFO] [stdout] 1607 | | "Invalid selected ion m/z array data type: {:?}", [INFO] [stdout] 1608 | | selected_mz_arr.data_type() [INFO] [stdout] 1609 | | )) [INFO] [stdout] 1610 | | .into()); [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 1609 - )) [INFO] [stdout] 1610 - .into()); [INFO] [stdout] 1609 + ))); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 1606 ~ return Err(>::into(parquet::errors::ParquetError::ArrowError(format!( [INFO] [stdout] 1607 | "Invalid selected ion m/z array data type: {:?}", [INFO] [stdout] 1608 | selected_mz_arr.data_type() [INFO] [stdout] 1609 ~ )))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `reader::utils::MaskSet` [INFO] [stdout] --> src/reader/point.rs:1081:17 [INFO] [stdout] | [INFO] [stdout] 1081 | index_range.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 1081 - index_range.into(), [INFO] [stdout] 1081 + index_range, [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 1081 - index_range.into(), [INFO] [stdout] 1081 + >::into(index_range), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `EntryMetadataDerivedFromData` [INFO] [stdout] --> src/writer/base.rs:1062:68 [INFO] [stdout] | [INFO] [stdout] 1062 | mzdata::spectrum::RefPeakDataLevel::Centroid(_) => self [INFO] [stdout] | ____________________________________________________________________^ [INFO] [stdout] 1063 | | .get_or_create_spectrum_peak_writer()? [INFO] [stdout] 1064 | | .write_peaks(spectrum_index, spectrum_time, peaks)? [INFO] [stdout] 1065 | | .into(), [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 1064 - .write_peaks(spectrum_index, spectrum_time, peaks)? [INFO] [stdout] 1065 - .into(), [INFO] [stdout] 1064 + .write_peaks(spectrum_index, spectrum_time, peaks)?, [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 1062 ~ mzdata::spectrum::RefPeakDataLevel::Centroid(_) => >::into(self [INFO] [stdout] 1063 | .get_or_create_spectrum_peak_writer()? [INFO] [stdout] 1064 ~ .write_peaks(spectrum_index, spectrum_time, peaks)?), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `EntryMetadataDerivedFromData` [INFO] [stdout] --> src/writer/base.rs:1066:72 [INFO] [stdout] | [INFO] [stdout] 1066 | mzdata::spectrum::RefPeakDataLevel::Deconvoluted(_) => self [INFO] [stdout] | ________________________________________________________________________^ [INFO] [stdout] 1067 | | .get_or_create_spectrum_peak_writer()? [INFO] [stdout] 1068 | | .write_peaks(spectrum_index, spectrum_time, peaks)? [INFO] [stdout] 1069 | | .into(), [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 1068 - .write_peaks(spectrum_index, spectrum_time, peaks)? [INFO] [stdout] 1069 - .into(), [INFO] [stdout] 1068 + .write_peaks(spectrum_index, spectrum_time, peaks)?, [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 1066 ~ mzdata::spectrum::RefPeakDataLevel::Deconvoluted(_) => >::into(self [INFO] [stdout] 1067 | .get_or_create_spectrum_peak_writer()? [INFO] [stdout] 1068 ~ .write_peaks(spectrum_index, spectrum_time, peaks)?), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mzpeak_prototyping` (lib test) due to 17 previous errors [INFO] running `Command { std: "docker" "inspect" "fb7618b431dc6d938cdc5793249899b092c8ec15fb53dc7356f9dec1b16d9361", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fb7618b431dc6d938cdc5793249899b092c8ec15fb53dc7356f9dec1b16d9361", kill_on_drop: false }` [INFO] [stdout] fb7618b431dc6d938cdc5793249899b092c8ec15fb53dc7356f9dec1b16d9361