[INFO] cloning repository https://github.com/marot/toy-payment-engine [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/marot/toy-payment-engine" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmarot%2Ftoy-payment-engine", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmarot%2Ftoy-payment-engine'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] da156a402a9588ca978da9a402d6eca1331ee1af [INFO] checking marot/toy-payment-engine against a5689b034ad287112f709693384a37f1377eb9cc for pr-129249-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmarot%2Ftoy-payment-engine" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/marot/toy-payment-engine [INFO] finished tweaking git repo https://github.com/marot/toy-payment-engine [INFO] tweaked toml for git repo https://github.com/marot/toy-payment-engine written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/marot/toy-payment-engine on toolchain a5689b034ad287112f709693384a37f1377eb9cc [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/marot/toy-payment-engine already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:77db811e55d90add9212f6832c23229e3de5f1c1f9905e8cb07319ea15df73ac" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] c7a55c03fd0bd0343df01732c0cf931c29c8c14aa9628c995e1ac49cb5ac59d2 [INFO] running `Command { std: "docker" "start" "c7a55c03fd0bd0343df01732c0cf931c29c8c14aa9628c995e1ac49cb5ac59d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c7a55c03fd0bd0343df01732c0cf931c29c8c14aa9628c995e1ac49cb5ac59d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "c7a55c03fd0bd0343df01732c0cf931c29c8c14aa9628c995e1ac49cb5ac59d2" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c7a55c03fd0bd0343df01732c0cf931c29c8c14aa9628c995e1ac49cb5ac59d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "c7a55c03fd0bd0343df01732c0cf931c29c8c14aa9628c995e1ac49cb5ac59d2" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.112 [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.85 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling serde_derive v1.0.133 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling parking_lot_core v0.8.5 [INFO] [stderr] Compiling serde v1.0.133 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking smallvec v1.7.0 [INFO] [stderr] Checking lock_api v0.4.5 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking once_cell v1.9.0 [INFO] [stderr] Checking pin-project-lite v0.2.8 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Compiling quote v1.0.14 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking mio v0.7.14 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Checking tokio v1.15.0 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking csv v1.1.6 (/opt/rustwide/workdir/csv-1.1.6) [INFO] [stdout] error: useless conversion to the same type: `&str` [INFO] [stdout] --> csv-1.1.6/src/deserializer.rs:434:58 [INFO] [stdout] | [INFO] [stdout] 434 | self.next_field().and_then(|f| visitor.visit_str(f.into())) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 434 - self.next_field().and_then(|f| visitor.visit_str(f.into())) [INFO] [stdout] 434 + self.next_field().and_then(|f| visitor.visit_str(f)) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 434 - self.next_field().and_then(|f| visitor.visit_str(f.into())) [INFO] [stdout] 434 + self.next_field().and_then(|f| visitor.visit_str(<&str as Into<_>>::into(f))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> csv-1.1.6/src/byte_record.rs:251:17 [INFO] [stdout] | [INFO] [stdout] 251 | pub fn iter(&self) -> ByteRecordIter { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 251 | pub fn iter(&self) -> ByteRecordIter<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> csv-1.1.6/src/reader.rs:1051:27 [INFO] [stdout] | [INFO] [stdout] 1051 | pub fn deserialize(&mut self) -> DeserializeRecordsIter [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 1051 | pub fn deserialize(&mut self) -> DeserializeRecordsIter<'_, R, D> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> csv-1.1.6/src/reader.rs:1154:20 [INFO] [stdout] | [INFO] [stdout] 1154 | pub fn records(&mut self) -> StringRecordsIter { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 1154 | pub fn records(&mut self) -> StringRecordsIter<'_, R> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> csv-1.1.6/src/reader.rs:1231:25 [INFO] [stdout] | [INFO] [stdout] 1231 | pub fn byte_records(&mut self) -> ByteRecordsIter { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 1231 | pub fn byte_records(&mut self) -> ByteRecordsIter<'_, R> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> csv-1.1.6/src/string_record.rs:314:17 [INFO] [stdout] | [INFO] [stdout] 314 | pub fn iter(&self) -> StringRecordIter { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 314 | pub fn iter(&self) -> StringRecordIter<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `csv` (lib) due to 1 previous error; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c7a55c03fd0bd0343df01732c0cf931c29c8c14aa9628c995e1ac49cb5ac59d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c7a55c03fd0bd0343df01732c0cf931c29c8c14aa9628c995e1ac49cb5ac59d2", kill_on_drop: false }` [INFO] [stdout] c7a55c03fd0bd0343df01732c0cf931c29c8c14aa9628c995e1ac49cb5ac59d2