[INFO] cloning repository https://github.com/amirbou/testio [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/amirbou/testio" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Famirbou%2Ftestio", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Famirbou%2Ftestio'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 382e40227633f5b24307ac009f46869bdde859c8 [INFO] checking amirbou/testio against a5689b034ad287112f709693384a37f1377eb9cc for pr-129249-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Famirbou%2Ftestio" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/amirbou/testio [INFO] finished tweaking git repo https://github.com/amirbou/testio [INFO] tweaked toml for git repo https://github.com/amirbou/testio written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/amirbou/testio on toolchain a5689b034ad287112f709693384a37f1377eb9cc [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/amirbou/testio already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:77db811e55d90add9212f6832c23229e3de5f1c1f9905e8cb07319ea15df73ac" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] e31e22a71acdaa961e645e1d86b68a63e7a212a8e709331fdd633731bdd84575 [INFO] running `Command { std: "docker" "start" "e31e22a71acdaa961e645e1d86b68a63e7a212a8e709331fdd633731bdd84575", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e31e22a71acdaa961e645e1d86b68a63e7a212a8e709331fdd633731bdd84575", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "e31e22a71acdaa961e645e1d86b68a63e7a212a8e709331fdd633731bdd84575" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e31e22a71acdaa961e645e1d86b68a63e7a212a8e709331fdd633731bdd84575", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "e31e22a71acdaa961e645e1d86b68a63e7a212a8e709331fdd633731bdd84575" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling libc v0.2.119 [INFO] [stderr] Compiling syn v1.0.86 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling pkg-config v0.3.24 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling indexmap v1.8.0 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking smallvec v1.8.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Compiling quote v1.0.15 [INFO] [stderr] Compiling fuser v0.10.0 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking users v0.11.0 [INFO] [stderr] Checking page_size v0.4.2 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Compiling dlopen_derive v0.1.4 [INFO] [stderr] Checking dlopen v0.1.8 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Compiling clap_derive v3.1.7 [INFO] [stderr] Compiling zerocopy-derive v0.3.1 [INFO] [stderr] Checking zerocopy v0.5.0 [INFO] [stderr] Checking clap v3.1.5 [INFO] [stderr] Checking testio v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: useless conversion to the same type: `&str` [INFO] [stdout] --> src/bin/testio.rs:15:31 [INFO] [stdout] | [INFO] [stdout] 15 | let data = name.clone() + "\n".into(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 15 - let data = name.clone() + "\n".into(); [INFO] [stdout] 15 + let data = name.clone() + "\n"; [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 15 - let data = name.clone() + "\n".into(); [INFO] [stdout] 15 + let data = name.clone() + <&str as Into<_>>::into("\n"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `&str` [INFO] [stdout] --> src/bin/testio.rs:15:31 [INFO] [stdout] | [INFO] [stdout] 15 | let data = name.clone() + "\n".into(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 15 - let data = name.clone() + "\n".into(); [INFO] [stdout] 15 + let data = name.clone() + "\n"; [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 15 - let data = name.clone() + "\n".into(); [INFO] [stdout] 15 + let data = name.clone() + <&str as Into<_>>::into("\n"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/bin/testio.rs:16:47 [INFO] [stdout] | [INFO] [stdout] 16 | files.push(Box::new(PrepopulatedFile::new(name.into(), data))); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 16 - files.push(Box::new(PrepopulatedFile::new(name.into(), data))); [INFO] [stdout] 16 + files.push(Box::new(PrepopulatedFile::new(name, data))); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 16 - files.push(Box::new(PrepopulatedFile::new(name.into(), data))); [INFO] [stdout] 16 + files.push(Box::new(PrepopulatedFile::new(>::into(name), data))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/bin/testio.rs:16:47 [INFO] [stdout] | [INFO] [stdout] 16 | files.push(Box::new(PrepopulatedFile::new(name.into(), data))); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 16 - files.push(Box::new(PrepopulatedFile::new(name.into(), data))); [INFO] [stdout] 16 + files.push(Box::new(PrepopulatedFile::new(name, data))); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 16 - files.push(Box::new(PrepopulatedFile::new(name.into(), data))); [INFO] [stdout] 16 + files.push(Box::new(PrepopulatedFile::new(>::into(name), data))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `testio` (bin "testio") due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `testio` (bin "testio" test) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "e31e22a71acdaa961e645e1d86b68a63e7a212a8e709331fdd633731bdd84575", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e31e22a71acdaa961e645e1d86b68a63e7a212a8e709331fdd633731bdd84575", kill_on_drop: false }` [INFO] [stdout] e31e22a71acdaa961e645e1d86b68a63e7a212a8e709331fdd633731bdd84575