[INFO] cloning repository https://github.com/aamathews23/battleship-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/aamathews23/battleship-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faamathews23%2Fbattleship-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faamathews23%2Fbattleship-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2e6528a81ba13b737fa7bc039e33604510ca5cb3 [INFO] checking aamathews23/battleship-rs against a5689b034ad287112f709693384a37f1377eb9cc for pr-129249-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faamathews23%2Fbattleship-rs" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/aamathews23/battleship-rs [INFO] finished tweaking git repo https://github.com/aamathews23/battleship-rs [INFO] tweaked toml for git repo https://github.com/aamathews23/battleship-rs written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/aamathews23/battleship-rs on toolchain a5689b034ad287112f709693384a37f1377eb9cc [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/aamathews23/battleship-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: Cargo.toml: unused manifest key: workspace.package.name [INFO] [stderr] warning: unused field `name` in `workspace.package` [INFO] [stderr] --> Cargo.toml:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | name = "battleship-rs" [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `cargo::unused_workspace_package_fields` is set to `warn` by default [INFO] [stderr] help: consider removing the field `workspace.package.name` [INFO] [stderr] warning: unused field `readme` in `workspace.package` [INFO] [stderr] --> Cargo.toml:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | readme = "README.md" [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] help: consider removing the field `workspace.package.readme` [INFO] [stderr] warning: workspace (manifest) generated 3 warnings [INFO] [stderr] warning: `package.homepage` is redundant with `package.repository` [INFO] [stderr] --> battleship/Cargo.toml:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | homepage.workspace = true [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] 8 | repository.workspace = true [INFO] [stderr] | ---------- [INFO] [stderr] | [INFO] [stderr] = note: `cargo::redundant_homepage` is set to `warn` by default [INFO] [stderr] help: consider removing `package.homepage` [INFO] [stderr] warning: `battleship` (manifest) generated 1 warning [INFO] [stderr] warning: `package.homepage` is redundant with `package.repository` [INFO] [stderr] --> battleship_cli/Cargo.toml:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | homepage.workspace = true [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] 8 | repository.workspace = true [INFO] [stderr] | ---------- [INFO] [stderr] | [INFO] [stderr] = note: `cargo::redundant_homepage` is set to `warn` by default [INFO] [stderr] help: consider removing `package.homepage` [INFO] [stderr] warning: `battleship_cli` (manifest) generated 1 warning [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:77db811e55d90add9212f6832c23229e3de5f1c1f9905e8cb07319ea15df73ac" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] fbec7109afb4d82675e61596798e9540a63800d56beaa49bf78cbe3017b5f203 [INFO] running `Command { std: "docker" "start" "fbec7109afb4d82675e61596798e9540a63800d56beaa49bf78cbe3017b5f203", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fbec7109afb4d82675e61596798e9540a63800d56beaa49bf78cbe3017b5f203", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "fbec7109afb4d82675e61596798e9540a63800d56beaa49bf78cbe3017b5f203" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fbec7109afb4d82675e61596798e9540a63800d56beaa49bf78cbe3017b5f203", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "fbec7109afb4d82675e61596798e9540a63800d56beaa49bf78cbe3017b5f203" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stderr] warning: Cargo.toml: unused manifest key: workspace.package.name [INFO] [stderr] warning: unused field `name` in `workspace.package` [INFO] [stderr] --> Cargo.toml:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | name = "battleship-rs" [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `cargo::unused_workspace_package_fields` is set to `warn` by default [INFO] [stderr] help: consider removing the field `workspace.package.name` [INFO] [stderr] warning: unused field `readme` in `workspace.package` [INFO] [stderr] --> Cargo.toml:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | readme = "README.md" [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] help: consider removing the field `workspace.package.readme` [INFO] [stderr] warning: workspace (manifest) generated 3 warnings [INFO] [stderr] warning: `package.homepage` is redundant with `package.repository` [INFO] [stderr] --> battleship_cli/Cargo.toml:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | homepage.workspace = true [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] 8 | repository.workspace = true [INFO] [stderr] | ---------- [INFO] [stderr] | [INFO] [stderr] = note: `cargo::redundant_homepage` is set to `warn` by default [INFO] [stderr] help: consider removing `package.homepage` [INFO] [stderr] warning: `battleship_cli` (manifest) generated 1 warning [INFO] [stderr] warning: `package.homepage` is redundant with `package.repository` [INFO] [stderr] --> battleship/Cargo.toml:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | homepage.workspace = true [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] 8 | repository.workspace = true [INFO] [stderr] | ---------- [INFO] [stderr] | [INFO] [stderr] = note: `cargo::redundant_homepage` is set to `warn` by default [INFO] [stderr] help: consider removing `package.homepage` [INFO] [stderr] warning: `battleship` (manifest) generated 1 warning [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling mockall_derive v0.13.0 [INFO] [stderr] Checking predicates-core v1.0.8 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking anstyle v1.0.10 [INFO] [stderr] Checking downcast v0.11.0 [INFO] [stderr] Checking fragile v2.0.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking regex-syntax v0.8.5 [INFO] [stderr] Checking predicates-tree v1.0.11 [INFO] [stderr] Checking dotenv v0.15.0 [INFO] [stderr] Checking predicates v3.1.2 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking regex-automata v0.4.8 [INFO] [stderr] Checking regex v1.11.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking mockall v0.13.0 [INFO] [stderr] Checking battleship v0.1.0 (/opt/rustwide/workdir/battleship) [INFO] [stdout] warning: use of deprecated module `std::usize`: all constants in this module replaced by associated constants on the type [INFO] [stdout] --> battleship/src/board.rs:1:10 [INFO] [stdout] | [INFO] [stdout] 1 | use std::usize; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::usize::MAX`: replaced by the `MAX` associated constant on this type [INFO] [stdout] --> battleship/src/board.rs:32:48 [INFO] [stdout] | [INFO] [stdout] 32 | let cell = Cell::new(0, usize::MAX); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated module `std::usize`: all constants in this module replaced by associated constants on the type [INFO] [stdout] --> battleship/src/board.rs:1:10 [INFO] [stdout] | [INFO] [stdout] 1 | use std::usize; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::usize::MAX`: replaced by the `MAX` associated constant on this type [INFO] [stdout] --> battleship/src/board.rs:32:48 [INFO] [stdout] | [INFO] [stdout] 32 | let cell = Cell::new(0, usize::MAX); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `i32` [INFO] [stdout] --> battleship/src/board.rs:40:34 [INFO] [stdout] | [INFO] [stdout] 40 | let ship_size: i32 = ship.size.into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 40 - let ship_size: i32 = ship.size.into(); [INFO] [stdout] 40 + let ship_size: i32 = ship.size; [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 40 - let ship_size: i32 = ship.size.into(); [INFO] [stdout] 40 + let ship_size: i32 = >::into(ship.size); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `i32` [INFO] [stdout] --> battleship/src/ship.rs:18:21 [INFO] [stdout] | [INFO] [stdout] 18 | health: size.into() [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 18 - health: size.into() [INFO] [stdout] 18 + health: size [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 18 - health: size.into() [INFO] [stdout] 18 + health: >::into(size) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `battleship` (lib) due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: useless conversion to the same type: `i32` [INFO] [stdout] --> battleship/src/board.rs:40:34 [INFO] [stdout] | [INFO] [stdout] 40 | let ship_size: i32 = ship.size.into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 40 - let ship_size: i32 = ship.size.into(); [INFO] [stdout] 40 + let ship_size: i32 = ship.size; [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 40 - let ship_size: i32 = ship.size.into(); [INFO] [stdout] 40 + let ship_size: i32 = >::into(ship.size); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `i32` [INFO] [stdout] --> battleship/src/ship.rs:18:21 [INFO] [stdout] | [INFO] [stdout] 18 | health: size.into() [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 18 - health: size.into() [INFO] [stdout] 18 + health: size [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 18 - health: size.into() [INFO] [stdout] 18 + health: >::into(size) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `battleship` (lib test) due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "fbec7109afb4d82675e61596798e9540a63800d56beaa49bf78cbe3017b5f203", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fbec7109afb4d82675e61596798e9540a63800d56beaa49bf78cbe3017b5f203", kill_on_drop: false }` [INFO] [stdout] fbec7109afb4d82675e61596798e9540a63800d56beaa49bf78cbe3017b5f203