[INFO] cloning repository https://github.com/Zapix/leetcode-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Zapix/leetcode-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FZapix%2Fleetcode-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FZapix%2Fleetcode-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d75a70405ecb4306869f1fa4852d562c818e829e [INFO] checking Zapix/leetcode-rust against a5689b034ad287112f709693384a37f1377eb9cc for pr-129249-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FZapix%2Fleetcode-rust" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Zapix/leetcode-rust [INFO] finished tweaking git repo https://github.com/Zapix/leetcode-rust [INFO] tweaked toml for git repo https://github.com/Zapix/leetcode-rust written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Zapix/leetcode-rust on toolchain a5689b034ad287112f709693384a37f1377eb9cc [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Zapix/leetcode-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:77db811e55d90add9212f6832c23229e3de5f1c1f9905e8cb07319ea15df73ac" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] eb03ede3850875914e78c542c25aadd28c42e011309f88251b1260bf37f0ec20 [INFO] running `Command { std: "docker" "start" "eb03ede3850875914e78c542c25aadd28c42e011309f88251b1260bf37f0ec20", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "eb03ede3850875914e78c542c25aadd28c42e011309f88251b1260bf37f0ec20", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "eb03ede3850875914e78c542c25aadd28c42e011309f88251b1260bf37f0ec20" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "eb03ede3850875914e78c542c25aadd28c42e011309f88251b1260bf37f0ec20", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "eb03ede3850875914e78c542c25aadd28c42e011309f88251b1260bf37f0ec20" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stderr] Checking leetcode v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/problems/maximum_frequency_after_performing_operations_1.rs:16:20 [INFO] [stdout] | [INFO] [stdout] 16 | for num in (*nums.first().unwrap_or(&0)..(*nums.last().unwrap_or(&0) + 1)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 16 - for num in (*nums.first().unwrap_or(&0)..(*nums.last().unwrap_or(&0) + 1)) { [INFO] [stdout] 16 + for num in *nums.first().unwrap_or(&0)..(*nums.last().unwrap_or(&0) + 1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around closure body [INFO] [stdout] --> src/problems/maximum_number_of_events_that_can_be_attended_ii.rs:18:52 [INFO] [stdout] | [INFO] [stdout] 18 | let j = events.partition_point(|e| (e[0] <= events[x][1])); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 18 - let j = events.partition_point(|e| (e[0] <= events[x][1])); [INFO] [stdout] 18 + let j = events.partition_point(|e| e[0] <= events[x][1]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around method argument [INFO] [stdout] --> src/problems/sum_of_k_mirror_numbers.rs:31:42 [INFO] [stdout] | [INFO] [stdout] 31 | if self.num >= self.base.pow((self.length as u32)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 31 - if self.num >= self.base.pow((self.length as u32)) { [INFO] [stdout] 31 + if self.num >= self.base.pow(self.length as u32) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around closure body [INFO] [stdout] --> src/problems/take_gifts_from_the_richest_pile.rs:13:29 [INFO] [stdout] | [INFO] [stdout] 13 | heap.iter().map(|x| (*x as i64)).sum() [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 13 - heap.iter().map(|x| (*x as i64)).sum() [INFO] [stdout] 13 + heap.iter().map(|x| *x as i64).sum() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/problems/maximum_frequency_after_performing_operations_1.rs:16:20 [INFO] [stdout] | [INFO] [stdout] 16 | for num in (*nums.first().unwrap_or(&0)..(*nums.last().unwrap_or(&0) + 1)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 16 - for num in (*nums.first().unwrap_or(&0)..(*nums.last().unwrap_or(&0) + 1)) { [INFO] [stdout] 16 + for num in *nums.first().unwrap_or(&0)..(*nums.last().unwrap_or(&0) + 1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around closure body [INFO] [stdout] --> src/problems/maximum_number_of_events_that_can_be_attended_ii.rs:18:52 [INFO] [stdout] | [INFO] [stdout] 18 | let j = events.partition_point(|e| (e[0] <= events[x][1])); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 18 - let j = events.partition_point(|e| (e[0] <= events[x][1])); [INFO] [stdout] 18 + let j = events.partition_point(|e| e[0] <= events[x][1]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around method argument [INFO] [stdout] --> src/problems/sum_of_k_mirror_numbers.rs:31:42 [INFO] [stdout] | [INFO] [stdout] 31 | if self.num >= self.base.pow((self.length as u32)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 31 - if self.num >= self.base.pow((self.length as u32)) { [INFO] [stdout] 31 + if self.num >= self.base.pow(self.length as u32) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around closure body [INFO] [stdout] --> src/problems/take_gifts_from_the_richest_pile.rs:13:29 [INFO] [stdout] | [INFO] [stdout] 13 | heap.iter().map(|x| (*x as i64)).sum() [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 13 - heap.iter().map(|x| (*x as i64)).sum() [INFO] [stdout] 13 + heap.iter().map(|x| *x as i64).sum() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/problems/find_the_k_th_character_in_string_game_ii.rs:4:26 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn kth_character(mut k: i64, mut operations: Vec) -> char { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/problems/longest_harmonious_subsequence.rs:5:21 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn find_lhs(mut nums: Vec) -> i32 { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/problems/maximum_number_of_distinct_elements_after_operations.rs:7:13 [INFO] [stdout] | [INFO] [stdout] 7 | let mut freq_map = nums.iter().fold(BTreeMap::new(), |mut acc, &num| { [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/problems/maximum_number_of_events_that_can_be_attended.rs:9:13 [INFO] [stdout] | [INFO] [stdout] 9 | let mut max_day = events.iter().map(|x| x[1]).max().unwrap_or(0); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/problems/ones_and_zeros.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | let mut values = strs [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `c` [INFO] [stdout] --> src/problems/power_grid_maintenance.rs:5:24 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn build_graph(c: usize, connections: &Vec>) -> HashMap> { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_c` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/problems/power_grid_maintenance.rs:61:29 [INFO] [stdout] | [INFO] [stdout] 61 | let mut value = match groups[group_idx].first(){ [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `&HashMap` [INFO] [stdout] --> src/problems/number_of_ways_to_arrive_at_destination.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | self.data.get(&x).unwrap().into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 37 - self.data.get(&x).unwrap().into() [INFO] [stdout] 37 + self.data.get(&x).unwrap() [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 37 - self.data.get(&x).unwrap().into() [INFO] [stdout] 37 + <&HashMap as Into<_>>::into(self.data.get(&x).unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `leetcode` (bin "leetcode") due to 1 previous error; 11 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/problems/find_the_k_th_character_in_string_game_ii.rs:4:26 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn kth_character(mut k: i64, mut operations: Vec) -> char { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/problems/longest_harmonious_subsequence.rs:5:21 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn find_lhs(mut nums: Vec) -> i32 { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/problems/maximum_number_of_distinct_elements_after_operations.rs:7:13 [INFO] [stdout] | [INFO] [stdout] 7 | let mut freq_map = nums.iter().fold(BTreeMap::new(), |mut acc, &num| { [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/problems/maximum_number_of_events_that_can_be_attended.rs:9:13 [INFO] [stdout] | [INFO] [stdout] 9 | let mut max_day = events.iter().map(|x| x[1]).max().unwrap_or(0); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/problems/ones_and_zeros.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | let mut values = strs [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `c` [INFO] [stdout] --> src/problems/power_grid_maintenance.rs:5:24 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn build_graph(c: usize, connections: &Vec>) -> HashMap> { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_c` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/problems/power_grid_maintenance.rs:61:29 [INFO] [stdout] | [INFO] [stdout] 61 | let mut value = match groups[group_idx].first(){ [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `&HashMap` [INFO] [stdout] --> src/problems/number_of_ways_to_arrive_at_destination.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | self.data.get(&x).unwrap().into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 37 - self.data.get(&x).unwrap().into() [INFO] [stdout] 37 + self.data.get(&x).unwrap() [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 37 - self.data.get(&x).unwrap().into() [INFO] [stdout] 37 + <&HashMap as Into<_>>::into(self.data.get(&x).unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `leetcode` (bin "leetcode" test) due to 1 previous error; 11 warnings emitted [INFO] running `Command { std: "docker" "inspect" "eb03ede3850875914e78c542c25aadd28c42e011309f88251b1260bf37f0ec20", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eb03ede3850875914e78c542c25aadd28c42e011309f88251b1260bf37f0ec20", kill_on_drop: false }` [INFO] [stdout] eb03ede3850875914e78c542c25aadd28c42e011309f88251b1260bf37f0ec20